maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/Object/invalid.test

88 lines
3.8 KiB
Plaintext
Raw Normal View History

Convert an assert that can fail into error checking. llvm-svn: 240944
2015-06-29 22:02:24 +08:00
RUN: not llvm-objdump -s %p/Inputs/invalid-strtab-type.elf 2>&1 | FileCheck %s
Factor out the checking of string tables. This moves the error checking for string tables to getStringTable which returns an ErrorOr<StringRef>. This improves error checking, makes it uniform across all string tables and makes it possible to check them once instead of once per name. llvm-svn: 240950
2015-06-29 22:39:25 +08:00
RUN: not llvm-objdump -s %p/Inputs/invalid-strtab-size.elf 2>&1 | FileCheck %s
[Object/ELF] - Do not crash if string table sh_size is equal to zero. Revealed using "id_000038,sig_11,src_000015,op_havoc,rep_16" from PR30540, when sh_size was 0, crash happened. Differential revision: https://reviews.llvm.org/D25091 llvm-svn: 285282
2016-10-27 19:41:57 +08:00
RUN: not llvm-objdump -s %p/Inputs/invalid-strtab-zero-size.elf 2>&1 | FileCheck %s
Improve error handling of getRelocationAddend. This patch changes getRelocationAddend to use ErrorOr and considers it an error to try to get the addend of a REL section. If, for example, a x86_64 file has a REL section, that file is corrupted and we should reject it. Using ErrorOr is not ideal since we check the section type once per relocation instead of once per section. Checking once per section would involve getRelocationAddend just asserting and callers checking the section before iterating over the relocations. In any case, this is an improvement and includes a test. llvm-svn: 240176
2015-06-20 04:58:43 +08:00
CHECK: Invalid data was encountered while parsing the file
Add a testcase for an invalid file. We were already checking this, but had no tests. llvm-svn: 240945
2015-06-29 22:12:14 +08:00
Convert an ErrorOr to Expected. getRelocationAddend should never be called on non SHT_RELA sections, but changing that requires changing RelocVisitor.h. llvm-svn: 315473
2017-10-12 00:56:33 +08:00
RUN: not llvm-dwarfdump %p/Inputs/invalid-bad-rel-type.elf 2>&1 | FileCheck --check-prefix=RELA %s
RELA: Section is not SHT_RELA
Add a testcase for an invalid file. We were already checking this, but had no tests. llvm-svn: 240945
2015-06-29 22:12:14 +08:00
RUN: not llvm-objdump -s %p/Inputs/invalid-strtab-non-null.elf 2>&1 | FileCheck --check-prefix=NON-NULL %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
NON-NULL: Invalid data was encountered while parsing the file
Report an error on invalid sh_entsize. llvm-svn: 241070
2015-06-30 22:59:20 +08:00
Test the sh_entsize are invalid
RUN: llvm-readobj -s %p/Inputs/invalid-sh_entsize.elf | FileCheck --check-prefix=SECTION %s
SECTION: Name: .dynsym
SECTION-NEXT: Type: SHT_DYNSYM
SECTION-NEXT: Flags [
SECTION-NEXT: SHF_ALLOC
SECTION-NEXT: ]
SECTION-NEXT: Address:
SECTION-NEXT: Offset:
SECTION-NEXT: Size:
SECTION-NEXT: Link:
SECTION-NEXT: Info:
SECTION-NEXT: AddressAlignment:
SECTION-NEXT: EntrySize: 32
SECTION: Name: .symtab
SECTION-NEXT: Type: SHT_SYMTAB
SECTION-NEXT: Flags [
SECTION-NEXT: ]
SECTION-NEXT: Address:
SECTION-NEXT: Offset:
SECTION-NEXT: Size:
SECTION-NEXT: Link:
SECTION-NEXT: Info:
SECTION-NEXT: AddressAlignment:
SECTION-NEXT: EntrySize: 32
RUN: not llvm-readobj -t %p/Inputs/invalid-sh_entsize.elf 2>&1 | FileCheck --check-prefix=INVALID-SYM-SIZE %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-SYM-SIZE: invalid sh_entsize
Add a test of an elf file with an invalid section index. We were already checking, but were missing a test. llvm-svn: 241094
2015-07-01 02:23:07 +08:00
Change how readobj stores info about dynamic symbols. We used to keep both a section and a pointer to the first symbol. The oddity of keeping a section for dynamic symbols is because there is a DT_SYMTAB but no DT_SYMTABZ, so to print the table we have to find the size via a section table. The reason for still keeping a pointer to the first symbol is because we want to be able to print relocation tables even if the section table is missing (it is mandatory only for files used in linking). With this patch we keep just a DynRegionInfo. This then requires changing a few places that were asking for a Elf_Shdr but actually just needed the first symbol. The test change is to delete the program header pointer. Now that we use the information of both DT_SYMTAB and .dynsym, we don't depend on the sh_entsize of .dynsym if we see DT_SYMTAB. Note: It is questionable if it is worth it putting the effort to report broken sh_entsize given that in files with no section table we have to assume it is sizeof(Elf_Sym), but that is for another change. Extracted from r260488. llvm-svn: 261099
2016-02-17 23:38:21 +08:00
RUN: not llvm-readobj --dyn-symbols %p/Inputs/invalid-sh_entsize.elf 2>&1 | FileCheck --check-prefix=INVALID-DYNSYM-SIZE %s
INVALID-DYNSYM-SIZE: Invalid entity size
Add a test of an elf file with an invalid section index. We were already checking, but were missing a test. llvm-svn: 241094
2015-07-01 02:23:07 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-section-index.elf 2>&1 | FileCheck --check-prefix=INVALID-SECTION-INDEX %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-SECTION-INDEX: invalid section index
Remove Elf_Shdr_Iter. Diagnose files with invalid section header sizes. llvm-svn: 241109
2015-07-01 03:58:10 +08:00
RUN: not llvm-readobj -s %p/Inputs/invalid-section-size.elf 2>&1 | FileCheck --check-prefix=INVALID-SECTION-SIZE %s
Make the ELFObjectFile constructor private. This forces every user to use the new create method that returns an Expected. This in turn propagates better error messages. llvm-svn: 315371
2017-10-11 05:21:16 +08:00
INVALID-SECTION-SIZE: invalid section header entry size (e_shentsize) in ELF header
Refactor duplicated code and check for invalid symbol table size. llvm-svn: 242981
2015-07-23 11:24:22 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-symbol-table-size.elf 2>&1 | FileCheck --check-prefix=INVALID-SYMTAB-SIZE %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-SYMTAB-SIZE: size is not a multiple of sh_entsize
Report an error if a SHT_SYMTAB_SHNDX section has the wrong size. llvm-svn: 245873
2015-08-25 05:09:41 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-xindex-size.elf 2>&1 | FileCheck --check-prefix=INVALID-XINDEX-SIZE %s
Make the ELFObjectFile constructor private. This forces every user to use the new create method that returns an Expected. This in turn propagates better error messages. llvm-svn: 315371
2017-10-11 05:21:16 +08:00
INVALID-XINDEX-SIZE: invalid section contents size
[Object/ELF] - Avoid possible crash in getExtendedSymbolTableIndex(). When using broken input object found using AFL, getExtendedSymbolTableIndex() crashed because ShndxTable was empty as object does not contain SHT_SYMTAB_SHNDX section. Differential revision: https://reviews.llvm.org/D25189 llvm-svn: 283196
2016-10-04 16:44:03 +08:00
Recommit r284371 "[Object/ELF] - Check that e_shnum is null when e_shoff is." With fix: hex edited the precompiled inputs from another testcases to pass new checks. Original commit message: [Object/ELF] - Check that e_shnum is null when e_shoff is. Spec says (http://www.sco.com/developers/gabi/1998-04-29/ch4.eheader.html) : e_shnum This member holds the number of entries in the section header table. Thus the product of e_shentsize and e_shnum gives the section header table's size in bytes. If a file has no section header table, e_shnum holds the value zero. Revealed using "id_000037,sig_11,src_000015,op_havoc,rep_8" from PR30540 That was the reason of crash in lld on incorrect input file. Binary reduced using afl-min. Differential revision: https://reviews.llvm.org/D25090 llvm-svn: 284374
2016-10-17 18:58:02 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-e_shnum.elf 2>&1 | FileCheck --check-prefix=INVALID-SH-NUM %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-SH-NUM: invalid e_phentsize
Recommit r284371 "[Object/ELF] - Check that e_shnum is null when e_shoff is." With fix: hex edited the precompiled inputs from another testcases to pass new checks. Original commit message: [Object/ELF] - Check that e_shnum is null when e_shoff is. Spec says (http://www.sco.com/developers/gabi/1998-04-29/ch4.eheader.html) : e_shnum This member holds the number of entries in the section header table. Thus the product of e_shentsize and e_shnum gives the section header table's size in bytes. If a file has no section header table, e_shnum holds the value zero. Revealed using "id_000037,sig_11,src_000015,op_havoc,rep_8" from PR30540 That was the reason of crash in lld on incorrect input file. Binary reduced using afl-min. Differential revision: https://reviews.llvm.org/D25090 llvm-svn: 284374
2016-10-17 18:58:02 +08:00
[Object/ELF] - Avoid possible crash in getExtendedSymbolTableIndex(). When using broken input object found using AFL, getExtendedSymbolTableIndex() crashed because ShndxTable was empty as object does not contain SHT_SYMTAB_SHNDX section. Differential revision: https://reviews.llvm.org/D25189 llvm-svn: 283196
2016-10-04 16:44:03 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-ext-symtab-index.elf-x86-64 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-EXT-SYMTAB-INDEX %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-EXT-SYMTAB-INDEX: index past the end of the symbol table
[Object/ELF] - Do not crash on invalid sh_offset value of REL[A] section. Previously code would access invalid memory and may crash, patch fixes the issue. Differential revision: https://reviews.llvm.org/D25187 llvm-svn: 283204
2016-10-04 17:25:39 +08:00
RUN: not llvm-readobj -r %p/Inputs/invalid-relocation-sec-sh_offset.elf-i386 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-RELOC-SH-OFFSET %s
RUN: not llvm-readobj -r %p/Inputs/invalid-relocation-sec-sh_offset.elf-x86-64 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-RELOC-SH-OFFSET %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-RELOC-SH-OFFSET: invalid section offset
[Object/ELF] - Check Header->e_shoff value earlier and do not crash. Patch checks that section pointer is aligned properly. This should be done before getStringTable() call. Differential revision: https://reviews.llvm.org/D25462 llvm-svn: 284387
2016-10-17 22:28:12 +08:00
[Object/ELF] - Do not allow overflow when checking section size/offset. Overflow was the reason of incorrect passing the check, patch fixes the case. Differentail revision: https://reviews.llvm.org/D25514 llvm-svn: 285284
2016-10-27 19:44:56 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-section-size2.elf 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-SECTION-SIZE2 %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-SECTION-SIZE2: invalid section offset
Recommit r285285 - [Object/ELF] - Fixed behavior when SectionHeaderTable->sh_size is too large. with fix: edited invalid-section-index2.elf input to pass the new check and fail on the same place it was intended to fail. Original commit message: Elf.h already has code checking that section table does not go past end of file. Problem is that this check may not work on values greater than UINT64_MAX / Header->e_shentsize because of calculation overflow. Parch fixes the issue. Differential revision: https://reviews.llvm.org/D25432 llvm-svn: 285586
2016-10-31 23:33:00 +08:00
RUN: not llvm-readobj -t %p/Inputs/invalid-sections-num.elf 2>&1 | FileCheck --check-prefix=INVALID-SECTION-NUM %s
Make the ELFObjectFile constructor private. This forces every user to use the new create method that returns an Expected. This in turn propagates better error messages. llvm-svn: 315371
2017-10-11 05:21:16 +08:00
INVALID-SECTION-NUM: section table goes past the end of file
Add error handling to getEntry. Issue found by inspection. llvm-svn: 285951
2016-11-04 02:05:33 +08:00
RUN: not llvm-readobj -r %p/Inputs/invalid-rel-sym.elf 2>&1 | FileCheck --check-prefix=INVALID-REL-SYM %s
[ELF] Convert ELF.h to Expected<T>. This has two advantages: 1) We slowly move away from ErrorOr to the new handling interface, in the hope of having an uniform error handling in LLVM, eventually. 2) We're starting to have *meaningful* error messages for invalid object ELF files, rather than a generic "parse error". At some point we should include also the offset to improve the quality of the diagnostic. llvm-svn: 287081
2016-11-16 13:10:28 +08:00
INVALID-REL-SYM: invalid section offset
Make the ELFFile constructor private. With this all clients have to use the new create method which returns an Expected. Fixes a crash on invalid input. llvm-svn: 315376
2017-10-11 06:17:49 +08:00
RUN: not llvm-readobj -r %p/Inputs/invalid-buffer.elf 2>&1 | FileCheck --check-prefix=INVALID-BUFFER %s
INVALID-BUFFER: Invalid buffer
Fix buffer overflow. We were reading past the end of the buffer. llvm-svn: 316143
2017-10-19 09:25:48 +08:00
RUN: not llvm-readobj %p/Inputs/invalid-coff-header-too-small 2>&1 | FileCheck --check-prefix=COFF-HEADER %s
COFF-HEADER: The file was not recognized as a valid object file