2012-08-25 04:39:55 +08:00
|
|
|
// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.deadcode.UnreachableCode,alpha.core.CastSize,alpha.unix.MallocWithAnnotations -analyzer-store=region -verify %s
|
2012-02-09 07:16:52 +08:00
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
|
|
void *malloc(size_t);
|
|
|
|
void free(void *);
|
|
|
|
void *realloc(void *ptr, size_t size);
|
|
|
|
void *calloc(size_t nmemb, size_t size);
|
|
|
|
void __attribute((ownership_returns(malloc))) *my_malloc(size_t);
|
|
|
|
void __attribute((ownership_takes(malloc, 1))) my_free(void *);
|
2012-03-02 06:06:06 +08:00
|
|
|
void my_freeBoth(void *, void *)
|
|
|
|
__attribute((ownership_holds(malloc, 1, 2)));
|
2012-02-09 07:16:52 +08:00
|
|
|
void __attribute((ownership_returns(malloc, 1))) *my_malloc2(size_t);
|
|
|
|
void __attribute((ownership_holds(malloc, 1))) my_hold(void *);
|
|
|
|
|
|
|
|
// Duplicate attributes are silly, but not an error.
|
|
|
|
// Duplicate attribute has no extra effect.
|
|
|
|
// If two are of different kinds, that is an error and reported as such.
|
|
|
|
void __attribute((ownership_holds(malloc, 1)))
|
|
|
|
__attribute((ownership_holds(malloc, 1)))
|
|
|
|
__attribute((ownership_holds(malloc, 3))) my_hold2(void *, void *, void *);
|
|
|
|
void *my_malloc3(size_t);
|
|
|
|
void *myglobalpointer;
|
|
|
|
struct stuff {
|
|
|
|
void *somefield;
|
|
|
|
};
|
|
|
|
struct stuff myglobalstuff;
|
|
|
|
|
|
|
|
void f1() {
|
|
|
|
int *p = malloc(12);
|
2012-03-22 03:45:08 +08:00
|
|
|
return; // expected-warning{{Memory is never released; potential leak}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void f2() {
|
|
|
|
int *p = malloc(12);
|
|
|
|
free(p);
|
2012-02-17 06:26:12 +08:00
|
|
|
free(p); // expected-warning{{Attempt to free released memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void f2_realloc_0() {
|
|
|
|
int *p = malloc(12);
|
|
|
|
realloc(p,0);
|
2012-02-17 06:26:12 +08:00
|
|
|
realloc(p,0); // expected-warning{{Attempt to free released memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void f2_realloc_1() {
|
|
|
|
int *p = malloc(12);
|
|
|
|
int *q = realloc(p,0); // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
// ownership attributes tests
|
|
|
|
void naf1() {
|
|
|
|
int *p = my_malloc3(12);
|
|
|
|
return; // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
void n2af1() {
|
|
|
|
int *p = my_malloc2(12);
|
2012-03-22 03:45:08 +08:00
|
|
|
return; // expected-warning{{Memory is never released; potential leak}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void af1() {
|
|
|
|
int *p = my_malloc(12);
|
2012-03-22 03:45:08 +08:00
|
|
|
return; // expected-warning{{Memory is never released; potential leak}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void af1_b() {
|
2012-11-16 03:11:43 +08:00
|
|
|
int *p = my_malloc(12);
|
|
|
|
} // expected-warning{{Memory is never released; potential leak}}
|
2012-02-09 07:16:52 +08:00
|
|
|
|
|
|
|
void af1_c() {
|
|
|
|
myglobalpointer = my_malloc(12); // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test that we can pass out allocated memory via pointer-to-pointer.
|
|
|
|
void af1_e(void **pp) {
|
|
|
|
*pp = my_malloc(42); // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
void af1_f(struct stuff *somestuff) {
|
|
|
|
somestuff->somefield = my_malloc(12); // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
// Allocating memory for a field via multiple indirections to our arguments is OK.
|
|
|
|
void af1_g(struct stuff **pps) {
|
|
|
|
*pps = my_malloc(sizeof(struct stuff)); // no-warning
|
|
|
|
(*pps)->somefield = my_malloc(42); // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
void af2() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
my_free(p);
|
2012-02-17 06:26:12 +08:00
|
|
|
free(p); // expected-warning{{Attempt to free released memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void af2b() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
free(p);
|
2012-02-17 06:26:12 +08:00
|
|
|
my_free(p); // expected-warning{{Attempt to free released memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void af2c() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
free(p);
|
2012-02-17 06:26:12 +08:00
|
|
|
my_hold(p); // expected-warning{{Attempt to free released memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void af2d() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
free(p);
|
2012-02-17 06:26:12 +08:00
|
|
|
my_hold2(0, 0, p); // expected-warning{{Attempt to free released memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// No leak if malloc returns null.
|
|
|
|
void af2e() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
if (!p)
|
|
|
|
return; // no-warning
|
|
|
|
free(p); // no-warning
|
|
|
|
}
|
|
|
|
|
2012-06-21 04:57:46 +08:00
|
|
|
// This case inflicts a possible double-free.
|
2012-02-09 07:16:52 +08:00
|
|
|
void af3() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
my_hold(p);
|
2012-06-22 10:04:31 +08:00
|
|
|
free(p); // expected-warning{{Attempt to free non-owned memory}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
int * af4() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
my_free(p);
|
2012-02-17 06:26:12 +08:00
|
|
|
return p; // expected-warning{{Use of memory after it is freed}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// This case is (possibly) ok, be conservative
|
|
|
|
int * af5() {
|
|
|
|
int *p = my_malloc(12);
|
|
|
|
my_hold(p);
|
|
|
|
return p; // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// This case tests that storing malloc'ed memory to a static variable which is
|
|
|
|
// then returned is not leaked. In the absence of known contracts for functions
|
|
|
|
// or inter-procedural analysis, this is a conservative answer.
|
|
|
|
int *f3() {
|
|
|
|
static int *p = 0;
|
|
|
|
p = malloc(12);
|
|
|
|
return p; // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
// This case tests that storing malloc'ed memory to a static global variable
|
|
|
|
// which is then returned is not leaked. In the absence of known contracts for
|
|
|
|
// functions or inter-procedural analysis, this is a conservative answer.
|
|
|
|
static int *p_f4 = 0;
|
|
|
|
int *f4() {
|
|
|
|
p_f4 = malloc(12);
|
|
|
|
return p_f4; // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
int *f5() {
|
|
|
|
int *q = malloc(12);
|
|
|
|
q = realloc(q, 20);
|
|
|
|
return q; // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
void f6() {
|
|
|
|
int *p = malloc(12);
|
|
|
|
if (!p)
|
|
|
|
return; // no-warning
|
|
|
|
else
|
|
|
|
free(p);
|
|
|
|
}
|
|
|
|
|
|
|
|
void f6_realloc() {
|
|
|
|
int *p = malloc(12);
|
|
|
|
if (!p)
|
|
|
|
return; // no-warning
|
|
|
|
else
|
|
|
|
realloc(p,0);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
char *doit2();
|
|
|
|
void pr6069() {
|
|
|
|
char *buf = doit2();
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
void pr6293() {
|
|
|
|
free(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void f7() {
|
|
|
|
char *x = (char*) malloc(4);
|
|
|
|
free(x);
|
2012-02-17 06:26:12 +08:00
|
|
|
x[0] = 'a'; // expected-warning{{Use of memory after it is freed}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void f7_realloc() {
|
|
|
|
char *x = (char*) malloc(4);
|
|
|
|
realloc(x,0);
|
2012-02-17 06:26:12 +08:00
|
|
|
x[0] = 'a'; // expected-warning{{Use of memory after it is freed}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void PR6123() {
|
Allow multiple PathDiagnosticConsumers to be used with a BugReporter at the same time.
This fixes several issues:
- removes egregious hack where PlistDiagnosticConsumer would forward to HTMLDiagnosticConsumer,
but diagnostics wouldn't be generated consistently in the same way if PlistDiagnosticConsumer
was used by itself.
- emitting diagnostics to the terminal (using clang's diagnostic machinery) is no longer a special
case, just another PathDiagnosticConsumer. This also magically resolved some duplicate warnings,
as we now use PathDiagnosticConsumer's diagnostic pruning, which has scope for the entire translation
unit, not just the scope of a BugReporter (which is limited to a particular ExprEngine).
As an interesting side-effect, diagnostics emitted to the terminal also have their trailing "." stripped,
just like with diagnostics emitted to plists and HTML. This required some tests to be updated, but now
the tests have higher fidelity with what users will see.
There are some inefficiencies in this patch. We currently generate the report graph (from the ExplodedGraph)
once per PathDiagnosticConsumer, which is a bit wasteful, but that could be pulled up higher in the
logic stack. There is some intended duplication, however, as we now generate different PathDiagnostics (for the same issue)
for different PathDiagnosticConsumers. This is necessary to produce the diagnostics that a particular
consumer expects.
llvm-svn: 162028
2012-08-17 01:45:23 +08:00
|
|
|
int *x = malloc(11); // expected-warning{{Cast a region whose size is not a multiple of the destination type size}}
|
2012-02-09 07:16:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void PR7217() {
|
Allow multiple PathDiagnosticConsumers to be used with a BugReporter at the same time.
This fixes several issues:
- removes egregious hack where PlistDiagnosticConsumer would forward to HTMLDiagnosticConsumer,
but diagnostics wouldn't be generated consistently in the same way if PlistDiagnosticConsumer
was used by itself.
- emitting diagnostics to the terminal (using clang's diagnostic machinery) is no longer a special
case, just another PathDiagnosticConsumer. This also magically resolved some duplicate warnings,
as we now use PathDiagnosticConsumer's diagnostic pruning, which has scope for the entire translation
unit, not just the scope of a BugReporter (which is limited to a particular ExprEngine).
As an interesting side-effect, diagnostics emitted to the terminal also have their trailing "." stripped,
just like with diagnostics emitted to plists and HTML. This required some tests to be updated, but now
the tests have higher fidelity with what users will see.
There are some inefficiencies in this patch. We currently generate the report graph (from the ExplodedGraph)
once per PathDiagnosticConsumer, which is a bit wasteful, but that could be pulled up higher in the
logic stack. There is some intended duplication, however, as we now generate different PathDiagnostics (for the same issue)
for different PathDiagnosticConsumers. This is necessary to produce the diagnostics that a particular
consumer expects.
llvm-svn: 162028
2012-08-17 01:45:23 +08:00
|
|
|
int *buf = malloc(2); // expected-warning{{Cast a region whose size is not a multiple of the destination type size}}
|
2012-02-09 07:16:52 +08:00
|
|
|
buf[1] = 'c'; // not crash
|
|
|
|
}
|
|
|
|
|
|
|
|
void mallocCastToVoid() {
|
|
|
|
void *p = malloc(2);
|
|
|
|
const void *cp = p; // not crash
|
|
|
|
free(p);
|
|
|
|
}
|
|
|
|
|
|
|
|
void mallocCastToFP() {
|
|
|
|
void *p = malloc(2);
|
|
|
|
void (*fp)() = p; // not crash
|
|
|
|
free(p);
|
|
|
|
}
|
|
|
|
|
|
|
|
// This tests that malloc() buffers are undefined by default
|
|
|
|
char mallocGarbage () {
|
|
|
|
char *buf = malloc(2);
|
|
|
|
char result = buf[1]; // expected-warning{{undefined}}
|
|
|
|
free(buf);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
// This tests that calloc() buffers need to be freed
|
|
|
|
void callocNoFree () {
|
|
|
|
char *buf = calloc(2,2);
|
|
|
|
return; // expected-warning{{never released}}
|
|
|
|
}
|
|
|
|
|
|
|
|
// These test that calloc() buffers are zeroed by default
|
|
|
|
char callocZeroesGood () {
|
|
|
|
char *buf = calloc(2,2);
|
|
|
|
char result = buf[3]; // no-warning
|
|
|
|
if (buf[1] == 0) {
|
|
|
|
free(buf);
|
|
|
|
}
|
|
|
|
return result; // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
char callocZeroesBad () {
|
|
|
|
char *buf = calloc(2,2);
|
|
|
|
char result = buf[3]; // no-warning
|
|
|
|
if (buf[1] != 0) {
|
|
|
|
free(buf); // expected-warning{{never executed}}
|
|
|
|
}
|
|
|
|
return result; // expected-warning{{never released}}
|
|
|
|
}
|
2012-03-02 06:06:06 +08:00
|
|
|
|
|
|
|
void testMultipleFreeAnnotations() {
|
|
|
|
int *p = malloc(12);
|
|
|
|
int *q = malloc(12);
|
|
|
|
my_freeBoth(p, q);
|
|
|
|
}
|
|
|
|
|
2013-02-06 08:01:14 +08:00
|
|
|
// ----------------------------------------------------------------------------
|
|
|
|
|
|
|
|
// False negatives.
|
|
|
|
|
|
|
|
// Pending on removal of the escaping on assignment to struct fields.
|
|
|
|
void af1_d() {
|
|
|
|
struct stuff mystuff;
|
|
|
|
mystuff.somefield = my_malloc(12);
|
|
|
|
} // missing warning
|
|
|
|
|
|
|
|
|