maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/pecoff/alignment.test

15 lines
445 B
Plaintext
Raw Normal View History

[PECOFF] Fix alignment bug. There was a bug that if a section has an alignment requirement and there are multiple symbols at offset 0 in the section, only the last atom at offset 0 would be aligned properly. That bug would move only the last symbol to an alignment boundary, leaving other symbols unaligned, although they should be at the same location. That caused a mysterious SEGV error of the resultant executable. With this patch, we manage all symbols at the same location properly, rather than keeping the last one. llvm-svn: 190724
2013-09-14 05:11:00 +08:00
# RUN: yaml2obj %p/Inputs/alignment.obj.yaml > %t.obj
#
[PECOFF] Fix .bss section alignment Previously the alignment of the .bss section was not properly set because of a bug in AtomizeDefinedSymbolsInSection. We set the alignment of the section at the end of the function, but we use an eraly return for the .bss section, so the code had been skipped. llvm-svn: 212571
2014-07-09 07:11:01 +08:00
# RUN: lld -flavor link /out:%t.exe /subsystem:console /force \
# RUN: /entry:start /opt:noref -- %t.obj
[PECOFF] Add file extensions to temporary files. No functionality change. llvm-svn: 198075
2013-12-27 16:37:40 +08:00
# RUN: llvm-readobj -sections %t.exe | FileCheck %s
[PECOFF] Fix alignment bug. There was a bug that if a section has an alignment requirement and there are multiple symbols at offset 0 in the section, only the last atom at offset 0 would be aligned properly. That bug would move only the last symbol to an alignment boundary, leaving other symbols unaligned, although they should be at the same location. That caused a mysterious SEGV error of the resultant executable. With this patch, we manage all symbols at the same location properly, rather than keeping the last one. llvm-svn: 190724
2013-09-14 05:11:00 +08:00
[PECOFF] Fix .bss section alignment Previously the alignment of the .bss section was not properly set because of a bug in AtomizeDefinedSymbolsInSection. We set the alignment of the section at the end of the function, but we use an eraly return for the .bss section, so the code had been skipped. llvm-svn: 212571
2014-07-09 07:11:01 +08:00
CHECK: Name: .bss (2E 62 73 73 00 00 00 00)
[PECOFF] Fix section header. The PE/COFF spec says that SizeOfRawData field in the section header must be a multiple of FileAlignment from the optional header. LLD emits 512 as FileAlignment, so it must have been a multiple of 512. LLD did not follow that. It emitted the actual section size without the last padding as the SizeOfRawData. Although it's not correct as per the spec, the Windows loader doesn't seem to actually bother to check that. Executables created by LLD worked fine. However, tools dealing with executalbe files may expect it to be the correct value, and one instance of it is mt.exe tool distributed as a part of Windows SDK. If CMake is invoked with "-E vs_link_exe" option, it silently run mt.exe to embed a resource file to the resulting file. And mt.exe sometimes breaks an input file if it's section header does not follow the standard. That caused a misterous error that CMake with Ninja occasionally produces a broken executable. This patch fixes the section header to make mt.exe and other tools happy. llvm-svn: 214453
2014-08-01 06:40:35 +08:00
CHECK: RawDataSize: 0
[PECOFF] Fix .bss section alignment Previously the alignment of the .bss section was not properly set because of a bug in AtomizeDefinedSymbolsInSection. We set the alignment of the section at the end of the function, but we use an eraly return for the .bss section, so the code had been skipped. llvm-svn: 212571
2014-07-09 07:11:01 +08:00
[PECOFF] Add a generic section writer. Instead of having multiple SectionChunks for each section (.text, .data, .rdata and .bss), we could have one chunk writer that can emit any sections. This patch does that -- removing all section-sepcific chunk writers and replace them with one "generic" writer. This change should simplify the code because it eliminates similar-but- slightly-different classes. It also fixes an issue in the previous design. Before this patch, we could emit only limited set of sections (i.e. .text, .data, .rdata and .bss). With this patch, we can emit any sections. llvm-svn: 195797
2013-11-27 08:55:45 +08:00
CHECK: Name: .data (2E 64 61 74 61 00 00 00)
Revert "WriterPECOFF" This reverts accidental commit r195794. llvm-svn: 195795
2013-11-27 08:25:17 +08:00
CHECK-NEXT: VirtualSize: 0x6
[PECOFF] Add a generic section writer. Instead of having multiple SectionChunks for each section (.text, .data, .rdata and .bss), we could have one chunk writer that can emit any sections. This patch does that -- removing all section-sepcific chunk writers and replace them with one "generic" writer. This change should simplify the code because it eliminates similar-but- slightly-different classes. It also fixes an issue in the previous design. Before this patch, we could emit only limited set of sections (i.e. .text, .data, .rdata and .bss). With this patch, we can emit any sections. llvm-svn: 195797
2013-11-27 08:55:45 +08:00
CHECK: Name: .text (2E 74 65 78 74 00 00 00)
CHECK-NEXT: VirtualSize: 0x1001