[lldb][NFC] Fix all formatting errors in .cpp file headers
Summary:
A *.cpp file header in LLDB (and in LLDB) should like this:
```
//===-- TestUtilities.cpp -------------------------------------------------===//
```
However in LLDB most of our source files have arbitrary changes to this format and
these changes are spreading through LLDB as folks usually just use the existing
source files as templates for their new files (most notably the unnecessary
editor language indicator `-*- C++ -*-` is spreading and in every review
someone is pointing out that this is wrong, resulting in people pointing out that this
is done in the same way in other files).
This patch removes most of these inconsistencies including the editor language indicators,
all the different missing/additional '-' characters, files that center the file name, missing
trailing `===//` (mostly caused by clang-format breaking the line).
Reviewers: aprantl, espindola, jfb, shafik, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73258
2020-01-24 15:23:27 +08:00
|
|
|
//===-- StringExtractor.cpp -----------------------------------------------===//
|
2010-06-09 00:52:24 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2010-06-09 00:52:24 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2015-07-07 18:08:41 +08:00
|
|
|
#include "lldb/Utility/StringExtractor.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2016-08-30 03:58:14 +08:00
|
|
|
#include <tuple>
|
2017-04-07 02:12:24 +08:00
|
|
|
|
2018-11-12 07:16:43 +08:00
|
|
|
#include <ctype.h>
|
2017-04-07 02:12:24 +08:00
|
|
|
#include <stdlib.h>
|
2018-11-12 07:16:43 +08:00
|
|
|
#include <string.h>
|
2010-06-09 00:52:24 +08:00
|
|
|
|
|
|
|
static inline int xdigit_to_sint(char ch) {
|
|
|
|
if (ch >= 'a' && ch <= 'f')
|
|
|
|
return 10 + ch - 'a';
|
2010-06-23 05:28:05 +08:00
|
|
|
if (ch >= 'A' && ch <= 'F')
|
|
|
|
return 10 + ch - 'A';
|
2014-12-02 06:19:33 +08:00
|
|
|
if (ch >= '0' && ch <= '9')
|
|
|
|
return ch - '0';
|
|
|
|
return -1;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// StringExtractor constructor
|
|
|
|
StringExtractor::StringExtractor() : m_packet(), m_index(0) {}
|
|
|
|
|
2016-08-30 03:58:14 +08:00
|
|
|
StringExtractor::StringExtractor(llvm::StringRef packet_str)
|
|
|
|
: m_packet(), m_index(0) {
|
|
|
|
m_packet.assign(packet_str.begin(), packet_str.end());
|
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
|
|
|
|
StringExtractor::StringExtractor(const char *packet_cstr)
|
|
|
|
: m_packet(), m_index(0) {
|
|
|
|
if (packet_cstr)
|
|
|
|
m_packet.assign(packet_cstr);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Destructor
|
|
|
|
StringExtractor::~StringExtractor() {}
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
char StringExtractor::GetChar(char fail_value) {
|
|
|
|
if (m_index < m_packet.size()) {
|
|
|
|
char ch = m_packet[m_index];
|
|
|
|
++m_index;
|
|
|
|
return ch;
|
|
|
|
}
|
2013-01-26 02:06:21 +08:00
|
|
|
m_index = UINT64_MAX;
|
2010-06-09 00:52:24 +08:00
|
|
|
return fail_value;
|
|
|
|
}
|
|
|
|
|
2018-05-01 00:49:04 +08:00
|
|
|
// If a pair of valid hex digits exist at the head of the StringExtractor they
|
|
|
|
// are decoded into an unsigned byte and returned by this function
|
2014-12-02 06:19:33 +08:00
|
|
|
//
|
|
|
|
// If there is not a pair of valid hex digits at the head of the
|
|
|
|
// StringExtractor, it is left unchanged and -1 is returned
|
|
|
|
int StringExtractor::DecodeHexU8() {
|
2016-05-25 02:19:45 +08:00
|
|
|
SkipSpaces();
|
2014-12-02 06:19:33 +08:00
|
|
|
if (GetBytesLeft() < 2) {
|
|
|
|
return -1;
|
2016-08-31 16:43:37 +08:00
|
|
|
}
|
|
|
|
const int hi_nibble = xdigit_to_sint(m_packet[m_index]);
|
|
|
|
const int lo_nibble = xdigit_to_sint(m_packet[m_index + 1]);
|
|
|
|
if (hi_nibble == -1 || lo_nibble == -1) {
|
2014-12-02 06:19:33 +08:00
|
|
|
return -1;
|
2016-08-31 16:43:37 +08:00
|
|
|
}
|
2014-12-02 06:19:33 +08:00
|
|
|
m_index += 2;
|
2019-05-23 13:12:11 +08:00
|
|
|
return static_cast<uint8_t>((hi_nibble << 4) + lo_nibble);
|
2014-12-02 06:19:33 +08:00
|
|
|
}
|
|
|
|
|
2018-05-01 00:49:04 +08:00
|
|
|
// Extract an unsigned character from two hex ASCII chars in the packet string,
|
|
|
|
// or return fail_value on failure
|
2012-04-07 08:42:53 +08:00
|
|
|
uint8_t StringExtractor::GetHexU8(uint8_t fail_value, bool set_eof_on_fail) {
|
2018-05-01 00:49:04 +08:00
|
|
|
// On success, fail_value will be overwritten with the next character in the
|
|
|
|
// stream
|
2015-09-18 01:55:32 +08:00
|
|
|
GetHexU8Ex(fail_value, set_eof_on_fail);
|
|
|
|
return fail_value;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool StringExtractor::GetHexU8Ex(uint8_t &ch, bool set_eof_on_fail) {
|
2014-12-02 06:19:33 +08:00
|
|
|
int byte = DecodeHexU8();
|
|
|
|
if (byte == -1) {
|
|
|
|
if (set_eof_on_fail || m_index >= m_packet.size())
|
|
|
|
m_index = UINT64_MAX;
|
2015-09-18 01:55:32 +08:00
|
|
|
// ch should not be changed in case of failure
|
|
|
|
return false;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2019-05-23 13:12:11 +08:00
|
|
|
ch = static_cast<uint8_t>(byte);
|
2015-09-18 01:55:32 +08:00
|
|
|
return true;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
Many improvements to the Platform base class and subclasses. The base Platform
class now implements the Host functionality for a lot of things that make
sense by default so that subclasses can check:
int
PlatformSubclass::Foo ()
{
if (IsHost())
return Platform::Foo (); // Let the platform base class do the host specific stuff
// Platform subclass specific code...
int result = ...
return result;
}
Added new functions to the platform:
virtual const char *Platform::GetUserName (uint32_t uid);
virtual const char *Platform::GetGroupName (uint32_t gid);
The user and group names are cached locally so that remote platforms can avoid
sending packets multiple times to resolve this information.
Added the parent process ID to the ProcessInfo class.
Added a new ProcessInfoMatch class which helps us to match processes up
and changed the Host layer over to using this new class. The new class allows
us to search for processs:
1 - by name (equal to, starts with, ends with, contains, and regex)
2 - by pid
3 - And further check for parent pid == value, uid == value, gid == value,
euid == value, egid == value, arch == value, parent == value.
This is all hookup up to the "platform process list" command which required
adding dumping routines to dump process information. If the Host class
implements the process lookup routines, you can now lists processes on
your local machine:
machine1.foo.com % lldb
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
94727 244 username usergroup username usergroup x86_64-apple-darwin Xcode
92742 92710 username usergroup username usergroup i386-apple-darwin debugserver
This of course also works remotely with the lldb-platform:
machine1.foo.com % lldb-platform --listen 1234
machine2.foo.com % lldb
(lldb) platform create remote-macosx
Platform: remote-macosx
Connected: no
(lldb) platform connect connect://localhost:1444
Platform: remote-macosx
Triple: x86_64-apple-darwin
OS Version: 10.6.7 (10J869)
Kernel: Darwin Kernel Version 10.7.0: Sat Jan 29 15:17:16 PST 2011; root:xnu-1504.9.37~1/RELEASE_I386
Hostname: machine1.foo.com
Connected: yes
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99556 244 username usergroup username usergroup x86_64-apple-darwin trustevaluation
99548 65539 username usergroup username usergroup x86_64-apple-darwin lldb
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
The lldb-platform implements everything with the Host:: layer, so this should
"just work" for linux. I will probably be adding more stuff to the Host layer
for launching processes and attaching to processes so that this support should
eventually just work as well.
Modified the target to be able to be created with an architecture that differs
from the main executable. This is needed for iOS debugging since we can have
an "armv6" binary which can run on an "armv7" machine, so we want to be able
to do:
% lldb
(lldb) platform create remote-ios
(lldb) file --arch armv7 a.out
Where "a.out" is an armv6 executable. The platform then can correctly decide
to open all "armv7" images for all dependent shared libraries.
Modified the disassembly to show the current PC value. Example output:
(lldb) disassemble --frame
a.out`main:
0x1eb7: pushl %ebp
0x1eb8: movl %esp, %ebp
0x1eba: pushl %ebx
0x1ebb: subl $20, %esp
0x1ebe: calll 0x1ec3 ; main + 12 at test.c:18
0x1ec3: popl %ebx
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
0x1edb: leal 213(%ebx), %eax
0x1ee1: movl %eax, (%esp)
0x1ee4: calll 0x1f1e ; puts
0x1ee9: calll 0x1f0c ; getchar
0x1eee: movl $20, (%esp)
0x1ef5: calll 0x1e6a ; sleep_loop at test.c:6
0x1efa: movl $12, %eax
0x1eff: addl $20, %esp
0x1f02: popl %ebx
0x1f03: leave
0x1f04: ret
This can be handy when dealing with the new --line options that was recently
added:
(lldb) disassemble --line
a.out`main + 13 at test.c:19
18 {
-> 19 printf("Process: %i\n\n", getpid());
20 puts("Press any key to continue..."); getchar();
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
Modified the ModuleList to have a lookup based solely on a UUID. Since the
UUID is typically the MD5 checksum of a binary image, there is no need
to give the path and architecture when searching for a pre-existing
image in an image list.
Now that we support remote debugging a bit better, our lldb_private::Module
needs to be able to track what the original path for file was as the platform
knows it, as well as where the file is locally. The module has the two
following functions to retrieve both paths:
const FileSpec &Module::GetFileSpec () const;
const FileSpec &Module::GetPlatformFileSpec () const;
llvm-svn: 128563
2011-03-31 02:16:51 +08:00
|
|
|
uint32_t StringExtractor::GetU32(uint32_t fail_value, int base) {
|
|
|
|
if (m_index < m_packet.size()) {
|
2014-04-20 21:17:36 +08:00
|
|
|
char *end = nullptr;
|
Many improvements to the Platform base class and subclasses. The base Platform
class now implements the Host functionality for a lot of things that make
sense by default so that subclasses can check:
int
PlatformSubclass::Foo ()
{
if (IsHost())
return Platform::Foo (); // Let the platform base class do the host specific stuff
// Platform subclass specific code...
int result = ...
return result;
}
Added new functions to the platform:
virtual const char *Platform::GetUserName (uint32_t uid);
virtual const char *Platform::GetGroupName (uint32_t gid);
The user and group names are cached locally so that remote platforms can avoid
sending packets multiple times to resolve this information.
Added the parent process ID to the ProcessInfo class.
Added a new ProcessInfoMatch class which helps us to match processes up
and changed the Host layer over to using this new class. The new class allows
us to search for processs:
1 - by name (equal to, starts with, ends with, contains, and regex)
2 - by pid
3 - And further check for parent pid == value, uid == value, gid == value,
euid == value, egid == value, arch == value, parent == value.
This is all hookup up to the "platform process list" command which required
adding dumping routines to dump process information. If the Host class
implements the process lookup routines, you can now lists processes on
your local machine:
machine1.foo.com % lldb
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
94727 244 username usergroup username usergroup x86_64-apple-darwin Xcode
92742 92710 username usergroup username usergroup i386-apple-darwin debugserver
This of course also works remotely with the lldb-platform:
machine1.foo.com % lldb-platform --listen 1234
machine2.foo.com % lldb
(lldb) platform create remote-macosx
Platform: remote-macosx
Connected: no
(lldb) platform connect connect://localhost:1444
Platform: remote-macosx
Triple: x86_64-apple-darwin
OS Version: 10.6.7 (10J869)
Kernel: Darwin Kernel Version 10.7.0: Sat Jan 29 15:17:16 PST 2011; root:xnu-1504.9.37~1/RELEASE_I386
Hostname: machine1.foo.com
Connected: yes
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99556 244 username usergroup username usergroup x86_64-apple-darwin trustevaluation
99548 65539 username usergroup username usergroup x86_64-apple-darwin lldb
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
The lldb-platform implements everything with the Host:: layer, so this should
"just work" for linux. I will probably be adding more stuff to the Host layer
for launching processes and attaching to processes so that this support should
eventually just work as well.
Modified the target to be able to be created with an architecture that differs
from the main executable. This is needed for iOS debugging since we can have
an "armv6" binary which can run on an "armv7" machine, so we want to be able
to do:
% lldb
(lldb) platform create remote-ios
(lldb) file --arch armv7 a.out
Where "a.out" is an armv6 executable. The platform then can correctly decide
to open all "armv7" images for all dependent shared libraries.
Modified the disassembly to show the current PC value. Example output:
(lldb) disassemble --frame
a.out`main:
0x1eb7: pushl %ebp
0x1eb8: movl %esp, %ebp
0x1eba: pushl %ebx
0x1ebb: subl $20, %esp
0x1ebe: calll 0x1ec3 ; main + 12 at test.c:18
0x1ec3: popl %ebx
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
0x1edb: leal 213(%ebx), %eax
0x1ee1: movl %eax, (%esp)
0x1ee4: calll 0x1f1e ; puts
0x1ee9: calll 0x1f0c ; getchar
0x1eee: movl $20, (%esp)
0x1ef5: calll 0x1e6a ; sleep_loop at test.c:6
0x1efa: movl $12, %eax
0x1eff: addl $20, %esp
0x1f02: popl %ebx
0x1f03: leave
0x1f04: ret
This can be handy when dealing with the new --line options that was recently
added:
(lldb) disassemble --line
a.out`main + 13 at test.c:19
18 {
-> 19 printf("Process: %i\n\n", getpid());
20 puts("Press any key to continue..."); getchar();
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
Modified the ModuleList to have a lookup based solely on a UUID. Since the
UUID is typically the MD5 checksum of a binary image, there is no need
to give the path and architecture when searching for a pre-existing
image in an image list.
Now that we support remote debugging a bit better, our lldb_private::Module
needs to be able to track what the original path for file was as the platform
knows it, as well as where the file is locally. The module has the two
following functions to retrieve both paths:
const FileSpec &Module::GetFileSpec () const;
const FileSpec &Module::GetPlatformFileSpec () const;
llvm-svn: 128563
2011-03-31 02:16:51 +08:00
|
|
|
const char *start = m_packet.c_str();
|
2013-08-27 07:57:52 +08:00
|
|
|
const char *cstr = start + m_index;
|
2015-03-13 08:31:45 +08:00
|
|
|
uint32_t result = static_cast<uint32_t>(::strtoul(cstr, &end, base));
|
2013-08-27 07:57:52 +08:00
|
|
|
|
|
|
|
if (end && end != cstr) {
|
|
|
|
m_index = end - start;
|
|
|
|
return result;
|
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2013-08-27 07:57:52 +08:00
|
|
|
return fail_value;
|
|
|
|
}
|
|
|
|
|
|
|
|
int32_t StringExtractor::GetS32(int32_t fail_value, int base) {
|
|
|
|
if (m_index < m_packet.size()) {
|
2014-04-20 21:17:36 +08:00
|
|
|
char *end = nullptr;
|
2013-08-27 07:57:52 +08:00
|
|
|
const char *start = m_packet.c_str();
|
|
|
|
const char *cstr = start + m_index;
|
2015-03-13 08:31:45 +08:00
|
|
|
int32_t result = static_cast<int32_t>(::strtol(cstr, &end, base));
|
2013-08-27 07:57:52 +08:00
|
|
|
|
|
|
|
if (end && end != cstr) {
|
|
|
|
m_index = end - start;
|
|
|
|
return result;
|
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2013-08-27 07:57:52 +08:00
|
|
|
return fail_value;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t StringExtractor::GetU64(uint64_t fail_value, int base) {
|
|
|
|
if (m_index < m_packet.size()) {
|
2014-04-20 21:17:36 +08:00
|
|
|
char *end = nullptr;
|
2013-08-27 07:57:52 +08:00
|
|
|
const char *start = m_packet.c_str();
|
|
|
|
const char *cstr = start + m_index;
|
|
|
|
uint64_t result = ::strtoull(cstr, &end, base);
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2013-08-27 07:57:52 +08:00
|
|
|
if (end && end != cstr) {
|
Many improvements to the Platform base class and subclasses. The base Platform
class now implements the Host functionality for a lot of things that make
sense by default so that subclasses can check:
int
PlatformSubclass::Foo ()
{
if (IsHost())
return Platform::Foo (); // Let the platform base class do the host specific stuff
// Platform subclass specific code...
int result = ...
return result;
}
Added new functions to the platform:
virtual const char *Platform::GetUserName (uint32_t uid);
virtual const char *Platform::GetGroupName (uint32_t gid);
The user and group names are cached locally so that remote platforms can avoid
sending packets multiple times to resolve this information.
Added the parent process ID to the ProcessInfo class.
Added a new ProcessInfoMatch class which helps us to match processes up
and changed the Host layer over to using this new class. The new class allows
us to search for processs:
1 - by name (equal to, starts with, ends with, contains, and regex)
2 - by pid
3 - And further check for parent pid == value, uid == value, gid == value,
euid == value, egid == value, arch == value, parent == value.
This is all hookup up to the "platform process list" command which required
adding dumping routines to dump process information. If the Host class
implements the process lookup routines, you can now lists processes on
your local machine:
machine1.foo.com % lldb
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
94727 244 username usergroup username usergroup x86_64-apple-darwin Xcode
92742 92710 username usergroup username usergroup i386-apple-darwin debugserver
This of course also works remotely with the lldb-platform:
machine1.foo.com % lldb-platform --listen 1234
machine2.foo.com % lldb
(lldb) platform create remote-macosx
Platform: remote-macosx
Connected: no
(lldb) platform connect connect://localhost:1444
Platform: remote-macosx
Triple: x86_64-apple-darwin
OS Version: 10.6.7 (10J869)
Kernel: Darwin Kernel Version 10.7.0: Sat Jan 29 15:17:16 PST 2011; root:xnu-1504.9.37~1/RELEASE_I386
Hostname: machine1.foo.com
Connected: yes
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99556 244 username usergroup username usergroup x86_64-apple-darwin trustevaluation
99548 65539 username usergroup username usergroup x86_64-apple-darwin lldb
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
The lldb-platform implements everything with the Host:: layer, so this should
"just work" for linux. I will probably be adding more stuff to the Host layer
for launching processes and attaching to processes so that this support should
eventually just work as well.
Modified the target to be able to be created with an architecture that differs
from the main executable. This is needed for iOS debugging since we can have
an "armv6" binary which can run on an "armv7" machine, so we want to be able
to do:
% lldb
(lldb) platform create remote-ios
(lldb) file --arch armv7 a.out
Where "a.out" is an armv6 executable. The platform then can correctly decide
to open all "armv7" images for all dependent shared libraries.
Modified the disassembly to show the current PC value. Example output:
(lldb) disassemble --frame
a.out`main:
0x1eb7: pushl %ebp
0x1eb8: movl %esp, %ebp
0x1eba: pushl %ebx
0x1ebb: subl $20, %esp
0x1ebe: calll 0x1ec3 ; main + 12 at test.c:18
0x1ec3: popl %ebx
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
0x1edb: leal 213(%ebx), %eax
0x1ee1: movl %eax, (%esp)
0x1ee4: calll 0x1f1e ; puts
0x1ee9: calll 0x1f0c ; getchar
0x1eee: movl $20, (%esp)
0x1ef5: calll 0x1e6a ; sleep_loop at test.c:6
0x1efa: movl $12, %eax
0x1eff: addl $20, %esp
0x1f02: popl %ebx
0x1f03: leave
0x1f04: ret
This can be handy when dealing with the new --line options that was recently
added:
(lldb) disassemble --line
a.out`main + 13 at test.c:19
18 {
-> 19 printf("Process: %i\n\n", getpid());
20 puts("Press any key to continue..."); getchar();
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
Modified the ModuleList to have a lookup based solely on a UUID. Since the
UUID is typically the MD5 checksum of a binary image, there is no need
to give the path and architecture when searching for a pre-existing
image in an image list.
Now that we support remote debugging a bit better, our lldb_private::Module
needs to be able to track what the original path for file was as the platform
knows it, as well as where the file is locally. The module has the two
following functions to retrieve both paths:
const FileSpec &Module::GetFileSpec () const;
const FileSpec &Module::GetPlatformFileSpec () const;
llvm-svn: 128563
2011-03-31 02:16:51 +08:00
|
|
|
m_index = end - start;
|
|
|
|
return result;
|
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
Many improvements to the Platform base class and subclasses. The base Platform
class now implements the Host functionality for a lot of things that make
sense by default so that subclasses can check:
int
PlatformSubclass::Foo ()
{
if (IsHost())
return Platform::Foo (); // Let the platform base class do the host specific stuff
// Platform subclass specific code...
int result = ...
return result;
}
Added new functions to the platform:
virtual const char *Platform::GetUserName (uint32_t uid);
virtual const char *Platform::GetGroupName (uint32_t gid);
The user and group names are cached locally so that remote platforms can avoid
sending packets multiple times to resolve this information.
Added the parent process ID to the ProcessInfo class.
Added a new ProcessInfoMatch class which helps us to match processes up
and changed the Host layer over to using this new class. The new class allows
us to search for processs:
1 - by name (equal to, starts with, ends with, contains, and regex)
2 - by pid
3 - And further check for parent pid == value, uid == value, gid == value,
euid == value, egid == value, arch == value, parent == value.
This is all hookup up to the "platform process list" command which required
adding dumping routines to dump process information. If the Host class
implements the process lookup routines, you can now lists processes on
your local machine:
machine1.foo.com % lldb
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
94727 244 username usergroup username usergroup x86_64-apple-darwin Xcode
92742 92710 username usergroup username usergroup i386-apple-darwin debugserver
This of course also works remotely with the lldb-platform:
machine1.foo.com % lldb-platform --listen 1234
machine2.foo.com % lldb
(lldb) platform create remote-macosx
Platform: remote-macosx
Connected: no
(lldb) platform connect connect://localhost:1444
Platform: remote-macosx
Triple: x86_64-apple-darwin
OS Version: 10.6.7 (10J869)
Kernel: Darwin Kernel Version 10.7.0: Sat Jan 29 15:17:16 PST 2011; root:xnu-1504.9.37~1/RELEASE_I386
Hostname: machine1.foo.com
Connected: yes
(lldb) platform process list
PID PARENT USER GROUP EFF USER EFF GROUP TRIPLE NAME
====== ====== ========== ========== ========== ========== ======================== ============================
99556 244 username usergroup username usergroup x86_64-apple-darwin trustevaluation
99548 65539 username usergroup username usergroup x86_64-apple-darwin lldb
99538 1 username usergroup username usergroup x86_64-apple-darwin FileMerge
94943 1 username usergroup username usergroup x86_64-apple-darwin mdworker
94852 244 username usergroup username usergroup x86_64-apple-darwin Safari
The lldb-platform implements everything with the Host:: layer, so this should
"just work" for linux. I will probably be adding more stuff to the Host layer
for launching processes and attaching to processes so that this support should
eventually just work as well.
Modified the target to be able to be created with an architecture that differs
from the main executable. This is needed for iOS debugging since we can have
an "armv6" binary which can run on an "armv7" machine, so we want to be able
to do:
% lldb
(lldb) platform create remote-ios
(lldb) file --arch armv7 a.out
Where "a.out" is an armv6 executable. The platform then can correctly decide
to open all "armv7" images for all dependent shared libraries.
Modified the disassembly to show the current PC value. Example output:
(lldb) disassemble --frame
a.out`main:
0x1eb7: pushl %ebp
0x1eb8: movl %esp, %ebp
0x1eba: pushl %ebx
0x1ebb: subl $20, %esp
0x1ebe: calll 0x1ec3 ; main + 12 at test.c:18
0x1ec3: popl %ebx
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
0x1edb: leal 213(%ebx), %eax
0x1ee1: movl %eax, (%esp)
0x1ee4: calll 0x1f1e ; puts
0x1ee9: calll 0x1f0c ; getchar
0x1eee: movl $20, (%esp)
0x1ef5: calll 0x1e6a ; sleep_loop at test.c:6
0x1efa: movl $12, %eax
0x1eff: addl $20, %esp
0x1f02: popl %ebx
0x1f03: leave
0x1f04: ret
This can be handy when dealing with the new --line options that was recently
added:
(lldb) disassemble --line
a.out`main + 13 at test.c:19
18 {
-> 19 printf("Process: %i\n\n", getpid());
20 puts("Press any key to continue..."); getchar();
-> 0x1ec4: calll 0x1f12 ; getpid
0x1ec9: movl %eax, 4(%esp)
0x1ecd: leal 199(%ebx), %eax
0x1ed3: movl %eax, (%esp)
0x1ed6: calll 0x1f18 ; printf
Modified the ModuleList to have a lookup based solely on a UUID. Since the
UUID is typically the MD5 checksum of a binary image, there is no need
to give the path and architecture when searching for a pre-existing
image in an image list.
Now that we support remote debugging a bit better, our lldb_private::Module
needs to be able to track what the original path for file was as the platform
knows it, as well as where the file is locally. The module has the two
following functions to retrieve both paths:
const FileSpec &Module::GetFileSpec () const;
const FileSpec &Module::GetPlatformFileSpec () const;
llvm-svn: 128563
2011-03-31 02:16:51 +08:00
|
|
|
return fail_value;
|
|
|
|
}
|
|
|
|
|
2013-08-27 07:57:52 +08:00
|
|
|
int64_t StringExtractor::GetS64(int64_t fail_value, int base) {
|
|
|
|
if (m_index < m_packet.size()) {
|
2014-04-20 21:17:36 +08:00
|
|
|
char *end = nullptr;
|
2013-08-27 07:57:52 +08:00
|
|
|
const char *start = m_packet.c_str();
|
|
|
|
const char *cstr = start + m_index;
|
|
|
|
int64_t result = ::strtoll(cstr, &end, base);
|
2016-08-31 16:43:37 +08:00
|
|
|
|
|
|
|
if (end && end != cstr) {
|
|
|
|
m_index = end - start;
|
|
|
|
return result;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2016-08-31 16:43:37 +08:00
|
|
|
return fail_value;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
uint32_t StringExtractor::GetHexMaxU32(bool little_endian,
|
|
|
|
uint32_t fail_value) {
|
2016-08-31 16:43:37 +08:00
|
|
|
uint32_t result = 0;
|
|
|
|
uint32_t nibble_count = 0;
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2016-08-31 16:43:37 +08:00
|
|
|
SkipSpaces();
|
2016-08-31 03:28:01 +08:00
|
|
|
if (little_endian) {
|
2016-08-31 16:43:37 +08:00
|
|
|
uint32_t shift_amount = 0;
|
|
|
|
while (m_index < m_packet.size() && ::isxdigit(m_packet[m_index])) {
|
|
|
|
// Make sure we don't exceed the size of a uint32_t...
|
|
|
|
if (nibble_count >= (sizeof(uint32_t) * 2)) {
|
|
|
|
m_index = UINT64_MAX;
|
|
|
|
return fail_value;
|
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2016-08-31 16:43:37 +08:00
|
|
|
uint8_t nibble_lo;
|
|
|
|
uint8_t nibble_hi = xdigit_to_sint(m_packet[m_index]);
|
|
|
|
++m_index;
|
|
|
|
if (m_index < m_packet.size() && ::isxdigit(m_packet[m_index])) {
|
|
|
|
nibble_lo = xdigit_to_sint(m_packet[m_index]);
|
|
|
|
++m_index;
|
2019-05-23 13:12:11 +08:00
|
|
|
result |= (static_cast<uint32_t>(nibble_hi) << (shift_amount + 4));
|
|
|
|
result |= (static_cast<uint32_t>(nibble_lo) << shift_amount);
|
2016-08-31 16:43:37 +08:00
|
|
|
nibble_count += 2;
|
|
|
|
shift_amount += 8;
|
|
|
|
} else {
|
2019-05-23 13:12:11 +08:00
|
|
|
result |= (static_cast<uint32_t>(nibble_hi) << shift_amount);
|
2016-08-31 16:43:37 +08:00
|
|
|
nibble_count += 1;
|
|
|
|
shift_amount += 4;
|
|
|
|
}
|
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
} else {
|
2016-08-31 16:43:37 +08:00
|
|
|
while (m_index < m_packet.size() && ::isxdigit(m_packet[m_index])) {
|
|
|
|
// Make sure we don't exceed the size of a uint32_t...
|
|
|
|
if (nibble_count >= (sizeof(uint32_t) * 2)) {
|
|
|
|
m_index = UINT64_MAX;
|
|
|
|
return fail_value;
|
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2016-08-31 16:43:37 +08:00
|
|
|
uint8_t nibble = xdigit_to_sint(m_packet[m_index]);
|
|
|
|
// Big Endian
|
|
|
|
result <<= 4;
|
|
|
|
result |= nibble;
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2016-08-31 16:43:37 +08:00
|
|
|
++m_index;
|
|
|
|
++nibble_count;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2016-08-31 16:43:37 +08:00
|
|
|
return result;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
2016-08-31 02:12:11 +08:00
|
|
|
uint64_t StringExtractor::GetHexMaxU64(bool little_endian,
|
|
|
|
uint64_t fail_value) {
|
|
|
|
uint64_t result = 0;
|
|
|
|
uint32_t nibble_count = 0;
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
SkipSpaces();
|
|
|
|
if (little_endian) {
|
|
|
|
uint32_t shift_amount = 0;
|
2016-08-31 02:12:11 +08:00
|
|
|
while (m_index < m_packet.size() && ::isxdigit(m_packet[m_index])) {
|
|
|
|
// Make sure we don't exceed the size of a uint64_t...
|
|
|
|
if (nibble_count >= (sizeof(uint64_t) * 2)) {
|
|
|
|
m_index = UINT64_MAX;
|
|
|
|
return fail_value;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
uint8_t nibble_lo;
|
2016-08-31 02:12:11 +08:00
|
|
|
uint8_t nibble_hi = xdigit_to_sint(m_packet[m_index]);
|
2016-08-31 16:43:37 +08:00
|
|
|
++m_index;
|
2016-08-31 02:12:11 +08:00
|
|
|
if (m_index < m_packet.size() && ::isxdigit(m_packet[m_index])) {
|
2016-08-31 16:43:37 +08:00
|
|
|
nibble_lo = xdigit_to_sint(m_packet[m_index]);
|
|
|
|
++m_index;
|
2019-05-23 13:12:11 +08:00
|
|
|
result |= (static_cast<uint64_t>(nibble_hi) << (shift_amount + 4));
|
|
|
|
result |= (static_cast<uint64_t>(nibble_lo) << shift_amount);
|
2016-08-31 16:43:37 +08:00
|
|
|
nibble_count += 2;
|
|
|
|
shift_amount += 8;
|
2016-09-07 04:57:50 +08:00
|
|
|
} else {
|
2019-05-23 13:12:11 +08:00
|
|
|
result |= (static_cast<uint64_t>(nibble_hi) << shift_amount);
|
2016-08-31 16:43:37 +08:00
|
|
|
nibble_count += 1;
|
|
|
|
shift_amount += 4;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
} else {
|
2016-08-31 16:43:37 +08:00
|
|
|
while (m_index < m_packet.size() && ::isxdigit(m_packet[m_index])) {
|
|
|
|
// Make sure we don't exceed the size of a uint64_t...
|
|
|
|
if (nibble_count >= (sizeof(uint64_t) * 2)) {
|
|
|
|
m_index = UINT64_MAX;
|
|
|
|
return fail_value;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
|
2016-08-31 16:43:37 +08:00
|
|
|
uint8_t nibble = xdigit_to_sint(m_packet[m_index]);
|
|
|
|
// Big Endian
|
|
|
|
result <<= 4;
|
|
|
|
result |= nibble;
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2016-08-31 16:43:37 +08:00
|
|
|
++m_index;
|
|
|
|
++nibble_count;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
}
|
2013-08-27 07:57:52 +08:00
|
|
|
return result;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2017-05-26 19:46:27 +08:00
|
|
|
bool StringExtractor::ConsumeFront(const llvm::StringRef &str) {
|
|
|
|
llvm::StringRef S = GetStringRef();
|
|
|
|
if (!S.startswith(str))
|
|
|
|
return false;
|
|
|
|
else
|
|
|
|
m_index += str.size();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2016-08-31 02:12:11 +08:00
|
|
|
size_t StringExtractor::GetHexBytes(llvm::MutableArrayRef<uint8_t> dest,
|
2016-08-31 16:43:37 +08:00
|
|
|
uint8_t fail_fill_value) {
|
2014-12-02 06:19:33 +08:00
|
|
|
size_t bytes_extracted = 0;
|
2016-08-31 02:12:11 +08:00
|
|
|
while (!dest.empty() && GetBytesLeft() > 0) {
|
|
|
|
dest[0] = GetHexU8(fail_fill_value);
|
|
|
|
if (!IsGood())
|
2016-09-07 04:57:50 +08:00
|
|
|
break;
|
2016-08-31 02:12:11 +08:00
|
|
|
++bytes_extracted;
|
|
|
|
dest = dest.drop_front();
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
|
2016-08-31 02:12:11 +08:00
|
|
|
if (!dest.empty())
|
|
|
|
::memset(dest.data(), fail_fill_value, dest.size());
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
return bytes_extracted;
|
|
|
|
}
|
|
|
|
|
2018-05-01 00:49:04 +08:00
|
|
|
// Decodes all valid hex encoded bytes at the head of the StringExtractor,
|
|
|
|
// limited by dst_len.
|
2014-12-02 06:19:33 +08:00
|
|
|
//
|
|
|
|
// Returns the number of bytes successfully decoded
|
2016-08-31 02:12:11 +08:00
|
|
|
size_t StringExtractor::GetHexBytesAvail(llvm::MutableArrayRef<uint8_t> dest) {
|
2014-12-02 06:19:33 +08:00
|
|
|
size_t bytes_extracted = 0;
|
2016-08-31 02:12:11 +08:00
|
|
|
while (!dest.empty()) {
|
2014-12-02 06:19:33 +08:00
|
|
|
int decode = DecodeHexU8();
|
|
|
|
if (decode == -1)
|
|
|
|
break;
|
2019-05-23 13:12:11 +08:00
|
|
|
dest[0] = static_cast<uint8_t>(decode);
|
2016-08-31 02:12:11 +08:00
|
|
|
dest = dest.drop_front();
|
|
|
|
++bytes_extracted;
|
2014-12-02 06:19:33 +08:00
|
|
|
}
|
|
|
|
return bytes_extracted;
|
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2011-01-08 11:17:57 +08:00
|
|
|
size_t StringExtractor::GetHexByteString(std::string &str) {
|
|
|
|
str.clear();
|
2016-08-09 20:04:46 +08:00
|
|
|
str.reserve(GetBytesLeft() / 2);
|
2011-01-08 11:17:57 +08:00
|
|
|
char ch;
|
|
|
|
while ((ch = GetHexU8()) != '\0')
|
|
|
|
str.append(1, ch);
|
|
|
|
return str.size();
|
|
|
|
}
|
|
|
|
|
2014-07-01 05:05:18 +08:00
|
|
|
size_t StringExtractor::GetHexByteStringFixedLength(std::string &str,
|
|
|
|
uint32_t nibble_length) {
|
|
|
|
str.clear();
|
2016-08-31 16:43:37 +08:00
|
|
|
|
|
|
|
uint32_t nibble_count = 0;
|
|
|
|
for (const char *pch = Peek();
|
|
|
|
(nibble_count < nibble_length) && (pch != nullptr);
|
|
|
|
str.append(1, GetHexU8(0, false)), pch = Peek(), nibble_count += 2) {
|
|
|
|
}
|
|
|
|
|
2014-07-01 05:05:18 +08:00
|
|
|
return str.size();
|
|
|
|
}
|
|
|
|
|
2013-08-27 07:57:52 +08:00
|
|
|
size_t StringExtractor::GetHexByteStringTerminatedBy(std::string &str,
|
|
|
|
char terminator) {
|
|
|
|
str.clear();
|
|
|
|
char ch;
|
|
|
|
while ((ch = GetHexU8(0, false)) != '\0')
|
|
|
|
str.append(1, ch);
|
2016-08-31 16:43:37 +08:00
|
|
|
if (Peek() && *Peek() == terminator)
|
2013-08-27 07:57:52 +08:00
|
|
|
return str.size();
|
|
|
|
|
2016-08-30 03:58:14 +08:00
|
|
|
str.clear();
|
|
|
|
return str.size();
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2015-07-07 07:40:40 +08:00
|
|
|
|
|
|
|
bool StringExtractor::GetNameColonValue(llvm::StringRef &name,
|
2016-08-30 03:58:14 +08:00
|
|
|
llvm::StringRef &value) {
|
2018-05-01 00:49:04 +08:00
|
|
|
// Read something in the form of NNNN:VVVV; where NNNN is any character that
|
|
|
|
// is not a colon, followed by a ':' character, then a value (one or more ';'
|
|
|
|
// chars), followed by a ';'
|
2015-07-07 07:40:40 +08:00
|
|
|
if (m_index >= m_packet.size())
|
2016-08-30 03:58:14 +08:00
|
|
|
return fail();
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2016-08-30 03:58:14 +08:00
|
|
|
llvm::StringRef view(m_packet);
|
|
|
|
if (view.empty())
|
2015-07-07 07:40:40 +08:00
|
|
|
return fail();
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2015-07-07 07:40:40 +08:00
|
|
|
llvm::StringRef a, b, c, d;
|
2016-08-30 03:58:14 +08:00
|
|
|
view = view.substr(m_index);
|
|
|
|
std::tie(a, b) = view.split(':');
|
|
|
|
if (a.empty() || b.empty())
|
|
|
|
return fail();
|
|
|
|
std::tie(c, d) = b.split(';');
|
|
|
|
if (b == c && d.empty())
|
|
|
|
return fail();
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2015-07-07 07:40:40 +08:00
|
|
|
name = a;
|
2016-08-30 03:58:14 +08:00
|
|
|
value = c;
|
|
|
|
if (d.empty())
|
2015-07-07 07:40:40 +08:00
|
|
|
m_index = m_packet.size();
|
2016-09-07 04:57:50 +08:00
|
|
|
else {
|
2015-07-07 07:40:40 +08:00
|
|
|
size_t bytes_consumed = d.data() - view.data();
|
|
|
|
m_index += bytes_consumed;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2016-08-30 03:58:14 +08:00
|
|
|
return true;
|
2015-07-07 07:40:40 +08:00
|
|
|
}
|
|
|
|
|
2016-08-30 03:58:14 +08:00
|
|
|
void StringExtractor::SkipSpaces() {
|
2013-08-27 07:57:52 +08:00
|
|
|
const size_t n = m_packet.size();
|
2015-07-07 07:40:40 +08:00
|
|
|
while (m_index < n && isspace(m_packet[m_index]))
|
2016-08-31 16:43:37 +08:00
|
|
|
++m_index;
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|