[lldb][NFC] Fix all formatting errors in .cpp file headers
Summary:
A *.cpp file header in LLDB (and in LLDB) should like this:
```
//===-- TestUtilities.cpp -------------------------------------------------===//
```
However in LLDB most of our source files have arbitrary changes to this format and
these changes are spreading through LLDB as folks usually just use the existing
source files as templates for their new files (most notably the unnecessary
editor language indicator `-*- C++ -*-` is spreading and in every review
someone is pointing out that this is wrong, resulting in people pointing out that this
is done in the same way in other files).
This patch removes most of these inconsistencies including the editor language indicators,
all the different missing/additional '-' characters, files that center the file name, missing
trailing `===//` (mostly caused by clang-format breaking the line).
Reviewers: aprantl, espindola, jfb, shafik, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73258
2020-01-24 15:23:27 +08:00
|
|
|
//===-- DWARFIndex.cpp ----------------------------------------------------===//
|
2018-05-21 22:12:52 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2018-05-21 22:12:52 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "Plugins/SymbolFile/DWARF/DWARFIndex.h"
|
2018-06-08 17:10:31 +08:00
|
|
|
#include "Plugins/Language/ObjC/ObjCLanguage.h"
|
DWARF: Add "dwo_num" field to the DIERef class
Summary:
When dwo support was introduced, it used a trick where debug info
entries were referenced by the offset of the compile unit in the main
file, but the die offset was relative to the dwo file. Although there
was some elegance to it, this representation was starting to reach its
breaking point:
- the fact that the skeleton compile unit owned the DWO file meant that
it was impossible (or at least hard and unintuitive) to support DWO
files containing more than one compile unit. These kinds of files are
produced by LTO for example.
- it made it impossible to reference any DIEs in the skeleton compile
unit (although the skeleton units are generally empty, clang still
puts some info into them with -fsplit-dwarf-inlining).
- (current motivation) it made it very hard to support type units placed
in DWO files, as type units don't have any skeleton units which could
be referenced in the main file
This patch addresses this problem by introducing an new
"dwo_num" field to the DIERef class, whose purpose is to identify the
dwo file. It's kind of similar to the dwo_id field in DWARF5 unit
headers, but while this is a 64bit hash whose main purpose is to catch
file mismatches, this is just a smaller integer used to indentify a
loaded dwo file. Currently, this is based on the index of the skeleton
compile unit which owns the dwo file, but it is intended to be
eventually independent of that (to support the LTO use case).
Simultaneously the cu_offset is dropped to conserve space, as it is no
longer necessary. This means we can remove the "BaseObjectOffset" field
from the DWARFUnit class. It also means we can remove some of the
workarounds put in place to support the skeleton-unit+dwo-die combo.
More work is needed to remove all of them, which is out of scope of this
patch.
Reviewers: JDevlieghere, clayborg, aprantl
Subscribers: mehdi_amini, dexonsmith, arphaman, lldb-commits
Differential Revision: https://reviews.llvm.org/D63428
llvm-svn: 364009
2019-06-21 15:56:50 +08:00
|
|
|
#include "Plugins/SymbolFile/DWARF/DWARFDIE.h"
|
|
|
|
#include "Plugins/SymbolFile/DWARF/SymbolFileDWARF.h"
|
2018-06-08 17:10:31 +08:00
|
|
|
|
2018-05-21 22:12:52 +08:00
|
|
|
using namespace lldb_private;
|
|
|
|
using namespace lldb;
|
|
|
|
|
|
|
|
DWARFIndex::~DWARFIndex() = default;
|
2018-06-08 17:10:31 +08:00
|
|
|
|
|
|
|
void DWARFIndex::ProcessFunctionDIE(llvm::StringRef name, DIERef ref,
|
DWARF: Add "dwo_num" field to the DIERef class
Summary:
When dwo support was introduced, it used a trick where debug info
entries were referenced by the offset of the compile unit in the main
file, but the die offset was relative to the dwo file. Although there
was some elegance to it, this representation was starting to reach its
breaking point:
- the fact that the skeleton compile unit owned the DWO file meant that
it was impossible (or at least hard and unintuitive) to support DWO
files containing more than one compile unit. These kinds of files are
produced by LTO for example.
- it made it impossible to reference any DIEs in the skeleton compile
unit (although the skeleton units are generally empty, clang still
puts some info into them with -fsplit-dwarf-inlining).
- (current motivation) it made it very hard to support type units placed
in DWO files, as type units don't have any skeleton units which could
be referenced in the main file
This patch addresses this problem by introducing an new
"dwo_num" field to the DIERef class, whose purpose is to identify the
dwo file. It's kind of similar to the dwo_id field in DWARF5 unit
headers, but while this is a 64bit hash whose main purpose is to catch
file mismatches, this is just a smaller integer used to indentify a
loaded dwo file. Currently, this is based on the index of the skeleton
compile unit which owns the dwo file, but it is intended to be
eventually independent of that (to support the LTO use case).
Simultaneously the cu_offset is dropped to conserve space, as it is no
longer necessary. This means we can remove the "BaseObjectOffset" field
from the DWARFUnit class. It also means we can remove some of the
workarounds put in place to support the skeleton-unit+dwo-die combo.
More work is needed to remove all of them, which is out of scope of this
patch.
Reviewers: JDevlieghere, clayborg, aprantl
Subscribers: mehdi_amini, dexonsmith, arphaman, lldb-commits
Differential Revision: https://reviews.llvm.org/D63428
llvm-svn: 364009
2019-06-21 15:56:50 +08:00
|
|
|
SymbolFileDWARF &dwarf,
|
2018-06-08 17:10:31 +08:00
|
|
|
const CompilerDeclContext &parent_decl_ctx,
|
|
|
|
uint32_t name_type_mask,
|
|
|
|
std::vector<DWARFDIE> &dies) {
|
DWARF: Add "dwo_num" field to the DIERef class
Summary:
When dwo support was introduced, it used a trick where debug info
entries were referenced by the offset of the compile unit in the main
file, but the die offset was relative to the dwo file. Although there
was some elegance to it, this representation was starting to reach its
breaking point:
- the fact that the skeleton compile unit owned the DWO file meant that
it was impossible (or at least hard and unintuitive) to support DWO
files containing more than one compile unit. These kinds of files are
produced by LTO for example.
- it made it impossible to reference any DIEs in the skeleton compile
unit (although the skeleton units are generally empty, clang still
puts some info into them with -fsplit-dwarf-inlining).
- (current motivation) it made it very hard to support type units placed
in DWO files, as type units don't have any skeleton units which could
be referenced in the main file
This patch addresses this problem by introducing an new
"dwo_num" field to the DIERef class, whose purpose is to identify the
dwo file. It's kind of similar to the dwo_id field in DWARF5 unit
headers, but while this is a 64bit hash whose main purpose is to catch
file mismatches, this is just a smaller integer used to indentify a
loaded dwo file. Currently, this is based on the index of the skeleton
compile unit which owns the dwo file, but it is intended to be
eventually independent of that (to support the LTO use case).
Simultaneously the cu_offset is dropped to conserve space, as it is no
longer necessary. This means we can remove the "BaseObjectOffset" field
from the DWARFUnit class. It also means we can remove some of the
workarounds put in place to support the skeleton-unit+dwo-die combo.
More work is needed to remove all of them, which is out of scope of this
patch.
Reviewers: JDevlieghere, clayborg, aprantl
Subscribers: mehdi_amini, dexonsmith, arphaman, lldb-commits
Differential Revision: https://reviews.llvm.org/D63428
llvm-svn: 364009
2019-06-21 15:56:50 +08:00
|
|
|
DWARFDIE die = dwarf.GetDIE(ref);
|
2018-06-08 17:10:31 +08:00
|
|
|
if (!die) {
|
2019-06-14 20:01:18 +08:00
|
|
|
ReportInvalidDIERef(ref, name);
|
2018-06-08 17:10:31 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Exit early if we're searching exclusively for methods or selectors and
|
|
|
|
// we have a context specified (no methods in namespaces).
|
|
|
|
uint32_t looking_for_nonmethods =
|
|
|
|
name_type_mask & ~(eFunctionNameTypeMethod | eFunctionNameTypeSelector);
|
|
|
|
if (!looking_for_nonmethods && parent_decl_ctx.IsValid())
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Otherwise, we need to also check that the context matches. If it does not
|
|
|
|
// match, we do nothing.
|
|
|
|
if (!SymbolFileDWARF::DIEInDeclContext(&parent_decl_ctx, die))
|
|
|
|
return;
|
|
|
|
|
2020-01-28 20:42:34 +08:00
|
|
|
// In case of a full match, we just insert everything we find.
|
|
|
|
if (name_type_mask & eFunctionNameTypeFull) {
|
2018-06-08 17:10:31 +08:00
|
|
|
dies.push_back(die);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If looking for ObjC selectors, we need to also check if the name is a
|
|
|
|
// possible selector.
|
|
|
|
if (name_type_mask & eFunctionNameTypeSelector &&
|
|
|
|
ObjCLanguage::IsPossibleObjCMethodName(die.GetName())) {
|
|
|
|
dies.push_back(die);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool looking_for_methods = name_type_mask & lldb::eFunctionNameTypeMethod;
|
|
|
|
bool looking_for_functions = name_type_mask & lldb::eFunctionNameTypeBase;
|
|
|
|
if (looking_for_methods || looking_for_functions) {
|
|
|
|
// If we're looking for either methods or functions, we definitely want this
|
|
|
|
// die. Otherwise, only keep it if the die type matches what we are
|
|
|
|
// searching for.
|
|
|
|
if ((looking_for_methods && looking_for_functions) ||
|
|
|
|
looking_for_methods == die.IsMethod())
|
|
|
|
dies.push_back(die);
|
|
|
|
}
|
|
|
|
}
|