2002-05-09 06:19:27 +08:00
|
|
|
//===- Reassociate.cpp - Reassociate binary expressions -------------------===//
|
2005-04-22 07:48:37 +08:00
|
|
|
//
|
2003-10-21 03:43:21 +08:00
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 04:36:04 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2005-04-22 07:48:37 +08:00
|
|
|
//
|
2003-10-21 03:43:21 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2002-05-09 06:19:27 +08:00
|
|
|
//
|
|
|
|
// This pass reassociates commutative expressions in an order that is designed
|
2010-01-01 08:04:26 +08:00
|
|
|
// to promote better constant propagation, GCSE, LICM, PRE, etc.
|
2002-05-09 06:19:27 +08:00
|
|
|
//
|
|
|
|
// For example: 4 + (x + 5) -> x + (4 + 5)
|
|
|
|
//
|
|
|
|
// In the implementation of this algorithm, constants are assigned rank = 0,
|
|
|
|
// function arguments are rank = 1, and other values are assigned ranks
|
|
|
|
// corresponding to the reverse post order traversal of current function
|
|
|
|
// (starting at 2), which effectively gives values in deep loops higher rank
|
|
|
|
// than values not in loops.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2005-05-07 12:08:02 +08:00
|
|
|
#define DEBUG_TYPE "reassociate"
|
2002-05-09 06:19:27 +08:00
|
|
|
#include "llvm/Transforms/Scalar.h"
|
2005-05-07 12:24:13 +08:00
|
|
|
#include "llvm/Constants.h"
|
2006-04-28 12:14:49 +08:00
|
|
|
#include "llvm/DerivedTypes.h"
|
2002-05-09 06:19:27 +08:00
|
|
|
#include "llvm/Function.h"
|
2004-07-30 01:05:13 +08:00
|
|
|
#include "llvm/Instructions.h"
|
2009-03-06 09:41:59 +08:00
|
|
|
#include "llvm/IntrinsicInst.h"
|
2002-05-09 06:19:27 +08:00
|
|
|
#include "llvm/Pass.h"
|
2005-05-09 04:09:57 +08:00
|
|
|
#include "llvm/Assembly/Writer.h"
|
2002-05-09 06:19:27 +08:00
|
|
|
#include "llvm/Support/CFG.h"
|
2004-09-02 06:55:40 +08:00
|
|
|
#include "llvm/Support/Debug.h"
|
2009-04-01 06:13:29 +08:00
|
|
|
#include "llvm/Support/ValueHandle.h"
|
2009-08-23 12:37:46 +08:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2004-09-02 06:55:40 +08:00
|
|
|
#include "llvm/ADT/PostOrderIterator.h"
|
|
|
|
#include "llvm/ADT/Statistic.h"
|
2009-12-31 15:33:14 +08:00
|
|
|
#include "llvm/ADT/DenseMap.h"
|
2005-05-08 05:59:39 +08:00
|
|
|
#include <algorithm>
|
2004-01-09 14:02:20 +08:00
|
|
|
using namespace llvm;
|
2003-11-12 06:41:34 +08:00
|
|
|
|
2006-12-20 05:40:18 +08:00
|
|
|
STATISTIC(NumLinear , "Number of insts linearized");
|
|
|
|
STATISTIC(NumChanged, "Number of insts reassociated");
|
|
|
|
STATISTIC(NumAnnihil, "Number of expr tree annihilated");
|
|
|
|
STATISTIC(NumFactor , "Number of multiplies factored");
|
2002-10-02 06:38:41 +08:00
|
|
|
|
2006-12-20 05:40:18 +08:00
|
|
|
namespace {
|
2009-09-02 14:11:42 +08:00
|
|
|
struct ValueEntry {
|
2005-05-08 05:59:39 +08:00
|
|
|
unsigned Rank;
|
|
|
|
Value *Op;
|
|
|
|
ValueEntry(unsigned R, Value *O) : Rank(R), Op(O) {}
|
|
|
|
};
|
|
|
|
inline bool operator<(const ValueEntry &LHS, const ValueEntry &RHS) {
|
|
|
|
return LHS.Rank > RHS.Rank; // Sort so that highest rank goes to start.
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
2005-05-08 05:59:39 +08:00
|
|
|
|
2008-11-22 05:00:20 +08:00
|
|
|
#ifndef NDEBUG
|
2006-03-04 17:31:13 +08:00
|
|
|
/// PrintOps - Print out the expression identified in the Ops list.
|
|
|
|
///
|
2010-01-01 02:40:32 +08:00
|
|
|
static void PrintOps(Instruction *I, const SmallVectorImpl<ValueEntry> &Ops) {
|
2006-03-04 17:31:13 +08:00
|
|
|
Module *M = I->getParent()->getParent()->getParent();
|
2010-01-05 09:27:24 +08:00
|
|
|
dbgs() << Instruction::getOpcodeName(I->getOpcode()) << " "
|
2009-12-31 15:17:37 +08:00
|
|
|
<< *Ops[0].Op->getType() << '\t';
|
2008-08-19 12:45:19 +08:00
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
2010-01-05 09:27:24 +08:00
|
|
|
dbgs() << "[ ";
|
|
|
|
WriteAsOperand(dbgs(), Ops[i].Op, false, M);
|
|
|
|
dbgs() << ", #" << Ops[i].Rank << "] ";
|
2008-08-19 12:45:19 +08:00
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
2008-11-22 04:00:59 +08:00
|
|
|
#endif
|
2006-03-04 17:31:13 +08:00
|
|
|
|
2008-05-13 08:00:25 +08:00
|
|
|
namespace {
|
2009-09-02 14:11:42 +08:00
|
|
|
class Reassociate : public FunctionPass {
|
2010-01-01 08:01:34 +08:00
|
|
|
DenseMap<BasicBlock*, unsigned> RankMap;
|
|
|
|
DenseMap<AssertingVH<>, unsigned> ValueRankMap;
|
2005-05-08 05:59:39 +08:00
|
|
|
bool MadeChange;
|
2002-05-09 06:19:27 +08:00
|
|
|
public:
|
2007-05-06 21:37:16 +08:00
|
|
|
static char ID; // Pass identification, replacement for typeid
|
2008-09-05 01:05:41 +08:00
|
|
|
Reassociate() : FunctionPass(&ID) {}
|
2007-05-02 05:15:47 +08:00
|
|
|
|
2002-06-26 00:13:24 +08:00
|
|
|
bool runOnFunction(Function &F);
|
2002-05-09 06:19:27 +08:00
|
|
|
|
|
|
|
virtual void getAnalysisUsage(AnalysisUsage &AU) const {
|
2002-10-22 04:00:28 +08:00
|
|
|
AU.setPreservesCFG();
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
private:
|
2002-06-26 00:13:24 +08:00
|
|
|
void BuildRankMap(Function &F);
|
2002-05-09 06:19:27 +08:00
|
|
|
unsigned getRank(Value *V);
|
2010-01-01 03:24:52 +08:00
|
|
|
Value *ReassociateExpression(BinaryOperator *I);
|
2010-01-01 02:40:32 +08:00
|
|
|
void RewriteExprTree(BinaryOperator *I, SmallVectorImpl<ValueEntry> &Ops,
|
2006-03-15 00:04:29 +08:00
|
|
|
unsigned Idx = 0);
|
2010-01-01 02:40:32 +08:00
|
|
|
Value *OptimizeExpression(BinaryOperator *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops);
|
|
|
|
Value *OptimizeAdd(Instruction *I, SmallVectorImpl<ValueEntry> &Ops);
|
|
|
|
void LinearizeExprTree(BinaryOperator *I, SmallVectorImpl<ValueEntry> &Ops);
|
2005-05-08 05:59:39 +08:00
|
|
|
void LinearizeExpr(BinaryOperator *I);
|
2006-03-04 17:31:13 +08:00
|
|
|
Value *RemoveFactorFromExpression(Value *V, Value *Factor);
|
2005-05-08 05:59:39 +08:00
|
|
|
void ReassociateBB(BasicBlock *BB);
|
2006-03-04 17:31:13 +08:00
|
|
|
|
|
|
|
void RemoveDeadBinaryOp(Value *V);
|
2002-05-09 06:19:27 +08:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2008-05-13 08:00:25 +08:00
|
|
|
char Reassociate::ID = 0;
|
|
|
|
static RegisterPass<Reassociate> X("reassociate", "Reassociate expressions");
|
|
|
|
|
2003-11-12 06:41:34 +08:00
|
|
|
// Public interface to the Reassociate pass
|
2004-01-09 14:02:20 +08:00
|
|
|
FunctionPass *llvm::createReassociatePass() { return new Reassociate(); }
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2006-03-04 17:31:13 +08:00
|
|
|
void Reassociate::RemoveDeadBinaryOp(Value *V) {
|
2006-12-23 14:05:41 +08:00
|
|
|
Instruction *Op = dyn_cast<Instruction>(V);
|
2010-01-01 03:24:52 +08:00
|
|
|
if (!Op || !isa<BinaryOperator>(Op) || !Op->use_empty())
|
2006-12-23 14:05:41 +08:00
|
|
|
return;
|
2006-03-04 17:31:13 +08:00
|
|
|
|
2006-12-23 14:05:41 +08:00
|
|
|
Value *LHS = Op->getOperand(0), *RHS = Op->getOperand(1);
|
2010-01-01 03:24:52 +08:00
|
|
|
|
|
|
|
ValueRankMap.erase(Op);
|
|
|
|
Op->eraseFromParent();
|
2006-03-04 17:31:13 +08:00
|
|
|
RemoveDeadBinaryOp(LHS);
|
|
|
|
RemoveDeadBinaryOp(RHS);
|
|
|
|
}
|
|
|
|
|
2005-05-09 04:57:04 +08:00
|
|
|
|
|
|
|
static bool isUnmovableInstruction(Instruction *I) {
|
|
|
|
if (I->getOpcode() == Instruction::PHI ||
|
|
|
|
I->getOpcode() == Instruction::Alloca ||
|
|
|
|
I->getOpcode() == Instruction::Load ||
|
|
|
|
I->getOpcode() == Instruction::Invoke ||
|
2009-03-06 09:41:59 +08:00
|
|
|
(I->getOpcode() == Instruction::Call &&
|
|
|
|
!isa<DbgInfoIntrinsic>(I)) ||
|
2006-10-26 14:15:43 +08:00
|
|
|
I->getOpcode() == Instruction::UDiv ||
|
|
|
|
I->getOpcode() == Instruction::SDiv ||
|
|
|
|
I->getOpcode() == Instruction::FDiv ||
|
2006-11-02 09:53:59 +08:00
|
|
|
I->getOpcode() == Instruction::URem ||
|
|
|
|
I->getOpcode() == Instruction::SRem ||
|
|
|
|
I->getOpcode() == Instruction::FRem)
|
2005-05-09 04:57:04 +08:00
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2002-06-26 00:13:24 +08:00
|
|
|
void Reassociate::BuildRankMap(Function &F) {
|
2003-08-13 04:14:27 +08:00
|
|
|
unsigned i = 2;
|
2003-08-14 00:16:26 +08:00
|
|
|
|
|
|
|
// Assign distinct ranks to function arguments
|
2005-03-15 12:54:21 +08:00
|
|
|
for (Function::arg_iterator I = F.arg_begin(), E = F.arg_end(); I != E; ++I)
|
2009-04-01 06:13:29 +08:00
|
|
|
ValueRankMap[&*I] = ++i;
|
2003-08-14 00:16:26 +08:00
|
|
|
|
2002-06-26 00:13:24 +08:00
|
|
|
ReversePostOrderTraversal<Function*> RPOT(&F);
|
2002-05-09 06:19:27 +08:00
|
|
|
for (ReversePostOrderTraversal<Function*>::rpo_iterator I = RPOT.begin(),
|
2005-05-09 04:57:04 +08:00
|
|
|
E = RPOT.end(); I != E; ++I) {
|
|
|
|
BasicBlock *BB = *I;
|
|
|
|
unsigned BBRank = RankMap[BB] = ++i << 16;
|
|
|
|
|
|
|
|
// Walk the basic block, adding precomputed ranks for any instructions that
|
|
|
|
// we cannot move. This ensures that the ranks for these instructions are
|
|
|
|
// all different in the block.
|
|
|
|
for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I)
|
|
|
|
if (isUnmovableInstruction(I))
|
2009-04-01 06:13:29 +08:00
|
|
|
ValueRankMap[&*I] = ++BBRank;
|
2005-05-09 04:57:04 +08:00
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
unsigned Reassociate::getRank(Value *V) {
|
2005-05-07 12:08:02 +08:00
|
|
|
Instruction *I = dyn_cast<Instruction>(V);
|
2010-01-01 08:01:34 +08:00
|
|
|
if (I == 0) {
|
|
|
|
if (isa<Argument>(V)) return ValueRankMap[V]; // Function argument.
|
|
|
|
return 0; // Otherwise it's a global or constant, rank 0.
|
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2010-01-01 08:01:34 +08:00
|
|
|
if (unsigned Rank = ValueRankMap[I])
|
|
|
|
return Rank; // Rank already known?
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2005-05-07 12:08:02 +08:00
|
|
|
// If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that
|
|
|
|
// we can reassociate expressions for code motion! Since we do not recurse
|
|
|
|
// for PHI nodes, we cannot have infinite recursion here, because there
|
|
|
|
// cannot be loops in the value graph that do not go through PHI nodes.
|
|
|
|
unsigned Rank = 0, MaxRank = RankMap[I->getParent()];
|
|
|
|
for (unsigned i = 0, e = I->getNumOperands();
|
|
|
|
i != e && Rank != MaxRank; ++i)
|
|
|
|
Rank = std::max(Rank, getRank(I->getOperand(i)));
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2005-05-08 08:08:33 +08:00
|
|
|
// If this is a not or neg instruction, do not count it for rank. This
|
|
|
|
// assures us that X and ~X will have the same rank.
|
2010-02-16 00:12:20 +08:00
|
|
|
if (!I->getType()->isIntegerTy() ||
|
2009-07-14 06:18:28 +08:00
|
|
|
(!BinaryOperator::isNot(I) && !BinaryOperator::isNeg(I)))
|
2005-05-08 08:08:33 +08:00
|
|
|
++Rank;
|
|
|
|
|
2010-01-05 09:27:24 +08:00
|
|
|
//DEBUG(dbgs() << "Calculated Rank[" << V->getName() << "] = "
|
2009-08-23 12:37:46 +08:00
|
|
|
// << Rank << "\n");
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2010-01-01 08:01:34 +08:00
|
|
|
return ValueRankMap[I] = Rank;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
/// isReassociableOp - Return true if V is an instruction of the specified
|
|
|
|
/// opcode and if it only has one use.
|
|
|
|
static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) {
|
2006-03-15 00:04:29 +08:00
|
|
|
if ((V->hasOneUse() || V->use_empty()) && isa<Instruction>(V) &&
|
2005-05-08 05:59:39 +08:00
|
|
|
cast<Instruction>(V)->getOpcode() == Opcode)
|
|
|
|
return cast<BinaryOperator>(V);
|
|
|
|
return 0;
|
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2005-05-09 05:28:52 +08:00
|
|
|
/// LowerNegateToMultiply - Replace 0-X with X*-1.
|
|
|
|
///
|
2009-03-20 01:22:53 +08:00
|
|
|
static Instruction *LowerNegateToMultiply(Instruction *Neg,
|
2010-01-01 08:01:34 +08:00
|
|
|
DenseMap<AssertingVH<>, unsigned> &ValueRankMap) {
|
2009-08-01 04:28:14 +08:00
|
|
|
Constant *Cst = Constant::getAllOnesValue(Neg->getType());
|
2005-05-09 05:28:52 +08:00
|
|
|
|
2008-05-17 03:29:10 +08:00
|
|
|
Instruction *Res = BinaryOperator::CreateMul(Neg->getOperand(1), Cst, "",Neg);
|
2009-03-20 01:22:53 +08:00
|
|
|
ValueRankMap.erase(Neg);
|
2007-02-11 09:23:03 +08:00
|
|
|
Res->takeName(Neg);
|
2005-05-09 05:28:52 +08:00
|
|
|
Neg->replaceAllUsesWith(Res);
|
|
|
|
Neg->eraseFromParent();
|
|
|
|
return Res;
|
|
|
|
}
|
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
// Given an expression of the form '(A+B)+(D+C)', turn it into '(((A+B)+C)+D)'.
|
|
|
|
// Note that if D is also part of the expression tree that we recurse to
|
|
|
|
// linearize it as well. Besides that case, this does not recurse into A,B, or
|
|
|
|
// C.
|
|
|
|
void Reassociate::LinearizeExpr(BinaryOperator *I) {
|
|
|
|
BinaryOperator *LHS = cast<BinaryOperator>(I->getOperand(0));
|
|
|
|
BinaryOperator *RHS = cast<BinaryOperator>(I->getOperand(1));
|
2005-07-27 14:12:32 +08:00
|
|
|
assert(isReassociableOp(LHS, I->getOpcode()) &&
|
2005-05-08 05:59:39 +08:00
|
|
|
isReassociableOp(RHS, I->getOpcode()) &&
|
|
|
|
"Not an expression that needs linearization?");
|
|
|
|
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "Linear" << *LHS << '\n' << *RHS << '\n' << *I << '\n');
|
2005-05-08 05:59:39 +08:00
|
|
|
|
|
|
|
// Move the RHS instruction to live immediately before I, avoiding breaking
|
|
|
|
// dominator properties.
|
2005-08-09 03:11:57 +08:00
|
|
|
RHS->moveBefore(I);
|
2005-05-08 05:59:39 +08:00
|
|
|
|
|
|
|
// Move operands around to do the linearization.
|
|
|
|
I->setOperand(1, RHS->getOperand(0));
|
|
|
|
RHS->setOperand(0, LHS);
|
|
|
|
I->setOperand(0, RHS);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
++NumLinear;
|
|
|
|
MadeChange = true;
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "Linearized: " << *I << '\n');
|
2005-04-22 07:48:37 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
// If D is part of this expression tree, tail recurse.
|
|
|
|
if (isReassociableOp(I->getOperand(1), I->getOpcode()))
|
|
|
|
LinearizeExpr(I);
|
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2002-11-01 01:12:59 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
/// LinearizeExprTree - Given an associative binary expression tree, traverse
|
|
|
|
/// all of the uses putting it into canonical form. This forces a left-linear
|
2010-02-11 00:03:48 +08:00
|
|
|
/// form of the expression (((a+b)+c)+d), and collects information about the
|
2005-05-08 05:59:39 +08:00
|
|
|
/// rank of the non-tree operands.
|
|
|
|
///
|
2006-03-15 00:04:29 +08:00
|
|
|
/// NOTE: These intentionally destroys the expression tree operands (turning
|
|
|
|
/// them into undef values) to reduce #uses of the values. This means that the
|
|
|
|
/// caller MUST use something like RewriteExprTree to put the values back in.
|
|
|
|
///
|
2005-05-08 05:59:39 +08:00
|
|
|
void Reassociate::LinearizeExprTree(BinaryOperator *I,
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2005-05-08 05:59:39 +08:00
|
|
|
Value *LHS = I->getOperand(0), *RHS = I->getOperand(1);
|
|
|
|
unsigned Opcode = I->getOpcode();
|
|
|
|
|
|
|
|
// First step, linearize the expression if it is in ((A+B)+(C+D)) form.
|
|
|
|
BinaryOperator *LHSBO = isReassociableOp(LHS, Opcode);
|
|
|
|
BinaryOperator *RHSBO = isReassociableOp(RHS, Opcode);
|
|
|
|
|
2005-05-09 05:28:52 +08:00
|
|
|
// If this is a multiply expression tree and it contains internal negations,
|
|
|
|
// transform them into multiplies by -1 so they can be reassociated.
|
|
|
|
if (I->getOpcode() == Instruction::Mul) {
|
2009-07-14 06:18:28 +08:00
|
|
|
if (!LHSBO && LHS->hasOneUse() && BinaryOperator::isNeg(LHS)) {
|
2009-11-14 15:25:54 +08:00
|
|
|
LHS = LowerNegateToMultiply(cast<Instruction>(LHS), ValueRankMap);
|
2005-05-09 05:28:52 +08:00
|
|
|
LHSBO = isReassociableOp(LHS, Opcode);
|
|
|
|
}
|
2009-07-14 06:18:28 +08:00
|
|
|
if (!RHSBO && RHS->hasOneUse() && BinaryOperator::isNeg(RHS)) {
|
2009-11-14 15:25:54 +08:00
|
|
|
RHS = LowerNegateToMultiply(cast<Instruction>(RHS), ValueRankMap);
|
2005-05-09 05:28:52 +08:00
|
|
|
RHSBO = isReassociableOp(RHS, Opcode);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
if (!LHSBO) {
|
|
|
|
if (!RHSBO) {
|
|
|
|
// Neither the LHS or RHS as part of the tree, thus this is a leaf. As
|
|
|
|
// such, just remember these operands and their rank.
|
|
|
|
Ops.push_back(ValueEntry(getRank(LHS), LHS));
|
|
|
|
Ops.push_back(ValueEntry(getRank(RHS), RHS));
|
2006-03-15 00:04:29 +08:00
|
|
|
|
|
|
|
// Clear the leaves out.
|
2009-07-31 07:03:37 +08:00
|
|
|
I->setOperand(0, UndefValue::get(I->getType()));
|
|
|
|
I->setOperand(1, UndefValue::get(I->getType()));
|
2005-05-08 05:59:39 +08:00
|
|
|
return;
|
|
|
|
}
|
2009-12-31 15:59:34 +08:00
|
|
|
|
|
|
|
// Turn X+(Y+Z) -> (Y+Z)+X
|
|
|
|
std::swap(LHSBO, RHSBO);
|
|
|
|
std::swap(LHS, RHS);
|
|
|
|
bool Success = !I->swapOperands();
|
|
|
|
assert(Success && "swapOperands failed");
|
|
|
|
Success = false;
|
|
|
|
MadeChange = true;
|
2005-05-08 05:59:39 +08:00
|
|
|
} else if (RHSBO) {
|
2010-02-11 00:03:48 +08:00
|
|
|
// Turn (A+B)+(C+D) -> (((A+B)+C)+D). This guarantees the RHS is not
|
2005-05-08 05:59:39 +08:00
|
|
|
// part of the expression tree.
|
|
|
|
LinearizeExpr(I);
|
|
|
|
LHS = LHSBO = cast<BinaryOperator>(I->getOperand(0));
|
|
|
|
RHS = I->getOperand(1);
|
|
|
|
RHSBO = 0;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
2005-04-22 07:48:37 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
// Okay, now we know that the LHS is a nested expression and that the RHS is
|
|
|
|
// not. Perform reassociation.
|
|
|
|
assert(!isReassociableOp(RHS, Opcode) && "LinearizeExpr failed!");
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
// Move LHS right before I to make sure that the tree expression dominates all
|
|
|
|
// values.
|
2005-08-09 03:11:57 +08:00
|
|
|
LHSBO->moveBefore(I);
|
2005-05-08 05:59:39 +08:00
|
|
|
|
|
|
|
// Linearize the expression tree on the LHS.
|
|
|
|
LinearizeExprTree(LHSBO, Ops);
|
|
|
|
|
|
|
|
// Remember the RHS operand and its rank.
|
|
|
|
Ops.push_back(ValueEntry(getRank(RHS), RHS));
|
2006-03-15 00:04:29 +08:00
|
|
|
|
|
|
|
// Clear the RHS leaf out.
|
2009-07-31 07:03:37 +08:00
|
|
|
I->setOperand(1, UndefValue::get(I->getType()));
|
2005-05-08 05:59:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// RewriteExprTree - Now that the operands for this expression tree are
|
|
|
|
// linearized and optimized, emit them in-order. This function is written to be
|
|
|
|
// tail recursive.
|
2006-03-15 00:04:29 +08:00
|
|
|
void Reassociate::RewriteExprTree(BinaryOperator *I,
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVectorImpl<ValueEntry> &Ops,
|
2006-03-15 00:04:29 +08:00
|
|
|
unsigned i) {
|
2005-05-08 05:59:39 +08:00
|
|
|
if (i+2 == Ops.size()) {
|
|
|
|
if (I->getOperand(0) != Ops[i].Op ||
|
|
|
|
I->getOperand(1) != Ops[i+1].Op) {
|
2006-03-04 17:31:13 +08:00
|
|
|
Value *OldLHS = I->getOperand(0);
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "RA: " << *I << '\n');
|
2005-05-08 05:59:39 +08:00
|
|
|
I->setOperand(0, Ops[i].Op);
|
|
|
|
I->setOperand(1, Ops[i+1].Op);
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "TO: " << *I << '\n');
|
2005-05-08 05:59:39 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumChanged;
|
2006-03-04 17:31:13 +08:00
|
|
|
|
|
|
|
// If we reassociated a tree to fewer operands (e.g. (1+a+2) -> (a+3)
|
|
|
|
// delete the extra, now dead, nodes.
|
|
|
|
RemoveDeadBinaryOp(OldLHS);
|
2005-05-08 05:59:39 +08:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
assert(i+2 < Ops.size() && "Ops index out of range!");
|
|
|
|
|
|
|
|
if (I->getOperand(1) != Ops[i].Op) {
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "RA: " << *I << '\n');
|
2005-05-08 05:59:39 +08:00
|
|
|
I->setOperand(1, Ops[i].Op);
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "TO: " << *I << '\n');
|
2005-05-08 05:59:39 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumChanged;
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
|
|
|
BinaryOperator *LHS = cast<BinaryOperator>(I->getOperand(0));
|
|
|
|
assert(LHS->getOpcode() == I->getOpcode() &&
|
|
|
|
"Improper expression tree!");
|
|
|
|
|
|
|
|
// Compactify the tree instructions together with each other to guarantee
|
|
|
|
// that the expression tree is dominated by all of Ops.
|
|
|
|
LHS->moveBefore(I);
|
2006-03-15 00:04:29 +08:00
|
|
|
RewriteExprTree(LHS, Ops, i+1);
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
|
2002-05-16 12:37:07 +08:00
|
|
|
// NegateValue - Insert instructions before the instruction pointed to by BI,
|
|
|
|
// that computes the negative version of the value specified. The negative
|
|
|
|
// version of the value is returned, and BI is left pointing at the instruction
|
|
|
|
// that should be processed next by the reassociation pass.
|
|
|
|
//
|
2009-11-14 15:25:54 +08:00
|
|
|
static Value *NegateValue(Value *V, Instruction *BI) {
|
2010-01-01 04:34:32 +08:00
|
|
|
if (Constant *C = dyn_cast<Constant>(V))
|
|
|
|
return ConstantExpr::getNeg(C);
|
|
|
|
|
2002-05-16 12:37:07 +08:00
|
|
|
// We are trying to expose opportunity for reassociation. One of the things
|
|
|
|
// that we want to do to achieve this is to push a negation as deep into an
|
|
|
|
// expression chain as possible, to expose the add instructions. In practice,
|
|
|
|
// this means that we turn this:
|
|
|
|
// X = -(A+12+C+D) into X = -A + -12 + -C + -D = -12 + -A + -C + -D
|
|
|
|
// so that later, a: Y = 12+X could get reassociated with the -12 to eliminate
|
|
|
|
// the constants. We assume that instcombine will clean up the mess later if
|
2010-01-01 08:04:26 +08:00
|
|
|
// we introduce tons of unnecessary negation instructions.
|
2002-05-16 12:37:07 +08:00
|
|
|
//
|
|
|
|
if (Instruction *I = dyn_cast<Instruction>(V))
|
2003-10-16 00:48:29 +08:00
|
|
|
if (I->getOpcode() == Instruction::Add && I->hasOneUse()) {
|
2005-09-02 14:38:04 +08:00
|
|
|
// Push the negates through the add.
|
2009-11-14 15:25:54 +08:00
|
|
|
I->setOperand(0, NegateValue(I->getOperand(0), BI));
|
|
|
|
I->setOperand(1, NegateValue(I->getOperand(1), BI));
|
2005-09-02 14:38:04 +08:00
|
|
|
|
|
|
|
// We must move the add instruction here, because the neg instructions do
|
|
|
|
// not dominate the old add instruction in general. By moving it, we are
|
|
|
|
// assured that the neg instructions we just inserted dominate the
|
|
|
|
// instruction we are about to insert after them.
|
2002-05-16 12:37:07 +08:00
|
|
|
//
|
2005-09-02 14:38:04 +08:00
|
|
|
I->moveBefore(BI);
|
|
|
|
I->setName(I->getName()+".neg");
|
|
|
|
return I;
|
2002-05-16 12:37:07 +08:00
|
|
|
}
|
2010-01-01 04:34:32 +08:00
|
|
|
|
|
|
|
// Okay, we need to materialize a negated version of V with an instruction.
|
|
|
|
// Scan the use lists of V to see if we have one already.
|
|
|
|
for (Value::use_iterator UI = V->use_begin(), E = V->use_end(); UI != E;++UI){
|
|
|
|
if (!BinaryOperator::isNeg(*UI)) continue;
|
|
|
|
|
|
|
|
// We found one! Now we have to make sure that the definition dominates
|
|
|
|
// this use. We do this by moving it to the entry block (if it is a
|
|
|
|
// non-instruction value) or right after the definition. These negates will
|
|
|
|
// be zapped by reassociate later, so we don't need much finesse here.
|
|
|
|
BinaryOperator *TheNeg = cast<BinaryOperator>(*UI);
|
2010-01-03 05:46:33 +08:00
|
|
|
|
|
|
|
// Verify that the negate is in this function, V might be a constant expr.
|
|
|
|
if (TheNeg->getParent()->getParent() != BI->getParent()->getParent())
|
|
|
|
continue;
|
2010-01-01 04:34:32 +08:00
|
|
|
|
|
|
|
BasicBlock::iterator InsertPt;
|
|
|
|
if (Instruction *InstInput = dyn_cast<Instruction>(V)) {
|
|
|
|
if (InvokeInst *II = dyn_cast<InvokeInst>(InstInput)) {
|
|
|
|
InsertPt = II->getNormalDest()->begin();
|
|
|
|
} else {
|
|
|
|
InsertPt = InstInput;
|
|
|
|
++InsertPt;
|
|
|
|
}
|
|
|
|
while (isa<PHINode>(InsertPt)) ++InsertPt;
|
|
|
|
} else {
|
|
|
|
InsertPt = TheNeg->getParent()->getParent()->getEntryBlock().begin();
|
|
|
|
}
|
|
|
|
TheNeg->moveBefore(InsertPt);
|
|
|
|
return TheNeg;
|
|
|
|
}
|
2002-05-16 12:37:07 +08:00
|
|
|
|
|
|
|
// Insert a 'neg' instruction that subtracts the value from zero to get the
|
|
|
|
// negation.
|
2009-08-13 00:23:25 +08:00
|
|
|
return BinaryOperator::CreateNeg(V, V->getName() + ".neg", BI);
|
2002-05-16 12:37:07 +08:00
|
|
|
}
|
|
|
|
|
2008-02-18 04:44:51 +08:00
|
|
|
/// ShouldBreakUpSubtract - Return true if we should break up this subtract of
|
|
|
|
/// X-Y into (X + -Y).
|
2009-11-14 15:25:54 +08:00
|
|
|
static bool ShouldBreakUpSubtract(Instruction *Sub) {
|
2008-02-18 04:44:51 +08:00
|
|
|
// If this is a negation, we can't split it up!
|
2009-07-14 06:18:28 +08:00
|
|
|
if (BinaryOperator::isNeg(Sub))
|
2008-02-18 04:44:51 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Don't bother to break this up unless either the LHS is an associable add or
|
2008-02-18 04:51:26 +08:00
|
|
|
// subtract or if this is only used by one.
|
|
|
|
if (isReassociableOp(Sub->getOperand(0), Instruction::Add) ||
|
|
|
|
isReassociableOp(Sub->getOperand(0), Instruction::Sub))
|
2008-02-18 04:44:51 +08:00
|
|
|
return true;
|
2008-02-18 04:51:26 +08:00
|
|
|
if (isReassociableOp(Sub->getOperand(1), Instruction::Add) ||
|
2008-02-18 04:54:40 +08:00
|
|
|
isReassociableOp(Sub->getOperand(1), Instruction::Sub))
|
2008-02-18 04:44:51 +08:00
|
|
|
return true;
|
2008-02-18 04:51:26 +08:00
|
|
|
if (Sub->hasOneUse() &&
|
|
|
|
(isReassociableOp(Sub->use_back(), Instruction::Add) ||
|
|
|
|
isReassociableOp(Sub->use_back(), Instruction::Sub)))
|
2008-02-18 04:44:51 +08:00
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2005-05-07 12:08:02 +08:00
|
|
|
/// BreakUpSubtract - If we have (X-Y), and if either X is an add, or if this is
|
|
|
|
/// only used by an add, transform this into (X+(0-Y)) to promote better
|
|
|
|
/// reassociation.
|
2009-11-14 15:25:54 +08:00
|
|
|
static Instruction *BreakUpSubtract(Instruction *Sub,
|
2010-01-01 08:01:34 +08:00
|
|
|
DenseMap<AssertingVH<>, unsigned> &ValueRankMap) {
|
2010-01-01 08:04:26 +08:00
|
|
|
// Convert a subtract into an add and a neg instruction. This allows sub
|
|
|
|
// instructions to be commuted with other add instructions.
|
2005-05-07 12:08:02 +08:00
|
|
|
//
|
2010-01-01 08:04:26 +08:00
|
|
|
// Calculate the negative value of Operand 1 of the sub instruction,
|
|
|
|
// and set it as the RHS of the add instruction we just made.
|
2005-05-07 12:08:02 +08:00
|
|
|
//
|
2009-11-14 15:25:54 +08:00
|
|
|
Value *NegVal = NegateValue(Sub->getOperand(1), Sub);
|
2005-05-07 12:08:02 +08:00
|
|
|
Instruction *New =
|
2008-05-17 03:29:10 +08:00
|
|
|
BinaryOperator::CreateAdd(Sub->getOperand(0), NegVal, "", Sub);
|
2007-02-11 09:23:03 +08:00
|
|
|
New->takeName(Sub);
|
2005-05-07 12:08:02 +08:00
|
|
|
|
|
|
|
// Everyone now refers to the add instruction.
|
2009-03-20 01:22:53 +08:00
|
|
|
ValueRankMap.erase(Sub);
|
2005-05-07 12:08:02 +08:00
|
|
|
Sub->replaceAllUsesWith(New);
|
|
|
|
Sub->eraseFromParent();
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "Negated: " << *New << '\n');
|
2005-05-07 12:08:02 +08:00
|
|
|
return New;
|
|
|
|
}
|
|
|
|
|
2005-05-07 12:24:13 +08:00
|
|
|
/// ConvertShiftToMul - If this is a shift of a reassociable multiply or is used
|
|
|
|
/// by one, change this into a multiply by a constant to assist with further
|
|
|
|
/// reassociation.
|
2009-03-20 01:22:53 +08:00
|
|
|
static Instruction *ConvertShiftToMul(Instruction *Shl,
|
2010-01-01 08:01:34 +08:00
|
|
|
DenseMap<AssertingVH<>, unsigned> &ValueRankMap) {
|
2006-03-14 14:55:18 +08:00
|
|
|
// If an operand of this shift is a reassociable multiply, or if the shift
|
|
|
|
// is used by a reassociable multiply or add, turn into a multiply.
|
|
|
|
if (isReassociableOp(Shl->getOperand(0), Instruction::Mul) ||
|
|
|
|
(Shl->hasOneUse() &&
|
|
|
|
(isReassociableOp(Shl->use_back(), Instruction::Mul) ||
|
|
|
|
isReassociableOp(Shl->use_back(), Instruction::Add)))) {
|
2009-07-25 07:12:02 +08:00
|
|
|
Constant *MulCst = ConstantInt::get(Shl->getType(), 1);
|
2009-12-31 15:59:34 +08:00
|
|
|
MulCst = ConstantExpr::getShl(MulCst, cast<Constant>(Shl->getOperand(1)));
|
2006-03-14 14:55:18 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
Instruction *Mul =
|
|
|
|
BinaryOperator::CreateMul(Shl->getOperand(0), MulCst, "", Shl);
|
2009-03-20 01:22:53 +08:00
|
|
|
ValueRankMap.erase(Shl);
|
2007-02-11 09:23:03 +08:00
|
|
|
Mul->takeName(Shl);
|
2006-03-14 14:55:18 +08:00
|
|
|
Shl->replaceAllUsesWith(Mul);
|
|
|
|
Shl->eraseFromParent();
|
|
|
|
return Mul;
|
|
|
|
}
|
|
|
|
return 0;
|
2005-05-07 12:24:13 +08:00
|
|
|
}
|
|
|
|
|
2005-05-09 02:59:37 +08:00
|
|
|
// Scan backwards and forwards among values with the same rank as element i to
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
// see if X exists. If X does not exist, return i. This is useful when
|
|
|
|
// scanning for 'x' when we see '-x' because they both get the same rank.
|
2010-01-01 02:40:32 +08:00
|
|
|
static unsigned FindInOperandList(SmallVectorImpl<ValueEntry> &Ops, unsigned i,
|
2005-05-09 02:59:37 +08:00
|
|
|
Value *X) {
|
|
|
|
unsigned XRank = Ops[i].Rank;
|
|
|
|
unsigned e = Ops.size();
|
|
|
|
for (unsigned j = i+1; j != e && Ops[j].Rank == XRank; ++j)
|
|
|
|
if (Ops[j].Op == X)
|
|
|
|
return j;
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
// Scan backwards.
|
2005-05-09 02:59:37 +08:00
|
|
|
for (unsigned j = i-1; j != ~0U && Ops[j].Rank == XRank; --j)
|
|
|
|
if (Ops[j].Op == X)
|
|
|
|
return j;
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
2006-03-04 17:31:13 +08:00
|
|
|
/// EmitAddTreeOfValues - Emit a tree of add instructions, summing Ops together
|
|
|
|
/// and returning the result. Insert the tree before I.
|
2009-12-31 15:48:51 +08:00
|
|
|
static Value *EmitAddTreeOfValues(Instruction *I, SmallVectorImpl<Value*> &Ops){
|
2006-03-04 17:31:13 +08:00
|
|
|
if (Ops.size() == 1) return Ops.back();
|
|
|
|
|
|
|
|
Value *V1 = Ops.back();
|
|
|
|
Ops.pop_back();
|
|
|
|
Value *V2 = EmitAddTreeOfValues(I, Ops);
|
2008-05-17 03:29:10 +08:00
|
|
|
return BinaryOperator::CreateAdd(V2, V1, "tmp", I);
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// RemoveFactorFromExpression - If V is an expression tree that is a
|
|
|
|
/// multiplication sequence, and if this sequence contains a multiply by Factor,
|
|
|
|
/// remove Factor from the tree and return the new tree.
|
|
|
|
Value *Reassociate::RemoveFactorFromExpression(Value *V, Value *Factor) {
|
|
|
|
BinaryOperator *BO = isReassociableOp(V, Instruction::Mul);
|
|
|
|
if (!BO) return 0;
|
|
|
|
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVector<ValueEntry, 8> Factors;
|
2006-03-04 17:31:13 +08:00
|
|
|
LinearizeExprTree(BO, Factors);
|
|
|
|
|
|
|
|
bool FoundFactor = false;
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
bool NeedsNegate = false;
|
|
|
|
for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
|
2006-03-04 17:31:13 +08:00
|
|
|
if (Factors[i].Op == Factor) {
|
|
|
|
FoundFactor = true;
|
|
|
|
Factors.erase(Factors.begin()+i);
|
|
|
|
break;
|
|
|
|
}
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
|
|
|
|
// If this is a negative version of this factor, remove it.
|
|
|
|
if (ConstantInt *FC1 = dyn_cast<ConstantInt>(Factor))
|
|
|
|
if (ConstantInt *FC2 = dyn_cast<ConstantInt>(Factors[i].Op))
|
|
|
|
if (FC1->getValue() == -FC2->getValue()) {
|
|
|
|
FoundFactor = NeedsNegate = true;
|
|
|
|
Factors.erase(Factors.begin()+i);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-03-15 00:04:29 +08:00
|
|
|
if (!FoundFactor) {
|
|
|
|
// Make sure to restore the operands to the expression tree.
|
|
|
|
RewriteExprTree(BO, Factors);
|
|
|
|
return 0;
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
BasicBlock::iterator InsertPt = BO; ++InsertPt;
|
|
|
|
|
2010-01-01 03:34:45 +08:00
|
|
|
// If this was just a single multiply, remove the multiply and return the only
|
|
|
|
// remaining operand.
|
|
|
|
if (Factors.size() == 1) {
|
|
|
|
ValueRankMap.erase(BO);
|
|
|
|
BO->eraseFromParent();
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
V = Factors[0].Op;
|
|
|
|
} else {
|
|
|
|
RewriteExprTree(BO, Factors);
|
|
|
|
V = BO;
|
2010-01-01 03:34:45 +08:00
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
if (NeedsNegate)
|
|
|
|
V = BinaryOperator::CreateNeg(V, "neg", InsertPt);
|
|
|
|
|
|
|
|
return V;
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
|
|
|
|
2006-03-15 00:04:29 +08:00
|
|
|
/// FindSingleUseMultiplyFactors - If V is a single-use multiply, recursively
|
|
|
|
/// add its operands as factors, otherwise add V to the list of factors.
|
2010-03-05 15:18:54 +08:00
|
|
|
///
|
|
|
|
/// Ops is the top-level list of add operands we're trying to factor.
|
2006-03-15 00:04:29 +08:00
|
|
|
static void FindSingleUseMultiplyFactors(Value *V,
|
2010-03-05 15:18:54 +08:00
|
|
|
SmallVectorImpl<Value*> &Factors,
|
|
|
|
const SmallVectorImpl<ValueEntry> &Ops,
|
|
|
|
bool IsRoot) {
|
2006-03-15 00:04:29 +08:00
|
|
|
BinaryOperator *BO;
|
2010-03-05 15:18:54 +08:00
|
|
|
if (!(V->hasOneUse() || V->use_empty()) || // More than one use.
|
2006-03-15 00:04:29 +08:00
|
|
|
!(BO = dyn_cast<BinaryOperator>(V)) ||
|
|
|
|
BO->getOpcode() != Instruction::Mul) {
|
|
|
|
Factors.push_back(V);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-03-05 15:18:54 +08:00
|
|
|
// If this value has a single use because it is another input to the add
|
|
|
|
// tree we're reassociating and we dropped its use, it actually has two
|
|
|
|
// uses and we can't factor it.
|
|
|
|
if (!IsRoot) {
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i)
|
|
|
|
if (Ops[i].Op == V) {
|
|
|
|
Factors.push_back(V);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2006-03-15 00:04:29 +08:00
|
|
|
// Otherwise, add the LHS and RHS to the list of factors.
|
2010-03-05 15:18:54 +08:00
|
|
|
FindSingleUseMultiplyFactors(BO->getOperand(1), Factors, Ops, false);
|
|
|
|
FindSingleUseMultiplyFactors(BO->getOperand(0), Factors, Ops, false);
|
2006-03-15 00:04:29 +08:00
|
|
|
}
|
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
/// OptimizeAndOrXor - Optimize a series of operands to an 'and', 'or', or 'xor'
|
|
|
|
/// instruction. This optimizes based on identities. If it can be reduced to
|
|
|
|
/// a single Value, it is returned, otherwise the Ops list is mutated as
|
|
|
|
/// necessary.
|
2010-01-01 02:40:32 +08:00
|
|
|
static Value *OptimizeAndOrXor(unsigned Opcode,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2009-12-31 15:59:34 +08:00
|
|
|
// Scan the operand lists looking for X and ~X pairs, along with X,X pairs.
|
|
|
|
// If we find any, we can simplify the expression. X&~X == 0, X|~X == -1.
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
|
|
|
// First, check for X and ~X in the operand list.
|
|
|
|
assert(i < Ops.size());
|
|
|
|
if (BinaryOperator::isNot(Ops[i].Op)) { // Cannot occur for ^.
|
|
|
|
Value *X = BinaryOperator::getNotArgument(Ops[i].Op);
|
|
|
|
unsigned FoundX = FindInOperandList(Ops, i, X);
|
|
|
|
if (FoundX != i) {
|
2010-01-01 01:51:05 +08:00
|
|
|
if (Opcode == Instruction::And) // ...&X&~X = 0
|
2009-12-31 15:59:34 +08:00
|
|
|
return Constant::getNullValue(X->getType());
|
|
|
|
|
2010-01-01 01:51:05 +08:00
|
|
|
if (Opcode == Instruction::Or) // ...|X|~X = -1
|
2009-12-31 15:59:34 +08:00
|
|
|
return Constant::getAllOnesValue(X->getType());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Next, check for duplicate pairs of values, which we assume are next to
|
|
|
|
// each other, due to our sorting criteria.
|
|
|
|
assert(i < Ops.size());
|
|
|
|
if (i+1 != Ops.size() && Ops[i+1].Op == Ops[i].Op) {
|
|
|
|
if (Opcode == Instruction::And || Opcode == Instruction::Or) {
|
2010-01-01 03:49:01 +08:00
|
|
|
// Drop duplicate values for And and Or.
|
2009-12-31 15:59:34 +08:00
|
|
|
Ops.erase(Ops.begin()+i);
|
|
|
|
--i; --e;
|
|
|
|
++NumAnnihil;
|
2010-01-01 03:49:01 +08:00
|
|
|
continue;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
2010-01-01 03:49:01 +08:00
|
|
|
|
|
|
|
// Drop pairs of values for Xor.
|
|
|
|
assert(Opcode == Instruction::Xor);
|
|
|
|
if (e == 2)
|
|
|
|
return Constant::getNullValue(Ops[0].Op->getType());
|
|
|
|
|
2010-01-01 08:04:26 +08:00
|
|
|
// Y ^ X^X -> Y
|
2010-01-01 03:49:01 +08:00
|
|
|
Ops.erase(Ops.begin()+i, Ops.begin()+i+2);
|
|
|
|
i -= 1; e -= 2;
|
|
|
|
++NumAnnihil;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
2006-03-15 00:04:29 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
/// OptimizeAdd - Optimize a series of operands to an 'add' instruction. This
|
|
|
|
/// optimizes based on identities. If it can be reduced to a single Value, it
|
|
|
|
/// is returned, otherwise the Ops list is mutated as necessary.
|
2010-01-01 02:40:32 +08:00
|
|
|
Value *Reassociate::OptimizeAdd(Instruction *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2009-12-31 15:59:34 +08:00
|
|
|
// Scan the operand lists looking for X and -X pairs. If we find any, we
|
2010-01-01 03:24:52 +08:00
|
|
|
// can simplify the expression. X+-X == 0. While we're at it, scan for any
|
|
|
|
// duplicates. We want to canonicalize Y+Y+Y+Z -> 3*Y+Z.
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
//
|
|
|
|
// TODO: We could handle "X + ~X" -> "-1" if we wanted, since "-X = ~X+1".
|
|
|
|
//
|
2009-12-31 15:59:34 +08:00
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
2010-01-01 03:24:52 +08:00
|
|
|
Value *TheOp = Ops[i].Op;
|
|
|
|
// Check to see if we've seen this operand before. If so, we factor all
|
2010-01-01 03:49:01 +08:00
|
|
|
// instances of the operand together. Due to our sorting criteria, we know
|
|
|
|
// that these need to be next to each other in the vector.
|
|
|
|
if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) {
|
|
|
|
// Rescan the list, remove all instances of this operand from the expr.
|
2010-01-01 03:24:52 +08:00
|
|
|
unsigned NumFound = 0;
|
2010-01-01 03:49:01 +08:00
|
|
|
do {
|
|
|
|
Ops.erase(Ops.begin()+i);
|
2010-01-01 03:24:52 +08:00
|
|
|
++NumFound;
|
2010-01-01 03:49:01 +08:00
|
|
|
} while (i != Ops.size() && Ops[i].Op == TheOp);
|
|
|
|
|
2010-01-01 03:25:19 +08:00
|
|
|
DEBUG(errs() << "\nFACTORING [" << NumFound << "]: " << *TheOp << '\n');
|
2010-01-01 03:24:52 +08:00
|
|
|
++NumFactor;
|
|
|
|
|
|
|
|
// Insert a new multiply.
|
|
|
|
Value *Mul = ConstantInt::get(cast<IntegerType>(I->getType()), NumFound);
|
|
|
|
Mul = BinaryOperator::CreateMul(TheOp, Mul, "factor", I);
|
|
|
|
|
|
|
|
// Now that we have inserted a multiply, optimize it. This allows us to
|
|
|
|
// handle cases that require multiple factoring steps, such as this:
|
|
|
|
// (X*2) + (X*2) + (X*2) -> (X*2)*3 -> X*6
|
|
|
|
Mul = ReassociateExpression(cast<BinaryOperator>(Mul));
|
|
|
|
|
|
|
|
// If every add operand was a duplicate, return the multiply.
|
|
|
|
if (Ops.empty())
|
|
|
|
return Mul;
|
|
|
|
|
|
|
|
// Otherwise, we had some input that didn't have the dupe, such as
|
|
|
|
// "A + A + B" -> "A*2 + B". Add the new multiply to the list of
|
|
|
|
// things being added by this operation.
|
|
|
|
Ops.insert(Ops.begin(), ValueEntry(getRank(Mul), Mul));
|
2010-01-01 03:49:01 +08:00
|
|
|
|
|
|
|
--i;
|
|
|
|
e = Ops.size();
|
|
|
|
continue;
|
2010-01-01 03:24:52 +08:00
|
|
|
}
|
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
// Check for X and -X in the operand list.
|
2010-01-01 03:24:52 +08:00
|
|
|
if (!BinaryOperator::isNeg(TheOp))
|
2009-12-31 15:59:34 +08:00
|
|
|
continue;
|
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
Value *X = BinaryOperator::getNegArgument(TheOp);
|
2009-12-31 15:59:34 +08:00
|
|
|
unsigned FoundX = FindInOperandList(Ops, i, X);
|
|
|
|
if (FoundX == i)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Remove X and -X from the operand list.
|
2010-01-01 01:51:05 +08:00
|
|
|
if (Ops.size() == 2)
|
2009-12-31 15:59:34 +08:00
|
|
|
return Constant::getNullValue(X->getType());
|
|
|
|
|
|
|
|
Ops.erase(Ops.begin()+i);
|
|
|
|
if (i < FoundX)
|
|
|
|
--FoundX;
|
|
|
|
else
|
|
|
|
--i; // Need to back up an extra one.
|
|
|
|
Ops.erase(Ops.begin()+FoundX);
|
|
|
|
++NumAnnihil;
|
|
|
|
--i; // Revisit element.
|
|
|
|
e -= 2; // Removed two elements.
|
|
|
|
}
|
2010-01-01 02:17:13 +08:00
|
|
|
|
|
|
|
// Scan the operand list, checking to see if there are any common factors
|
|
|
|
// between operands. Consider something like A*A+A*B*C+D. We would like to
|
|
|
|
// reassociate this to A*(A+B*C)+D, which reduces the number of multiplies.
|
|
|
|
// To efficiently find this, we count the number of times a factor occurs
|
|
|
|
// for any ADD operands that are MULs.
|
|
|
|
DenseMap<Value*, unsigned> FactorOccurrences;
|
|
|
|
|
|
|
|
// Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4)
|
|
|
|
// where they are actually the same multiply.
|
|
|
|
unsigned MaxOcc = 0;
|
|
|
|
Value *MaxOccVal = 0;
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
|
|
|
BinaryOperator *BOp = dyn_cast<BinaryOperator>(Ops[i].Op);
|
|
|
|
if (BOp == 0 || BOp->getOpcode() != Instruction::Mul || !BOp->use_empty())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Compute all of the factors of this added value.
|
|
|
|
SmallVector<Value*, 8> Factors;
|
2010-03-05 15:18:54 +08:00
|
|
|
FindSingleUseMultiplyFactors(BOp, Factors, Ops, true);
|
2010-01-01 02:17:13 +08:00
|
|
|
assert(Factors.size() > 1 && "Bad linearize!");
|
|
|
|
|
|
|
|
// Add one to FactorOccurrences for each unique factor in this op.
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
SmallPtrSet<Value*, 8> Duplicates;
|
|
|
|
for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
|
|
|
|
Value *Factor = Factors[i];
|
|
|
|
if (!Duplicates.insert(Factor)) continue;
|
|
|
|
|
|
|
|
unsigned Occ = ++FactorOccurrences[Factor];
|
|
|
|
if (Occ > MaxOcc) { MaxOcc = Occ; MaxOccVal = Factor; }
|
|
|
|
|
|
|
|
// If Factor is a negative constant, add the negated value as a factor
|
|
|
|
// because we can percolate the negate out. Watch for minint, which
|
|
|
|
// cannot be positivified.
|
|
|
|
if (ConstantInt *CI = dyn_cast<ConstantInt>(Factor))
|
|
|
|
if (CI->getValue().isNegative() && !CI->getValue().isMinSignedValue()) {
|
|
|
|
Factor = ConstantInt::get(CI->getContext(), -CI->getValue());
|
|
|
|
assert(!Duplicates.count(Factor) &&
|
|
|
|
"Shouldn't have two constant factors, missed a canonicalize");
|
|
|
|
|
|
|
|
unsigned Occ = ++FactorOccurrences[Factor];
|
|
|
|
if (Occ > MaxOcc) { MaxOcc = Occ; MaxOccVal = Factor; }
|
|
|
|
}
|
2010-01-01 02:17:13 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If any factor occurred more than one time, we can pull it out.
|
|
|
|
if (MaxOcc > 1) {
|
2010-01-01 03:24:52 +08:00
|
|
|
DEBUG(errs() << "\nFACTORING [" << MaxOcc << "]: " << *MaxOccVal << '\n');
|
2010-01-01 02:17:13 +08:00
|
|
|
++NumFactor;
|
|
|
|
|
|
|
|
// Create a new instruction that uses the MaxOccVal twice. If we don't do
|
|
|
|
// this, we could otherwise run into situations where removing a factor
|
|
|
|
// from an expression will drop a use of maxocc, and this can cause
|
|
|
|
// RemoveFactorFromExpression on successive values to behave differently.
|
|
|
|
Instruction *DummyInst = BinaryOperator::CreateAdd(MaxOccVal, MaxOccVal);
|
|
|
|
SmallVector<Value*, 4> NewMulOps;
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
2010-01-09 14:01:36 +08:00
|
|
|
// Only try to remove factors from expressions we're allowed to.
|
|
|
|
BinaryOperator *BOp = dyn_cast<BinaryOperator>(Ops[i].Op);
|
|
|
|
if (BOp == 0 || BOp->getOpcode() != Instruction::Mul || !BOp->use_empty())
|
|
|
|
continue;
|
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
if (Value *V = RemoveFactorFromExpression(Ops[i].Op, MaxOccVal)) {
|
|
|
|
NewMulOps.push_back(V);
|
|
|
|
Ops.erase(Ops.begin()+i);
|
|
|
|
--i; --e;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// No need for extra uses anymore.
|
|
|
|
delete DummyInst;
|
2010-01-09 01:51:48 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
unsigned NumAddedValues = NewMulOps.size();
|
|
|
|
Value *V = EmitAddTreeOfValues(I, NewMulOps);
|
2010-01-09 01:51:48 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// Now that we have inserted the add tree, optimize it. This allows us to
|
|
|
|
// handle cases that require multiple factoring steps, such as this:
|
2010-01-01 02:17:13 +08:00
|
|
|
// A*A*B + A*A*C --> A*(A*B+A*C) --> A*(A*(B+C))
|
2010-01-01 02:18:46 +08:00
|
|
|
assert(NumAddedValues > 1 && "Each occurrence should contribute a value");
|
2010-01-09 01:51:48 +08:00
|
|
|
(void)NumAddedValues;
|
2010-01-01 03:24:52 +08:00
|
|
|
V = ReassociateExpression(cast<BinaryOperator>(V));
|
|
|
|
|
|
|
|
// Create the multiply.
|
|
|
|
Value *V2 = BinaryOperator::CreateMul(V, MaxOccVal, "tmp", I);
|
|
|
|
|
2010-01-01 03:49:01 +08:00
|
|
|
// Rerun associate on the multiply in case the inner expression turned into
|
|
|
|
// a multiply. We want to make sure that we keep things in canonical form.
|
|
|
|
V2 = ReassociateExpression(cast<BinaryOperator>(V2));
|
2010-01-01 02:17:13 +08:00
|
|
|
|
|
|
|
// If every add operand included the factor (e.g. "A*B + A*C"), then the
|
|
|
|
// entire result expression is just the multiply "A*(B+C)".
|
|
|
|
if (Ops.empty())
|
|
|
|
return V2;
|
|
|
|
|
2010-01-01 02:18:46 +08:00
|
|
|
// Otherwise, we had some input that didn't have the factor, such as
|
2010-01-01 02:17:13 +08:00
|
|
|
// "A*B + A*C + D" -> "A*(B+C) + D". Add the new multiply to the list of
|
2010-01-01 02:18:46 +08:00
|
|
|
// things being added by this operation.
|
2010-01-01 02:17:13 +08:00
|
|
|
Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2));
|
|
|
|
}
|
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
|
|
|
Value *Reassociate::OptimizeExpression(BinaryOperator *I,
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2005-05-08 08:19:31 +08:00
|
|
|
// Now that we have the linearized expression tree, try to optimize it.
|
|
|
|
// Start by folding any constants that we found.
|
2005-05-09 02:59:37 +08:00
|
|
|
bool IterateOptimization = false;
|
2006-03-04 17:31:13 +08:00
|
|
|
if (Ops.size() == 1) return Ops[0].Op;
|
2005-05-08 08:19:31 +08:00
|
|
|
|
2006-03-04 17:31:13 +08:00
|
|
|
unsigned Opcode = I->getOpcode();
|
|
|
|
|
2005-05-08 08:19:31 +08:00
|
|
|
if (Constant *V1 = dyn_cast<Constant>(Ops[Ops.size()-2].Op))
|
|
|
|
if (Constant *V2 = dyn_cast<Constant>(Ops.back().Op)) {
|
|
|
|
Ops.pop_back();
|
2009-07-30 02:55:55 +08:00
|
|
|
Ops.back().Op = ConstantExpr::get(Opcode, V1, V2);
|
2006-03-04 17:31:13 +08:00
|
|
|
return OptimizeExpression(I, Ops);
|
2005-05-08 08:19:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Check for destructive annihilation due to a constant being used.
|
2007-01-11 20:24:14 +08:00
|
|
|
if (ConstantInt *CstVal = dyn_cast<ConstantInt>(Ops.back().Op))
|
2005-05-08 08:19:31 +08:00
|
|
|
switch (Opcode) {
|
|
|
|
default: break;
|
|
|
|
case Instruction::And:
|
2010-01-01 08:04:26 +08:00
|
|
|
if (CstVal->isZero()) // X & 0 -> 0
|
2006-03-04 17:31:13 +08:00
|
|
|
return CstVal;
|
2010-01-01 08:04:26 +08:00
|
|
|
if (CstVal->isAllOnesValue()) // X & -1 -> X
|
2009-12-31 15:48:51 +08:00
|
|
|
Ops.pop_back();
|
2005-05-08 08:19:31 +08:00
|
|
|
break;
|
|
|
|
case Instruction::Mul:
|
2010-01-01 08:04:26 +08:00
|
|
|
if (CstVal->isZero()) { // X * 0 -> 0
|
2005-05-09 02:59:37 +08:00
|
|
|
++NumAnnihil;
|
2006-03-04 17:31:13 +08:00
|
|
|
return CstVal;
|
2005-05-08 08:19:31 +08:00
|
|
|
}
|
2009-12-31 15:48:51 +08:00
|
|
|
|
|
|
|
if (cast<ConstantInt>(CstVal)->isOne())
|
2010-01-01 08:04:26 +08:00
|
|
|
Ops.pop_back(); // X * 1 -> X
|
2005-05-08 08:19:31 +08:00
|
|
|
break;
|
|
|
|
case Instruction::Or:
|
2010-01-01 08:04:26 +08:00
|
|
|
if (CstVal->isAllOnesValue()) // X | -1 -> -1
|
2006-03-04 17:31:13 +08:00
|
|
|
return CstVal;
|
2005-05-08 08:19:31 +08:00
|
|
|
// FALLTHROUGH!
|
|
|
|
case Instruction::Add:
|
|
|
|
case Instruction::Xor:
|
2010-01-01 08:04:26 +08:00
|
|
|
if (CstVal->isZero()) // X [|^+] 0 -> X
|
2005-05-08 08:19:31 +08:00
|
|
|
Ops.pop_back();
|
|
|
|
break;
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
if (Ops.size() == 1) return Ops[0].Op;
|
2005-05-08 08:19:31 +08:00
|
|
|
|
2009-12-31 15:33:14 +08:00
|
|
|
// Handle destructive annihilation due to identities between elements in the
|
2005-05-08 08:19:31 +08:00
|
|
|
// argument list here.
|
2005-05-09 02:59:37 +08:00
|
|
|
switch (Opcode) {
|
|
|
|
default: break;
|
|
|
|
case Instruction::And:
|
|
|
|
case Instruction::Or:
|
2009-12-31 15:59:34 +08:00
|
|
|
case Instruction::Xor: {
|
|
|
|
unsigned NumOps = Ops.size();
|
|
|
|
if (Value *Result = OptimizeAndOrXor(Opcode, Ops))
|
|
|
|
return Result;
|
|
|
|
IterateOptimization |= Ops.size() != NumOps;
|
2005-05-09 02:59:37 +08:00
|
|
|
break;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
2005-05-09 02:59:37 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
case Instruction::Add: {
|
|
|
|
unsigned NumOps = Ops.size();
|
2010-01-01 02:17:13 +08:00
|
|
|
if (Value *Result = OptimizeAdd(I, Ops))
|
2009-12-31 15:59:34 +08:00
|
|
|
return Result;
|
|
|
|
IterateOptimization |= Ops.size() != NumOps;
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
2005-05-09 02:59:37 +08:00
|
|
|
break;
|
|
|
|
//case Instruction::Mul:
|
|
|
|
}
|
|
|
|
|
2005-07-27 14:12:32 +08:00
|
|
|
if (IterateOptimization)
|
2006-03-04 17:31:13 +08:00
|
|
|
return OptimizeExpression(I, Ops);
|
|
|
|
return 0;
|
2005-05-08 08:19:31 +08:00
|
|
|
}
|
|
|
|
|
2005-05-07 12:08:02 +08:00
|
|
|
|
|
|
|
/// ReassociateBB - Inspect all of the instructions in this basic block,
|
|
|
|
/// reassociating them as we go.
|
2005-05-08 05:59:39 +08:00
|
|
|
void Reassociate::ReassociateBB(BasicBlock *BB) {
|
2006-03-04 17:31:13 +08:00
|
|
|
for (BasicBlock::iterator BBI = BB->begin(); BBI != BB->end(); ) {
|
|
|
|
Instruction *BI = BBI++;
|
2005-05-10 11:39:25 +08:00
|
|
|
if (BI->getOpcode() == Instruction::Shl &&
|
|
|
|
isa<ConstantInt>(BI->getOperand(1)))
|
2009-11-14 15:25:54 +08:00
|
|
|
if (Instruction *NI = ConvertShiftToMul(BI, ValueRankMap)) {
|
2005-05-10 11:39:25 +08:00
|
|
|
MadeChange = true;
|
|
|
|
BI = NI;
|
|
|
|
}
|
|
|
|
|
2005-05-09 05:33:47 +08:00
|
|
|
// Reject cases where it is pointless to do this.
|
2010-02-16 00:12:20 +08:00
|
|
|
if (!isa<BinaryOperator>(BI) || BI->getType()->isFloatingPointTy() ||
|
2010-02-16 19:11:14 +08:00
|
|
|
BI->getType()->isVectorTy())
|
2005-05-09 05:33:47 +08:00
|
|
|
continue; // Floating point ops are not associative.
|
|
|
|
|
2010-02-05 07:32:37 +08:00
|
|
|
// Do not reassociate boolean (i1) expressions. We want to preserve the
|
|
|
|
// original order of evaluation for short-circuited comparisons that
|
|
|
|
// SimplifyCFG has folded to AND/OR expressions. If the expression
|
|
|
|
// is not further optimized, it is likely to be transformed back to a
|
|
|
|
// short-circuited form for code gen, and the source order may have been
|
|
|
|
// optimized for the most likely conditions.
|
2010-02-16 00:12:20 +08:00
|
|
|
if (BI->getType()->isIntegerTy(1))
|
2010-02-05 07:32:37 +08:00
|
|
|
continue;
|
|
|
|
|
2005-05-07 12:08:02 +08:00
|
|
|
// If this is a subtract instruction which is not already in negate form,
|
|
|
|
// see if we can convert it to X+-Y.
|
2005-05-09 05:28:52 +08:00
|
|
|
if (BI->getOpcode() == Instruction::Sub) {
|
2009-11-14 15:25:54 +08:00
|
|
|
if (ShouldBreakUpSubtract(BI)) {
|
|
|
|
BI = BreakUpSubtract(BI, ValueRankMap);
|
2010-01-05 12:55:35 +08:00
|
|
|
// Reset the BBI iterator in case BreakUpSubtract changed the
|
|
|
|
// instruction it points to.
|
|
|
|
BBI = BI;
|
|
|
|
++BBI;
|
2008-02-18 10:18:25 +08:00
|
|
|
MadeChange = true;
|
2009-07-14 06:18:28 +08:00
|
|
|
} else if (BinaryOperator::isNeg(BI)) {
|
2005-05-09 05:28:52 +08:00
|
|
|
// Otherwise, this is a negation. See if the operand is a multiply tree
|
|
|
|
// and if this is not an inner node of a multiply tree.
|
|
|
|
if (isReassociableOp(BI->getOperand(1), Instruction::Mul) &&
|
|
|
|
(!BI->hasOneUse() ||
|
|
|
|
!isReassociableOp(BI->use_back(), Instruction::Mul))) {
|
2009-11-14 15:25:54 +08:00
|
|
|
BI = LowerNegateToMultiply(BI, ValueRankMap);
|
2005-05-09 05:28:52 +08:00
|
|
|
MadeChange = true;
|
|
|
|
}
|
2005-05-07 12:08:02 +08:00
|
|
|
}
|
2005-05-09 05:28:52 +08:00
|
|
|
}
|
2002-11-01 01:12:59 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
// If this instruction is a commutative binary operator, process it.
|
|
|
|
if (!BI->isAssociative()) continue;
|
|
|
|
BinaryOperator *I = cast<BinaryOperator>(BI);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
// If this is an interior node of a reassociable tree, ignore it until we
|
|
|
|
// get to the root of the tree, to avoid N^2 analysis.
|
|
|
|
if (I->hasOneUse() && isReassociableOp(I->use_back(), I->getOpcode()))
|
|
|
|
continue;
|
|
|
|
|
2005-09-02 15:07:58 +08:00
|
|
|
// If this is an add tree that is used by a sub instruction, ignore it
|
|
|
|
// until we process the subtract.
|
|
|
|
if (I->hasOneUse() && I->getOpcode() == Instruction::Add &&
|
|
|
|
cast<Instruction>(I->use_back())->getOpcode() == Instruction::Sub)
|
|
|
|
continue;
|
|
|
|
|
2006-03-14 15:11:11 +08:00
|
|
|
ReassociateExpression(I);
|
|
|
|
}
|
|
|
|
}
|
2005-05-09 04:09:57 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
Value *Reassociate::ReassociateExpression(BinaryOperator *I) {
|
2006-03-14 15:11:11 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// First, walk the expression tree, linearizing the tree, collecting the
|
|
|
|
// operand information.
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVector<ValueEntry, 8> Ops;
|
2006-03-14 15:11:11 +08:00
|
|
|
LinearizeExprTree(I, Ops);
|
|
|
|
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "RAIn:\t"; PrintOps(I, Ops); dbgs() << '\n');
|
2006-03-14 15:11:11 +08:00
|
|
|
|
|
|
|
// Now that we have linearized the tree to a list and have gathered all of
|
|
|
|
// the operands and their ranks, sort the operands by their rank. Use a
|
|
|
|
// stable_sort so that values with equal ranks will have their relative
|
|
|
|
// positions maintained (and so the compiler is deterministic). Note that
|
|
|
|
// this sorts so that the highest ranking values end up at the beginning of
|
|
|
|
// the vector.
|
|
|
|
std::stable_sort(Ops.begin(), Ops.end());
|
|
|
|
|
|
|
|
// OptimizeExpression - Now that we have the expression tree in a convenient
|
|
|
|
// sorted form, optimize it globally if possible.
|
|
|
|
if (Value *V = OptimizeExpression(I, Ops)) {
|
|
|
|
// This expression tree simplified to something that isn't a tree,
|
|
|
|
// eliminate it.
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "Reassoc to scalar: " << *V << '\n');
|
2006-03-14 15:11:11 +08:00
|
|
|
I->replaceAllUsesWith(V);
|
|
|
|
RemoveDeadBinaryOp(I);
|
2010-01-01 01:51:05 +08:00
|
|
|
++NumAnnihil;
|
2010-01-01 03:24:52 +08:00
|
|
|
return V;
|
2006-03-14 15:11:11 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// We want to sink immediates as deeply as possible except in the case where
|
|
|
|
// this is a multiply tree used only by an add, and the immediate is a -1.
|
|
|
|
// In this case we reassociate to put the negation on the outside so that we
|
|
|
|
// can fold the negation into the add: (-X)*Y + Z -> Z-X*Y
|
|
|
|
if (I->getOpcode() == Instruction::Mul && I->hasOneUse() &&
|
|
|
|
cast<Instruction>(I->use_back())->getOpcode() == Instruction::Add &&
|
|
|
|
isa<ConstantInt>(Ops.back().Op) &&
|
|
|
|
cast<ConstantInt>(Ops.back().Op)->isAllOnesValue()) {
|
2010-01-01 02:40:32 +08:00
|
|
|
ValueEntry Tmp = Ops.pop_back_val();
|
|
|
|
Ops.insert(Ops.begin(), Tmp);
|
2006-03-14 15:11:11 +08:00
|
|
|
}
|
|
|
|
|
2010-01-05 09:27:24 +08:00
|
|
|
DEBUG(dbgs() << "RAOut:\t"; PrintOps(I, Ops); dbgs() << '\n');
|
2006-03-14 15:11:11 +08:00
|
|
|
|
|
|
|
if (Ops.size() == 1) {
|
|
|
|
// This expression tree simplified to something that isn't a tree,
|
|
|
|
// eliminate it.
|
|
|
|
I->replaceAllUsesWith(Ops[0].Op);
|
|
|
|
RemoveDeadBinaryOp(I);
|
2010-01-01 03:24:52 +08:00
|
|
|
return Ops[0].Op;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
2010-01-01 03:24:52 +08:00
|
|
|
|
|
|
|
// Now that we ordered and optimized the expressions, splat them back into
|
|
|
|
// the expression tree, removing any unneeded nodes.
|
|
|
|
RewriteExprTree(I, Ops);
|
|
|
|
return I;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2002-06-26 00:13:24 +08:00
|
|
|
bool Reassociate::runOnFunction(Function &F) {
|
2002-05-09 06:19:27 +08:00
|
|
|
// Recalculate the rank map for F
|
|
|
|
BuildRankMap(F);
|
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
MadeChange = false;
|
2002-06-26 00:13:24 +08:00
|
|
|
for (Function::iterator FI = F.begin(), FE = F.end(); FI != FE; ++FI)
|
2005-05-08 05:59:39 +08:00
|
|
|
ReassociateBB(FI);
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2010-01-01 08:01:34 +08:00
|
|
|
// We are done with the rank map.
|
2002-05-09 06:19:27 +08:00
|
|
|
RankMap.clear();
|
2003-08-14 00:16:26 +08:00
|
|
|
ValueRankMap.clear();
|
2005-05-08 05:59:39 +08:00
|
|
|
return MadeChange;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
2003-11-12 06:41:34 +08:00
|
|
|
|