2020-03-27 19:35:08 +08:00
|
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-unknown-linux %s -verify \
|
|
|
|
// RUN: -Wno-incompatible-library-redeclaration \
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
// RUN: -analyzer-checker=unix.Malloc
|
2014-03-27 01:05:46 +08:00
|
|
|
|
|
|
|
#define __GFP_ZERO 0x8000
|
|
|
|
#define NULL ((void *)0)
|
|
|
|
|
2019-09-20 17:01:45 +08:00
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
|
|
|
2014-03-27 01:05:46 +08:00
|
|
|
void *kmalloc(size_t, int);
|
2020-03-27 19:35:08 +08:00
|
|
|
void kfree(void *);
|
2014-03-27 01:05:46 +08:00
|
|
|
|
|
|
|
struct test {
|
|
|
|
};
|
|
|
|
|
|
|
|
void foo(struct test *);
|
|
|
|
|
|
|
|
void test_zeroed() {
|
|
|
|
struct test **list, *t;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
list = kmalloc(sizeof(*list) * 10, __GFP_ZERO);
|
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
|
|
t = list[i];
|
|
|
|
foo(t);
|
|
|
|
}
|
[analyzer] Support kfree in MallocChecker
Summary:
kmalloc is freed with kfree in the linux kernel. kmalloc support was
added in r204832, but kfree was not. Adding kfree fixes incorrectly
detected memory leaks.
Reviewers: NoQ, nickdesaulniers, dcoughlin, Szelethus
Reviewed By: NoQ, Szelethus
Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, Charusso, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64030
llvm-svn: 364875
2019-07-02 07:29:10 +08:00
|
|
|
kfree(list); // no-warning
|
2014-03-27 01:05:46 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void test_nonzero() {
|
|
|
|
struct test **list, *t;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
list = kmalloc(sizeof(*list) * 10, 0);
|
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
|
|
t = list[i]; // expected-warning{{undefined}}
|
|
|
|
foo(t);
|
|
|
|
}
|
[analyzer] Support kfree in MallocChecker
Summary:
kmalloc is freed with kfree in the linux kernel. kmalloc support was
added in r204832, but kfree was not. Adding kfree fixes incorrectly
detected memory leaks.
Reviewers: NoQ, nickdesaulniers, dcoughlin, Szelethus
Reviewed By: NoQ, Szelethus
Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, Charusso, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64030
llvm-svn: 364875
2019-07-02 07:29:10 +08:00
|
|
|
kfree(list);
|
2014-03-27 01:05:46 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void test_indeterminate(int flags) {
|
|
|
|
struct test **list, *t;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
list = kmalloc(sizeof(*list) * 10, flags);
|
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
|
|
t = list[i]; // expected-warning{{undefined}}
|
|
|
|
foo(t);
|
|
|
|
}
|
[analyzer] Support kfree in MallocChecker
Summary:
kmalloc is freed with kfree in the linux kernel. kmalloc support was
added in r204832, but kfree was not. Adding kfree fixes incorrectly
detected memory leaks.
Reviewers: NoQ, nickdesaulniers, dcoughlin, Szelethus
Reviewed By: NoQ, Szelethus
Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, Charusso, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64030
llvm-svn: 364875
2019-07-02 07:29:10 +08:00
|
|
|
kfree(list);
|
2014-03-27 01:05:46 +08:00
|
|
|
}
|
2019-09-20 17:01:45 +08:00
|
|
|
|
|
|
|
typedef unsigned long long uint64_t;
|
|
|
|
|
|
|
|
struct malloc_type;
|
|
|
|
|
2020-03-27 19:35:08 +08:00
|
|
|
// 3 parameter malloc:
|
|
|
|
// https://www.freebsd.org/cgi/man.cgi?query=malloc&sektion=9
|
2019-09-20 17:01:45 +08:00
|
|
|
void *malloc(unsigned long size, struct malloc_type *mtp, int flags);
|
|
|
|
|
|
|
|
void test_3arg_malloc(struct malloc_type *mtp) {
|
|
|
|
struct test **list, *t;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, __GFP_ZERO);
|
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
|
|
t = list[i];
|
|
|
|
foo(t);
|
|
|
|
}
|
|
|
|
kfree(list); // no-warning
|
|
|
|
}
|
|
|
|
|
|
|
|
void test_3arg_malloc_nonzero(struct malloc_type *mtp) {
|
|
|
|
struct test **list, *t;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, 0);
|
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
|
|
t = list[i]; // expected-warning{{undefined}}
|
|
|
|
foo(t);
|
|
|
|
}
|
|
|
|
kfree(list);
|
|
|
|
}
|
|
|
|
|
|
|
|
void test_3arg_malloc_indeterminate(struct malloc_type *mtp, int flags) {
|
|
|
|
struct test **list, *t;
|
|
|
|
int i;
|
|
|
|
|
2020-03-27 19:35:08 +08:00
|
|
|
list = malloc(sizeof(*list) * 10, mtp, flags);
|
2019-09-20 17:01:45 +08:00
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (i = 0; i < 10; i++) {
|
|
|
|
t = list[i]; // expected-warning{{undefined}}
|
|
|
|
foo(t);
|
|
|
|
}
|
|
|
|
kfree(list);
|
|
|
|
}
|
2020-03-27 19:35:08 +08:00
|
|
|
|
|
|
|
void test_3arg_malloc_leak(struct malloc_type *mtp, int flags) {
|
|
|
|
struct test **list;
|
|
|
|
|
|
|
|
list = malloc(sizeof(*list) * 10, mtp, flags);
|
|
|
|
if (list == NULL)
|
|
|
|
return;
|
|
|
|
} // expected-warning{{Potential leak of memory pointed to by 'list'}}
|
[Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.
Summary:
The kernel kmalloc function may return a constant value ZERO_SIZE_PTR
if a zero-sized block is allocated. This special value is allowed to
be passed to kfree and should produce no warning.
This is a simple version but should be no problem. The macro is always
detected independent of if this is a kernel source code or any other
code.
Reviewers: Szelethus, martong
Reviewed By: Szelethus, martong
Subscribers: rnkovacs, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, gamesh411, Charusso, martong, ASDenysPetrov, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76830
2020-03-30 15:23:07 +08:00
|
|
|
|
|
|
|
// kmalloc can return a constant value defined in ZERO_SIZE_PTR
|
|
|
|
// if a block of size 0 is requested
|
|
|
|
#define ZERO_SIZE_PTR ((void *)16)
|
|
|
|
|
|
|
|
void test_kfree_ZERO_SIZE_PTR() {
|
|
|
|
void *ptr = ZERO_SIZE_PTR;
|
|
|
|
kfree(ptr); // no warning about freeing this value
|
|
|
|
}
|
|
|
|
|
|
|
|
void test_kfree_other_constant_value() {
|
|
|
|
void *ptr = (void *)1;
|
|
|
|
kfree(ptr); // expected-warning{{Argument to kfree() is a constant address (1)}}
|
|
|
|
}
|