maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/tools/llvm-objdump/X86/malformed-machos.test

42 lines
1.6 KiB
Plaintext
Raw Normal View History

Fix two bugs in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused crashes. We recently got about 700 malformed Mach-O files which we have been using the improve the robustness of tools that deal with reading data from object files. These resulted in about 20 small bug fixes to the darwin based tools. The goal here is to also improve the robustness of llvm-objdump and this is the first two fixes. In talking with Tim Northover the approach we thought might be best is to: 1) Only include tests for the malformed Mach-O files that cause crashes (not all 700+ tests). 2) The test should only contain the command line option that caused the crash and not all the others that don’t matter. 3) There should be only one line for the FileCheck that is past the point of the crash if possible and if possible indicates the malformation. Again the goal is to fix crashes and not so much care about how the printing of malformed data comes out. Tim also suggested if we really wanted to add test cases for all 700+ malformed Mach-O files putting them in the regression tests might be an option. But many of these do not cause crashes. llvm-svn: 249479
2015-10-07 06:27:08 +08:00
// These test checks that llvm-objdump will not crash with malformed Mach-O
// files. So the check line is not all that important but the bug fixes to
// make sure llvm-objdump is robust is what matters.
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -objc-meta-data \
Fix two bugs in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused crashes. We recently got about 700 malformed Mach-O files which we have been using the improve the robustness of tools that deal with reading data from object files. These resulted in about 20 small bug fixes to the darwin based tools. The goal here is to also improve the robustness of llvm-objdump and this is the first two fixes. In talking with Tim Northover the approach we thought might be best is to: 1) Only include tests for the malformed Mach-O files that cause crashes (not all 700+ tests). 2) The test should only contain the command line option that caused the crash and not all the others that don’t matter. 3) There should be only one line for the FileCheck that is past the point of the crash if possible and if possible indicates the malformation. Again the goal is to fix crashes and not so much care about how the printing of malformed data comes out. Tim also suggested if we really wanted to add test cases for all 700+ malformed Mach-O files putting them in the regression tests might be an option. But many of these do not cause crashes. llvm-svn: 249479
2015-10-07 06:27:08 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0001.macho \
# RUN: | FileCheck -check-prefix=m0001 %s
# m0001: (method_t extends past the end of the section)
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -objc-meta-data \
Fix two bugs in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused crashes. We recently got about 700 malformed Mach-O files which we have been using the improve the robustness of tools that deal with reading data from object files. These resulted in about 20 small bug fixes to the darwin based tools. The goal here is to also improve the robustness of llvm-objdump and this is the first two fixes. In talking with Tim Northover the approach we thought might be best is to: 1) Only include tests for the malformed Mach-O files that cause crashes (not all 700+ tests). 2) The test should only contain the command line option that caused the crash and not all the others that don’t matter. 3) There should be only one line for the FileCheck that is past the point of the crash if possible and if possible indicates the malformation. Again the goal is to fix crashes and not so much care about how the printing of malformed data comes out. Tim also suggested if we really wanted to add test cases for all 700+ malformed Mach-O files putting them in the regression tests might be an option. But many of these do not cause crashes. llvm-svn: 249479
2015-10-07 06:27:08 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0006.macho \
# RUN: | FileCheck -check-prefix=m0006 %s
# m0006: ivarLayout 0x8
Fix a bug in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused a crash because of loops in the class meta data. llvm-svn: 249700
2015-10-09 00:56:35 +08:00
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -objc-meta-data \
Fix a bug in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused a crash because of loops in the class meta data. llvm-svn: 249700
2015-10-09 00:56:35 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0006.macho \
# RUN: | FileCheck -check-prefix=m0010 %s
# m0010: 00000000000010e0 0x10e8 _OBJC_CLASS_
Fix a bug in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused a crash because of a section header had a size that extended past the end of the file. rdar://22983603 llvm-svn: 249768
2015-10-09 06:50:55 +08:00
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -objc-meta-data \
Fix a bug in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused a crash because of a section header had a size that extended past the end of the file. rdar://22983603 llvm-svn: 249768
2015-10-09 06:50:55 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0040.macho \
# RUN: | FileCheck -check-prefix=m0040 %s
# m0040: 00000000000010a0 0xf39 -[tiny_dylib init]
Fixed two bugs in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused crashes. The first because the offset in a dyld bind table entry was out of range. The second because their was no image info section and the routine printing it did not have the need check to see the section did not exist. rdar://22983603 llvm-svn: 249845
2015-10-10 00:48:44 +08:00
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -objc-meta-data \
Fixed two bugs in llvm-objdump’s printing of Objective-C meta data from malformed Mach-O files that caused crashes. The first because the offset in a dyld bind table entry was out of range. The second because their was no image info section and the routine printing it did not have the need check to see the section did not exist. rdar://22983603 llvm-svn: 249845
2015-10-10 00:48:44 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0080.macho \
# RUN: | FileCheck -check-prefix=m0080 %s
# m0080: data 0xf960000 (struct class_ro_t *)
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -objc-meta-data \
The issue with the malformed-machos 00000031.a test is that it needed ‘-arch x86_64’ flag as it was a Mach-O universal file. The default as to which architecture slice that is dumped without an -arch flag depends on the host architecture and the contents of the universal file. The malformed archive 00000031.a file has both an x86_64 and i386 slice. So for for x86_64 hosts only that slice is dumped, for non-x86_64 hosts, which is many of the bots both slices are dumped. The test is intended to only check that the malformation of the x86_64 which has a non-decimal characters in the size field of the archive header so it no longer crashes. The problem turned out that the i388 slice of the malformed archive had a different malformation which was causing the non-x86_64 bots to get this error: llvm-objdump -macho -disassemble -arch i386 00000031.a Archive : .00000031.a 00000031.a(c_start.o): LLVM ERROR: Symbol name entry points before beginning or past end of file. and causing the test as it was written to fail. So by adding ‘-arch x86_64’ it should correct the test and the malformation on the i388 slice will not be dumped. Also the removal of the malformed-machos mem-crup-0261.macho was not causing the issue so that is put back in. Sorry for the churn on these tests, Kev llvm-svn: 250184
2015-10-14 01:06:34 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0261.macho
[llvm-objdump] Printing hex instead of dec by default Differential Revision: http://reviews.llvm.org/D18770 llvm-svn: 265817
2016-04-09 01:55:03 +08:00
# RUN: llvm-objdump --print-imm-hex=false -macho -disassemble \
Fix a bugs in the Mach-O disassembler when disassembling from a malformed Mach-O file that caused a crash. This was because of an assert where the code was incorrectly attempting to parse relocation entries off of the sections and the filetype was not an MH_OBJECT. rdar://22983603 llvm-svn: 249921
2015-10-10 08:05:01 +08:00
# RUN: %p/Inputs/malformed-machos/mem-crup-0337.macho \
# RUN: | FileCheck -check-prefix=m0337 %s
# m0337: subq $16, %rsp