maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/MachO/reloc-subtractor.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

75 lines
2.0 KiB
ArmAsm
Raw Normal View History

[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
# REQUIRES: x86, aarch64
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
# RUN: rm -rf %t; split-file %s %t
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/test.s -o %t/x86_64.o
# RUN: llvm-mc -filetype=obj -triple=arm64-apple-darwin %t/test.s -o %t/arm64.o
# RUN: %lld -lSystem %t/x86_64.o -o %t/x86_64 -order_file %t/order-file
[lld-macho] Don't emit rebase opcodes for subtractor minuend relocs Also add a few asserts to verify that we are indeed handling an UNSIGNED relocation as the minued. I haven't made it an actual user-facing error since I don't think llvm-mc is capable of generating SUBTRACTOR relocations without an associated UNSIGNED. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97103
2021-02-28 01:30:16 +08:00
# RUN: llvm-objdump --syms --full-contents --rebase %t/x86_64 | FileCheck %s
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
# RUN: %lld -arch arm64 -lSystem %t/arm64.o -o %t/arm64 -order_file %t/order-file
[lld-macho] Don't emit rebase opcodes for subtractor minuend relocs Also add a few asserts to verify that we are indeed handling an UNSIGNED relocation as the minued. I haven't made it an actual user-facing error since I don't think llvm-mc is capable of generating SUBTRACTOR relocations without an associated UNSIGNED. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97103
2021-02-28 01:30:16 +08:00
# RUN: llvm-objdump --syms --full-contents --rebase %t/arm64 | FileCheck %s
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
# CHECK-LABEL: SYMBOL TABLE:
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
# CHECK: {{0*}}[[#%x, SUB1ADDR:]] l {{.*}} __DATA,bar _sub1
# CHECK: {{0*}}[[#%x, SUB2ADDR:]] l {{.*}} __DATA,bar _sub2
# CHECK: {{0*}}[[#%x, SUB3ADDR:]] l {{.*}} __DATA,bar _sub3
# CHECK: {{0*}}[[#%x, SUB4ADDR:]] l {{.*}} __DATA,bar _sub4
# CHECK: {{0*}}[[#%x, SUB5ADDR:]] l {{.*}} __DATA,bar _sub5
# CHECK-LABEL: Contents of section __DATA,bar:
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
# CHECK: [[#SUB1ADDR]] 10000000
[lld-macho] Extract embedded addends for arm64 UNSIGNED relocations On arm64, UNSIGNED relocs are the only ones that use embedded addends instead of the ADDEND relocation. Also ensure that the addend works when UNSIGNED is part of a SUBTRACTOR pair. Reviewed By: #lld-macho, alexshap Differential Revision: https://reviews.llvm.org/D97105
2021-02-28 01:30:19 +08:00
# CHECK-NEXT: [[#SUB2ADDR]] f2ffffff
# CHECK-NEXT: [[#SUB3ADDR]] 14000000 00000000
# CHECK-NEXT: [[#SUB4ADDR]] f6ffffff ffffffff
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
# CHECK-NEXT: [[#SUB5ADDR]] f1ffffff ffffffff
[lld-macho] Don't emit rebase opcodes for subtractor minuend relocs Also add a few asserts to verify that we are indeed handling an UNSIGNED relocation as the minued. I haven't made it an actual user-facing error since I don't think llvm-mc is capable of generating SUBTRACTOR relocations without an associated UNSIGNED. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97103
2021-02-28 01:30:16 +08:00
# CHECK: Rebase table:
# CHECK-NEXT: segment section address type
# CHECK-EMPTY:
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
#--- test.s
[lld-macho][nfc] Refactor subtractor reloc handling SUBTRACTOR relocations are always paired with UNSIGNED relocations to indicate a pair of symbols whose address difference we want. Functionally they are like a single relocation: only one pointer gets written / relocated. Previously, we would handle these pairs by skipping over the SUBTRACTOR relocation and writing the pointer when handling the UNSIGNED reloc. This diff reverses things, so we write while handling SUBTRACTORs and skip over the UNSIGNED relocs instead. Being able to distinguish between SUBTRACTOR and UNSIGNED relocs in the write phase (i.e. inside `relocateOne`) is useful for the upcoming range check diff: we want to check that SUBTRACTOR relocs write signed values, but UNSIGNED relocs (naturally) write unsigned values. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D98386
2021-03-12 02:28:13 +08:00
.globl _main, _subtrahend_1, _subtrahend_2, _minuend1, _minuend2
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
.section __DATA,foo
.space 16
L_.minuend:
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
.space 16
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
.section __DATA,bar
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
_minuend_1:
.space 16
_minuend_2:
.space 16
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
_subtrahend_1:
.space 16
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
_subtrahend_2:
.space 16
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
_sub1:
.long _minuend_1 - _subtrahend_1
.space 12
_sub2:
[lld-macho] Extract embedded addends for arm64 UNSIGNED relocations On arm64, UNSIGNED relocs are the only ones that use embedded addends instead of the ADDEND relocation. Also ensure that the addend works when UNSIGNED is part of a SUBTRACTOR pair. Reviewed By: #lld-macho, alexshap Differential Revision: https://reviews.llvm.org/D97105
2021-02-28 01:30:19 +08:00
.long _minuend_2 - _subtrahend_2 + 2
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
.space 12
_sub3:
[lld-macho] Extract embedded addends for arm64 UNSIGNED relocations On arm64, UNSIGNED relocs are the only ones that use embedded addends instead of the ADDEND relocation. Also ensure that the addend works when UNSIGNED is part of a SUBTRACTOR pair. Reviewed By: #lld-macho, alexshap Differential Revision: https://reviews.llvm.org/D97105
2021-02-28 01:30:19 +08:00
.quad _minuend_1 - _subtrahend_1 + 4
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
.space 8
_sub4:
[lld-macho] Extract embedded addends for arm64 UNSIGNED relocations On arm64, UNSIGNED relocs are the only ones that use embedded addends instead of the ADDEND relocation. Also ensure that the addend works when UNSIGNED is part of a SUBTRACTOR pair. Reviewed By: #lld-macho, alexshap Differential Revision: https://reviews.llvm.org/D97105
2021-02-28 01:30:19 +08:00
.quad _minuend_2 - _subtrahend_2 + 6
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
.space 8
_sub5:
.quad L_.minuend - _subtrahend_1 + 1
.space 8
[lld-macho] Properly test subtractor relocations & fix their attributes `llvm-mc` doesn't generate any relocations for subtractions between local symbols -- they must be global -- so the previous test wasn't actually testing any relocation logic. I've fixed that and extended the test to cover r_length=3 relocations as well as both x86_64 and arm64. Reviewed By: #lld-macho, smeenai Differential Revision: https://reviews.llvm.org/D97057
2021-02-28 01:30:15 +08:00
.text
.p2align 2
_main:
ret
[lld-macho] Support subtractor relocations that reference sections The minuend (but not the subtrahend) can reference a section. Note that we do not yet properly validate that the subtrahend isn't referencing a section; I've filed PR50034 to track that. I've also extended the reloc-subtractor.s test to reorder symbols, to make sure that the addends are being associated with the minuend (and not the subtrahend) relocation. Fixes PR49999. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D100804
2021-04-21 04:58:06 +08:00
.subsections_via_symbols
#--- order-file
## Reorder the symbols to make sure that the addends are being associated with
## the minuend (and not the subtrahend) relocation.
_subtrahend_1
_minuend_1
_minuend_2
_subtrahend_2