XRay: Add entry and exit sleds
Summary:
In this patch we implement the following parts of XRay:
- Supporting a function attribute named 'function-instrument' which currently only supports 'xray-always'. We should be able to use this attribute for other instrumentation approaches.
- Supporting a function attribute named 'xray-instruction-threshold' used to determine whether a function is instrumented with a minimum number of instructions (IR instruction counts).
- X86-specific nop sleds as described in the white paper.
- A machine function pass that adds the different instrumentation marker instructions at a very late stage.
- A way of identifying which return opcode is considered "normal" for each architecture.
There are some caveats here:
1) We don't handle PATCHABLE_RET in platforms other than x86_64 yet -- this means if IR used PATCHABLE_RET directly instead of a normal ret, instruction lowering for that platform might do the wrong thing. We think this should be handled at instruction selection time to by default be unpacked for platforms where XRay is not availble yet.
2) The generated section for X86 is different from what is described from the white paper for the sole reason that LLVM allows us to do this neatly. We're taking the opportunity to deviate from the white paper from this perspective to allow us to get richer information from the runtime library.
Reviewers: sanjoy, eugenis, kcc, pcc, echristo, rnk
Subscribers: niravd, majnemer, atrick, rnk, emaste, bmakam, mcrosier, mehdi_amini, llvm-commits
Differential Revision: http://reviews.llvm.org/D19904
llvm-svn: 275367
2016-07-14 12:06:33 +08:00
|
|
|
//===-- XRayInstrumentation.cpp - Adds XRay instrumentation to functions. -===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements a MachineFunctionPass that inserts the appropriate
|
|
|
|
// XRay instrumentation instructions. We look for XRay-specific attributes
|
|
|
|
// on the function to determine whether we should insert the replacement
|
|
|
|
// operations.
|
|
|
|
//
|
|
|
|
//===---------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/CodeGen/Analysis.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
|
|
#include "llvm/CodeGen/Passes.h"
|
|
|
|
#include "llvm/Support/TargetRegistry.h"
|
|
|
|
#include "llvm/Target/TargetInstrInfo.h"
|
|
|
|
#include "llvm/Target/TargetSubtargetInfo.h"
|
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
struct XRayInstrumentation : public MachineFunctionPass {
|
|
|
|
static char ID;
|
|
|
|
|
|
|
|
XRayInstrumentation() : MachineFunctionPass(ID) {
|
|
|
|
initializeXRayInstrumentationPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
|
|
|
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
bool XRayInstrumentation::runOnMachineFunction(MachineFunction &MF) {
|
|
|
|
auto &F = *MF.getFunction();
|
|
|
|
auto InstrAttr = F.getFnAttribute("function-instrument");
|
|
|
|
bool AlwaysInstrument = !InstrAttr.hasAttribute(Attribute::None) &&
|
|
|
|
InstrAttr.isStringAttribute() &&
|
|
|
|
InstrAttr.getValueAsString() == "xray-always";
|
|
|
|
Attribute Attr = F.getFnAttribute("xray-instruction-threshold");
|
|
|
|
unsigned XRayThreshold = 0;
|
|
|
|
if (!AlwaysInstrument) {
|
|
|
|
if (Attr.hasAttribute(Attribute::None) || !Attr.isStringAttribute())
|
|
|
|
return false; // XRay threshold attribute not found.
|
|
|
|
if (Attr.getValueAsString().getAsInteger(10, XRayThreshold))
|
|
|
|
return false; // Invalid value for threshold.
|
|
|
|
if (F.size() < XRayThreshold)
|
|
|
|
return false; // Function is too small.
|
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME: Do the loop triviality analysis here or in an earlier pass.
|
|
|
|
|
|
|
|
// First, insert an PATCHABLE_FUNCTION_ENTER as the first instruction of the
|
|
|
|
// MachineFunction.
|
|
|
|
auto &FirstMBB = *MF.begin();
|
|
|
|
auto &FirstMI = *FirstMBB.begin();
|
|
|
|
auto *TII = MF.getSubtarget().getInstrInfo();
|
|
|
|
BuildMI(FirstMBB, FirstMI, FirstMI.getDebugLoc(),
|
|
|
|
TII->get(TargetOpcode::PATCHABLE_FUNCTION_ENTER));
|
|
|
|
|
2016-09-09 01:10:39 +08:00
|
|
|
// Then we look for *all* terminators and returns, then replace those with
|
|
|
|
// PATCHABLE_RET instructions.
|
|
|
|
SmallVector<MachineInstr *, 4> Terminators;
|
|
|
|
for (auto &MBB : MF) {
|
|
|
|
for (auto &T : MBB.terminators()) {
|
|
|
|
unsigned Opc = 0;
|
|
|
|
if (T.isReturn() && T.getOpcode() == TII->getReturnOpcode()) {
|
|
|
|
// Replace return instructions with:
|
|
|
|
// PATCHABLE_RET <Opcode>, <Operand>...
|
|
|
|
Opc = TargetOpcode::PATCHABLE_RET;
|
|
|
|
}
|
|
|
|
if (TII->isTailCall(T)) {
|
|
|
|
// Treat the tail call as a return instruction, which has a
|
|
|
|
// different-looking sled than the normal return case.
|
|
|
|
Opc = TargetOpcode::PATCHABLE_TAIL_CALL;
|
|
|
|
}
|
|
|
|
if (Opc != 0) {
|
|
|
|
auto MIB = BuildMI(MBB, T, T.getDebugLoc(), TII->get(Opc))
|
|
|
|
.addImm(T.getOpcode());
|
|
|
|
for (auto &MO : T.operands())
|
|
|
|
MIB.addOperand(MO);
|
|
|
|
Terminators.push_back(&T);
|
|
|
|
}
|
|
|
|
}
|
XRay: Add entry and exit sleds
Summary:
In this patch we implement the following parts of XRay:
- Supporting a function attribute named 'function-instrument' which currently only supports 'xray-always'. We should be able to use this attribute for other instrumentation approaches.
- Supporting a function attribute named 'xray-instruction-threshold' used to determine whether a function is instrumented with a minimum number of instructions (IR instruction counts).
- X86-specific nop sleds as described in the white paper.
- A machine function pass that adds the different instrumentation marker instructions at a very late stage.
- A way of identifying which return opcode is considered "normal" for each architecture.
There are some caveats here:
1) We don't handle PATCHABLE_RET in platforms other than x86_64 yet -- this means if IR used PATCHABLE_RET directly instead of a normal ret, instruction lowering for that platform might do the wrong thing. We think this should be handled at instruction selection time to by default be unpacked for platforms where XRay is not availble yet.
2) The generated section for X86 is different from what is described from the white paper for the sole reason that LLVM allows us to do this neatly. We're taking the opportunity to deviate from the white paper from this perspective to allow us to get richer information from the runtime library.
Reviewers: sanjoy, eugenis, kcc, pcc, echristo, rnk
Subscribers: niravd, majnemer, atrick, rnk, emaste, bmakam, mcrosier, mehdi_amini, llvm-commits
Differential Revision: http://reviews.llvm.org/D19904
llvm-svn: 275367
2016-07-14 12:06:33 +08:00
|
|
|
}
|
2016-09-09 01:10:39 +08:00
|
|
|
|
|
|
|
for (auto &I : Terminators)
|
|
|
|
I->eraseFromParent();
|
|
|
|
|
XRay: Add entry and exit sleds
Summary:
In this patch we implement the following parts of XRay:
- Supporting a function attribute named 'function-instrument' which currently only supports 'xray-always'. We should be able to use this attribute for other instrumentation approaches.
- Supporting a function attribute named 'xray-instruction-threshold' used to determine whether a function is instrumented with a minimum number of instructions (IR instruction counts).
- X86-specific nop sleds as described in the white paper.
- A machine function pass that adds the different instrumentation marker instructions at a very late stage.
- A way of identifying which return opcode is considered "normal" for each architecture.
There are some caveats here:
1) We don't handle PATCHABLE_RET in platforms other than x86_64 yet -- this means if IR used PATCHABLE_RET directly instead of a normal ret, instruction lowering for that platform might do the wrong thing. We think this should be handled at instruction selection time to by default be unpacked for platforms where XRay is not availble yet.
2) The generated section for X86 is different from what is described from the white paper for the sole reason that LLVM allows us to do this neatly. We're taking the opportunity to deviate from the white paper from this perspective to allow us to get richer information from the runtime library.
Reviewers: sanjoy, eugenis, kcc, pcc, echristo, rnk
Subscribers: niravd, majnemer, atrick, rnk, emaste, bmakam, mcrosier, mehdi_amini, llvm-commits
Differential Revision: http://reviews.llvm.org/D19904
llvm-svn: 275367
2016-07-14 12:06:33 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
char XRayInstrumentation::ID = 0;
|
|
|
|
char &llvm::XRayInstrumentationID = XRayInstrumentation::ID;
|
|
|
|
INITIALIZE_PASS(XRayInstrumentation, "xray-instrumentation", "Insert XRay ops",
|
2016-07-14 19:46:41 +08:00
|
|
|
false, false)
|