2010-06-09 00:52:24 +08:00
|
|
|
//===-- ObjectFile.cpp ------------------------------------------*- C++ -*-===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
#include "lldb/Symbol/ObjectFile.h"
|
|
|
|
#include "Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
#include "lldb/Core/Module.h"
|
2013-04-25 06:29:28 +08:00
|
|
|
#include "lldb/Core/ModuleSpec.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
#include "lldb/Core/PluginManager.h"
|
<rdar://problem/11757916>
Make breakpoint setting by file and line much more efficient by only looking for inlined breakpoint locations if we are setting a breakpoint in anything but a source implementation file. Implementing this complex for a many reasons. Turns out that parsing compile units lazily had some issues with respect to how we need to do things with DWARF in .o files. So the fixes in the checkin for this makes these changes:
- Add a new setting called "target.inline-breakpoint-strategy" which can be set to "never", "always", or "headers". "never" will never try and set any inlined breakpoints (fastest). "always" always looks for inlined breakpoint locations (slowest, but most accurate). "headers", which is the default setting, will only look for inlined breakpoint locations if the breakpoint is set in what are consudered to be header files, which is realy defined as "not in an implementation source file".
- modify the breakpoint setting by file and line to check the current "target.inline-breakpoint-strategy" setting and act accordingly
- Modify compile units to be able to get their language and other info lazily. This allows us to create compile units from the debug map and not have to fill all of the details in, and then lazily discover this information as we go on debuggging. This is needed to avoid parsing all .o files when setting breakpoints in implementation only files (no inlines). Otherwise we would need to parse the .o file, the object file (mach-o in our case) and the symbol file (DWARF in the object file) just to see what the compile unit was.
- modify the "SymbolFileDWARFDebugMap" to subclass lldb_private::Module so that the virtual "GetObjectFile()" and "GetSymbolVendor()" functions can be intercepted when the .o file contenst are later lazilly needed. Prior to this fix, when we first instantiated the "SymbolFileDWARFDebugMap" class, we would also make modules, object files and symbol files for every .o file in the debug map because we needed to fix up the sections in the .o files with information that is in the executable debug map. Now we lazily do this in the DebugMapModule::GetObjectFile()
Cleaned up header includes a bit as well.
llvm-svn: 162860
2012-08-30 05:13:06 +08:00
|
|
|
#include "lldb/Core/Section.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
#include "lldb/Symbol/ObjectContainer.h"
|
|
|
|
#include "lldb/Symbol/SymbolFile.h"
|
2017-02-03 05:39:50 +08:00
|
|
|
#include "lldb/Target/Process.h"
|
2017-01-20 01:32:50 +08:00
|
|
|
#include "lldb/Target/RegisterContext.h"
|
|
|
|
#include "lldb/Target/SectionLoadList.h"
|
2017-02-03 05:39:50 +08:00
|
|
|
#include "lldb/Target/Target.h"
|
2017-03-04 09:30:05 +08:00
|
|
|
#include "lldb/Utility/DataBuffer.h"
|
|
|
|
#include "lldb/Utility/DataBufferHeap.h"
|
2017-03-07 07:42:14 +08:00
|
|
|
#include "lldb/Utility/DataBufferLLVM.h"
|
2017-03-04 04:56:28 +08:00
|
|
|
#include "lldb/Utility/Log.h"
|
2017-02-03 05:39:50 +08:00
|
|
|
#include "lldb/Utility/RegularExpression.h"
|
2017-06-29 22:32:17 +08:00
|
|
|
#include "lldb/Utility/Timer.h"
|
2016-09-07 04:57:50 +08:00
|
|
|
#include "lldb/lldb-private.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
|
|
|
|
using namespace lldb;
|
|
|
|
using namespace lldb_private;
|
|
|
|
|
2011-09-19 02:59:15 +08:00
|
|
|
ObjectFileSP
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFile::FindPlugin(const lldb::ModuleSP &module_sp, const FileSpec *file,
|
|
|
|
lldb::offset_t file_offset, lldb::offset_t file_size,
|
|
|
|
DataBufferSP &data_sp, lldb::offset_t &data_offset) {
|
|
|
|
ObjectFileSP object_file_sp;
|
|
|
|
|
|
|
|
if (module_sp) {
|
2017-05-15 21:02:37 +08:00
|
|
|
static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
|
2016-09-07 04:57:50 +08:00
|
|
|
Timer scoped_timer(
|
2017-05-15 21:02:37 +08:00
|
|
|
func_cat,
|
2016-09-07 04:57:50 +08:00
|
|
|
"ObjectFile::FindPlugin (module = %s, file = %p, file_offset = "
|
|
|
|
"0x%8.8" PRIx64 ", file_size = 0x%8.8" PRIx64 ")",
|
|
|
|
module_sp->GetFileSpec().GetPath().c_str(),
|
|
|
|
static_cast<const void *>(file), static_cast<uint64_t>(file_offset),
|
|
|
|
static_cast<uint64_t>(file_size));
|
|
|
|
if (file) {
|
|
|
|
FileSpec archive_file;
|
|
|
|
ObjectContainerCreateInstance create_object_container_callback;
|
|
|
|
|
|
|
|
const bool file_exists = file->Exists();
|
|
|
|
if (!data_sp) {
|
|
|
|
// We have an object name which most likely means we have
|
|
|
|
// a .o file in a static archive (.a file). Try and see if
|
|
|
|
// we have a cached archive first without reading any data
|
|
|
|
// first
|
|
|
|
if (file_exists && module_sp->GetObjectName()) {
|
|
|
|
for (uint32_t idx = 0;
|
|
|
|
(create_object_container_callback =
|
|
|
|
PluginManager::GetObjectContainerCreateCallbackAtIndex(
|
|
|
|
idx)) != nullptr;
|
|
|
|
++idx) {
|
|
|
|
std::unique_ptr<ObjectContainer> object_container_ap(
|
|
|
|
create_object_container_callback(module_sp, data_sp,
|
|
|
|
data_offset, file, file_offset,
|
|
|
|
file_size));
|
|
|
|
|
|
|
|
if (object_container_ap.get())
|
|
|
|
object_file_sp = object_container_ap->GetObjectFile(file);
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
if (object_file_sp.get())
|
|
|
|
return object_file_sp;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Ok, we didn't find any containers that have a named object, now
|
|
|
|
// lets read the first 512 bytes from the file so the object file
|
|
|
|
// and object container plug-ins can use these bytes to see if they
|
|
|
|
// can parse this file.
|
|
|
|
if (file_size > 0) {
|
2017-03-07 07:42:14 +08:00
|
|
|
data_sp =
|
|
|
|
DataBufferLLVM::CreateSliceFromPath(file->GetPath(), 512, file_offset);
|
2016-09-07 04:57:50 +08:00
|
|
|
data_offset = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!data_sp || data_sp->GetByteSize() == 0) {
|
|
|
|
// Check for archive file with format "/path/to/archive.a(object.o)"
|
|
|
|
char path_with_object[PATH_MAX * 2];
|
|
|
|
module_sp->GetFileSpec().GetPath(path_with_object,
|
|
|
|
sizeof(path_with_object));
|
|
|
|
|
|
|
|
ConstString archive_object;
|
|
|
|
const bool must_exist = true;
|
|
|
|
if (ObjectFile::SplitArchivePathWithObject(
|
|
|
|
path_with_object, archive_file, archive_object, must_exist)) {
|
|
|
|
file_size = archive_file.GetByteSize();
|
|
|
|
if (file_size > 0) {
|
|
|
|
file = &archive_file;
|
|
|
|
module_sp->SetFileSpecAndObjectName(archive_file, archive_object);
|
|
|
|
// Check if this is a object container by iterating through all
|
|
|
|
// object
|
|
|
|
// container plugin instances and then trying to get an object file
|
|
|
|
// from the container plugins since we had a name. Also, don't read
|
|
|
|
// ANY data in case there is data cached in the container plug-ins
|
|
|
|
// (like BSD archives caching the contained objects within an file).
|
|
|
|
for (uint32_t idx = 0;
|
|
|
|
(create_object_container_callback =
|
|
|
|
PluginManager::GetObjectContainerCreateCallbackAtIndex(
|
|
|
|
idx)) != nullptr;
|
|
|
|
++idx) {
|
|
|
|
std::unique_ptr<ObjectContainer> object_container_ap(
|
|
|
|
create_object_container_callback(module_sp, data_sp,
|
|
|
|
data_offset, file,
|
|
|
|
file_offset, file_size));
|
|
|
|
|
|
|
|
if (object_container_ap.get())
|
|
|
|
object_file_sp = object_container_ap->GetObjectFile(file);
|
|
|
|
|
|
|
|
if (object_file_sp.get())
|
|
|
|
return object_file_sp;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
// We failed to find any cached object files in the container
|
|
|
|
// plug-ins, so lets read the first 512 bytes and try again below...
|
2017-03-07 07:42:14 +08:00
|
|
|
data_sp = DataBufferLLVM::CreateSliceFromPath(archive_file.GetPath(),
|
|
|
|
512, file_offset);
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2014-04-04 12:06:10 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
if (data_sp && data_sp->GetByteSize() > 0) {
|
2012-02-05 10:38:54 +08:00
|
|
|
// Check if this is a normal object file by iterating through
|
|
|
|
// all object file plugin instances.
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFileCreateInstance create_object_file_callback;
|
|
|
|
for (uint32_t idx = 0;
|
|
|
|
(create_object_file_callback =
|
|
|
|
PluginManager::GetObjectFileCreateCallbackAtIndex(idx)) !=
|
|
|
|
nullptr;
|
|
|
|
++idx) {
|
|
|
|
object_file_sp.reset(create_object_file_callback(
|
|
|
|
module_sp, data_sp, data_offset, file, file_offset, file_size));
|
|
|
|
if (object_file_sp.get())
|
|
|
|
return object_file_sp;
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
// Check if this is a object container by iterating through
|
|
|
|
// all object container plugin instances and then trying to get
|
|
|
|
// an object file from the container.
|
|
|
|
for (uint32_t idx = 0;
|
|
|
|
(create_object_container_callback =
|
|
|
|
PluginManager::GetObjectContainerCreateCallbackAtIndex(
|
|
|
|
idx)) != nullptr;
|
|
|
|
++idx) {
|
|
|
|
std::unique_ptr<ObjectContainer> object_container_ap(
|
|
|
|
create_object_container_callback(module_sp, data_sp, data_offset,
|
|
|
|
file, file_offset, file_size));
|
|
|
|
|
|
|
|
if (object_container_ap.get())
|
|
|
|
object_file_sp = object_container_ap->GetObjectFile(file);
|
|
|
|
|
|
|
|
if (object_file_sp.get())
|
|
|
|
return object_file_sp;
|
2013-07-13 06:07:46 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2013-07-13 06:07:46 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
// We didn't find it, so clear our shared pointer in case it
|
|
|
|
// contains anything and return an empty shared pointer
|
|
|
|
object_file_sp.reset();
|
|
|
|
return object_file_sp;
|
2013-04-25 06:29:28 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFileSP ObjectFile::FindPlugin(const lldb::ModuleSP &module_sp,
|
|
|
|
const ProcessSP &process_sp,
|
|
|
|
lldb::addr_t header_addr,
|
|
|
|
DataBufferSP &data_sp) {
|
|
|
|
ObjectFileSP object_file_sp;
|
|
|
|
|
|
|
|
if (module_sp) {
|
2017-05-15 21:02:37 +08:00
|
|
|
static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
|
|
|
|
Timer scoped_timer(func_cat,
|
|
|
|
"ObjectFile::FindPlugin (module = "
|
|
|
|
"%s, process = %p, header_addr = "
|
|
|
|
"0x%" PRIx64 ")",
|
2016-09-07 04:57:50 +08:00
|
|
|
module_sp->GetFileSpec().GetPath().c_str(),
|
|
|
|
static_cast<void *>(process_sp.get()), header_addr);
|
|
|
|
uint32_t idx;
|
|
|
|
|
|
|
|
// Check if this is a normal object file by iterating through
|
|
|
|
// all object file plugin instances.
|
|
|
|
ObjectFileCreateMemoryInstance create_callback;
|
|
|
|
for (idx = 0;
|
|
|
|
(create_callback =
|
|
|
|
PluginManager::GetObjectFileCreateMemoryCallbackAtIndex(idx)) !=
|
|
|
|
nullptr;
|
|
|
|
++idx) {
|
|
|
|
object_file_sp.reset(
|
|
|
|
create_callback(module_sp, data_sp, process_sp, header_addr));
|
|
|
|
if (object_file_sp.get())
|
|
|
|
return object_file_sp;
|
2013-04-25 06:29:28 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2013-04-25 06:29:28 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
// We didn't find it, so clear our shared pointer in case it
|
|
|
|
// contains anything and return an empty shared pointer
|
|
|
|
object_file_sp.reset();
|
|
|
|
return object_file_sp;
|
2013-04-25 06:29:28 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
size_t ObjectFile::GetModuleSpecifications(const FileSpec &file,
|
|
|
|
lldb::offset_t file_offset,
|
|
|
|
lldb::offset_t file_size,
|
|
|
|
ModuleSpecList &specs) {
|
2017-03-07 07:42:14 +08:00
|
|
|
DataBufferSP data_sp = DataBufferLLVM::CreateSliceFromPath(file.GetPath(), 512, file_offset);
|
2016-09-07 04:57:50 +08:00
|
|
|
if (data_sp) {
|
|
|
|
if (file_size == 0) {
|
|
|
|
const lldb::offset_t actual_file_size = file.GetByteSize();
|
|
|
|
if (actual_file_size > file_offset)
|
|
|
|
file_size = actual_file_size - file_offset;
|
|
|
|
}
|
|
|
|
return ObjectFile::GetModuleSpecifications(file, // file spec
|
|
|
|
data_sp, // data bytes
|
|
|
|
0, // data offset
|
|
|
|
file_offset, // file offset
|
|
|
|
file_size, // file length
|
|
|
|
specs);
|
|
|
|
}
|
|
|
|
return 0;
|
2011-09-19 02:59:15 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
size_t ObjectFile::GetModuleSpecifications(
|
|
|
|
const lldb_private::FileSpec &file, lldb::DataBufferSP &data_sp,
|
|
|
|
lldb::offset_t data_offset, lldb::offset_t file_offset,
|
|
|
|
lldb::offset_t file_size, lldb_private::ModuleSpecList &specs) {
|
|
|
|
const size_t initial_count = specs.GetSize();
|
|
|
|
ObjectFileGetModuleSpecifications callback;
|
|
|
|
uint32_t i;
|
|
|
|
// Try the ObjectFile plug-ins
|
|
|
|
for (i = 0;
|
|
|
|
(callback =
|
|
|
|
PluginManager::GetObjectFileGetModuleSpecificationsCallbackAtIndex(
|
|
|
|
i)) != nullptr;
|
|
|
|
++i) {
|
|
|
|
if (callback(file, data_sp, data_offset, file_offset, file_size, specs) > 0)
|
|
|
|
return specs.GetSize() - initial_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Try the ObjectContainer plug-ins
|
|
|
|
for (i = 0;
|
|
|
|
(callback = PluginManager::
|
|
|
|
GetObjectContainerGetModuleSpecificationsCallbackAtIndex(i)) !=
|
|
|
|
nullptr;
|
|
|
|
++i) {
|
|
|
|
if (callback(file, data_sp, data_offset, file_offset, file_size, specs) > 0)
|
|
|
|
return specs.GetSize() - initial_count;
|
|
|
|
}
|
|
|
|
return 0;
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFile::ObjectFile(const lldb::ModuleSP &module_sp,
|
|
|
|
const FileSpec *file_spec_ptr,
|
|
|
|
lldb::offset_t file_offset, lldb::offset_t length,
|
|
|
|
const lldb::DataBufferSP &data_sp,
|
|
|
|
lldb::offset_t data_offset)
|
|
|
|
: ModuleChild(module_sp),
|
|
|
|
m_file(), // This file could be different from the original module's file
|
|
|
|
m_type(eTypeInvalid), m_strata(eStrataInvalid),
|
|
|
|
m_file_offset(file_offset), m_length(length), m_data(),
|
|
|
|
m_unwind_table(*this), m_process_wp(),
|
|
|
|
m_memory_addr(LLDB_INVALID_ADDRESS), m_sections_ap(), m_symtab_ap(),
|
|
|
|
m_synthetic_symbol_idx(0) {
|
|
|
|
if (file_spec_ptr)
|
|
|
|
m_file = *file_spec_ptr;
|
|
|
|
if (data_sp)
|
|
|
|
m_data.SetData(data_sp, data_offset, length);
|
|
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
|
|
|
|
if (log)
|
|
|
|
log->Printf("%p ObjectFile::ObjectFile() module = %p (%s), file = %s, "
|
|
|
|
"file_offset = 0x%8.8" PRIx64 ", size = %" PRIu64,
|
|
|
|
static_cast<void *>(this), static_cast<void *>(module_sp.get()),
|
|
|
|
module_sp->GetSpecificationDescription().c_str(),
|
|
|
|
m_file ? m_file.GetPath().c_str() : "<NULL>", m_file_offset,
|
|
|
|
m_length);
|
|
|
|
}
|
2012-02-05 10:38:54 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFile::ObjectFile(const lldb::ModuleSP &module_sp,
|
|
|
|
const ProcessSP &process_sp, lldb::addr_t header_addr,
|
|
|
|
DataBufferSP &header_data_sp)
|
|
|
|
: ModuleChild(module_sp), m_file(), m_type(eTypeInvalid),
|
|
|
|
m_strata(eStrataInvalid), m_file_offset(0), m_length(0), m_data(),
|
|
|
|
m_unwind_table(*this), m_process_wp(process_sp),
|
|
|
|
m_memory_addr(header_addr), m_sections_ap(), m_symtab_ap(),
|
|
|
|
m_synthetic_symbol_idx(0) {
|
|
|
|
if (header_data_sp)
|
|
|
|
m_data.SetData(header_data_sp, 0, header_data_sp->GetByteSize());
|
|
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
|
|
|
|
if (log)
|
|
|
|
log->Printf("%p ObjectFile::ObjectFile() module = %p (%s), process = %p, "
|
|
|
|
"header_addr = 0x%" PRIx64,
|
|
|
|
static_cast<void *>(this), static_cast<void *>(module_sp.get()),
|
|
|
|
module_sp->GetSpecificationDescription().c_str(),
|
|
|
|
static_cast<void *>(process_sp.get()), m_memory_addr);
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2010-08-10 07:31:02 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFile::~ObjectFile() {
|
|
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
|
|
|
|
if (log)
|
|
|
|
log->Printf("%p ObjectFile::~ObjectFile ()\n", static_cast<void *>(this));
|
2010-08-10 07:31:02 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
bool ObjectFile::SetModulesArchitecture(const ArchSpec &new_arch) {
|
|
|
|
ModuleSP module_sp(GetModule());
|
|
|
|
if (module_sp)
|
|
|
|
return module_sp->SetArchitecture(new_arch);
|
|
|
|
return false;
|
|
|
|
}
|
2014-04-04 12:06:10 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
AddressClass ObjectFile::GetAddressClass(addr_t file_addr) {
|
|
|
|
Symtab *symtab = GetSymtab();
|
|
|
|
if (symtab) {
|
|
|
|
Symbol *symbol = symtab->FindSymbolContainingFileAddress(file_addr);
|
|
|
|
if (symbol) {
|
|
|
|
if (symbol->ValueIsAddress()) {
|
|
|
|
const SectionSP section_sp(symbol->GetAddressRef().GetSection());
|
|
|
|
if (section_sp) {
|
|
|
|
const SectionType section_type = section_sp->GetType();
|
|
|
|
switch (section_type) {
|
|
|
|
case eSectionTypeInvalid:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSectionTypeCode:
|
|
|
|
return eAddressClassCode;
|
|
|
|
case eSectionTypeContainer:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSectionTypeData:
|
|
|
|
case eSectionTypeDataCString:
|
|
|
|
case eSectionTypeDataCStringPointers:
|
|
|
|
case eSectionTypeDataSymbolAddress:
|
|
|
|
case eSectionTypeData4:
|
|
|
|
case eSectionTypeData8:
|
|
|
|
case eSectionTypeData16:
|
|
|
|
case eSectionTypeDataPointers:
|
|
|
|
case eSectionTypeZeroFill:
|
|
|
|
case eSectionTypeDataObjCMessageRefs:
|
|
|
|
case eSectionTypeDataObjCCFStrings:
|
|
|
|
case eSectionTypeGoSymtab:
|
|
|
|
return eAddressClassData;
|
|
|
|
case eSectionTypeDebug:
|
|
|
|
case eSectionTypeDWARFDebugAbbrev:
|
|
|
|
case eSectionTypeDWARFDebugAddr:
|
|
|
|
case eSectionTypeDWARFDebugAranges:
|
2017-08-25 21:56:14 +08:00
|
|
|
case eSectionTypeDWARFDebugCuIndex:
|
2016-09-07 04:57:50 +08:00
|
|
|
case eSectionTypeDWARFDebugFrame:
|
|
|
|
case eSectionTypeDWARFDebugInfo:
|
|
|
|
case eSectionTypeDWARFDebugLine:
|
|
|
|
case eSectionTypeDWARFDebugLoc:
|
|
|
|
case eSectionTypeDWARFDebugMacInfo:
|
|
|
|
case eSectionTypeDWARFDebugMacro:
|
|
|
|
case eSectionTypeDWARFDebugPubNames:
|
|
|
|
case eSectionTypeDWARFDebugPubTypes:
|
|
|
|
case eSectionTypeDWARFDebugRanges:
|
|
|
|
case eSectionTypeDWARFDebugStr:
|
|
|
|
case eSectionTypeDWARFDebugStrOffsets:
|
|
|
|
case eSectionTypeDWARFAppleNames:
|
|
|
|
case eSectionTypeDWARFAppleTypes:
|
|
|
|
case eSectionTypeDWARFAppleNamespaces:
|
|
|
|
case eSectionTypeDWARFAppleObjC:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSectionTypeEHFrame:
|
|
|
|
case eSectionTypeARMexidx:
|
|
|
|
case eSectionTypeARMextab:
|
|
|
|
case eSectionTypeCompactUnwind:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
case eSectionTypeELFSymbolTable:
|
|
|
|
case eSectionTypeELFDynamicSymbols:
|
|
|
|
case eSectionTypeELFRelocationEntries:
|
|
|
|
case eSectionTypeELFDynamicLinkInfo:
|
|
|
|
case eSectionTypeOther:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSectionTypeAbsoluteAddress:
|
|
|
|
// In case of absolute sections decide the address class based on
|
|
|
|
// the symbol
|
|
|
|
// type because the section type isn't specify if it is a code or a
|
|
|
|
// data
|
|
|
|
// section.
|
|
|
|
break;
|
|
|
|
}
|
2011-03-19 09:12:21 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
const SymbolType symbol_type = symbol->GetType();
|
|
|
|
switch (symbol_type) {
|
|
|
|
case eSymbolTypeAny:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSymbolTypeAbsolute:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSymbolTypeCode:
|
|
|
|
return eAddressClassCode;
|
|
|
|
case eSymbolTypeTrampoline:
|
|
|
|
return eAddressClassCode;
|
|
|
|
case eSymbolTypeResolver:
|
|
|
|
return eAddressClassCode;
|
|
|
|
case eSymbolTypeData:
|
|
|
|
return eAddressClassData;
|
|
|
|
case eSymbolTypeRuntime:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
case eSymbolTypeException:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
case eSymbolTypeSourceFile:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeHeaderFile:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeObjectFile:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeCommonBlock:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeBlock:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeLocal:
|
|
|
|
return eAddressClassData;
|
|
|
|
case eSymbolTypeParam:
|
|
|
|
return eAddressClassData;
|
|
|
|
case eSymbolTypeVariable:
|
|
|
|
return eAddressClassData;
|
|
|
|
case eSymbolTypeVariableType:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeLineEntry:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeLineHeader:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeScopeBegin:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeScopeEnd:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeAdditional:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSymbolTypeCompiler:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeInstrumentation:
|
|
|
|
return eAddressClassDebug;
|
|
|
|
case eSymbolTypeUndefined:
|
|
|
|
return eAddressClassUnknown;
|
|
|
|
case eSymbolTypeObjCClass:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
case eSymbolTypeObjCMetaClass:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
case eSymbolTypeObjCIVar:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
case eSymbolTypeReExported:
|
|
|
|
return eAddressClassRuntime;
|
|
|
|
}
|
2011-03-19 09:12:21 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
return eAddressClassUnknown;
|
2011-03-19 09:12:21 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
DataBufferSP ObjectFile::ReadMemory(const ProcessSP &process_sp,
|
|
|
|
lldb::addr_t addr, size_t byte_size) {
|
|
|
|
DataBufferSP data_sp;
|
|
|
|
if (process_sp) {
|
|
|
|
std::unique_ptr<DataBufferHeap> data_ap(new DataBufferHeap(byte_size, 0));
|
2017-05-12 12:51:55 +08:00
|
|
|
Status error;
|
2016-09-07 04:57:50 +08:00
|
|
|
const size_t bytes_read = process_sp->ReadMemory(
|
|
|
|
addr, data_ap->GetBytes(), data_ap->GetByteSize(), error);
|
|
|
|
if (bytes_read == byte_size)
|
|
|
|
data_sp.reset(data_ap.release());
|
|
|
|
}
|
|
|
|
return data_sp;
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
size_t ObjectFile::GetData(lldb::offset_t offset, size_t length,
|
|
|
|
DataExtractor &data) const {
|
|
|
|
// The entire file has already been mmap'ed into m_data, so just copy from
|
|
|
|
// there
|
|
|
|
// as the back mmap buffer will be shared with shared pointers.
|
|
|
|
return data.SetData(m_data, offset, length);
|
2012-01-12 13:25:17 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
size_t ObjectFile::CopyData(lldb::offset_t offset, size_t length,
|
|
|
|
void *dst) const {
|
|
|
|
// The entire file has already been mmap'ed into m_data, so just copy from
|
|
|
|
// there
|
|
|
|
// Note that the data remains in target byte order.
|
|
|
|
return m_data.CopyData(offset, length, dst);
|
2012-01-12 13:25:17 +08:00
|
|
|
}
|
2011-03-19 09:12:21 +08:00
|
|
|
|
2017-10-02 22:35:07 +08:00
|
|
|
size_t ObjectFile::ReadSectionData(Section *section,
|
2016-09-07 04:57:50 +08:00
|
|
|
lldb::offset_t section_offset, void *dst,
|
2017-10-02 22:35:07 +08:00
|
|
|
size_t dst_len) {
|
2016-09-07 04:57:50 +08:00
|
|
|
assert(section);
|
|
|
|
section_offset *= section->GetTargetByteSize();
|
|
|
|
|
|
|
|
// If some other objectfile owns this data, pass this to them.
|
|
|
|
if (section->GetObjectFile() != this)
|
|
|
|
return section->GetObjectFile()->ReadSectionData(section, section_offset,
|
|
|
|
dst, dst_len);
|
|
|
|
|
|
|
|
if (IsInMemory()) {
|
|
|
|
ProcessSP process_sp(m_process_wp.lock());
|
|
|
|
if (process_sp) {
|
2017-05-12 12:51:55 +08:00
|
|
|
Status error;
|
2016-09-07 04:57:50 +08:00
|
|
|
const addr_t base_load_addr =
|
|
|
|
section->GetLoadBaseAddress(&process_sp->GetTarget());
|
|
|
|
if (base_load_addr != LLDB_INVALID_ADDRESS)
|
|
|
|
return process_sp->ReadMemory(base_load_addr + section_offset, dst,
|
|
|
|
dst_len, error);
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
} else {
|
2017-10-02 22:35:07 +08:00
|
|
|
if (!section->IsRelocated())
|
|
|
|
RelocateSection(section);
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
const lldb::offset_t section_file_size = section->GetFileSize();
|
|
|
|
if (section_offset < section_file_size) {
|
|
|
|
const size_t section_bytes_left = section_file_size - section_offset;
|
|
|
|
size_t section_dst_len = dst_len;
|
|
|
|
if (section_dst_len > section_bytes_left)
|
|
|
|
section_dst_len = section_bytes_left;
|
|
|
|
return CopyData(section->GetFileOffset() + section_offset,
|
|
|
|
section_dst_len, dst);
|
|
|
|
} else {
|
|
|
|
if (section->GetType() == eSectionTypeZeroFill) {
|
|
|
|
const uint64_t section_size = section->GetByteSize();
|
|
|
|
const uint64_t section_bytes_left = section_size - section_offset;
|
|
|
|
uint64_t section_dst_len = dst_len;
|
|
|
|
if (section_dst_len > section_bytes_left)
|
|
|
|
section_dst_len = section_bytes_left;
|
|
|
|
memset(dst, 0, section_dst_len);
|
|
|
|
return section_dst_len;
|
|
|
|
}
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
return 0;
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
//----------------------------------------------------------------------
|
|
|
|
// Get the section data the file on disk
|
|
|
|
//----------------------------------------------------------------------
|
2017-10-02 22:35:07 +08:00
|
|
|
size_t ObjectFile::ReadSectionData(Section *section,
|
|
|
|
DataExtractor §ion_data) {
|
2016-09-07 04:57:50 +08:00
|
|
|
// If some other objectfile owns this data, pass this to them.
|
|
|
|
if (section->GetObjectFile() != this)
|
|
|
|
return section->GetObjectFile()->ReadSectionData(section, section_data);
|
|
|
|
|
|
|
|
if (IsInMemory()) {
|
|
|
|
ProcessSP process_sp(m_process_wp.lock());
|
|
|
|
if (process_sp) {
|
|
|
|
const addr_t base_load_addr =
|
|
|
|
section->GetLoadBaseAddress(&process_sp->GetTarget());
|
|
|
|
if (base_load_addr != LLDB_INVALID_ADDRESS) {
|
|
|
|
DataBufferSP data_sp(
|
|
|
|
ReadMemory(process_sp, base_load_addr, section->GetByteSize()));
|
|
|
|
if (data_sp) {
|
|
|
|
section_data.SetData(data_sp, 0, data_sp->GetByteSize());
|
|
|
|
section_data.SetByteOrder(process_sp->GetByteOrder());
|
|
|
|
section_data.SetAddressByteSize(process_sp->GetAddressByteSize());
|
|
|
|
return section_data.GetByteSize();
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
return GetData(section->GetFileOffset(), section->GetFileSize(),
|
|
|
|
section_data);
|
|
|
|
} else {
|
|
|
|
// The object file now contains a full mmap'ed copy of the object file data,
|
|
|
|
// so just use this
|
2017-10-02 22:35:07 +08:00
|
|
|
if (!section->IsRelocated())
|
|
|
|
RelocateSection(section);
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
return GetData(section->GetFileOffset(), section->GetFileSize(),
|
|
|
|
section_data);
|
|
|
|
}
|
2012-02-05 10:38:54 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
bool ObjectFile::SplitArchivePathWithObject(const char *path_with_object,
|
|
|
|
FileSpec &archive_file,
|
|
|
|
ConstString &archive_object,
|
|
|
|
bool must_exist) {
|
2016-09-22 00:01:28 +08:00
|
|
|
RegularExpression g_object_regex(llvm::StringRef("(.*)\\(([^\\)]+)\\)$"));
|
2016-09-07 04:57:50 +08:00
|
|
|
RegularExpression::Match regex_match(2);
|
2016-09-22 00:01:28 +08:00
|
|
|
if (g_object_regex.Execute(llvm::StringRef::withNullAsEmpty(path_with_object),
|
|
|
|
®ex_match)) {
|
2016-09-07 04:57:50 +08:00
|
|
|
std::string path;
|
|
|
|
std::string obj;
|
|
|
|
if (regex_match.GetMatchAtIndex(path_with_object, 1, path) &&
|
|
|
|
regex_match.GetMatchAtIndex(path_with_object, 2, obj)) {
|
2016-11-03 04:34:10 +08:00
|
|
|
archive_file.SetFile(path, false);
|
2016-09-07 04:57:50 +08:00
|
|
|
archive_object.SetCString(obj.c_str());
|
|
|
|
if (must_exist && !archive_file.Exists())
|
|
|
|
return false;
|
|
|
|
return true;
|
<rdar://problem/11757916>
Make breakpoint setting by file and line much more efficient by only looking for inlined breakpoint locations if we are setting a breakpoint in anything but a source implementation file. Implementing this complex for a many reasons. Turns out that parsing compile units lazily had some issues with respect to how we need to do things with DWARF in .o files. So the fixes in the checkin for this makes these changes:
- Add a new setting called "target.inline-breakpoint-strategy" which can be set to "never", "always", or "headers". "never" will never try and set any inlined breakpoints (fastest). "always" always looks for inlined breakpoint locations (slowest, but most accurate). "headers", which is the default setting, will only look for inlined breakpoint locations if the breakpoint is set in what are consudered to be header files, which is realy defined as "not in an implementation source file".
- modify the breakpoint setting by file and line to check the current "target.inline-breakpoint-strategy" setting and act accordingly
- Modify compile units to be able to get their language and other info lazily. This allows us to create compile units from the debug map and not have to fill all of the details in, and then lazily discover this information as we go on debuggging. This is needed to avoid parsing all .o files when setting breakpoints in implementation only files (no inlines). Otherwise we would need to parse the .o file, the object file (mach-o in our case) and the symbol file (DWARF in the object file) just to see what the compile unit was.
- modify the "SymbolFileDWARFDebugMap" to subclass lldb_private::Module so that the virtual "GetObjectFile()" and "GetSymbolVendor()" functions can be intercepted when the .o file contenst are later lazilly needed. Prior to this fix, when we first instantiated the "SymbolFileDWARFDebugMap" class, we would also make modules, object files and symbol files for every .o file in the debug map because we needed to fix up the sections in the .o files with information that is in the executable debug map. Now we lazily do this in the DebugMapModule::GetObjectFile()
Cleaned up header includes a bit as well.
llvm-svn: 162860
2012-08-30 05:13:06 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
return false;
|
<rdar://problem/11757916>
Make breakpoint setting by file and line much more efficient by only looking for inlined breakpoint locations if we are setting a breakpoint in anything but a source implementation file. Implementing this complex for a many reasons. Turns out that parsing compile units lazily had some issues with respect to how we need to do things with DWARF in .o files. So the fixes in the checkin for this makes these changes:
- Add a new setting called "target.inline-breakpoint-strategy" which can be set to "never", "always", or "headers". "never" will never try and set any inlined breakpoints (fastest). "always" always looks for inlined breakpoint locations (slowest, but most accurate). "headers", which is the default setting, will only look for inlined breakpoint locations if the breakpoint is set in what are consudered to be header files, which is realy defined as "not in an implementation source file".
- modify the breakpoint setting by file and line to check the current "target.inline-breakpoint-strategy" setting and act accordingly
- Modify compile units to be able to get their language and other info lazily. This allows us to create compile units from the debug map and not have to fill all of the details in, and then lazily discover this information as we go on debuggging. This is needed to avoid parsing all .o files when setting breakpoints in implementation only files (no inlines). Otherwise we would need to parse the .o file, the object file (mach-o in our case) and the symbol file (DWARF in the object file) just to see what the compile unit was.
- modify the "SymbolFileDWARFDebugMap" to subclass lldb_private::Module so that the virtual "GetObjectFile()" and "GetSymbolVendor()" functions can be intercepted when the .o file contenst are later lazilly needed. Prior to this fix, when we first instantiated the "SymbolFileDWARFDebugMap" class, we would also make modules, object files and symbol files for every .o file in the debug map because we needed to fix up the sections in the .o files with information that is in the executable debug map. Now we lazily do this in the DebugMapModule::GetObjectFile()
Cleaned up header includes a bit as well.
llvm-svn: 162860
2012-08-30 05:13:06 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
void ObjectFile::ClearSymtab() {
|
|
|
|
ModuleSP module_sp(GetModule());
|
|
|
|
if (module_sp) {
|
|
|
|
std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
|
|
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
|
|
|
|
if (log)
|
|
|
|
log->Printf("%p ObjectFile::ClearSymtab () symtab = %p",
|
|
|
|
static_cast<void *>(this),
|
|
|
|
static_cast<void *>(m_symtab_ap.get()));
|
|
|
|
m_symtab_ap.reset();
|
|
|
|
}
|
2013-07-10 09:23:25 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
SectionList *ObjectFile::GetSectionList(bool update_module_section_list) {
|
|
|
|
if (m_sections_ap.get() == nullptr) {
|
|
|
|
if (update_module_section_list) {
|
|
|
|
ModuleSP module_sp(GetModule());
|
|
|
|
if (module_sp) {
|
|
|
|
std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
|
|
|
|
CreateSections(*module_sp->GetUnifiedSectionList());
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
SectionList unified_section_list;
|
|
|
|
CreateSections(unified_section_list);
|
2013-03-05 05:46:16 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
return m_sections_ap.get();
|
2013-03-05 05:46:16 +08:00
|
|
|
}
|
2015-11-10 13:21:54 +08:00
|
|
|
|
|
|
|
lldb::SymbolType
|
2016-09-07 04:57:50 +08:00
|
|
|
ObjectFile::GetSymbolTypeFromName(llvm::StringRef name,
|
|
|
|
lldb::SymbolType symbol_type_hint) {
|
|
|
|
if (!name.empty()) {
|
|
|
|
if (name.startswith("_OBJC_")) {
|
|
|
|
// ObjC
|
|
|
|
if (name.startswith("_OBJC_CLASS_$_"))
|
|
|
|
return lldb::eSymbolTypeObjCClass;
|
|
|
|
if (name.startswith("_OBJC_METACLASS_$_"))
|
|
|
|
return lldb::eSymbolTypeObjCMetaClass;
|
|
|
|
if (name.startswith("_OBJC_IVAR_$_"))
|
|
|
|
return lldb::eSymbolTypeObjCIVar;
|
|
|
|
} else if (name.startswith(".objc_class_name_")) {
|
|
|
|
// ObjC v1
|
|
|
|
return lldb::eSymbolTypeObjCClass;
|
2015-11-10 13:21:54 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
return symbol_type_hint;
|
2015-11-10 13:21:54 +08:00
|
|
|
}
|
2016-02-18 19:12:18 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
ConstString ObjectFile::GetNextSyntheticSymbolName() {
|
|
|
|
StreamString ss;
|
|
|
|
ConstString file_name = GetModule()->GetFileSpec().GetFilename();
|
|
|
|
ss.Printf("___lldb_unnamed_symbol%u$$%s", ++m_synthetic_symbol_idx,
|
|
|
|
file_name.GetCString());
|
2016-11-17 05:15:24 +08:00
|
|
|
return ConstString(ss.GetString());
|
2016-02-18 19:12:18 +08:00
|
|
|
}
|
2017-01-20 01:32:50 +08:00
|
|
|
|
2017-05-12 12:51:55 +08:00
|
|
|
Status ObjectFile::LoadInMemory(Target &target, bool set_pc) {
|
|
|
|
Status error;
|
2017-01-20 01:32:50 +08:00
|
|
|
ProcessSP process = target.CalculateProcess();
|
|
|
|
if (!process)
|
2017-05-12 12:51:55 +08:00
|
|
|
return Status("No Process");
|
2017-01-25 07:07:27 +08:00
|
|
|
if (set_pc && !GetEntryPointAddress().IsValid())
|
2017-05-12 12:51:55 +08:00
|
|
|
return Status("No entry address in object file");
|
2017-01-20 01:32:50 +08:00
|
|
|
|
|
|
|
SectionList *section_list = GetSectionList();
|
|
|
|
if (!section_list)
|
2017-05-12 12:51:55 +08:00
|
|
|
return Status("No section in object file");
|
2017-01-20 01:32:50 +08:00
|
|
|
size_t section_count = section_list->GetNumSections(0);
|
|
|
|
for (size_t i = 0; i < section_count; ++i) {
|
|
|
|
SectionSP section_sp = section_list->GetSectionAtIndex(i);
|
|
|
|
addr_t addr = target.GetSectionLoadList().GetSectionLoadAddress(section_sp);
|
|
|
|
if (addr != LLDB_INVALID_ADDRESS) {
|
|
|
|
DataExtractor section_data;
|
|
|
|
// We can skip sections like bss
|
|
|
|
if (section_sp->GetFileSize() == 0)
|
|
|
|
continue;
|
|
|
|
section_sp->GetSectionData(section_data);
|
|
|
|
lldb::offset_t written = process->WriteMemory(
|
|
|
|
addr, section_data.GetDataStart(), section_data.GetByteSize(), error);
|
|
|
|
if (written != section_data.GetByteSize())
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
}
|
2017-01-25 07:07:27 +08:00
|
|
|
if (set_pc) {
|
|
|
|
ThreadList &thread_list = process->GetThreadList();
|
|
|
|
ThreadSP curr_thread(thread_list.GetSelectedThread());
|
|
|
|
RegisterContextSP reg_context(curr_thread->GetRegisterContext());
|
|
|
|
Address file_entry = GetEntryPointAddress();
|
|
|
|
reg_context->SetPC(file_entry.GetLoadAddress(&target));
|
|
|
|
}
|
2017-01-20 01:32:50 +08:00
|
|
|
return error;
|
|
|
|
}
|
2017-10-02 22:35:07 +08:00
|
|
|
|
|
|
|
void ObjectFile::RelocateSection(lldb_private::Section *section)
|
|
|
|
{
|
|
|
|
}
|
Make sure DataBufferLLVM contents are writable
Summary:
We sometimes need to write to the object file we've mapped into memory,
generally to apply relocations to debug info sections. We've had that
ability before, but with the introduction of DataBufferLLVM, we have
lost it, as the underlying llvm class (MemoryBuffer) only supports
read-only mappings.
This switches DataBufferLLVM to use the new llvm::WritableMemoryBuffer
class as a back-end, as this one guarantees to return a writable buffer.
This removes the need for the "Private" flag to the DataBufferLLVM
creation functions, as it was really used to mean "writable". The LLVM
function also does not have the NullTerminate flag, so I've modified our
clients to not require this feature and removed that flag as well.
Reviewers: zturner, clayborg, jingham
Subscribers: emaste, aprantl, arichardson, krytarowski, lldb-commits
Differential Revision: https://reviews.llvm.org/D40079
llvm-svn: 321255
2017-12-21 18:54:30 +08:00
|
|
|
|
|
|
|
DataBufferSP ObjectFile::MapFileData(const FileSpec &file, uint64_t Size,
|
|
|
|
uint64_t Offset) {
|
|
|
|
return DataBufferLLVM::CreateSliceFromPath(file.GetPath(), Size, Offset);
|
|
|
|
}
|