2018-07-12 04:25:49 +08:00
|
|
|
; RUN: llc < %s -march=amdgcn -verify-machineinstrs | FileCheck -allow-deprecated-dag-overlap -enable-var-scope --check-prefixes=SI,GCN,MESA-GCN,FUNC %s
|
|
|
|
|
; RUN: llc < %s -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs | FileCheck -allow-deprecated-dag-overlap -enable-var-scope -check-prefixes=VI,GCN,MESA-VI,MESA-GCN,FUNC %s
|
|
|
|
|
; RUN: llc < %s -mtriple=amdgcn--amdhsa -mcpu=fiji -verify-machineinstrs | FileCheck -allow-deprecated-dag-overlap -enable-var-scope -check-prefixes=VI,GCN,HSA-VI,FUNC %s
|
2018-07-28 20:34:25 +08:00
|
|
|
; RUN: llc < %s -march=r600 -mcpu=redwood -verify-machineinstrs | FileCheck -allow-deprecated-dag-overlap -enable-var-scope -check-prefixes=EG,EGCM,FUNC %s
|
|
|
|
|
; RUN: llc < %s -march=r600 -mcpu=cayman -verify-machineinstrs | FileCheck -allow-deprecated-dag-overlap -enable-var-scope --check-prefixes=CM,EGCM,FUNC %s
|
2013-10-23 08:44:32 +08:00
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i8_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
|
2015-11-07 05:58:37 +08:00
|
|
|
; SI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x2c
|
|
|
|
|
; MESA-GCN: s_and_b32 s{{[0-9]+}}, [[VAL]], 0xff
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
|
|
|
|
|
; HSA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x8
|
|
|
|
|
; HSA-VI: s_and_b32 s{{[0-9]+}}, [[VAL]], 0xff
|
2018-07-28 20:34:25 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
; EG: LSHR T0.X, KC0[2].Y, literal.x,
|
|
|
|
|
; EG-NEXT: MOV * T1.X, KC0[2].Z,
|
|
|
|
|
; EG-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
|
|
|
|
|
|
|
|
|
; CM: LSHR * T0.X, KC0[2].Y, literal.x,
|
|
|
|
|
; CM-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
|
|
|
|
; CM-NEXT: MOV * T1.X, KC0[2].Z,
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i8_arg(i32 addrspace(1)* nocapture %out, i8 %in) nounwind {
|
2018-07-06 01:01:20 +08:00
|
|
|
%ext = zext i8 %in to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
2013-10-23 08:44:32 +08:00
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i8_zext_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword s{{[0-9]}}, s[0:1], 0x2c
|
2013-10-23 08:44:32 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; HSA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x8
|
|
|
|
|
; HSA-VI: s_and_b32 s{{[0-9]+}}, [[VAL]], 0xff
|
2018-07-28 20:34:25 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
; EG: BFE_INT T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; EG-NEXT: LSHR * T1.X, KC0[2].Y, literal.y,
|
|
|
|
|
; EG-NEXT: 8(1.121039e-44), 2(2.802597e-45)
|
|
|
|
|
|
|
|
|
|
; CM: BFE_INT * T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; CM-NEXT: 8(1.121039e-44), 0(0.000000e+00)
|
|
|
|
|
; CM-NEXT: LSHR * T1.X, KC0[2].Y, literal.x,
|
|
|
|
|
; CM-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i8_zext_arg(i32 addrspace(1)* nocapture %out, i8 zeroext %in) nounwind {
|
2018-07-06 01:01:20 +08:00
|
|
|
%ext = zext i8 %in to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
2013-10-23 08:44:32 +08:00
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i8_sext_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]}}, s[0:1], 0xb
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword s{{[0-9]}}, s[0:1], 0x2c
|
2013-10-23 08:44:32 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; HSA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x8
|
|
|
|
|
; HSA-VI: s_sext_i32_i8 s{{[0-9]+}}, [[VAL]]
|
|
|
|
|
; HSA-VI: flat_store_dword
|
2018-07-28 20:34:25 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
; EG: BFE_INT T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; EG-NEXT: LSHR * T1.X, KC0[2].Y, literal.y,
|
|
|
|
|
; EG-NEXT: 8(1.121039e-44), 2(2.802597e-45)
|
|
|
|
|
|
|
|
|
|
; CM: BFE_INT * T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; CM-NEXT: 8(1.121039e-44), 0(0.000000e+00)
|
|
|
|
|
; CM-NEXT: LSHR * T1.X, KC0[2].Y, literal.x,
|
|
|
|
|
; CM-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i8_sext_arg(i32 addrspace(1)* nocapture %out, i8 signext %in) nounwind {
|
2018-07-06 01:01:20 +08:00
|
|
|
%ext = sext i8 %in to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
2013-10-23 08:44:32 +08:00
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i16_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2015-11-07 05:58:37 +08:00
|
|
|
; SI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0xb
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x2c
|
|
|
|
|
; MESA-GCN: s_and_b32 s{{[0-9]+}}, [[VAL]], 0xff
|
2013-10-23 08:44:32 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; HSA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x8
|
|
|
|
|
; HSA-VI: s_and_b32 s{{[0-9]+}}, [[VAL]], 0xffff{{$}}
|
|
|
|
|
; HSA-VI: flat_store_dword
|
2018-07-28 20:34:25 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
; EG: LSHR T0.X, KC0[2].Y, literal.x,
|
|
|
|
|
; EG-NEXT: MOV * T1.X, KC0[2].Z,
|
|
|
|
|
; EG-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
|
|
|
|
|
|
|
|
|
; CM: LSHR * T0.X, KC0[2].Y, literal.x,
|
|
|
|
|
; CM-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
|
|
|
|
; CM-NEXT: MOV * T1.X, KC0[2].Z,
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i16_arg(i32 addrspace(1)* nocapture %out, i16 %in) nounwind {
|
2018-07-06 01:01:20 +08:00
|
|
|
%ext = zext i16 %in to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
2013-10-23 08:44:32 +08:00
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i16_zext_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword s{{[0-9]}}, s[0:1], 0x2c
|
2013-10-23 08:44:32 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; HSA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x8
|
|
|
|
|
; HSA-VI: s_and_b32 s{{[0-9]+}}, [[VAL]], 0xffff{{$}}
|
|
|
|
|
; HSA-VI: flat_store_dword
|
2018-07-28 20:34:25 +08:00
|
|
|
|
|
|
|
|
; EG: BFE_INT T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; EG-NEXT: LSHR * T1.X, KC0[2].Y, literal.y,
|
|
|
|
|
; EG-NEXT: 16(2.242078e-44), 2(2.802597e-45)
|
|
|
|
|
|
|
|
|
|
; CM: BFE_INT * T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; CM-NEXT: 16(2.242078e-44), 0(0.000000e+00)
|
|
|
|
|
; CM-NEXT: LSHR * T1.X, KC0[2].Y, literal.x,
|
|
|
|
|
; CM-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i16_zext_arg(i32 addrspace(1)* nocapture %out, i16 zeroext %in) nounwind {
|
2018-07-06 01:01:20 +08:00
|
|
|
%ext = zext i16 %in to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
2013-10-23 08:44:32 +08:00
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i16_sext_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword s{{[0-9]}}, s[0:1], 0x2c
|
2013-10-23 08:44:32 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
|
|
|
|
|
; HSA-VI: s_load_dword [[VAL:s[0-9]+]], s[{{[0-9]+:[0-9]+}}], 0x8
|
|
|
|
|
; HSA-VI: s_sext_i32_i16 s{{[0-9]+}}, [[VAL]]
|
|
|
|
|
; HSA-VI: flat_store_dword
|
2018-07-28 20:34:25 +08:00
|
|
|
|
|
|
|
|
; EG: BFE_INT T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; EG-NEXT: LSHR * T1.X, KC0[2].Y, literal.y,
|
|
|
|
|
; EG-NEXT: 16(2.242078e-44), 2(2.802597e-45)
|
|
|
|
|
|
|
|
|
|
; CM: BFE_INT * T0.X, T0.X, 0.0, literal.x,
|
|
|
|
|
; CM-NEXT: 16(2.242078e-44), 0(0.000000e+00)
|
|
|
|
|
; CM-NEXT: LSHR * T1.X, KC0[2].Y, literal.x,
|
|
|
|
|
; CM-NEXT: 2(2.802597e-45), 0(0.000000e+00)
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i16_sext_arg(i32 addrspace(1)* nocapture %out, i16 signext %in) nounwind {
|
2018-07-06 01:01:20 +08:00
|
|
|
%ext = sext i16 %in to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
2013-10-23 08:44:32 +08:00
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}i32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: T{{[0-9]\.[XYZW]}}, KC0[2].Z
|
2015-02-11 22:26:46 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword s{{[0-9]}}, s[0:1], 0x2c
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]}}, s[4:5], 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i32_arg(i32 addrspace(1)* nocapture %out, i32 %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store i32 %in, i32 addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}f32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: T{{[0-9]\.[XYZW]}}, KC0[2].Z
|
2015-02-11 22:26:46 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dword s{{[0-9]}}, s[0:1], 0x2c
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @f32_arg(float addrspace(1)* nocapture %out, float %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store float %in, float addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v2i8_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; GCN: s_load_dword s
|
|
|
|
|
; GCN-NOT: {{buffer|flat|global}}_load_
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v2i8_arg(<2 x i8> addrspace(1)* %out, <2 x i8> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <2 x i8> %in, <2 x i8> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v2i16_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
2018-05-22 14:32:10 +08:00
|
|
|
|
2018-05-31 00:17:51 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]+}}, s[0:1], 0xb
|
|
|
|
|
; MESA-VI: s_load_dword s{{[0-9]+}}, s{{\[[0-9]+:[0-9]+\]}}, 0x2c
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s{{\[[0-9]+:[0-9]+\]}}, 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v2i16_arg(<2 x i16> addrspace(1)* %out, <2 x i16> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <2 x i16> %in, <2 x i16> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v2i32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 16
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[2].W
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dwordx2 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx2 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0x2c
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v2i32_arg(<2 x i32> addrspace(1)* nocapture %out, <2 x i32> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <2 x i32> %in, <2 x i32> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v2f32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 16
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[2].W
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dwordx2 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0xb
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx2 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0x2c
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]:[0-9]\]}}, s[4:5], 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v2f32_arg(<2 x float> addrspace(1)* nocapture %out, <2 x float> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <2 x float> %in, <2 x float> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v3i8_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: VTX_READ_8 T{{[0-9]}}.X, T{{[0-9]}}.X, 40
|
|
|
|
|
; EGCM-DAG: VTX_READ_8 T{{[0-9]}}.X, T{{[0-9]}}.X, 41
|
|
|
|
|
; EGCM-DAG: VTX_READ_8 T{{[0-9]}}.X, T{{[0-9]}}.X, 42
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI: s_load_dword s{{[0-9]+}}, s{{\[[0-9]+:[0-9]+\]}}, 0xb
|
|
|
|
|
|
|
|
|
|
; VI-MESA: s_load_dword s{{[0-9]+}}, s{{\[[0-9]+:[0-9]+\]}}, 0x2c
|
|
|
|
|
; VI-HSA: s_load_dword s{{[0-9]+}}, s{{\[[0-9]+:[0-9]+\]}}, 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v3i8_arg(<3 x i8> addrspace(1)* nocapture %out, <3 x i8> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <3 x i8> %in, <3 x i8> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v3i16_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 16
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-05-30 03:35:00 +08:00
|
|
|
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: VTX_READ_16 T{{[0-9]}}.X, T{{[0-9]}}.X, 44
|
|
|
|
|
; EGCM-DAG: VTX_READ_16 T{{[0-9]}}.X, T{{[0-9]}}.X, 46
|
|
|
|
|
; EGCM-DAG: VTX_READ_16 T{{[0-9]}}.X, T{{[0-9]}}.X, 48
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s{{\[[0-9]+:[0-9]+\]}}, 0xb
|
2018-06-15 23:15:46 +08:00
|
|
|
|
|
|
|
|
; VI-HSA: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s{{\[[0-9]+:[0-9]+\]}}, 0x8
|
|
|
|
|
; VI-MESA: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s{{\[[0-9]+:[0-9]+\]}}, 0x2c
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v3i16_arg(<3 x i16> addrspace(1)* nocapture %out, <3 x i16> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <3 x i16> %in, <3 x i16> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v3i32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 32
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].W
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dwordx4 s{{\[[0-9]:[0-9]+\]}}, s[0:1], 0xd
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx4 s{{\[[0-9]:[0-9]+\]}}, s[0:1], 0x34
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x10
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v3i32_arg(<3 x i32> addrspace(1)* nocapture %out, <3 x i32> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <3 x i32> %in, <3 x i32> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v3f32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 32
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].W
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dwordx4 s{{\[[0-9]:[0-9]+\]}}, s[0:1], 0xd
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx4 s{{\[[0-9]:[0-9]+\]}}, s[0:1], 0x34
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x10
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v3f32_arg(<3 x float> addrspace(1)* nocapture %out, <3 x float> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <3 x float> %in, <3 x float> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v4i8_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; GCN-DAG: s_load_dwordx2 s
|
|
|
|
|
; GCN-DAG: s_load_dword s
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v4i8_arg(<4 x i8> addrspace(1)* %out, <4 x i8> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <4 x i8> %in, <4 x i8> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v4i16_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 16
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
2018-05-22 14:32:10 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0xb
|
2018-05-31 00:17:51 +08:00
|
|
|
; SI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x9
|
2018-05-22 14:32:10 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; MESA-VI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x24
|
|
|
|
|
; MESA-VI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x2c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
; MESA-VI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x24
|
|
|
|
|
; MESA-VI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x2c
|
|
|
|
|
|
|
|
|
|
; HSA-VI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI-DAG: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x8
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v4i16_arg(<4 x i16> addrspace(1)* %out, <4 x i16> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <4 x i16> %in, <4 x i16> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v4i32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 32
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].X
|
2018-05-22 14:32:10 +08:00
|
|
|
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dwordx4 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0xd
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx4 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0x34
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x10
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v4i32_arg(<4 x i32> addrspace(1)* nocapture %out, <4 x i32> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <4 x i32> %in, <4 x i32> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v4f32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 32
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[3].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].X
|
2015-02-04 05:53:27 +08:00
|
|
|
; SI: s_load_dwordx4 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0xd
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx4 s{{\[[0-9]:[0-9]\]}}, s[0:1], 0x34
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x10
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v4f32_arg(<4 x float> addrspace(1)* nocapture %out, <4 x float> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <4 x float> %in, <4 x float> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; FIXME: Lots of unpack and re-pack junk on VI
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v8i8_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 16
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI-NOT: {{buffer|flat|global}}_load
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; SI: s_load_dwordx2 s
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI-NEXT: s_load_dwordx2 s
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; SI-NOT: {{buffer|flat|global}}_load
|
|
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; VI: s_load_dwordx2 s
|
|
|
|
|
; VI-NEXT: s_load_dwordx2 s
|
|
|
|
|
; VI-NOT: lshl
|
|
|
|
|
; VI-NOT: _or
|
|
|
|
|
; VI-NOT: _sdwa
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v8i8_arg(<8 x i8> addrspace(1)* %out, <8 x i8> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <8 x i8> %in, <8 x i8> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v8i16_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 32
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
2018-05-22 14:32:10 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI: s_load_dwordx4
|
|
|
|
|
; SI-NEXT: s_load_dwordx2
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; SI-NOT: {{buffer|flat|global}}_load
|
|
|
|
|
|
2018-05-22 14:32:10 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; MESA-VI: s_load_dwordx4 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x34
|
2018-06-15 23:15:46 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; HSA-VI: s_load_dwordx4 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x10
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v8i16_arg(<8 x i16> addrspace(1)* %out, <8 x i16> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <8 x i16> %in, <8 x i16> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v8i32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 64
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 5
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].X
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
|
2015-12-01 05:15:53 +08:00
|
|
|
; SI: s_load_dwordx8 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x11
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx8 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x44
|
|
|
|
|
; HSA-VI: s_load_dwordx8 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x20
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v8i32_arg(<8 x i32> addrspace(1)* nocapture %out, <8 x i32> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <8 x i32> %in, <8 x i32> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v8f32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 64
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 5
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[4].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[5].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].X
|
2015-12-01 05:15:53 +08:00
|
|
|
; SI: s_load_dwordx8 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x11
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v8f32_arg(<8 x float> addrspace(1)* nocapture %out, <8 x float> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <8 x float> %in, <8 x float> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; FIXME: Pack/repack on VI
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v16i8_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 32
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
|
|
|
|
; EGCM: VTX_READ_8
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI: s_load_dwordx4 s
|
|
|
|
|
; SI-NEXT: s_load_dwordx2 s
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; SI-NOT: {{buffer|flat|global}}_load
|
2018-05-31 00:17:51 +08:00
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; VI: s_load_dwordx4 s
|
|
|
|
|
; VI-NOT: shr
|
|
|
|
|
; VI-NOT: shl
|
|
|
|
|
; VI-NOT: _sdwa
|
|
|
|
|
; VI-NOT: _or_
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v16i8_arg(<16 x i8> addrspace(1)* %out, <16 x i8> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <16 x i8> %in, <16 x i8> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v16i16_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 64
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 5
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
|
|
|
|
; EGCM: VTX_READ_16
|
2018-05-22 14:32:10 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI: s_load_dwordx8 s
|
|
|
|
|
; SI-NEXT: s_load_dwordx2 s
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; SI-NOT: {{buffer|flat|global}}_load
|
|
|
|
|
|
2018-05-22 14:32:10 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; MESA-VI: s_load_dwordx8 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x44
|
2018-06-15 23:15:46 +08:00
|
|
|
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; HSA-VI: s_load_dwordx8 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x20
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v16i16_arg(<16 x i16> addrspace(1)* %out, <16 x i16> %in) {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <16 x i16> %in, <16 x i16> addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v16i32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 128
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 6
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[10].X
|
2015-12-01 05:15:53 +08:00
|
|
|
; SI: s_load_dwordx16 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x19
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx16 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x64
|
|
|
|
|
; HSA-VI: s_load_dwordx16 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x40
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v16i32_arg(<16 x i32> addrspace(1)* nocapture %out, <16 x i32> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <16 x i32> %in, <16 x i32> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-11 22:26:46 +08:00
|
|
|
; FUNC-LABEL: {{^}}v16f32_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 128
|
2016-12-07 05:53:10 +08:00
|
|
|
; HSA-VI: kernarg_segment_alignment = 6
|
2018-07-28 20:34:25 +08:00
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[6].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[7].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[8].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].X
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].Y
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].Z
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[9].W
|
|
|
|
|
; EGCM-DAG: T{{[0-9]\.[XYZW]}}, KC0[10].X
|
2015-12-01 05:15:53 +08:00
|
|
|
; SI: s_load_dwordx16 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x19
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-VI: s_load_dwordx16 s{{\[[0-9]+:[0-9]+\]}}, s[0:1], 0x64
|
|
|
|
|
; HSA-VI: s_load_dwordx16 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x40
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @v16f32_arg(<16 x float> addrspace(1)* nocapture %out, <16 x float> %in) nounwind {
|
2013-10-23 08:44:32 +08:00
|
|
|
entry:
|
|
|
|
|
store <16 x float> %in, <16 x float> addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
2014-08-14 02:14:11 +08:00
|
|
|
|
2014-10-02 01:15:17 +08:00
|
|
|
; FUNC-LABEL: {{^}}kernel_arg_i64:
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; MESA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[0:1], 0x24
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x0
|
|
|
|
|
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-GCN: buffer_store_dwordx2
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @kernel_arg_i64(i64 addrspace(1)* %out, i64 %a) nounwind {
|
2014-08-14 02:14:11 +08:00
|
|
|
store i64 %a, i64 addrspace(1)* %out, align 8
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2015-04-26 08:53:33 +08:00
|
|
|
; FUNC-LABEL: {{^}}f64_kernel_arg:
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
; SI-DAG: s_load_dwordx4 s[{{[0-9]:[0-9]}}], s[0:1], 0x9
|
|
|
|
|
; MESA-VI-DAG: s_load_dwordx4 s[{{[0-9]:[0-9]}}], s[0:1], 0x24
|
2016-09-17 06:20:24 +08:00
|
|
|
; MESA-GCN: buffer_store_dwordx2
|
AMDGPU: Add pass to lower kernel arguments to loads
This replaces most argument uses with loads, but for
now not all.
The code in SelectionDAG for calling convention lowering
is actively harmful for amdgpu_kernel. It attempts to
split the argument types into register legal types, which
results in low quality code for arbitary types. Since
all kernel arguments are passed in memory, we just want the
raw types.
I've tried a couple of methods of mitigating this in SelectionDAG,
but it's easier to just bypass this problem alltogether. It's
possible to hack around the problem in the initial lowering,
but the real problem is the DAG then expects to be able to use
CopyToReg/CopyFromReg for uses of the arguments outside the block.
Exposing the argument loads in the IR also has the advantage
that the LoadStoreVectorizer can merge them.
I'm not sure the best approach to dealing with the IR
argument list is. The patch as-is just leaves the IR arguments
in place, so all the existing code will still compute the same
kernarg size and pointlessly lowers the arguments.
Arguably the frontend should emit kernels with an empty argument
list in the first place. Alternatively a dummy array could be
inserted as a single argument just to reserve space.
This does have some disadvantages. Local pointer kernel arguments can
no longer have AssertZext placed on them as the equivalent !range
metadata is not valid on pointer typed loads. This is mostly bad
for SI which needs to know about the known bits in order to use the
DS instruction offset, so in this case this is not done.
More importantly, this skips noalias arguments since this pass
does not yet convert this to the equivalent !alias.scope and !noalias
metadata. Producing this metadata correctly seems to be tricky,
although this logically is the same as inlining into a function which
doesn't exist. Additionally, exposing these loads to the vectorizer
may result in degraded aliasing information if a pointer load is
merged with another argument load.
I'm also not entirely sure this is preserving the current clover
ABI, although I would greatly prefer if it would stop widening
arguments and match the HSA ABI. As-is I think it is extending
< 4-byte arguments to 4-bytes but doesn't align them to 4-bytes.
llvm-svn: 335650
2018-06-27 03:10:00 +08:00
|
|
|
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s[{{[0-9]+:[0-9]+}}], s[4:5], 0x0
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @f64_kernel_arg(double addrspace(1)* %out, double %in) {
|
2015-04-26 08:53:33 +08:00
|
|
|
entry:
|
|
|
|
|
store double %in, double addrspace(1)* %out
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2014-10-02 01:15:17 +08:00
|
|
|
; XFUNC-LABEL: {{^}}kernel_arg_v1i64:
|
2015-02-11 22:26:46 +08:00
|
|
|
; XGCN: s_load_dwordx2
|
|
|
|
|
; XGCN: s_load_dwordx2
|
|
|
|
|
; XGCN: buffer_store_dwordx2
|
2017-03-22 05:39:51 +08:00
|
|
|
; define amdgpu_kernel void @kernel_arg_v1i64(<1 x i64> addrspace(1)* %out, <1 x i64> %a) nounwind {
|
2014-08-14 02:14:11 +08:00
|
|
|
; store <1 x i64> %a, <1 x i64> addrspace(1)* %out, align 8
|
|
|
|
|
; ret void
|
|
|
|
|
; }
|
2016-06-03 03:54:26 +08:00
|
|
|
|
2018-07-20 17:05:08 +08:00
|
|
|
; FUNC-LABEL: {{^}}i65_arg:
|
|
|
|
|
; HSA-VI: kernarg_segment_byte_size = 24
|
|
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x8
|
|
|
|
|
define amdgpu_kernel void @i65_arg(i65 addrspace(1)* nocapture %out, i65 %in) nounwind {
|
|
|
|
|
entry:
|
|
|
|
|
store i65 %in, i65 addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
2016-06-03 03:54:26 +08:00
|
|
|
; FUNC-LABEL: {{^}}i1_arg:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
|
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; GCN: s_load_dword s
|
|
|
|
|
; GCN: s_and_b32
|
|
|
|
|
; GCN: {{buffer|flat}}_store_byte
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i1_arg(i1 addrspace(1)* %out, i1 %x) nounwind {
|
2016-06-03 03:54:26 +08:00
|
|
|
store i1 %x, i1 addrspace(1)* %out, align 1
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; FUNC-LABEL: {{^}}i1_arg_zext_i32:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
|
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; GCN: s_load_dword
|
|
|
|
|
; SGCN: buffer_store_dword
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i1_arg_zext_i32(i32 addrspace(1)* %out, i1 %x) nounwind {
|
2016-06-03 03:54:26 +08:00
|
|
|
%ext = zext i1 %x to i32
|
|
|
|
|
store i32 %ext, i32 addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; FUNC-LABEL: {{^}}i1_arg_zext_i64:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
|
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; GCN: s_load_dword s
|
|
|
|
|
; GCN: {{buffer|flat}}_store_dwordx2
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i1_arg_zext_i64(i64 addrspace(1)* %out, i1 %x) nounwind {
|
2016-06-03 03:54:26 +08:00
|
|
|
%ext = zext i1 %x to i64
|
|
|
|
|
store i64 %ext, i64 addrspace(1)* %out, align 8
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; FUNC-LABEL: {{^}}i1_arg_sext_i32:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
|
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; GCN: s_load_dword
|
|
|
|
|
; GCN: {{buffer|flat}}_store_dword
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i1_arg_sext_i32(i32 addrspace(1)* %out, i1 %x) nounwind {
|
2016-06-03 03:54:26 +08:00
|
|
|
%ext = sext i1 %x to i32
|
|
|
|
|
store i32 %ext, i32addrspace(1)* %out, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; FUNC-LABEL: {{^}}i1_arg_sext_i64:
|
2018-05-30 03:35:00 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 12
|
|
|
|
|
; HSA-VI: kernarg_segment_alignment = 4
|
|
|
|
|
|
AMDGPU: Try a lot harder to emit scalar loads
This has two main components. First, widen
widen short constant loads in DAG when they have
the correct alignment. This is already done a bit in
AMDGPUCodeGenPrepare, since that has access to
DivergenceAnalysis. This can't help kernarg loads
created in the DAG. Start to use DAG divergence analysis
to help this case.
The second part is to avoid kernel argument lowering
breaking the alignment of short vector elements because
calling convention lowering wants to split everything
into legal register types.
When loading a split type, load the nearest 4-byte aligned
segment and shift to get the desired bits. This extra
load of the earlier argument piece ends up merging,
and the bit extract hopefully folds out.
There are a number of improvements and regressions with
this, but I think as-is this is a better compromise between
several of the worst parts of SelectionDAG.
Particularly when i16 is legal, this produces worse code
for i8 and i16 element vector kernel arguments. This is
partially due to the very weak load merging the DAG does.
It only looks for fairly specific combines between pairs
of loads which no longer appear. In particular this
causes v4i16 loads to be split into 2 components when
previously the two halves were merged.
Worse, because of the newly introduced shifts, there
is a lot more unnecessary vector packing and unpacking code
emitted. At least some of this is due to reporting
false for isTypeDesirableForOp for i16 as a workaround for
the lack of divergence information in the DAG. The cases
where this happens it doesn't actually matter, but the
relevant code in SimplifyDemandedBits doens't have the context
to know to ignore this.
The use of the scalar cache is probably more important
than the mess of mostly scalar instructions doing this packing
and unpacking. Future work can fix this, possibly by making better
use of the new DAG divergence information for controlling promotion
decisions, or adding another version of shift + trunc + shift
combines that doesn't only know about the used types.
llvm-svn: 334180
2018-06-07 17:54:49 +08:00
|
|
|
; GCN: s_load_dword
|
|
|
|
|
; GCN: s_bfe_i64
|
|
|
|
|
; GCN: {{buffer|flat}}_store_dwordx2
|
2017-03-22 05:39:51 +08:00
|
|
|
define amdgpu_kernel void @i1_arg_sext_i64(i64 addrspace(1)* %out, i1 %x) nounwind {
|
2016-06-03 03:54:26 +08:00
|
|
|
%ext = sext i1 %x to i64
|
|
|
|
|
store i64 %ext, i64 addrspace(1)* %out, align 8
|
|
|
|
|
ret void
|
|
|
|
|
}
|
2018-07-06 01:01:20 +08:00
|
|
|
|
|
|
|
|
; FUNC-LABEL: {{^}}empty_struct_arg:
|
2018-07-20 17:05:08 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 0
|
2018-07-06 01:01:20 +08:00
|
|
|
define amdgpu_kernel void @empty_struct_arg({} %in) nounwind {
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; The correct load offsets for these:
|
|
|
|
|
; load 4 from 0,
|
|
|
|
|
; load 8 from 8
|
|
|
|
|
; load 4 from 24
|
|
|
|
|
; load 8 from 32
|
|
|
|
|
|
|
|
|
|
; With the SelectionDAG argument lowering, the alignments for the
|
|
|
|
|
; struct members is not properly considered, making these wrong.
|
|
|
|
|
|
|
|
|
|
; FIXME: Total argument size is computed wrong
|
|
|
|
|
; FUNC-LABEL: {{^}}struct_argument_alignment:
|
2018-07-20 17:05:08 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 40
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x8
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x18
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x20
|
2018-07-06 01:01:20 +08:00
|
|
|
define amdgpu_kernel void @struct_argument_alignment({i32, i64} %arg0, i8, {i32, i64} %arg1) {
|
|
|
|
|
%val0 = extractvalue {i32, i64} %arg0, 0
|
|
|
|
|
%val1 = extractvalue {i32, i64} %arg0, 1
|
|
|
|
|
%val2 = extractvalue {i32, i64} %arg1, 0
|
|
|
|
|
%val3 = extractvalue {i32, i64} %arg1, 1
|
|
|
|
|
store volatile i32 %val0, i32 addrspace(1)* null
|
|
|
|
|
store volatile i64 %val1, i64 addrspace(1)* null
|
|
|
|
|
store volatile i32 %val2, i32 addrspace(1)* null
|
|
|
|
|
store volatile i64 %val3, i64 addrspace(1)* null
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; No padding between i8 and next struct, but round up at end to 4 byte
|
|
|
|
|
; multiple.
|
|
|
|
|
; FUNC-LABEL: {{^}}packed_struct_argument_alignment:
|
2018-07-20 17:05:08 +08:00
|
|
|
; HSA-VI: kernarg_segment_byte_size = 28
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x4
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0xc
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x10
|
2018-07-06 01:01:20 +08:00
|
|
|
define amdgpu_kernel void @packed_struct_argument_alignment(<{i32, i64}> %arg0, i8, <{i32, i64}> %arg1) {
|
|
|
|
|
%val0 = extractvalue <{i32, i64}> %arg0, 0
|
|
|
|
|
%val1 = extractvalue <{i32, i64}> %arg0, 1
|
|
|
|
|
%val2 = extractvalue <{i32, i64}> %arg1, 0
|
|
|
|
|
%val3 = extractvalue <{i32, i64}> %arg1, 1
|
|
|
|
|
store volatile i32 %val0, i32 addrspace(1)* null
|
|
|
|
|
store volatile i64 %val1, i64 addrspace(1)* null
|
|
|
|
|
store volatile i32 %val2, i32 addrspace(1)* null
|
|
|
|
|
store volatile i64 %val3, i64 addrspace(1)* null
|
|
|
|
|
ret void
|
|
|
|
|
}
|
2018-07-20 17:05:08 +08:00
|
|
|
|
|
|
|
|
; GCN-LABEL: {{^}}struct_argument_alignment_after:
|
|
|
|
|
; HSA-VI: kernarg_segment_byte_size = 64
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x8
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x18
|
|
|
|
|
; HSA-VI: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x20
|
|
|
|
|
; HSA-VI: s_load_dwordx4 s{{\[[0-9]+:[0-9]+\]}}, s[4:5], 0x30
|
|
|
|
|
define amdgpu_kernel void @struct_argument_alignment_after({i32, i64} %arg0, i8, {i32, i64} %arg2, i8, <4 x i32> %arg4) {
|
|
|
|
|
%val0 = extractvalue {i32, i64} %arg0, 0
|
|
|
|
|
%val1 = extractvalue {i32, i64} %arg0, 1
|
|
|
|
|
%val2 = extractvalue {i32, i64} %arg2, 0
|
|
|
|
|
%val3 = extractvalue {i32, i64} %arg2, 1
|
|
|
|
|
store volatile i32 %val0, i32 addrspace(1)* null
|
|
|
|
|
store volatile i64 %val1, i64 addrspace(1)* null
|
|
|
|
|
store volatile i32 %val2, i32 addrspace(1)* null
|
|
|
|
|
store volatile i64 %val3, i64 addrspace(1)* null
|
|
|
|
|
store volatile <4 x i32> %arg4, <4 x i32> addrspace(1)* null
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; GCN-LABEL: {{^}}array_3xi32:
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x4
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x8
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0xc
|
|
|
|
|
define amdgpu_kernel void @array_3xi32(i16 %arg0, [3 x i32] %arg1) {
|
|
|
|
|
store volatile i16 %arg0, i16 addrspace(1)* undef
|
|
|
|
|
store volatile [3 x i32] %arg1, [3 x i32] addrspace(1)* undef
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; FIXME: Why not all scalar loads?
|
|
|
|
|
; GCN-LABEL: {{^}}array_3xi16:
|
|
|
|
|
; HSA-VI: s_add_u32 s{{[0-9]+}}, s4, 2
|
|
|
|
|
; HSA-VI: s_addc_u32 s{{[0-9]+}}, s5, 0
|
|
|
|
|
; HSA-VI: flat_load_ushort
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x0
|
|
|
|
|
; HSA-VI: s_load_dword s{{[0-9]+}}, s[4:5], 0x4
|
|
|
|
|
define amdgpu_kernel void @array_3xi16(i8 %arg0, [3 x i16] %arg1) {
|
|
|
|
|
store volatile i8 %arg0, i8 addrspace(1)* undef
|
|
|
|
|
store volatile [3 x i16] %arg1, [3 x i16] addrspace(1)* undef
|
|
|
|
|
ret void
|
|
|
|
|
}
|