2009-10-11 17:03:14 +08:00
|
|
|
//===--- SemaExceptionSpec.cpp - C++ Exception Specifications ---*- C++ -*-===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file provides Sema routines for C++ exception specification testing.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "Sema.h"
|
|
|
|
#include "clang/Basic/Diagnostic.h"
|
|
|
|
#include "clang/AST/CXXInheritance.h"
|
|
|
|
#include "clang/AST/Expr.h"
|
|
|
|
#include "clang/AST/ExprCXX.h"
|
|
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
|
|
|
|
|
|
namespace clang {
|
|
|
|
|
|
|
|
static const FunctionProtoType *GetUnderlyingFunction(QualType T)
|
|
|
|
{
|
|
|
|
if (const PointerType *PtrTy = T->getAs<PointerType>())
|
|
|
|
T = PtrTy->getPointeeType();
|
|
|
|
else if (const ReferenceType *RefTy = T->getAs<ReferenceType>())
|
|
|
|
T = RefTy->getPointeeType();
|
2009-10-14 22:38:54 +08:00
|
|
|
else if (const MemberPointerType *MPTy = T->getAs<MemberPointerType>())
|
|
|
|
T = MPTy->getPointeeType();
|
2009-10-11 17:03:14 +08:00
|
|
|
return T->getAs<FunctionProtoType>();
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckSpecifiedExceptionType - Check if the given type is valid in an
|
|
|
|
/// exception specification. Incomplete types, or pointers to incomplete types
|
|
|
|
/// other than void are not allowed.
|
|
|
|
bool Sema::CheckSpecifiedExceptionType(QualType T, const SourceRange &Range) {
|
|
|
|
// FIXME: This may not correctly work with the fix for core issue 437,
|
|
|
|
// where a class's own type is considered complete within its body. But
|
|
|
|
// perhaps RequireCompleteType itself should contain this logic?
|
|
|
|
|
|
|
|
// C++ 15.4p2: A type denoted in an exception-specification shall not denote
|
|
|
|
// an incomplete type.
|
2009-10-14 22:59:48 +08:00
|
|
|
if (RequireCompleteType(Range.getBegin(), T,
|
|
|
|
PDiag(diag::err_incomplete_in_exception_spec) << /*direct*/0 << Range))
|
|
|
|
return true;
|
2009-10-11 17:03:14 +08:00
|
|
|
|
|
|
|
// C++ 15.4p2: A type denoted in an exception-specification shall not denote
|
|
|
|
// an incomplete type a pointer or reference to an incomplete type, other
|
|
|
|
// than (cv) void*.
|
|
|
|
int kind;
|
|
|
|
if (const PointerType* IT = T->getAs<PointerType>()) {
|
|
|
|
T = IT->getPointeeType();
|
|
|
|
kind = 1;
|
|
|
|
} else if (const ReferenceType* IT = T->getAs<ReferenceType>()) {
|
|
|
|
T = IT->getPointeeType();
|
|
|
|
kind = 2;
|
|
|
|
} else
|
|
|
|
return false;
|
|
|
|
|
2009-10-14 22:59:48 +08:00
|
|
|
if (!T->isVoidType() && RequireCompleteType(Range.getBegin(), T,
|
|
|
|
PDiag(diag::err_incomplete_in_exception_spec) << /*direct*/kind << Range))
|
|
|
|
return true;
|
2009-10-11 17:03:14 +08:00
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckDistantExceptionSpec - Check if the given type is a pointer or pointer
|
|
|
|
/// to member to a function with an exception specification. This means that
|
|
|
|
/// it is invalid to add another level of indirection.
|
|
|
|
bool Sema::CheckDistantExceptionSpec(QualType T) {
|
|
|
|
if (const PointerType *PT = T->getAs<PointerType>())
|
|
|
|
T = PT->getPointeeType();
|
|
|
|
else if (const MemberPointerType *PT = T->getAs<MemberPointerType>())
|
|
|
|
T = PT->getPointeeType();
|
|
|
|
else
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const FunctionProtoType *FnT = T->getAs<FunctionProtoType>();
|
|
|
|
if (!FnT)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return FnT->hasExceptionSpec();
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckEquivalentExceptionSpec - Check if the two types have equivalent
|
|
|
|
/// exception specifications. Exception specifications are equivalent if
|
|
|
|
/// they allow exactly the same set of exception types. It does not matter how
|
|
|
|
/// that is achieved. See C++ [except.spec]p2.
|
|
|
|
bool Sema::CheckEquivalentExceptionSpec(
|
|
|
|
const FunctionProtoType *Old, SourceLocation OldLoc,
|
|
|
|
const FunctionProtoType *New, SourceLocation NewLoc) {
|
|
|
|
return CheckEquivalentExceptionSpec(diag::err_mismatched_exception_spec,
|
|
|
|
diag::note_previous_declaration,
|
|
|
|
Old, OldLoc, New, NewLoc);
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckEquivalentExceptionSpec - Check if the two types have equivalent
|
|
|
|
/// exception specifications. Exception specifications are equivalent if
|
|
|
|
/// they allow exactly the same set of exception types. It does not matter how
|
|
|
|
/// that is achieved. See C++ [except.spec]p2.
|
|
|
|
bool Sema::CheckEquivalentExceptionSpec(
|
2009-10-15 00:09:29 +08:00
|
|
|
const PartialDiagnostic &DiagID, const PartialDiagnostic & NoteID,
|
2009-10-11 17:03:14 +08:00
|
|
|
const FunctionProtoType *Old, SourceLocation OldLoc,
|
|
|
|
const FunctionProtoType *New, SourceLocation NewLoc) {
|
|
|
|
bool OldAny = !Old->hasExceptionSpec() || Old->hasAnyExceptionSpec();
|
|
|
|
bool NewAny = !New->hasExceptionSpec() || New->hasAnyExceptionSpec();
|
|
|
|
if (OldAny && NewAny)
|
|
|
|
return false;
|
|
|
|
if (OldAny || NewAny) {
|
|
|
|
Diag(NewLoc, DiagID);
|
2009-10-15 00:09:29 +08:00
|
|
|
if (NoteID.getDiagID() != 0)
|
2009-10-11 17:03:14 +08:00
|
|
|
Diag(OldLoc, NoteID);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Success = true;
|
|
|
|
// Both have a definite exception spec. Collect the first set, then compare
|
|
|
|
// to the second.
|
2009-10-14 23:06:25 +08:00
|
|
|
llvm::SmallPtrSet<CanQualType, 8> OldTypes, NewTypes;
|
2009-10-11 17:03:14 +08:00
|
|
|
for (FunctionProtoType::exception_iterator I = Old->exception_begin(),
|
|
|
|
E = Old->exception_end(); I != E; ++I)
|
2009-10-14 23:06:25 +08:00
|
|
|
OldTypes.insert(Context.getCanonicalType(*I).getUnqualifiedType());
|
2009-10-11 17:03:14 +08:00
|
|
|
|
|
|
|
for (FunctionProtoType::exception_iterator I = New->exception_begin(),
|
2009-10-11 17:11:23 +08:00
|
|
|
E = New->exception_end(); I != E && Success; ++I) {
|
2009-10-14 23:06:25 +08:00
|
|
|
CanQualType TypePtr = Context.getCanonicalType(*I).getUnqualifiedType();
|
2009-10-11 17:11:23 +08:00
|
|
|
if(OldTypes.count(TypePtr))
|
|
|
|
NewTypes.insert(TypePtr);
|
|
|
|
else
|
|
|
|
Success = false;
|
|
|
|
}
|
2009-10-11 17:03:14 +08:00
|
|
|
|
2009-10-11 17:11:23 +08:00
|
|
|
Success = Success && OldTypes.size() == NewTypes.size();
|
2009-10-11 17:03:14 +08:00
|
|
|
|
|
|
|
if (Success) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
Diag(NewLoc, DiagID);
|
2009-10-15 00:09:29 +08:00
|
|
|
if (NoteID.getDiagID() != 0)
|
2009-10-11 17:03:14 +08:00
|
|
|
Diag(OldLoc, NoteID);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckExceptionSpecSubset - Check whether the second function type's
|
|
|
|
/// exception specification is a subset (or equivalent) of the first function
|
|
|
|
/// type. This is used by override and pointer assignment checks.
|
2009-10-15 00:09:29 +08:00
|
|
|
bool Sema::CheckExceptionSpecSubset(
|
|
|
|
const PartialDiagnostic &DiagID, const PartialDiagnostic & NoteID,
|
2009-10-11 17:03:14 +08:00
|
|
|
const FunctionProtoType *Superset, SourceLocation SuperLoc,
|
|
|
|
const FunctionProtoType *Subset, SourceLocation SubLoc) {
|
|
|
|
// FIXME: As usual, we could be more specific in our error messages, but
|
|
|
|
// that better waits until we've got types with source locations.
|
|
|
|
|
|
|
|
if (!SubLoc.isValid())
|
|
|
|
SubLoc = SuperLoc;
|
|
|
|
|
|
|
|
// If superset contains everything, we're done.
|
|
|
|
if (!Superset->hasExceptionSpec() || Superset->hasAnyExceptionSpec())
|
|
|
|
return CheckParamExceptionSpec(NoteID, Superset, SuperLoc, Subset, SubLoc);
|
|
|
|
|
|
|
|
// It does not. If the subset contains everything, we've failed.
|
|
|
|
if (!Subset->hasExceptionSpec() || Subset->hasAnyExceptionSpec()) {
|
|
|
|
Diag(SubLoc, DiagID);
|
2009-10-15 00:09:29 +08:00
|
|
|
if (NoteID.getDiagID() != 0)
|
2009-10-11 17:03:14 +08:00
|
|
|
Diag(SuperLoc, NoteID);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Neither contains everything. Do a proper comparison.
|
|
|
|
for (FunctionProtoType::exception_iterator SubI = Subset->exception_begin(),
|
|
|
|
SubE = Subset->exception_end(); SubI != SubE; ++SubI) {
|
|
|
|
// Take one type from the subset.
|
|
|
|
QualType CanonicalSubT = Context.getCanonicalType(*SubI);
|
2009-10-14 22:38:54 +08:00
|
|
|
// Unwrap pointers and references so that we can do checks within a class
|
|
|
|
// hierarchy. Don't unwrap member pointers; they don't have hierarchy
|
|
|
|
// conversions on the pointee.
|
2009-10-11 17:03:14 +08:00
|
|
|
bool SubIsPointer = false;
|
|
|
|
if (const ReferenceType *RefTy = CanonicalSubT->getAs<ReferenceType>())
|
|
|
|
CanonicalSubT = RefTy->getPointeeType();
|
|
|
|
if (const PointerType *PtrTy = CanonicalSubT->getAs<PointerType>()) {
|
|
|
|
CanonicalSubT = PtrTy->getPointeeType();
|
|
|
|
SubIsPointer = true;
|
|
|
|
}
|
|
|
|
bool SubIsClass = CanonicalSubT->isRecordType();
|
First part of changes to eliminate problems with cv-qualifiers and
sugared types. The basic problem is that our qualifier accessors
(getQualifiers, getCVRQualifiers, isConstQualified, etc.) only look at
the current QualType and not at any qualifiers that come from sugared
types, meaning that we won't see these qualifiers through, e.g.,
typedefs:
typedef const int CInt;
typedef CInt Self;
Self.isConstQualified() currently returns false!
Various bugs (e.g., PR5383) have cropped up all over the front end due
to such problems. I'm addressing this problem by splitting each
qualifier accessor into two versions:
- the "local" version only returns qualifiers on this particular
QualType instance
- the "normal" version that will eventually combine qualifiers from this
QualType instance with the qualifiers on the canonical type to
produce the full set of qualifiers.
This commit adds the local versions and switches a few callers from
the "normal" version (e.g., isConstQualified) over to the "local"
version (e.g., isLocalConstQualified) when that is the right thing to
do, e.g., because we're printing or serializing the qualifiers. Also,
switch a bunch of
Context.getCanonicalType(T1).getUnqualifiedType() == Context.getCanonicalType(T2).getQualifiedType()
expressions over to
Context.hasSameUnqualifiedType(T1, T2)
llvm-svn: 88969
2009-11-17 05:35:15 +08:00
|
|
|
CanonicalSubT = CanonicalSubT.getLocalUnqualifiedType();
|
2009-10-11 17:03:14 +08:00
|
|
|
|
|
|
|
CXXBasePaths Paths(/*FindAmbiguities=*/true, /*RecordPaths=*/true,
|
|
|
|
/*DetectVirtual=*/false);
|
|
|
|
|
|
|
|
bool Contained = false;
|
|
|
|
// Make sure it's in the superset.
|
|
|
|
for (FunctionProtoType::exception_iterator SuperI =
|
|
|
|
Superset->exception_begin(), SuperE = Superset->exception_end();
|
|
|
|
SuperI != SuperE; ++SuperI) {
|
|
|
|
QualType CanonicalSuperT = Context.getCanonicalType(*SuperI);
|
|
|
|
// SubT must be SuperT or derived from it, or pointer or reference to
|
|
|
|
// such types.
|
|
|
|
if (const ReferenceType *RefTy = CanonicalSuperT->getAs<ReferenceType>())
|
|
|
|
CanonicalSuperT = RefTy->getPointeeType();
|
|
|
|
if (SubIsPointer) {
|
|
|
|
if (const PointerType *PtrTy = CanonicalSuperT->getAs<PointerType>())
|
|
|
|
CanonicalSuperT = PtrTy->getPointeeType();
|
|
|
|
else {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
First part of changes to eliminate problems with cv-qualifiers and
sugared types. The basic problem is that our qualifier accessors
(getQualifiers, getCVRQualifiers, isConstQualified, etc.) only look at
the current QualType and not at any qualifiers that come from sugared
types, meaning that we won't see these qualifiers through, e.g.,
typedefs:
typedef const int CInt;
typedef CInt Self;
Self.isConstQualified() currently returns false!
Various bugs (e.g., PR5383) have cropped up all over the front end due
to such problems. I'm addressing this problem by splitting each
qualifier accessor into two versions:
- the "local" version only returns qualifiers on this particular
QualType instance
- the "normal" version that will eventually combine qualifiers from this
QualType instance with the qualifiers on the canonical type to
produce the full set of qualifiers.
This commit adds the local versions and switches a few callers from
the "normal" version (e.g., isConstQualified) over to the "local"
version (e.g., isLocalConstQualified) when that is the right thing to
do, e.g., because we're printing or serializing the qualifiers. Also,
switch a bunch of
Context.getCanonicalType(T1).getUnqualifiedType() == Context.getCanonicalType(T2).getQualifiedType()
expressions over to
Context.hasSameUnqualifiedType(T1, T2)
llvm-svn: 88969
2009-11-17 05:35:15 +08:00
|
|
|
CanonicalSuperT = CanonicalSuperT.getLocalUnqualifiedType();
|
2009-10-11 17:03:14 +08:00
|
|
|
// If the types are the same, move on to the next type in the subset.
|
|
|
|
if (CanonicalSubT == CanonicalSuperT) {
|
|
|
|
Contained = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise we need to check the inheritance.
|
|
|
|
if (!SubIsClass || !CanonicalSuperT->isRecordType())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
Paths.clear();
|
|
|
|
if (!IsDerivedFrom(CanonicalSubT, CanonicalSuperT, Paths))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (Paths.isAmbiguous(CanonicalSuperT))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (FindInaccessibleBase(CanonicalSubT, CanonicalSuperT, Paths, true))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
Contained = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (!Contained) {
|
|
|
|
Diag(SubLoc, DiagID);
|
2009-10-15 00:09:29 +08:00
|
|
|
if (NoteID.getDiagID() != 0)
|
2009-10-11 17:03:14 +08:00
|
|
|
Diag(SuperLoc, NoteID);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// We've run half the gauntlet.
|
|
|
|
return CheckParamExceptionSpec(NoteID, Superset, SuperLoc, Subset, SubLoc);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool CheckSpecForTypesEquivalent(Sema &S,
|
2009-10-15 00:09:29 +08:00
|
|
|
const PartialDiagnostic &DiagID, const PartialDiagnostic & NoteID,
|
2009-10-11 17:03:14 +08:00
|
|
|
QualType Target, SourceLocation TargetLoc,
|
|
|
|
QualType Source, SourceLocation SourceLoc)
|
|
|
|
{
|
|
|
|
const FunctionProtoType *TFunc = GetUnderlyingFunction(Target);
|
|
|
|
if (!TFunc)
|
|
|
|
return false;
|
|
|
|
const FunctionProtoType *SFunc = GetUnderlyingFunction(Source);
|
|
|
|
if (!SFunc)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return S.CheckEquivalentExceptionSpec(DiagID, NoteID, TFunc, TargetLoc,
|
|
|
|
SFunc, SourceLoc);
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckParamExceptionSpec - Check if the parameter and return types of the
|
|
|
|
/// two functions have equivalent exception specs. This is part of the
|
|
|
|
/// assignment and override compatibility check. We do not check the parameters
|
|
|
|
/// of parameter function pointers recursively, as no sane programmer would
|
|
|
|
/// even be able to write such a function type.
|
2009-10-15 00:09:29 +08:00
|
|
|
bool Sema::CheckParamExceptionSpec(const PartialDiagnostic & NoteID,
|
2009-10-11 17:03:14 +08:00
|
|
|
const FunctionProtoType *Target, SourceLocation TargetLoc,
|
|
|
|
const FunctionProtoType *Source, SourceLocation SourceLoc)
|
|
|
|
{
|
2009-10-15 00:09:29 +08:00
|
|
|
if (CheckSpecForTypesEquivalent(*this,
|
|
|
|
PDiag(diag::err_deep_exception_specs_differ) << 0, 0,
|
2009-10-11 17:03:14 +08:00
|
|
|
Target->getResultType(), TargetLoc,
|
|
|
|
Source->getResultType(), SourceLoc))
|
|
|
|
return true;
|
|
|
|
|
2009-10-15 00:09:29 +08:00
|
|
|
// We shouldn't even be testing this unless the arguments are otherwise
|
2009-10-11 17:03:14 +08:00
|
|
|
// compatible.
|
|
|
|
assert(Target->getNumArgs() == Source->getNumArgs() &&
|
|
|
|
"Functions have different argument counts.");
|
|
|
|
for (unsigned i = 0, E = Target->getNumArgs(); i != E; ++i) {
|
2009-10-15 00:09:29 +08:00
|
|
|
if (CheckSpecForTypesEquivalent(*this,
|
|
|
|
PDiag(diag::err_deep_exception_specs_differ) << 1, 0,
|
2009-10-11 17:03:14 +08:00
|
|
|
Target->getArgType(i), TargetLoc,
|
|
|
|
Source->getArgType(i), SourceLoc))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Sema::CheckExceptionSpecCompatibility(Expr *From, QualType ToType)
|
|
|
|
{
|
|
|
|
// First we check for applicability.
|
|
|
|
// Target type must be a function, function pointer or function reference.
|
|
|
|
const FunctionProtoType *ToFunc = GetUnderlyingFunction(ToType);
|
|
|
|
if (!ToFunc)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// SourceType must be a function or function pointer.
|
|
|
|
const FunctionProtoType *FromFunc = GetUnderlyingFunction(From->getType());
|
|
|
|
if (!FromFunc)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Now we've got the correct types on both sides, check their compatibility.
|
|
|
|
// This means that the source of the conversion can only throw a subset of
|
|
|
|
// the exceptions of the target, and any exception specs on arguments or
|
|
|
|
// return types must be equivalent.
|
|
|
|
return CheckExceptionSpecSubset(diag::err_incompatible_exception_specs,
|
|
|
|
0, ToFunc, From->getSourceRange().getBegin(),
|
|
|
|
FromFunc, SourceLocation());
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Sema::CheckOverridingFunctionExceptionSpec(const CXXMethodDecl *New,
|
|
|
|
const CXXMethodDecl *Old) {
|
|
|
|
return CheckExceptionSpecSubset(diag::err_override_exception_spec,
|
|
|
|
diag::note_overridden_virtual_function,
|
|
|
|
Old->getType()->getAs<FunctionProtoType>(),
|
|
|
|
Old->getLocation(),
|
|
|
|
New->getType()->getAs<FunctionProtoType>(),
|
|
|
|
New->getLocation());
|
|
|
|
}
|
|
|
|
|
|
|
|
} // end namespace clang
|