2013-04-17 05:59:21 +08:00
|
|
|
// RUN: %clang -target x86_64-apple-darwin10 --analyze %s -o /dev/null -Xclang -analyzer-checker=debug.ConfigDumper > %t 2>&1
|
2012-10-02 02:28:19 +08:00
|
|
|
// RUN: FileCheck --input-file=%t %s
|
|
|
|
|
|
|
|
|
|
void bar() {}
|
|
|
|
|
void foo() { bar(); }
|
|
|
|
|
|
|
|
|
|
// CHECK: [config]
|
2013-03-29 08:09:28 +08:00
|
|
|
// CHECK-NEXT: cfg-conditional-static-initializers = true
|
2013-07-23 10:15:11 +08:00
|
|
|
// CHECK-NEXT: cfg-temporary-dtors = false
|
2012-10-02 02:28:19 +08:00
|
|
|
// CHECK-NEXT: faux-bodies = true
|
2012-10-24 07:59:05 +08:00
|
|
|
// CHECK-NEXT: graph-trim-interval = 1000
|
2013-01-25 07:15:30 +08:00
|
|
|
// CHECK-NEXT: ipa = dynamic-bifurcate
|
2012-10-03 04:31:56 +08:00
|
|
|
// CHECK-NEXT: ipa-always-inline-size = 3
|
2013-04-17 05:44:22 +08:00
|
|
|
// CHECK-NEXT: leak-diagnostics-reference-allocation = false
|
2013-01-31 03:12:36 +08:00
|
|
|
// CHECK-NEXT: max-inlinable-size = 50
|
2013-01-31 03:12:39 +08:00
|
|
|
// CHECK-NEXT: max-nodes = 150000
|
2012-12-18 04:08:51 +08:00
|
|
|
// CHECK-NEXT: max-times-inline-large = 32
|
2013-01-25 07:15:34 +08:00
|
|
|
// CHECK-NEXT: mode = deep
|
[analyzer] "Force" LazyCompoundVals on bind when they are simple enough.
The analyzer uses LazyCompoundVals to represent rvalues of aggregate types,
most importantly structs and arrays. This allows us to efficiently copy
around an entire struct, rather than doing a memberwise load every time a
struct rvalue is encountered. This can also keep memory usage down by
allowing several structs to "share" the same snapshotted bindings.
However, /lookup/ through LazyCompoundVals can be expensive, especially
since they can end up chaining back to the original value. While we try
to reuse LazyCompoundVals whenever it's safe, and cache information about
this transitivity, the fact is it's sometimes just not a good idea to
perpetuate LazyCompoundVals -- the tradeoffs just aren't worth it.
This commit changes RegionStore so that binding a LazyCompoundVal to struct
will do a memberwise copy if the struct is simple enough. Today's definition
of "simple enough" is "up to N scalar members" (see below), but that could
easily be changed in the future. This is enough to bring the test case in
PR15697 back down to a manageable analysis time (within 20% of its original
time, in an unfair test where the new analyzer is not compiled with LTO).
The actual value of "N" is controlled by a new -analyzer-config option,
'region-store-small-struct-limit'. It defaults to "2", meaning structs with
zero, one, or two scalar members will be considered "simple enough" for
this code path.
It's worth noting that a more straightforward implementation would do this
on load, not on bind, and make use of the structure we already have for this:
CompoundVal. A long time ago, this was actually how RegionStore modeled
aggregate-to-aggregate copies, but today it's only used for compound literals.
Unfortunately, it seems that we've special-cased LazyCompoundVal in certain
places (such as liveness checks) but failed to similarly special-case
CompoundVal in all of them. Until we're confident that CompoundVal is
handled properly everywhere, this solution is safer, since the entire
optimization is just an implementation detail of RegionStore.
<rdar://problem/13599304>
llvm-svn: 179767
2013-04-19 00:33:46 +08:00
|
|
|
// CHECK-NEXT: region-store-small-struct-limit = 2
|
2012-10-02 02:28:19 +08:00
|
|
|
// CHECK-NEXT: [stats]
|
[analyzer] "Force" LazyCompoundVals on bind when they are simple enough.
The analyzer uses LazyCompoundVals to represent rvalues of aggregate types,
most importantly structs and arrays. This allows us to efficiently copy
around an entire struct, rather than doing a memberwise load every time a
struct rvalue is encountered. This can also keep memory usage down by
allowing several structs to "share" the same snapshotted bindings.
However, /lookup/ through LazyCompoundVals can be expensive, especially
since they can end up chaining back to the original value. While we try
to reuse LazyCompoundVals whenever it's safe, and cache information about
this transitivity, the fact is it's sometimes just not a good idea to
perpetuate LazyCompoundVals -- the tradeoffs just aren't worth it.
This commit changes RegionStore so that binding a LazyCompoundVal to struct
will do a memberwise copy if the struct is simple enough. Today's definition
of "simple enough" is "up to N scalar members" (see below), but that could
easily be changed in the future. This is enough to bring the test case in
PR15697 back down to a manageable analysis time (within 20% of its original
time, in an unfair test where the new analyzer is not compiled with LTO).
The actual value of "N" is controlled by a new -analyzer-config option,
'region-store-small-struct-limit'. It defaults to "2", meaning structs with
zero, one, or two scalar members will be considered "simple enough" for
this code path.
It's worth noting that a more straightforward implementation would do this
on load, not on bind, and make use of the structure we already have for this:
CompoundVal. A long time ago, this was actually how RegionStore modeled
aggregate-to-aggregate copies, but today it's only used for compound literals.
Unfortunately, it seems that we've special-cased LazyCompoundVal in certain
places (such as liveness checks) but failed to similarly special-case
CompoundVal in all of them. Until we're confident that CompoundVal is
handled properly everywhere, this solution is safer, since the entire
optimization is just an implementation detail of RegionStore.
<rdar://problem/13599304>
llvm-svn: 179767
2013-04-19 00:33:46 +08:00
|
|
|
// CHECK-NEXT: num-entries = 12
|
2013-03-29 08:09:28 +08:00
|
|
|
|