Extract common PlatformPOSIX/Windows code into a separate class
Summary:
The two classes contained a lot of duplicated code, but there wasn't a
good place to factor it to. It couldn't be the base Platform class,
since we also have platforms which are only remote (such as
PlatformGDBRemoteServer), and so it did not make sense for those to have
an m_remote_platform member.
This patch creates a new class, RemoteAwarePlatform, which can serve as
a base class for platforms which can both serve as a host, and forward
actions to a remote system. It is motivated partly by D56232 (which was
about to add a bunch of additional duplicated methods), and partly by my
own need to modify a function which happens to be implemented in both
places identically.
The patch moves the methods which are trivially identical in the two
classes into the common base class, there were one or two more methods
which could probably be merged into one, but this wasn't completely
trivial, so I did not attempt to do that now.
Reviewers: jingham, zturner, clayborg, asmith
Subscribers: emaste, mgorny, Hui, lldb-commits
Differential Revision: https://reviews.llvm.org/D58052
llvm-svn: 353812
2019-02-12 17:27:24 +08:00
|
|
|
//===-- RemoteAwarePlatform.cpp ---------------------------------*- C++ -*-===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "lldb/Target/RemoteAwarePlatform.h"
|
2019-02-14 13:34:46 +08:00
|
|
|
#include "lldb/Host/FileCache.h"
|
|
|
|
#include "lldb/Host/FileSystem.h"
|
Extract common PlatformPOSIX/Windows code into a separate class
Summary:
The two classes contained a lot of duplicated code, but there wasn't a
good place to factor it to. It couldn't be the base Platform class,
since we also have platforms which are only remote (such as
PlatformGDBRemoteServer), and so it did not make sense for those to have
an m_remote_platform member.
This patch creates a new class, RemoteAwarePlatform, which can serve as
a base class for platforms which can both serve as a host, and forward
actions to a remote system. It is motivated partly by D56232 (which was
about to add a bunch of additional duplicated methods), and partly by my
own need to modify a function which happens to be implemented in both
places identically.
The patch moves the methods which are trivially identical in the two
classes into the common base class, there were one or two more methods
which could probably be merged into one, but this wasn't completely
trivial, so I did not attempt to do that now.
Reviewers: jingham, zturner, clayborg, asmith
Subscribers: emaste, mgorny, Hui, lldb-commits
Differential Revision: https://reviews.llvm.org/D58052
llvm-svn: 353812
2019-02-12 17:27:24 +08:00
|
|
|
#include "lldb/Host/Host.h"
|
2019-03-05 02:48:00 +08:00
|
|
|
#include "lldb/Host/HostInfo.h"
|
Extract common PlatformPOSIX/Windows code into a separate class
Summary:
The two classes contained a lot of duplicated code, but there wasn't a
good place to factor it to. It couldn't be the base Platform class,
since we also have platforms which are only remote (such as
PlatformGDBRemoteServer), and so it did not make sense for those to have
an m_remote_platform member.
This patch creates a new class, RemoteAwarePlatform, which can serve as
a base class for platforms which can both serve as a host, and forward
actions to a remote system. It is motivated partly by D56232 (which was
about to add a bunch of additional duplicated methods), and partly by my
own need to modify a function which happens to be implemented in both
places identically.
The patch moves the methods which are trivially identical in the two
classes into the common base class, there were one or two more methods
which could probably be merged into one, but this wasn't completely
trivial, so I did not attempt to do that now.
Reviewers: jingham, zturner, clayborg, asmith
Subscribers: emaste, mgorny, Hui, lldb-commits
Differential Revision: https://reviews.llvm.org/D58052
llvm-svn: 353812
2019-02-12 17:27:24 +08:00
|
|
|
|
|
|
|
using namespace lldb_private;
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::GetModuleSpec(const FileSpec &module_file_spec,
|
|
|
|
const ArchSpec &arch,
|
|
|
|
ModuleSpec &module_spec) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetModuleSpec(module_file_spec, arch,
|
|
|
|
module_spec);
|
|
|
|
|
|
|
|
return Platform::GetModuleSpec(module_file_spec, arch, module_spec);
|
|
|
|
}
|
|
|
|
|
2019-02-14 13:34:46 +08:00
|
|
|
Status RemoteAwarePlatform::RunShellCommand(
|
|
|
|
const char *command, const FileSpec &working_dir, int *status_ptr,
|
|
|
|
int *signo_ptr, std::string *command_output,
|
|
|
|
const Timeout<std::micro> &timeout) {
|
|
|
|
if (IsHost())
|
|
|
|
return Host::RunShellCommand(command, working_dir, status_ptr, signo_ptr,
|
|
|
|
command_output, timeout);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->RunShellCommand(
|
|
|
|
command, working_dir, status_ptr, signo_ptr, command_output, timeout);
|
|
|
|
return Status("unable to run a remote command without a platform");
|
|
|
|
}
|
|
|
|
|
|
|
|
Status RemoteAwarePlatform::MakeDirectory(const FileSpec &file_spec,
|
|
|
|
uint32_t file_permissions) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->MakeDirectory(file_spec, file_permissions);
|
|
|
|
return Platform::MakeDirectory(file_spec, file_permissions);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status RemoteAwarePlatform::GetFilePermissions(const FileSpec &file_spec,
|
|
|
|
uint32_t &file_permissions) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetFilePermissions(file_spec,
|
|
|
|
file_permissions);
|
|
|
|
return Platform::GetFilePermissions(file_spec, file_permissions);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status RemoteAwarePlatform::SetFilePermissions(const FileSpec &file_spec,
|
|
|
|
uint32_t file_permissions) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->SetFilePermissions(file_spec,
|
|
|
|
file_permissions);
|
|
|
|
return Platform::SetFilePermissions(file_spec, file_permissions);
|
|
|
|
}
|
|
|
|
|
|
|
|
lldb::user_id_t RemoteAwarePlatform::OpenFile(const FileSpec &file_spec,
|
|
|
|
uint32_t flags, uint32_t mode,
|
|
|
|
Status &error) {
|
|
|
|
if (IsHost())
|
|
|
|
return FileCache::GetInstance().OpenFile(file_spec, flags, mode, error);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->OpenFile(file_spec, flags, mode, error);
|
|
|
|
return Platform::OpenFile(file_spec, flags, mode, error);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::CloseFile(lldb::user_id_t fd, Status &error) {
|
|
|
|
if (IsHost())
|
|
|
|
return FileCache::GetInstance().CloseFile(fd, error);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->CloseFile(fd, error);
|
|
|
|
return Platform::CloseFile(fd, error);
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t RemoteAwarePlatform::ReadFile(lldb::user_id_t fd, uint64_t offset,
|
|
|
|
void *dst, uint64_t dst_len,
|
|
|
|
Status &error) {
|
|
|
|
if (IsHost())
|
|
|
|
return FileCache::GetInstance().ReadFile(fd, offset, dst, dst_len, error);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->ReadFile(fd, offset, dst, dst_len, error);
|
|
|
|
return Platform::ReadFile(fd, offset, dst, dst_len, error);
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t RemoteAwarePlatform::WriteFile(lldb::user_id_t fd, uint64_t offset,
|
|
|
|
const void *src, uint64_t src_len,
|
|
|
|
Status &error) {
|
|
|
|
if (IsHost())
|
|
|
|
return FileCache::GetInstance().WriteFile(fd, offset, src, src_len, error);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->WriteFile(fd, offset, src, src_len, error);
|
|
|
|
return Platform::WriteFile(fd, offset, src, src_len, error);
|
|
|
|
}
|
|
|
|
|
|
|
|
lldb::user_id_t RemoteAwarePlatform::GetFileSize(const FileSpec &file_spec) {
|
|
|
|
if (IsHost()) {
|
|
|
|
uint64_t Size;
|
|
|
|
if (llvm::sys::fs::file_size(file_spec.GetPath(), Size))
|
|
|
|
return 0;
|
|
|
|
return Size;
|
|
|
|
}
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetFileSize(file_spec);
|
|
|
|
return Platform::GetFileSize(file_spec);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status RemoteAwarePlatform::CreateSymlink(const FileSpec &src,
|
|
|
|
const FileSpec &dst) {
|
|
|
|
if (IsHost())
|
|
|
|
return FileSystem::Instance().Symlink(src, dst);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->CreateSymlink(src, dst);
|
|
|
|
return Platform::CreateSymlink(src, dst);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::GetFileExists(const FileSpec &file_spec) {
|
|
|
|
if (IsHost())
|
|
|
|
return FileSystem::Instance().Exists(file_spec);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetFileExists(file_spec);
|
|
|
|
return Platform::GetFileExists(file_spec);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status RemoteAwarePlatform::Unlink(const FileSpec &file_spec) {
|
|
|
|
if (IsHost())
|
|
|
|
return llvm::sys::fs::remove(file_spec.GetPath());
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->Unlink(file_spec);
|
|
|
|
return Platform::Unlink(file_spec);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::CalculateMD5(const FileSpec &file_spec, uint64_t &low,
|
|
|
|
uint64_t &high) {
|
|
|
|
if (IsHost())
|
|
|
|
return Platform::CalculateMD5(file_spec, low, high);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->CalculateMD5(file_spec, low, high);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
FileSpec RemoteAwarePlatform::GetRemoteWorkingDirectory() {
|
|
|
|
if (IsRemote() && m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetRemoteWorkingDirectory();
|
|
|
|
return Platform::GetRemoteWorkingDirectory();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::SetRemoteWorkingDirectory(
|
|
|
|
const FileSpec &working_dir) {
|
|
|
|
if (IsRemote() && m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->SetRemoteWorkingDirectory(working_dir);
|
|
|
|
return Platform::SetRemoteWorkingDirectory(working_dir);
|
|
|
|
}
|
|
|
|
|
Extract common PlatformPOSIX/Windows code into a separate class
Summary:
The two classes contained a lot of duplicated code, but there wasn't a
good place to factor it to. It couldn't be the base Platform class,
since we also have platforms which are only remote (such as
PlatformGDBRemoteServer), and so it did not make sense for those to have
an m_remote_platform member.
This patch creates a new class, RemoteAwarePlatform, which can serve as
a base class for platforms which can both serve as a host, and forward
actions to a remote system. It is motivated partly by D56232 (which was
about to add a bunch of additional duplicated methods), and partly by my
own need to modify a function which happens to be implemented in both
places identically.
The patch moves the methods which are trivially identical in the two
classes into the common base class, there were one or two more methods
which could probably be merged into one, but this wasn't completely
trivial, so I did not attempt to do that now.
Reviewers: jingham, zturner, clayborg, asmith
Subscribers: emaste, mgorny, Hui, lldb-commits
Differential Revision: https://reviews.llvm.org/D58052
llvm-svn: 353812
2019-02-12 17:27:24 +08:00
|
|
|
Status RemoteAwarePlatform::GetFileWithUUID(const FileSpec &platform_file,
|
|
|
|
const UUID *uuid_ptr,
|
|
|
|
FileSpec &local_file) {
|
|
|
|
if (IsRemote() && m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetFileWithUUID(platform_file, uuid_ptr,
|
|
|
|
local_file);
|
|
|
|
|
|
|
|
// Default to the local case
|
|
|
|
local_file = platform_file;
|
|
|
|
return Status();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::GetRemoteOSVersion() {
|
|
|
|
if (m_remote_platform_sp) {
|
|
|
|
m_os_version = m_remote_platform_sp->GetOSVersion();
|
|
|
|
return !m_os_version.empty();
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::GetRemoteOSBuildString(std::string &s) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetRemoteOSBuildString(s);
|
|
|
|
s.clear();
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::GetRemoteOSKernelDescription(std::string &s) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetRemoteOSKernelDescription(s);
|
|
|
|
s.clear();
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
ArchSpec RemoteAwarePlatform::GetRemoteSystemArchitecture() {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetRemoteSystemArchitecture();
|
|
|
|
return ArchSpec();
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *RemoteAwarePlatform::GetHostname() {
|
|
|
|
if (IsHost())
|
|
|
|
return Platform::GetHostname();
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetHostname();
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2019-03-05 02:48:00 +08:00
|
|
|
UserIDResolver &RemoteAwarePlatform::GetUserIDResolver() {
|
|
|
|
if (IsHost())
|
|
|
|
return HostInfo::GetUserIDResolver();
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetUserIDResolver();
|
|
|
|
return UserIDResolver::GetNoopResolver();
|
Extract common PlatformPOSIX/Windows code into a separate class
Summary:
The two classes contained a lot of duplicated code, but there wasn't a
good place to factor it to. It couldn't be the base Platform class,
since we also have platforms which are only remote (such as
PlatformGDBRemoteServer), and so it did not make sense for those to have
an m_remote_platform member.
This patch creates a new class, RemoteAwarePlatform, which can serve as
a base class for platforms which can both serve as a host, and forward
actions to a remote system. It is motivated partly by D56232 (which was
about to add a bunch of additional duplicated methods), and partly by my
own need to modify a function which happens to be implemented in both
places identically.
The patch moves the methods which are trivially identical in the two
classes into the common base class, there were one or two more methods
which could probably be merged into one, but this wasn't completely
trivial, so I did not attempt to do that now.
Reviewers: jingham, zturner, clayborg, asmith
Subscribers: emaste, mgorny, Hui, lldb-commits
Differential Revision: https://reviews.llvm.org/D58052
llvm-svn: 353812
2019-02-12 17:27:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
Environment RemoteAwarePlatform::GetEnvironment() {
|
|
|
|
if (IsRemote()) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetEnvironment();
|
|
|
|
return Environment();
|
|
|
|
}
|
|
|
|
return Host::GetEnvironment();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::IsConnected() const {
|
|
|
|
if (IsHost())
|
|
|
|
return true;
|
|
|
|
else if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->IsConnected();
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RemoteAwarePlatform::GetProcessInfo(lldb::pid_t pid,
|
|
|
|
ProcessInstanceInfo &process_info) {
|
|
|
|
if (IsHost())
|
|
|
|
return Platform::GetProcessInfo(pid, process_info);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->GetProcessInfo(pid, process_info);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint32_t
|
|
|
|
RemoteAwarePlatform::FindProcesses(const ProcessInstanceInfoMatch &match_info,
|
|
|
|
ProcessInstanceInfoList &process_infos) {
|
|
|
|
if (IsHost())
|
|
|
|
return Platform::FindProcesses(match_info, process_infos);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->FindProcesses(match_info, process_infos);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-02-14 13:34:46 +08:00
|
|
|
lldb::ProcessSP RemoteAwarePlatform::ConnectProcess(llvm::StringRef connect_url,
|
|
|
|
llvm::StringRef plugin_name,
|
|
|
|
Debugger &debugger,
|
|
|
|
Target *target,
|
|
|
|
Status &error) {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->ConnectProcess(connect_url, plugin_name,
|
|
|
|
debugger, target, error);
|
|
|
|
return Platform::ConnectProcess(connect_url, plugin_name, debugger, target,
|
|
|
|
error);
|
|
|
|
}
|
|
|
|
|
Extract common PlatformPOSIX/Windows code into a separate class
Summary:
The two classes contained a lot of duplicated code, but there wasn't a
good place to factor it to. It couldn't be the base Platform class,
since we also have platforms which are only remote (such as
PlatformGDBRemoteServer), and so it did not make sense for those to have
an m_remote_platform member.
This patch creates a new class, RemoteAwarePlatform, which can serve as
a base class for platforms which can both serve as a host, and forward
actions to a remote system. It is motivated partly by D56232 (which was
about to add a bunch of additional duplicated methods), and partly by my
own need to modify a function which happens to be implemented in both
places identically.
The patch moves the methods which are trivially identical in the two
classes into the common base class, there were one or two more methods
which could probably be merged into one, but this wasn't completely
trivial, so I did not attempt to do that now.
Reviewers: jingham, zturner, clayborg, asmith
Subscribers: emaste, mgorny, Hui, lldb-commits
Differential Revision: https://reviews.llvm.org/D58052
llvm-svn: 353812
2019-02-12 17:27:24 +08:00
|
|
|
Status RemoteAwarePlatform::LaunchProcess(ProcessLaunchInfo &launch_info) {
|
|
|
|
Status error;
|
|
|
|
|
|
|
|
if (IsHost()) {
|
|
|
|
error = Platform::LaunchProcess(launch_info);
|
|
|
|
} else {
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
error = m_remote_platform_sp->LaunchProcess(launch_info);
|
|
|
|
else
|
|
|
|
error.SetErrorString("the platform is not currently connected");
|
|
|
|
}
|
|
|
|
return error;
|
|
|
|
}
|
2019-02-14 13:34:46 +08:00
|
|
|
|
|
|
|
Status RemoteAwarePlatform::KillProcess(const lldb::pid_t pid) {
|
|
|
|
if (IsHost())
|
|
|
|
return Platform::KillProcess(pid);
|
|
|
|
if (m_remote_platform_sp)
|
|
|
|
return m_remote_platform_sp->KillProcess(pid);
|
|
|
|
return Status("the platform is not currently connected");
|
|
|
|
}
|