2015-11-17 00:18:28 +08:00
|
|
|
//===-- WebAssemblyRegStackify.cpp - Register Stackification --------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
///
|
|
|
|
/// \file
|
2018-05-01 23:54:18 +08:00
|
|
|
/// This file implements a register stacking pass.
|
2015-11-17 00:18:28 +08:00
|
|
|
///
|
|
|
|
/// This pass reorders instructions to put register uses and defs in an order
|
|
|
|
/// such that they form single-use expression trees. Registers fitting this form
|
|
|
|
/// are then marked as "stackified", meaning references to them are replaced by
|
2016-10-04 06:43:53 +08:00
|
|
|
/// "push" and "pop" from the value stack.
|
2015-11-17 00:18:28 +08:00
|
|
|
///
|
2015-12-08 11:43:03 +08:00
|
|
|
/// This is primarily a code size optimization, since temporary values on the
|
2016-10-04 06:43:53 +08:00
|
|
|
/// value stack don't need to be named.
|
2015-11-17 00:18:28 +08:00
|
|
|
///
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2015-11-19 00:12:01 +08:00
|
|
|
#include "MCTargetDesc/WebAssemblyMCTargetDesc.h" // for WebAssembly::ARGUMENT_*
|
2017-06-06 19:49:48 +08:00
|
|
|
#include "WebAssembly.h"
|
2015-11-30 06:32:02 +08:00
|
|
|
#include "WebAssemblyMachineFunctionInfo.h"
|
2016-01-20 00:59:23 +08:00
|
|
|
#include "WebAssemblySubtarget.h"
|
2016-10-25 03:49:43 +08:00
|
|
|
#include "WebAssemblyUtilities.h"
|
2018-09-26 02:59:34 +08:00
|
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
2015-11-26 00:55:01 +08:00
|
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
2017-12-13 10:51:04 +08:00
|
|
|
#include "llvm/CodeGen/LiveIntervals.h"
|
2015-11-17 00:18:28 +08:00
|
|
|
#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
|
2016-01-28 09:22:44 +08:00
|
|
|
#include "llvm/CodeGen/MachineDominators.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
2017-02-25 07:46:05 +08:00
|
|
|
#include "llvm/CodeGen/MachineModuleInfoImpls.h"
|
2015-11-17 00:18:28 +08:00
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
|
|
#include "llvm/CodeGen/Passes.h"
|
|
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
#define DEBUG_TYPE "wasm-reg-stackify"
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class WebAssemblyRegStackify final : public MachineFunctionPass {
|
2016-10-01 10:56:57 +08:00
|
|
|
StringRef getPassName() const override {
|
2015-11-17 00:18:28 +08:00
|
|
|
return "WebAssembly Register Stackify";
|
|
|
|
}
|
|
|
|
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
|
|
AU.setPreservesCFG();
|
2015-11-26 00:55:01 +08:00
|
|
|
AU.addRequired<AAResultsWrapperPass>();
|
2016-01-28 09:22:44 +08:00
|
|
|
AU.addRequired<MachineDominatorTree>();
|
2015-12-25 08:31:02 +08:00
|
|
|
AU.addRequired<LiveIntervals>();
|
2015-11-17 00:18:28 +08:00
|
|
|
AU.addPreserved<MachineBlockFrequencyInfo>();
|
2015-12-25 08:31:02 +08:00
|
|
|
AU.addPreserved<SlotIndexes>();
|
|
|
|
AU.addPreserved<LiveIntervals>();
|
|
|
|
AU.addPreservedID(LiveVariablesID);
|
2016-01-28 09:22:44 +08:00
|
|
|
AU.addPreserved<MachineDominatorTree>();
|
2015-11-17 00:18:28 +08:00
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
|
|
|
|
public:
|
|
|
|
static char ID; // Pass identification, replacement for typeid
|
|
|
|
WebAssemblyRegStackify() : MachineFunctionPass(ID) {}
|
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
char WebAssemblyRegStackify::ID = 0;
|
2018-03-31 04:36:58 +08:00
|
|
|
INITIALIZE_PASS(WebAssemblyRegStackify, DEBUG_TYPE,
|
|
|
|
"Reorder instructions to use the WebAssembly value stack",
|
|
|
|
false, false)
|
|
|
|
|
2015-11-17 00:18:28 +08:00
|
|
|
FunctionPass *llvm::createWebAssemblyRegStackify() {
|
|
|
|
return new WebAssemblyRegStackify();
|
|
|
|
}
|
|
|
|
|
2015-11-20 10:19:12 +08:00
|
|
|
// Decorate the given instruction with implicit operands that enforce the
|
2015-12-25 08:31:02 +08:00
|
|
|
// expression stack ordering constraints for an instruction which is on
|
|
|
|
// the expression stack.
|
|
|
|
static void ImposeStackOrdering(MachineInstr *MI) {
|
2016-10-04 06:43:53 +08:00
|
|
|
// Write the opaque VALUE_STACK register.
|
|
|
|
if (!MI->definesRegister(WebAssembly::VALUE_STACK))
|
|
|
|
MI->addOperand(MachineOperand::CreateReg(WebAssembly::VALUE_STACK,
|
2015-12-05 08:51:40 +08:00
|
|
|
/*isDef=*/true,
|
|
|
|
/*isImp=*/true));
|
|
|
|
|
2016-10-04 06:43:53 +08:00
|
|
|
// Also read the opaque VALUE_STACK register.
|
|
|
|
if (!MI->readsRegister(WebAssembly::VALUE_STACK))
|
|
|
|
MI->addOperand(MachineOperand::CreateReg(WebAssembly::VALUE_STACK,
|
2015-12-15 06:37:23 +08:00
|
|
|
/*isDef=*/false,
|
|
|
|
/*isImp=*/true));
|
2015-11-20 10:19:12 +08:00
|
|
|
}
|
|
|
|
|
2016-11-09 03:40:38 +08:00
|
|
|
// Convert an IMPLICIT_DEF instruction into an instruction which defines
|
|
|
|
// a constant zero value.
|
|
|
|
static void ConvertImplicitDefToConstZero(MachineInstr *MI,
|
|
|
|
MachineRegisterInfo &MRI,
|
|
|
|
const TargetInstrInfo *TII,
|
|
|
|
MachineFunction &MF) {
|
|
|
|
assert(MI->getOpcode() == TargetOpcode::IMPLICIT_DEF);
|
|
|
|
|
2018-09-05 09:27:38 +08:00
|
|
|
const auto *RegClass = MRI.getRegClass(MI->getOperand(0).getReg());
|
2016-11-09 03:40:38 +08:00
|
|
|
if (RegClass == &WebAssembly::I32RegClass) {
|
|
|
|
MI->setDesc(TII->get(WebAssembly::CONST_I32));
|
|
|
|
MI->addOperand(MachineOperand::CreateImm(0));
|
|
|
|
} else if (RegClass == &WebAssembly::I64RegClass) {
|
|
|
|
MI->setDesc(TII->get(WebAssembly::CONST_I64));
|
|
|
|
MI->addOperand(MachineOperand::CreateImm(0));
|
|
|
|
} else if (RegClass == &WebAssembly::F32RegClass) {
|
|
|
|
MI->setDesc(TII->get(WebAssembly::CONST_F32));
|
|
|
|
ConstantFP *Val = cast<ConstantFP>(Constant::getNullValue(
|
2017-12-16 07:52:06 +08:00
|
|
|
Type::getFloatTy(MF.getFunction().getContext())));
|
2016-11-09 03:40:38 +08:00
|
|
|
MI->addOperand(MachineOperand::CreateFPImm(Val));
|
|
|
|
} else if (RegClass == &WebAssembly::F64RegClass) {
|
|
|
|
MI->setDesc(TII->get(WebAssembly::CONST_F64));
|
|
|
|
ConstantFP *Val = cast<ConstantFP>(Constant::getNullValue(
|
2017-12-16 07:52:06 +08:00
|
|
|
Type::getDoubleTy(MF.getFunction().getContext())));
|
2016-11-09 03:40:38 +08:00
|
|
|
MI->addOperand(MachineOperand::CreateFPImm(Val));
|
2018-11-01 07:50:53 +08:00
|
|
|
} else if (RegClass == &WebAssembly::V128RegClass) {
|
|
|
|
// TODO: make splat instead of constant
|
|
|
|
MI->setDesc(TII->get(WebAssembly::CONST_V128_v16i8));
|
|
|
|
for (int I = 0; I < 16; ++I)
|
|
|
|
MI->addOperand(MachineOperand::CreateImm(0));
|
2016-11-09 03:40:38 +08:00
|
|
|
} else {
|
|
|
|
llvm_unreachable("Unexpected reg class");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-17 12:05:31 +08:00
|
|
|
// Determine whether a call to the callee referenced by
|
|
|
|
// MI->getOperand(CalleeOpNo) reads memory, writes memory, and/or has side
|
|
|
|
// effects.
|
2016-07-09 03:36:40 +08:00
|
|
|
static void QueryCallee(const MachineInstr &MI, unsigned CalleeOpNo, bool &Read,
|
|
|
|
bool &Write, bool &Effects, bool &StackPointer) {
|
2016-05-18 05:14:26 +08:00
|
|
|
// All calls can use the stack pointer.
|
|
|
|
StackPointer = true;
|
|
|
|
|
2016-07-09 03:36:40 +08:00
|
|
|
const MachineOperand &MO = MI.getOperand(CalleeOpNo);
|
2016-05-17 12:05:31 +08:00
|
|
|
if (MO.isGlobal()) {
|
|
|
|
const Constant *GV = MO.getGlobal();
|
|
|
|
if (const GlobalAlias *GA = dyn_cast<GlobalAlias>(GV))
|
|
|
|
if (!GA->isInterposable())
|
|
|
|
GV = GA->getAliasee();
|
|
|
|
|
|
|
|
if (const Function *F = dyn_cast<Function>(GV)) {
|
|
|
|
if (!F->doesNotThrow())
|
|
|
|
Effects = true;
|
|
|
|
if (F->doesNotAccessMemory())
|
|
|
|
return;
|
|
|
|
if (F->onlyReadsMemory()) {
|
|
|
|
Read = true;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Assume the worst.
|
|
|
|
Write = true;
|
|
|
|
Read = true;
|
|
|
|
Effects = true;
|
|
|
|
}
|
|
|
|
|
2016-05-18 05:14:26 +08:00
|
|
|
// Determine whether MI reads memory, writes memory, has side effects,
|
2017-02-25 07:46:05 +08:00
|
|
|
// and/or uses the stack pointer value.
|
2016-07-09 03:36:40 +08:00
|
|
|
static void Query(const MachineInstr &MI, AliasAnalysis &AA, bool &Read,
|
|
|
|
bool &Write, bool &Effects, bool &StackPointer) {
|
|
|
|
assert(!MI.isTerminator());
|
2016-05-24 01:42:57 +08:00
|
|
|
|
[WebAssembly] Support instruction selection for catching exceptions
Summary:
This lowers exception catching-related instructions:
1. Lowers `wasm.catch` intrinsic to `catch` instruction
2. Removes `catchpad` and `cleanuppad` instructions; they are not
necessary after isel phase. (`MachineBasicBlock::isEHFuncletEntry()` or
`MachineBasicBlock::isEHPad()` can be used instead.)
3. Lowers `catchret` and `cleanupret` instructions to pseudo `catchret`
and `cleanupret` instructions in isel, which will be replaced with other
instructions in `WebAssemblyExceptionPrepare` pass.
4. Adds 'WebAssemblyExceptionPrepare` pass, which is for running various
transformation for EH. Currently this pass only replaces `catchret` and
`cleanupret` instructions into appropriate wasm instructions to make
this patch successfully run until the end.
Currently this does not handle lowering of intrinsics related to LSDA
info generation (`wasm.landingpad.index` and `wasm.lsda`), because they
cannot be tested without implementing `EHStreamer`'s wasm-specific
handlers. They are marked as TODO, which is needed to make isel pass.
Also this does not generate `try` and `end_try` markers yet, which will
be handled in later patches.
This patch is based on the first wasm EH proposal.
(https://github.com/WebAssembly/exception-handling/blob/master/proposals/Exceptions.md)
Reviewers: dschuff, majnemer
Subscribers: jfb, sbc100, jgravelle-google, sunfish, llvm-commits
Differential Revision: https://reviews.llvm.org/D44090
llvm-svn: 333705
2018-06-01 06:25:54 +08:00
|
|
|
if (MI.isDebugInstr() || MI.isPosition())
|
2016-05-24 01:42:57 +08:00
|
|
|
return;
|
2016-05-17 12:05:31 +08:00
|
|
|
|
|
|
|
// Check for loads.
|
2016-09-10 09:03:20 +08:00
|
|
|
if (MI.mayLoad() && !MI.isDereferenceableInvariantLoad(&AA))
|
2016-05-17 12:05:31 +08:00
|
|
|
Read = true;
|
|
|
|
|
|
|
|
// Check for stores.
|
2016-07-09 03:36:40 +08:00
|
|
|
if (MI.mayStore()) {
|
2016-05-17 12:05:31 +08:00
|
|
|
Write = true;
|
2016-05-18 05:14:26 +08:00
|
|
|
|
2017-06-17 07:59:10 +08:00
|
|
|
// Check for stores to __stack_pointer.
|
|
|
|
for (auto MMO : MI.memoperands()) {
|
|
|
|
const MachinePointerInfo &MPI = MMO->getPointerInfo();
|
|
|
|
if (MPI.V.is<const PseudoSourceValue *>()) {
|
|
|
|
auto PSV = MPI.V.get<const PseudoSourceValue *>();
|
|
|
|
if (const ExternalSymbolPseudoSourceValue *EPSV =
|
|
|
|
dyn_cast<ExternalSymbolPseudoSourceValue>(PSV))
|
|
|
|
if (StringRef(EPSV->getSymbol()) == "__stack_pointer") {
|
|
|
|
StackPointer = true;
|
|
|
|
}
|
2016-05-18 05:14:26 +08:00
|
|
|
}
|
|
|
|
}
|
2016-07-09 03:36:40 +08:00
|
|
|
} else if (MI.hasOrderedMemoryRef()) {
|
|
|
|
switch (MI.getOpcode()) {
|
2018-09-05 09:27:38 +08:00
|
|
|
case WebAssembly::DIV_S_I32:
|
|
|
|
case WebAssembly::DIV_S_I64:
|
|
|
|
case WebAssembly::REM_S_I32:
|
|
|
|
case WebAssembly::REM_S_I64:
|
|
|
|
case WebAssembly::DIV_U_I32:
|
|
|
|
case WebAssembly::DIV_U_I64:
|
|
|
|
case WebAssembly::REM_U_I32:
|
|
|
|
case WebAssembly::REM_U_I64:
|
|
|
|
case WebAssembly::I32_TRUNC_S_F32:
|
|
|
|
case WebAssembly::I64_TRUNC_S_F32:
|
|
|
|
case WebAssembly::I32_TRUNC_S_F64:
|
|
|
|
case WebAssembly::I64_TRUNC_S_F64:
|
|
|
|
case WebAssembly::I32_TRUNC_U_F32:
|
|
|
|
case WebAssembly::I64_TRUNC_U_F32:
|
|
|
|
case WebAssembly::I32_TRUNC_U_F64:
|
|
|
|
case WebAssembly::I64_TRUNC_U_F64:
|
2016-05-17 12:05:31 +08:00
|
|
|
// These instruction have hasUnmodeledSideEffects() returning true
|
|
|
|
// because they trap on overflow and invalid so they can't be arbitrarily
|
|
|
|
// moved, however hasOrderedMemoryRef() interprets this plus their lack
|
|
|
|
// of memoperands as having a potential unknown memory reference.
|
|
|
|
break;
|
|
|
|
default:
|
2016-05-18 06:24:18 +08:00
|
|
|
// Record volatile accesses, unless it's a call, as calls are handled
|
2016-05-17 12:05:31 +08:00
|
|
|
// specially below.
|
2016-07-09 03:36:40 +08:00
|
|
|
if (!MI.isCall()) {
|
2016-05-17 12:05:31 +08:00
|
|
|
Write = true;
|
2016-05-18 06:24:18 +08:00
|
|
|
Effects = true;
|
|
|
|
}
|
2016-05-17 12:05:31 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check for side effects.
|
2016-07-09 03:36:40 +08:00
|
|
|
if (MI.hasUnmodeledSideEffects()) {
|
|
|
|
switch (MI.getOpcode()) {
|
2018-09-05 09:27:38 +08:00
|
|
|
case WebAssembly::DIV_S_I32:
|
|
|
|
case WebAssembly::DIV_S_I64:
|
|
|
|
case WebAssembly::REM_S_I32:
|
|
|
|
case WebAssembly::REM_S_I64:
|
|
|
|
case WebAssembly::DIV_U_I32:
|
|
|
|
case WebAssembly::DIV_U_I64:
|
|
|
|
case WebAssembly::REM_U_I32:
|
|
|
|
case WebAssembly::REM_U_I64:
|
|
|
|
case WebAssembly::I32_TRUNC_S_F32:
|
|
|
|
case WebAssembly::I64_TRUNC_S_F32:
|
|
|
|
case WebAssembly::I32_TRUNC_S_F64:
|
|
|
|
case WebAssembly::I64_TRUNC_S_F64:
|
|
|
|
case WebAssembly::I32_TRUNC_U_F32:
|
|
|
|
case WebAssembly::I64_TRUNC_U_F32:
|
|
|
|
case WebAssembly::I32_TRUNC_U_F64:
|
|
|
|
case WebAssembly::I64_TRUNC_U_F64:
|
2016-05-17 12:05:31 +08:00
|
|
|
// These instructions have hasUnmodeledSideEffects() returning true
|
|
|
|
// because they trap on overflow and invalid so they can't be arbitrarily
|
|
|
|
// moved, however in the specific case of register stackifying, it is safe
|
|
|
|
// to move them because overflow and invalid are Undefined Behavior.
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
Effects = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Analyze calls.
|
2016-07-09 03:36:40 +08:00
|
|
|
if (MI.isCall()) {
|
2018-08-29 01:49:39 +08:00
|
|
|
unsigned CalleeOpNo = WebAssembly::getCalleeOpNo(MI);
|
|
|
|
QueryCallee(MI, CalleeOpNo, Read, Write, Effects, StackPointer);
|
2016-05-17 12:05:31 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test whether Def is safe and profitable to rematerialize.
|
2016-06-30 08:01:54 +08:00
|
|
|
static bool ShouldRematerialize(const MachineInstr &Def, AliasAnalysis &AA,
|
2016-05-17 12:05:31 +08:00
|
|
|
const WebAssemblyInstrInfo *TII) {
|
2016-06-30 08:01:54 +08:00
|
|
|
return Def.isAsCheapAsAMove() && TII->isTriviallyReMaterializable(Def, &AA);
|
2016-05-17 12:05:31 +08:00
|
|
|
}
|
|
|
|
|
2016-05-18 04:19:47 +08:00
|
|
|
// Identify the definition for this register at this point. This is a
|
|
|
|
// generalization of MachineRegisterInfo::getUniqueVRegDef that uses
|
|
|
|
// LiveIntervals to handle complex cases.
|
2016-05-17 12:05:31 +08:00
|
|
|
static MachineInstr *GetVRegDef(unsigned Reg, const MachineInstr *Insert,
|
|
|
|
const MachineRegisterInfo &MRI,
|
2018-09-05 09:27:38 +08:00
|
|
|
const LiveIntervals &LIS) {
|
2016-05-17 12:05:31 +08:00
|
|
|
// Most registers are in SSA form here so we try a quick MRI query first.
|
|
|
|
if (MachineInstr *Def = MRI.getUniqueVRegDef(Reg))
|
|
|
|
return Def;
|
|
|
|
|
|
|
|
// MRI doesn't know what the Def is. Try asking LIS.
|
|
|
|
if (const VNInfo *ValNo = LIS.getInterval(Reg).getVNInfoBefore(
|
|
|
|
LIS.getInstructionIndex(*Insert)))
|
|
|
|
return LIS.getInstructionFromIndex(ValNo->def);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2016-05-18 04:19:47 +08:00
|
|
|
// Test whether Reg, as defined at Def, has exactly one use. This is a
|
|
|
|
// generalization of MachineRegisterInfo::hasOneUse that uses LiveIntervals
|
|
|
|
// to handle complex cases.
|
2018-09-05 09:27:38 +08:00
|
|
|
static bool HasOneUse(unsigned Reg, MachineInstr *Def, MachineRegisterInfo &MRI,
|
|
|
|
MachineDominatorTree &MDT, LiveIntervals &LIS) {
|
2016-05-18 04:19:47 +08:00
|
|
|
// Most registers are in SSA form here so we try a quick MRI query first.
|
|
|
|
if (MRI.hasOneUse(Reg))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
bool HasOne = false;
|
|
|
|
const LiveInterval &LI = LIS.getInterval(Reg);
|
2018-09-05 09:27:38 +08:00
|
|
|
const VNInfo *DefVNI =
|
|
|
|
LI.getVNInfoAt(LIS.getInstructionIndex(*Def).getRegSlot());
|
2016-05-18 04:19:47 +08:00
|
|
|
assert(DefVNI);
|
[WebAssembly] Handle debug information and virtual registers without crashing (reland r278967)
Summary: Currently, enabling debug information when compiling for WebAssembly crashes the backend. This commit fixes these by skipping debug values in backend passes.
Reviewers: jfb, aprantl, dschuff, echristo
Subscribers: llvm-commits, dschuff, jfb, MatzeB, dexonsmith, yurydelendik, mehdi_amini
Differential Revision: https://reviews.llvm.org/D23635
llvm-svn: 279011
2016-08-18 07:42:27 +08:00
|
|
|
for (auto &I : MRI.use_nodbg_operands(Reg)) {
|
2016-05-18 04:19:47 +08:00
|
|
|
const auto &Result = LI.Query(LIS.getInstructionIndex(*I.getParent()));
|
|
|
|
if (Result.valueIn() == DefVNI) {
|
|
|
|
if (!Result.isKill())
|
|
|
|
return false;
|
|
|
|
if (HasOne)
|
|
|
|
return false;
|
|
|
|
HasOne = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return HasOne;
|
|
|
|
}
|
|
|
|
|
2015-12-25 08:31:02 +08:00
|
|
|
// Test whether it's safe to move Def to just before Insert.
|
2015-11-26 00:55:01 +08:00
|
|
|
// TODO: Compute memory dependencies in a way that doesn't require always
|
|
|
|
// walking the block.
|
|
|
|
// TODO: Compute memory dependencies in a way that uses AliasAnalysis to be
|
|
|
|
// more precise.
|
|
|
|
static bool IsSafeToMove(const MachineInstr *Def, const MachineInstr *Insert,
|
2016-10-01 02:02:54 +08:00
|
|
|
AliasAnalysis &AA, const MachineRegisterInfo &MRI) {
|
2015-12-04 07:07:03 +08:00
|
|
|
assert(Def->getParent() == Insert->getParent());
|
2015-12-25 08:31:02 +08:00
|
|
|
|
|
|
|
// Check for register dependencies.
|
2016-10-01 02:02:54 +08:00
|
|
|
SmallVector<unsigned, 4> MutableRegisters;
|
2015-12-25 08:31:02 +08:00
|
|
|
for (const MachineOperand &MO : Def->operands()) {
|
|
|
|
if (!MO.isReg() || MO.isUndef())
|
|
|
|
continue;
|
|
|
|
unsigned Reg = MO.getReg();
|
|
|
|
|
|
|
|
// If the register is dead here and at Insert, ignore it.
|
|
|
|
if (MO.isDead() && Insert->definesRegister(Reg) &&
|
|
|
|
!Insert->readsRegister(Reg))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
|
2016-05-10 12:24:02 +08:00
|
|
|
// Ignore ARGUMENTS; it's just used to keep the ARGUMENT_* instructions
|
|
|
|
// from moving down, and we've already checked for that.
|
|
|
|
if (Reg == WebAssembly::ARGUMENTS)
|
|
|
|
continue;
|
2015-12-25 08:31:02 +08:00
|
|
|
// If the physical register is never modified, ignore it.
|
|
|
|
if (!MRI.isPhysRegModified(Reg))
|
|
|
|
continue;
|
|
|
|
// Otherwise, it's a physical register with unknown liveness.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-10-01 02:02:54 +08:00
|
|
|
// If one of the operands isn't in SSA form, it has different values at
|
|
|
|
// different times, and we need to make sure we don't move our use across
|
|
|
|
// a different def.
|
|
|
|
if (!MO.isDef() && !MRI.hasOneDef(Reg))
|
|
|
|
MutableRegisters.push_back(Reg);
|
2015-12-25 08:31:02 +08:00
|
|
|
}
|
|
|
|
|
2016-05-18 05:14:26 +08:00
|
|
|
bool Read = false, Write = false, Effects = false, StackPointer = false;
|
2016-07-09 03:36:40 +08:00
|
|
|
Query(*Def, AA, Read, Write, Effects, StackPointer);
|
2016-05-17 12:05:31 +08:00
|
|
|
|
|
|
|
// If the instruction does not access memory and has no side effects, it has
|
|
|
|
// no additional dependencies.
|
2016-10-01 02:02:54 +08:00
|
|
|
bool HasMutableRegisters = !MutableRegisters.empty();
|
|
|
|
if (!Read && !Write && !Effects && !StackPointer && !HasMutableRegisters)
|
2016-05-17 12:05:31 +08:00
|
|
|
return true;
|
|
|
|
|
|
|
|
// Scan through the intervening instructions between Def and Insert.
|
|
|
|
MachineBasicBlock::const_iterator D(Def), I(Insert);
|
|
|
|
for (--I; I != D; --I) {
|
|
|
|
bool InterveningRead = false;
|
|
|
|
bool InterveningWrite = false;
|
|
|
|
bool InterveningEffects = false;
|
2016-05-18 05:14:26 +08:00
|
|
|
bool InterveningStackPointer = false;
|
2016-07-09 03:36:40 +08:00
|
|
|
Query(*I, AA, InterveningRead, InterveningWrite, InterveningEffects,
|
2016-05-18 05:14:26 +08:00
|
|
|
InterveningStackPointer);
|
2016-05-17 12:05:31 +08:00
|
|
|
if (Effects && InterveningEffects)
|
|
|
|
return false;
|
|
|
|
if (Read && InterveningWrite)
|
|
|
|
return false;
|
|
|
|
if (Write && (InterveningRead || InterveningWrite))
|
|
|
|
return false;
|
2016-05-18 05:14:26 +08:00
|
|
|
if (StackPointer && InterveningStackPointer)
|
|
|
|
return false;
|
2016-10-01 02:02:54 +08:00
|
|
|
|
|
|
|
for (unsigned Reg : MutableRegisters)
|
|
|
|
for (const MachineOperand &MO : I->operands())
|
|
|
|
if (MO.isReg() && MO.isDef() && MO.getReg() == Reg)
|
|
|
|
return false;
|
2016-05-17 12:05:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
2015-11-26 00:55:01 +08:00
|
|
|
}
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
/// Test whether OneUse, a use of Reg, dominates all of Reg's other uses.
|
|
|
|
static bool OneUseDominatesOtherUses(unsigned Reg, const MachineOperand &OneUse,
|
|
|
|
const MachineBasicBlock &MBB,
|
|
|
|
const MachineRegisterInfo &MRI,
|
2016-05-10 12:24:02 +08:00
|
|
|
const MachineDominatorTree &MDT,
|
2016-05-18 06:24:18 +08:00
|
|
|
LiveIntervals &LIS,
|
|
|
|
WebAssemblyFunctionInfo &MFI) {
|
2016-05-10 12:24:02 +08:00
|
|
|
const LiveInterval &LI = LIS.getInterval(Reg);
|
|
|
|
|
|
|
|
const MachineInstr *OneUseInst = OneUse.getParent();
|
|
|
|
VNInfo *OneUseVNI = LI.getVNInfoBefore(LIS.getInstructionIndex(*OneUseInst));
|
|
|
|
|
[WebAssembly] Handle debug information and virtual registers without crashing (reland r278967)
Summary: Currently, enabling debug information when compiling for WebAssembly crashes the backend. This commit fixes these by skipping debug values in backend passes.
Reviewers: jfb, aprantl, dschuff, echristo
Subscribers: llvm-commits, dschuff, jfb, MatzeB, dexonsmith, yurydelendik, mehdi_amini
Differential Revision: https://reviews.llvm.org/D23635
llvm-svn: 279011
2016-08-18 07:42:27 +08:00
|
|
|
for (const MachineOperand &Use : MRI.use_nodbg_operands(Reg)) {
|
2016-01-28 09:22:44 +08:00
|
|
|
if (&Use == &OneUse)
|
|
|
|
continue;
|
2016-05-10 12:24:02 +08:00
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
const MachineInstr *UseInst = Use.getParent();
|
2016-05-10 12:24:02 +08:00
|
|
|
VNInfo *UseVNI = LI.getVNInfoBefore(LIS.getInstructionIndex(*UseInst));
|
|
|
|
|
|
|
|
if (UseVNI != OneUseVNI)
|
|
|
|
continue;
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
const MachineInstr *OneUseInst = OneUse.getParent();
|
2016-05-18 04:19:47 +08:00
|
|
|
if (UseInst == OneUseInst) {
|
2016-01-28 09:22:44 +08:00
|
|
|
// Another use in the same instruction. We need to ensure that the one
|
|
|
|
// selected use happens "before" it.
|
|
|
|
if (&OneUse > &Use)
|
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
// Test that the use is dominated by the one selected use.
|
2016-05-18 06:24:18 +08:00
|
|
|
while (!MDT.dominates(OneUseInst, UseInst)) {
|
|
|
|
// Actually, dominating is over-conservative. Test that the use would
|
|
|
|
// happen after the one selected use in the stack evaluation order.
|
|
|
|
//
|
|
|
|
// This is needed as a consequence of using implicit get_locals for
|
|
|
|
// uses and implicit set_locals for defs.
|
2016-08-11 12:10:56 +08:00
|
|
|
if (UseInst->getDesc().getNumDefs() == 0)
|
2016-05-18 06:24:18 +08:00
|
|
|
return false;
|
|
|
|
const MachineOperand &MO = UseInst->getOperand(0);
|
|
|
|
if (!MO.isReg())
|
|
|
|
return false;
|
|
|
|
unsigned DefReg = MO.getReg();
|
|
|
|
if (!TargetRegisterInfo::isVirtualRegister(DefReg) ||
|
|
|
|
!MFI.isVRegStackified(DefReg))
|
|
|
|
return false;
|
2018-09-27 07:49:21 +08:00
|
|
|
assert(MRI.hasOneNonDBGUse(DefReg));
|
|
|
|
const MachineOperand &NewUse = *MRI.use_nodbg_begin(DefReg);
|
2016-05-18 06:24:18 +08:00
|
|
|
const MachineInstr *NewUseInst = NewUse.getParent();
|
|
|
|
if (NewUseInst == OneUseInst) {
|
|
|
|
if (&OneUse > &NewUse)
|
|
|
|
return false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
UseInst = NewUseInst;
|
|
|
|
}
|
2016-01-28 09:22:44 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2016-10-25 03:49:43 +08:00
|
|
|
/// Get the appropriate tee opcode for the given register class.
|
|
|
|
static unsigned GetTeeOpcode(const TargetRegisterClass *RC) {
|
2016-01-28 09:22:44 +08:00
|
|
|
if (RC == &WebAssembly::I32RegClass)
|
2016-10-25 03:49:43 +08:00
|
|
|
return WebAssembly::TEE_I32;
|
2016-01-28 09:22:44 +08:00
|
|
|
if (RC == &WebAssembly::I64RegClass)
|
2016-10-25 03:49:43 +08:00
|
|
|
return WebAssembly::TEE_I64;
|
2016-01-28 09:22:44 +08:00
|
|
|
if (RC == &WebAssembly::F32RegClass)
|
2016-10-25 03:49:43 +08:00
|
|
|
return WebAssembly::TEE_F32;
|
2016-01-28 09:22:44 +08:00
|
|
|
if (RC == &WebAssembly::F64RegClass)
|
2016-10-25 03:49:43 +08:00
|
|
|
return WebAssembly::TEE_F64;
|
2016-08-03 07:16:09 +08:00
|
|
|
if (RC == &WebAssembly::V128RegClass)
|
2016-10-25 03:49:43 +08:00
|
|
|
return WebAssembly::TEE_V128;
|
2016-01-28 09:22:44 +08:00
|
|
|
llvm_unreachable("Unexpected register class");
|
|
|
|
}
|
|
|
|
|
2016-05-17 12:05:31 +08:00
|
|
|
// Shrink LI to its uses, cleaning up LI.
|
|
|
|
static void ShrinkToUses(LiveInterval &LI, LiveIntervals &LIS) {
|
|
|
|
if (LIS.shrinkToUses(&LI)) {
|
2018-09-05 09:27:38 +08:00
|
|
|
SmallVector<LiveInterval *, 4> SplitLIs;
|
2016-05-17 12:05:31 +08:00
|
|
|
LIS.splitSeparateComponents(LI, SplitLIs);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-09-26 02:59:34 +08:00
|
|
|
static void MoveDebugValues(unsigned Reg, MachineInstr *Insert,
|
|
|
|
MachineBasicBlock &MBB, MachineRegisterInfo &MRI) {
|
|
|
|
for (auto &Op : MRI.reg_operands(Reg)) {
|
|
|
|
MachineInstr *MI = Op.getParent();
|
|
|
|
assert(MI != nullptr);
|
|
|
|
if (MI->isDebugValue() && MI->getParent() == &MBB)
|
|
|
|
MBB.splice(Insert, &MBB, MI);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void UpdateDebugValuesReg(unsigned Reg, unsigned NewReg,
|
|
|
|
MachineBasicBlock &MBB,
|
|
|
|
MachineRegisterInfo &MRI) {
|
|
|
|
for (auto &Op : MRI.reg_operands(Reg)) {
|
|
|
|
MachineInstr *MI = Op.getParent();
|
|
|
|
assert(MI != nullptr);
|
|
|
|
if (MI->isDebugValue() && MI->getParent() == &MBB)
|
|
|
|
Op.setReg(NewReg);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
/// A single-use def in the same block with no intervening memory or register
|
|
|
|
/// dependencies; move the def down and nest it with the current instruction.
|
2018-09-05 09:27:38 +08:00
|
|
|
static MachineInstr *MoveForSingleUse(unsigned Reg, MachineOperand &Op,
|
|
|
|
MachineInstr *Def, MachineBasicBlock &MBB,
|
2016-01-28 09:22:44 +08:00
|
|
|
MachineInstr *Insert, LiveIntervals &LIS,
|
2016-05-10 12:24:02 +08:00
|
|
|
WebAssemblyFunctionInfo &MFI,
|
|
|
|
MachineRegisterInfo &MRI) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Move for single use: "; Def->dump());
|
2016-05-17 12:05:31 +08:00
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
MBB.splice(Insert, &MBB, Def);
|
2018-09-26 02:59:34 +08:00
|
|
|
MoveDebugValues(Reg, Insert, MBB, MRI);
|
2016-02-28 23:33:53 +08:00
|
|
|
LIS.handleMove(*Def);
|
2016-05-10 12:24:02 +08:00
|
|
|
|
2016-05-18 04:19:47 +08:00
|
|
|
if (MRI.hasOneDef(Reg) && MRI.hasOneUse(Reg)) {
|
|
|
|
// No one else is using this register for anything so we can just stackify
|
|
|
|
// it in place.
|
2016-05-10 12:24:02 +08:00
|
|
|
MFI.stackifyVReg(Reg);
|
|
|
|
} else {
|
2016-05-18 04:19:47 +08:00
|
|
|
// The register may have unrelated uses or defs; create a new register for
|
|
|
|
// just our one def and use so that we can stackify it.
|
2016-05-10 12:24:02 +08:00
|
|
|
unsigned NewReg = MRI.createVirtualRegister(MRI.getRegClass(Reg));
|
|
|
|
Def->getOperand(0).setReg(NewReg);
|
|
|
|
Op.setReg(NewReg);
|
|
|
|
|
|
|
|
// Tell LiveIntervals about the new register.
|
|
|
|
LIS.createAndComputeVirtRegInterval(NewReg);
|
|
|
|
|
|
|
|
// Tell LiveIntervals about the changes to the old register.
|
|
|
|
LiveInterval &LI = LIS.getInterval(Reg);
|
2016-05-24 01:42:57 +08:00
|
|
|
LI.removeSegment(LIS.getInstructionIndex(*Def).getRegSlot(),
|
|
|
|
LIS.getInstructionIndex(*Op.getParent()).getRegSlot(),
|
|
|
|
/*RemoveDeadValNo=*/true);
|
2016-05-10 12:24:02 +08:00
|
|
|
|
|
|
|
MFI.stackifyVReg(NewReg);
|
2016-05-17 12:05:31 +08:00
|
|
|
|
2018-09-26 02:59:34 +08:00
|
|
|
UpdateDebugValuesReg(Reg, NewReg, MBB, MRI);
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " - Replaced register: "; Def->dump());
|
2016-05-10 12:24:02 +08:00
|
|
|
}
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
ImposeStackOrdering(Def);
|
|
|
|
return Def;
|
|
|
|
}
|
|
|
|
|
2018-09-26 02:59:34 +08:00
|
|
|
static void CloneDebugValues(unsigned Reg, MachineInstr *Insert,
|
|
|
|
unsigned TargetReg, MachineBasicBlock &MBB,
|
|
|
|
MachineRegisterInfo &MRI,
|
|
|
|
const WebAssemblyInstrInfo *TII) {
|
|
|
|
SmallPtrSet<MachineInstr *, 4> Instrs;
|
|
|
|
for (auto &Op : MRI.reg_operands(Reg)) {
|
|
|
|
MachineInstr *MI = Op.getParent();
|
|
|
|
assert(MI != nullptr);
|
|
|
|
if (MI->isDebugValue() && MI->getParent() == &MBB &&
|
|
|
|
Instrs.find(MI) == Instrs.end())
|
|
|
|
Instrs.insert(MI);
|
|
|
|
}
|
|
|
|
for (const auto &MI : Instrs) {
|
|
|
|
MachineInstr &Clone = TII->duplicate(MBB, Insert, *MI);
|
|
|
|
for (unsigned i = 0, e = Clone.getNumOperands(); i != e; ++i) {
|
|
|
|
MachineOperand &MO = Clone.getOperand(i);
|
|
|
|
if (MO.isReg() && MO.getReg() == Reg)
|
|
|
|
MO.setReg(TargetReg);
|
|
|
|
}
|
|
|
|
LLVM_DEBUG(dbgs() << " - - Cloned DBG_VALUE: "; Clone.dump());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
/// A trivially cloneable instruction; clone it and nest the new copy with the
|
|
|
|
/// current instruction.
|
2016-06-30 08:01:54 +08:00
|
|
|
static MachineInstr *RematerializeCheapDef(
|
|
|
|
unsigned Reg, MachineOperand &Op, MachineInstr &Def, MachineBasicBlock &MBB,
|
|
|
|
MachineBasicBlock::instr_iterator Insert, LiveIntervals &LIS,
|
|
|
|
WebAssemblyFunctionInfo &MFI, MachineRegisterInfo &MRI,
|
|
|
|
const WebAssemblyInstrInfo *TII, const WebAssemblyRegisterInfo *TRI) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Rematerializing cheap def: "; Def.dump());
|
|
|
|
LLVM_DEBUG(dbgs() << " - for use in "; Op.getParent()->dump());
|
2016-05-17 12:05:31 +08:00
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
unsigned NewReg = MRI.createVirtualRegister(MRI.getRegClass(Reg));
|
|
|
|
TII->reMaterialize(MBB, Insert, NewReg, 0, Def, *TRI);
|
|
|
|
Op.setReg(NewReg);
|
2016-06-30 08:01:54 +08:00
|
|
|
MachineInstr *Clone = &*std::prev(Insert);
|
2016-02-28 00:38:23 +08:00
|
|
|
LIS.InsertMachineInstrInMaps(*Clone);
|
2016-01-28 09:22:44 +08:00
|
|
|
LIS.createAndComputeVirtRegInterval(NewReg);
|
|
|
|
MFI.stackifyVReg(NewReg);
|
|
|
|
ImposeStackOrdering(Clone);
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " - Cloned to "; Clone->dump());
|
2016-05-17 12:05:31 +08:00
|
|
|
|
2016-05-10 12:24:02 +08:00
|
|
|
// Shrink the interval.
|
|
|
|
bool IsDead = MRI.use_empty(Reg);
|
|
|
|
if (!IsDead) {
|
|
|
|
LiveInterval &LI = LIS.getInterval(Reg);
|
2016-05-17 12:05:31 +08:00
|
|
|
ShrinkToUses(LI, LIS);
|
2016-06-30 08:01:54 +08:00
|
|
|
IsDead = !LI.liveAt(LIS.getInstructionIndex(Def).getDeadSlot());
|
2016-05-10 12:24:02 +08:00
|
|
|
}
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
// If that was the last use of the original, delete the original.
|
2018-09-26 02:59:34 +08:00
|
|
|
// Move or clone corresponding DBG_VALUEs to the 'Insert' location.
|
2016-05-10 12:24:02 +08:00
|
|
|
if (IsDead) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " - Deleting original\n");
|
2016-06-30 08:01:54 +08:00
|
|
|
SlotIndex Idx = LIS.getInstructionIndex(Def).getRegSlot();
|
2016-01-28 09:22:44 +08:00
|
|
|
LIS.removePhysRegDefAt(WebAssembly::ARGUMENTS, Idx);
|
|
|
|
LIS.removeInterval(Reg);
|
2016-06-30 08:01:54 +08:00
|
|
|
LIS.RemoveMachineInstrFromMaps(Def);
|
|
|
|
Def.eraseFromParent();
|
2018-09-26 02:59:34 +08:00
|
|
|
|
|
|
|
MoveDebugValues(Reg, &*Insert, MBB, MRI);
|
|
|
|
UpdateDebugValuesReg(Reg, NewReg, MBB, MRI);
|
|
|
|
} else {
|
|
|
|
CloneDebugValues(Reg, &*Insert, NewReg, MBB, MRI, TII);
|
2016-01-28 09:22:44 +08:00
|
|
|
}
|
2016-05-10 12:24:02 +08:00
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
return Clone;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// A multiple-use def in the same block with no intervening memory or register
|
|
|
|
/// dependencies; move the def down, nest it with the current instruction, and
|
2016-10-25 03:49:43 +08:00
|
|
|
/// insert a tee to satisfy the rest of the uses. As an illustration, rewrite
|
|
|
|
/// this:
|
2016-01-28 09:22:44 +08:00
|
|
|
///
|
|
|
|
/// Reg = INST ... // Def
|
|
|
|
/// INST ..., Reg, ... // Insert
|
|
|
|
/// INST ..., Reg, ...
|
|
|
|
/// INST ..., Reg, ...
|
|
|
|
///
|
|
|
|
/// to this:
|
|
|
|
///
|
2016-02-16 23:17:21 +08:00
|
|
|
/// DefReg = INST ... // Def (to become the new Insert)
|
2016-10-25 03:49:43 +08:00
|
|
|
/// TeeReg, Reg = TEE_... DefReg
|
2016-01-28 09:22:44 +08:00
|
|
|
/// INST ..., TeeReg, ... // Insert
|
2016-05-24 01:42:57 +08:00
|
|
|
/// INST ..., Reg, ...
|
|
|
|
/// INST ..., Reg, ...
|
2016-01-28 09:22:44 +08:00
|
|
|
///
|
2016-02-16 23:17:21 +08:00
|
|
|
/// with DefReg and TeeReg stackified. This eliminates a get_local from the
|
2016-01-28 09:22:44 +08:00
|
|
|
/// resulting code.
|
|
|
|
static MachineInstr *MoveAndTeeForMultiUse(
|
|
|
|
unsigned Reg, MachineOperand &Op, MachineInstr *Def, MachineBasicBlock &MBB,
|
|
|
|
MachineInstr *Insert, LiveIntervals &LIS, WebAssemblyFunctionInfo &MFI,
|
|
|
|
MachineRegisterInfo &MRI, const WebAssemblyInstrInfo *TII) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Move and tee for multi-use:"; Def->dump());
|
2016-05-17 12:05:31 +08:00
|
|
|
|
2016-05-18 04:19:47 +08:00
|
|
|
// Move Def into place.
|
2016-01-28 09:22:44 +08:00
|
|
|
MBB.splice(Insert, &MBB, Def);
|
2016-02-28 23:33:53 +08:00
|
|
|
LIS.handleMove(*Def);
|
2016-05-18 04:19:47 +08:00
|
|
|
|
|
|
|
// Create the Tee and attach the registers.
|
2016-01-28 09:22:44 +08:00
|
|
|
const auto *RegClass = MRI.getRegClass(Reg);
|
|
|
|
unsigned TeeReg = MRI.createVirtualRegister(RegClass);
|
2016-02-16 23:17:21 +08:00
|
|
|
unsigned DefReg = MRI.createVirtualRegister(RegClass);
|
2016-05-12 12:19:09 +08:00
|
|
|
MachineOperand &DefMO = Def->getOperand(0);
|
2016-01-28 09:22:44 +08:00
|
|
|
MachineInstr *Tee = BuildMI(MBB, Insert, Insert->getDebugLoc(),
|
2016-10-25 03:49:43 +08:00
|
|
|
TII->get(GetTeeOpcode(RegClass)), TeeReg)
|
2016-05-18 04:19:47 +08:00
|
|
|
.addReg(Reg, RegState::Define)
|
2016-05-12 12:19:09 +08:00
|
|
|
.addReg(DefReg, getUndefRegState(DefMO.isDead()));
|
2016-01-28 09:22:44 +08:00
|
|
|
Op.setReg(TeeReg);
|
2016-05-12 12:19:09 +08:00
|
|
|
DefMO.setReg(DefReg);
|
2016-05-18 04:19:47 +08:00
|
|
|
SlotIndex TeeIdx = LIS.InsertMachineInstrInMaps(*Tee).getRegSlot();
|
|
|
|
SlotIndex DefIdx = LIS.getInstructionIndex(*Def).getRegSlot();
|
|
|
|
|
2018-09-26 02:59:34 +08:00
|
|
|
MoveDebugValues(Reg, Insert, MBB, MRI);
|
|
|
|
|
2016-05-18 04:19:47 +08:00
|
|
|
// Tell LiveIntervals we moved the original vreg def from Def to Tee.
|
|
|
|
LiveInterval &LI = LIS.getInterval(Reg);
|
|
|
|
LiveInterval::iterator I = LI.FindSegmentContaining(DefIdx);
|
|
|
|
VNInfo *ValNo = LI.getVNInfoAt(DefIdx);
|
|
|
|
I->start = TeeIdx;
|
|
|
|
ValNo->def = TeeIdx;
|
|
|
|
ShrinkToUses(LI, LIS);
|
|
|
|
|
|
|
|
// Finish stackifying the new regs.
|
2016-01-28 09:22:44 +08:00
|
|
|
LIS.createAndComputeVirtRegInterval(TeeReg);
|
2016-02-16 23:17:21 +08:00
|
|
|
LIS.createAndComputeVirtRegInterval(DefReg);
|
|
|
|
MFI.stackifyVReg(DefReg);
|
2016-01-28 09:22:44 +08:00
|
|
|
MFI.stackifyVReg(TeeReg);
|
|
|
|
ImposeStackOrdering(Def);
|
|
|
|
ImposeStackOrdering(Tee);
|
2016-05-18 04:19:47 +08:00
|
|
|
|
2018-09-26 02:59:34 +08:00
|
|
|
CloneDebugValues(Reg, Tee, DefReg, MBB, MRI, TII);
|
|
|
|
CloneDebugValues(Reg, Insert, TeeReg, MBB, MRI, TII);
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " - Replaced register: "; Def->dump());
|
|
|
|
LLVM_DEBUG(dbgs() << " - Tee instruction: "; Tee->dump());
|
2016-01-28 09:22:44 +08:00
|
|
|
return Def;
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
/// A stack for walking the tree of instructions being built, visiting the
|
|
|
|
/// MachineOperands in DFS order.
|
|
|
|
class TreeWalkerState {
|
|
|
|
typedef MachineInstr::mop_iterator mop_iterator;
|
|
|
|
typedef std::reverse_iterator<mop_iterator> mop_reverse_iterator;
|
|
|
|
typedef iterator_range<mop_reverse_iterator> RangeTy;
|
|
|
|
SmallVector<RangeTy, 4> Worklist;
|
|
|
|
|
|
|
|
public:
|
|
|
|
explicit TreeWalkerState(MachineInstr *Insert) {
|
|
|
|
const iterator_range<mop_iterator> &Range = Insert->explicit_uses();
|
|
|
|
if (Range.begin() != Range.end())
|
|
|
|
Worklist.push_back(reverse(Range));
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Done() const { return Worklist.empty(); }
|
|
|
|
|
|
|
|
MachineOperand &Pop() {
|
|
|
|
RangeTy &Range = Worklist.back();
|
|
|
|
MachineOperand &Op = *Range.begin();
|
|
|
|
Range = drop_begin(Range, 1);
|
|
|
|
if (Range.begin() == Range.end())
|
|
|
|
Worklist.pop_back();
|
|
|
|
assert((Worklist.empty() ||
|
|
|
|
Worklist.back().begin() != Worklist.back().end()) &&
|
|
|
|
"Empty ranges shouldn't remain in the worklist");
|
|
|
|
return Op;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Push Instr's operands onto the stack to be visited.
|
|
|
|
void PushOperands(MachineInstr *Instr) {
|
|
|
|
const iterator_range<mop_iterator> &Range(Instr->explicit_uses());
|
|
|
|
if (Range.begin() != Range.end())
|
|
|
|
Worklist.push_back(reverse(Range));
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Some of Instr's operands are on the top of the stack; remove them and
|
|
|
|
/// re-insert them starting from the beginning (because we've commuted them).
|
|
|
|
void ResetTopOperands(MachineInstr *Instr) {
|
|
|
|
assert(HasRemainingOperands(Instr) &&
|
|
|
|
"Reseting operands should only be done when the instruction has "
|
|
|
|
"an operand still on the stack");
|
|
|
|
Worklist.back() = reverse(Instr->explicit_uses());
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Test whether Instr has operands remaining to be visited at the top of
|
|
|
|
/// the stack.
|
|
|
|
bool HasRemainingOperands(const MachineInstr *Instr) const {
|
|
|
|
if (Worklist.empty())
|
|
|
|
return false;
|
|
|
|
const RangeTy &Range = Worklist.back();
|
|
|
|
return Range.begin() != Range.end() && Range.begin()->getParent() == Instr;
|
|
|
|
}
|
2016-01-28 11:59:09 +08:00
|
|
|
|
|
|
|
/// Test whether the given register is present on the stack, indicating an
|
|
|
|
/// operand in the tree that we haven't visited yet. Moving a definition of
|
|
|
|
/// Reg to a point in the tree after that would change its value.
|
2016-05-18 06:24:18 +08:00
|
|
|
///
|
|
|
|
/// This is needed as a consequence of using implicit get_locals for
|
|
|
|
/// uses and implicit set_locals for defs.
|
2016-01-28 11:59:09 +08:00
|
|
|
bool IsOnStack(unsigned Reg) const {
|
|
|
|
for (const RangeTy &Range : Worklist)
|
|
|
|
for (const MachineOperand &MO : Range)
|
|
|
|
if (MO.isReg() && MO.getReg() == Reg)
|
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
}
|
2016-01-28 09:22:44 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
/// State to keep track of whether commuting is in flight or whether it's been
|
|
|
|
/// tried for the current instruction and didn't work.
|
|
|
|
class CommutingState {
|
|
|
|
/// There are effectively three states: the initial state where we haven't
|
|
|
|
/// started commuting anything and we don't know anything yet, the tenative
|
|
|
|
/// state where we've commuted the operands of the current instruction and are
|
|
|
|
/// revisting it, and the declined state where we've reverted the operands
|
|
|
|
/// back to their original order and will no longer commute it further.
|
|
|
|
bool TentativelyCommuting;
|
|
|
|
bool Declined;
|
|
|
|
|
|
|
|
/// During the tentative state, these hold the operand indices of the commuted
|
|
|
|
/// operands.
|
|
|
|
unsigned Operand0, Operand1;
|
|
|
|
|
|
|
|
public:
|
|
|
|
CommutingState() : TentativelyCommuting(false), Declined(false) {}
|
|
|
|
|
|
|
|
/// Stackification for an operand was not successful due to ordering
|
|
|
|
/// constraints. If possible, and if we haven't already tried it and declined
|
|
|
|
/// it, commute Insert's operands and prepare to revisit it.
|
|
|
|
void MaybeCommute(MachineInstr *Insert, TreeWalkerState &TreeWalker,
|
|
|
|
const WebAssemblyInstrInfo *TII) {
|
|
|
|
if (TentativelyCommuting) {
|
|
|
|
assert(!Declined &&
|
|
|
|
"Don't decline commuting until you've finished trying it");
|
|
|
|
// Commuting didn't help. Revert it.
|
2016-06-30 08:01:54 +08:00
|
|
|
TII->commuteInstruction(*Insert, /*NewMI=*/false, Operand0, Operand1);
|
2016-01-28 09:22:44 +08:00
|
|
|
TentativelyCommuting = false;
|
|
|
|
Declined = true;
|
|
|
|
} else if (!Declined && TreeWalker.HasRemainingOperands(Insert)) {
|
|
|
|
Operand0 = TargetInstrInfo::CommuteAnyOperandIndex;
|
|
|
|
Operand1 = TargetInstrInfo::CommuteAnyOperandIndex;
|
2016-06-30 08:01:54 +08:00
|
|
|
if (TII->findCommutedOpIndices(*Insert, Operand0, Operand1)) {
|
2016-01-28 09:22:44 +08:00
|
|
|
// Tentatively commute the operands and try again.
|
2016-06-30 08:01:54 +08:00
|
|
|
TII->commuteInstruction(*Insert, /*NewMI=*/false, Operand0, Operand1);
|
2016-01-28 09:22:44 +08:00
|
|
|
TreeWalker.ResetTopOperands(Insert);
|
|
|
|
TentativelyCommuting = true;
|
|
|
|
Declined = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Stackification for some operand was successful. Reset to the default
|
|
|
|
/// state.
|
|
|
|
void Reset() {
|
|
|
|
TentativelyCommuting = false;
|
|
|
|
Declined = false;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
2015-11-17 00:18:28 +08:00
|
|
|
bool WebAssemblyRegStackify::runOnMachineFunction(MachineFunction &MF) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "********** Register Stackifying **********\n"
|
|
|
|
"********** Function: "
|
|
|
|
<< MF.getName() << '\n');
|
2015-11-17 00:18:28 +08:00
|
|
|
|
|
|
|
bool Changed = false;
|
|
|
|
MachineRegisterInfo &MRI = MF.getRegInfo();
|
|
|
|
WebAssemblyFunctionInfo &MFI = *MF.getInfo<WebAssemblyFunctionInfo>();
|
2016-01-20 00:59:23 +08:00
|
|
|
const auto *TII = MF.getSubtarget<WebAssemblySubtarget>().getInstrInfo();
|
|
|
|
const auto *TRI = MF.getSubtarget<WebAssemblySubtarget>().getRegisterInfo();
|
2015-11-26 00:55:01 +08:00
|
|
|
AliasAnalysis &AA = getAnalysis<AAResultsWrapperPass>().getAAResults();
|
2016-01-28 09:22:44 +08:00
|
|
|
MachineDominatorTree &MDT = getAnalysis<MachineDominatorTree>();
|
2015-12-25 08:31:02 +08:00
|
|
|
LiveIntervals &LIS = getAnalysis<LiveIntervals>();
|
2015-12-08 11:30:42 +08:00
|
|
|
|
2015-11-17 00:18:28 +08:00
|
|
|
// Walk the instructions from the bottom up. Currently we don't look past
|
|
|
|
// block boundaries, and the blocks aren't ordered so the block visitation
|
|
|
|
// order isn't significant, but we may want to change this in the future.
|
|
|
|
for (MachineBasicBlock &MBB : MF) {
|
2016-01-07 02:29:35 +08:00
|
|
|
// Don't use a range-based for loop, because we modify the list as we're
|
|
|
|
// iterating over it and the end iterator may change.
|
|
|
|
for (auto MII = MBB.rbegin(); MII != MBB.rend(); ++MII) {
|
|
|
|
MachineInstr *Insert = &*MII;
|
2015-11-26 00:55:01 +08:00
|
|
|
// Don't nest anything inside an inline asm, because we don't have
|
|
|
|
// constraints for $push inputs.
|
|
|
|
if (Insert->getOpcode() == TargetOpcode::INLINEASM)
|
2016-02-23 01:45:20 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// Ignore debugging intrinsics.
|
|
|
|
if (Insert->getOpcode() == TargetOpcode::DBG_VALUE)
|
|
|
|
continue;
|
2015-11-26 00:55:01 +08:00
|
|
|
|
2015-11-17 00:18:28 +08:00
|
|
|
// Iterate through the inputs in reverse order, since we'll be pulling
|
2015-12-03 02:08:49 +08:00
|
|
|
// operands off the stack in LIFO order.
|
2016-01-28 09:22:44 +08:00
|
|
|
CommutingState Commuting;
|
|
|
|
TreeWalkerState TreeWalker(Insert);
|
|
|
|
while (!TreeWalker.Done()) {
|
|
|
|
MachineOperand &Op = TreeWalker.Pop();
|
|
|
|
|
2015-11-17 00:18:28 +08:00
|
|
|
// We're only interested in explicit virtual register operands.
|
2016-01-28 09:22:44 +08:00
|
|
|
if (!Op.isReg())
|
2015-11-17 00:18:28 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
unsigned Reg = Op.getReg();
|
2016-01-28 09:22:44 +08:00
|
|
|
assert(Op.isUse() && "explicit_uses() should only iterate over uses");
|
|
|
|
assert(!Op.isImplicit() &&
|
|
|
|
"explicit_uses() should only iterate over explicit operands");
|
|
|
|
if (TargetRegisterInfo::isPhysicalRegister(Reg))
|
|
|
|
continue;
|
2015-11-17 00:18:28 +08:00
|
|
|
|
2016-10-04 06:32:21 +08:00
|
|
|
// Identify the definition for this register at this point.
|
2016-05-17 12:05:31 +08:00
|
|
|
MachineInstr *Def = GetVRegDef(Reg, Insert, MRI, LIS);
|
|
|
|
if (!Def)
|
|
|
|
continue;
|
2015-11-17 00:18:28 +08:00
|
|
|
|
2015-11-26 00:55:01 +08:00
|
|
|
// Don't nest an INLINE_ASM def into anything, because we don't have
|
|
|
|
// constraints for $pop outputs.
|
|
|
|
if (Def->getOpcode() == TargetOpcode::INLINEASM)
|
|
|
|
continue;
|
|
|
|
|
2015-11-19 00:12:01 +08:00
|
|
|
// Argument instructions represent live-in registers and not real
|
|
|
|
// instructions.
|
2016-10-25 03:49:43 +08:00
|
|
|
if (WebAssembly::isArgument(*Def))
|
2015-11-19 00:12:01 +08:00
|
|
|
continue;
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
// Decide which strategy to take. Prefer to move a single-use value
|
2016-10-25 03:49:43 +08:00
|
|
|
// over cloning it, and prefer cloning over introducing a tee.
|
2016-01-28 09:22:44 +08:00
|
|
|
// For moving, we require the def to be in the same block as the use;
|
|
|
|
// this makes things simpler (LiveIntervals' handleMove function only
|
|
|
|
// supports intra-block moves) and it's MachineSink's job to catch all
|
|
|
|
// the sinking opportunities anyway.
|
|
|
|
bool SameBlock = Def->getParent() == &MBB;
|
2016-10-01 02:02:54 +08:00
|
|
|
bool CanMove = SameBlock && IsSafeToMove(Def, Insert, AA, MRI) &&
|
2016-01-28 11:59:09 +08:00
|
|
|
!TreeWalker.IsOnStack(Reg);
|
2016-05-18 04:19:47 +08:00
|
|
|
if (CanMove && HasOneUse(Reg, Def, MRI, MDT, LIS)) {
|
2016-05-10 12:24:02 +08:00
|
|
|
Insert = MoveForSingleUse(Reg, Op, Def, MBB, Insert, LIS, MFI, MRI);
|
2016-06-30 08:01:54 +08:00
|
|
|
} else if (ShouldRematerialize(*Def, AA, TII)) {
|
|
|
|
Insert =
|
|
|
|
RematerializeCheapDef(Reg, Op, *Def, MBB, Insert->getIterator(),
|
|
|
|
LIS, MFI, MRI, TII, TRI);
|
2018-07-17 07:09:29 +08:00
|
|
|
} else if (CanMove &&
|
2016-05-18 06:24:18 +08:00
|
|
|
OneUseDominatesOtherUses(Reg, Op, MBB, MRI, MDT, LIS, MFI)) {
|
2016-01-28 09:22:44 +08:00
|
|
|
Insert = MoveAndTeeForMultiUse(Reg, Op, Def, MBB, Insert, LIS, MFI,
|
|
|
|
MRI, TII);
|
|
|
|
} else {
|
|
|
|
// We failed to stackify the operand. If the problem was ordering
|
|
|
|
// constraints, Commuting may be able to help.
|
|
|
|
if (!CanMove && SameBlock)
|
|
|
|
Commuting.MaybeCommute(Insert, TreeWalker, TII);
|
|
|
|
// Proceed to the next operand.
|
|
|
|
continue;
|
2016-01-20 00:59:23 +08:00
|
|
|
}
|
2016-01-28 09:22:44 +08:00
|
|
|
|
2016-11-09 03:40:38 +08:00
|
|
|
// If the instruction we just stackified is an IMPLICIT_DEF, convert it
|
|
|
|
// to a constant 0 so that the def is explicit, and the push/pop
|
|
|
|
// correspondence is maintained.
|
|
|
|
if (Insert->getOpcode() == TargetOpcode::IMPLICIT_DEF)
|
|
|
|
ConvertImplicitDefToConstZero(Insert, MRI, TII, MF);
|
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
// We stackified an operand. Add the defining instruction's operands to
|
|
|
|
// the worklist stack now to continue to build an ever deeper tree.
|
|
|
|
Commuting.Reset();
|
|
|
|
TreeWalker.PushOperands(Insert);
|
2015-11-17 00:18:28 +08:00
|
|
|
}
|
2016-01-28 09:22:44 +08:00
|
|
|
|
|
|
|
// If we stackified any operands, skip over the tree to start looking for
|
|
|
|
// the next instruction we can build a tree on.
|
|
|
|
if (Insert != &*MII) {
|
2016-01-07 02:29:35 +08:00
|
|
|
ImposeStackOrdering(&*MII);
|
2016-09-12 17:35:59 +08:00
|
|
|
MII = MachineBasicBlock::iterator(Insert).getReverse();
|
2016-01-28 09:22:44 +08:00
|
|
|
Changed = true;
|
|
|
|
}
|
2015-11-17 00:18:28 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-10-04 06:43:53 +08:00
|
|
|
// If we used VALUE_STACK anywhere, add it to the live-in sets everywhere so
|
2016-01-28 09:22:44 +08:00
|
|
|
// that it never looks like a use-before-def.
|
2015-11-20 10:19:12 +08:00
|
|
|
if (Changed) {
|
2016-10-04 06:43:53 +08:00
|
|
|
MF.getRegInfo().addLiveIn(WebAssembly::VALUE_STACK);
|
2015-11-20 10:19:12 +08:00
|
|
|
for (MachineBasicBlock &MBB : MF)
|
2016-10-04 06:43:53 +08:00
|
|
|
MBB.addLiveIn(WebAssembly::VALUE_STACK);
|
2015-11-20 10:19:12 +08:00
|
|
|
}
|
|
|
|
|
2015-11-20 10:33:24 +08:00
|
|
|
#ifndef NDEBUG
|
2016-01-20 00:59:23 +08:00
|
|
|
// Verify that pushes and pops are performed in LIFO order.
|
2015-11-20 10:33:24 +08:00
|
|
|
SmallVector<unsigned, 0> Stack;
|
|
|
|
for (MachineBasicBlock &MBB : MF) {
|
|
|
|
for (MachineInstr &MI : MBB) {
|
2018-05-09 10:42:00 +08:00
|
|
|
if (MI.isDebugInstr())
|
2016-05-10 12:24:02 +08:00
|
|
|
continue;
|
2015-11-20 10:33:24 +08:00
|
|
|
for (MachineOperand &MO : reverse(MI.explicit_operands())) {
|
2015-11-30 06:32:02 +08:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
2016-01-28 09:22:44 +08:00
|
|
|
unsigned Reg = MO.getReg();
|
2015-11-20 10:33:24 +08:00
|
|
|
|
2016-01-28 09:22:44 +08:00
|
|
|
if (MFI.isVRegStackified(Reg)) {
|
2015-11-20 10:33:24 +08:00
|
|
|
if (MO.isDef())
|
2016-01-28 09:22:44 +08:00
|
|
|
Stack.push_back(Reg);
|
2015-11-20 10:33:24 +08:00
|
|
|
else
|
2016-01-28 09:22:44 +08:00
|
|
|
assert(Stack.pop_back_val() == Reg &&
|
|
|
|
"Register stack pop should be paired with a push");
|
2015-11-20 10:33:24 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// TODO: Generalize this code to support keeping values on the stack across
|
|
|
|
// basic block boundaries.
|
2016-01-28 09:22:44 +08:00
|
|
|
assert(Stack.empty() &&
|
|
|
|
"Register stack pushes and pops should be balanced");
|
2015-11-20 10:33:24 +08:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2015-11-17 00:18:28 +08:00
|
|
|
return Changed;
|
|
|
|
}
|