2015-07-30 19:36:16 +08:00
// RUN: %clang_cc1 -verify -fopenmp %s
2016-04-12 03:30:25 +08:00
// RUN: %clang_cc1 -verify -fopenmp -std=c++98 %s
// RUN: %clang_cc1 -verify -fopenmp -std=c++11 %s
2015-07-30 19:36:16 +08:00
2017-12-30 02:07:07 +08:00
// RUN: %clang_cc1 -verify -fopenmp-simd %s
// RUN: %clang_cc1 -verify -fopenmp-simd -std=c++98 %s
// RUN: %clang_cc1 -verify -fopenmp-simd -std=c++11 %s
// SIMD-ONLY0-NOT: {{__kmpc|__tgt}}
2015-07-30 19:36:16 +08:00
void foo ( ) {
}
2016-04-12 03:30:25 +08:00
# if __cplusplus >= 201103L
// expected-note@+2 4 {{declared here}}
# endif
2015-07-30 19:36:16 +08:00
bool foobool ( int argc ) {
return argc ;
}
struct S1 ; // expected-note {{declared here}}
template < class T , typename S , int N , int ST > // expected-note {{declared here}}
T tmain ( T argc , S * * argv ) { //expected-note 2 {{declared here}}
# pragma omp for ordered
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered() // expected-error {{expected expression}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
// expected-error@+3 {{expected ')'}} expected-note@+3 {{to match this '('}}
// expected-error@+2 2 {{expression is not an integral constant expression}}
// expected-note@+1 2 {{read of non-const variable 'argc' is not allowed in a constant expression}}
# pragma omp for ordered(argc
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
2015-12-01 18:17:31 +08:00
// expected-error@+1 2 {{argument to 'ordered' clause must be a strictly positive integer value}}
2015-07-30 19:36:16 +08:00
# pragma omp for ordered(ST // expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered(1)) // expected-warning {{extra tokens at the end of '#pragma omp for' are ignored}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered((ST > 0) ? 1 + ST : 2) // expected-note 2 {{as specified in 'ordered' clause}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ; // expected-error 2 {{expected 2 for loops after '#pragma omp for', but found only 1}}
2016-04-12 03:30:25 +08:00
// expected-error@+6 2 {{directive '#pragma omp for' cannot contain more than one 'ordered' clause}}
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed. isNonNegative and isStrictlyPositive call isNegative and so
are also affected.
This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.
A large set of Clang OpenMP tests are affected. Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive. This patch adjusts those tests to
assume `true` should be accepted.
This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.
Reviewed By: lebedev.ri, ABataev, hfinkel
Differential Revision: https://reviews.llvm.org/D59712
llvm-svn: 359012
2019-04-24 01:04:15 +08:00
// expected-error@+5 {{argument to 'ordered' clause must be a strictly positive integer value}}
2016-04-12 03:30:25 +08:00
// expected-error@+4 2 {{expression is not an integral constant expression}}
# if __cplusplus >= 201103L
// expected-note@+2 2 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
# endif
2015-07-30 19:36:16 +08:00
# pragma omp for ordered(foobool(argc)), ordered(true), ordered(-5)
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered(S) // expected-error {{'S' does not refer to a value}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
2016-04-12 03:30:25 +08:00
# if __cplusplus <= 199711L
// expected-error@+4 2 {{expression is not an integral constant expression}}
# else
// expected-error@+2 2 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
# endif
2015-07-30 19:36:16 +08:00
# pragma omp for ordered(argv[1] = 2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered(1)
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
2015-12-01 18:17:31 +08:00
# pragma omp for ordered(N-1) // expected-error 2 {{argument to 'ordered' clause must be a strictly positive integer value}}
2015-11-26 15:50:39 +08:00
for ( int i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
2015-12-01 18:17:31 +08:00
# pragma omp for ordered(N) // expected-error {{argument to 'ordered' clause must be a strictly positive integer value}}
2015-07-30 19:36:16 +08:00
for ( T i = ST ; i < N ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp for ordered(2) // expected-note {{as specified in 'ordered' clause}}
foo ( ) ; // expected-error {{expected 2 for loops after '#pragma omp for'}}
2015-12-01 18:17:31 +08:00
# pragma omp for ordered(N) collapse(N + 2) // expected-error {{the parameter of the 'ordered' clause must be greater than or equal to the parameter of the 'collapse' clause}} expected-note {{parameter of the 'collapse' clause}} expected-error {{argument to 'ordered' clause must be a strictly positive integer value}}
2015-11-26 15:50:39 +08:00
for ( int i = ST ; i < N ; i + + )
for ( int j = ST ; j < N ; j + + )
for ( int k = ST ; k < N ; k + + )
foo ( ) ;
2015-07-30 19:36:16 +08:00
return argc ;
}
int main ( int argc , char * * argv ) {
# pragma omp for ordered
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp for ordered( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp for ordered() // expected-error {{expected expression}}
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp for ordered(4 // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-note {{as specified in 'ordered' clause}}
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
# pragma omp for ordered(2 + 2)) // expected-warning {{extra tokens at the end of '#pragma omp for' are ignored}} expected-note {{as specified in 'ordered' clause}}
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2016-04-12 03:30:25 +08:00
// expected-error@+4 {{expression is not an integral constant expression}}
# if __cplusplus >= 201103L
// expected-note@+2 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
# endif
# pragma omp for ordered(foobool(1) > 0 ? 1 : 2)
2015-07-30 19:36:16 +08:00
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
2016-04-12 03:30:25 +08:00
// expected-error@+6 {{expression is not an integral constant expression}}
# if __cplusplus >= 201103L
// expected-note@+4 {{non-constexpr function 'foobool' cannot be used in a constant expression}}
# endif
2015-07-30 19:36:16 +08:00
// expected-error@+2 2 {{directive '#pragma omp for' cannot contain more than one 'ordered' clause}}
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed. isNonNegative and isStrictlyPositive call isNegative and so
are also affected.
This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.
A large set of Clang OpenMP tests are affected. Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive. This patch adjusts those tests to
assume `true` should be accepted.
This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.
Reviewed By: lebedev.ri, ABataev, hfinkel
Differential Revision: https://reviews.llvm.org/D59712
llvm-svn: 359012
2019-04-24 01:04:15 +08:00
// expected-error@+1 {{argument to 'ordered' clause must be a strictly positive integer value}}
2015-07-30 19:36:16 +08:00
# pragma omp for ordered(foobool(argc)), ordered(true), ordered(-5)
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp for ordered(S1) // expected-error {{'S1' does not refer to a value}}
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
2016-04-12 03:30:25 +08:00
# if __cplusplus <= 199711L
// expected-error@+4 {{expression is not an integral constant expression}}
# else
// expected-error@+2 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
# endif
2015-07-30 19:36:16 +08:00
# pragma omp for ordered(argv[1] = 2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
// expected-error@+3 {{statement after '#pragma omp for' must be a for loop}}
// expected-note@+1 {{in instantiation of function template specialization 'tmain<int, char, -1, -2>' requested here}}
# pragma omp for ordered(ordered(tmain < int, char, -1, -2 > (argc, argv) // expected-error 2 {{expected ')'}} expected-note 2 {{to match this '('}}
foo ( ) ;
# pragma omp for ordered(2) // expected-note {{as specified in 'ordered' clause}}
foo ( ) ; // expected-error {{expected 2 for loops after '#pragma omp for'}}
2015-12-01 18:17:31 +08:00
# pragma omp for ordered(0) // expected-error {{argument to 'ordered' clause must be a strictly positive integer value}}
2015-11-26 15:50:39 +08:00
for ( int i = 4 ; i < 12 ; i + + )
argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp for ordered(2) collapse(3) // expected-error {{the parameter of the 'ordered' clause must be greater than or equal to the parameter of the 'collapse' clause}} expected-note {{parameter of the 'collapse' clause}}
for ( int i = 0 ; i < 10 ; i + + )
for ( int j = 0 ; j < 11 ; j + + )
for ( int k = 0 ; k < 12 ; k + + )
foo ( ) ;
2015-07-30 19:36:16 +08:00
// expected-note@+1 {{in instantiation of function template specialization 'tmain<int, char, 1, 0>' requested here}}
return tmain < int , char , 1 , 0 > ( argc , argv ) ;
}
