2017-11-03 20:12:27 +08:00
|
|
|
//===--- ExpandMemCmp.cpp - Expand memcmp() to load/stores ----------------===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2017-11-03 20:12:27 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
2017-12-18 15:32:48 +08:00
|
|
|
// This pass tries to expand memcmp() calls into optimally-sized loads and
|
|
|
|
// compares for the target.
|
2017-11-03 20:12:27 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/ADT/Statistic.h"
|
|
|
|
#include "llvm/Analysis/ConstantFolding.h"
|
2019-12-06 01:39:37 +08:00
|
|
|
#include "llvm/Analysis/LazyBlockFrequencyInfo.h"
|
|
|
|
#include "llvm/Analysis/ProfileSummaryInfo.h"
|
2017-11-03 20:12:27 +08:00
|
|
|
#include "llvm/Analysis/TargetLibraryInfo.h"
|
|
|
|
#include "llvm/Analysis/TargetTransformInfo.h"
|
|
|
|
#include "llvm/Analysis/ValueTracking.h"
|
2019-09-10 18:39:09 +08:00
|
|
|
#include "llvm/CodeGen/TargetLowering.h"
|
|
|
|
#include "llvm/CodeGen/TargetPassConfig.h"
|
2017-11-17 09:07:10 +08:00
|
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
2017-11-03 20:12:27 +08:00
|
|
|
#include "llvm/IR/IRBuilder.h"
|
Sink all InitializePasses.h includes
This file lists every pass in LLVM, and is included by Pass.h, which is
very popular. Every time we add, remove, or rename a pass in LLVM, it
caused lots of recompilation.
I found this fact by looking at this table, which is sorted by the
number of times a file was changed over the last 100,000 git commits
multiplied by the number of object files that depend on it in the
current checkout:
recompiles touches affected_files header
342380 95 3604 llvm/include/llvm/ADT/STLExtras.h
314730 234 1345 llvm/include/llvm/InitializePasses.h
307036 118 2602 llvm/include/llvm/ADT/APInt.h
213049 59 3611 llvm/include/llvm/Support/MathExtras.h
170422 47 3626 llvm/include/llvm/Support/Compiler.h
162225 45 3605 llvm/include/llvm/ADT/Optional.h
158319 63 2513 llvm/include/llvm/ADT/Triple.h
140322 39 3598 llvm/include/llvm/ADT/StringRef.h
137647 59 2333 llvm/include/llvm/Support/Error.h
131619 73 1803 llvm/include/llvm/Support/FileSystem.h
Before this change, touching InitializePasses.h would cause 1345 files
to recompile. After this change, touching it only causes 550 compiles in
an incremental rebuild.
Reviewers: bkramer, asbirlea, bollu, jdoerfert
Differential Revision: https://reviews.llvm.org/D70211
2019-11-14 05:15:01 +08:00
|
|
|
#include "llvm/InitializePasses.h"
|
2020-03-03 20:17:21 +08:00
|
|
|
#include "llvm/Transforms/Utils/Local.h"
|
2019-12-06 01:39:37 +08:00
|
|
|
#include "llvm/Transforms/Utils/SizeOpts.h"
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
#define DEBUG_TYPE "expandmemcmp"
|
|
|
|
|
|
|
|
STATISTIC(NumMemCmpCalls, "Number of memcmp calls");
|
|
|
|
STATISTIC(NumMemCmpNotConstant, "Number of memcmp calls without constant size");
|
|
|
|
STATISTIC(NumMemCmpGreaterThanMax,
|
|
|
|
"Number of memcmp calls with size greater than max size");
|
|
|
|
STATISTIC(NumMemCmpInlined, "Number of inlined memcmp calls");
|
|
|
|
|
2018-01-04 04:02:39 +08:00
|
|
|
static cl::opt<unsigned> MemCmpEqZeroNumLoadsPerBlock(
|
2017-11-03 20:12:27 +08:00
|
|
|
"memcmp-num-loads-per-block", cl::Hidden, cl::init(1),
|
|
|
|
cl::desc("The number of loads per basic block for inline expansion of "
|
|
|
|
"memcmp that is only being compared against zero."));
|
|
|
|
|
2019-04-12 23:05:46 +08:00
|
|
|
static cl::opt<unsigned> MaxLoadsPerMemcmp(
|
|
|
|
"max-loads-per-memcmp", cl::Hidden,
|
|
|
|
cl::desc("Set maximum number of loads used in expanded memcmp"));
|
|
|
|
|
|
|
|
static cl::opt<unsigned> MaxLoadsPerMemcmpOptSize(
|
|
|
|
"max-loads-per-memcmp-opt-size", cl::Hidden,
|
|
|
|
cl::desc("Set maximum number of loads used in expanded memcmp for -Os/Oz"));
|
|
|
|
|
2017-11-03 20:12:27 +08:00
|
|
|
namespace {
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
|
2017-11-03 20:12:27 +08:00
|
|
|
// This class provides helper functions to expand a memcmp library call into an
|
|
|
|
// inline expansion.
|
|
|
|
class MemCmpExpansion {
|
|
|
|
struct ResultBlock {
|
|
|
|
BasicBlock *BB = nullptr;
|
|
|
|
PHINode *PhiSrc1 = nullptr;
|
|
|
|
PHINode *PhiSrc2 = nullptr;
|
|
|
|
|
|
|
|
ResultBlock() = default;
|
|
|
|
};
|
|
|
|
|
|
|
|
CallInst *const CI;
|
|
|
|
ResultBlock ResBlock;
|
|
|
|
const uint64_t Size;
|
|
|
|
unsigned MaxLoadSize;
|
|
|
|
uint64_t NumLoadsNonOneByte;
|
2018-01-04 04:02:39 +08:00
|
|
|
const uint64_t NumLoadsPerBlockForZeroCmp;
|
2017-11-03 20:12:27 +08:00
|
|
|
std::vector<BasicBlock *> LoadCmpBlocks;
|
2019-09-10 18:39:09 +08:00
|
|
|
BasicBlock *EndBlock;
|
2017-11-03 20:12:27 +08:00
|
|
|
PHINode *PhiRes;
|
|
|
|
const bool IsUsedForZeroCmp;
|
|
|
|
const DataLayout &DL;
|
|
|
|
IRBuilder<> Builder;
|
|
|
|
// Represents the decomposition in blocks of the expansion. For example,
|
|
|
|
// comparing 33 bytes on X86+sse can be done with 2x16-byte loads and
|
2020-03-03 18:06:37 +08:00
|
|
|
// 1x1-byte load, which would be represented as [{16, 0}, {16, 16}, {1, 32}.
|
2017-11-03 20:12:27 +08:00
|
|
|
struct LoadEntry {
|
|
|
|
LoadEntry(unsigned LoadSize, uint64_t Offset)
|
2019-09-10 18:39:09 +08:00
|
|
|
: LoadSize(LoadSize), Offset(Offset) {
|
|
|
|
}
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
// The size of the load for this block, in bytes.
|
2018-12-20 21:01:04 +08:00
|
|
|
unsigned LoadSize;
|
|
|
|
// The offset of this load from the base pointer, in bytes.
|
|
|
|
uint64_t Offset;
|
2017-11-03 20:12:27 +08:00
|
|
|
};
|
2018-12-20 21:01:04 +08:00
|
|
|
using LoadEntryVector = SmallVector<LoadEntry, 8>;
|
|
|
|
LoadEntryVector LoadSequence;
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
void createLoadCmpBlocks();
|
|
|
|
void createResultBlock();
|
|
|
|
void setupResultBlockPHINodes();
|
|
|
|
void setupEndBlockPHINodes();
|
|
|
|
Value *getCompareLoadPairs(unsigned BlockIndex, unsigned &LoadIndex);
|
|
|
|
void emitLoadCompareBlock(unsigned BlockIndex);
|
|
|
|
void emitLoadCompareBlockMultipleLoads(unsigned BlockIndex,
|
|
|
|
unsigned &LoadIndex);
|
2018-12-20 21:01:04 +08:00
|
|
|
void emitLoadCompareByteBlock(unsigned BlockIndex, unsigned OffsetBytes);
|
2017-11-03 20:12:27 +08:00
|
|
|
void emitMemCmpResultBlock();
|
|
|
|
Value *getMemCmpExpansionZeroCase();
|
|
|
|
Value *getMemCmpEqZeroOneBlock();
|
|
|
|
Value *getMemCmpOneBlock();
|
2020-03-03 20:17:21 +08:00
|
|
|
struct LoadPair {
|
|
|
|
Value *Lhs = nullptr;
|
|
|
|
Value *Rhs = nullptr;
|
|
|
|
};
|
|
|
|
LoadPair getLoadPair(Type *LoadSizeType, bool NeedsBSwap, Type *CmpSizeType,
|
|
|
|
unsigned OffsetBytes);
|
2018-12-20 21:01:04 +08:00
|
|
|
|
|
|
|
static LoadEntryVector
|
|
|
|
computeGreedyLoadSequence(uint64_t Size, llvm::ArrayRef<unsigned> LoadSizes,
|
|
|
|
unsigned MaxNumLoads, unsigned &NumLoadsNonOneByte);
|
|
|
|
static LoadEntryVector
|
|
|
|
computeOverlappingLoadSequence(uint64_t Size, unsigned MaxLoadSize,
|
|
|
|
unsigned MaxNumLoads,
|
|
|
|
unsigned &NumLoadsNonOneByte);
|
|
|
|
|
|
|
|
public:
|
2017-11-03 20:12:27 +08:00
|
|
|
MemCmpExpansion(CallInst *CI, uint64_t Size,
|
|
|
|
const TargetTransformInfo::MemCmpExpansionOptions &Options,
|
2019-09-10 18:39:09 +08:00
|
|
|
const bool IsUsedForZeroCmp, const DataLayout &TheDataLayout);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
unsigned getNumBlocks();
|
|
|
|
uint64_t getNumLoads() const { return LoadSequence.size(); }
|
|
|
|
|
|
|
|
Value *getMemCmpExpansion();
|
|
|
|
};
|
|
|
|
|
2018-12-20 21:01:04 +08:00
|
|
|
MemCmpExpansion::LoadEntryVector MemCmpExpansion::computeGreedyLoadSequence(
|
|
|
|
uint64_t Size, llvm::ArrayRef<unsigned> LoadSizes,
|
|
|
|
const unsigned MaxNumLoads, unsigned &NumLoadsNonOneByte) {
|
|
|
|
NumLoadsNonOneByte = 0;
|
|
|
|
LoadEntryVector LoadSequence;
|
|
|
|
uint64_t Offset = 0;
|
|
|
|
while (Size && !LoadSizes.empty()) {
|
|
|
|
const unsigned LoadSize = LoadSizes.front();
|
|
|
|
const uint64_t NumLoadsForThisSize = Size / LoadSize;
|
|
|
|
if (LoadSequence.size() + NumLoadsForThisSize > MaxNumLoads) {
|
|
|
|
// Do not expand if the total number of loads is larger than what the
|
|
|
|
// target allows. Note that it's important that we exit before completing
|
|
|
|
// the expansion to avoid using a ton of memory to store the expansion for
|
|
|
|
// large sizes.
|
|
|
|
return {};
|
|
|
|
}
|
|
|
|
if (NumLoadsForThisSize > 0) {
|
|
|
|
for (uint64_t I = 0; I < NumLoadsForThisSize; ++I) {
|
|
|
|
LoadSequence.push_back({LoadSize, Offset});
|
|
|
|
Offset += LoadSize;
|
|
|
|
}
|
|
|
|
if (LoadSize > 1)
|
|
|
|
++NumLoadsNonOneByte;
|
|
|
|
Size = Size % LoadSize;
|
|
|
|
}
|
|
|
|
LoadSizes = LoadSizes.drop_front();
|
|
|
|
}
|
|
|
|
return LoadSequence;
|
|
|
|
}
|
|
|
|
|
|
|
|
MemCmpExpansion::LoadEntryVector
|
|
|
|
MemCmpExpansion::computeOverlappingLoadSequence(uint64_t Size,
|
|
|
|
const unsigned MaxLoadSize,
|
|
|
|
const unsigned MaxNumLoads,
|
|
|
|
unsigned &NumLoadsNonOneByte) {
|
|
|
|
// These are already handled by the greedy approach.
|
|
|
|
if (Size < 2 || MaxLoadSize < 2)
|
|
|
|
return {};
|
|
|
|
|
|
|
|
// We try to do as many non-overlapping loads as possible starting from the
|
|
|
|
// beginning.
|
|
|
|
const uint64_t NumNonOverlappingLoads = Size / MaxLoadSize;
|
|
|
|
assert(NumNonOverlappingLoads && "there must be at least one load");
|
|
|
|
// There remain 0 to (MaxLoadSize - 1) bytes to load, this will be done with
|
|
|
|
// an overlapping load.
|
|
|
|
Size = Size - NumNonOverlappingLoads * MaxLoadSize;
|
|
|
|
// Bail if we do not need an overloapping store, this is already handled by
|
|
|
|
// the greedy approach.
|
|
|
|
if (Size == 0)
|
|
|
|
return {};
|
|
|
|
// Bail if the number of loads (non-overlapping + potential overlapping one)
|
|
|
|
// is larger than the max allowed.
|
|
|
|
if ((NumNonOverlappingLoads + 1) > MaxNumLoads)
|
|
|
|
return {};
|
|
|
|
|
|
|
|
// Add non-overlapping loads.
|
|
|
|
LoadEntryVector LoadSequence;
|
|
|
|
uint64_t Offset = 0;
|
|
|
|
for (uint64_t I = 0; I < NumNonOverlappingLoads; ++I) {
|
|
|
|
LoadSequence.push_back({MaxLoadSize, Offset});
|
|
|
|
Offset += MaxLoadSize;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add the last overlapping load.
|
|
|
|
assert(Size > 0 && Size < MaxLoadSize && "broken invariant");
|
|
|
|
LoadSequence.push_back({MaxLoadSize, Offset - (MaxLoadSize - Size)});
|
|
|
|
NumLoadsNonOneByte = 1;
|
|
|
|
return LoadSequence;
|
|
|
|
}
|
|
|
|
|
2017-11-03 20:12:27 +08:00
|
|
|
// Initialize the basic block structure required for expansion of memcmp call
|
|
|
|
// with given maximum load size and memcmp size parameter.
|
|
|
|
// This structure includes:
|
|
|
|
// 1. A list of load compare blocks - LoadCmpBlocks.
|
|
|
|
// 2. An EndBlock, split from original instruction point, which is the block to
|
|
|
|
// return from.
|
|
|
|
// 3. ResultBlock, block to branch to for early exit when a
|
|
|
|
// LoadCmpBlock finds a difference.
|
|
|
|
MemCmpExpansion::MemCmpExpansion(
|
|
|
|
CallInst *const CI, uint64_t Size,
|
|
|
|
const TargetTransformInfo::MemCmpExpansionOptions &Options,
|
2019-09-10 18:39:09 +08:00
|
|
|
const bool IsUsedForZeroCmp, const DataLayout &TheDataLayout)
|
2019-06-25 16:04:13 +08:00
|
|
|
: CI(CI), Size(Size), MaxLoadSize(0), NumLoadsNonOneByte(0),
|
|
|
|
NumLoadsPerBlockForZeroCmp(Options.NumLoadsPerBlock),
|
2019-09-10 18:39:09 +08:00
|
|
|
IsUsedForZeroCmp(IsUsedForZeroCmp), DL(TheDataLayout), Builder(CI) {
|
2017-11-03 20:12:27 +08:00
|
|
|
assert(Size > 0 && "zero blocks");
|
|
|
|
// Scale the max size down if the target can load more bytes than we need.
|
2018-12-20 21:01:04 +08:00
|
|
|
llvm::ArrayRef<unsigned> LoadSizes(Options.LoadSizes);
|
|
|
|
while (!LoadSizes.empty() && LoadSizes.front() > Size) {
|
|
|
|
LoadSizes = LoadSizes.drop_front();
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
2018-12-20 21:01:04 +08:00
|
|
|
assert(!LoadSizes.empty() && "cannot load Size bytes");
|
|
|
|
MaxLoadSize = LoadSizes.front();
|
2017-11-03 20:12:27 +08:00
|
|
|
// Compute the decomposition.
|
2018-12-20 21:01:04 +08:00
|
|
|
unsigned GreedyNumLoadsNonOneByte = 0;
|
2019-06-25 16:04:13 +08:00
|
|
|
LoadSequence = computeGreedyLoadSequence(Size, LoadSizes, Options.MaxNumLoads,
|
2018-12-20 21:01:04 +08:00
|
|
|
GreedyNumLoadsNonOneByte);
|
|
|
|
NumLoadsNonOneByte = GreedyNumLoadsNonOneByte;
|
2019-06-25 16:04:13 +08:00
|
|
|
assert(LoadSequence.size() <= Options.MaxNumLoads && "broken invariant");
|
2018-12-20 21:01:04 +08:00
|
|
|
// If we allow overlapping loads and the load sequence is not already optimal,
|
|
|
|
// use overlapping loads.
|
|
|
|
if (Options.AllowOverlappingLoads &&
|
|
|
|
(LoadSequence.empty() || LoadSequence.size() > 2)) {
|
|
|
|
unsigned OverlappingNumLoadsNonOneByte = 0;
|
|
|
|
auto OverlappingLoads = computeOverlappingLoadSequence(
|
2019-06-25 16:04:13 +08:00
|
|
|
Size, MaxLoadSize, Options.MaxNumLoads, OverlappingNumLoadsNonOneByte);
|
2018-12-20 21:01:04 +08:00
|
|
|
if (!OverlappingLoads.empty() &&
|
|
|
|
(LoadSequence.empty() ||
|
|
|
|
OverlappingLoads.size() < LoadSequence.size())) {
|
|
|
|
LoadSequence = OverlappingLoads;
|
|
|
|
NumLoadsNonOneByte = OverlappingNumLoadsNonOneByte;
|
2018-12-20 17:58:33 +08:00
|
|
|
}
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
2019-06-25 16:04:13 +08:00
|
|
|
assert(LoadSequence.size() <= Options.MaxNumLoads && "broken invariant");
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
unsigned MemCmpExpansion::getNumBlocks() {
|
|
|
|
if (IsUsedForZeroCmp)
|
2018-01-04 04:02:39 +08:00
|
|
|
return getNumLoads() / NumLoadsPerBlockForZeroCmp +
|
|
|
|
(getNumLoads() % NumLoadsPerBlockForZeroCmp != 0 ? 1 : 0);
|
2017-11-03 20:12:27 +08:00
|
|
|
return getNumLoads();
|
|
|
|
}
|
|
|
|
|
|
|
|
void MemCmpExpansion::createLoadCmpBlocks() {
|
|
|
|
for (unsigned i = 0; i < getNumBlocks(); i++) {
|
|
|
|
BasicBlock *BB = BasicBlock::Create(CI->getContext(), "loadbb",
|
|
|
|
EndBlock->getParent(), EndBlock);
|
|
|
|
LoadCmpBlocks.push_back(BB);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void MemCmpExpansion::createResultBlock() {
|
|
|
|
ResBlock.BB = BasicBlock::Create(CI->getContext(), "res_block",
|
|
|
|
EndBlock->getParent(), EndBlock);
|
|
|
|
}
|
|
|
|
|
2020-03-03 20:17:21 +08:00
|
|
|
MemCmpExpansion::LoadPair MemCmpExpansion::getLoadPair(Type *LoadSizeType,
|
|
|
|
bool NeedsBSwap,
|
|
|
|
Type *CmpSizeType,
|
|
|
|
unsigned OffsetBytes) {
|
|
|
|
// Get the memory source at offset `OffsetBytes`.
|
|
|
|
Value *LhsSource = CI->getArgOperand(0);
|
|
|
|
Value *RhsSource = CI->getArgOperand(1);
|
[ExpandMemCmp] Correctly set alignment of generated loads
Summary:
This is a part of the series of efforts for correcting alignment of memory operations.
(Another related bugs: https://bugs.llvm.org/show_bug.cgi?id=44388 , https://bugs.llvm.org/show_bug.cgi?id=44543 )
This fixes https://bugs.llvm.org/show_bug.cgi?id=43880 by giving default alignment of loads to 1.
The test CodeGen/AArch64/bcmp-inline-small.ll should have been changed; it was introduced by https://reviews.llvm.org/D64805 . I talked with @evandro, and confirmed that the test is okay to be changed.
Other two tests from PowerPC needed changes as well, but fixes were straightforward.
Reviewers: courbet
Reviewed By: courbet
Subscribers: nlopes, gchatelet, wuzish, nemanjai, kristof.beyls, hiraditya, steven.zhang, danielkiss, llvm-commits, evandro
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76113
2020-03-16 21:38:29 +08:00
|
|
|
Align LhsAlign = LhsSource->getPointerAlignment(DL).valueOrOne();
|
|
|
|
Align RhsAlign = RhsSource->getPointerAlignment(DL).valueOrOne();
|
2018-12-20 21:01:04 +08:00
|
|
|
if (OffsetBytes > 0) {
|
|
|
|
auto *ByteType = Type::getInt8Ty(CI->getContext());
|
2020-03-03 20:17:21 +08:00
|
|
|
LhsSource = Builder.CreateConstGEP1_64(
|
|
|
|
ByteType, Builder.CreateBitCast(LhsSource, ByteType->getPointerTo()),
|
|
|
|
OffsetBytes);
|
|
|
|
RhsSource = Builder.CreateConstGEP1_64(
|
|
|
|
ByteType, Builder.CreateBitCast(RhsSource, ByteType->getPointerTo()),
|
2019-10-28 20:39:40 +08:00
|
|
|
OffsetBytes);
|
[ExpandMemCmp] Correctly set alignment of generated loads
Summary:
This is a part of the series of efforts for correcting alignment of memory operations.
(Another related bugs: https://bugs.llvm.org/show_bug.cgi?id=44388 , https://bugs.llvm.org/show_bug.cgi?id=44543 )
This fixes https://bugs.llvm.org/show_bug.cgi?id=43880 by giving default alignment of loads to 1.
The test CodeGen/AArch64/bcmp-inline-small.ll should have been changed; it was introduced by https://reviews.llvm.org/D64805 . I talked with @evandro, and confirmed that the test is okay to be changed.
Other two tests from PowerPC needed changes as well, but fixes were straightforward.
Reviewers: courbet
Reviewed By: courbet
Subscribers: nlopes, gchatelet, wuzish, nemanjai, kristof.beyls, hiraditya, steven.zhang, danielkiss, llvm-commits, evandro
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76113
2020-03-16 21:38:29 +08:00
|
|
|
LhsAlign = commonAlignment(LhsAlign, OffsetBytes);
|
|
|
|
RhsAlign = commonAlignment(RhsAlign, OffsetBytes);
|
2018-12-20 21:01:04 +08:00
|
|
|
}
|
2020-03-03 20:17:21 +08:00
|
|
|
LhsSource = Builder.CreateBitCast(LhsSource, LoadSizeType->getPointerTo());
|
|
|
|
RhsSource = Builder.CreateBitCast(RhsSource, LoadSizeType->getPointerTo());
|
|
|
|
|
|
|
|
// Create a constant or a load from the source.
|
|
|
|
Value *Lhs = nullptr;
|
|
|
|
if (auto *C = dyn_cast<Constant>(LhsSource))
|
|
|
|
Lhs = ConstantFoldLoadFromConstPtr(C, LoadSizeType, DL);
|
|
|
|
if (!Lhs)
|
[ExpandMemCmp] Correctly set alignment of generated loads
Summary:
This is a part of the series of efforts for correcting alignment of memory operations.
(Another related bugs: https://bugs.llvm.org/show_bug.cgi?id=44388 , https://bugs.llvm.org/show_bug.cgi?id=44543 )
This fixes https://bugs.llvm.org/show_bug.cgi?id=43880 by giving default alignment of loads to 1.
The test CodeGen/AArch64/bcmp-inline-small.ll should have been changed; it was introduced by https://reviews.llvm.org/D64805 . I talked with @evandro, and confirmed that the test is okay to be changed.
Other two tests from PowerPC needed changes as well, but fixes were straightforward.
Reviewers: courbet
Reviewed By: courbet
Subscribers: nlopes, gchatelet, wuzish, nemanjai, kristof.beyls, hiraditya, steven.zhang, danielkiss, llvm-commits, evandro
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76113
2020-03-16 21:38:29 +08:00
|
|
|
Lhs = Builder.CreateAlignedLoad(LoadSizeType, LhsSource, LhsAlign);
|
2020-03-03 20:17:21 +08:00
|
|
|
|
|
|
|
Value *Rhs = nullptr;
|
|
|
|
if (auto *C = dyn_cast<Constant>(RhsSource))
|
|
|
|
Rhs = ConstantFoldLoadFromConstPtr(C, LoadSizeType, DL);
|
|
|
|
if (!Rhs)
|
[ExpandMemCmp] Correctly set alignment of generated loads
Summary:
This is a part of the series of efforts for correcting alignment of memory operations.
(Another related bugs: https://bugs.llvm.org/show_bug.cgi?id=44388 , https://bugs.llvm.org/show_bug.cgi?id=44543 )
This fixes https://bugs.llvm.org/show_bug.cgi?id=43880 by giving default alignment of loads to 1.
The test CodeGen/AArch64/bcmp-inline-small.ll should have been changed; it was introduced by https://reviews.llvm.org/D64805 . I talked with @evandro, and confirmed that the test is okay to be changed.
Other two tests from PowerPC needed changes as well, but fixes were straightforward.
Reviewers: courbet
Reviewed By: courbet
Subscribers: nlopes, gchatelet, wuzish, nemanjai, kristof.beyls, hiraditya, steven.zhang, danielkiss, llvm-commits, evandro
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76113
2020-03-16 21:38:29 +08:00
|
|
|
Rhs = Builder.CreateAlignedLoad(LoadSizeType, RhsSource, RhsAlign);
|
2020-03-03 20:17:21 +08:00
|
|
|
|
|
|
|
// Swap bytes if required.
|
|
|
|
if (NeedsBSwap) {
|
|
|
|
Function *Bswap = Intrinsic::getDeclaration(CI->getModule(),
|
|
|
|
Intrinsic::bswap, LoadSizeType);
|
|
|
|
Lhs = Builder.CreateCall(Bswap, Lhs);
|
|
|
|
Rhs = Builder.CreateCall(Bswap, Rhs);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Zero extend if required.
|
|
|
|
if (CmpSizeType != nullptr && CmpSizeType != LoadSizeType) {
|
|
|
|
Lhs = Builder.CreateZExt(Lhs, CmpSizeType);
|
|
|
|
Rhs = Builder.CreateZExt(Rhs, CmpSizeType);
|
|
|
|
}
|
|
|
|
return {Lhs, Rhs};
|
2018-12-20 21:01:04 +08:00
|
|
|
}
|
|
|
|
|
2017-11-03 20:12:27 +08:00
|
|
|
// This function creates the IR instructions for loading and comparing 1 byte.
|
|
|
|
// It loads 1 byte from each source of the memcmp parameters with the given
|
|
|
|
// GEPIndex. It then subtracts the two loaded values and adds this result to the
|
|
|
|
// final phi node for selecting the memcmp result.
|
|
|
|
void MemCmpExpansion::emitLoadCompareByteBlock(unsigned BlockIndex,
|
2018-12-20 21:01:04 +08:00
|
|
|
unsigned OffsetBytes) {
|
2019-09-10 18:39:09 +08:00
|
|
|
Builder.SetInsertPoint(LoadCmpBlocks[BlockIndex]);
|
2020-03-03 20:17:21 +08:00
|
|
|
const LoadPair Loads =
|
|
|
|
getLoadPair(Type::getInt8Ty(CI->getContext()), /*NeedsBSwap=*/false,
|
|
|
|
Type::getInt32Ty(CI->getContext()), OffsetBytes);
|
|
|
|
Value *Diff = Builder.CreateSub(Loads.Lhs, Loads.Rhs);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
PhiRes->addIncoming(Diff, LoadCmpBlocks[BlockIndex]);
|
|
|
|
|
|
|
|
if (BlockIndex < (LoadCmpBlocks.size() - 1)) {
|
|
|
|
// Early exit branch if difference found to EndBlock. Otherwise, continue to
|
|
|
|
// next LoadCmpBlock,
|
|
|
|
Value *Cmp = Builder.CreateICmp(ICmpInst::ICMP_NE, Diff,
|
|
|
|
ConstantInt::get(Diff->getType(), 0));
|
2019-09-10 18:39:09 +08:00
|
|
|
BranchInst *CmpBr =
|
|
|
|
BranchInst::Create(EndBlock, LoadCmpBlocks[BlockIndex + 1], Cmp);
|
2017-11-03 20:12:27 +08:00
|
|
|
Builder.Insert(CmpBr);
|
|
|
|
} else {
|
|
|
|
// The last block has an unconditional branch to EndBlock.
|
|
|
|
BranchInst *CmpBr = BranchInst::Create(EndBlock);
|
|
|
|
Builder.Insert(CmpBr);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Generate an equality comparison for one or more pairs of loaded values.
|
|
|
|
/// This is used in the case where the memcmp() call is compared equal or not
|
|
|
|
/// equal to zero.
|
|
|
|
Value *MemCmpExpansion::getCompareLoadPairs(unsigned BlockIndex,
|
|
|
|
unsigned &LoadIndex) {
|
|
|
|
assert(LoadIndex < getNumLoads() &&
|
|
|
|
"getCompareLoadPairs() called with no remaining loads");
|
|
|
|
std::vector<Value *> XorList, OrList;
|
2019-05-18 19:31:48 +08:00
|
|
|
Value *Diff = nullptr;
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
const unsigned NumLoads =
|
2018-01-04 04:02:39 +08:00
|
|
|
std::min(getNumLoads() - LoadIndex, NumLoadsPerBlockForZeroCmp);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
// For a single-block expansion, start inserting before the memcmp call.
|
|
|
|
if (LoadCmpBlocks.empty())
|
|
|
|
Builder.SetInsertPoint(CI);
|
|
|
|
else
|
|
|
|
Builder.SetInsertPoint(LoadCmpBlocks[BlockIndex]);
|
|
|
|
|
|
|
|
Value *Cmp = nullptr;
|
|
|
|
// If we have multiple loads per block, we need to generate a composite
|
|
|
|
// comparison using xor+or. The type for the combinations is the largest load
|
|
|
|
// type.
|
|
|
|
IntegerType *const MaxLoadType =
|
|
|
|
NumLoads == 1 ? nullptr
|
|
|
|
: IntegerType::get(CI->getContext(), MaxLoadSize * 8);
|
|
|
|
for (unsigned i = 0; i < NumLoads; ++i, ++LoadIndex) {
|
|
|
|
const LoadEntry &CurLoadEntry = LoadSequence[LoadIndex];
|
2020-03-03 20:17:21 +08:00
|
|
|
const LoadPair Loads = getLoadPair(
|
|
|
|
IntegerType::get(CI->getContext(), CurLoadEntry.LoadSize * 8),
|
|
|
|
/*NeedsBSwap=*/false, MaxLoadType, CurLoadEntry.Offset);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
if (NumLoads != 1) {
|
|
|
|
// If we have multiple loads per block, we need to generate a composite
|
|
|
|
// comparison using xor+or.
|
2020-03-03 20:17:21 +08:00
|
|
|
Diff = Builder.CreateXor(Loads.Lhs, Loads.Rhs);
|
2017-11-03 20:12:27 +08:00
|
|
|
Diff = Builder.CreateZExt(Diff, MaxLoadType);
|
|
|
|
XorList.push_back(Diff);
|
|
|
|
} else {
|
|
|
|
// If there's only one load per block, we just compare the loaded values.
|
2020-03-03 20:17:21 +08:00
|
|
|
Cmp = Builder.CreateICmpNE(Loads.Lhs, Loads.Rhs);
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
auto pairWiseOr = [&](std::vector<Value *> &InList) -> std::vector<Value *> {
|
|
|
|
std::vector<Value *> OutList;
|
|
|
|
for (unsigned i = 0; i < InList.size() - 1; i = i + 2) {
|
|
|
|
Value *Or = Builder.CreateOr(InList[i], InList[i + 1]);
|
|
|
|
OutList.push_back(Or);
|
|
|
|
}
|
|
|
|
if (InList.size() % 2 != 0)
|
|
|
|
OutList.push_back(InList.back());
|
|
|
|
return OutList;
|
|
|
|
};
|
|
|
|
|
|
|
|
if (!Cmp) {
|
|
|
|
// Pairwise OR the XOR results.
|
|
|
|
OrList = pairWiseOr(XorList);
|
|
|
|
|
|
|
|
// Pairwise OR the OR results until one result left.
|
|
|
|
while (OrList.size() != 1) {
|
|
|
|
OrList = pairWiseOr(OrList);
|
|
|
|
}
|
2019-05-18 19:31:48 +08:00
|
|
|
|
|
|
|
assert(Diff && "Failed to find comparison diff");
|
2017-11-03 20:12:27 +08:00
|
|
|
Cmp = Builder.CreateICmpNE(OrList[0], ConstantInt::get(Diff->getType(), 0));
|
|
|
|
}
|
|
|
|
|
|
|
|
return Cmp;
|
|
|
|
}
|
|
|
|
|
|
|
|
void MemCmpExpansion::emitLoadCompareBlockMultipleLoads(unsigned BlockIndex,
|
|
|
|
unsigned &LoadIndex) {
|
|
|
|
Value *Cmp = getCompareLoadPairs(BlockIndex, LoadIndex);
|
|
|
|
|
|
|
|
BasicBlock *NextBB = (BlockIndex == (LoadCmpBlocks.size() - 1))
|
|
|
|
? EndBlock
|
|
|
|
: LoadCmpBlocks[BlockIndex + 1];
|
|
|
|
// Early exit branch if difference found to ResultBlock. Otherwise,
|
|
|
|
// continue to next LoadCmpBlock or EndBlock.
|
|
|
|
BranchInst *CmpBr = BranchInst::Create(ResBlock.BB, NextBB, Cmp);
|
|
|
|
Builder.Insert(CmpBr);
|
|
|
|
|
|
|
|
// Add a phi edge for the last LoadCmpBlock to Endblock with a value of 0
|
|
|
|
// since early exit to ResultBlock was not taken (no difference was found in
|
|
|
|
// any of the bytes).
|
|
|
|
if (BlockIndex == LoadCmpBlocks.size() - 1) {
|
|
|
|
Value *Zero = ConstantInt::get(Type::getInt32Ty(CI->getContext()), 0);
|
2019-09-10 18:39:09 +08:00
|
|
|
PhiRes->addIncoming(Zero, LoadCmpBlocks[BlockIndex]);
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// This function creates the IR intructions for loading and comparing using the
|
|
|
|
// given LoadSize. It loads the number of bytes specified by LoadSize from each
|
|
|
|
// source of the memcmp parameters. It then does a subtract to see if there was
|
|
|
|
// a difference in the loaded values. If a difference is found, it branches
|
|
|
|
// with an early exit to the ResultBlock for calculating which source was
|
|
|
|
// larger. Otherwise, it falls through to the either the next LoadCmpBlock or
|
|
|
|
// the EndBlock if this is the last LoadCmpBlock. Loading 1 byte is handled with
|
|
|
|
// a special case through emitLoadCompareByteBlock. The special handling can
|
|
|
|
// simply subtract the loaded values and add it to the result phi node.
|
|
|
|
void MemCmpExpansion::emitLoadCompareBlock(unsigned BlockIndex) {
|
|
|
|
// There is one load per block in this case, BlockIndex == LoadIndex.
|
|
|
|
const LoadEntry &CurLoadEntry = LoadSequence[BlockIndex];
|
|
|
|
|
|
|
|
if (CurLoadEntry.LoadSize == 1) {
|
2018-12-20 21:01:04 +08:00
|
|
|
MemCmpExpansion::emitLoadCompareByteBlock(BlockIndex, CurLoadEntry.Offset);
|
2017-11-03 20:12:27 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
Type *LoadSizeType =
|
|
|
|
IntegerType::get(CI->getContext(), CurLoadEntry.LoadSize * 8);
|
|
|
|
Type *MaxLoadType = IntegerType::get(CI->getContext(), MaxLoadSize * 8);
|
|
|
|
assert(CurLoadEntry.LoadSize <= MaxLoadSize && "Unexpected load type");
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
Builder.SetInsertPoint(LoadCmpBlocks[BlockIndex]);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
2020-03-03 20:17:21 +08:00
|
|
|
const LoadPair Loads =
|
|
|
|
getLoadPair(LoadSizeType, /*NeedsBSwap=*/DL.isLittleEndian(), MaxLoadType,
|
|
|
|
CurLoadEntry.Offset);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
// Add the loaded values to the phi nodes for calculating memcmp result only
|
|
|
|
// if result is not used in a zero equality.
|
|
|
|
if (!IsUsedForZeroCmp) {
|
2020-03-03 20:17:21 +08:00
|
|
|
ResBlock.PhiSrc1->addIncoming(Loads.Lhs, LoadCmpBlocks[BlockIndex]);
|
|
|
|
ResBlock.PhiSrc2->addIncoming(Loads.Rhs, LoadCmpBlocks[BlockIndex]);
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
|
2020-03-03 20:17:21 +08:00
|
|
|
Value *Cmp = Builder.CreateICmp(ICmpInst::ICMP_EQ, Loads.Lhs, Loads.Rhs);
|
2017-11-03 20:12:27 +08:00
|
|
|
BasicBlock *NextBB = (BlockIndex == (LoadCmpBlocks.size() - 1))
|
|
|
|
? EndBlock
|
|
|
|
: LoadCmpBlocks[BlockIndex + 1];
|
|
|
|
// Early exit branch if difference found to ResultBlock. Otherwise, continue
|
|
|
|
// to next LoadCmpBlock or EndBlock.
|
|
|
|
BranchInst *CmpBr = BranchInst::Create(NextBB, ResBlock.BB, Cmp);
|
|
|
|
Builder.Insert(CmpBr);
|
|
|
|
|
|
|
|
// Add a phi edge for the last LoadCmpBlock to Endblock with a value of 0
|
|
|
|
// since early exit to ResultBlock was not taken (no difference was found in
|
|
|
|
// any of the bytes).
|
|
|
|
if (BlockIndex == LoadCmpBlocks.size() - 1) {
|
|
|
|
Value *Zero = ConstantInt::get(Type::getInt32Ty(CI->getContext()), 0);
|
2019-09-10 18:39:09 +08:00
|
|
|
PhiRes->addIncoming(Zero, LoadCmpBlocks[BlockIndex]);
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// This function populates the ResultBlock with a sequence to calculate the
|
|
|
|
// memcmp result. It compares the two loaded source values and returns -1 if
|
|
|
|
// src1 < src2 and 1 if src1 > src2.
|
|
|
|
void MemCmpExpansion::emitMemCmpResultBlock() {
|
|
|
|
// Special case: if memcmp result is used in a zero equality, result does not
|
|
|
|
// need to be calculated and can simply return 1.
|
|
|
|
if (IsUsedForZeroCmp) {
|
|
|
|
BasicBlock::iterator InsertPt = ResBlock.BB->getFirstInsertionPt();
|
|
|
|
Builder.SetInsertPoint(ResBlock.BB, InsertPt);
|
|
|
|
Value *Res = ConstantInt::get(Type::getInt32Ty(CI->getContext()), 1);
|
|
|
|
PhiRes->addIncoming(Res, ResBlock.BB);
|
|
|
|
BranchInst *NewBr = BranchInst::Create(EndBlock);
|
|
|
|
Builder.Insert(NewBr);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
BasicBlock::iterator InsertPt = ResBlock.BB->getFirstInsertionPt();
|
|
|
|
Builder.SetInsertPoint(ResBlock.BB, InsertPt);
|
|
|
|
|
|
|
|
Value *Cmp = Builder.CreateICmp(ICmpInst::ICMP_ULT, ResBlock.PhiSrc1,
|
|
|
|
ResBlock.PhiSrc2);
|
|
|
|
|
|
|
|
Value *Res =
|
|
|
|
Builder.CreateSelect(Cmp, ConstantInt::get(Builder.getInt32Ty(), -1),
|
|
|
|
ConstantInt::get(Builder.getInt32Ty(), 1));
|
|
|
|
|
|
|
|
BranchInst *NewBr = BranchInst::Create(EndBlock);
|
|
|
|
Builder.Insert(NewBr);
|
|
|
|
PhiRes->addIncoming(Res, ResBlock.BB);
|
|
|
|
}
|
|
|
|
|
|
|
|
void MemCmpExpansion::setupResultBlockPHINodes() {
|
|
|
|
Type *MaxLoadType = IntegerType::get(CI->getContext(), MaxLoadSize * 8);
|
|
|
|
Builder.SetInsertPoint(ResBlock.BB);
|
|
|
|
// Note: this assumes one load per block.
|
|
|
|
ResBlock.PhiSrc1 =
|
|
|
|
Builder.CreatePHI(MaxLoadType, NumLoadsNonOneByte, "phi.src1");
|
|
|
|
ResBlock.PhiSrc2 =
|
|
|
|
Builder.CreatePHI(MaxLoadType, NumLoadsNonOneByte, "phi.src2");
|
|
|
|
}
|
|
|
|
|
|
|
|
void MemCmpExpansion::setupEndBlockPHINodes() {
|
|
|
|
Builder.SetInsertPoint(&EndBlock->front());
|
|
|
|
PhiRes = Builder.CreatePHI(Type::getInt32Ty(CI->getContext()), 2, "phi.res");
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *MemCmpExpansion::getMemCmpExpansionZeroCase() {
|
|
|
|
unsigned LoadIndex = 0;
|
|
|
|
// This loop populates each of the LoadCmpBlocks with the IR sequence to
|
|
|
|
// handle multiple loads per block.
|
|
|
|
for (unsigned I = 0; I < getNumBlocks(); ++I) {
|
|
|
|
emitLoadCompareBlockMultipleLoads(I, LoadIndex);
|
|
|
|
}
|
|
|
|
|
|
|
|
emitMemCmpResultBlock();
|
|
|
|
return PhiRes;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// A memcmp expansion that compares equality with 0 and only has one block of
|
|
|
|
/// load and compare can bypass the compare, branch, and phi IR that is required
|
|
|
|
/// in the general case.
|
|
|
|
Value *MemCmpExpansion::getMemCmpEqZeroOneBlock() {
|
|
|
|
unsigned LoadIndex = 0;
|
|
|
|
Value *Cmp = getCompareLoadPairs(0, LoadIndex);
|
|
|
|
assert(LoadIndex == getNumLoads() && "some entries were not consumed");
|
|
|
|
return Builder.CreateZExt(Cmp, Type::getInt32Ty(CI->getContext()));
|
|
|
|
}
|
|
|
|
|
|
|
|
/// A memcmp expansion that only has one block of load and compare can bypass
|
|
|
|
/// the compare, branch, and phi IR that is required in the general case.
|
|
|
|
Value *MemCmpExpansion::getMemCmpOneBlock() {
|
|
|
|
Type *LoadSizeType = IntegerType::get(CI->getContext(), Size * 8);
|
2020-03-03 20:17:21 +08:00
|
|
|
bool NeedsBSwap = DL.isLittleEndian() && Size != 1;
|
2017-11-03 20:12:27 +08:00
|
|
|
|
2020-03-03 20:17:21 +08:00
|
|
|
// The i8 and i16 cases don't need compares. We zext the loaded values and
|
|
|
|
// subtract them to get the suitable negative, zero, or positive i32 result.
|
2017-11-03 20:12:27 +08:00
|
|
|
if (Size < 4) {
|
2020-03-03 20:17:21 +08:00
|
|
|
const LoadPair Loads =
|
|
|
|
getLoadPair(LoadSizeType, NeedsBSwap, Builder.getInt32Ty(),
|
|
|
|
/*Offset*/ 0);
|
|
|
|
return Builder.CreateSub(Loads.Lhs, Loads.Rhs);
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
|
2020-03-03 20:17:21 +08:00
|
|
|
const LoadPair Loads = getLoadPair(LoadSizeType, NeedsBSwap, LoadSizeType,
|
|
|
|
/*Offset*/ 0);
|
2017-11-03 20:12:27 +08:00
|
|
|
// The result of memcmp is negative, zero, or positive, so produce that by
|
|
|
|
// subtracting 2 extended compare bits: sub (ugt, ult).
|
|
|
|
// If a target prefers to use selects to get -1/0/1, they should be able
|
|
|
|
// to transform this later. The inverse transform (going from selects to math)
|
|
|
|
// may not be possible in the DAG because the selects got converted into
|
|
|
|
// branches before we got there.
|
2020-03-03 20:17:21 +08:00
|
|
|
Value *CmpUGT = Builder.CreateICmpUGT(Loads.Lhs, Loads.Rhs);
|
|
|
|
Value *CmpULT = Builder.CreateICmpULT(Loads.Lhs, Loads.Rhs);
|
2017-11-03 20:12:27 +08:00
|
|
|
Value *ZextUGT = Builder.CreateZExt(CmpUGT, Builder.getInt32Ty());
|
|
|
|
Value *ZextULT = Builder.CreateZExt(CmpULT, Builder.getInt32Ty());
|
|
|
|
return Builder.CreateSub(ZextUGT, ZextULT);
|
|
|
|
}
|
|
|
|
|
|
|
|
// This function expands the memcmp call into an inline expansion and returns
|
|
|
|
// the memcmp result.
|
|
|
|
Value *MemCmpExpansion::getMemCmpExpansion() {
|
2018-01-07 00:16:04 +08:00
|
|
|
// Create the basic block framework for a multi-block expansion.
|
|
|
|
if (getNumBlocks() != 1) {
|
2017-11-03 20:12:27 +08:00
|
|
|
BasicBlock *StartBlock = CI->getParent();
|
|
|
|
EndBlock = StartBlock->splitBasicBlock(CI, "endblock");
|
|
|
|
setupEndBlockPHINodes();
|
|
|
|
createResultBlock();
|
|
|
|
|
|
|
|
// If return value of memcmp is not used in a zero equality, we need to
|
|
|
|
// calculate which source was larger. The calculation requires the
|
|
|
|
// two loaded source values of each load compare block.
|
|
|
|
// These will be saved in the phi nodes created by setupResultBlockPHINodes.
|
2019-09-10 18:39:09 +08:00
|
|
|
if (!IsUsedForZeroCmp) setupResultBlockPHINodes();
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
// Create the number of required load compare basic blocks.
|
|
|
|
createLoadCmpBlocks();
|
|
|
|
|
|
|
|
// Update the terminator added by splitBasicBlock to branch to the first
|
|
|
|
// LoadCmpBlock.
|
2019-09-10 18:39:09 +08:00
|
|
|
StartBlock->getTerminator()->setSuccessor(0, LoadCmpBlocks[0]);
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
Builder.SetCurrentDebugLocation(CI->getDebugLoc());
|
|
|
|
|
|
|
|
if (IsUsedForZeroCmp)
|
|
|
|
return getNumBlocks() == 1 ? getMemCmpEqZeroOneBlock()
|
|
|
|
: getMemCmpExpansionZeroCase();
|
|
|
|
|
2018-01-04 04:02:39 +08:00
|
|
|
if (getNumBlocks() == 1)
|
|
|
|
return getMemCmpOneBlock();
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
for (unsigned I = 0; I < getNumBlocks(); ++I) {
|
|
|
|
emitLoadCompareBlock(I);
|
|
|
|
}
|
|
|
|
|
|
|
|
emitMemCmpResultBlock();
|
|
|
|
return PhiRes;
|
|
|
|
}
|
|
|
|
|
|
|
|
// This function checks to see if an expansion of memcmp can be generated.
|
|
|
|
// It checks for constant compare size that is less than the max inline size.
|
|
|
|
// If an expansion cannot occur, returns false to leave as a library call.
|
|
|
|
// Otherwise, the library call is replaced with a new IR instruction sequence.
|
|
|
|
/// We want to transform:
|
|
|
|
/// %call = call signext i32 @memcmp(i8* %0, i8* %1, i64 15)
|
|
|
|
/// To:
|
|
|
|
/// loadbb:
|
|
|
|
/// %0 = bitcast i32* %buffer2 to i8*
|
|
|
|
/// %1 = bitcast i32* %buffer1 to i8*
|
|
|
|
/// %2 = bitcast i8* %1 to i64*
|
|
|
|
/// %3 = bitcast i8* %0 to i64*
|
|
|
|
/// %4 = load i64, i64* %2
|
|
|
|
/// %5 = load i64, i64* %3
|
|
|
|
/// %6 = call i64 @llvm.bswap.i64(i64 %4)
|
|
|
|
/// %7 = call i64 @llvm.bswap.i64(i64 %5)
|
|
|
|
/// %8 = sub i64 %6, %7
|
|
|
|
/// %9 = icmp ne i64 %8, 0
|
|
|
|
/// br i1 %9, label %res_block, label %loadbb1
|
|
|
|
/// res_block: ; preds = %loadbb2,
|
|
|
|
/// %loadbb1, %loadbb
|
|
|
|
/// %phi.src1 = phi i64 [ %6, %loadbb ], [ %22, %loadbb1 ], [ %36, %loadbb2 ]
|
|
|
|
/// %phi.src2 = phi i64 [ %7, %loadbb ], [ %23, %loadbb1 ], [ %37, %loadbb2 ]
|
|
|
|
/// %10 = icmp ult i64 %phi.src1, %phi.src2
|
|
|
|
/// %11 = select i1 %10, i32 -1, i32 1
|
|
|
|
/// br label %endblock
|
|
|
|
/// loadbb1: ; preds = %loadbb
|
|
|
|
/// %12 = bitcast i32* %buffer2 to i8*
|
|
|
|
/// %13 = bitcast i32* %buffer1 to i8*
|
|
|
|
/// %14 = bitcast i8* %13 to i32*
|
|
|
|
/// %15 = bitcast i8* %12 to i32*
|
|
|
|
/// %16 = getelementptr i32, i32* %14, i32 2
|
|
|
|
/// %17 = getelementptr i32, i32* %15, i32 2
|
|
|
|
/// %18 = load i32, i32* %16
|
|
|
|
/// %19 = load i32, i32* %17
|
|
|
|
/// %20 = call i32 @llvm.bswap.i32(i32 %18)
|
|
|
|
/// %21 = call i32 @llvm.bswap.i32(i32 %19)
|
|
|
|
/// %22 = zext i32 %20 to i64
|
|
|
|
/// %23 = zext i32 %21 to i64
|
|
|
|
/// %24 = sub i64 %22, %23
|
|
|
|
/// %25 = icmp ne i64 %24, 0
|
|
|
|
/// br i1 %25, label %res_block, label %loadbb2
|
|
|
|
/// loadbb2: ; preds = %loadbb1
|
|
|
|
/// %26 = bitcast i32* %buffer2 to i8*
|
|
|
|
/// %27 = bitcast i32* %buffer1 to i8*
|
|
|
|
/// %28 = bitcast i8* %27 to i16*
|
|
|
|
/// %29 = bitcast i8* %26 to i16*
|
|
|
|
/// %30 = getelementptr i16, i16* %28, i16 6
|
|
|
|
/// %31 = getelementptr i16, i16* %29, i16 6
|
|
|
|
/// %32 = load i16, i16* %30
|
|
|
|
/// %33 = load i16, i16* %31
|
|
|
|
/// %34 = call i16 @llvm.bswap.i16(i16 %32)
|
|
|
|
/// %35 = call i16 @llvm.bswap.i16(i16 %33)
|
|
|
|
/// %36 = zext i16 %34 to i64
|
|
|
|
/// %37 = zext i16 %35 to i64
|
|
|
|
/// %38 = sub i64 %36, %37
|
|
|
|
/// %39 = icmp ne i64 %38, 0
|
|
|
|
/// br i1 %39, label %res_block, label %loadbb3
|
|
|
|
/// loadbb3: ; preds = %loadbb2
|
|
|
|
/// %40 = bitcast i32* %buffer2 to i8*
|
|
|
|
/// %41 = bitcast i32* %buffer1 to i8*
|
|
|
|
/// %42 = getelementptr i8, i8* %41, i8 14
|
|
|
|
/// %43 = getelementptr i8, i8* %40, i8 14
|
|
|
|
/// %44 = load i8, i8* %42
|
|
|
|
/// %45 = load i8, i8* %43
|
|
|
|
/// %46 = zext i8 %44 to i32
|
|
|
|
/// %47 = zext i8 %45 to i32
|
|
|
|
/// %48 = sub i32 %46, %47
|
|
|
|
/// br label %endblock
|
|
|
|
/// endblock: ; preds = %res_block,
|
|
|
|
/// %loadbb3
|
|
|
|
/// %phi.res = phi i32 [ %48, %loadbb3 ], [ %11, %res_block ]
|
|
|
|
/// ret i32 %phi.res
|
|
|
|
static bool expandMemCmp(CallInst *CI, const TargetTransformInfo *TTI,
|
2019-12-06 01:39:37 +08:00
|
|
|
const TargetLowering *TLI, const DataLayout *DL,
|
|
|
|
ProfileSummaryInfo *PSI, BlockFrequencyInfo *BFI) {
|
2017-11-03 20:12:27 +08:00
|
|
|
NumMemCmpCalls++;
|
|
|
|
|
|
|
|
// Early exit from expansion if -Oz.
|
2019-04-05 06:40:06 +08:00
|
|
|
if (CI->getFunction()->hasMinSize())
|
2017-11-03 20:12:27 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Early exit from expansion if size is not a constant.
|
|
|
|
ConstantInt *SizeCast = dyn_cast<ConstantInt>(CI->getArgOperand(2));
|
|
|
|
if (!SizeCast) {
|
|
|
|
NumMemCmpNotConstant++;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
const uint64_t SizeVal = SizeCast->getZExtValue();
|
|
|
|
|
|
|
|
if (SizeVal == 0) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
// TTI call to check if target would like to expand memcmp. Also, get the
|
|
|
|
// available load sizes.
|
|
|
|
const bool IsUsedForZeroCmp = isOnlyUsedInZeroEqualityComparison(CI);
|
2019-12-06 01:39:37 +08:00
|
|
|
bool OptForSize = CI->getFunction()->hasOptSize() ||
|
|
|
|
llvm::shouldOptimizeForSize(CI->getParent(), PSI, BFI);
|
|
|
|
auto Options = TTI->enableMemCmpExpansion(OptForSize,
|
2019-06-25 16:04:13 +08:00
|
|
|
IsUsedForZeroCmp);
|
2019-09-10 18:39:09 +08:00
|
|
|
if (!Options) return false;
|
2017-11-03 20:12:27 +08:00
|
|
|
|
2019-06-25 16:04:13 +08:00
|
|
|
if (MemCmpEqZeroNumLoadsPerBlock.getNumOccurrences())
|
|
|
|
Options.NumLoadsPerBlock = MemCmpEqZeroNumLoadsPerBlock;
|
2017-11-03 20:12:27 +08:00
|
|
|
|
2019-12-06 01:39:37 +08:00
|
|
|
if (OptForSize &&
|
2019-06-25 16:04:13 +08:00
|
|
|
MaxLoadsPerMemcmpOptSize.getNumOccurrences())
|
|
|
|
Options.MaxNumLoads = MaxLoadsPerMemcmpOptSize;
|
2018-01-04 04:02:39 +08:00
|
|
|
|
2019-12-06 01:39:37 +08:00
|
|
|
if (!OptForSize && MaxLoadsPerMemcmp.getNumOccurrences())
|
2019-06-25 16:04:13 +08:00
|
|
|
Options.MaxNumLoads = MaxLoadsPerMemcmp;
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
MemCmpExpansion Expansion(CI, SizeVal, Options, IsUsedForZeroCmp, *DL);
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
// Don't expand if this will require more loads than desired by the target.
|
|
|
|
if (Expansion.getNumLoads() == 0) {
|
|
|
|
NumMemCmpGreaterThanMax++;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
NumMemCmpInlined++;
|
|
|
|
|
|
|
|
Value *Res = Expansion.getMemCmpExpansion();
|
|
|
|
|
|
|
|
// Replace call with result of expansion and erase call.
|
|
|
|
CI->replaceAllUsesWith(Res);
|
|
|
|
CI->eraseFromParent();
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
|
|
|
|
|
2017-11-03 20:12:27 +08:00
|
|
|
class ExpandMemCmpPass : public FunctionPass {
|
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
|
|
|
|
ExpandMemCmpPass() : FunctionPass(ID) {
|
|
|
|
initializeExpandMemCmpPassPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
|
|
|
|
|
|
|
bool runOnFunction(Function &F) override {
|
2019-09-10 18:39:09 +08:00
|
|
|
if (skipFunction(F)) return false;
|
|
|
|
|
|
|
|
auto *TPC = getAnalysisIfAvailable<TargetPassConfig>();
|
|
|
|
if (!TPC) {
|
2017-11-03 20:12:27 +08:00
|
|
|
return false;
|
2019-09-10 18:39:09 +08:00
|
|
|
}
|
|
|
|
const TargetLowering* TL =
|
|
|
|
TPC->getTM<TargetMachine>().getSubtargetImpl(F)->getTargetLowering();
|
2017-11-03 20:12:27 +08:00
|
|
|
|
|
|
|
const TargetLibraryInfo *TLI =
|
Change TargetLibraryInfo analysis passes to always require Function
Summary:
This is the first change to enable the TLI to be built per-function so
that -fno-builtin* handling can be migrated to use function attributes.
See discussion on D61634 for background. This is an enabler for fixing
handling of these options for LTO, for example.
This change should not affect behavior, as the provided function is not
yet used to build a specifically per-function TLI, but rather enables
that migration.
Most of the changes were very mechanical, e.g. passing a Function to the
legacy analysis pass's getTLI interface, or in Module level cases,
adding a callback. This is similar to the way the per-function TTI
analysis works.
There was one place where we were looking for builtins but not in the
context of a specific function. See FindCXAAtExit in
lib/Transforms/IPO/GlobalOpt.cpp. I'm somewhat concerned my workaround
could provide the wrong behavior in some corner cases. Suggestions
welcome.
Reviewers: chandlerc, hfinkel
Subscribers: arsenm, dschuff, jvesely, nhaehnle, mehdi_amini, javed.absar, sbc100, jgravelle-google, eraman, aheejin, steven_wu, george.burgess.iv, dexonsmith, jfb, asbirlea, gchatelet, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66428
llvm-svn: 371284
2019-09-07 11:09:36 +08:00
|
|
|
&getAnalysis<TargetLibraryInfoWrapperPass>().getTLI(F);
|
2017-11-03 20:12:27 +08:00
|
|
|
const TargetTransformInfo *TTI =
|
|
|
|
&getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F);
|
2019-12-06 01:39:37 +08:00
|
|
|
auto *PSI = &getAnalysis<ProfileSummaryInfoWrapperPass>().getPSI();
|
|
|
|
auto *BFI = (PSI && PSI->hasProfileSummary()) ?
|
|
|
|
&getAnalysis<LazyBlockFrequencyInfoPass>().getBFI() :
|
|
|
|
nullptr;
|
|
|
|
auto PA = runImpl(F, TLI, TTI, TL, PSI, BFI);
|
2017-11-03 20:12:27 +08:00
|
|
|
return !PA.areAllPreserved();
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
|
|
AU.addRequired<TargetLibraryInfoWrapperPass>();
|
|
|
|
AU.addRequired<TargetTransformInfoWrapperPass>();
|
2019-12-06 01:39:37 +08:00
|
|
|
AU.addRequired<ProfileSummaryInfoWrapperPass>();
|
|
|
|
LazyBlockFrequencyInfoPass::getLazyBFIAnalysisUsage(AU);
|
2017-11-03 20:12:27 +08:00
|
|
|
FunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
|
|
|
|
|
|
|
PreservedAnalyses runImpl(Function &F, const TargetLibraryInfo *TLI,
|
2019-09-10 18:39:09 +08:00
|
|
|
const TargetTransformInfo *TTI,
|
2019-12-06 01:39:37 +08:00
|
|
|
const TargetLowering* TL,
|
|
|
|
ProfileSummaryInfo *PSI, BlockFrequencyInfo *BFI);
|
2017-11-03 20:12:27 +08:00
|
|
|
// Returns true if a change was made.
|
|
|
|
bool runOnBlock(BasicBlock &BB, const TargetLibraryInfo *TLI,
|
2019-09-10 18:39:09 +08:00
|
|
|
const TargetTransformInfo *TTI, const TargetLowering* TL,
|
2019-12-06 01:39:37 +08:00
|
|
|
const DataLayout& DL, ProfileSummaryInfo *PSI,
|
|
|
|
BlockFrequencyInfo *BFI);
|
2017-11-03 20:12:27 +08:00
|
|
|
};
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
bool ExpandMemCmpPass::runOnBlock(
|
|
|
|
BasicBlock &BB, const TargetLibraryInfo *TLI,
|
|
|
|
const TargetTransformInfo *TTI, const TargetLowering* TL,
|
2019-12-06 01:39:37 +08:00
|
|
|
const DataLayout& DL, ProfileSummaryInfo *PSI, BlockFrequencyInfo *BFI) {
|
2019-09-10 18:39:09 +08:00
|
|
|
for (Instruction& I : BB) {
|
2017-11-03 20:12:27 +08:00
|
|
|
CallInst *CI = dyn_cast<CallInst>(&I);
|
|
|
|
if (!CI) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
LibFunc Func;
|
|
|
|
if (TLI->getLibFunc(ImmutableCallSite(CI), Func) &&
|
2019-03-20 19:51:11 +08:00
|
|
|
(Func == LibFunc_memcmp || Func == LibFunc_bcmp) &&
|
2019-12-06 01:39:37 +08:00
|
|
|
expandMemCmp(CI, TTI, TL, &DL, PSI, BFI)) {
|
2017-11-03 20:12:27 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
|
|
|
|
PreservedAnalyses ExpandMemCmpPass::runImpl(
|
|
|
|
Function &F, const TargetLibraryInfo *TLI, const TargetTransformInfo *TTI,
|
2019-12-06 01:39:37 +08:00
|
|
|
const TargetLowering* TL, ProfileSummaryInfo *PSI,
|
|
|
|
BlockFrequencyInfo *BFI) {
|
2019-09-10 18:39:09 +08:00
|
|
|
const DataLayout& DL = F.getParent()->getDataLayout();
|
2017-11-03 20:12:27 +08:00
|
|
|
bool MadeChanges = false;
|
|
|
|
for (auto BBIt = F.begin(); BBIt != F.end();) {
|
2019-12-06 01:39:37 +08:00
|
|
|
if (runOnBlock(*BBIt, TLI, TTI, TL, DL, PSI, BFI)) {
|
2017-11-03 20:12:27 +08:00
|
|
|
MadeChanges = true;
|
|
|
|
// If changes were made, restart the function from the beginning, since
|
|
|
|
// the structure of the function was changed.
|
|
|
|
BBIt = F.begin();
|
|
|
|
} else {
|
|
|
|
++BBIt;
|
|
|
|
}
|
|
|
|
}
|
2020-03-03 20:17:21 +08:00
|
|
|
if (MadeChanges)
|
|
|
|
for (BasicBlock &BB : F)
|
|
|
|
SimplifyInstructionsInBlock(&BB);
|
2019-09-10 18:39:09 +08:00
|
|
|
return MadeChanges ? PreservedAnalyses::none() : PreservedAnalyses::all();
|
2017-11-03 20:12:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
char ExpandMemCmpPass::ID = 0;
|
|
|
|
INITIALIZE_PASS_BEGIN(ExpandMemCmpPass, "expandmemcmp",
|
|
|
|
"Expand memcmp() to load/stores", false, false)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
|
2019-12-06 01:39:37 +08:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(LazyBlockFrequencyInfoPass)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(ProfileSummaryInfoWrapperPass)
|
2017-11-03 20:12:27 +08:00
|
|
|
INITIALIZE_PASS_END(ExpandMemCmpPass, "expandmemcmp",
|
|
|
|
"Expand memcmp() to load/stores", false, false)
|
|
|
|
|
2019-09-10 18:39:09 +08:00
|
|
|
FunctionPass *llvm::createExpandMemCmpPass() {
|
|
|
|
return new ExpandMemCmpPass();
|
|
|
|
}
|