maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/Instrumentation/AddressSanitizer/global_metadata_external_co...

10 lines
308 B
LLVM
Raw Normal View History

Re-land r334313 "[asan] Instrument comdat globals on COFF targets" If we can use comdats, then we can make it so that the global metadata is thrown away if the prevailing definition of the global was uninstrumented. I have only tested this on COFF targets, but in theory, there is no reason that we cannot also do this for ELF. This will allow us to re-enable string merging with ASan on Windows, reducing the binary size cost of ASan on Windows. I tested this change with ASan+PGO, and I fixed an issue with the __llvm_profile_raw_version symbol. With the old version of my patch, we would attempt to instrument that symbol on ELF because it had a comdat with external linkage. If we had been using the linker GC-friendly metadata scheme, everything would have worked, but clang does not enable it by default. llvm-svn: 340232
2018-08-21 07:35:45 +08:00
; RUN: opt < %s -mtriple=x86_64-linux -asan -asan-module -asan-globals-live-support=0 -S | FileCheck %s
$my_var = comdat any
@my_var = global i32 42, align 4, comdat
Fix global_metadata_external_comdat.ll test llvm-svn: 340240
2018-08-21 08:03:21 +08:00
; CHECK: @my_var = global i32 42, comdat, align 4
Re-land r334313 "[asan] Instrument comdat globals on COFF targets" If we can use comdats, then we can make it so that the global metadata is thrown away if the prevailing definition of the global was uninstrumented. I have only tested this on COFF targets, but in theory, there is no reason that we cannot also do this for ELF. This will allow us to re-enable string merging with ASan on Windows, reducing the binary size cost of ASan on Windows. I tested this change with ASan+PGO, and I fixed an issue with the __llvm_profile_raw_version symbol. With the old version of my patch, we would attempt to instrument that symbol on ELF because it had a comdat with external linkage. If we had been using the linker GC-friendly metadata scheme, everything would have worked, but clang does not enable it by default. llvm-svn: 340232
2018-08-21 07:35:45 +08:00
; Don't instrument my_var, it is comdat.
Fix global_metadata_external_comdat.ll test llvm-svn: 340240
2018-08-21 08:03:21 +08:00
; CHECK-NOT: call {{.*}}__asan_register_globals