maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/ELF/icf9.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

34 lines
995 B
ArmAsm
Raw Normal View History

ELF ICF: Merge only functions. Previously, LLD merged all read-only sections. So the following program prints out "true" if -icf=all is specified. static const int foo = 1; static const int bar = 1; int main() { printf("%s\n", &foo == &bar ? "true" : "false"); } This is somewhat counter-intuitive, and it actually caused nasty issues. One example is https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24. This patch changes the way how it works. Now ICF merges only functions (i.e. executable sections). Differential Revision: https://reviews.llvm.org/D30365 llvm-svn: 296534
2017-03-01 06:42:49 +08:00
# REQUIRES: x86
### Make sure that we do not merge data.
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
[ELF] - Repair (re-enable) few ICF test cases. --verbose is not used to report ICF sections since r324755, --print-icf-sections is used instead. These tests were at fact disabled since that time. llvm-svn: 335354
2018-06-22 23:08:01 +08:00
# RUN: ld.lld %t -o %t2 --icf=all --print-icf-sections 2>&1 | FileCheck -allow-empty %s
Fix test to test what it intended to test. The test was added to test that we don't merge read only data sections, but the sections in the test were rw. llvm-svn: 320339
2017-12-11 09:06:39 +08:00
# RUN: llvm-readelf -S -W %t2 | FileCheck --check-prefix=SEC %s
ELF ICF: Merge only functions. Previously, LLD merged all read-only sections. So the following program prints out "true" if -icf=all is specified. static const int foo = 1; static const int bar = 1; int main() { printf("%s\n", &foo == &bar ? "true" : "false"); } This is somewhat counter-intuitive, and it actually caused nasty issues. One example is https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24. This patch changes the way how it works. Now ICF merges only functions (i.e. executable sections). Differential Revision: https://reviews.llvm.org/D30365 llvm-svn: 296534
2017-03-01 06:42:49 +08:00
Fix test to test what it intended to test. The test was added to test that we don't merge read only data sections, but the sections in the test were rw. llvm-svn: 320339
2017-12-11 09:06:39 +08:00
# SEC: .rodata PROGBITS 0000000000200120 000120 000002 00 A 0 0 1
Use toString to stringize sections and files. Differential Revision: https://reviews.llvm.org/D43251 llvm-svn: 325065
2018-02-14 06:56:49 +08:00
# CHECK-NOT: selected section {{.*}}:(.rodata.d1)
# CHECK-NOT: selected section {{.*}}:(.rodata.d2)
ELF ICF: Merge only functions. Previously, LLD merged all read-only sections. So the following program prints out "true" if -icf=all is specified. static const int foo = 1; static const int bar = 1; int main() { printf("%s\n", &foo == &bar ? "true" : "false"); } This is somewhat counter-intuitive, and it actually caused nasty issues. One example is https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24. This patch changes the way how it works. Now ICF merges only functions (i.e. executable sections). Differential Revision: https://reviews.llvm.org/D30365 llvm-svn: 296534
2017-03-01 06:42:49 +08:00
Add an option for ICFing data. An internal linker has support for merging identical data and in some cases it can be a significant win. This is behind an off by default flag so it has to be requested explicitly. llvm-svn: 320448
2017-12-12 09:36:24 +08:00
# We do merge rodata if passed --icf-data
Do not print out removed ICF sections for -verbose. GNU gold doesn't print out ICF sections for -verbose. It only shows them for -print-icf-sections. We printed out them for -verbose because we didn't have -print-icf-sections. Now that we have the option, there's no reason to print out for -verbose. Differential Revision: https://reviews.llvm.org/D43100 llvm-svn: 324755
2018-02-10 01:55:09 +08:00
# RUN: ld.lld %t -o %t2 --icf=all --print-icf-sections --ignore-data-address-equality | \
# RUN: FileCheck --check-prefix=DATA %s
Add an option for ICFing data. An internal linker has support for merging identical data and in some cases it can be a significant win. This is behind an off by default flag so it has to be requested explicitly. llvm-svn: 320448
2017-12-12 09:36:24 +08:00
# RUN: llvm-readelf -S -W %t2 | FileCheck --check-prefix=DATA-SEC %s
Use toString to stringize sections and files. Differential Revision: https://reviews.llvm.org/D43251 llvm-svn: 325065
2018-02-14 06:56:49 +08:00
# DATA: selected section {{.*}}:(.rodata.d1)
# DATA: removing identical section {{.*}}:(.rodata.d2)
Add an option for ICFing data. An internal linker has support for merging identical data and in some cases it can be a significant win. This is behind an off by default flag so it has to be requested explicitly. llvm-svn: 320448
2017-12-12 09:36:24 +08:00
# DATA-SEC: .rodata PROGBITS 0000000000200120 000120 000001 00 A 0 0 1
ELF ICF: Merge only functions. Previously, LLD merged all read-only sections. So the following program prints out "true" if -icf=all is specified. static const int foo = 1; static const int bar = 1; int main() { printf("%s\n", &foo == &bar ? "true" : "false"); } This is somewhat counter-intuitive, and it actually caused nasty issues. One example is https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24. This patch changes the way how it works. Now ICF merges only functions (i.e. executable sections). Differential Revision: https://reviews.llvm.org/D30365 llvm-svn: 296534
2017-03-01 06:42:49 +08:00
.globl _start, d1, d2
_start:
ret
Add an option for ICFing data. An internal linker has support for merging identical data and in some cases it can be a significant win. This is behind an off by default flag so it has to be requested explicitly. llvm-svn: 320448
2017-12-12 09:36:24 +08:00
.section .rodata.d1, "a"
ELF ICF: Merge only functions. Previously, LLD merged all read-only sections. So the following program prints out "true" if -icf=all is specified. static const int foo = 1; static const int bar = 1; int main() { printf("%s\n", &foo == &bar ? "true" : "false"); } This is somewhat counter-intuitive, and it actually caused nasty issues. One example is https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24. This patch changes the way how it works. Now ICF merges only functions (i.e. executable sections). Differential Revision: https://reviews.llvm.org/D30365 llvm-svn: 296534
2017-03-01 06:42:49 +08:00
d1:
.byte 1
Add an option for ICFing data. An internal linker has support for merging identical data and in some cases it can be a significant win. This is behind an off by default flag so it has to be requested explicitly. llvm-svn: 320448
2017-12-12 09:36:24 +08:00
.section .rodata.d2, "a"
ELF ICF: Merge only functions. Previously, LLD merged all read-only sections. So the following program prints out "true" if -icf=all is specified. static const int foo = 1; static const int bar = 1; int main() { printf("%s\n", &foo == &bar ? "true" : "false"); } This is somewhat counter-intuitive, and it actually caused nasty issues. One example is https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24. This patch changes the way how it works. Now ICF merges only functions (i.e. executable sections). Differential Revision: https://reviews.llvm.org/D30365 llvm-svn: 296534
2017-03-01 06:42:49 +08:00
d2:
.byte 1