2012-03-07 04:06:33 +08:00
|
|
|
//===--- ObjCMT.cpp - ObjC Migrate Tool -----------------------------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2013-07-19 06:17:33 +08:00
|
|
|
#include "Transforms.h"
|
2012-03-07 04:06:33 +08:00
|
|
|
#include "clang/ARCMigrate/ARCMTActions.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/AST/ASTConsumer.h"
|
2012-07-05 04:19:54 +08:00
|
|
|
#include "clang/AST/ASTContext.h"
|
2012-03-07 04:06:33 +08:00
|
|
|
#include "clang/AST/NSAPI.h"
|
2013-01-17 07:54:48 +08:00
|
|
|
#include "clang/AST/ParentMap.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/AST/RecursiveASTVisitor.h"
|
|
|
|
#include "clang/Basic/FileManager.h"
|
2012-03-07 04:06:33 +08:00
|
|
|
#include "clang/Edit/Commit.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/Edit/EditedSource.h"
|
2012-03-07 04:06:33 +08:00
|
|
|
#include "clang/Edit/EditsReceiver.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/Edit/Rewriters.h"
|
|
|
|
#include "clang/Frontend/CompilerInstance.h"
|
|
|
|
#include "clang/Frontend/MultiplexConsumer.h"
|
2012-12-04 15:27:05 +08:00
|
|
|
#include "clang/Lex/PPConditionalDirectiveRecord.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/Lex/Preprocessor.h"
|
|
|
|
#include "clang/Rewrite/Core/Rewriter.h"
|
2013-08-20 03:13:34 +08:00
|
|
|
#include "clang/Analysis/DomainSpecific/CocoaConventions.h"
|
2013-08-16 05:44:38 +08:00
|
|
|
#include "clang/StaticAnalyzer/Checkers/ObjCRetainCount.h"
|
2013-08-13 07:17:13 +08:00
|
|
|
#include "clang/AST/Attr.h"
|
2012-03-07 04:06:33 +08:00
|
|
|
#include "llvm/ADT/SmallString.h"
|
|
|
|
|
|
|
|
using namespace clang;
|
|
|
|
using namespace arcmt;
|
2013-08-16 05:44:38 +08:00
|
|
|
using namespace ento::objc_retain;
|
2012-03-07 04:06:33 +08:00
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
class ObjCMigrateASTConsumer : public ASTConsumer {
|
2013-08-28 06:42:30 +08:00
|
|
|
enum CF_BRIDGING_KIND {
|
|
|
|
CF_BRIDGING_NONE,
|
|
|
|
CF_BRIDGING_ENABLE,
|
|
|
|
CF_BRIDGING_MAY_INCLUDE
|
|
|
|
};
|
|
|
|
|
2012-03-07 04:06:33 +08:00
|
|
|
void migrateDecl(Decl *D);
|
2013-09-18 03:00:30 +08:00
|
|
|
void migrateObjCInterfaceDecl(ASTContext &Ctx, ObjCContainerDecl *D);
|
2013-07-13 06:32:19 +08:00
|
|
|
void migrateProtocolConformance(ASTContext &Ctx,
|
|
|
|
const ObjCImplementationDecl *ImpDecl);
|
2013-10-15 08:00:28 +08:00
|
|
|
void CacheObjCNSIntegerTypedefed(const TypedefDecl *TypedefDcl);
|
2013-10-12 05:34:56 +08:00
|
|
|
bool migrateNSEnumDecl(ASTContext &Ctx, const EnumDecl *EnumDcl,
|
2013-07-19 04:11:45 +08:00
|
|
|
const TypedefDecl *TypedefDcl);
|
2013-10-03 06:49:59 +08:00
|
|
|
void migrateAllMethodInstaceType(ASTContext &Ctx, ObjCContainerDecl *CDecl);
|
2013-07-24 07:34:42 +08:00
|
|
|
void migrateMethodInstanceType(ASTContext &Ctx, ObjCContainerDecl *CDecl,
|
|
|
|
ObjCMethodDecl *OM);
|
2013-09-18 03:00:30 +08:00
|
|
|
bool migrateProperty(ASTContext &Ctx, ObjCContainerDecl *D, ObjCMethodDecl *OM);
|
2013-08-31 07:52:08 +08:00
|
|
|
void migrateNsReturnsInnerPointer(ASTContext &Ctx, ObjCMethodDecl *OM);
|
2013-09-25 04:20:52 +08:00
|
|
|
void migratePropertyNsReturnsInnerPointer(ASTContext &Ctx, ObjCPropertyDecl *P);
|
2013-08-03 02:00:53 +08:00
|
|
|
void migrateFactoryMethod(ASTContext &Ctx, ObjCContainerDecl *CDecl,
|
2013-08-03 04:54:18 +08:00
|
|
|
ObjCMethodDecl *OM,
|
|
|
|
ObjCInstanceTypeFamily OIT_Family = OIT_None);
|
2013-08-13 07:17:13 +08:00
|
|
|
|
2013-08-23 05:40:15 +08:00
|
|
|
void migrateCFAnnotation(ASTContext &Ctx, const Decl *Decl);
|
2013-08-28 06:42:30 +08:00
|
|
|
void AddCFAnnotations(ASTContext &Ctx, const CallEffects &CE,
|
2013-08-28 07:56:54 +08:00
|
|
|
const FunctionDecl *FuncDecl, bool ResultAnnotated);
|
2013-08-28 06:42:30 +08:00
|
|
|
void AddCFAnnotations(ASTContext &Ctx, const CallEffects &CE,
|
2013-08-28 07:56:54 +08:00
|
|
|
const ObjCMethodDecl *MethodDecl, bool ResultAnnotated);
|
2013-08-17 07:35:05 +08:00
|
|
|
|
2013-08-21 06:42:13 +08:00
|
|
|
void AnnotateImplicitBridging(ASTContext &Ctx);
|
|
|
|
|
2013-08-28 06:42:30 +08:00
|
|
|
CF_BRIDGING_KIND migrateAddFunctionAnnotation(ASTContext &Ctx,
|
|
|
|
const FunctionDecl *FuncDecl);
|
2013-08-13 07:17:13 +08:00
|
|
|
|
2013-08-23 02:35:27 +08:00
|
|
|
void migrateARCSafeAnnotation(ASTContext &Ctx, ObjCContainerDecl *CDecl);
|
|
|
|
|
2013-09-04 08:10:06 +08:00
|
|
|
void migrateAddMethodAnnotation(ASTContext &Ctx,
|
|
|
|
const ObjCMethodDecl *MethodDecl);
|
2012-03-07 04:06:33 +08:00
|
|
|
public:
|
|
|
|
std::string MigrateDir;
|
2013-10-03 01:08:12 +08:00
|
|
|
unsigned ASTMigrateActions;
|
2013-08-21 07:35:26 +08:00
|
|
|
unsigned FileId;
|
2013-10-15 08:00:28 +08:00
|
|
|
const TypedefDecl *NSIntegerTypedefed;
|
|
|
|
const TypedefDecl *NSUIntegerTypedefed;
|
2013-01-13 03:30:44 +08:00
|
|
|
OwningPtr<NSAPI> NSAPIObj;
|
|
|
|
OwningPtr<edit::EditedSource> Editor;
|
2012-03-07 04:06:33 +08:00
|
|
|
FileRemapper &Remapper;
|
|
|
|
FileManager &FileMgr;
|
2012-12-04 15:27:05 +08:00
|
|
|
const PPConditionalDirectiveRecord *PPRec;
|
2013-07-04 07:05:00 +08:00
|
|
|
Preprocessor &PP;
|
2012-03-07 04:06:33 +08:00
|
|
|
bool IsOutputFile;
|
2013-07-13 06:32:19 +08:00
|
|
|
llvm::SmallPtrSet<ObjCProtocolDecl *, 32> ObjCProtocolDecls;
|
2013-08-23 02:35:27 +08:00
|
|
|
llvm::SmallVector<const Decl *, 8> CFFunctionIBCandidates;
|
2013-07-13 06:32:19 +08:00
|
|
|
|
2012-03-07 04:06:33 +08:00
|
|
|
ObjCMigrateASTConsumer(StringRef migrateDir,
|
2013-10-03 01:08:12 +08:00
|
|
|
unsigned astMigrateActions,
|
2012-03-07 04:06:33 +08:00
|
|
|
FileRemapper &remapper,
|
|
|
|
FileManager &fileMgr,
|
2012-12-04 15:27:05 +08:00
|
|
|
const PPConditionalDirectiveRecord *PPRec,
|
2013-07-04 07:05:00 +08:00
|
|
|
Preprocessor &PP,
|
2012-03-07 04:06:33 +08:00
|
|
|
bool isOutputFile = false)
|
|
|
|
: MigrateDir(migrateDir),
|
2013-10-03 01:08:12 +08:00
|
|
|
ASTMigrateActions(astMigrateActions),
|
2013-10-15 08:00:28 +08:00
|
|
|
FileId(0), NSIntegerTypedefed(0), NSUIntegerTypedefed(0),
|
|
|
|
Remapper(remapper), FileMgr(fileMgr), PPRec(PPRec), PP(PP),
|
2012-03-07 04:06:33 +08:00
|
|
|
IsOutputFile(isOutputFile) { }
|
|
|
|
|
|
|
|
protected:
|
|
|
|
virtual void Initialize(ASTContext &Context) {
|
|
|
|
NSAPIObj.reset(new NSAPI(Context));
|
|
|
|
Editor.reset(new edit::EditedSource(Context.getSourceManager(),
|
2012-03-11 15:00:24 +08:00
|
|
|
Context.getLangOpts(),
|
2013-10-02 05:16:29 +08:00
|
|
|
PPRec, false));
|
2012-03-07 04:06:33 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
virtual bool HandleTopLevelDecl(DeclGroupRef DG) {
|
|
|
|
for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I)
|
|
|
|
migrateDecl(*I);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
virtual void HandleInterestingDecl(DeclGroupRef DG) {
|
|
|
|
// Ignore decls from the PCH.
|
|
|
|
}
|
|
|
|
virtual void HandleTopLevelDeclInObjCContainer(DeclGroupRef DG) {
|
|
|
|
ObjCMigrateASTConsumer::HandleTopLevelDecl(DG);
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void HandleTranslationUnit(ASTContext &Ctx);
|
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
ObjCMigrateAction::ObjCMigrateAction(FrontendAction *WrappedAction,
|
2013-10-03 01:08:12 +08:00
|
|
|
StringRef migrateDir,
|
|
|
|
unsigned migrateAction)
|
2012-03-07 04:06:33 +08:00
|
|
|
: WrapperFrontendAction(WrappedAction), MigrateDir(migrateDir),
|
2013-10-03 01:08:12 +08:00
|
|
|
ObjCMigAction(migrateAction),
|
2012-03-07 04:06:33 +08:00
|
|
|
CompInst(0) {
|
|
|
|
if (MigrateDir.empty())
|
|
|
|
MigrateDir = "."; // user current directory if none is given.
|
|
|
|
}
|
|
|
|
|
|
|
|
ASTConsumer *ObjCMigrateAction::CreateASTConsumer(CompilerInstance &CI,
|
|
|
|
StringRef InFile) {
|
2012-12-04 15:27:05 +08:00
|
|
|
PPConditionalDirectiveRecord *
|
|
|
|
PPRec = new PPConditionalDirectiveRecord(CompInst->getSourceManager());
|
|
|
|
CompInst->getPreprocessor().addPPCallbacks(PPRec);
|
2012-03-07 04:06:33 +08:00
|
|
|
ASTConsumer *
|
|
|
|
WrappedConsumer = WrapperFrontendAction::CreateASTConsumer(CI, InFile);
|
|
|
|
ASTConsumer *MTConsumer = new ObjCMigrateASTConsumer(MigrateDir,
|
2013-10-03 01:08:12 +08:00
|
|
|
ObjCMigAction,
|
2012-03-07 04:06:33 +08:00
|
|
|
Remapper,
|
|
|
|
CompInst->getFileManager(),
|
2013-07-04 07:05:00 +08:00
|
|
|
PPRec,
|
|
|
|
CompInst->getPreprocessor());
|
2012-03-07 04:06:33 +08:00
|
|
|
ASTConsumer *Consumers[] = { MTConsumer, WrappedConsumer };
|
|
|
|
return new MultiplexConsumer(Consumers);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ObjCMigrateAction::BeginInvocation(CompilerInstance &CI) {
|
|
|
|
Remapper.initFromDisk(MigrateDir, CI.getDiagnostics(),
|
|
|
|
/*ignoreIfFilesChanges=*/true);
|
|
|
|
CompInst = &CI;
|
|
|
|
CI.getDiagnostics().setIgnoreAllWarnings(true);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class ObjCMigrator : public RecursiveASTVisitor<ObjCMigrator> {
|
|
|
|
ObjCMigrateASTConsumer &Consumer;
|
2013-01-17 07:54:48 +08:00
|
|
|
ParentMap &PMap;
|
2012-03-07 04:06:33 +08:00
|
|
|
|
|
|
|
public:
|
2013-01-17 07:54:48 +08:00
|
|
|
ObjCMigrator(ObjCMigrateASTConsumer &consumer, ParentMap &PMap)
|
|
|
|
: Consumer(consumer), PMap(PMap) { }
|
2012-03-07 04:06:33 +08:00
|
|
|
|
|
|
|
bool shouldVisitTemplateInstantiations() const { return false; }
|
|
|
|
bool shouldWalkTypesOfTypeLocs() const { return false; }
|
|
|
|
|
|
|
|
bool VisitObjCMessageExpr(ObjCMessageExpr *E) {
|
2013-10-03 01:08:12 +08:00
|
|
|
if (Consumer.ASTMigrateActions & FrontendOptions::ObjCMT_Literals) {
|
2012-03-07 04:06:33 +08:00
|
|
|
edit::Commit commit(*Consumer.Editor);
|
2013-01-17 07:54:48 +08:00
|
|
|
edit::rewriteToObjCLiteralSyntax(E, *Consumer.NSAPIObj, commit, &PMap);
|
2012-03-07 04:06:33 +08:00
|
|
|
Consumer.Editor->commit(commit);
|
|
|
|
}
|
|
|
|
|
2013-10-03 01:08:12 +08:00
|
|
|
if (Consumer.ASTMigrateActions & FrontendOptions::ObjCMT_Subscripting) {
|
2012-03-07 04:06:33 +08:00
|
|
|
edit::Commit commit(*Consumer.Editor);
|
|
|
|
edit::rewriteToObjCSubscriptSyntax(E, *Consumer.NSAPIObj, commit);
|
|
|
|
Consumer.Editor->commit(commit);
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool TraverseObjCMessageExpr(ObjCMessageExpr *E) {
|
|
|
|
// Do depth first; we want to rewrite the subexpressions first so that if
|
|
|
|
// we have to move expressions we will move them already rewritten.
|
|
|
|
for (Stmt::child_range range = E->children(); range; ++range)
|
|
|
|
if (!TraverseStmt(*range))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return WalkUpFromObjCMessageExpr(E);
|
|
|
|
}
|
|
|
|
};
|
2013-01-17 07:54:48 +08:00
|
|
|
|
|
|
|
class BodyMigrator : public RecursiveASTVisitor<BodyMigrator> {
|
|
|
|
ObjCMigrateASTConsumer &Consumer;
|
|
|
|
OwningPtr<ParentMap> PMap;
|
|
|
|
|
|
|
|
public:
|
|
|
|
BodyMigrator(ObjCMigrateASTConsumer &consumer) : Consumer(consumer) { }
|
|
|
|
|
|
|
|
bool shouldVisitTemplateInstantiations() const { return false; }
|
|
|
|
bool shouldWalkTypesOfTypeLocs() const { return false; }
|
|
|
|
|
|
|
|
bool TraverseStmt(Stmt *S) {
|
|
|
|
PMap.reset(new ParentMap(S));
|
|
|
|
ObjCMigrator(Consumer, *PMap).TraverseStmt(S);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
};
|
2012-03-07 04:06:33 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void ObjCMigrateASTConsumer::migrateDecl(Decl *D) {
|
|
|
|
if (!D)
|
|
|
|
return;
|
|
|
|
if (isa<ObjCMethodDecl>(D))
|
|
|
|
return; // Wait for the ObjC container declaration.
|
|
|
|
|
2013-01-17 07:54:48 +08:00
|
|
|
BodyMigrator(*this).TraverseDecl(D);
|
2012-03-07 04:06:33 +08:00
|
|
|
}
|
|
|
|
|
2013-10-17 03:48:23 +08:00
|
|
|
static void append_attr(std::string &PropertyString, const char *attr,
|
|
|
|
bool &LParenAdded) {
|
|
|
|
if (!LParenAdded) {
|
|
|
|
PropertyString += "(";
|
|
|
|
LParenAdded = true;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
PropertyString += ", ";
|
2013-08-09 04:51:58 +08:00
|
|
|
PropertyString += attr;
|
|
|
|
}
|
|
|
|
|
2013-10-09 04:14:24 +08:00
|
|
|
static
|
|
|
|
void MigrateBlockOrFunctionPointerTypeVariable(std::string & PropertyString,
|
|
|
|
const std::string& TypeString,
|
|
|
|
const char *name) {
|
|
|
|
const char *argPtr = TypeString.c_str();
|
|
|
|
int paren = 0;
|
|
|
|
while (*argPtr) {
|
|
|
|
switch (*argPtr) {
|
|
|
|
case '(':
|
|
|
|
PropertyString += *argPtr;
|
|
|
|
paren++;
|
|
|
|
break;
|
|
|
|
case ')':
|
|
|
|
PropertyString += *argPtr;
|
|
|
|
paren--;
|
|
|
|
break;
|
|
|
|
case '^':
|
2013-10-09 05:32:16 +08:00
|
|
|
case '*':
|
|
|
|
PropertyString += (*argPtr);
|
|
|
|
if (paren == 1) {
|
2013-10-09 04:14:24 +08:00
|
|
|
PropertyString += name;
|
2013-10-09 05:32:16 +08:00
|
|
|
name = "";
|
|
|
|
}
|
2013-10-09 04:14:24 +08:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
PropertyString += *argPtr;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
argPtr++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-10-17 06:35:19 +08:00
|
|
|
static void rewriteToObjCProperty(const ObjCMethodDecl *Getter,
|
2013-07-19 06:17:33 +08:00
|
|
|
const ObjCMethodDecl *Setter,
|
2013-08-09 04:51:58 +08:00
|
|
|
const NSAPI &NS, edit::Commit &commit,
|
2013-10-10 03:06:08 +08:00
|
|
|
unsigned LengthOfPrefix,
|
|
|
|
bool Atomic) {
|
2013-07-19 06:17:33 +08:00
|
|
|
ASTContext &Context = NS.getASTContext();
|
2013-10-17 03:48:23 +08:00
|
|
|
bool LParenAdded = false;
|
|
|
|
std::string PropertyString = "@property ";
|
|
|
|
if (!Atomic) {
|
|
|
|
PropertyString += "(nonatomic";
|
|
|
|
LParenAdded = true;
|
|
|
|
}
|
|
|
|
|
2013-08-07 02:06:23 +08:00
|
|
|
std::string PropertyNameString = Getter->getNameAsString();
|
|
|
|
StringRef PropertyName(PropertyNameString);
|
2013-09-12 01:05:15 +08:00
|
|
|
if (LengthOfPrefix > 0) {
|
2013-10-17 03:48:23 +08:00
|
|
|
if (!LParenAdded) {
|
|
|
|
PropertyString += "(getter=";
|
|
|
|
LParenAdded = true;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
PropertyString += ", getter=";
|
2013-08-09 04:51:58 +08:00
|
|
|
PropertyString += PropertyNameString;
|
|
|
|
}
|
2013-08-29 07:22:46 +08:00
|
|
|
// Property with no setter may be suggested as a 'readonly' property.
|
2013-10-17 03:48:23 +08:00
|
|
|
if (!Setter) {
|
|
|
|
if (!LParenAdded) {
|
|
|
|
PropertyString += "(readonly";
|
|
|
|
LParenAdded = true;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
append_attr(PropertyString, "readonly", LParenAdded);
|
|
|
|
}
|
2013-10-09 04:14:24 +08:00
|
|
|
|
2013-10-17 02:52:17 +08:00
|
|
|
// Short circuit 'delegate' properties that contain the name "delegate" or
|
|
|
|
// "dataSource", or have exact name "target" to have 'assign' attribute.
|
2013-08-07 02:06:23 +08:00
|
|
|
if (PropertyName.equals("target") ||
|
|
|
|
(PropertyName.find("delegate") != StringRef::npos) ||
|
2013-10-17 04:44:26 +08:00
|
|
|
(PropertyName.find("dataSource") != StringRef::npos)) {
|
|
|
|
QualType QT = Getter->getResultType();
|
|
|
|
if (!QT->isRealType())
|
|
|
|
append_attr(PropertyString, "assign", LParenAdded);
|
|
|
|
}
|
2013-08-29 07:22:46 +08:00
|
|
|
else if (Setter) {
|
2013-08-07 02:06:23 +08:00
|
|
|
const ParmVarDecl *argDecl = *Setter->param_begin();
|
|
|
|
QualType ArgType = Context.getCanonicalType(argDecl->getType());
|
|
|
|
Qualifiers::ObjCLifetime propertyLifetime = ArgType.getObjCLifetime();
|
|
|
|
bool RetainableObject = ArgType->isObjCRetainableType();
|
|
|
|
if (RetainableObject && propertyLifetime == Qualifiers::OCL_Strong) {
|
|
|
|
if (const ObjCObjectPointerType *ObjPtrTy =
|
|
|
|
ArgType->getAs<ObjCObjectPointerType>()) {
|
|
|
|
ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface();
|
|
|
|
if (IDecl &&
|
|
|
|
IDecl->lookupNestedProtocol(&Context.Idents.get("NSCopying")))
|
2013-10-17 03:48:23 +08:00
|
|
|
append_attr(PropertyString, "copy", LParenAdded);
|
2013-08-07 02:06:23 +08:00
|
|
|
else
|
2013-10-17 03:48:23 +08:00
|
|
|
append_attr(PropertyString, "retain", LParenAdded);
|
2013-08-22 02:49:03 +08:00
|
|
|
}
|
2013-10-09 04:14:24 +08:00
|
|
|
else if (ArgType->isBlockPointerType())
|
2013-10-17 03:48:23 +08:00
|
|
|
append_attr(PropertyString, "copy", LParenAdded);
|
2013-08-07 02:06:23 +08:00
|
|
|
} else if (propertyLifetime == Qualifiers::OCL_Weak)
|
|
|
|
// TODO. More precise determination of 'weak' attribute requires
|
|
|
|
// looking into setter's implementation for backing weak ivar.
|
2013-10-17 03:48:23 +08:00
|
|
|
append_attr(PropertyString, "weak", LParenAdded);
|
2013-08-07 02:06:23 +08:00
|
|
|
else if (RetainableObject)
|
2013-10-09 04:14:24 +08:00
|
|
|
append_attr(PropertyString,
|
2013-10-17 03:48:23 +08:00
|
|
|
ArgType->isBlockPointerType() ? "copy" : "retain", LParenAdded);
|
2013-08-07 02:06:23 +08:00
|
|
|
}
|
2013-10-17 03:48:23 +08:00
|
|
|
if (LParenAdded)
|
|
|
|
PropertyString += ')';
|
2013-08-09 04:51:58 +08:00
|
|
|
QualType RT = Getter->getResultType();
|
|
|
|
if (!isa<TypedefType>(RT)) {
|
|
|
|
// strip off any ARC lifetime qualifier.
|
|
|
|
QualType CanResultTy = Context.getCanonicalType(RT);
|
|
|
|
if (CanResultTy.getQualifiers().hasObjCLifetime()) {
|
|
|
|
Qualifiers Qs = CanResultTy.getQualifiers();
|
|
|
|
Qs.removeObjCLifetime();
|
|
|
|
RT = Context.getQualifiedType(CanResultTy.getUnqualifiedType(), Qs);
|
|
|
|
}
|
2013-07-19 06:17:33 +08:00
|
|
|
}
|
|
|
|
PropertyString += " ";
|
2013-10-09 04:14:24 +08:00
|
|
|
PrintingPolicy SubPolicy(Context.getPrintingPolicy());
|
|
|
|
SubPolicy.SuppressStrongLifetime = true;
|
2013-10-10 01:37:28 +08:00
|
|
|
SubPolicy.SuppressLifetimeQualifiers = true;
|
2013-10-09 04:14:24 +08:00
|
|
|
std::string TypeString = RT.getAsString(SubPolicy);
|
2013-09-12 01:05:15 +08:00
|
|
|
if (LengthOfPrefix > 0) {
|
2013-08-09 04:51:58 +08:00
|
|
|
// property name must strip off "is" and lower case the first character
|
|
|
|
// after that; e.g. isContinuous will become continuous.
|
|
|
|
StringRef PropertyNameStringRef(PropertyNameString);
|
2013-09-12 01:05:15 +08:00
|
|
|
PropertyNameStringRef = PropertyNameStringRef.drop_front(LengthOfPrefix);
|
2013-08-09 04:51:58 +08:00
|
|
|
PropertyNameString = PropertyNameStringRef;
|
2013-10-09 04:14:24 +08:00
|
|
|
bool NoLowering = (isUppercase(PropertyNameString[0]) &&
|
|
|
|
PropertyNameString.size() > 1 &&
|
|
|
|
isUppercase(PropertyNameString[1]));
|
2013-09-12 02:27:16 +08:00
|
|
|
if (!NoLowering)
|
2013-10-09 04:14:24 +08:00
|
|
|
PropertyNameString[0] = toLowercase(PropertyNameString[0]);
|
2013-08-09 04:51:58 +08:00
|
|
|
}
|
2013-10-09 04:14:24 +08:00
|
|
|
if (RT->isBlockPointerType() || RT->isFunctionPointerType())
|
|
|
|
MigrateBlockOrFunctionPointerTypeVariable(PropertyString,
|
|
|
|
TypeString,
|
|
|
|
PropertyNameString.c_str());
|
|
|
|
else {
|
|
|
|
char LastChar = TypeString[TypeString.size()-1];
|
|
|
|
PropertyString += TypeString;
|
|
|
|
if (LastChar != '*')
|
|
|
|
PropertyString += ' ';
|
2013-08-09 04:51:58 +08:00
|
|
|
PropertyString += PropertyNameString;
|
2013-10-09 04:14:24 +08:00
|
|
|
}
|
2013-09-07 07:45:20 +08:00
|
|
|
SourceLocation StartGetterSelectorLoc = Getter->getSelectorStartLoc();
|
|
|
|
Selector GetterSelector = Getter->getSelector();
|
|
|
|
|
|
|
|
SourceLocation EndGetterSelectorLoc =
|
|
|
|
StartGetterSelectorLoc.getLocWithOffset(GetterSelector.getNameForSlot(0).size());
|
2013-07-19 06:17:33 +08:00
|
|
|
commit.replace(CharSourceRange::getCharRange(Getter->getLocStart(),
|
2013-09-07 07:45:20 +08:00
|
|
|
EndGetterSelectorLoc),
|
2013-07-19 06:17:33 +08:00
|
|
|
PropertyString);
|
2013-08-29 07:22:46 +08:00
|
|
|
if (Setter) {
|
|
|
|
SourceLocation EndLoc = Setter->getDeclaratorEndLoc();
|
|
|
|
// Get location past ';'
|
|
|
|
EndLoc = EndLoc.getLocWithOffset(1);
|
2013-10-17 06:35:19 +08:00
|
|
|
SourceLocation BeginOfSetterDclLoc = Setter->getLocStart();
|
|
|
|
// FIXME. This assumes that setter decl; is immediately preceeded by eoln.
|
|
|
|
// It is trying to remove the setter method decl. line entirely.
|
|
|
|
BeginOfSetterDclLoc = BeginOfSetterDclLoc.getLocWithOffset(-1);
|
|
|
|
commit.remove(SourceRange(BeginOfSetterDclLoc, EndLoc));
|
2013-08-29 07:22:46 +08:00
|
|
|
}
|
2013-07-19 06:17:33 +08:00
|
|
|
}
|
|
|
|
|
2013-07-04 07:05:00 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateObjCInterfaceDecl(ASTContext &Ctx,
|
2013-09-18 03:00:30 +08:00
|
|
|
ObjCContainerDecl *D) {
|
2013-09-18 05:56:04 +08:00
|
|
|
if (D->isDeprecated())
|
|
|
|
return;
|
|
|
|
|
2013-07-04 07:05:00 +08:00
|
|
|
for (ObjCContainerDecl::method_iterator M = D->meth_begin(), MEnd = D->meth_end();
|
|
|
|
M != MEnd; ++M) {
|
|
|
|
ObjCMethodDecl *Method = (*M);
|
2013-09-18 05:56:04 +08:00
|
|
|
if (Method->isDeprecated())
|
|
|
|
continue;
|
2013-09-25 04:20:52 +08:00
|
|
|
migrateProperty(Ctx, D, Method);
|
2013-10-03 06:49:59 +08:00
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_Annotation)
|
|
|
|
migrateNsReturnsInnerPointer(Ctx, Method);
|
2013-09-25 04:20:52 +08:00
|
|
|
}
|
|
|
|
for (ObjCContainerDecl::prop_iterator P = D->prop_begin(),
|
|
|
|
E = D->prop_end(); P != E; ++P) {
|
|
|
|
ObjCPropertyDecl *Prop = *P;
|
2013-10-03 06:49:59 +08:00
|
|
|
if ((ASTMigrateActions & FrontendOptions::ObjCMT_Annotation) &&
|
|
|
|
!P->isDeprecated())
|
2013-09-25 04:20:52 +08:00
|
|
|
migratePropertyNsReturnsInnerPointer(Ctx, Prop);
|
2013-07-04 07:05:00 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-07-13 08:04:20 +08:00
|
|
|
static bool
|
2013-07-14 01:16:41 +08:00
|
|
|
ClassImplementsAllMethodsAndProperties(ASTContext &Ctx,
|
2013-07-13 08:04:20 +08:00
|
|
|
const ObjCImplementationDecl *ImpDecl,
|
2013-07-16 05:22:08 +08:00
|
|
|
const ObjCInterfaceDecl *IDecl,
|
2013-07-13 08:04:20 +08:00
|
|
|
ObjCProtocolDecl *Protocol) {
|
2013-07-16 05:22:08 +08:00
|
|
|
// In auto-synthesis, protocol properties are not synthesized. So,
|
|
|
|
// a conforming protocol must have its required properties declared
|
|
|
|
// in class interface.
|
2013-07-23 07:50:04 +08:00
|
|
|
bool HasAtleastOneRequiredProperty = false;
|
2013-07-16 05:22:08 +08:00
|
|
|
if (const ObjCProtocolDecl *PDecl = Protocol->getDefinition())
|
|
|
|
for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(),
|
|
|
|
E = PDecl->prop_end(); P != E; ++P) {
|
|
|
|
ObjCPropertyDecl *Property = *P;
|
|
|
|
if (Property->getPropertyImplementation() == ObjCPropertyDecl::Optional)
|
|
|
|
continue;
|
2013-07-23 07:50:04 +08:00
|
|
|
HasAtleastOneRequiredProperty = true;
|
2013-07-16 05:22:08 +08:00
|
|
|
DeclContext::lookup_const_result R = IDecl->lookup(Property->getDeclName());
|
2013-07-17 05:59:42 +08:00
|
|
|
if (R.size() == 0) {
|
|
|
|
// Relax the rule and look into class's implementation for a synthesize
|
|
|
|
// or dynamic declaration. Class is implementing a property coming from
|
|
|
|
// another protocol. This still makes the target protocol as conforming.
|
|
|
|
if (!ImpDecl->FindPropertyImplDecl(
|
|
|
|
Property->getDeclName().getAsIdentifierInfo()))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
else if (ObjCPropertyDecl *ClassProperty = dyn_cast<ObjCPropertyDecl>(R[0])) {
|
|
|
|
if ((ClassProperty->getPropertyAttributes()
|
|
|
|
!= Property->getPropertyAttributes()) ||
|
|
|
|
!Ctx.hasSameType(ClassProperty->getType(), Property->getType()))
|
2013-07-16 05:22:08 +08:00
|
|
|
return false;
|
|
|
|
}
|
2013-07-17 05:59:42 +08:00
|
|
|
else
|
|
|
|
return false;
|
2013-07-16 05:22:08 +08:00
|
|
|
}
|
2013-07-23 07:50:04 +08:00
|
|
|
|
2013-07-16 05:22:08 +08:00
|
|
|
// At this point, all required properties in this protocol conform to those
|
|
|
|
// declared in the class.
|
|
|
|
// Check that class implements the required methods of the protocol too.
|
2013-07-23 07:50:04 +08:00
|
|
|
bool HasAtleastOneRequiredMethod = false;
|
2013-07-16 08:20:21 +08:00
|
|
|
if (const ObjCProtocolDecl *PDecl = Protocol->getDefinition()) {
|
|
|
|
if (PDecl->meth_begin() == PDecl->meth_end())
|
2013-07-23 07:50:04 +08:00
|
|
|
return HasAtleastOneRequiredProperty;
|
2013-07-16 05:22:08 +08:00
|
|
|
for (ObjCContainerDecl::method_iterator M = PDecl->meth_begin(),
|
|
|
|
MEnd = PDecl->meth_end(); M != MEnd; ++M) {
|
|
|
|
ObjCMethodDecl *MD = (*M);
|
2013-07-16 08:20:21 +08:00
|
|
|
if (MD->isImplicit())
|
|
|
|
continue;
|
2013-07-16 05:22:08 +08:00
|
|
|
if (MD->getImplementationControl() == ObjCMethodDecl::Optional)
|
|
|
|
continue;
|
|
|
|
DeclContext::lookup_const_result R = ImpDecl->lookup(MD->getDeclName());
|
2013-07-16 08:20:21 +08:00
|
|
|
if (R.size() == 0)
|
|
|
|
return false;
|
2013-07-23 07:50:04 +08:00
|
|
|
bool match = false;
|
|
|
|
HasAtleastOneRequiredMethod = true;
|
2013-07-16 05:22:08 +08:00
|
|
|
for (unsigned I = 0, N = R.size(); I != N; ++I)
|
|
|
|
if (ObjCMethodDecl *ImpMD = dyn_cast<ObjCMethodDecl>(R[0]))
|
|
|
|
if (Ctx.ObjCMethodsAreEqual(MD, ImpMD)) {
|
|
|
|
match = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (!match)
|
|
|
|
return false;
|
|
|
|
}
|
2013-07-16 08:20:21 +08:00
|
|
|
}
|
2013-07-23 07:50:04 +08:00
|
|
|
if (HasAtleastOneRequiredProperty || HasAtleastOneRequiredMethod)
|
|
|
|
return true;
|
|
|
|
return false;
|
2013-07-13 08:04:20 +08:00
|
|
|
}
|
|
|
|
|
2013-07-19 06:17:33 +08:00
|
|
|
static bool rewriteToObjCInterfaceDecl(const ObjCInterfaceDecl *IDecl,
|
|
|
|
llvm::SmallVectorImpl<ObjCProtocolDecl*> &ConformingProtocols,
|
|
|
|
const NSAPI &NS, edit::Commit &commit) {
|
|
|
|
const ObjCList<ObjCProtocolDecl> &Protocols = IDecl->getReferencedProtocols();
|
|
|
|
std::string ClassString;
|
|
|
|
SourceLocation EndLoc =
|
|
|
|
IDecl->getSuperClass() ? IDecl->getSuperClassLoc() : IDecl->getLocation();
|
|
|
|
|
|
|
|
if (Protocols.empty()) {
|
|
|
|
ClassString = '<';
|
|
|
|
for (unsigned i = 0, e = ConformingProtocols.size(); i != e; i++) {
|
|
|
|
ClassString += ConformingProtocols[i]->getNameAsString();
|
|
|
|
if (i != (e-1))
|
|
|
|
ClassString += ", ";
|
|
|
|
}
|
|
|
|
ClassString += "> ";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
ClassString = ", ";
|
|
|
|
for (unsigned i = 0, e = ConformingProtocols.size(); i != e; i++) {
|
|
|
|
ClassString += ConformingProtocols[i]->getNameAsString();
|
|
|
|
if (i != (e-1))
|
|
|
|
ClassString += ", ";
|
|
|
|
}
|
|
|
|
ObjCInterfaceDecl::protocol_loc_iterator PL = IDecl->protocol_loc_end() - 1;
|
|
|
|
EndLoc = *PL;
|
|
|
|
}
|
|
|
|
|
|
|
|
commit.insertAfterToken(EndLoc, ClassString);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool rewriteToNSEnumDecl(const EnumDecl *EnumDcl,
|
|
|
|
const TypedefDecl *TypedefDcl,
|
2013-07-19 09:05:49 +08:00
|
|
|
const NSAPI &NS, edit::Commit &commit,
|
2013-08-31 01:46:01 +08:00
|
|
|
bool IsNSIntegerType,
|
|
|
|
bool NSOptions) {
|
|
|
|
std::string ClassString;
|
|
|
|
if (NSOptions)
|
|
|
|
ClassString = "typedef NS_OPTIONS(NSUInteger, ";
|
|
|
|
else
|
|
|
|
ClassString =
|
|
|
|
IsNSIntegerType ? "typedef NS_ENUM(NSInteger, "
|
|
|
|
: "typedef NS_ENUM(NSUInteger, ";
|
|
|
|
|
2013-07-19 06:17:33 +08:00
|
|
|
ClassString += TypedefDcl->getIdentifier()->getName();
|
|
|
|
ClassString += ')';
|
|
|
|
SourceRange R(EnumDcl->getLocStart(), EnumDcl->getLocStart());
|
|
|
|
commit.replace(R, ClassString);
|
2013-10-15 08:00:28 +08:00
|
|
|
SourceLocation EndOfEnumDclLoc = EnumDcl->getLocEnd();
|
|
|
|
EndOfEnumDclLoc = trans::findSemiAfterLocation(EndOfEnumDclLoc,
|
|
|
|
NS.getASTContext(), /*IsDecl*/true);
|
|
|
|
if (!EndOfEnumDclLoc.isInvalid()) {
|
|
|
|
SourceRange EnumDclRange(EnumDcl->getLocStart(), EndOfEnumDclLoc);
|
|
|
|
commit.insertFromRange(TypedefDcl->getLocStart(), EnumDclRange);
|
|
|
|
}
|
|
|
|
else
|
|
|
|
return false;
|
|
|
|
|
|
|
|
SourceLocation EndTypedefDclLoc = TypedefDcl->getLocEnd();
|
|
|
|
EndTypedefDclLoc = trans::findSemiAfterLocation(EndTypedefDclLoc,
|
|
|
|
NS.getASTContext(), /*IsDecl*/true);
|
|
|
|
if (!EndTypedefDclLoc.isInvalid()) {
|
|
|
|
SourceRange TDRange(TypedefDcl->getLocStart(), EndTypedefDclLoc);
|
|
|
|
commit.remove(TDRange);
|
|
|
|
}
|
|
|
|
else
|
|
|
|
return false;
|
|
|
|
|
|
|
|
EndOfEnumDclLoc = trans::findLocationAfterSemi(EnumDcl->getLocEnd(), NS.getASTContext(),
|
2013-10-12 01:35:22 +08:00
|
|
|
/*IsDecl*/true);
|
2013-10-15 08:00:28 +08:00
|
|
|
if (!EndOfEnumDclLoc.isInvalid()) {
|
|
|
|
SourceLocation BeginOfEnumDclLoc = EnumDcl->getLocStart();
|
|
|
|
// FIXME. This assumes that enum decl; is immediately preceeded by eoln.
|
|
|
|
// It is trying to remove the enum decl. lines entirely.
|
|
|
|
BeginOfEnumDclLoc = BeginOfEnumDclLoc.getLocWithOffset(-1);
|
|
|
|
commit.remove(SourceRange(BeginOfEnumDclLoc, EndOfEnumDclLoc));
|
2013-07-19 06:17:33 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-10-18 07:13:13 +08:00
|
|
|
static void rewriteToNSMacroDecl(const EnumDecl *EnumDcl,
|
2013-07-20 04:18:36 +08:00
|
|
|
const TypedefDecl *TypedefDcl,
|
2013-07-23 02:53:45 +08:00
|
|
|
const NSAPI &NS, edit::Commit &commit,
|
|
|
|
bool IsNSIntegerType) {
|
|
|
|
std::string ClassString =
|
|
|
|
IsNSIntegerType ? "NS_ENUM(NSInteger, " : "NS_OPTIONS(NSUInteger, ";
|
2013-07-20 04:18:36 +08:00
|
|
|
ClassString += TypedefDcl->getIdentifier()->getName();
|
|
|
|
ClassString += ')';
|
|
|
|
SourceRange R(EnumDcl->getLocStart(), EnumDcl->getLocStart());
|
|
|
|
commit.replace(R, ClassString);
|
|
|
|
SourceLocation TypedefLoc = TypedefDcl->getLocEnd();
|
|
|
|
commit.remove(SourceRange(TypedefLoc, TypedefLoc));
|
|
|
|
}
|
|
|
|
|
2013-08-30 08:10:37 +08:00
|
|
|
static bool UseNSOptionsMacro(Preprocessor &PP, ASTContext &Ctx,
|
2013-07-23 02:53:45 +08:00
|
|
|
const EnumDecl *EnumDcl) {
|
|
|
|
bool PowerOfTwo = true;
|
2013-09-24 04:27:06 +08:00
|
|
|
bool AllHexdecimalEnumerator = true;
|
2013-08-16 02:46:37 +08:00
|
|
|
uint64_t MaxPowerOfTwoVal = 0;
|
2013-07-23 02:53:45 +08:00
|
|
|
for (EnumDecl::enumerator_iterator EI = EnumDcl->enumerator_begin(),
|
|
|
|
EE = EnumDcl->enumerator_end(); EI != EE; ++EI) {
|
|
|
|
EnumConstantDecl *Enumerator = (*EI);
|
|
|
|
const Expr *InitExpr = Enumerator->getInitExpr();
|
|
|
|
if (!InitExpr) {
|
|
|
|
PowerOfTwo = false;
|
2013-09-24 04:27:06 +08:00
|
|
|
AllHexdecimalEnumerator = false;
|
2013-07-23 02:53:45 +08:00
|
|
|
continue;
|
|
|
|
}
|
2013-09-18 07:32:51 +08:00
|
|
|
InitExpr = InitExpr->IgnoreParenCasts();
|
2013-07-23 02:53:45 +08:00
|
|
|
if (const BinaryOperator *BO = dyn_cast<BinaryOperator>(InitExpr))
|
|
|
|
if (BO->isShiftOp() || BO->isBitwiseOp())
|
|
|
|
return true;
|
|
|
|
|
|
|
|
uint64_t EnumVal = Enumerator->getInitVal().getZExtValue();
|
2013-08-16 02:46:37 +08:00
|
|
|
if (PowerOfTwo && EnumVal) {
|
|
|
|
if (!llvm::isPowerOf2_64(EnumVal))
|
|
|
|
PowerOfTwo = false;
|
|
|
|
else if (EnumVal > MaxPowerOfTwoVal)
|
|
|
|
MaxPowerOfTwoVal = EnumVal;
|
|
|
|
}
|
2013-09-24 04:27:06 +08:00
|
|
|
if (AllHexdecimalEnumerator && EnumVal) {
|
|
|
|
bool FoundHexdecimalEnumerator = false;
|
2013-08-30 08:10:37 +08:00
|
|
|
SourceLocation EndLoc = Enumerator->getLocEnd();
|
|
|
|
Token Tok;
|
|
|
|
if (!PP.getRawToken(EndLoc, Tok, /*IgnoreWhiteSpace=*/true))
|
|
|
|
if (Tok.isLiteral() && Tok.getLength() > 2) {
|
|
|
|
if (const char *StringLit = Tok.getLiteralData())
|
|
|
|
FoundHexdecimalEnumerator =
|
|
|
|
(StringLit[0] == '0' && (toLowercase(StringLit[1]) == 'x'));
|
|
|
|
}
|
2013-09-24 04:27:06 +08:00
|
|
|
if (!FoundHexdecimalEnumerator)
|
|
|
|
AllHexdecimalEnumerator = false;
|
2013-08-30 08:10:37 +08:00
|
|
|
}
|
2013-07-23 02:53:45 +08:00
|
|
|
}
|
2013-09-24 04:27:06 +08:00
|
|
|
return AllHexdecimalEnumerator || (PowerOfTwo && (MaxPowerOfTwoVal > 2));
|
2013-07-23 02:53:45 +08:00
|
|
|
}
|
|
|
|
|
2013-07-20 01:44:32 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateProtocolConformance(ASTContext &Ctx,
|
2013-07-13 06:32:19 +08:00
|
|
|
const ObjCImplementationDecl *ImpDecl) {
|
|
|
|
const ObjCInterfaceDecl *IDecl = ImpDecl->getClassInterface();
|
2013-09-18 05:56:04 +08:00
|
|
|
if (!IDecl || ObjCProtocolDecls.empty() || IDecl->isDeprecated())
|
2013-07-13 06:32:19 +08:00
|
|
|
return;
|
|
|
|
// Find all implicit conforming protocols for this class
|
|
|
|
// and make them explicit.
|
|
|
|
llvm::SmallPtrSet<ObjCProtocolDecl *, 8> ExplicitProtocols;
|
|
|
|
Ctx.CollectInheritedProtocols(IDecl, ExplicitProtocols);
|
2013-07-13 08:04:20 +08:00
|
|
|
llvm::SmallVector<ObjCProtocolDecl *, 8> PotentialImplicitProtocols;
|
2013-07-13 06:32:19 +08:00
|
|
|
|
2013-07-13 08:04:20 +08:00
|
|
|
for (llvm::SmallPtrSet<ObjCProtocolDecl*, 32>::iterator I =
|
2013-07-13 06:32:19 +08:00
|
|
|
ObjCProtocolDecls.begin(),
|
|
|
|
E = ObjCProtocolDecls.end(); I != E; ++I)
|
|
|
|
if (!ExplicitProtocols.count(*I))
|
2013-07-13 08:04:20 +08:00
|
|
|
PotentialImplicitProtocols.push_back(*I);
|
2013-07-13 06:32:19 +08:00
|
|
|
|
|
|
|
if (PotentialImplicitProtocols.empty())
|
|
|
|
return;
|
2013-07-13 08:04:20 +08:00
|
|
|
|
|
|
|
// go through list of non-optional methods and properties in each protocol
|
|
|
|
// in the PotentialImplicitProtocols list. If class implements every one of the
|
|
|
|
// methods and properties, then this class conforms to this protocol.
|
|
|
|
llvm::SmallVector<ObjCProtocolDecl*, 8> ConformingProtocols;
|
|
|
|
for (unsigned i = 0, e = PotentialImplicitProtocols.size(); i != e; i++)
|
2013-07-16 05:22:08 +08:00
|
|
|
if (ClassImplementsAllMethodsAndProperties(Ctx, ImpDecl, IDecl,
|
2013-07-13 08:04:20 +08:00
|
|
|
PotentialImplicitProtocols[i]))
|
|
|
|
ConformingProtocols.push_back(PotentialImplicitProtocols[i]);
|
2013-07-16 08:20:21 +08:00
|
|
|
|
|
|
|
if (ConformingProtocols.empty())
|
|
|
|
return;
|
2013-07-17 08:02:22 +08:00
|
|
|
|
|
|
|
// Further reduce number of conforming protocols. If protocol P1 is in the list
|
|
|
|
// protocol P2 (P2<P1>), No need to include P1.
|
|
|
|
llvm::SmallVector<ObjCProtocolDecl*, 8> MinimalConformingProtocols;
|
|
|
|
for (unsigned i = 0, e = ConformingProtocols.size(); i != e; i++) {
|
|
|
|
bool DropIt = false;
|
|
|
|
ObjCProtocolDecl *TargetPDecl = ConformingProtocols[i];
|
|
|
|
for (unsigned i1 = 0, e1 = ConformingProtocols.size(); i1 != e1; i1++) {
|
|
|
|
ObjCProtocolDecl *PDecl = ConformingProtocols[i1];
|
|
|
|
if (PDecl == TargetPDecl)
|
|
|
|
continue;
|
|
|
|
if (PDecl->lookupProtocolNamed(
|
|
|
|
TargetPDecl->getDeclName().getAsIdentifierInfo())) {
|
|
|
|
DropIt = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!DropIt)
|
|
|
|
MinimalConformingProtocols.push_back(TargetPDecl);
|
|
|
|
}
|
2013-07-16 08:20:21 +08:00
|
|
|
edit::Commit commit(*Editor);
|
2013-07-19 06:17:33 +08:00
|
|
|
rewriteToObjCInterfaceDecl(IDecl, MinimalConformingProtocols,
|
|
|
|
*NSAPIObj, commit);
|
2013-07-16 08:20:21 +08:00
|
|
|
Editor->commit(commit);
|
2013-07-13 06:32:19 +08:00
|
|
|
}
|
|
|
|
|
2013-10-15 08:00:28 +08:00
|
|
|
void ObjCMigrateASTConsumer::CacheObjCNSIntegerTypedefed(
|
|
|
|
const TypedefDecl *TypedefDcl) {
|
|
|
|
|
|
|
|
QualType qt = TypedefDcl->getTypeSourceInfo()->getType();
|
|
|
|
if (NSAPIObj->isObjCNSIntegerType(qt))
|
|
|
|
NSIntegerTypedefed = TypedefDcl;
|
|
|
|
else if (NSAPIObj->isObjCNSUIntegerType(qt))
|
|
|
|
NSUIntegerTypedefed = TypedefDcl;
|
|
|
|
}
|
|
|
|
|
2013-10-12 05:34:56 +08:00
|
|
|
bool ObjCMigrateASTConsumer::migrateNSEnumDecl(ASTContext &Ctx,
|
2013-07-19 04:11:45 +08:00
|
|
|
const EnumDecl *EnumDcl,
|
|
|
|
const TypedefDecl *TypedefDcl) {
|
|
|
|
if (!EnumDcl->isCompleteDefinition() || EnumDcl->getIdentifier() ||
|
2013-10-15 08:00:28 +08:00
|
|
|
EnumDcl->isDeprecated())
|
|
|
|
return false;
|
|
|
|
if (!TypedefDcl) {
|
|
|
|
if (NSIntegerTypedefed) {
|
|
|
|
TypedefDcl = NSIntegerTypedefed;
|
|
|
|
NSIntegerTypedefed = 0;
|
|
|
|
}
|
|
|
|
else if (NSUIntegerTypedefed) {
|
|
|
|
TypedefDcl = NSUIntegerTypedefed;
|
|
|
|
NSUIntegerTypedefed = 0;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
return false;
|
|
|
|
unsigned FileIdOfTypedefDcl =
|
|
|
|
PP.getSourceManager().getFileID(TypedefDcl->getLocation()).getHashValue();
|
|
|
|
unsigned FileIdOfEnumDcl =
|
|
|
|
PP.getSourceManager().getFileID(EnumDcl->getLocation()).getHashValue();
|
|
|
|
if (FileIdOfTypedefDcl != FileIdOfEnumDcl)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
if (TypedefDcl->isDeprecated())
|
2013-10-12 05:34:56 +08:00
|
|
|
return false;
|
2013-07-19 04:11:45 +08:00
|
|
|
|
|
|
|
QualType qt = TypedefDcl->getTypeSourceInfo()->getType();
|
2013-07-19 09:05:49 +08:00
|
|
|
bool IsNSIntegerType = NSAPIObj->isObjCNSIntegerType(qt);
|
|
|
|
bool IsNSUIntegerType = !IsNSIntegerType && NSAPIObj->isObjCNSUIntegerType(qt);
|
2013-07-23 02:53:45 +08:00
|
|
|
|
2013-07-20 04:18:36 +08:00
|
|
|
if (!IsNSIntegerType && !IsNSUIntegerType) {
|
|
|
|
// Also check for typedef enum {...} TD;
|
|
|
|
if (const EnumType *EnumTy = qt->getAs<EnumType>()) {
|
|
|
|
if (EnumTy->getDecl() == EnumDcl) {
|
2013-08-30 08:10:37 +08:00
|
|
|
bool NSOptions = UseNSOptionsMacro(PP, Ctx, EnumDcl);
|
2013-07-23 02:53:45 +08:00
|
|
|
if (NSOptions) {
|
|
|
|
if (!Ctx.Idents.get("NS_OPTIONS").hasMacroDefinition())
|
2013-10-12 05:34:56 +08:00
|
|
|
return false;
|
2013-07-23 02:53:45 +08:00
|
|
|
}
|
|
|
|
else if (!Ctx.Idents.get("NS_ENUM").hasMacroDefinition())
|
2013-10-12 05:34:56 +08:00
|
|
|
return false;
|
2013-07-20 04:18:36 +08:00
|
|
|
edit::Commit commit(*Editor);
|
2013-07-23 02:53:45 +08:00
|
|
|
rewriteToNSMacroDecl(EnumDcl, TypedefDcl, *NSAPIObj, commit, !NSOptions);
|
2013-07-20 04:18:36 +08:00
|
|
|
Editor->commit(commit);
|
2013-10-18 06:23:32 +08:00
|
|
|
return true;
|
2013-07-20 04:18:36 +08:00
|
|
|
}
|
|
|
|
}
|
2013-10-12 05:34:56 +08:00
|
|
|
return false;
|
2013-07-23 02:53:45 +08:00
|
|
|
}
|
2013-07-19 04:11:45 +08:00
|
|
|
|
2013-08-31 01:46:01 +08:00
|
|
|
// We may still use NS_OPTIONS based on what we find in the enumertor list.
|
|
|
|
bool NSOptions = UseNSOptionsMacro(PP, Ctx, EnumDcl);
|
2013-07-19 04:11:45 +08:00
|
|
|
// NS_ENUM must be available.
|
2013-07-19 09:05:49 +08:00
|
|
|
if (IsNSIntegerType && !Ctx.Idents.get("NS_ENUM").hasMacroDefinition())
|
2013-10-12 05:34:56 +08:00
|
|
|
return false;
|
2013-07-19 09:05:49 +08:00
|
|
|
// NS_OPTIONS must be available.
|
|
|
|
if (IsNSUIntegerType && !Ctx.Idents.get("NS_OPTIONS").hasMacroDefinition())
|
2013-10-12 05:34:56 +08:00
|
|
|
return false;
|
2013-07-19 04:11:45 +08:00
|
|
|
edit::Commit commit(*Editor);
|
2013-10-15 08:00:28 +08:00
|
|
|
bool Res = rewriteToNSEnumDecl(EnumDcl, TypedefDcl, *NSAPIObj,
|
|
|
|
commit, IsNSIntegerType, NSOptions);
|
2013-07-19 04:11:45 +08:00
|
|
|
Editor->commit(commit);
|
2013-10-15 08:00:28 +08:00
|
|
|
return Res;
|
2013-07-19 04:11:45 +08:00
|
|
|
}
|
|
|
|
|
2013-08-03 02:00:53 +08:00
|
|
|
static void ReplaceWithInstancetype(const ObjCMigrateASTConsumer &ASTC,
|
|
|
|
ObjCMethodDecl *OM) {
|
|
|
|
SourceRange R;
|
|
|
|
std::string ClassString;
|
|
|
|
if (TypeSourceInfo *TSInfo = OM->getResultTypeSourceInfo()) {
|
|
|
|
TypeLoc TL = TSInfo->getTypeLoc();
|
|
|
|
R = SourceRange(TL.getBeginLoc(), TL.getEndLoc());
|
|
|
|
ClassString = "instancetype";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
R = SourceRange(OM->getLocStart(), OM->getLocStart());
|
|
|
|
ClassString = OM->isInstanceMethod() ? '-' : '+';
|
|
|
|
ClassString += " (instancetype)";
|
|
|
|
}
|
|
|
|
edit::Commit commit(*ASTC.Editor);
|
|
|
|
commit.replace(R, ClassString);
|
|
|
|
ASTC.Editor->commit(commit);
|
|
|
|
}
|
|
|
|
|
2013-10-11 02:23:13 +08:00
|
|
|
static void ReplaceWithClasstype(const ObjCMigrateASTConsumer &ASTC,
|
|
|
|
ObjCMethodDecl *OM) {
|
|
|
|
ObjCInterfaceDecl *IDecl = OM->getClassInterface();
|
|
|
|
SourceRange R;
|
|
|
|
std::string ClassString;
|
|
|
|
if (TypeSourceInfo *TSInfo = OM->getResultTypeSourceInfo()) {
|
|
|
|
TypeLoc TL = TSInfo->getTypeLoc();
|
|
|
|
R = SourceRange(TL.getBeginLoc(), TL.getEndLoc()); {
|
|
|
|
ClassString = IDecl->getName();
|
|
|
|
ClassString += "*";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
R = SourceRange(OM->getLocStart(), OM->getLocStart());
|
|
|
|
ClassString = "+ (";
|
|
|
|
ClassString += IDecl->getName(); ClassString += "*)";
|
|
|
|
}
|
|
|
|
edit::Commit commit(*ASTC.Editor);
|
|
|
|
commit.replace(R, ClassString);
|
|
|
|
ASTC.Editor->commit(commit);
|
|
|
|
}
|
|
|
|
|
2013-07-24 07:34:42 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateMethodInstanceType(ASTContext &Ctx,
|
|
|
|
ObjCContainerDecl *CDecl,
|
|
|
|
ObjCMethodDecl *OM) {
|
2013-07-24 06:42:28 +08:00
|
|
|
ObjCInstanceTypeFamily OIT_Family =
|
|
|
|
Selector::getInstTypeMethodFamily(OM->getSelector());
|
2013-08-03 04:54:18 +08:00
|
|
|
|
2013-07-25 03:18:37 +08:00
|
|
|
std::string ClassName;
|
2013-07-24 07:55:55 +08:00
|
|
|
switch (OIT_Family) {
|
2013-08-03 04:54:18 +08:00
|
|
|
case OIT_None:
|
|
|
|
migrateFactoryMethod(Ctx, CDecl, OM);
|
|
|
|
return;
|
2013-08-29 05:23:00 +08:00
|
|
|
case OIT_Array:
|
|
|
|
ClassName = "NSArray";
|
|
|
|
break;
|
|
|
|
case OIT_Dictionary:
|
|
|
|
ClassName = "NSDictionary";
|
|
|
|
break;
|
2013-08-03 04:54:18 +08:00
|
|
|
case OIT_Singleton:
|
|
|
|
migrateFactoryMethod(Ctx, CDecl, OM, OIT_Singleton);
|
2013-07-24 07:55:55 +08:00
|
|
|
return;
|
2013-09-19 04:35:47 +08:00
|
|
|
case OIT_Init:
|
|
|
|
if (OM->getResultType()->isObjCIdType())
|
|
|
|
ReplaceWithInstancetype(*this, OM);
|
|
|
|
return;
|
2013-10-11 02:23:13 +08:00
|
|
|
case OIT_ReturnsSelf:
|
|
|
|
migrateFactoryMethod(Ctx, CDecl, OM, OIT_ReturnsSelf);
|
|
|
|
return;
|
2013-07-24 07:55:55 +08:00
|
|
|
}
|
2013-07-24 06:42:28 +08:00
|
|
|
if (!OM->getResultType()->isObjCIdType())
|
|
|
|
return;
|
|
|
|
|
|
|
|
ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl);
|
|
|
|
if (!IDecl) {
|
|
|
|
if (ObjCCategoryDecl *CatDecl = dyn_cast<ObjCCategoryDecl>(CDecl))
|
|
|
|
IDecl = CatDecl->getClassInterface();
|
|
|
|
else if (ObjCImplDecl *ImpDecl = dyn_cast<ObjCImplDecl>(CDecl))
|
|
|
|
IDecl = ImpDecl->getClassInterface();
|
|
|
|
}
|
2013-07-25 03:18:37 +08:00
|
|
|
if (!IDecl ||
|
2013-08-03 02:00:53 +08:00
|
|
|
!IDecl->lookupInheritedClass(&Ctx.Idents.get(ClassName))) {
|
|
|
|
migrateFactoryMethod(Ctx, CDecl, OM);
|
2013-07-24 06:42:28 +08:00
|
|
|
return;
|
2013-08-02 08:01:14 +08:00
|
|
|
}
|
2013-08-03 02:00:53 +08:00
|
|
|
ReplaceWithInstancetype(*this, OM);
|
2013-07-24 06:42:28 +08:00
|
|
|
}
|
|
|
|
|
2013-08-31 07:52:08 +08:00
|
|
|
static bool TypeIsInnerPointer(QualType T) {
|
|
|
|
if (!T->isAnyPointerType())
|
|
|
|
return false;
|
|
|
|
if (T->isObjCObjectPointerType() || T->isObjCBuiltinType() ||
|
2013-09-27 05:43:47 +08:00
|
|
|
T->isBlockPointerType() || T->isFunctionPointerType() ||
|
|
|
|
ento::coreFoundation::isCFObjectRef(T))
|
2013-08-31 07:52:08 +08:00
|
|
|
return false;
|
2013-09-10 07:56:14 +08:00
|
|
|
// Also, typedef-of-pointer-to-incomplete-struct is something that we assume
|
|
|
|
// is not an innter pointer type.
|
|
|
|
QualType OrigT = T;
|
|
|
|
while (const TypedefType *TD = dyn_cast<TypedefType>(T.getTypePtr()))
|
|
|
|
T = TD->getDecl()->getUnderlyingType();
|
|
|
|
if (OrigT == T || !T->isPointerType())
|
|
|
|
return true;
|
|
|
|
const PointerType* PT = T->getAs<PointerType>();
|
|
|
|
QualType UPointeeT = PT->getPointeeType().getUnqualifiedType();
|
|
|
|
if (UPointeeT->isRecordType()) {
|
|
|
|
const RecordType *RecordTy = UPointeeT->getAs<RecordType>();
|
|
|
|
if (!RecordTy->getDecl()->isCompleteDefinition())
|
|
|
|
return false;
|
|
|
|
}
|
2013-08-31 07:52:08 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2013-09-19 01:22:25 +08:00
|
|
|
static bool AttributesMatch(const Decl *Decl1, const Decl *Decl2) {
|
|
|
|
if (Decl1->hasAttrs() != Decl2->hasAttrs())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (!Decl1->hasAttrs())
|
|
|
|
return true;
|
|
|
|
|
|
|
|
const AttrVec &Attrs1 = Decl1->getAttrs();
|
|
|
|
const AttrVec &Attrs2 = Decl2->getAttrs();
|
|
|
|
// This list is very small, so this need not be optimized.
|
|
|
|
for (unsigned i = 0, e = Attrs1.size(); i != e; i++) {
|
|
|
|
bool match = false;
|
|
|
|
for (unsigned j = 0, f = Attrs2.size(); j != f; j++) {
|
|
|
|
// Matching attribute kind only. We are not getting into
|
|
|
|
// details of the attributes. For all practical purposes
|
|
|
|
// this is sufficient.
|
|
|
|
if (Attrs1[i]->getKind() == Attrs2[j]->getKind()) {
|
|
|
|
match = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!match)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2013-09-28 06:55:54 +08:00
|
|
|
static bool IsValidIdentifier(ASTContext &Ctx,
|
|
|
|
const char *Name) {
|
|
|
|
if (!isIdentifierHead(Name[0]))
|
|
|
|
return false;
|
|
|
|
std::string NameString = Name;
|
|
|
|
NameString[0] = toLowercase(NameString[0]);
|
|
|
|
IdentifierInfo *II = &Ctx.Idents.get(NameString);
|
|
|
|
return II->getTokenID() == tok::identifier;
|
|
|
|
}
|
|
|
|
|
2013-09-07 07:45:20 +08:00
|
|
|
bool ObjCMigrateASTConsumer::migrateProperty(ASTContext &Ctx,
|
2013-09-18 03:00:30 +08:00
|
|
|
ObjCContainerDecl *D,
|
2013-09-07 07:45:20 +08:00
|
|
|
ObjCMethodDecl *Method) {
|
|
|
|
if (Method->isPropertyAccessor() || !Method->isInstanceMethod() ||
|
|
|
|
Method->param_size() != 0)
|
|
|
|
return false;
|
|
|
|
// Is this method candidate to be a getter?
|
|
|
|
QualType GRT = Method->getResultType();
|
|
|
|
if (GRT->isVoidType())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
Selector GetterSelector = Method->getSelector();
|
2013-09-25 08:17:07 +08:00
|
|
|
ObjCInstanceTypeFamily OIT_Family =
|
|
|
|
Selector::getInstTypeMethodFamily(GetterSelector);
|
|
|
|
|
|
|
|
if (OIT_Family != OIT_None)
|
|
|
|
return false;
|
|
|
|
|
2013-09-07 07:45:20 +08:00
|
|
|
IdentifierInfo *getterName = GetterSelector.getIdentifierInfoForSlot(0);
|
|
|
|
Selector SetterSelector =
|
|
|
|
SelectorTable::constructSetterSelector(PP.getIdentifierTable(),
|
|
|
|
PP.getSelectorTable(),
|
|
|
|
getterName);
|
2013-09-18 03:00:30 +08:00
|
|
|
ObjCMethodDecl *SetterMethod = D->getInstanceMethod(SetterSelector);
|
2013-09-12 01:05:15 +08:00
|
|
|
unsigned LengthOfPrefix = 0;
|
2013-09-07 07:45:20 +08:00
|
|
|
if (!SetterMethod) {
|
|
|
|
// try a different naming convention for getter: isXxxxx
|
|
|
|
StringRef getterNameString = getterName->getName();
|
2013-09-12 01:05:15 +08:00
|
|
|
bool IsPrefix = getterNameString.startswith("is");
|
2013-09-18 03:38:55 +08:00
|
|
|
// Note that we don't want to change an isXXX method of retainable object
|
|
|
|
// type to property (readonly or otherwise).
|
|
|
|
if (IsPrefix && GRT->isObjCRetainableType())
|
|
|
|
return false;
|
|
|
|
if (IsPrefix || getterNameString.startswith("get")) {
|
2013-09-12 01:05:15 +08:00
|
|
|
LengthOfPrefix = (IsPrefix ? 2 : 3);
|
|
|
|
const char *CGetterName = getterNameString.data() + LengthOfPrefix;
|
|
|
|
// Make sure that first character after "is" or "get" prefix can
|
|
|
|
// start an identifier.
|
2013-09-28 06:55:54 +08:00
|
|
|
if (!IsValidIdentifier(Ctx, CGetterName))
|
2013-09-12 01:05:15 +08:00
|
|
|
return false;
|
2013-09-07 07:45:20 +08:00
|
|
|
if (CGetterName[0] && isUppercase(CGetterName[0])) {
|
|
|
|
getterName = &Ctx.Idents.get(CGetterName);
|
|
|
|
SetterSelector =
|
|
|
|
SelectorTable::constructSetterSelector(PP.getIdentifierTable(),
|
|
|
|
PP.getSelectorTable(),
|
|
|
|
getterName);
|
2013-09-18 03:00:30 +08:00
|
|
|
SetterMethod = D->getInstanceMethod(SetterSelector);
|
2013-09-07 07:45:20 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2013-09-18 03:38:55 +08:00
|
|
|
|
2013-09-07 07:45:20 +08:00
|
|
|
if (SetterMethod) {
|
2013-10-03 05:32:39 +08:00
|
|
|
if ((ASTMigrateActions & FrontendOptions::ObjCMT_ReadwriteProperty) == 0)
|
|
|
|
return false;
|
2013-09-19 01:22:25 +08:00
|
|
|
if (SetterMethod->isDeprecated() ||
|
|
|
|
!AttributesMatch(Method, SetterMethod))
|
2013-09-18 06:41:25 +08:00
|
|
|
return false;
|
2013-09-19 01:22:25 +08:00
|
|
|
|
2013-09-07 07:45:20 +08:00
|
|
|
// Is this a valid setter, matching the target getter?
|
|
|
|
QualType SRT = SetterMethod->getResultType();
|
|
|
|
if (!SRT->isVoidType())
|
|
|
|
return false;
|
|
|
|
const ParmVarDecl *argDecl = *SetterMethod->param_begin();
|
|
|
|
QualType ArgType = argDecl->getType();
|
2013-09-19 01:22:25 +08:00
|
|
|
if (!Ctx.hasSameUnqualifiedType(ArgType, GRT))
|
2013-09-07 07:45:20 +08:00
|
|
|
return false;
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
rewriteToObjCProperty(Method, SetterMethod, *NSAPIObj, commit,
|
2013-10-10 03:06:08 +08:00
|
|
|
LengthOfPrefix,
|
|
|
|
(ASTMigrateActions &
|
|
|
|
FrontendOptions::ObjCMT_AtomicProperty) != 0);
|
2013-09-07 07:45:20 +08:00
|
|
|
Editor->commit(commit);
|
|
|
|
return true;
|
|
|
|
}
|
2013-10-03 01:08:12 +08:00
|
|
|
else if (ASTMigrateActions & FrontendOptions::ObjCMT_ReadonlyProperty) {
|
2013-09-07 07:45:20 +08:00
|
|
|
// Try a non-void method with no argument (and no setter or property of same name
|
|
|
|
// as a 'readonly' property.
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
rewriteToObjCProperty(Method, 0 /*SetterMethod*/, *NSAPIObj, commit,
|
2013-10-10 03:06:08 +08:00
|
|
|
LengthOfPrefix,
|
|
|
|
(ASTMigrateActions &
|
|
|
|
FrontendOptions::ObjCMT_AtomicProperty) != 0);
|
2013-09-07 07:45:20 +08:00
|
|
|
Editor->commit(commit);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-08-31 07:52:08 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateNsReturnsInnerPointer(ASTContext &Ctx,
|
|
|
|
ObjCMethodDecl *OM) {
|
2013-09-25 04:20:52 +08:00
|
|
|
if (OM->isImplicit() ||
|
2013-09-27 06:43:41 +08:00
|
|
|
!OM->isInstanceMethod() ||
|
2013-09-25 04:20:52 +08:00
|
|
|
OM->hasAttr<ObjCReturnsInnerPointerAttr>())
|
2013-08-31 07:52:08 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
QualType RT = OM->getResultType();
|
|
|
|
if (!TypeIsInnerPointer(RT) ||
|
|
|
|
!Ctx.Idents.get("NS_RETURNS_INNER_POINTER").hasMacroDefinition())
|
|
|
|
return;
|
|
|
|
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(OM->getLocEnd(), " NS_RETURNS_INNER_POINTER");
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
|
|
|
|
2013-09-25 04:20:52 +08:00
|
|
|
void ObjCMigrateASTConsumer::migratePropertyNsReturnsInnerPointer(ASTContext &Ctx,
|
|
|
|
ObjCPropertyDecl *P) {
|
|
|
|
QualType T = P->getType();
|
|
|
|
|
|
|
|
if (!TypeIsInnerPointer(T) ||
|
|
|
|
!Ctx.Idents.get("NS_RETURNS_INNER_POINTER").hasMacroDefinition())
|
|
|
|
return;
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(P->getLocEnd(), " NS_RETURNS_INNER_POINTER ");
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
|
|
|
|
2013-10-03 06:49:59 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateAllMethodInstaceType(ASTContext &Ctx,
|
2013-07-24 06:42:28 +08:00
|
|
|
ObjCContainerDecl *CDecl) {
|
2013-09-18 23:43:52 +08:00
|
|
|
if (CDecl->isDeprecated())
|
|
|
|
return;
|
|
|
|
|
2013-07-24 06:42:28 +08:00
|
|
|
// migrate methods which can have instancetype as their result type.
|
|
|
|
for (ObjCContainerDecl::method_iterator M = CDecl->meth_begin(),
|
|
|
|
MEnd = CDecl->meth_end();
|
|
|
|
M != MEnd; ++M) {
|
|
|
|
ObjCMethodDecl *Method = (*M);
|
2013-09-18 05:56:04 +08:00
|
|
|
if (Method->isDeprecated())
|
|
|
|
continue;
|
2013-07-24 06:42:28 +08:00
|
|
|
migrateMethodInstanceType(Ctx, CDecl, Method);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-08-03 02:00:53 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateFactoryMethod(ASTContext &Ctx,
|
|
|
|
ObjCContainerDecl *CDecl,
|
2013-08-03 04:54:18 +08:00
|
|
|
ObjCMethodDecl *OM,
|
|
|
|
ObjCInstanceTypeFamily OIT_Family) {
|
2013-08-03 06:34:18 +08:00
|
|
|
if (OM->isInstanceMethod() ||
|
|
|
|
OM->getResultType() == Ctx.getObjCInstanceType() ||
|
|
|
|
!OM->getResultType()->isObjCIdType())
|
2013-08-03 02:00:53 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
// Candidate factory methods are + (id) NaMeXXX : ... which belong to a class
|
|
|
|
// NSYYYNamE with matching names be at least 3 characters long.
|
|
|
|
ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl);
|
|
|
|
if (!IDecl) {
|
|
|
|
if (ObjCCategoryDecl *CatDecl = dyn_cast<ObjCCategoryDecl>(CDecl))
|
|
|
|
IDecl = CatDecl->getClassInterface();
|
|
|
|
else if (ObjCImplDecl *ImpDecl = dyn_cast<ObjCImplDecl>(CDecl))
|
|
|
|
IDecl = ImpDecl->getClassInterface();
|
|
|
|
}
|
|
|
|
if (!IDecl)
|
|
|
|
return;
|
|
|
|
|
|
|
|
std::string StringClassName = IDecl->getName();
|
|
|
|
StringRef LoweredClassName(StringClassName);
|
|
|
|
std::string StringLoweredClassName = LoweredClassName.lower();
|
|
|
|
LoweredClassName = StringLoweredClassName;
|
|
|
|
|
|
|
|
IdentifierInfo *MethodIdName = OM->getSelector().getIdentifierInfoForSlot(0);
|
2013-08-14 02:01:42 +08:00
|
|
|
// Handle method with no name at its first selector slot; e.g. + (id):(int)x.
|
|
|
|
if (!MethodIdName)
|
|
|
|
return;
|
|
|
|
|
2013-08-03 02:00:53 +08:00
|
|
|
std::string MethodName = MethodIdName->getName();
|
2013-10-11 02:23:13 +08:00
|
|
|
if (OIT_Family == OIT_Singleton || OIT_Family == OIT_ReturnsSelf) {
|
2013-08-03 04:54:18 +08:00
|
|
|
StringRef STRefMethodName(MethodName);
|
|
|
|
size_t len = 0;
|
|
|
|
if (STRefMethodName.startswith("standard"))
|
|
|
|
len = strlen("standard");
|
|
|
|
else if (STRefMethodName.startswith("shared"))
|
|
|
|
len = strlen("shared");
|
|
|
|
else if (STRefMethodName.startswith("default"))
|
|
|
|
len = strlen("default");
|
|
|
|
else
|
|
|
|
return;
|
|
|
|
MethodName = STRefMethodName.substr(len);
|
|
|
|
}
|
2013-08-03 02:00:53 +08:00
|
|
|
std::string MethodNameSubStr = MethodName.substr(0, 3);
|
|
|
|
StringRef MethodNamePrefix(MethodNameSubStr);
|
|
|
|
std::string StringLoweredMethodNamePrefix = MethodNamePrefix.lower();
|
|
|
|
MethodNamePrefix = StringLoweredMethodNamePrefix;
|
|
|
|
size_t Ix = LoweredClassName.rfind(MethodNamePrefix);
|
|
|
|
if (Ix == StringRef::npos)
|
|
|
|
return;
|
|
|
|
std::string ClassNamePostfix = LoweredClassName.substr(Ix);
|
|
|
|
StringRef LoweredMethodName(MethodName);
|
|
|
|
std::string StringLoweredMethodName = LoweredMethodName.lower();
|
|
|
|
LoweredMethodName = StringLoweredMethodName;
|
|
|
|
if (!LoweredMethodName.startswith(ClassNamePostfix))
|
|
|
|
return;
|
2013-10-11 02:23:13 +08:00
|
|
|
if (OIT_Family == OIT_ReturnsSelf)
|
|
|
|
ReplaceWithClasstype(*this, OM);
|
|
|
|
else
|
|
|
|
ReplaceWithInstancetype(*this, OM);
|
2013-08-03 02:00:53 +08:00
|
|
|
}
|
|
|
|
|
2013-08-17 07:35:05 +08:00
|
|
|
static bool IsVoidStarType(QualType Ty) {
|
|
|
|
if (!Ty->isPointerType())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
while (const TypedefType *TD = dyn_cast<TypedefType>(Ty.getTypePtr()))
|
|
|
|
Ty = TD->getDecl()->getUnderlyingType();
|
|
|
|
|
|
|
|
// Is the type void*?
|
|
|
|
const PointerType* PT = Ty->getAs<PointerType>();
|
|
|
|
if (PT->getPointeeType().getUnqualifiedType()->isVoidType())
|
|
|
|
return true;
|
|
|
|
return IsVoidStarType(PT->getPointeeType());
|
|
|
|
}
|
|
|
|
|
2013-08-21 02:54:39 +08:00
|
|
|
/// AuditedType - This routine audits the type AT and returns false if it is one of known
|
|
|
|
/// CF object types or of the "void *" variety. It returns true if we don't care about the type
|
|
|
|
/// such as a non-pointer or pointers which have no ownership issues (such as "int *").
|
2013-08-28 06:42:30 +08:00
|
|
|
static bool AuditedType (QualType AT) {
|
|
|
|
if (!AT->isAnyPointerType() && !AT->isBlockPointerType())
|
2013-08-20 03:13:34 +08:00
|
|
|
return true;
|
|
|
|
// FIXME. There isn't much we can say about CF pointer type; or is there?
|
2013-08-21 02:54:39 +08:00
|
|
|
if (ento::coreFoundation::isCFObjectRef(AT) ||
|
|
|
|
IsVoidStarType(AT) ||
|
|
|
|
// If an ObjC object is type, assuming that it is not a CF function and
|
|
|
|
// that it is an un-audited function.
|
2013-08-23 06:27:36 +08:00
|
|
|
AT->isObjCObjectPointerType() || AT->isObjCBuiltinType())
|
2013-08-20 03:13:34 +08:00
|
|
|
return false;
|
2013-08-21 02:54:39 +08:00
|
|
|
// All other pointers are assumed audited as harmless.
|
2013-08-20 03:13:34 +08:00
|
|
|
return true;
|
2013-08-17 07:35:05 +08:00
|
|
|
}
|
|
|
|
|
2013-08-21 06:42:13 +08:00
|
|
|
void ObjCMigrateASTConsumer::AnnotateImplicitBridging(ASTContext &Ctx) {
|
2013-08-23 02:35:27 +08:00
|
|
|
if (CFFunctionIBCandidates.empty())
|
|
|
|
return;
|
2013-08-21 06:42:13 +08:00
|
|
|
if (!Ctx.Idents.get("CF_IMPLICIT_BRIDGING_ENABLED").hasMacroDefinition()) {
|
|
|
|
CFFunctionIBCandidates.clear();
|
2013-08-21 07:35:26 +08:00
|
|
|
FileId = 0;
|
2013-08-21 06:42:13 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
// Insert CF_IMPLICIT_BRIDGING_ENABLE/CF_IMPLICIT_BRIDGING_DISABLED
|
2013-08-23 02:35:27 +08:00
|
|
|
const Decl *FirstFD = CFFunctionIBCandidates[0];
|
|
|
|
const Decl *LastFD =
|
|
|
|
CFFunctionIBCandidates[CFFunctionIBCandidates.size()-1];
|
2013-08-21 06:42:13 +08:00
|
|
|
const char *PragmaString = "\nCF_IMPLICIT_BRIDGING_ENABLED\n\n";
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(FirstFD->getLocStart(), PragmaString);
|
|
|
|
PragmaString = "\n\nCF_IMPLICIT_BRIDGING_DISABLED\n";
|
|
|
|
SourceLocation EndLoc = LastFD->getLocEnd();
|
|
|
|
// get location just past end of function location.
|
|
|
|
EndLoc = PP.getLocForEndOfToken(EndLoc);
|
2013-08-23 02:35:27 +08:00
|
|
|
if (isa<FunctionDecl>(LastFD)) {
|
|
|
|
// For Methods, EndLoc points to the ending semcolon. So,
|
|
|
|
// not of these extra work is needed.
|
|
|
|
Token Tok;
|
|
|
|
// get locaiton of token that comes after end of function.
|
|
|
|
bool Failed = PP.getRawToken(EndLoc, Tok, /*IgnoreWhiteSpace=*/true);
|
|
|
|
if (!Failed)
|
|
|
|
EndLoc = Tok.getLocation();
|
|
|
|
}
|
2013-08-21 06:42:13 +08:00
|
|
|
commit.insertAfterToken(EndLoc, PragmaString);
|
|
|
|
Editor->commit(commit);
|
2013-08-21 07:35:26 +08:00
|
|
|
FileId = 0;
|
2013-08-21 06:42:13 +08:00
|
|
|
CFFunctionIBCandidates.clear();
|
|
|
|
}
|
|
|
|
|
2013-08-23 05:40:15 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateCFAnnotation(ASTContext &Ctx, const Decl *Decl) {
|
2013-09-18 05:56:04 +08:00
|
|
|
if (Decl->isDeprecated())
|
|
|
|
return;
|
|
|
|
|
2013-08-23 05:40:15 +08:00
|
|
|
if (Decl->hasAttr<CFAuditedTransferAttr>()) {
|
2013-08-20 06:00:50 +08:00
|
|
|
assert(CFFunctionIBCandidates.empty() &&
|
2013-08-23 05:40:15 +08:00
|
|
|
"Cannot have audited functions/methods inside user "
|
2013-08-20 06:00:50 +08:00
|
|
|
"provided CF_IMPLICIT_BRIDGING_ENABLE");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-08-17 07:35:05 +08:00
|
|
|
// Finction must be annotated first.
|
2013-09-04 08:10:06 +08:00
|
|
|
if (const FunctionDecl *FuncDecl = dyn_cast<FunctionDecl>(Decl)) {
|
|
|
|
CF_BRIDGING_KIND AuditKind = migrateAddFunctionAnnotation(Ctx, FuncDecl);
|
|
|
|
if (AuditKind == CF_BRIDGING_ENABLE) {
|
2013-08-28 06:42:30 +08:00
|
|
|
CFFunctionIBCandidates.push_back(Decl);
|
|
|
|
if (!FileId)
|
|
|
|
FileId = PP.getSourceManager().getFileID(Decl->getLocation()).getHashValue();
|
|
|
|
}
|
2013-09-04 08:10:06 +08:00
|
|
|
else if (AuditKind == CF_BRIDGING_MAY_INCLUDE) {
|
|
|
|
if (!CFFunctionIBCandidates.empty()) {
|
|
|
|
CFFunctionIBCandidates.push_back(Decl);
|
|
|
|
if (!FileId)
|
|
|
|
FileId = PP.getSourceManager().getFileID(Decl->getLocation()).getHashValue();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
AnnotateImplicitBridging(Ctx);
|
2013-08-28 06:42:30 +08:00
|
|
|
}
|
2013-09-04 08:10:06 +08:00
|
|
|
else {
|
|
|
|
migrateAddMethodAnnotation(Ctx, cast<ObjCMethodDecl>(Decl));
|
2013-08-21 06:42:13 +08:00
|
|
|
AnnotateImplicitBridging(Ctx);
|
2013-09-04 08:10:06 +08:00
|
|
|
}
|
2013-08-17 07:35:05 +08:00
|
|
|
}
|
|
|
|
|
2013-08-28 06:42:30 +08:00
|
|
|
void ObjCMigrateASTConsumer::AddCFAnnotations(ASTContext &Ctx,
|
|
|
|
const CallEffects &CE,
|
2013-08-28 07:56:54 +08:00
|
|
|
const FunctionDecl *FuncDecl,
|
|
|
|
bool ResultAnnotated) {
|
2013-08-28 06:42:30 +08:00
|
|
|
// Annotate function.
|
2013-08-28 07:56:54 +08:00
|
|
|
if (!ResultAnnotated) {
|
2013-08-20 03:13:34 +08:00
|
|
|
RetEffect Ret = CE.getReturnValue();
|
|
|
|
const char *AnnotationString = 0;
|
2013-09-05 06:49:19 +08:00
|
|
|
if (Ret.getObjKind() == RetEffect::CF) {
|
|
|
|
if (Ret.isOwned() &&
|
|
|
|
Ctx.Idents.get("CF_RETURNS_RETAINED").hasMacroDefinition())
|
2013-08-20 03:13:34 +08:00
|
|
|
AnnotationString = " CF_RETURNS_RETAINED";
|
2013-09-05 06:49:19 +08:00
|
|
|
else if (Ret.notOwned() &&
|
|
|
|
Ctx.Idents.get("CF_RETURNS_NOT_RETAINED").hasMacroDefinition())
|
2013-08-20 03:13:34 +08:00
|
|
|
AnnotationString = " CF_RETURNS_NOT_RETAINED";
|
|
|
|
}
|
2013-09-05 06:49:19 +08:00
|
|
|
else if (Ret.getObjKind() == RetEffect::ObjC) {
|
|
|
|
if (Ret.isOwned() &&
|
|
|
|
Ctx.Idents.get("NS_RETURNS_RETAINED").hasMacroDefinition())
|
|
|
|
AnnotationString = " NS_RETURNS_RETAINED";
|
|
|
|
}
|
|
|
|
|
2013-08-20 03:13:34 +08:00
|
|
|
if (AnnotationString) {
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertAfterToken(FuncDecl->getLocEnd(), AnnotationString);
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
2013-08-28 06:42:30 +08:00
|
|
|
}
|
|
|
|
llvm::ArrayRef<ArgEffect> AEArgs = CE.getArgs();
|
|
|
|
unsigned i = 0;
|
|
|
|
for (FunctionDecl::param_const_iterator pi = FuncDecl->param_begin(),
|
|
|
|
pe = FuncDecl->param_end(); pi != pe; ++pi, ++i) {
|
|
|
|
const ParmVarDecl *pd = *pi;
|
|
|
|
ArgEffect AE = AEArgs[i];
|
|
|
|
if (AE == DecRef && !pd->getAttr<CFConsumedAttr>() &&
|
|
|
|
Ctx.Idents.get("CF_CONSUMED").hasMacroDefinition()) {
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(pd->getLocation(), "CF_CONSUMED ");
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
2013-09-05 06:49:19 +08:00
|
|
|
else if (AE == DecRefMsg && !pd->getAttr<NSConsumedAttr>() &&
|
|
|
|
Ctx.Idents.get("NS_CONSUMED").hasMacroDefinition()) {
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(pd->getLocation(), "NS_CONSUMED ");
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
2013-08-28 06:42:30 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
ObjCMigrateASTConsumer::CF_BRIDGING_KIND
|
|
|
|
ObjCMigrateASTConsumer::migrateAddFunctionAnnotation(
|
|
|
|
ASTContext &Ctx,
|
|
|
|
const FunctionDecl *FuncDecl) {
|
|
|
|
if (FuncDecl->hasBody())
|
|
|
|
return CF_BRIDGING_NONE;
|
|
|
|
|
|
|
|
CallEffects CE = CallEffects::getEffect(FuncDecl);
|
|
|
|
bool FuncIsReturnAnnotated = (FuncDecl->getAttr<CFReturnsRetainedAttr>() ||
|
2013-09-05 06:49:19 +08:00
|
|
|
FuncDecl->getAttr<CFReturnsNotRetainedAttr>() ||
|
|
|
|
FuncDecl->getAttr<NSReturnsRetainedAttr>() ||
|
2013-09-06 07:04:33 +08:00
|
|
|
FuncDecl->getAttr<NSReturnsNotRetainedAttr>() ||
|
|
|
|
FuncDecl->getAttr<NSReturnsAutoreleasedAttr>());
|
2013-08-28 06:42:30 +08:00
|
|
|
|
|
|
|
// Trivial case of when funciton is annotated and has no argument.
|
|
|
|
if (FuncIsReturnAnnotated && FuncDecl->getNumParams() == 0)
|
|
|
|
return CF_BRIDGING_NONE;
|
|
|
|
|
|
|
|
bool ReturnCFAudited = false;
|
|
|
|
if (!FuncIsReturnAnnotated) {
|
|
|
|
RetEffect Ret = CE.getReturnValue();
|
|
|
|
if (Ret.getObjKind() == RetEffect::CF &&
|
2013-09-04 08:10:06 +08:00
|
|
|
(Ret.isOwned() || Ret.notOwned()))
|
2013-08-28 06:42:30 +08:00
|
|
|
ReturnCFAudited = true;
|
|
|
|
else if (!AuditedType(FuncDecl->getResultType()))
|
|
|
|
return CF_BRIDGING_NONE;
|
2013-08-16 05:44:38 +08:00
|
|
|
}
|
2013-08-21 02:54:39 +08:00
|
|
|
|
2013-08-28 06:42:30 +08:00
|
|
|
// At this point result type is audited for potential inclusion.
|
2013-08-20 03:13:34 +08:00
|
|
|
// Now, how about argument types.
|
|
|
|
llvm::ArrayRef<ArgEffect> AEArgs = CE.getArgs();
|
|
|
|
unsigned i = 0;
|
2013-08-28 06:42:30 +08:00
|
|
|
bool ArgCFAudited = false;
|
2013-08-20 03:13:34 +08:00
|
|
|
for (FunctionDecl::param_const_iterator pi = FuncDecl->param_begin(),
|
|
|
|
pe = FuncDecl->param_end(); pi != pe; ++pi, ++i) {
|
2013-08-22 03:37:47 +08:00
|
|
|
const ParmVarDecl *pd = *pi;
|
2013-08-20 03:13:34 +08:00
|
|
|
ArgEffect AE = AEArgs[i];
|
2013-08-28 06:42:30 +08:00
|
|
|
if (AE == DecRef /*CFConsumed annotated*/ || AE == IncRef) {
|
|
|
|
if (AE == DecRef && !pd->getAttr<CFConsumedAttr>())
|
|
|
|
ArgCFAudited = true;
|
|
|
|
else if (AE == IncRef)
|
|
|
|
ArgCFAudited = true;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
QualType AT = pd->getType();
|
|
|
|
if (!AuditedType(AT)) {
|
2013-08-28 07:56:54 +08:00
|
|
|
AddCFAnnotations(Ctx, CE, FuncDecl, FuncIsReturnAnnotated);
|
2013-08-28 06:42:30 +08:00
|
|
|
return CF_BRIDGING_NONE;
|
2013-08-22 03:37:47 +08:00
|
|
|
}
|
2013-08-21 02:54:39 +08:00
|
|
|
}
|
2013-08-16 05:44:38 +08:00
|
|
|
}
|
2013-08-28 06:42:30 +08:00
|
|
|
if (ReturnCFAudited || ArgCFAudited)
|
|
|
|
return CF_BRIDGING_ENABLE;
|
|
|
|
|
|
|
|
return CF_BRIDGING_MAY_INCLUDE;
|
2013-08-13 07:17:13 +08:00
|
|
|
}
|
|
|
|
|
2013-08-23 02:35:27 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateARCSafeAnnotation(ASTContext &Ctx,
|
|
|
|
ObjCContainerDecl *CDecl) {
|
2013-09-18 05:56:04 +08:00
|
|
|
if (!isa<ObjCInterfaceDecl>(CDecl) || CDecl->isDeprecated())
|
2013-08-23 02:35:27 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
// migrate methods which can have instancetype as their result type.
|
|
|
|
for (ObjCContainerDecl::method_iterator M = CDecl->meth_begin(),
|
|
|
|
MEnd = CDecl->meth_end();
|
|
|
|
M != MEnd; ++M) {
|
|
|
|
ObjCMethodDecl *Method = (*M);
|
2013-08-23 05:40:15 +08:00
|
|
|
migrateCFAnnotation(Ctx, Method);
|
2013-08-23 02:35:27 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-08-28 06:42:30 +08:00
|
|
|
void ObjCMigrateASTConsumer::AddCFAnnotations(ASTContext &Ctx,
|
|
|
|
const CallEffects &CE,
|
2013-08-28 07:56:54 +08:00
|
|
|
const ObjCMethodDecl *MethodDecl,
|
|
|
|
bool ResultAnnotated) {
|
2013-08-28 06:42:30 +08:00
|
|
|
// Annotate function.
|
2013-08-28 07:56:54 +08:00
|
|
|
if (!ResultAnnotated) {
|
2013-08-23 02:35:27 +08:00
|
|
|
RetEffect Ret = CE.getReturnValue();
|
|
|
|
const char *AnnotationString = 0;
|
2013-09-05 06:49:19 +08:00
|
|
|
if (Ret.getObjKind() == RetEffect::CF) {
|
|
|
|
if (Ret.isOwned() &&
|
|
|
|
Ctx.Idents.get("CF_RETURNS_RETAINED").hasMacroDefinition())
|
2013-08-23 02:35:27 +08:00
|
|
|
AnnotationString = " CF_RETURNS_RETAINED";
|
2013-09-05 06:49:19 +08:00
|
|
|
else if (Ret.notOwned() &&
|
|
|
|
Ctx.Idents.get("CF_RETURNS_NOT_RETAINED").hasMacroDefinition())
|
2013-08-23 02:35:27 +08:00
|
|
|
AnnotationString = " CF_RETURNS_NOT_RETAINED";
|
|
|
|
}
|
2013-09-05 06:49:19 +08:00
|
|
|
else if (Ret.getObjKind() == RetEffect::ObjC) {
|
2013-09-06 07:04:33 +08:00
|
|
|
ObjCMethodFamily OMF = MethodDecl->getMethodFamily();
|
|
|
|
switch (OMF) {
|
|
|
|
case clang::OMF_alloc:
|
|
|
|
case clang::OMF_new:
|
|
|
|
case clang::OMF_copy:
|
|
|
|
case clang::OMF_init:
|
|
|
|
case clang::OMF_mutableCopy:
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
if (Ret.isOwned() &&
|
|
|
|
Ctx.Idents.get("NS_RETURNS_RETAINED").hasMacroDefinition())
|
|
|
|
AnnotationString = " NS_RETURNS_RETAINED";
|
|
|
|
break;
|
|
|
|
}
|
2013-09-05 06:49:19 +08:00
|
|
|
}
|
|
|
|
|
2013-08-23 02:35:27 +08:00
|
|
|
if (AnnotationString) {
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(MethodDecl->getLocEnd(), AnnotationString);
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
2013-08-28 06:42:30 +08:00
|
|
|
}
|
|
|
|
llvm::ArrayRef<ArgEffect> AEArgs = CE.getArgs();
|
|
|
|
unsigned i = 0;
|
|
|
|
for (ObjCMethodDecl::param_const_iterator pi = MethodDecl->param_begin(),
|
|
|
|
pe = MethodDecl->param_end(); pi != pe; ++pi, ++i) {
|
|
|
|
const ParmVarDecl *pd = *pi;
|
|
|
|
ArgEffect AE = AEArgs[i];
|
|
|
|
if (AE == DecRef && !pd->getAttr<CFConsumedAttr>() &&
|
|
|
|
Ctx.Idents.get("CF_CONSUMED").hasMacroDefinition()) {
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(pd->getLocation(), "CF_CONSUMED ");
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-04 08:10:06 +08:00
|
|
|
void ObjCMigrateASTConsumer::migrateAddMethodAnnotation(
|
2013-08-28 06:42:30 +08:00
|
|
|
ASTContext &Ctx,
|
|
|
|
const ObjCMethodDecl *MethodDecl) {
|
2013-09-05 06:49:19 +08:00
|
|
|
if (MethodDecl->hasBody() || MethodDecl->isImplicit())
|
2013-09-04 08:10:06 +08:00
|
|
|
return;
|
2013-08-28 06:42:30 +08:00
|
|
|
|
|
|
|
CallEffects CE = CallEffects::getEffect(MethodDecl);
|
|
|
|
bool MethodIsReturnAnnotated = (MethodDecl->getAttr<CFReturnsRetainedAttr>() ||
|
2013-09-05 06:49:19 +08:00
|
|
|
MethodDecl->getAttr<CFReturnsNotRetainedAttr>() ||
|
|
|
|
MethodDecl->getAttr<NSReturnsRetainedAttr>() ||
|
2013-09-06 07:04:33 +08:00
|
|
|
MethodDecl->getAttr<NSReturnsNotRetainedAttr>() ||
|
|
|
|
MethodDecl->getAttr<NSReturnsAutoreleasedAttr>());
|
|
|
|
|
|
|
|
if (CE.getReceiver() == DecRefMsg &&
|
|
|
|
!MethodDecl->getAttr<NSConsumesSelfAttr>() &&
|
|
|
|
MethodDecl->getMethodFamily() != OMF_init &&
|
|
|
|
MethodDecl->getMethodFamily() != OMF_release &&
|
|
|
|
Ctx.Idents.get("NS_CONSUMES_SELF").hasMacroDefinition()) {
|
|
|
|
edit::Commit commit(*Editor);
|
|
|
|
commit.insertBefore(MethodDecl->getLocEnd(), " NS_CONSUMES_SELF");
|
|
|
|
Editor->commit(commit);
|
|
|
|
}
|
2013-08-28 06:42:30 +08:00
|
|
|
|
|
|
|
// Trivial case of when funciton is annotated and has no argument.
|
|
|
|
if (MethodIsReturnAnnotated &&
|
|
|
|
(MethodDecl->param_begin() == MethodDecl->param_end()))
|
2013-09-04 08:10:06 +08:00
|
|
|
return;
|
2013-08-28 06:42:30 +08:00
|
|
|
|
|
|
|
if (!MethodIsReturnAnnotated) {
|
|
|
|
RetEffect Ret = CE.getReturnValue();
|
2013-09-05 06:49:19 +08:00
|
|
|
if ((Ret.getObjKind() == RetEffect::CF ||
|
|
|
|
Ret.getObjKind() == RetEffect::ObjC) &&
|
|
|
|
(Ret.isOwned() || Ret.notOwned())) {
|
2013-09-05 00:43:57 +08:00
|
|
|
AddCFAnnotations(Ctx, CE, MethodDecl, false);
|
|
|
|
return;
|
|
|
|
}
|
2013-08-28 06:42:30 +08:00
|
|
|
else if (!AuditedType(MethodDecl->getResultType()))
|
2013-09-04 08:10:06 +08:00
|
|
|
return;
|
2013-08-23 02:35:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// At this point result type is either annotated or audited.
|
|
|
|
// Now, how about argument types.
|
|
|
|
llvm::ArrayRef<ArgEffect> AEArgs = CE.getArgs();
|
|
|
|
unsigned i = 0;
|
|
|
|
for (ObjCMethodDecl::param_const_iterator pi = MethodDecl->param_begin(),
|
|
|
|
pe = MethodDecl->param_end(); pi != pe; ++pi, ++i) {
|
|
|
|
const ParmVarDecl *pd = *pi;
|
|
|
|
ArgEffect AE = AEArgs[i];
|
2013-09-05 00:43:57 +08:00
|
|
|
if ((AE == DecRef && !pd->getAttr<CFConsumedAttr>()) || AE == IncRef ||
|
|
|
|
!AuditedType(pd->getType())) {
|
|
|
|
AddCFAnnotations(Ctx, CE, MethodDecl, MethodIsReturnAnnotated);
|
|
|
|
return;
|
2013-08-23 02:35:27 +08:00
|
|
|
}
|
|
|
|
}
|
2013-09-04 08:10:06 +08:00
|
|
|
return;
|
2013-08-13 07:17:13 +08:00
|
|
|
}
|
|
|
|
|
2012-03-07 04:06:33 +08:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
class RewritesReceiver : public edit::EditsReceiver {
|
|
|
|
Rewriter &Rewrite;
|
|
|
|
|
|
|
|
public:
|
|
|
|
RewritesReceiver(Rewriter &Rewrite) : Rewrite(Rewrite) { }
|
|
|
|
|
|
|
|
virtual void insert(SourceLocation loc, StringRef text) {
|
|
|
|
Rewrite.InsertText(loc, text);
|
|
|
|
}
|
|
|
|
virtual void replace(CharSourceRange range, StringRef text) {
|
|
|
|
Rewrite.ReplaceText(range.getBegin(), Rewrite.getRangeSize(range), text);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2013-10-02 05:16:29 +08:00
|
|
|
static bool
|
|
|
|
IsReallyASystemHeader(ASTContext &Ctx, const FileEntry *file, FileID FID) {
|
|
|
|
bool Invalid = false;
|
|
|
|
const SrcMgr::SLocEntry &SEntry =
|
|
|
|
Ctx.getSourceManager().getSLocEntry(FID, &Invalid);
|
|
|
|
if (!Invalid && SEntry.isFile()) {
|
|
|
|
const SrcMgr::FileInfo &FI = SEntry.getFile();
|
|
|
|
if (!FI.hasLineDirectives()) {
|
|
|
|
if (FI.getFileCharacteristic() == SrcMgr::C_ExternCSystem)
|
|
|
|
return true;
|
|
|
|
if (FI.getFileCharacteristic() == SrcMgr::C_System) {
|
|
|
|
// This file is in a system header directory. Continue with commiting change
|
|
|
|
// only if it is a user specified system directory because user put a
|
|
|
|
// .system_framework file in the framework directory.
|
|
|
|
StringRef Directory(file->getDir()->getName());
|
|
|
|
size_t Ix = Directory.rfind(".framework");
|
|
|
|
if (Ix == StringRef::npos)
|
|
|
|
return true;
|
|
|
|
std::string PatchToSystemFramework = Directory.slice(0, Ix+sizeof(".framework"));
|
|
|
|
PatchToSystemFramework += ".system_framework";
|
|
|
|
if (!llvm::sys::fs::exists(PatchToSystemFramework.data()))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-03-07 04:06:33 +08:00
|
|
|
void ObjCMigrateASTConsumer::HandleTranslationUnit(ASTContext &Ctx) {
|
2013-07-04 07:05:00 +08:00
|
|
|
|
|
|
|
TranslationUnitDecl *TU = Ctx.getTranslationUnitDecl();
|
2013-10-03 05:32:39 +08:00
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_MigrateDecls) {
|
2013-07-10 00:59:14 +08:00
|
|
|
for (DeclContext::decl_iterator D = TU->decls_begin(), DEnd = TU->decls_end();
|
|
|
|
D != DEnd; ++D) {
|
2013-08-21 07:35:26 +08:00
|
|
|
if (unsigned FID =
|
|
|
|
PP.getSourceManager().getFileID((*D)->getLocation()).getHashValue())
|
2013-10-03 06:49:59 +08:00
|
|
|
if (FileId && FileId != FID) {
|
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_Annotation)
|
|
|
|
AnnotateImplicitBridging(Ctx);
|
|
|
|
}
|
|
|
|
|
2013-07-10 00:59:14 +08:00
|
|
|
if (ObjCInterfaceDecl *CDecl = dyn_cast<ObjCInterfaceDecl>(*D))
|
|
|
|
migrateObjCInterfaceDecl(Ctx, CDecl);
|
2013-09-18 03:00:30 +08:00
|
|
|
if (ObjCCategoryDecl *CatDecl = dyn_cast<ObjCCategoryDecl>(*D))
|
|
|
|
migrateObjCInterfaceDecl(Ctx, CatDecl);
|
2013-07-13 06:32:19 +08:00
|
|
|
else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(*D))
|
|
|
|
ObjCProtocolDecls.insert(PDecl);
|
|
|
|
else if (const ObjCImplementationDecl *ImpDecl =
|
2013-10-03 06:49:59 +08:00
|
|
|
dyn_cast<ObjCImplementationDecl>(*D)) {
|
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_ProtocolConformance)
|
|
|
|
migrateProtocolConformance(Ctx, ImpDecl);
|
|
|
|
}
|
2013-07-19 04:11:45 +08:00
|
|
|
else if (const EnumDecl *ED = dyn_cast<EnumDecl>(*D)) {
|
2013-10-15 08:00:28 +08:00
|
|
|
if (!(ASTMigrateActions & FrontendOptions::ObjCMT_NsMacros))
|
|
|
|
continue;
|
2013-07-19 04:11:45 +08:00
|
|
|
DeclContext::decl_iterator N = D;
|
2013-10-15 08:00:28 +08:00
|
|
|
if (++N != DEnd) {
|
|
|
|
const TypedefDecl *TD = dyn_cast<TypedefDecl>(*N);
|
|
|
|
if (migrateNSEnumDecl(Ctx, ED, TD) && TD)
|
|
|
|
D++;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
migrateNSEnumDecl(Ctx, ED, /*TypedefDecl */0);
|
2013-10-12 05:34:56 +08:00
|
|
|
}
|
|
|
|
else if (const TypedefDecl *TD = dyn_cast<TypedefDecl>(*D)) {
|
2013-10-18 07:13:13 +08:00
|
|
|
if (!(ASTMigrateActions & FrontendOptions::ObjCMT_NsMacros))
|
|
|
|
continue;
|
|
|
|
DeclContext::decl_iterator N = D;
|
|
|
|
if (++N == DEnd)
|
|
|
|
continue;
|
|
|
|
if (const EnumDecl *ED = dyn_cast<EnumDecl>(*N)) {
|
2013-10-15 08:00:28 +08:00
|
|
|
if (++N != DEnd)
|
2013-10-18 07:13:13 +08:00
|
|
|
if (const TypedefDecl *TDF = dyn_cast<TypedefDecl>(*N)) {
|
|
|
|
// prefer typedef-follows-enum to enum-follows-typedef pattern.
|
|
|
|
if (migrateNSEnumDecl(Ctx, ED, TDF)) {
|
|
|
|
++D; ++D;
|
|
|
|
CacheObjCNSIntegerTypedefed(TD);
|
2013-10-15 08:00:28 +08:00
|
|
|
continue;
|
|
|
|
}
|
2013-10-12 05:34:56 +08:00
|
|
|
}
|
2013-10-18 07:13:13 +08:00
|
|
|
if (migrateNSEnumDecl(Ctx, ED, TD)) {
|
|
|
|
++D;
|
|
|
|
continue;
|
|
|
|
}
|
2013-10-15 08:00:28 +08:00
|
|
|
}
|
2013-10-18 07:13:13 +08:00
|
|
|
CacheObjCNSIntegerTypedefed(TD);
|
2013-10-03 06:49:59 +08:00
|
|
|
}
|
|
|
|
else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(*D)) {
|
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_Annotation)
|
|
|
|
migrateCFAnnotation(Ctx, FD);
|
2013-07-19 04:11:45 +08:00
|
|
|
}
|
2013-08-14 02:01:42 +08:00
|
|
|
|
2013-08-23 02:35:27 +08:00
|
|
|
if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(*D)) {
|
|
|
|
// migrate methods which can have instancetype as their result type.
|
2013-10-03 06:49:59 +08:00
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_Instancetype)
|
|
|
|
migrateAllMethodInstaceType(Ctx, CDecl);
|
2013-08-23 02:35:27 +08:00
|
|
|
// annotate methods with CF annotations.
|
2013-10-03 06:49:59 +08:00
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_Annotation)
|
|
|
|
migrateARCSafeAnnotation(Ctx, CDecl);
|
2013-08-23 02:35:27 +08:00
|
|
|
}
|
2013-07-10 00:59:14 +08:00
|
|
|
}
|
2013-10-03 06:49:59 +08:00
|
|
|
if (ASTMigrateActions & FrontendOptions::ObjCMT_Annotation)
|
|
|
|
AnnotateImplicitBridging(Ctx);
|
2013-08-21 06:42:13 +08:00
|
|
|
}
|
2013-07-04 07:05:00 +08:00
|
|
|
|
2012-03-11 15:00:24 +08:00
|
|
|
Rewriter rewriter(Ctx.getSourceManager(), Ctx.getLangOpts());
|
2012-03-07 04:06:33 +08:00
|
|
|
RewritesReceiver Rec(rewriter);
|
|
|
|
Editor->applyRewrites(Rec);
|
|
|
|
|
|
|
|
for (Rewriter::buffer_iterator
|
|
|
|
I = rewriter.buffer_begin(), E = rewriter.buffer_end(); I != E; ++I) {
|
|
|
|
FileID FID = I->first;
|
|
|
|
RewriteBuffer &buf = I->second;
|
|
|
|
const FileEntry *file = Ctx.getSourceManager().getFileEntryForID(FID);
|
|
|
|
assert(file);
|
2013-10-02 05:16:29 +08:00
|
|
|
if (IsReallyASystemHeader(Ctx, file, FID))
|
|
|
|
continue;
|
2013-01-13 03:30:44 +08:00
|
|
|
SmallString<512> newText;
|
2012-03-07 04:06:33 +08:00
|
|
|
llvm::raw_svector_ostream vecOS(newText);
|
|
|
|
buf.write(vecOS);
|
|
|
|
vecOS.flush();
|
|
|
|
llvm::MemoryBuffer *memBuf = llvm::MemoryBuffer::getMemBufferCopy(
|
|
|
|
StringRef(newText.data(), newText.size()), file->getName());
|
2013-01-13 03:30:44 +08:00
|
|
|
SmallString<64> filePath(file->getName());
|
2012-03-07 04:06:33 +08:00
|
|
|
FileMgr.FixupRelativePath(filePath);
|
|
|
|
Remapper.remap(filePath.str(), memBuf);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (IsOutputFile) {
|
|
|
|
Remapper.flushToFile(MigrateDir, Ctx.getDiagnostics());
|
|
|
|
} else {
|
|
|
|
Remapper.flushToDisk(MigrateDir, Ctx.getDiagnostics());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool MigrateSourceAction::BeginInvocation(CompilerInstance &CI) {
|
2012-05-25 00:48:23 +08:00
|
|
|
CI.getDiagnostics().setIgnoreAllWarnings(true);
|
2012-03-07 04:06:33 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
ASTConsumer *MigrateSourceAction::CreateASTConsumer(CompilerInstance &CI,
|
|
|
|
StringRef InFile) {
|
2012-12-04 15:27:05 +08:00
|
|
|
PPConditionalDirectiveRecord *
|
|
|
|
PPRec = new PPConditionalDirectiveRecord(CI.getSourceManager());
|
|
|
|
CI.getPreprocessor().addPPCallbacks(PPRec);
|
2012-03-07 04:06:33 +08:00
|
|
|
return new ObjCMigrateASTConsumer(CI.getFrontendOpts().OutputFile,
|
2013-10-03 05:32:39 +08:00
|
|
|
FrontendOptions::ObjCMT_MigrateAll,
|
2012-03-07 04:06:33 +08:00
|
|
|
Remapper,
|
|
|
|
CI.getFileManager(),
|
2012-12-04 15:27:05 +08:00
|
|
|
PPRec,
|
2013-07-04 07:05:00 +08:00
|
|
|
CI.getPreprocessor(),
|
2012-03-07 04:06:33 +08:00
|
|
|
/*isOutputFile=*/true);
|
|
|
|
}
|