2012-10-14 00:45:24 +08:00
|
|
|
//===------ SimplifyLibCalls.cpp - Library calls simplifier ---------------===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2012-10-14 00:45:24 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
2018-03-02 04:05:09 +08:00
|
|
|
// This file implements the library calls simplifier. It does not implement
|
|
|
|
// any pass, but can't be used by other passes to do simplifications.
|
2012-10-14 00:45:24 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/Transforms/Utils/SimplifyLibCalls.h"
|
2018-08-31 03:04:51 +08:00
|
|
|
#include "llvm/ADT/APSInt.h"
|
2013-03-12 08:08:29 +08:00
|
|
|
#include "llvm/ADT/SmallString.h"
|
2012-10-14 00:45:24 +08:00
|
|
|
#include "llvm/ADT/StringMap.h"
|
2013-11-03 14:48:38 +08:00
|
|
|
#include "llvm/ADT/Triple.h"
|
2019-04-16 00:49:00 +08:00
|
|
|
#include "llvm/Analysis/BlockFrequencyInfo.h"
|
2017-08-22 03:13:14 +08:00
|
|
|
#include "llvm/Analysis/ConstantFolding.h"
|
2017-10-10 07:19:02 +08:00
|
|
|
#include "llvm/Analysis/OptimizationRemarkEmitter.h"
|
2019-04-16 00:49:00 +08:00
|
|
|
#include "llvm/Analysis/ProfileSummaryInfo.h"
|
2015-11-25 02:57:06 +08:00
|
|
|
#include "llvm/Analysis/TargetLibraryInfo.h"
|
2018-06-05 05:23:21 +08:00
|
|
|
#include "llvm/Transforms/Utils/Local.h"
|
2012-10-14 00:45:24 +08:00
|
|
|
#include "llvm/Analysis/ValueTracking.h"
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
#include "llvm/Analysis/CaptureTracking.h"
|
2018-08-10 12:32:54 +08:00
|
|
|
#include "llvm/Analysis/Loads.h"
|
2013-01-02 19:36:10 +08:00
|
|
|
#include "llvm/IR/DataLayout.h"
|
|
|
|
#include "llvm/IR/Function.h"
|
|
|
|
#include "llvm/IR/IRBuilder.h"
|
2013-03-12 08:08:29 +08:00
|
|
|
#include "llvm/IR/IntrinsicInst.h"
|
2013-01-02 19:36:10 +08:00
|
|
|
#include "llvm/IR/Intrinsics.h"
|
|
|
|
#include "llvm/IR/LLVMContext.h"
|
|
|
|
#include "llvm/IR/Module.h"
|
2014-10-17 02:48:17 +08:00
|
|
|
#include "llvm/IR/PatternMatch.h"
|
2013-11-17 10:06:35 +08:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
2017-04-27 00:39:58 +08:00
|
|
|
#include "llvm/Support/KnownBits.h"
|
2019-10-01 04:52:21 +08:00
|
|
|
#include "llvm/Support/MathExtras.h"
|
2012-10-14 00:45:24 +08:00
|
|
|
#include "llvm/Transforms/Utils/BuildLibCalls.h"
|
2019-04-16 00:49:00 +08:00
|
|
|
#include "llvm/Transforms/Utils/SizeOpts.h"
|
2012-10-14 00:45:24 +08:00
|
|
|
|
|
|
|
using namespace llvm;
|
2014-10-17 02:48:17 +08:00
|
|
|
using namespace PatternMatch;
|
2012-10-14 00:45:24 +08:00
|
|
|
|
2014-10-22 23:29:23 +08:00
|
|
|
static cl::opt<bool>
|
|
|
|
EnableUnsafeFPShrink("enable-double-float-shrink", cl::Hidden,
|
|
|
|
cl::init(false),
|
|
|
|
cl::desc("Enable unsafe double to float "
|
|
|
|
"shrinking for math lib calls"));
|
|
|
|
|
2012-10-31 11:33:06 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Helper Functions
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
static bool ignoreCallingConv(LibFunc Func) {
|
|
|
|
return Func == LibFunc_abs || Func == LibFunc_labs ||
|
|
|
|
Func == LibFunc_llabs || Func == LibFunc_strlen;
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
|
|
|
|
2016-09-13 20:10:14 +08:00
|
|
|
static bool isCallingConvCCompatible(CallInst *CI) {
|
|
|
|
switch(CI->getCallingConv()) {
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
case llvm::CallingConv::C:
|
|
|
|
return true;
|
|
|
|
case llvm::CallingConv::ARM_APCS:
|
|
|
|
case llvm::CallingConv::ARM_AAPCS:
|
|
|
|
case llvm::CallingConv::ARM_AAPCS_VFP: {
|
|
|
|
|
|
|
|
// The iOS ABI diverges from the standard in some cases, so for now don't
|
|
|
|
// try to simplify those calls.
|
|
|
|
if (Triple(CI->getModule()->getTargetTriple()).isiOS())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
auto *FuncTy = CI->getFunctionType();
|
|
|
|
|
|
|
|
if (!FuncTy->getReturnType()->isPointerTy() &&
|
|
|
|
!FuncTy->getReturnType()->isIntegerTy() &&
|
|
|
|
!FuncTy->getReturnType()->isVoidTy())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
for (auto Param : FuncTy->params()) {
|
|
|
|
if (!Param->isPointerTy() && !Param->isIntegerTy())
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
/// Return true if it is only used in equality comparisons with With.
|
2012-11-11 11:51:48 +08:00
|
|
|
static bool isOnlyUsedInEqualityComparison(Value *V, Value *With) {
|
2014-03-09 11:16:01 +08:00
|
|
|
for (User *U : V->users()) {
|
|
|
|
if (ICmpInst *IC = dyn_cast<ICmpInst>(U))
|
2012-11-11 11:51:48 +08:00
|
|
|
if (IC->isEquality() && IC->getOperand(1) == With)
|
|
|
|
continue;
|
|
|
|
// Unknown instruction.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2012-11-27 04:37:20 +08:00
|
|
|
static bool callHasFloatingPointArgument(const CallInst *CI) {
|
2016-08-12 05:15:00 +08:00
|
|
|
return any_of(CI->operands(), [](const Use &OI) {
|
2015-11-29 06:27:48 +08:00
|
|
|
return OI->getType()->isFloatingPointTy();
|
|
|
|
});
|
2013-09-01 02:19:35 +08:00
|
|
|
}
|
|
|
|
|
2019-04-03 09:08:35 +08:00
|
|
|
static bool callHasFP128Argument(const CallInst *CI) {
|
|
|
|
return any_of(CI->operands(), [](const Use &OI) {
|
|
|
|
return OI->getType()->isFP128Ty();
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2018-04-26 02:58:53 +08:00
|
|
|
static Value *convertStrToNumber(CallInst *CI, StringRef &Str, int64_t Base) {
|
|
|
|
if (Base < 2 || Base > 36)
|
|
|
|
// handle special zero base
|
|
|
|
if (Base != 0)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
char *End;
|
|
|
|
std::string nptr = Str.str();
|
|
|
|
errno = 0;
|
|
|
|
long long int Result = strtoll(nptr.c_str(), &End, Base);
|
|
|
|
if (errno)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// if we assume all possible target locales are ASCII supersets,
|
|
|
|
// then if strtoll successfully parses a number on the host,
|
|
|
|
// it will also successfully parse the same way on the target
|
|
|
|
if (*End != '\0')
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
if (!isIntN(CI->getType()->getPrimitiveSizeInBits(), Result))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
return ConstantInt::get(CI->getType(), Result);
|
|
|
|
}
|
|
|
|
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
static bool isLocallyOpenedFile(Value *File, CallInst *CI, IRBuilder<> &B,
|
|
|
|
const TargetLibraryInfo *TLI) {
|
|
|
|
CallInst *FOpen = dyn_cast<CallInst>(File);
|
|
|
|
if (!FOpen)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
Function *InnerCallee = FOpen->getCalledFunction();
|
|
|
|
if (!InnerCallee)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
LibFunc Func;
|
|
|
|
if (!TLI->getLibFunc(*InnerCallee, Func) || !TLI->has(Func) ||
|
|
|
|
Func != LibFunc_fopen)
|
|
|
|
return false;
|
|
|
|
|
2018-10-17 05:18:31 +08:00
|
|
|
inferLibFuncAttributes(*CI->getCalledFunction(), *TLI);
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
if (PointerMayBeCaptured(File, true, true))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-08-10 12:32:54 +08:00
|
|
|
static bool isOnlyUsedInComparisonWithZero(Value *V) {
|
|
|
|
for (User *U : V->users()) {
|
|
|
|
if (ICmpInst *IC = dyn_cast<ICmpInst>(U))
|
|
|
|
if (Constant *C = dyn_cast<Constant>(IC->getOperand(1)))
|
|
|
|
if (C->isNullValue())
|
|
|
|
continue;
|
|
|
|
// Unknown instruction.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool canTransformToMemCmp(CallInst *CI, Value *Str, uint64_t Len,
|
|
|
|
const DataLayout &DL) {
|
|
|
|
if (!isOnlyUsedInComparisonWithZero(CI))
|
|
|
|
return false;
|
|
|
|
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
if (!isDereferenceableAndAlignedPointer(Str, Align(1), APInt(64, Len), DL))
|
2018-08-10 12:32:54 +08:00
|
|
|
return false;
|
2018-09-20 03:37:24 +08:00
|
|
|
|
|
|
|
if (CI->getFunction()->hasFnAttribute(Attribute::SanitizeMemory))
|
|
|
|
return false;
|
|
|
|
|
2018-08-10 12:32:54 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
static void annotateDereferenceableBytes(CallInst *CI,
|
|
|
|
ArrayRef<unsigned> ArgNos,
|
2019-08-14 00:44:16 +08:00
|
|
|
uint64_t DereferenceableBytes) {
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
const Function *F = CI->getCaller();
|
2019-08-15 01:15:20 +08:00
|
|
|
if (!F)
|
|
|
|
return;
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
for (unsigned ArgNo : ArgNos) {
|
2019-08-15 01:15:20 +08:00
|
|
|
uint64_t DerefBytes = DereferenceableBytes;
|
|
|
|
unsigned AS = CI->getArgOperand(ArgNo)->getType()->getPointerAddressSpace();
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (!llvm::NullPointerIsDefined(F, AS) ||
|
|
|
|
CI->paramHasAttr(ArgNo, Attribute::NonNull))
|
2019-08-15 01:15:20 +08:00
|
|
|
DerefBytes = std::max(CI->getDereferenceableOrNullBytes(
|
|
|
|
ArgNo + AttributeList::FirstArgIndex),
|
|
|
|
DereferenceableBytes);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
if (CI->getDereferenceableBytes(ArgNo + AttributeList::FirstArgIndex) <
|
|
|
|
DerefBytes) {
|
|
|
|
CI->removeParamAttr(ArgNo, Attribute::Dereferenceable);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (!llvm::NullPointerIsDefined(F, AS) ||
|
|
|
|
CI->paramHasAttr(ArgNo, Attribute::NonNull))
|
2019-08-15 01:15:20 +08:00
|
|
|
CI->removeParamAttr(ArgNo, Attribute::DereferenceableOrNull);
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
CI->addParamAttr(ArgNo, Attribute::getWithDereferenceableBytes(
|
|
|
|
CI->getContext(), DerefBytes));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
static void annotateNonNullBasedOnAccess(CallInst *CI,
|
|
|
|
ArrayRef<unsigned> ArgNos) {
|
|
|
|
Function *F = CI->getCaller();
|
|
|
|
if (!F)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (unsigned ArgNo : ArgNos) {
|
|
|
|
if (CI->paramHasAttr(ArgNo, Attribute::NonNull))
|
|
|
|
continue;
|
|
|
|
unsigned AS = CI->getArgOperand(ArgNo)->getType()->getPointerAddressSpace();
|
|
|
|
if (llvm::NullPointerIsDefined(F, AS))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
CI->addParamAttr(ArgNo, Attribute::NonNull);
|
|
|
|
annotateDereferenceableBytes(CI, ArgNo, 1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void annotateNonNullAndDereferenceable(CallInst *CI, ArrayRef<unsigned> ArgNos,
|
|
|
|
Value *Size, const DataLayout &DL) {
|
|
|
|
if (ConstantInt *LenC = dyn_cast<ConstantInt>(Size)) {
|
|
|
|
annotateNonNullBasedOnAccess(CI, ArgNos);
|
|
|
|
annotateDereferenceableBytes(CI, ArgNos, LenC->getZExtValue());
|
|
|
|
} else if (isKnownNonZero(Size, DL)) {
|
|
|
|
annotateNonNullBasedOnAccess(CI, ArgNos);
|
|
|
|
const APInt *X, *Y;
|
|
|
|
uint64_t DerefMin = 1;
|
|
|
|
if (match(Size, m_Select(m_Value(), m_APInt(X), m_APInt(Y)))) {
|
|
|
|
DerefMin = std::min(X->getZExtValue(), Y->getZExtValue());
|
|
|
|
annotateDereferenceableBytes(CI, ArgNos, DerefMin);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-10-14 00:45:32 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// String and Memory Library Call Optimizations
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrCat(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// Extract some information from the instruction
|
|
|
|
Value *Dst = CI->getArgOperand(0);
|
|
|
|
Value *Src = CI->getArgOperand(1);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, {0, 1});
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// See if we can get the length of the input string.
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len = GetStringLength(Src);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len)
|
|
|
|
annotateDereferenceableBytes(CI, 1, Len);
|
|
|
|
else
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
--Len; // Unbias length.
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Handle the simple, do-nothing case: strcat(x, "") -> x
|
|
|
|
if (Len == 0)
|
|
|
|
return Dst;
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return emitStrLenMemCpy(Src, Dst, Len, B);
|
|
|
|
}
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::emitStrLenMemCpy(Value *Src, Value *Dst, uint64_t Len,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
// We need to find the end of the destination string. That's where the
|
|
|
|
// memory is to be moved to. We just generate a call to strlen.
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *DstLen = emitStrLen(Dst, B, DL, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
if (!DstLen)
|
|
|
|
return nullptr;
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Now that we have the destination's length, we must index into the
|
|
|
|
// destination's pointer to get the actual memcpy destination (end of
|
|
|
|
// the string .. we're concatenating).
|
2015-03-31 04:42:56 +08:00
|
|
|
Value *CpyDst = B.CreateGEP(B.getInt8Ty(), Dst, DstLen, "endptr");
|
2014-09-18 04:55:46 +08:00
|
|
|
|
|
|
|
// We have enough information to now generate the memcpy call to do the
|
|
|
|
// concatenation for us. Make a memcpy to copy the nul byte with align = 1.
|
2019-12-16 22:24:13 +08:00
|
|
|
B.CreateMemCpy(
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CpyDst, Align(1), Src, Align(1),
|
2019-12-16 22:24:13 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(Src->getContext()), Len + 1));
|
2014-09-18 04:55:46 +08:00
|
|
|
return Dst;
|
|
|
|
}
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrNCat(CallInst *CI, IRBuilder<> &B) {
|
2016-01-01 00:10:49 +08:00
|
|
|
// Extract some information from the instruction.
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Dst = CI->getArgOperand(0);
|
|
|
|
Value *Src = CI->getArgOperand(1);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *Size = CI->getArgOperand(2);
|
2014-09-18 04:55:46 +08:00
|
|
|
uint64_t Len;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
|
|
|
if (isKnownNonZero(Size, DL))
|
|
|
|
annotateNonNullBasedOnAccess(CI, 1);
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
// We don't do anything if length is not constant.
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
ConstantInt *LengthArg = dyn_cast<ConstantInt>(Size);
|
|
|
|
if (LengthArg) {
|
2014-09-18 04:55:46 +08:00
|
|
|
Len = LengthArg->getZExtValue();
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
// strncat(x, c, 0) -> x
|
|
|
|
if (!Len)
|
|
|
|
return Dst;
|
|
|
|
} else {
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
}
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// See if we can get the length of the input string.
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t SrcLen = GetStringLength(Src);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (SrcLen) {
|
|
|
|
annotateDereferenceableBytes(CI, 1, SrcLen);
|
|
|
|
--SrcLen; // Unbias length.
|
|
|
|
} else {
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
}
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strncat(x, "", c) -> x
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (SrcLen == 0)
|
2014-09-18 04:55:46 +08:00
|
|
|
return Dst;
|
2012-10-14 00:45:32 +08:00
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
// We don't optimize this case.
|
2014-09-18 04:55:46 +08:00
|
|
|
if (Len < SrcLen)
|
|
|
|
return nullptr;
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strncat(x, s, c) -> strcat(x, s)
|
2016-01-01 00:10:49 +08:00
|
|
|
// s is constant so the strcat can be optimized further.
|
2014-09-18 04:55:46 +08:00
|
|
|
return emitStrLenMemCpy(Src, Dst, SrcLen, B);
|
|
|
|
}
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrChr(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
FunctionType *FT = Callee->getFunctionType();
|
|
|
|
Value *SrcStr = CI->getArgOperand(0);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// If the second operand is non-constant, see if we can compute the length
|
|
|
|
// of the input string and turn this into memchr.
|
|
|
|
ConstantInt *CharC = dyn_cast<ConstantInt>(CI->getArgOperand(1));
|
|
|
|
if (!CharC) {
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len = GetStringLength(SrcStr);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len)
|
|
|
|
annotateDereferenceableBytes(CI, 0, Len);
|
|
|
|
else
|
|
|
|
return nullptr;
|
|
|
|
if (!FT->getParamType(1)->isIntegerTy(32)) // memchr needs i32.
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitMemChr(SrcStr, CI->getArgOperand(1), // include nul.
|
2015-03-10 10:37:25 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len),
|
|
|
|
B, DL, TLI);
|
2012-10-14 00:45:37 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Otherwise, the character is a constant, see if the first argument is
|
|
|
|
// a string literal. If so, we can constant fold.
|
|
|
|
StringRef Str;
|
|
|
|
if (!getConstantStringInfo(SrcStr, Str)) {
|
2015-03-10 10:37:25 +08:00
|
|
|
if (CharC->isZero()) // strchr(p, 0) -> p + strlen(p)
|
Check result of emitStrLen before passing it to CreateGEP
Summary:
This fixes PR43081, where the transformation of `strchr(p, 0) -> p +
strlen(p)` can cause a segfault, if `-fno-builtin-strlen` is used. In
that case, `emitStrLen` returns nullptr, which CreateGEP is not designed
to handle. Also add the minimized code from the PR as a test case.
Reviewers: xbolva00, spatel, jdoerfert, efriedma
Reviewed By: efriedma
Subscribers: lebedev.ri, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D70143
2019-11-14 05:15:30 +08:00
|
|
|
if (Value *StrLen = emitStrLen(SrcStr, B, DL, TLI))
|
|
|
|
return B.CreateGEP(B.getInt8Ty(), SrcStr, StrLen, "strchr");
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Compute the offset, make sure to handle the case when we're searching for
|
|
|
|
// zero (a weird way to spell strlen).
|
|
|
|
size_t I = (0xFF & CharC->getSExtValue()) == 0
|
|
|
|
? Str.size()
|
|
|
|
: Str.find(CharC->getSExtValue());
|
|
|
|
if (I == StringRef::npos) // Didn't find the char. strchr returns null.
|
|
|
|
return Constant::getNullValue(CI->getType());
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strchr(s+n,c) -> gep(s+n+i,c)
|
2015-03-31 04:42:56 +08:00
|
|
|
return B.CreateGEP(B.getInt8Ty(), SrcStr, B.getInt64(I), "strchr");
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrRChr(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *SrcStr = CI->getArgOperand(0);
|
|
|
|
ConstantInt *CharC = dyn_cast<ConstantInt>(CI->getArgOperand(1));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Cannot fold anything if we're not looking for a constant.
|
|
|
|
if (!CharC)
|
|
|
|
return nullptr;
|
2012-10-14 00:45:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
StringRef Str;
|
|
|
|
if (!getConstantStringInfo(SrcStr, Str)) {
|
|
|
|
// strrchr(s, 0) -> strchr(s, 0)
|
2015-03-10 10:37:25 +08:00
|
|
|
if (CharC->isZero())
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitStrChr(SrcStr, '\0', B, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Compute the offset.
|
|
|
|
size_t I = (0xFF & CharC->getSExtValue()) == 0
|
|
|
|
? Str.size()
|
|
|
|
: Str.rfind(CharC->getSExtValue());
|
|
|
|
if (I == StringRef::npos) // Didn't find the char. Return null.
|
|
|
|
return Constant::getNullValue(CI->getType());
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strrchr(s+n,c) -> gep(s+n+i,c)
|
2015-03-31 04:42:56 +08:00
|
|
|
return B.CreateGEP(B.getInt8Ty(), SrcStr, B.getInt64(I), "strrchr");
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrCmp(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *Str1P = CI->getArgOperand(0), *Str2P = CI->getArgOperand(1);
|
|
|
|
if (Str1P == Str2P) // strcmp(x,x) -> 0
|
|
|
|
return ConstantInt::get(CI->getType(), 0);
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
StringRef Str1, Str2;
|
|
|
|
bool HasStr1 = getConstantStringInfo(Str1P, Str1);
|
|
|
|
bool HasStr2 = getConstantStringInfo(Str2P, Str2);
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strcmp(x, y) -> cnst (if both x and y are constant strings)
|
|
|
|
if (HasStr1 && HasStr2)
|
|
|
|
return ConstantInt::get(CI->getType(), Str1.compare(Str2));
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (HasStr1 && Str1.empty()) // strcmp("", x) -> -*x
|
2019-02-02 04:44:24 +08:00
|
|
|
return B.CreateNeg(B.CreateZExt(
|
|
|
|
B.CreateLoad(B.getInt8Ty(), Str2P, "strcmpload"), CI->getType()));
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (HasStr2 && Str2.empty()) // strcmp(x,"") -> *x
|
2019-02-02 04:44:24 +08:00
|
|
|
return B.CreateZExt(B.CreateLoad(B.getInt8Ty(), Str1P, "strcmpload"),
|
|
|
|
CI->getType());
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strcmp(P, "x") -> memcmp(P, "x", 2)
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len1 = GetStringLength(Str1P);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len1)
|
|
|
|
annotateDereferenceableBytes(CI, 0, Len1);
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len2 = GetStringLength(Str2P);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len2)
|
|
|
|
annotateDereferenceableBytes(CI, 1, Len2);
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (Len1 && Len2) {
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitMemCmp(Str1P, Str2P,
|
2015-03-10 10:37:25 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()),
|
2014-09-18 04:55:46 +08:00
|
|
|
std::min(Len1, Len2)),
|
|
|
|
B, DL, TLI);
|
|
|
|
}
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2018-08-10 12:32:54 +08:00
|
|
|
// strcmp to memcmp
|
|
|
|
if (!HasStr1 && HasStr2) {
|
|
|
|
if (canTransformToMemCmp(CI, Str1P, Len2, DL))
|
|
|
|
return emitMemCmp(
|
|
|
|
Str1P, Str2P,
|
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len2), B, DL,
|
|
|
|
TLI);
|
|
|
|
} else if (HasStr1 && !HasStr2) {
|
|
|
|
if (canTransformToMemCmp(CI, Str2P, Len1, DL))
|
|
|
|
return emitMemCmp(
|
|
|
|
Str1P, Str2P,
|
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len1), B, DL,
|
|
|
|
TLI);
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, {0, 1});
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrNCmp(CallInst *CI, IRBuilder<> &B) {
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *Str1P = CI->getArgOperand(0);
|
|
|
|
Value *Str2P = CI->getArgOperand(1);
|
|
|
|
Value *Size = CI->getArgOperand(2);
|
2014-09-18 04:55:46 +08:00
|
|
|
if (Str1P == Str2P) // strncmp(x,x,n) -> 0
|
|
|
|
return ConstantInt::get(CI->getType(), 0);
|
2012-10-15 11:47:37 +08:00
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (isKnownNonZero(Size, DL))
|
|
|
|
annotateNonNullBasedOnAccess(CI, {0, 1});
|
2014-09-18 04:55:46 +08:00
|
|
|
// Get the length argument if it is constant.
|
|
|
|
uint64_t Length;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (ConstantInt *LengthArg = dyn_cast<ConstantInt>(Size))
|
2014-09-18 04:55:46 +08:00
|
|
|
Length = LengthArg->getZExtValue();
|
|
|
|
else
|
|
|
|
return nullptr;
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (Length == 0) // strncmp(x,y,0) -> 0
|
|
|
|
return ConstantInt::get(CI->getType(), 0);
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2015-03-10 10:37:25 +08:00
|
|
|
if (Length == 1) // strncmp(x,y,1) -> memcmp(x,y,1)
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
return emitMemCmp(Str1P, Str2P, Size, B, DL, TLI);
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
StringRef Str1, Str2;
|
|
|
|
bool HasStr1 = getConstantStringInfo(Str1P, Str1);
|
|
|
|
bool HasStr2 = getConstantStringInfo(Str2P, Str2);
|
2012-10-15 11:47:37 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strncmp(x, y) -> cnst (if both x and y are constant strings)
|
|
|
|
if (HasStr1 && HasStr2) {
|
|
|
|
StringRef SubStr1 = Str1.substr(0, Length);
|
|
|
|
StringRef SubStr2 = Str2.substr(0, Length);
|
|
|
|
return ConstantInt::get(CI->getType(), SubStr1.compare(SubStr2));
|
2012-10-15 11:47:37 +08:00
|
|
|
}
|
2012-10-19 02:12:40 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (HasStr1 && Str1.empty()) // strncmp("", x, n) -> -*x
|
2019-02-02 04:44:24 +08:00
|
|
|
return B.CreateNeg(B.CreateZExt(
|
|
|
|
B.CreateLoad(B.getInt8Ty(), Str2P, "strcmpload"), CI->getType()));
|
2012-10-19 02:12:40 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (HasStr2 && Str2.empty()) // strncmp(x, "", n) -> *x
|
2019-02-02 04:44:24 +08:00
|
|
|
return B.CreateZExt(B.CreateLoad(B.getInt8Ty(), Str1P, "strcmpload"),
|
|
|
|
CI->getType());
|
2012-10-19 02:12:40 +08:00
|
|
|
|
2018-08-10 12:32:54 +08:00
|
|
|
uint64_t Len1 = GetStringLength(Str1P);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len1)
|
|
|
|
annotateDereferenceableBytes(CI, 0, Len1);
|
2018-08-10 12:32:54 +08:00
|
|
|
uint64_t Len2 = GetStringLength(Str2P);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len2)
|
|
|
|
annotateDereferenceableBytes(CI, 1, Len2);
|
2018-08-10 12:32:54 +08:00
|
|
|
|
|
|
|
// strncmp to memcmp
|
|
|
|
if (!HasStr1 && HasStr2) {
|
|
|
|
Len2 = std::min(Len2, Length);
|
|
|
|
if (canTransformToMemCmp(CI, Str1P, Len2, DL))
|
|
|
|
return emitMemCmp(
|
|
|
|
Str1P, Str2P,
|
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len2), B, DL,
|
|
|
|
TLI);
|
|
|
|
} else if (HasStr1 && !HasStr2) {
|
|
|
|
Len1 = std::min(Len1, Length);
|
|
|
|
if (canTransformToMemCmp(CI, Str2P, Len1, DL))
|
|
|
|
return emitMemCmp(
|
|
|
|
Str1P, Str2P,
|
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len1), B, DL,
|
|
|
|
TLI);
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-10-31 08:20:56 +08:00
|
|
|
|
2019-09-24 02:20:01 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrNDup(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *Src = CI->getArgOperand(0);
|
|
|
|
ConstantInt *Size = dyn_cast<ConstantInt>(CI->getArgOperand(1));
|
|
|
|
uint64_t SrcLen = GetStringLength(Src);
|
|
|
|
if (SrcLen && Size) {
|
|
|
|
annotateDereferenceableBytes(CI, 0, SrcLen);
|
|
|
|
if (SrcLen <= Size->getZExtValue() + 1)
|
|
|
|
return emitStrDup(Src, B, TLI);
|
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrCpy(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *Dst = CI->getArgOperand(0), *Src = CI->getArgOperand(1);
|
|
|
|
if (Dst == Src) // strcpy(x,x) -> x
|
|
|
|
return Src;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
|
|
|
|
annotateNonNullBasedOnAccess(CI, {0, 1});
|
2014-09-18 04:55:46 +08:00
|
|
|
// See if we can get the length of the input string.
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len = GetStringLength(Src);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len)
|
|
|
|
annotateDereferenceableBytes(CI, 1, Len);
|
|
|
|
else
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
2012-10-31 08:20:56 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// We have enough information to now generate the memcpy call to do the
|
|
|
|
// copy for us. Make a memcpy to copy the nul byte with align = 1.
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
CallInst *NewCI =
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
B.CreateMemCpy(Dst, Align(1), Src, Align(1),
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len));
|
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2014-09-18 04:55:46 +08:00
|
|
|
return Dst;
|
|
|
|
}
|
2012-10-31 08:20:56 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStpCpy(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
Value *Dst = CI->getArgOperand(0), *Src = CI->getArgOperand(1);
|
|
|
|
if (Dst == Src) { // stpcpy(x,x) -> x+strlen(x)
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *StrLen = emitStrLen(Src, B, DL, TLI);
|
2015-04-04 05:33:42 +08:00
|
|
|
return StrLen ? B.CreateInBoundsGEP(B.getInt8Ty(), Dst, StrLen) : nullptr;
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-10-31 11:33:00 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// See if we can get the length of the input string.
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len = GetStringLength(Src);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len)
|
|
|
|
annotateDereferenceableBytes(CI, 1, Len);
|
|
|
|
else
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
2012-10-31 11:33:00 +08:00
|
|
|
|
2015-11-03 07:07:14 +08:00
|
|
|
Type *PT = Callee->getFunctionType()->getParamType(0);
|
2015-03-10 10:37:25 +08:00
|
|
|
Value *LenV = ConstantInt::get(DL.getIntPtrType(PT), Len);
|
2016-01-01 00:10:49 +08:00
|
|
|
Value *DstEnd = B.CreateGEP(B.getInt8Ty(), Dst,
|
|
|
|
ConstantInt::get(DL.getIntPtrType(PT), Len - 1));
|
2012-10-31 11:33:00 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// We have enough information to now generate the memcpy call to do the
|
|
|
|
// copy for us. Make a memcpy to copy the nul byte with align = 1.
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI = B.CreateMemCpy(Dst, Align(1), Src, Align(1), LenV);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2014-09-18 04:55:46 +08:00
|
|
|
return DstEnd;
|
|
|
|
}
|
2012-10-31 11:33:00 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrNCpy(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
Value *Dst = CI->getArgOperand(0);
|
|
|
|
Value *Src = CI->getArgOperand(1);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *Size = CI->getArgOperand(2);
|
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
|
|
|
if (isKnownNonZero(Size, DL))
|
|
|
|
annotateNonNullBasedOnAccess(CI, 1);
|
|
|
|
|
|
|
|
uint64_t Len;
|
|
|
|
if (ConstantInt *LengthArg = dyn_cast<ConstantInt>(Size))
|
|
|
|
Len = LengthArg->getZExtValue();
|
|
|
|
else
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// strncpy(x, y, 0) -> x
|
|
|
|
if (Len == 0)
|
|
|
|
return Dst;
|
2012-10-31 11:33:00 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// See if we can get the length of the input string.
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t SrcLen = GetStringLength(Src);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (SrcLen) {
|
|
|
|
annotateDereferenceableBytes(CI, 1, SrcLen);
|
|
|
|
--SrcLen; // Unbias length.
|
|
|
|
} else {
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
}
|
2012-10-31 11:33:00 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (SrcLen == 0) {
|
2018-02-06 05:23:22 +08:00
|
|
|
// strncpy(x, "", y) -> memset(align 1 x, '\0', y)
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI = B.CreateMemSet(Dst, B.getInt8('\0'), Size, Align(1));
|
2019-09-18 01:12:24 +08:00
|
|
|
AttrBuilder ArgAttrs(CI->getAttributes().getParamAttributes(0));
|
|
|
|
NewCI->setAttributes(NewCI->getAttributes().addParamAttributes(
|
|
|
|
CI->getContext(), 0, ArgAttrs));
|
2012-10-31 11:33:00 +08:00
|
|
|
return Dst;
|
|
|
|
}
|
2012-10-31 11:33:06 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Let strncpy handle the zero padding
|
|
|
|
if (Len > SrcLen + 1)
|
|
|
|
return nullptr;
|
2012-10-31 12:29:58 +08:00
|
|
|
|
2015-11-03 07:07:14 +08:00
|
|
|
Type *PT = Callee->getFunctionType()->getParamType(0);
|
2018-02-06 05:23:22 +08:00
|
|
|
// strncpy(x, s, c) -> memcpy(align 1 x, align 1 s, c) [s and c are constant]
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI = B.CreateMemCpy(Dst, Align(1), Src, Align(1),
|
2019-12-16 22:24:13 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(PT), Len));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2014-09-18 04:55:46 +08:00
|
|
|
return Dst;
|
|
|
|
}
|
2012-10-31 12:29:58 +08:00
|
|
|
|
2017-05-20 06:37:09 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStringLength(CallInst *CI, IRBuilder<> &B,
|
|
|
|
unsigned CharSize) {
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Src = CI->getArgOperand(0);
|
|
|
|
|
|
|
|
// Constant folding: strlen("xyz") -> 3
|
2018-05-23 04:27:36 +08:00
|
|
|
if (uint64_t Len = GetStringLength(Src, CharSize))
|
2014-09-18 04:55:46 +08:00
|
|
|
return ConstantInt::get(CI->getType(), Len - 1);
|
|
|
|
|
2016-04-13 22:31:06 +08:00
|
|
|
// If s is a constant pointer pointing to a string literal, we can fold
|
2017-05-20 06:37:09 +08:00
|
|
|
// strlen(s + x) to strlen(s) - x, when x is known to be in the range
|
2016-04-13 22:31:06 +08:00
|
|
|
// [0, strlen(s)] or the string has a single null terminator '\0' at the end.
|
2017-05-20 06:37:09 +08:00
|
|
|
// We only try to simplify strlen when the pointer s points to an array
|
2016-04-13 22:31:06 +08:00
|
|
|
// of i8. Otherwise, we would need to scale the offset x before doing the
|
2017-05-20 06:37:09 +08:00
|
|
|
// subtraction. This will make the optimization more complex, and it's not
|
|
|
|
// very useful because calling strlen for a pointer of other types is
|
2016-04-13 22:31:06 +08:00
|
|
|
// very uncommon.
|
|
|
|
if (GEPOperator *GEP = dyn_cast<GEPOperator>(Src)) {
|
2017-05-20 06:37:09 +08:00
|
|
|
if (!isGEPBasedOnPointerToString(GEP, CharSize))
|
2016-04-13 22:31:06 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2017-05-20 06:37:09 +08:00
|
|
|
ConstantDataArraySlice Slice;
|
|
|
|
if (getConstantDataArrayInfo(GEP->getOperand(0), Slice, CharSize)) {
|
|
|
|
uint64_t NullTermIdx;
|
|
|
|
if (Slice.Array == nullptr) {
|
|
|
|
NullTermIdx = 0;
|
|
|
|
} else {
|
|
|
|
NullTermIdx = ~((uint64_t)0);
|
|
|
|
for (uint64_t I = 0, E = Slice.Length; I < E; ++I) {
|
|
|
|
if (Slice.Array->getElementAsInteger(I + Slice.Offset) == 0) {
|
|
|
|
NullTermIdx = I;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// If the string does not have '\0', leave it to strlen to compute
|
|
|
|
// its length.
|
|
|
|
if (NullTermIdx == ~((uint64_t)0))
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2016-04-13 22:31:06 +08:00
|
|
|
Value *Offset = GEP->getOperand(2);
|
2017-05-25 00:53:07 +08:00
|
|
|
KnownBits Known = computeKnownBits(Offset, DL, 0, nullptr, CI, nullptr);
|
2017-04-27 00:39:58 +08:00
|
|
|
Known.Zero.flipAllBits();
|
2017-05-20 06:37:09 +08:00
|
|
|
uint64_t ArrSize =
|
2016-04-13 22:31:06 +08:00
|
|
|
cast<ArrayType>(GEP->getSourceElementType())->getNumElements();
|
|
|
|
|
2017-05-20 06:37:09 +08:00
|
|
|
// KnownZero's bits are flipped, so zeros in KnownZero now represent
|
|
|
|
// bits known to be zeros in Offset, and ones in KnowZero represent
|
2016-04-13 22:31:06 +08:00
|
|
|
// bits unknown in Offset. Therefore, Offset is known to be in range
|
2017-05-20 06:37:09 +08:00
|
|
|
// [0, NullTermIdx] when the flipped KnownZero is non-negative and
|
2016-04-13 22:31:06 +08:00
|
|
|
// unsigned-less-than NullTermIdx.
|
|
|
|
//
|
2017-05-20 06:37:09 +08:00
|
|
|
// If Offset is not provably in the range [0, NullTermIdx], we can still
|
|
|
|
// optimize if we can prove that the program has undefined behavior when
|
|
|
|
// Offset is outside that range. That is the case when GEP->getOperand(0)
|
2016-04-13 22:31:06 +08:00
|
|
|
// is a pointer to an object whose memory extent is NullTermIdx+1.
|
2017-05-20 06:37:09 +08:00
|
|
|
if ((Known.Zero.isNonNegative() && Known.Zero.ule(NullTermIdx)) ||
|
2016-04-13 22:31:06 +08:00
|
|
|
(GEP->isInBounds() && isa<GlobalVariable>(GEP->getOperand(0)) &&
|
2017-05-20 06:37:09 +08:00
|
|
|
NullTermIdx == ArrSize - 1)) {
|
|
|
|
Offset = B.CreateSExtOrTrunc(Offset, CI->getType());
|
|
|
|
return B.CreateSub(ConstantInt::get(CI->getType(), NullTermIdx),
|
2016-04-13 22:31:06 +08:00
|
|
|
Offset);
|
2017-05-20 06:37:09 +08:00
|
|
|
}
|
2016-04-13 22:31:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strlen(x?"foo":"bars") --> x ? 3 : 4
|
|
|
|
if (SelectInst *SI = dyn_cast<SelectInst>(Src)) {
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t LenTrue = GetStringLength(SI->getTrueValue(), CharSize);
|
|
|
|
uint64_t LenFalse = GetStringLength(SI->getFalseValue(), CharSize);
|
2014-09-18 04:55:46 +08:00
|
|
|
if (LenTrue && LenFalse) {
|
2017-10-12 01:12:59 +08:00
|
|
|
ORE.emit([&]() {
|
|
|
|
return OptimizationRemark("instcombine", "simplify-libcalls", CI)
|
|
|
|
<< "folded strlen(select) to select of constants";
|
|
|
|
});
|
2014-09-18 04:55:46 +08:00
|
|
|
return B.CreateSelect(SI->getCondition(),
|
|
|
|
ConstantInt::get(CI->getType(), LenTrue - 1),
|
|
|
|
ConstantInt::get(CI->getType(), LenFalse - 1));
|
2012-10-31 12:29:58 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strlen(x) != 0 --> *x != 0
|
|
|
|
// strlen(x) == 0 --> *x == 0
|
|
|
|
if (isOnlyUsedInZeroEqualityComparison(CI))
|
2019-02-02 04:44:24 +08:00
|
|
|
return B.CreateZExt(B.CreateLoad(B.getIntNTy(CharSize), Src, "strlenfirst"),
|
|
|
|
CI->getType());
|
2012-10-31 22:58:26 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-10-31 22:58:26 +08:00
|
|
|
|
2017-05-20 06:37:09 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrLen(CallInst *CI, IRBuilder<> &B) {
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Value *V = optimizeStringLength(CI, B, 8))
|
|
|
|
return V;
|
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
|
|
|
return nullptr;
|
2017-05-20 06:37:09 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeWcslen(CallInst *CI, IRBuilder<> &B) {
|
2018-06-01 00:39:27 +08:00
|
|
|
Module &M = *CI->getModule();
|
2017-05-20 06:37:09 +08:00
|
|
|
unsigned WCharSize = TLI->getWCharSize(M) * 8;
|
2017-09-26 10:36:57 +08:00
|
|
|
// We cannot perform this optimization without wchar_size metadata.
|
|
|
|
if (WCharSize == 0)
|
|
|
|
return nullptr;
|
2017-05-20 06:37:09 +08:00
|
|
|
|
|
|
|
return optimizeStringLength(CI, B, WCharSize);
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrPBrk(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
StringRef S1, S2;
|
|
|
|
bool HasS1 = getConstantStringInfo(CI->getArgOperand(0), S1);
|
|
|
|
bool HasS2 = getConstantStringInfo(CI->getArgOperand(1), S2);
|
2012-11-08 09:33:50 +08:00
|
|
|
|
2014-11-14 06:55:19 +08:00
|
|
|
// strpbrk(s, "") -> nullptr
|
|
|
|
// strpbrk("", s) -> nullptr
|
2014-09-18 04:55:46 +08:00
|
|
|
if ((HasS1 && S1.empty()) || (HasS2 && S2.empty()))
|
|
|
|
return Constant::getNullValue(CI->getType());
|
2012-11-08 09:33:50 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Constant folding.
|
|
|
|
if (HasS1 && HasS2) {
|
|
|
|
size_t I = S1.find_first_of(S2);
|
|
|
|
if (I == StringRef::npos) // No match.
|
2012-11-08 09:33:50 +08:00
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
return B.CreateGEP(B.getInt8Ty(), CI->getArgOperand(0), B.getInt64(I),
|
|
|
|
"strpbrk");
|
2012-11-08 09:33:50 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strpbrk(s, "a") -> strchr(s, 'a')
|
2015-03-10 10:37:25 +08:00
|
|
|
if (HasS2 && S2.size() == 1)
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitStrChr(CI->getArgOperand(0), S2[0], B, TLI);
|
2012-11-10 23:16:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-10 23:16:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrTo(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *EndPtr = CI->getArgOperand(1);
|
|
|
|
if (isa<ConstantPointerNull>(EndPtr)) {
|
|
|
|
// With a null EndPtr, this function won't capture the main argument.
|
|
|
|
// It would be readonly too, except that it still may write to errno.
|
2017-05-04 02:17:31 +08:00
|
|
|
CI->addParamAttr(0, Attribute::NoCapture);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-11-10 23:16:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-10 23:16:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrSpn(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
StringRef S1, S2;
|
|
|
|
bool HasS1 = getConstantStringInfo(CI->getArgOperand(0), S1);
|
|
|
|
bool HasS2 = getConstantStringInfo(CI->getArgOperand(1), S2);
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strspn(s, "") -> 0
|
|
|
|
// strspn("", s) -> 0
|
|
|
|
if ((HasS1 && S1.empty()) || (HasS2 && S2.empty()))
|
|
|
|
return Constant::getNullValue(CI->getType());
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Constant folding.
|
|
|
|
if (HasS1 && HasS2) {
|
|
|
|
size_t Pos = S1.find_first_not_of(S2);
|
|
|
|
if (Pos == StringRef::npos)
|
|
|
|
Pos = S1.size();
|
|
|
|
return ConstantInt::get(CI->getType(), Pos);
|
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeStrCSpn(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
StringRef S1, S2;
|
|
|
|
bool HasS1 = getConstantStringInfo(CI->getArgOperand(0), S1);
|
|
|
|
bool HasS2 = getConstantStringInfo(CI->getArgOperand(1), S2);
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strcspn("", s) -> 0
|
|
|
|
if (HasS1 && S1.empty())
|
|
|
|
return Constant::getNullValue(CI->getType());
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Constant folding.
|
|
|
|
if (HasS1 && HasS2) {
|
|
|
|
size_t Pos = S1.find_first_of(S2);
|
|
|
|
if (Pos == StringRef::npos)
|
|
|
|
Pos = S1.size();
|
|
|
|
return ConstantInt::get(CI->getType(), Pos);
|
|
|
|
}
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strcspn(s, "") -> strlen(s)
|
2015-03-10 10:37:25 +08:00
|
|
|
if (HasS2 && S2.empty())
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitStrLen(CI->getArgOperand(0), B, DL, TLI);
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-11 11:51:48 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStrStr(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// fold strstr(x, x) -> x.
|
|
|
|
if (CI->getArgOperand(0) == CI->getArgOperand(1))
|
|
|
|
return B.CreateBitCast(CI->getArgOperand(0), CI->getType());
|
|
|
|
|
|
|
|
// fold strstr(a, b) == a -> strncmp(a, b, strlen(b)) == 0
|
2015-03-10 10:37:25 +08:00
|
|
|
if (isOnlyUsedInEqualityComparison(CI, CI->getArgOperand(0))) {
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *StrLen = emitStrLen(CI->getArgOperand(1), B, DL, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
if (!StrLen)
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *StrNCmp = emitStrNCmp(CI->getArgOperand(0), CI->getArgOperand(1),
|
2014-09-18 04:55:46 +08:00
|
|
|
StrLen, B, DL, TLI);
|
|
|
|
if (!StrNCmp)
|
|
|
|
return nullptr;
|
|
|
|
for (auto UI = CI->user_begin(), UE = CI->user_end(); UI != UE;) {
|
|
|
|
ICmpInst *Old = cast<ICmpInst>(*UI++);
|
|
|
|
Value *Cmp =
|
|
|
|
B.CreateICmp(Old->getPredicate(), StrNCmp,
|
|
|
|
ConstantInt::getNullValue(StrNCmp->getType()), "cmp");
|
|
|
|
replaceAllUsesWith(Old, Cmp);
|
|
|
|
}
|
|
|
|
return CI;
|
|
|
|
}
|
2012-11-11 13:11:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// See if either input string is a constant string.
|
|
|
|
StringRef SearchStr, ToFindStr;
|
|
|
|
bool HasStr1 = getConstantStringInfo(CI->getArgOperand(0), SearchStr);
|
|
|
|
bool HasStr2 = getConstantStringInfo(CI->getArgOperand(1), ToFindStr);
|
2012-11-11 13:11:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// fold strstr(x, "") -> x.
|
|
|
|
if (HasStr2 && ToFindStr.empty())
|
|
|
|
return B.CreateBitCast(CI->getArgOperand(0), CI->getType());
|
2012-11-11 13:11:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// If both strings are known, constant fold it.
|
|
|
|
if (HasStr1 && HasStr2) {
|
|
|
|
size_t Offset = SearchStr.find(ToFindStr);
|
2012-11-11 13:11:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (Offset == StringRef::npos) // strstr("foo", "bar") -> null
|
2012-11-11 13:11:20 +08:00
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// strstr("abcd", "bc") -> gep((char*)"abcd", 1)
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *Result = castToCStr(CI->getArgOperand(0), B);
|
2019-02-02 04:44:47 +08:00
|
|
|
Result =
|
|
|
|
B.CreateConstInBoundsGEP1_64(B.getInt8Ty(), Result, Offset, "strstr");
|
2014-09-18 04:55:46 +08:00
|
|
|
return B.CreateBitCast(Result, CI->getType());
|
|
|
|
}
|
2012-11-11 13:11:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// fold strstr(x, "y") -> strchr(x, 'y').
|
|
|
|
if (HasStr2 && ToFindStr.size() == 1) {
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *StrChr = emitStrChr(CI->getArgOperand(0), ToFindStr[0], B, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
return StrChr ? B.CreateBitCast(StrChr, CI->getType()) : nullptr;
|
|
|
|
}
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
|
|
|
|
annotateNonNullBasedOnAccess(CI, {0, 1});
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeMemRChr(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (isKnownNonZero(CI->getOperand(2), DL))
|
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-11 13:11:20 +08:00
|
|
|
|
2015-03-21 23:36:21 +08:00
|
|
|
Value *LibCallSimplifier::optimizeMemChr(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *SrcStr = CI->getArgOperand(0);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *Size = CI->getArgOperand(2);
|
|
|
|
annotateNonNullAndDereferenceable(CI, 0, Size, DL);
|
2015-03-21 23:36:21 +08:00
|
|
|
ConstantInt *CharC = dyn_cast<ConstantInt>(CI->getArgOperand(1));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
ConstantInt *LenC = dyn_cast<ConstantInt>(Size);
|
2015-03-21 23:36:21 +08:00
|
|
|
|
|
|
|
// memchr(x, y, 0) -> null
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
if (LenC) {
|
|
|
|
if (LenC->isZero())
|
|
|
|
return Constant::getNullValue(CI->getType());
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
} else {
|
|
|
|
// From now on we need at least constant length and string.
|
|
|
|
return nullptr;
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
}
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
|
2015-03-21 23:36:21 +08:00
|
|
|
StringRef Str;
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (!getConstantStringInfo(SrcStr, Str, 0, /*TrimAtNul=*/false))
|
2015-03-21 23:36:21 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Truncate the string to LenC. If Str is smaller than LenC we will still only
|
|
|
|
// scan the string, as reading past the end of it is undefined and we can just
|
|
|
|
// return null if we don't find the char.
|
|
|
|
Str = Str.substr(0, LenC->getZExtValue());
|
|
|
|
|
[SimplifyLibCalls] Turn memchr(const, C, const) into a bitfield check.
strchr("123!", C) != nullptr is a common pattern to check if C is one
of 1, 2, 3 or !. If the largest element of the string is smaller than
the target's register size we can easily create a bitfield and just
do a simple test for set membership.
int foo(char C) { return strchr("123!", C) != nullptr; } now becomes
cmpl $64, %edi ## range check
sbbb %al, %al
movabsq $0xE000200000001, %rcx
btq %rdi, %rcx ## bit test
sbbb %cl, %cl
andb %al, %cl ## and the two conditions
andb $1, %cl
movzbl %cl, %eax ## returning an int
ret
(imho the backend should expand this into a series of branches, but
that's a different story)
The code is currently limited to bit fields that fit in a register, so
usually 64 or 32 bits. Sadly, this misses anything using alpha chars
or {}. This could be fixed by just emitting a i128 bit field, but that
can generate really ugly code so we have to find a better way. To some
degree this is also recreating switch lowering logic, but we can't
simply emit a switch instruction and thus change the CFG within
instcombine.
llvm-svn: 232902
2015-03-22 05:09:33 +08:00
|
|
|
// If the char is variable but the input str and length are not we can turn
|
|
|
|
// this memchr call into a simple bit field test. Of course this only works
|
|
|
|
// when the return value is only checked against null.
|
|
|
|
//
|
|
|
|
// It would be really nice to reuse switch lowering here but we can't change
|
|
|
|
// the CFG at this point.
|
|
|
|
//
|
2019-03-12 18:31:52 +08:00
|
|
|
// memchr("\r\n", C, 2) != nullptr -> (1 << C & ((1 << '\r') | (1 << '\n')))
|
|
|
|
// != 0
|
[SimplifyLibCalls] Turn memchr(const, C, const) into a bitfield check.
strchr("123!", C) != nullptr is a common pattern to check if C is one
of 1, 2, 3 or !. If the largest element of the string is smaller than
the target's register size we can easily create a bitfield and just
do a simple test for set membership.
int foo(char C) { return strchr("123!", C) != nullptr; } now becomes
cmpl $64, %edi ## range check
sbbb %al, %al
movabsq $0xE000200000001, %rcx
btq %rdi, %rcx ## bit test
sbbb %cl, %cl
andb %al, %cl ## and the two conditions
andb $1, %cl
movzbl %cl, %eax ## returning an int
ret
(imho the backend should expand this into a series of branches, but
that's a different story)
The code is currently limited to bit fields that fit in a register, so
usually 64 or 32 bits. Sadly, this misses anything using alpha chars
or {}. This could be fixed by just emitting a i128 bit field, but that
can generate really ugly code so we have to find a better way. To some
degree this is also recreating switch lowering logic, but we can't
simply emit a switch instruction and thus change the CFG within
instcombine.
llvm-svn: 232902
2015-03-22 05:09:33 +08:00
|
|
|
// after bounds check.
|
|
|
|
if (!CharC && !Str.empty() && isOnlyUsedInZeroEqualityComparison(CI)) {
|
2015-03-22 06:04:26 +08:00
|
|
|
unsigned char Max =
|
|
|
|
*std::max_element(reinterpret_cast<const unsigned char *>(Str.begin()),
|
|
|
|
reinterpret_cast<const unsigned char *>(Str.end()));
|
[SimplifyLibCalls] Turn memchr(const, C, const) into a bitfield check.
strchr("123!", C) != nullptr is a common pattern to check if C is one
of 1, 2, 3 or !. If the largest element of the string is smaller than
the target's register size we can easily create a bitfield and just
do a simple test for set membership.
int foo(char C) { return strchr("123!", C) != nullptr; } now becomes
cmpl $64, %edi ## range check
sbbb %al, %al
movabsq $0xE000200000001, %rcx
btq %rdi, %rcx ## bit test
sbbb %cl, %cl
andb %al, %cl ## and the two conditions
andb $1, %cl
movzbl %cl, %eax ## returning an int
ret
(imho the backend should expand this into a series of branches, but
that's a different story)
The code is currently limited to bit fields that fit in a register, so
usually 64 or 32 bits. Sadly, this misses anything using alpha chars
or {}. This could be fixed by just emitting a i128 bit field, but that
can generate really ugly code so we have to find a better way. To some
degree this is also recreating switch lowering logic, but we can't
simply emit a switch instruction and thus change the CFG within
instcombine.
llvm-svn: 232902
2015-03-22 05:09:33 +08:00
|
|
|
|
|
|
|
// Make sure the bit field we're about to create fits in a register on the
|
|
|
|
// target.
|
|
|
|
// FIXME: On a 64 bit architecture this prevents us from using the
|
|
|
|
// interesting range of alpha ascii chars. We could do better by emitting
|
|
|
|
// two bitfields or shifting the range by 64 if no lower chars are used.
|
|
|
|
if (!DL.fitsInLegalInteger(Max + 1))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// For the bit field use a power-of-2 type with at least 8 bits to avoid
|
|
|
|
// creating unnecessary illegal types.
|
|
|
|
unsigned char Width = NextPowerOf2(std::max((unsigned char)7, Max));
|
|
|
|
|
|
|
|
// Now build the bit field.
|
|
|
|
APInt Bitfield(Width, 0);
|
|
|
|
for (char C : Str)
|
|
|
|
Bitfield.setBit((unsigned char)C);
|
|
|
|
Value *BitfieldC = B.getInt(Bitfield);
|
|
|
|
|
2019-01-10 07:39:26 +08:00
|
|
|
// Adjust width of "C" to the bitfield width, then mask off the high bits.
|
[SimplifyLibCalls] Turn memchr(const, C, const) into a bitfield check.
strchr("123!", C) != nullptr is a common pattern to check if C is one
of 1, 2, 3 or !. If the largest element of the string is smaller than
the target's register size we can easily create a bitfield and just
do a simple test for set membership.
int foo(char C) { return strchr("123!", C) != nullptr; } now becomes
cmpl $64, %edi ## range check
sbbb %al, %al
movabsq $0xE000200000001, %rcx
btq %rdi, %rcx ## bit test
sbbb %cl, %cl
andb %al, %cl ## and the two conditions
andb $1, %cl
movzbl %cl, %eax ## returning an int
ret
(imho the backend should expand this into a series of branches, but
that's a different story)
The code is currently limited to bit fields that fit in a register, so
usually 64 or 32 bits. Sadly, this misses anything using alpha chars
or {}. This could be fixed by just emitting a i128 bit field, but that
can generate really ugly code so we have to find a better way. To some
degree this is also recreating switch lowering logic, but we can't
simply emit a switch instruction and thus change the CFG within
instcombine.
llvm-svn: 232902
2015-03-22 05:09:33 +08:00
|
|
|
Value *C = B.CreateZExtOrTrunc(CI->getArgOperand(1), BitfieldC->getType());
|
2019-01-10 07:39:26 +08:00
|
|
|
C = B.CreateAnd(C, B.getIntN(Width, 0xFF));
|
|
|
|
|
|
|
|
// First check that the bit field access is within bounds.
|
[SimplifyLibCalls] Turn memchr(const, C, const) into a bitfield check.
strchr("123!", C) != nullptr is a common pattern to check if C is one
of 1, 2, 3 or !. If the largest element of the string is smaller than
the target's register size we can easily create a bitfield and just
do a simple test for set membership.
int foo(char C) { return strchr("123!", C) != nullptr; } now becomes
cmpl $64, %edi ## range check
sbbb %al, %al
movabsq $0xE000200000001, %rcx
btq %rdi, %rcx ## bit test
sbbb %cl, %cl
andb %al, %cl ## and the two conditions
andb $1, %cl
movzbl %cl, %eax ## returning an int
ret
(imho the backend should expand this into a series of branches, but
that's a different story)
The code is currently limited to bit fields that fit in a register, so
usually 64 or 32 bits. Sadly, this misses anything using alpha chars
or {}. This could be fixed by just emitting a i128 bit field, but that
can generate really ugly code so we have to find a better way. To some
degree this is also recreating switch lowering logic, but we can't
simply emit a switch instruction and thus change the CFG within
instcombine.
llvm-svn: 232902
2015-03-22 05:09:33 +08:00
|
|
|
Value *Bounds = B.CreateICmp(ICmpInst::ICMP_ULT, C, B.getIntN(Width, Width),
|
|
|
|
"memchr.bounds");
|
|
|
|
|
|
|
|
// Create code that checks if the given bit is set in the field.
|
|
|
|
Value *Shl = B.CreateShl(B.getIntN(Width, 1ULL), C);
|
|
|
|
Value *Bits = B.CreateIsNotNull(B.CreateAnd(Shl, BitfieldC), "memchr.bits");
|
|
|
|
|
|
|
|
// Finally merge both checks and cast to pointer type. The inttoptr
|
|
|
|
// implicitly zexts the i1 to intptr type.
|
|
|
|
return B.CreateIntToPtr(B.CreateAnd(Bounds, Bits, "memchr"), CI->getType());
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check if all arguments are constants. If so, we can constant fold.
|
|
|
|
if (!CharC)
|
|
|
|
return nullptr;
|
|
|
|
|
2015-03-21 23:36:21 +08:00
|
|
|
// Compute the offset.
|
|
|
|
size_t I = Str.find(CharC->getSExtValue() & 0xFF);
|
|
|
|
if (I == StringRef::npos) // Didn't find the char. memchr returns null.
|
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
|
|
|
|
// memchr(s+n,c,l) -> gep(s+n+i,c)
|
2015-03-31 04:42:56 +08:00
|
|
|
return B.CreateGEP(B.getInt8Ty(), SrcStr, B.getInt64(I), "memchr");
|
2015-03-21 23:36:21 +08:00
|
|
|
}
|
|
|
|
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
static Value *optimizeMemCmpConstantSize(CallInst *CI, Value *LHS, Value *RHS,
|
|
|
|
uint64_t Len, IRBuilder<> &B,
|
|
|
|
const DataLayout &DL) {
|
2014-09-18 04:55:46 +08:00
|
|
|
if (Len == 0) // memcmp(s1,s2,0) -> 0
|
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
|
|
|
|
// memcmp(S1,S2,1) -> *(unsigned char*)LHS - *(unsigned char*)RHS
|
|
|
|
if (Len == 1) {
|
2019-02-02 04:44:24 +08:00
|
|
|
Value *LHSV =
|
|
|
|
B.CreateZExt(B.CreateLoad(B.getInt8Ty(), castToCStr(LHS, B), "lhsc"),
|
|
|
|
CI->getType(), "lhsv");
|
|
|
|
Value *RHSV =
|
|
|
|
B.CreateZExt(B.CreateLoad(B.getInt8Ty(), castToCStr(RHS, B), "rhsc"),
|
|
|
|
CI->getType(), "rhsv");
|
2014-09-18 04:55:46 +08:00
|
|
|
return B.CreateSub(LHSV, RHSV, "chardiff");
|
|
|
|
}
|
|
|
|
|
2015-08-29 02:30:18 +08:00
|
|
|
// memcmp(S1,S2,N/8)==0 -> (*(intN_t*)S1 != *(intN_t*)S2)==0
|
2017-08-22 03:13:14 +08:00
|
|
|
// TODO: The case where both inputs are constants does not need to be limited
|
|
|
|
// to legal integers or equality comparison. See block below this.
|
2015-08-29 02:30:18 +08:00
|
|
|
if (DL.isLegalInteger(Len * 8) && isOnlyUsedInZeroEqualityComparison(CI)) {
|
|
|
|
IntegerType *IntType = IntegerType::get(CI->getContext(), Len * 8);
|
|
|
|
unsigned PrefAlignment = DL.getPrefTypeAlignment(IntType);
|
|
|
|
|
2017-08-22 03:13:14 +08:00
|
|
|
// First, see if we can fold either argument to a constant.
|
|
|
|
Value *LHSV = nullptr;
|
|
|
|
if (auto *LHSC = dyn_cast<Constant>(LHS)) {
|
|
|
|
LHSC = ConstantExpr::getBitCast(LHSC, IntType->getPointerTo());
|
|
|
|
LHSV = ConstantFoldLoadFromConstPtr(LHSC, IntType, DL);
|
|
|
|
}
|
|
|
|
Value *RHSV = nullptr;
|
|
|
|
if (auto *RHSC = dyn_cast<Constant>(RHS)) {
|
|
|
|
RHSC = ConstantExpr::getBitCast(RHSC, IntType->getPointerTo());
|
|
|
|
RHSV = ConstantFoldLoadFromConstPtr(RHSC, IntType, DL);
|
|
|
|
}
|
2017-08-21 23:16:25 +08:00
|
|
|
|
2017-08-22 03:13:14 +08:00
|
|
|
// Don't generate unaligned loads. If either source is constant data,
|
|
|
|
// alignment doesn't matter for that source because there is no load.
|
|
|
|
if ((LHSV || getKnownAlignment(LHS, DL, CI) >= PrefAlignment) &&
|
|
|
|
(RHSV || getKnownAlignment(RHS, DL, CI) >= PrefAlignment)) {
|
|
|
|
if (!LHSV) {
|
|
|
|
Type *LHSPtrTy =
|
|
|
|
IntType->getPointerTo(LHS->getType()->getPointerAddressSpace());
|
2019-02-02 04:44:24 +08:00
|
|
|
LHSV = B.CreateLoad(IntType, B.CreateBitCast(LHS, LHSPtrTy), "lhsv");
|
2017-08-22 03:13:14 +08:00
|
|
|
}
|
|
|
|
if (!RHSV) {
|
|
|
|
Type *RHSPtrTy =
|
|
|
|
IntType->getPointerTo(RHS->getType()->getPointerAddressSpace());
|
2019-02-02 04:44:24 +08:00
|
|
|
RHSV = B.CreateLoad(IntType, B.CreateBitCast(RHS, RHSPtrTy), "rhsv");
|
2017-08-22 03:13:14 +08:00
|
|
|
}
|
2015-08-29 02:30:18 +08:00
|
|
|
return B.CreateZExt(B.CreateICmpNE(LHSV, RHSV), CI->getType(), "memcmp");
|
2017-08-21 23:16:25 +08:00
|
|
|
}
|
2015-08-29 02:30:18 +08:00
|
|
|
}
|
|
|
|
|
2017-08-22 03:13:14 +08:00
|
|
|
// Constant folding: memcmp(x, y, Len) -> constant (all arguments are const).
|
|
|
|
// TODO: This is limited to i8 arrays.
|
2014-09-18 04:55:46 +08:00
|
|
|
StringRef LHSStr, RHSStr;
|
|
|
|
if (getConstantStringInfo(LHS, LHSStr) &&
|
|
|
|
getConstantStringInfo(RHS, RHSStr)) {
|
|
|
|
// Make sure we're not reading out-of-bounds memory.
|
|
|
|
if (Len > LHSStr.size() || Len > RHSStr.size())
|
|
|
|
return nullptr;
|
|
|
|
// Fold the memcmp and normalize the result. This way we get consistent
|
|
|
|
// results across multiple platforms.
|
|
|
|
uint64_t Ret = 0;
|
|
|
|
int Cmp = memcmp(LHSStr.data(), RHSStr.data(), Len);
|
|
|
|
if (Cmp < 0)
|
|
|
|
Ret = -1;
|
|
|
|
else if (Cmp > 0)
|
|
|
|
Ret = 1;
|
|
|
|
return ConstantInt::get(CI->getType(), Ret);
|
2012-11-11 13:54:34 +08:00
|
|
|
}
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2019-05-06 17:15:22 +08:00
|
|
|
// Most simplifications for memcmp also apply to bcmp.
|
|
|
|
Value *LibCallSimplifier::optimizeMemCmpBCmpCommon(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
Value *LHS = CI->getArgOperand(0), *RHS = CI->getArgOperand(1);
|
|
|
|
Value *Size = CI->getArgOperand(2);
|
|
|
|
|
|
|
|
if (LHS == RHS) // memcmp(s,s,x) -> 0
|
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullAndDereferenceable(CI, {0, 1}, Size, DL);
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
// Handle constant lengths.
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
ConstantInt *LenC = dyn_cast<ConstantInt>(Size);
|
|
|
|
if (!LenC)
|
|
|
|
return nullptr;
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
// memcmp(d,s,0) -> 0
|
|
|
|
if (LenC->getZExtValue() == 0)
|
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
|
|
|
|
if (Value *Res =
|
|
|
|
optimizeMemCmpConstantSize(CI, LHS, RHS, LenC->getZExtValue(), B, DL))
|
|
|
|
return Res;
|
2019-05-06 17:15:22 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeMemCmp(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (Value *V = optimizeMemCmpBCmpCommon(CI, B))
|
|
|
|
return V;
|
|
|
|
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
// memcmp(x, y, Len) == 0 -> bcmp(x, y, Len) == 0
|
2019-07-25 07:31:04 +08:00
|
|
|
// bcmp can be more efficient than memcmp because it only has to know that
|
|
|
|
// there is a difference, not how different one is to the other.
|
|
|
|
if (TLI->has(LibFunc_bcmp) && isOnlyUsedInZeroEqualityComparison(CI)) {
|
2019-05-06 17:15:22 +08:00
|
|
|
Value *LHS = CI->getArgOperand(0);
|
|
|
|
Value *RHS = CI->getArgOperand(1);
|
|
|
|
Value *Size = CI->getArgOperand(2);
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
return emitBCmp(LHS, RHS, Size, B, DL, TLI);
|
|
|
|
}
|
2012-11-11 13:54:34 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-11 14:22:40 +08:00
|
|
|
|
2019-05-06 17:15:22 +08:00
|
|
|
Value *LibCallSimplifier::optimizeBCmp(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
return optimizeMemCmpBCmpCommon(CI, B);
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *LibCallSimplifier::optimizeMemCpy(CallInst *CI, IRBuilder<> &B) {
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
Value *Size = CI->getArgOperand(2);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullAndDereferenceable(CI, {0, 1}, Size, DL);
|
|
|
|
if (isa<IntrinsicInst>(CI))
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2018-02-06 05:23:22 +08:00
|
|
|
// memcpy(x, y, n) -> llvm.memcpy(align 1 x, align 1 y, n)
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI = B.CreateMemCpy(CI->getArgOperand(0), Align(1),
|
|
|
|
CI->getArgOperand(1), Align(1), Size);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2014-09-18 04:55:46 +08:00
|
|
|
return CI->getArgOperand(0);
|
|
|
|
}
|
2012-11-11 14:49:03 +08:00
|
|
|
|
2019-11-26 03:15:25 +08:00
|
|
|
Value *LibCallSimplifier::optimizeMemCCpy(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *Dst = CI->getArgOperand(0);
|
|
|
|
Value *Src = CI->getArgOperand(1);
|
|
|
|
ConstantInt *StopChar = dyn_cast<ConstantInt>(CI->getArgOperand(2));
|
|
|
|
ConstantInt *N = dyn_cast<ConstantInt>(CI->getArgOperand(3));
|
|
|
|
StringRef SrcStr;
|
|
|
|
if (CI->use_empty() && Dst == Src)
|
|
|
|
return Dst;
|
|
|
|
// memccpy(d, s, c, 0) -> nullptr
|
|
|
|
if (N) {
|
|
|
|
if (N->isNullValue())
|
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
if (!getConstantStringInfo(Src, SrcStr, /*Offset=*/0,
|
|
|
|
/*TrimAtNul=*/false) ||
|
|
|
|
!StopChar)
|
|
|
|
return nullptr;
|
|
|
|
} else {
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Wrap arg 'c' of type int to char
|
|
|
|
size_t Pos = SrcStr.find(StopChar->getSExtValue() & 0xFF);
|
|
|
|
if (Pos == StringRef::npos) {
|
|
|
|
if (N->getZExtValue() <= SrcStr.size()) {
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
B.CreateMemCpy(Dst, Align(1), Src, Align(1), CI->getArgOperand(3));
|
2019-11-26 03:15:25 +08:00
|
|
|
return Constant::getNullValue(CI->getType());
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *NewN =
|
2019-11-26 18:06:06 +08:00
|
|
|
ConstantInt::get(N->getType(), std::min(uint64_t(Pos + 1), N->getZExtValue()));
|
2019-11-26 03:15:25 +08:00
|
|
|
// memccpy -> llvm.memcpy
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
B.CreateMemCpy(Dst, Align(1), Src, Align(1), NewN);
|
2019-11-26 03:15:25 +08:00
|
|
|
return Pos + 1 <= N->getZExtValue()
|
|
|
|
? B.CreateInBoundsGEP(B.getInt8Ty(), Dst, NewN)
|
|
|
|
: Constant::getNullValue(CI->getType());
|
|
|
|
}
|
|
|
|
|
[InstCombine] mempcpy(d,s,n) to memcpy(d,s,n) + n
Summary:
Back-end currently expands mempcpy, but middle-end should work with memcpy instead of mempcpy to enable more memcpy-optimization.
GCC backend emits mempcpy, so LLVM backend could form it too, if we know mempcpy libcall is better than memcpy + n.
https://godbolt.org/z/dOCG96
Reviewers: efriedma, spatel, craig.topper, RKSimon, jdoerfert
Reviewed By: efriedma
Subscribers: hjl.tools, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65737
llvm-svn: 370593
2019-09-01 02:19:05 +08:00
|
|
|
Value *LibCallSimplifier::optimizeMemPCpy(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Value *Dst = CI->getArgOperand(0);
|
|
|
|
Value *N = CI->getArgOperand(2);
|
|
|
|
// mempcpy(x, y, n) -> llvm.memcpy(align 1 x, align 1 y, n), x + n
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI =
|
|
|
|
B.CreateMemCpy(Dst, Align(1), CI->getArgOperand(1), Align(1), N);
|
[InstCombine] mempcpy(d,s,n) to memcpy(d,s,n) + n
Summary:
Back-end currently expands mempcpy, but middle-end should work with memcpy instead of mempcpy to enable more memcpy-optimization.
GCC backend emits mempcpy, so LLVM backend could form it too, if we know mempcpy libcall is better than memcpy + n.
https://godbolt.org/z/dOCG96
Reviewers: efriedma, spatel, craig.topper, RKSimon, jdoerfert
Reviewed By: efriedma
Subscribers: hjl.tools, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65737
llvm-svn: 370593
2019-09-01 02:19:05 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
|
|
|
return B.CreateInBoundsGEP(B.getInt8Ty(), Dst, N);
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *LibCallSimplifier::optimizeMemMove(CallInst *CI, IRBuilder<> &B) {
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
Value *Size = CI->getArgOperand(2);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullAndDereferenceable(CI, {0, 1}, Size, DL);
|
|
|
|
if (isa<IntrinsicInst>(CI))
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2018-02-06 05:23:22 +08:00
|
|
|
// memmove(x, y, n) -> llvm.memmove(align 1 x, align 1 y, n)
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI = B.CreateMemMove(CI->getArgOperand(0), Align(1),
|
|
|
|
CI->getArgOperand(1), Align(1), Size);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
|
|
|
return CI->getArgOperand(0);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
|
|
|
|
2016-01-27 00:17:24 +08:00
|
|
|
/// Fold memset[_chk](malloc(n), 0, n) --> calloc(1, n).
|
2018-10-11 22:51:11 +08:00
|
|
|
Value *LibCallSimplifier::foldMallocMemset(CallInst *Memset, IRBuilder<> &B) {
|
2016-01-27 00:17:24 +08:00
|
|
|
// This has to be a memset of zeros (bzero).
|
|
|
|
auto *FillValue = dyn_cast<ConstantInt>(Memset->getArgOperand(1));
|
|
|
|
if (!FillValue || FillValue->getZExtValue() != 0)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// TODO: We should handle the case where the malloc has more than one use.
|
|
|
|
// This is necessary to optimize common patterns such as when the result of
|
|
|
|
// the malloc is checked against null or when a memset intrinsic is used in
|
|
|
|
// place of a memset library call.
|
|
|
|
auto *Malloc = dyn_cast<CallInst>(Memset->getArgOperand(0));
|
|
|
|
if (!Malloc || !Malloc->hasOneUse())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Is the inner call really malloc()?
|
|
|
|
Function *InnerCallee = Malloc->getCalledFunction();
|
2017-04-26 03:44:25 +08:00
|
|
|
if (!InnerCallee)
|
|
|
|
return nullptr;
|
|
|
|
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2018-10-11 22:51:11 +08:00
|
|
|
if (!TLI->getLibFunc(*InnerCallee, Func) || !TLI->has(Func) ||
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
Func != LibFunc_malloc)
|
2016-01-27 00:17:24 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// The memset must cover the same number of bytes that are malloc'd.
|
|
|
|
if (Memset->getArgOperand(2) != Malloc->getArgOperand(0))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Replace the malloc with a calloc. We need the data layout to know what the
|
2018-07-31 03:41:25 +08:00
|
|
|
// actual size of a 'size_t' parameter is.
|
2016-01-27 00:17:24 +08:00
|
|
|
B.SetInsertPoint(Malloc->getParent(), ++Malloc->getIterator());
|
|
|
|
const DataLayout &DL = Malloc->getModule()->getDataLayout();
|
|
|
|
IntegerType *SizeType = DL.getIntPtrType(B.GetInsertBlock()->getContext());
|
2019-09-07 06:07:11 +08:00
|
|
|
if (Value *Calloc = emitCalloc(ConstantInt::get(SizeType, 1),
|
|
|
|
Malloc->getArgOperand(0),
|
|
|
|
Malloc->getAttributes(), B, *TLI)) {
|
|
|
|
substituteInParent(Malloc, Calloc);
|
|
|
|
return Calloc;
|
|
|
|
}
|
2016-01-27 00:17:24 +08:00
|
|
|
|
2019-09-07 06:07:11 +08:00
|
|
|
return nullptr;
|
2016-01-27 00:17:24 +08:00
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
Value *LibCallSimplifier::optimizeMemSet(CallInst *CI, IRBuilder<> &B) {
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
Value *Size = CI->getArgOperand(2);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullAndDereferenceable(CI, 0, Size, DL);
|
|
|
|
if (isa<IntrinsicInst>(CI))
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2018-10-11 22:51:11 +08:00
|
|
|
if (auto *Calloc = foldMallocMemset(CI, B))
|
2016-01-27 00:17:24 +08:00
|
|
|
return Calloc;
|
|
|
|
|
2018-02-06 05:23:22 +08:00
|
|
|
// memset(p, v, n) -> llvm.memset(align 1 p, v, n)
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Val = B.CreateIntCast(CI->getArgOperand(1), B.getInt8Ty(), false);
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI = B.CreateMemSet(CI->getArgOperand(0), Val, Size, Align(1));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2014-09-18 04:55:46 +08:00
|
|
|
return CI->getArgOperand(0);
|
|
|
|
}
|
2012-11-11 14:49:03 +08:00
|
|
|
|
2018-04-18 22:21:31 +08:00
|
|
|
Value *LibCallSimplifier::optimizeRealloc(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (isa<ConstantPointerNull>(CI->getArgOperand(0)))
|
|
|
|
return emitMalloc(CI->getArgOperand(1), B, DL, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2012-11-13 12:16:17 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Math Library Optimizations
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
// Replace a libcall \p CI with a call to intrinsic \p IID
|
|
|
|
static Value *replaceUnaryCall(CallInst *CI, IRBuilder<> &B, Intrinsic::ID IID) {
|
|
|
|
// Propagate fast-math flags from the existing call to the new call.
|
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
|
|
|
B.setFastMathFlags(CI->getFastMathFlags());
|
|
|
|
|
|
|
|
Module *M = CI->getModule();
|
|
|
|
Value *V = CI->getArgOperand(0);
|
|
|
|
Function *F = Intrinsic::getDeclaration(M, IID, CI->getType());
|
|
|
|
CallInst *NewCall = B.CreateCall(F, V);
|
|
|
|
NewCall->takeName(CI);
|
|
|
|
return NewCall;
|
|
|
|
}
|
|
|
|
|
2014-12-04 05:46:33 +08:00
|
|
|
/// Return a variant of Val with float type.
|
|
|
|
/// Currently this works in two cases: If Val is an FPExtension of a float
|
|
|
|
/// value to something bigger, simply return the operand.
|
|
|
|
/// If Val is a ConstantFP but can be converted to a float ConstantFP without
|
|
|
|
/// loss of precision do so.
|
|
|
|
static Value *valueHasFloatPrecision(Value *Val) {
|
|
|
|
if (FPExtInst *Cast = dyn_cast<FPExtInst>(Val)) {
|
|
|
|
Value *Op = Cast->getOperand(0);
|
|
|
|
if (Op->getType()->isFloatTy())
|
|
|
|
return Op;
|
|
|
|
}
|
|
|
|
if (ConstantFP *Const = dyn_cast<ConstantFP>(Val)) {
|
|
|
|
APFloat F = Const->getValueAPF();
|
2014-12-04 06:10:39 +08:00
|
|
|
bool losesInfo;
|
2016-12-14 19:57:17 +08:00
|
|
|
(void)F.convert(APFloat::IEEEsingle(), APFloat::rmNearestTiesToEven,
|
2014-12-04 06:10:39 +08:00
|
|
|
&losesInfo);
|
|
|
|
if (!losesInfo)
|
2014-12-04 05:46:33 +08:00
|
|
|
return ConstantFP::get(Const->getContext(), F);
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
/// Shrink double -> float functions.
|
|
|
|
static Value *optimizeDoubleFP(CallInst *CI, IRBuilder<> &B,
|
2018-08-07 03:40:17 +08:00
|
|
|
bool isBinary, bool isPrecise = false) {
|
2019-05-07 03:51:54 +08:00
|
|
|
Function *CalleeFn = CI->getCalledFunction();
|
|
|
|
if (!CI->getType()->isDoubleTy() || !CalleeFn)
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
2012-11-13 12:16:17 +08:00
|
|
|
|
2018-08-07 03:40:17 +08:00
|
|
|
// If not all the uses of the function are converted to float, then bail out.
|
|
|
|
// This matters if the precision of the result is more important than the
|
|
|
|
// precision of the arguments.
|
|
|
|
if (isPrecise)
|
2014-09-18 04:55:46 +08:00
|
|
|
for (User *U : CI->users()) {
|
|
|
|
FPTruncInst *Cast = dyn_cast<FPTruncInst>(U);
|
|
|
|
if (!Cast || !Cast->getType()->isFloatTy())
|
|
|
|
return nullptr;
|
2012-11-13 12:16:17 +08:00
|
|
|
}
|
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
// If this is something like 'g((double) float)', convert to 'gf(float)'.
|
|
|
|
Value *V[2];
|
|
|
|
V[0] = valueHasFloatPrecision(CI->getArgOperand(0));
|
|
|
|
V[1] = isBinary ? valueHasFloatPrecision(CI->getArgOperand(1)) : nullptr;
|
|
|
|
if (!V[0] || (isBinary && !V[1]))
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
2018-07-31 03:41:25 +08:00
|
|
|
|
2017-04-25 20:36:14 +08:00
|
|
|
// If call isn't an intrinsic, check that it isn't within a function with the
|
2018-08-04 01:50:16 +08:00
|
|
|
// same name as the float version of this call, otherwise the result is an
|
|
|
|
// infinite loop. For example, from MinGW-w64:
|
2017-04-25 20:36:14 +08:00
|
|
|
//
|
2018-08-04 01:50:16 +08:00
|
|
|
// float expf(float val) { return (float) exp((double) val); }
|
2019-09-18 22:33:40 +08:00
|
|
|
StringRef CalleeName = CalleeFn->getName();
|
|
|
|
bool IsIntrinsic = CalleeFn->isIntrinsic();
|
|
|
|
if (!IsIntrinsic) {
|
|
|
|
StringRef CallerName = CI->getFunction()->getName();
|
|
|
|
if (!CallerName.empty() && CallerName.back() == 'f' &&
|
|
|
|
CallerName.size() == (CalleeName.size() + 1) &&
|
|
|
|
CallerName.startswith(CalleeName))
|
2017-04-25 20:36:14 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
// Propagate the math semantics from the current function to the new function.
|
2016-01-01 05:52:31 +08:00
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
2016-01-13 02:03:37 +08:00
|
|
|
B.setFastMathFlags(CI->getFastMathFlags());
|
2012-11-13 12:16:17 +08:00
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
// g((double) float) -> (double) gf(float)
|
|
|
|
Value *R;
|
2019-09-18 22:33:40 +08:00
|
|
|
if (IsIntrinsic) {
|
2015-12-15 01:24:23 +08:00
|
|
|
Module *M = CI->getModule();
|
2018-08-04 01:50:16 +08:00
|
|
|
Intrinsic::ID IID = CalleeFn->getIntrinsicID();
|
|
|
|
Function *Fn = Intrinsic::getDeclaration(M, IID, B.getFloatTy());
|
|
|
|
R = isBinary ? B.CreateCall(Fn, V) : B.CreateCall(Fn, V[0]);
|
2019-09-18 22:33:40 +08:00
|
|
|
} else {
|
|
|
|
AttributeList CalleeAttrs = CalleeFn->getAttributes();
|
|
|
|
R = isBinary ? emitBinaryFloatFnCall(V[0], V[1], CalleeName, B, CalleeAttrs)
|
|
|
|
: emitUnaryFloatFnCall(V[0], CalleeName, B, CalleeAttrs);
|
2014-10-24 05:52:45 +08:00
|
|
|
}
|
2018-08-04 01:50:16 +08:00
|
|
|
return B.CreateFPExt(R, B.getDoubleTy());
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-11-13 12:16:17 +08:00
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
/// Shrink double -> float for unary functions.
|
|
|
|
static Value *optimizeUnaryDoubleFP(CallInst *CI, IRBuilder<> &B,
|
2018-08-07 03:40:17 +08:00
|
|
|
bool isPrecise = false) {
|
|
|
|
return optimizeDoubleFP(CI, B, false, isPrecise);
|
2017-01-24 07:55:08 +08:00
|
|
|
}
|
|
|
|
|
2018-08-04 01:50:16 +08:00
|
|
|
/// Shrink double -> float for binary functions.
|
|
|
|
static Value *optimizeBinaryDoubleFP(CallInst *CI, IRBuilder<> &B,
|
2018-08-07 03:40:17 +08:00
|
|
|
bool isPrecise = false) {
|
|
|
|
return optimizeDoubleFP(CI, B, true, isPrecise);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2013-12-17 06:42:40 +08:00
|
|
|
|
2017-12-16 09:26:25 +08:00
|
|
|
// cabs(z) -> sqrt((creal(z)*creal(z)) + (cimag(z)*cimag(z)))
|
|
|
|
Value *LibCallSimplifier::optimizeCAbs(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (!CI->isFast())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Propagate fast-math flags from the existing call to new instructions.
|
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
|
|
|
B.setFastMathFlags(CI->getFastMathFlags());
|
|
|
|
|
|
|
|
Value *Real, *Imag;
|
|
|
|
if (CI->getNumArgOperands() == 1) {
|
|
|
|
Value *Op = CI->getArgOperand(0);
|
|
|
|
assert(Op->getType()->isArrayTy() && "Unexpected signature for cabs!");
|
|
|
|
Real = B.CreateExtractValue(Op, 0, "real");
|
|
|
|
Imag = B.CreateExtractValue(Op, 1, "imag");
|
|
|
|
} else {
|
|
|
|
assert(CI->getNumArgOperands() == 2 && "Unexpected signature for cabs!");
|
|
|
|
Real = CI->getArgOperand(0);
|
|
|
|
Imag = CI->getArgOperand(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *RealReal = B.CreateFMul(Real, Real);
|
|
|
|
Value *ImagImag = B.CreateFMul(Imag, Imag);
|
|
|
|
|
|
|
|
Function *FSqrt = Intrinsic::getDeclaration(CI->getModule(), Intrinsic::sqrt,
|
|
|
|
CI->getType());
|
|
|
|
return B.CreateCall(FSqrt, B.CreateFAdd(RealReal, ImagImag), "cabs");
|
|
|
|
}
|
|
|
|
|
2018-08-14 03:24:41 +08:00
|
|
|
static Value *optimizeTrigReflections(CallInst *Call, LibFunc Func,
|
|
|
|
IRBuilder<> &B) {
|
2018-08-14 05:49:19 +08:00
|
|
|
if (!isa<FPMathOperator>(Call))
|
|
|
|
return nullptr;
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
|
2018-08-14 05:49:19 +08:00
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
|
|
|
B.setFastMathFlags(Call->getFastMathFlags());
|
[SelectionDAG] Allow the user to specify a memeq function.
Summary:
Right now, when we encounter a string equality check,
e.g. `if (memcmp(a, b, s) == 0)`, we try to expand to a comparison if `s` is a
small compile-time constant, and fall back on calling `memcmp()` else.
This is sub-optimal because memcmp has to compute much more than
equality.
This patch replaces `memcmp(a, b, s) == 0` by `bcmp(a, b, s) == 0` on platforms
that support `bcmp`.
`bcmp` can be made much more efficient than `memcmp` because equality
compare is trivially parallel while lexicographic ordering has a chain
dependency.
Subscribers: fedor.sergeev, jyknight, ckennelly, gchatelet, llvm-commits
Differential Revision: https://reviews.llvm.org/D56593
llvm-svn: 355672
2019-03-08 17:07:45 +08:00
|
|
|
|
2018-08-14 03:24:41 +08:00
|
|
|
// TODO: Can this be shared to also handle LLVM intrinsics?
|
2018-08-14 01:40:49 +08:00
|
|
|
Value *X;
|
2018-08-14 03:24:41 +08:00
|
|
|
switch (Func) {
|
|
|
|
case LibFunc_sin:
|
|
|
|
case LibFunc_sinf:
|
|
|
|
case LibFunc_sinl:
|
2018-08-17 06:46:20 +08:00
|
|
|
case LibFunc_tan:
|
|
|
|
case LibFunc_tanf:
|
|
|
|
case LibFunc_tanl:
|
2018-08-14 03:24:41 +08:00
|
|
|
// sin(-X) --> -sin(X)
|
2018-08-17 06:46:20 +08:00
|
|
|
// tan(-X) --> -tan(X)
|
2018-08-14 03:24:41 +08:00
|
|
|
if (match(Call->getArgOperand(0), m_OneUse(m_FNeg(m_Value(X)))))
|
2018-08-17 06:46:20 +08:00
|
|
|
return B.CreateFNeg(B.CreateCall(Call->getCalledFunction(), X));
|
2018-08-14 03:24:41 +08:00
|
|
|
break;
|
|
|
|
case LibFunc_cos:
|
|
|
|
case LibFunc_cosf:
|
|
|
|
case LibFunc_cosl:
|
|
|
|
// cos(-X) --> cos(X)
|
|
|
|
if (match(Call->getArgOperand(0), m_FNeg(m_Value(X))))
|
|
|
|
return B.CreateCall(Call->getCalledFunction(), X, "cos");
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
2018-08-14 01:40:49 +08:00
|
|
|
return nullptr;
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-11-13 12:16:17 +08:00
|
|
|
|
[SimplifyLibCalls] Optimization for pow(x, n) where n is some constant
Summary:
In order to avoid calling pow function we generate repeated fmul when n is a
positive or negative whole number.
For each exponent we pre-compute Addition Chains in order to minimize the no.
of fmuls.
Refer: http://wwwhomes.uni-bielefeld.de/achim/addition_chain.html
We pre-compute addition chains for exponents upto 32 (which results in a max of
7 fmuls).
For eg:
4 = 2+2
5 = 2+3
6 = 3+3 and so on
Hence,
pow(x, 4.0) ==> y = fmul x, x
x = fmul y, y
ret x
For negative exponents, we simply compute the reciprocal of the final result.
Note: This transformation is only enabled under fast-math.
Patch by Mandeep Singh Grang <mgrang@codeaurora.org>
Reviewers: weimingz, majnemer, escha, davide, scanon, joerg
Subscribers: probinson, escha, llvm-commits
Differential Revision: http://reviews.llvm.org/D13994
llvm-svn: 254776
2015-12-05 06:00:47 +08:00
|
|
|
static Value *getPow(Value *InnerChain[33], unsigned Exp, IRBuilder<> &B) {
|
|
|
|
// Multiplications calculated using Addition Chains.
|
|
|
|
// Refer: http://wwwhomes.uni-bielefeld.de/achim/addition_chain.html
|
|
|
|
|
|
|
|
assert(Exp != 0 && "Incorrect exponent 0 not handled");
|
|
|
|
|
|
|
|
if (InnerChain[Exp])
|
|
|
|
return InnerChain[Exp];
|
|
|
|
|
|
|
|
static const unsigned AddChain[33][2] = {
|
|
|
|
{0, 0}, // Unused.
|
|
|
|
{0, 0}, // Unused (base case = pow1).
|
|
|
|
{1, 1}, // Unused (pre-computed).
|
|
|
|
{1, 2}, {2, 2}, {2, 3}, {3, 3}, {2, 5}, {4, 4},
|
|
|
|
{1, 8}, {5, 5}, {1, 10}, {6, 6}, {4, 9}, {7, 7},
|
|
|
|
{3, 12}, {8, 8}, {8, 9}, {2, 16}, {1, 18}, {10, 10},
|
|
|
|
{6, 15}, {11, 11}, {3, 20}, {12, 12}, {8, 17}, {13, 13},
|
|
|
|
{3, 24}, {14, 14}, {4, 25}, {15, 15}, {3, 28}, {16, 16},
|
|
|
|
};
|
|
|
|
|
|
|
|
InnerChain[Exp] = B.CreateFMul(getPow(InnerChain, AddChain[Exp][0], B),
|
|
|
|
getPow(InnerChain, AddChain[Exp][1], B));
|
|
|
|
return InnerChain[Exp];
|
|
|
|
}
|
|
|
|
|
2019-08-16 23:33:41 +08:00
|
|
|
// Return a properly extended 32-bit integer if the operation is an itofp.
|
|
|
|
static Value *getIntToFPVal(Value *I2F, IRBuilder<> &B) {
|
|
|
|
if (isa<SIToFPInst>(I2F) || isa<UIToFPInst>(I2F)) {
|
|
|
|
Value *Op = cast<Instruction>(I2F)->getOperand(0);
|
|
|
|
// Make sure that the exponent fits inside an int32_t,
|
|
|
|
// thus avoiding any range issues that FP has not.
|
|
|
|
unsigned BitWidth = Op->getType()->getPrimitiveSizeInBits();
|
|
|
|
if (BitWidth < 32 ||
|
|
|
|
(BitWidth == 32 && isa<SIToFPInst>(I2F)))
|
|
|
|
return isa<SIToFPInst>(I2F) ? B.CreateSExt(Op, B.getInt32Ty())
|
|
|
|
: B.CreateZExt(Op, B.getInt32Ty());
|
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2018-08-18 01:59:53 +08:00
|
|
|
/// Use exp{,2}(x * y) for pow(exp{,2}(x), y);
|
2019-08-16 23:33:41 +08:00
|
|
|
/// ldexp(1.0, x) for pow(2.0, itofp(x)); exp2(n * x) for pow(2.0 ** n, x);
|
|
|
|
/// exp10(x) for pow(10.0, x); exp2(log2(n) * x) for pow(n, x).
|
2018-08-18 01:59:53 +08:00
|
|
|
Value *LibCallSimplifier::replacePowWithExp(CallInst *Pow, IRBuilder<> &B) {
|
|
|
|
Value *Base = Pow->getArgOperand(0), *Expo = Pow->getArgOperand(1);
|
|
|
|
AttributeList Attrs = Pow->getCalledFunction()->getAttributes();
|
|
|
|
Module *Mod = Pow->getModule();
|
|
|
|
Type *Ty = Pow->getType();
|
2018-08-31 03:04:51 +08:00
|
|
|
bool Ignored;
|
2018-08-18 01:59:53 +08:00
|
|
|
|
|
|
|
// Evaluate special cases related to a nested function as the base.
|
|
|
|
|
|
|
|
// pow(exp(x), y) -> exp(x * y)
|
|
|
|
// pow(exp2(x), y) -> exp2(x * y)
|
2018-08-28 06:11:15 +08:00
|
|
|
// If exp{,2}() is used only once, it is better to fold two transcendental
|
|
|
|
// math functions into one. If used again, exp{,2}() would still have to be
|
|
|
|
// called with the original argument, then keep both original transcendental
|
|
|
|
// functions. However, this transformation is only safe with fully relaxed
|
|
|
|
// math semantics, since, besides rounding differences, it changes overflow
|
|
|
|
// and underflow behavior quite dramatically. For example:
|
2018-08-18 01:59:53 +08:00
|
|
|
// pow(exp(1000), 0.001) = pow(inf, 0.001) = inf
|
|
|
|
// Whereas:
|
|
|
|
// exp(1000 * 0.001) = exp(1)
|
|
|
|
// TODO: Loosen the requirement for fully relaxed math semantics.
|
|
|
|
// TODO: Handle exp10() when more targets have it available.
|
|
|
|
CallInst *BaseFn = dyn_cast<CallInst>(Base);
|
2018-08-28 06:11:15 +08:00
|
|
|
if (BaseFn && BaseFn->hasOneUse() && BaseFn->isFast() && Pow->isFast()) {
|
2018-08-18 01:59:53 +08:00
|
|
|
LibFunc LibFn;
|
2018-08-28 06:11:15 +08:00
|
|
|
|
2018-08-18 01:59:53 +08:00
|
|
|
Function *CalleeFn = BaseFn->getCalledFunction();
|
2018-08-30 01:59:48 +08:00
|
|
|
if (CalleeFn &&
|
|
|
|
TLI->getLibFunc(CalleeFn->getName(), LibFn) && TLI->has(LibFn)) {
|
|
|
|
StringRef ExpName;
|
|
|
|
Intrinsic::ID ID;
|
2018-08-28 06:11:15 +08:00
|
|
|
Value *ExpFn;
|
2019-10-01 04:52:21 +08:00
|
|
|
LibFunc LibFnFloat, LibFnDouble, LibFnLongDouble;
|
2018-08-28 06:11:15 +08:00
|
|
|
|
2018-08-30 01:59:48 +08:00
|
|
|
switch (LibFn) {
|
|
|
|
default:
|
|
|
|
return nullptr;
|
|
|
|
case LibFunc_expf: case LibFunc_exp: case LibFunc_expl:
|
2018-10-20 04:57:45 +08:00
|
|
|
ExpName = TLI->getName(LibFunc_exp);
|
2018-08-30 01:59:48 +08:00
|
|
|
ID = Intrinsic::exp;
|
Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Summary:
In several places in the code we use the following pattern:
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, TLI.getName(LibFunc_tan), B, Attrs);
[...]
}
In short, we check if there is a lib-function for a certain type, and then
we _always_ fetch the name of the "double" version of the lib function and
construct a call to the appropriate function, that we just checked exists,
using that "double" name as a basis.
This is of course a problem in cases where the target doesn't support the
"double" version, but e.g. only the "float" version.
In that case TLI.getName(LibFunc_tan) returns "", and
emitUnaryFloatFnCall happily appends an "f" to "", and we erroneously end
up with a call to a function called "f".
To solve this, the above pattern is changed to
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, &TLI, LibFunc_tan, LibFunc_tanf,
LibFunc_tanl, B, Attrs);
[...]
}
I.e instead of first fetching the name of the "double" version and then
letting emitUnaryFloatFnCall() add the final "f" or "l", we let
emitUnaryFloatFnCall() fetch the right name from TLI.
Reviewers: eli.friedman, efriedma
Reviewed By: efriedma
Subscribers: efriedma, bjope, llvm-commits
Differential Revision: https://reviews.llvm.org/D53370
llvm-svn: 344725
2018-10-18 14:27:53 +08:00
|
|
|
LibFnFloat = LibFunc_expf;
|
|
|
|
LibFnDouble = LibFunc_exp;
|
|
|
|
LibFnLongDouble = LibFunc_expl;
|
2018-08-30 01:59:48 +08:00
|
|
|
break;
|
|
|
|
case LibFunc_exp2f: case LibFunc_exp2: case LibFunc_exp2l:
|
2018-10-20 04:57:45 +08:00
|
|
|
ExpName = TLI->getName(LibFunc_exp2);
|
2018-08-30 01:59:48 +08:00
|
|
|
ID = Intrinsic::exp2;
|
Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Summary:
In several places in the code we use the following pattern:
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, TLI.getName(LibFunc_tan), B, Attrs);
[...]
}
In short, we check if there is a lib-function for a certain type, and then
we _always_ fetch the name of the "double" version of the lib function and
construct a call to the appropriate function, that we just checked exists,
using that "double" name as a basis.
This is of course a problem in cases where the target doesn't support the
"double" version, but e.g. only the "float" version.
In that case TLI.getName(LibFunc_tan) returns "", and
emitUnaryFloatFnCall happily appends an "f" to "", and we erroneously end
up with a call to a function called "f".
To solve this, the above pattern is changed to
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, &TLI, LibFunc_tan, LibFunc_tanf,
LibFunc_tanl, B, Attrs);
[...]
}
I.e instead of first fetching the name of the "double" version and then
letting emitUnaryFloatFnCall() add the final "f" or "l", we let
emitUnaryFloatFnCall() fetch the right name from TLI.
Reviewers: eli.friedman, efriedma
Reviewed By: efriedma
Subscribers: efriedma, bjope, llvm-commits
Differential Revision: https://reviews.llvm.org/D53370
llvm-svn: 344725
2018-10-18 14:27:53 +08:00
|
|
|
LibFnFloat = LibFunc_exp2f;
|
|
|
|
LibFnDouble = LibFunc_exp2;
|
|
|
|
LibFnLongDouble = LibFunc_exp2l;
|
2018-08-30 01:59:48 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2018-08-28 06:11:15 +08:00
|
|
|
// Create new exp{,2}() with the product as its argument.
|
2018-08-18 01:59:53 +08:00
|
|
|
Value *FMul = B.CreateFMul(BaseFn->getArgOperand(0), Expo, "mul");
|
2018-08-30 01:59:48 +08:00
|
|
|
ExpFn = BaseFn->doesNotAccessMemory()
|
|
|
|
? B.CreateCall(Intrinsic::getDeclaration(Mod, ID, Ty),
|
|
|
|
FMul, ExpName)
|
Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Summary:
In several places in the code we use the following pattern:
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, TLI.getName(LibFunc_tan), B, Attrs);
[...]
}
In short, we check if there is a lib-function for a certain type, and then
we _always_ fetch the name of the "double" version of the lib function and
construct a call to the appropriate function, that we just checked exists,
using that "double" name as a basis.
This is of course a problem in cases where the target doesn't support the
"double" version, but e.g. only the "float" version.
In that case TLI.getName(LibFunc_tan) returns "", and
emitUnaryFloatFnCall happily appends an "f" to "", and we erroneously end
up with a call to a function called "f".
To solve this, the above pattern is changed to
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, &TLI, LibFunc_tan, LibFunc_tanf,
LibFunc_tanl, B, Attrs);
[...]
}
I.e instead of first fetching the name of the "double" version and then
letting emitUnaryFloatFnCall() add the final "f" or "l", we let
emitUnaryFloatFnCall() fetch the right name from TLI.
Reviewers: eli.friedman, efriedma
Reviewed By: efriedma
Subscribers: efriedma, bjope, llvm-commits
Differential Revision: https://reviews.llvm.org/D53370
llvm-svn: 344725
2018-10-18 14:27:53 +08:00
|
|
|
: emitUnaryFloatFnCall(FMul, TLI, LibFnDouble, LibFnFloat,
|
|
|
|
LibFnLongDouble, B,
|
|
|
|
BaseFn->getAttributes());
|
2018-08-28 06:11:15 +08:00
|
|
|
|
|
|
|
// Since the new exp{,2}() is different from the original one, dead code
|
|
|
|
// elimination cannot be trusted to remove it, since it may have side
|
|
|
|
// effects (e.g., errno). When the only consumer for the original
|
|
|
|
// exp{,2}() is pow(), then it has to be explicitly erased.
|
2019-09-07 06:07:11 +08:00
|
|
|
substituteInParent(BaseFn, ExpFn);
|
2018-08-28 06:11:15 +08:00
|
|
|
return ExpFn;
|
2018-08-18 01:59:53 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Evaluate special cases related to a constant base.
|
|
|
|
|
2018-08-31 03:04:51 +08:00
|
|
|
const APFloat *BaseF;
|
|
|
|
if (!match(Pow->getArgOperand(0), m_APFloat(BaseF)))
|
|
|
|
return nullptr;
|
|
|
|
|
2019-08-16 23:33:41 +08:00
|
|
|
// pow(2.0, itofp(x)) -> ldexp(1.0, x)
|
|
|
|
if (match(Base, m_SpecificFP(2.0)) &&
|
|
|
|
(isa<SIToFPInst>(Expo) || isa<UIToFPInst>(Expo)) &&
|
|
|
|
hasFloatFn(TLI, Ty, LibFunc_ldexp, LibFunc_ldexpf, LibFunc_ldexpl)) {
|
|
|
|
if (Value *ExpoI = getIntToFPVal(Expo, B))
|
|
|
|
return emitBinaryFloatFnCall(ConstantFP::get(Ty, 1.0), ExpoI, TLI,
|
|
|
|
LibFunc_ldexp, LibFunc_ldexpf, LibFunc_ldexpl,
|
|
|
|
B, Attrs);
|
|
|
|
}
|
|
|
|
|
2018-08-31 03:04:51 +08:00
|
|
|
// pow(2.0 ** n, x) -> exp2(n * x)
|
2019-08-10 00:04:18 +08:00
|
|
|
if (hasFloatFn(TLI, Ty, LibFunc_exp2, LibFunc_exp2f, LibFunc_exp2l)) {
|
2018-08-31 03:04:51 +08:00
|
|
|
APFloat BaseR = APFloat(1.0);
|
|
|
|
BaseR.convert(BaseF->getSemantics(), APFloat::rmTowardZero, &Ignored);
|
|
|
|
BaseR = BaseR / *BaseF;
|
2019-07-02 23:58:45 +08:00
|
|
|
bool IsInteger = BaseF->isInteger(), IsReciprocal = BaseR.isInteger();
|
2018-08-31 03:04:51 +08:00
|
|
|
const APFloat *NF = IsReciprocal ? &BaseR : BaseF;
|
|
|
|
APSInt NI(64, false);
|
|
|
|
if ((IsInteger || IsReciprocal) &&
|
2019-07-02 23:58:45 +08:00
|
|
|
NF->convertToInteger(NI, APFloat::rmTowardZero, &Ignored) ==
|
|
|
|
APFloat::opOK &&
|
2018-08-31 03:04:51 +08:00
|
|
|
NI > 1 && NI.isPowerOf2()) {
|
|
|
|
double N = NI.logBase2() * (IsReciprocal ? -1.0 : 1.0);
|
|
|
|
Value *FMul = B.CreateFMul(Expo, ConstantFP::get(Ty, N), "mul");
|
|
|
|
if (Pow->doesNotAccessMemory())
|
|
|
|
return B.CreateCall(Intrinsic::getDeclaration(Mod, Intrinsic::exp2, Ty),
|
|
|
|
FMul, "exp2");
|
|
|
|
else
|
Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Summary:
In several places in the code we use the following pattern:
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, TLI.getName(LibFunc_tan), B, Attrs);
[...]
}
In short, we check if there is a lib-function for a certain type, and then
we _always_ fetch the name of the "double" version of the lib function and
construct a call to the appropriate function, that we just checked exists,
using that "double" name as a basis.
This is of course a problem in cases where the target doesn't support the
"double" version, but e.g. only the "float" version.
In that case TLI.getName(LibFunc_tan) returns "", and
emitUnaryFloatFnCall happily appends an "f" to "", and we erroneously end
up with a call to a function called "f".
To solve this, the above pattern is changed to
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, &TLI, LibFunc_tan, LibFunc_tanf,
LibFunc_tanl, B, Attrs);
[...]
}
I.e instead of first fetching the name of the "double" version and then
letting emitUnaryFloatFnCall() add the final "f" or "l", we let
emitUnaryFloatFnCall() fetch the right name from TLI.
Reviewers: eli.friedman, efriedma
Reviewed By: efriedma
Subscribers: efriedma, bjope, llvm-commits
Differential Revision: https://reviews.llvm.org/D53370
llvm-svn: 344725
2018-10-18 14:27:53 +08:00
|
|
|
return emitUnaryFloatFnCall(FMul, TLI, LibFunc_exp2, LibFunc_exp2f,
|
|
|
|
LibFunc_exp2l, B, Attrs);
|
2018-08-31 03:04:51 +08:00
|
|
|
}
|
2018-08-18 01:59:53 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// pow(10.0, x) -> exp10(x)
|
|
|
|
// TODO: There is no exp10() intrinsic yet, but some day there shall be one.
|
|
|
|
if (match(Base, m_SpecificFP(10.0)) &&
|
2019-08-10 00:04:18 +08:00
|
|
|
hasFloatFn(TLI, Ty, LibFunc_exp10, LibFunc_exp10f, LibFunc_exp10l))
|
Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Summary:
In several places in the code we use the following pattern:
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, TLI.getName(LibFunc_tan), B, Attrs);
[...]
}
In short, we check if there is a lib-function for a certain type, and then
we _always_ fetch the name of the "double" version of the lib function and
construct a call to the appropriate function, that we just checked exists,
using that "double" name as a basis.
This is of course a problem in cases where the target doesn't support the
"double" version, but e.g. only the "float" version.
In that case TLI.getName(LibFunc_tan) returns "", and
emitUnaryFloatFnCall happily appends an "f" to "", and we erroneously end
up with a call to a function called "f".
To solve this, the above pattern is changed to
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, &TLI, LibFunc_tan, LibFunc_tanf,
LibFunc_tanl, B, Attrs);
[...]
}
I.e instead of first fetching the name of the "double" version and then
letting emitUnaryFloatFnCall() add the final "f" or "l", we let
emitUnaryFloatFnCall() fetch the right name from TLI.
Reviewers: eli.friedman, efriedma
Reviewed By: efriedma
Subscribers: efriedma, bjope, llvm-commits
Differential Revision: https://reviews.llvm.org/D53370
llvm-svn: 344725
2018-10-18 14:27:53 +08:00
|
|
|
return emitUnaryFloatFnCall(Expo, TLI, LibFunc_exp10, LibFunc_exp10f,
|
|
|
|
LibFunc_exp10l, B, Attrs);
|
2018-08-18 01:59:53 +08:00
|
|
|
|
2019-07-12 08:33:49 +08:00
|
|
|
// pow(n, x) -> exp2(log2(n) * x)
|
2019-07-10 22:43:27 +08:00
|
|
|
if (Pow->hasOneUse() && Pow->hasApproxFunc() && Pow->hasNoNaNs() &&
|
|
|
|
Pow->hasNoInfs() && BaseF->isNormal() && !BaseF->isNegative()) {
|
|
|
|
Value *Log = nullptr;
|
|
|
|
if (Ty->isFloatTy())
|
|
|
|
Log = ConstantFP::get(Ty, std::log2(BaseF->convertToFloat()));
|
|
|
|
else if (Ty->isDoubleTy())
|
|
|
|
Log = ConstantFP::get(Ty, std::log2(BaseF->convertToDouble()));
|
|
|
|
|
|
|
|
if (Log) {
|
|
|
|
Value *FMul = B.CreateFMul(Log, Expo, "mul");
|
2019-08-10 00:04:18 +08:00
|
|
|
if (Pow->doesNotAccessMemory())
|
2019-07-10 22:43:27 +08:00
|
|
|
return B.CreateCall(Intrinsic::getDeclaration(Mod, Intrinsic::exp2, Ty),
|
|
|
|
FMul, "exp2");
|
2019-08-10 00:04:18 +08:00
|
|
|
else if (hasFloatFn(TLI, Ty, LibFunc_exp2, LibFunc_exp2f, LibFunc_exp2l))
|
|
|
|
return emitUnaryFloatFnCall(FMul, TLI, LibFunc_exp2, LibFunc_exp2f,
|
|
|
|
LibFunc_exp2l, B, Attrs);
|
2019-07-10 22:43:27 +08:00
|
|
|
}
|
|
|
|
}
|
2019-08-10 00:04:18 +08:00
|
|
|
|
2018-08-18 01:59:53 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2018-09-04 01:37:39 +08:00
|
|
|
static Value *getSqrtCall(Value *V, AttributeList Attrs, bool NoErrno,
|
|
|
|
Module *M, IRBuilder<> &B,
|
|
|
|
const TargetLibraryInfo *TLI) {
|
|
|
|
// If errno is never set, then use the intrinsic for sqrt().
|
|
|
|
if (NoErrno) {
|
|
|
|
Function *SqrtFn =
|
|
|
|
Intrinsic::getDeclaration(M, Intrinsic::sqrt, V->getType());
|
|
|
|
return B.CreateCall(SqrtFn, V, "sqrt");
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise, use the libcall for sqrt().
|
2019-08-10 00:04:18 +08:00
|
|
|
if (hasFloatFn(TLI, V->getType(), LibFunc_sqrt, LibFunc_sqrtf, LibFunc_sqrtl))
|
2018-09-04 01:37:39 +08:00
|
|
|
// TODO: We also should check that the target can in fact lower the sqrt()
|
|
|
|
// libcall. We currently have no way to ask this question, so we ask if
|
|
|
|
// the target has a sqrt() libcall, which is not exactly the same.
|
Add a emitUnaryFloatFnCall version that fetches the function name from TLI
Summary:
In several places in the code we use the following pattern:
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, TLI.getName(LibFunc_tan), B, Attrs);
[...]
}
In short, we check if there is a lib-function for a certain type, and then
we _always_ fetch the name of the "double" version of the lib function and
construct a call to the appropriate function, that we just checked exists,
using that "double" name as a basis.
This is of course a problem in cases where the target doesn't support the
"double" version, but e.g. only the "float" version.
In that case TLI.getName(LibFunc_tan) returns "", and
emitUnaryFloatFnCall happily appends an "f" to "", and we erroneously end
up with a call to a function called "f".
To solve this, the above pattern is changed to
if (hasUnaryFloatFn(&TLI, Ty, LibFunc_tan, LibFunc_tanf, LibFunc_tanl)) {
[...]
Value *Res = emitUnaryFloatFnCall(X, &TLI, LibFunc_tan, LibFunc_tanf,
LibFunc_tanl, B, Attrs);
[...]
}
I.e instead of first fetching the name of the "double" version and then
letting emitUnaryFloatFnCall() add the final "f" or "l", we let
emitUnaryFloatFnCall() fetch the right name from TLI.
Reviewers: eli.friedman, efriedma
Reviewed By: efriedma
Subscribers: efriedma, bjope, llvm-commits
Differential Revision: https://reviews.llvm.org/D53370
llvm-svn: 344725
2018-10-18 14:27:53 +08:00
|
|
|
return emitUnaryFloatFnCall(V, TLI, LibFunc_sqrt, LibFunc_sqrtf,
|
|
|
|
LibFunc_sqrtl, B, Attrs);
|
2018-09-04 01:37:39 +08:00
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2017-11-20 00:13:14 +08:00
|
|
|
/// Use square root in place of pow(x, +/-0.5).
|
|
|
|
Value *LibCallSimplifier::replacePowWithSqrt(CallInst *Pow, IRBuilder<> &B) {
|
2018-07-31 00:20:04 +08:00
|
|
|
Value *Sqrt, *Base = Pow->getArgOperand(0), *Expo = Pow->getArgOperand(1);
|
2018-08-16 23:58:08 +08:00
|
|
|
AttributeList Attrs = Pow->getCalledFunction()->getAttributes();
|
|
|
|
Module *Mod = Pow->getModule();
|
2018-07-31 00:20:04 +08:00
|
|
|
Type *Ty = Pow->getType();
|
|
|
|
|
|
|
|
const APFloat *ExpoF;
|
|
|
|
if (!match(Expo, m_APFloat(ExpoF)) ||
|
|
|
|
(!ExpoF->isExactlyValue(0.5) && !ExpoF->isExactlyValue(-0.5)))
|
2017-11-20 00:13:14 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2019-12-21 06:24:53 +08:00
|
|
|
// Converting pow(X, -0.5) to 1/sqrt(X) may introduce an extra rounding step,
|
|
|
|
// so that requires fast-math-flags (afn or reassoc).
|
|
|
|
if (ExpoF->isNegative() && (!Pow->hasApproxFunc() && !Pow->hasAllowReassoc()))
|
|
|
|
return nullptr;
|
|
|
|
|
2018-09-04 01:37:39 +08:00
|
|
|
Sqrt = getSqrtCall(Base, Attrs, Pow->doesNotAccessMemory(), Mod, B, TLI);
|
|
|
|
if (!Sqrt)
|
2017-11-20 00:13:14 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2018-08-16 23:58:08 +08:00
|
|
|
// Handle signed zero base by expanding to fabs(sqrt(x)).
|
|
|
|
if (!Pow->hasNoSignedZeros()) {
|
|
|
|
Function *FAbsFn = Intrinsic::getDeclaration(Mod, Intrinsic::fabs, Ty);
|
|
|
|
Sqrt = B.CreateCall(FAbsFn, Sqrt, "abs");
|
|
|
|
}
|
|
|
|
|
|
|
|
// Handle non finite base by expanding to
|
|
|
|
// (x == -infinity ? +infinity : sqrt(x)).
|
|
|
|
if (!Pow->hasNoInfs()) {
|
|
|
|
Value *PosInf = ConstantFP::getInfinity(Ty),
|
|
|
|
*NegInf = ConstantFP::getInfinity(Ty, true);
|
|
|
|
Value *FCmp = B.CreateFCmpOEQ(Base, NegInf, "isinf");
|
|
|
|
Sqrt = B.CreateSelect(FCmp, PosInf, Sqrt);
|
|
|
|
}
|
|
|
|
|
2018-08-01 06:11:02 +08:00
|
|
|
// If the exponent is negative, then get the reciprocal.
|
2018-07-31 00:20:04 +08:00
|
|
|
if (ExpoF->isNegative())
|
|
|
|
Sqrt = B.CreateFDiv(ConstantFP::get(Ty, 1.0), Sqrt, "reciprocal");
|
2017-11-20 00:13:14 +08:00
|
|
|
|
|
|
|
return Sqrt;
|
|
|
|
}
|
|
|
|
|
2019-07-02 23:58:45 +08:00
|
|
|
static Value *createPowWithIntegerExponent(Value *Base, Value *Expo, Module *M,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
Value *Args[] = {Base, Expo};
|
|
|
|
Function *F = Intrinsic::getDeclaration(M, Intrinsic::powi, Base->getType());
|
|
|
|
return B.CreateCall(F, Args);
|
|
|
|
}
|
|
|
|
|
2018-07-31 00:20:04 +08:00
|
|
|
Value *LibCallSimplifier::optimizePow(CallInst *Pow, IRBuilder<> &B) {
|
2019-07-02 23:58:45 +08:00
|
|
|
Value *Base = Pow->getArgOperand(0);
|
|
|
|
Value *Expo = Pow->getArgOperand(1);
|
2018-07-31 00:20:04 +08:00
|
|
|
Function *Callee = Pow->getCalledFunction();
|
2015-11-06 03:18:23 +08:00
|
|
|
StringRef Name = Callee->getName();
|
2018-07-31 00:20:04 +08:00
|
|
|
Type *Ty = Pow->getType();
|
2019-07-02 23:58:45 +08:00
|
|
|
Module *M = Pow->getModule();
|
2018-07-31 00:20:04 +08:00
|
|
|
Value *Shrunk = nullptr;
|
2019-07-02 23:58:45 +08:00
|
|
|
bool AllowApprox = Pow->hasApproxFunc();
|
2018-07-31 00:20:04 +08:00
|
|
|
bool Ignored;
|
2012-11-13 12:16:17 +08:00
|
|
|
|
2018-08-14 00:12:37 +08:00
|
|
|
// Bail out if simplifying libcalls to pow() is disabled.
|
2019-08-10 00:04:18 +08:00
|
|
|
if (!hasFloatFn(TLI, Ty, LibFunc_pow, LibFunc_powf, LibFunc_powl))
|
2018-08-14 00:12:37 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2018-08-01 06:11:02 +08:00
|
|
|
// Propagate the math semantics from the call to any created instructions.
|
2018-07-31 00:20:04 +08:00
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
|
|
|
B.setFastMathFlags(Pow->getFastMathFlags());
|
|
|
|
|
2018-08-07 03:40:17 +08:00
|
|
|
// Shrink pow() to powf() if the arguments are single precision,
|
|
|
|
// unless the result is expected to be double precision.
|
2019-07-02 23:58:45 +08:00
|
|
|
if (UnsafeFPShrink && Name == TLI->getName(LibFunc_pow) &&
|
|
|
|
hasFloatVersion(Name))
|
2018-08-07 03:40:17 +08:00
|
|
|
Shrunk = optimizeBinaryDoubleFP(Pow, B, true);
|
|
|
|
|
2018-07-31 00:20:04 +08:00
|
|
|
// Evaluate special cases related to the base.
|
2016-08-08 04:27:03 +08:00
|
|
|
|
|
|
|
// pow(1.0, x) -> 1.0
|
2018-08-02 23:43:57 +08:00
|
|
|
if (match(Base, m_FPOne()))
|
2018-07-31 00:20:04 +08:00
|
|
|
return Base;
|
|
|
|
|
2019-07-11 18:55:04 +08:00
|
|
|
if (Value *Exp = replacePowWithExp(Pow, B))
|
|
|
|
return Exp;
|
|
|
|
|
2018-07-31 00:20:04 +08:00
|
|
|
// Evaluate special cases related to the exponent.
|
|
|
|
|
|
|
|
// pow(x, -1.0) -> 1.0 / x
|
2018-08-14 00:12:37 +08:00
|
|
|
if (match(Expo, m_SpecificFP(-1.0)))
|
2018-07-31 00:20:04 +08:00
|
|
|
return B.CreateFDiv(ConstantFP::get(Ty, 1.0), Base, "reciprocal");
|
2012-11-13 12:16:17 +08:00
|
|
|
|
2019-09-07 00:10:18 +08:00
|
|
|
// pow(x, +/-0.0) -> 1.0
|
|
|
|
if (match(Expo, m_AnyZeroFP()))
|
2019-07-02 23:58:45 +08:00
|
|
|
return ConstantFP::get(Ty, 1.0);
|
2018-07-31 00:20:04 +08:00
|
|
|
|
|
|
|
// pow(x, 1.0) -> x
|
2018-08-14 00:12:37 +08:00
|
|
|
if (match(Expo, m_FPOne()))
|
2018-07-31 00:20:04 +08:00
|
|
|
return Base;
|
|
|
|
|
|
|
|
// pow(x, 2.0) -> x * x
|
2018-08-14 00:12:37 +08:00
|
|
|
if (match(Expo, m_SpecificFP(2.0)))
|
2018-07-31 00:20:04 +08:00
|
|
|
return B.CreateFMul(Base, Base, "square");
|
2014-09-18 04:55:46 +08:00
|
|
|
|
2018-08-14 00:12:37 +08:00
|
|
|
if (Value *Sqrt = replacePowWithSqrt(Pow, B))
|
|
|
|
return Sqrt;
|
|
|
|
|
|
|
|
// pow(x, n) -> x * x * x * ...
|
|
|
|
const APFloat *ExpoF;
|
2019-07-12 08:33:49 +08:00
|
|
|
if (AllowApprox && match(Expo, m_APFloat(ExpoF))) {
|
2018-08-14 00:12:37 +08:00
|
|
|
// We limit to a max of 7 multiplications, thus the maximum exponent is 32.
|
2018-09-04 01:37:39 +08:00
|
|
|
// If the exponent is an integer+0.5 we generate a call to sqrt and an
|
|
|
|
// additional fmul.
|
|
|
|
// TODO: This whole transformation should be backend specific (e.g. some
|
|
|
|
// backends might prefer libcalls or the limit for the exponent might
|
|
|
|
// be different) and it should also consider optimizing for size.
|
2019-12-04 17:57:38 +08:00
|
|
|
APFloat LimF(ExpoF->getSemantics(), 33),
|
2018-08-14 00:12:37 +08:00
|
|
|
ExpoA(abs(*ExpoF));
|
2018-09-04 01:37:39 +08:00
|
|
|
if (ExpoA.compare(LimF) == APFloat::cmpLessThan) {
|
|
|
|
// This transformation applies to integer or integer+0.5 exponents only.
|
|
|
|
// For integer+0.5, we create a sqrt(Base) call.
|
|
|
|
Value *Sqrt = nullptr;
|
|
|
|
if (!ExpoA.isInteger()) {
|
|
|
|
APFloat Expo2 = ExpoA;
|
|
|
|
// To check if ExpoA is an integer + 0.5, we add it to itself. If there
|
|
|
|
// is no floating point exception and the result is an integer, then
|
|
|
|
// ExpoA == integer + 0.5
|
|
|
|
if (Expo2.add(ExpoA, APFloat::rmNearestTiesToEven) != APFloat::opOK)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
if (!Expo2.isInteger())
|
|
|
|
return nullptr;
|
|
|
|
|
2019-07-02 23:58:45 +08:00
|
|
|
Sqrt = getSqrtCall(Base, Pow->getCalledFunction()->getAttributes(),
|
|
|
|
Pow->doesNotAccessMemory(), M, B, TLI);
|
2018-09-04 01:37:39 +08:00
|
|
|
}
|
|
|
|
|
2018-08-14 00:12:37 +08:00
|
|
|
// We will memoize intermediate products of the Addition Chain.
|
|
|
|
Value *InnerChain[33] = {nullptr};
|
|
|
|
InnerChain[1] = Base;
|
|
|
|
InnerChain[2] = B.CreateFMul(Base, Base, "square");
|
|
|
|
|
|
|
|
// We cannot readily convert a non-double type (like float) to a double.
|
|
|
|
// So we first convert it to something which could be converted to double.
|
|
|
|
ExpoA.convert(APFloat::IEEEdouble(), APFloat::rmTowardZero, &Ignored);
|
|
|
|
Value *FMul = getPow(InnerChain, ExpoA.convertToDouble(), B);
|
|
|
|
|
2018-09-04 01:37:39 +08:00
|
|
|
// Expand pow(x, y+0.5) to pow(x, y) * sqrt(x).
|
|
|
|
if (Sqrt)
|
|
|
|
FMul = B.CreateFMul(FMul, Sqrt);
|
|
|
|
|
2018-08-14 00:12:37 +08:00
|
|
|
// If the exponent is negative, then get the reciprocal.
|
|
|
|
if (ExpoF->isNegative())
|
|
|
|
FMul = B.CreateFDiv(ConstantFP::get(Ty, 1.0), FMul, "reciprocal");
|
|
|
|
|
|
|
|
return FMul;
|
|
|
|
}
|
2019-07-02 23:58:45 +08:00
|
|
|
|
|
|
|
APSInt IntExpo(32, /*isUnsigned=*/false);
|
2019-07-12 08:33:49 +08:00
|
|
|
// powf(x, n) -> powi(x, n) if n is a constant signed integer value
|
2019-07-03 05:16:34 +08:00
|
|
|
if (ExpoF->isInteger() &&
|
|
|
|
ExpoF->convertToInteger(IntExpo, APFloat::rmTowardZero, &Ignored) ==
|
|
|
|
APFloat::opOK) {
|
2019-07-02 23:58:45 +08:00
|
|
|
return createPowWithIntegerExponent(
|
|
|
|
Base, ConstantInt::get(B.getInt32Ty(), IntExpo), M, B);
|
|
|
|
}
|
[SimplifyLibCalls] Optimization for pow(x, n) where n is some constant
Summary:
In order to avoid calling pow function we generate repeated fmul when n is a
positive or negative whole number.
For each exponent we pre-compute Addition Chains in order to minimize the no.
of fmuls.
Refer: http://wwwhomes.uni-bielefeld.de/achim/addition_chain.html
We pre-compute addition chains for exponents upto 32 (which results in a max of
7 fmuls).
For eg:
4 = 2+2
5 = 2+3
6 = 3+3 and so on
Hence,
pow(x, 4.0) ==> y = fmul x, x
x = fmul y, y
ret x
For negative exponents, we simply compute the reciprocal of the final result.
Note: This transformation is only enabled under fast-math.
Patch by Mandeep Singh Grang <mgrang@codeaurora.org>
Reviewers: weimingz, majnemer, escha, davide, scanon, joerg
Subscribers: probinson, escha, llvm-commits
Differential Revision: http://reviews.llvm.org/D13994
llvm-svn: 254776
2015-12-05 06:00:47 +08:00
|
|
|
}
|
|
|
|
|
2019-07-12 08:33:49 +08:00
|
|
|
// powf(x, itofp(y)) -> powi(x, y)
|
|
|
|
if (AllowApprox && (isa<SIToFPInst>(Expo) || isa<UIToFPInst>(Expo))) {
|
2019-08-16 23:33:41 +08:00
|
|
|
if (Value *ExpoI = getIntToFPVal(Expo, B))
|
|
|
|
return createPowWithIntegerExponent(Base, ExpoI, M, B);
|
2019-07-12 08:33:49 +08:00
|
|
|
}
|
|
|
|
|
2018-08-07 03:40:17 +08:00
|
|
|
return Shrunk;
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeExp2(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
2015-11-06 03:18:23 +08:00
|
|
|
StringRef Name = Callee->getName();
|
2019-08-10 01:22:56 +08:00
|
|
|
Value *Ret = nullptr;
|
|
|
|
if (UnsafeFPShrink && Name == TLI->getName(LibFunc_exp2) &&
|
|
|
|
hasFloatVersion(Name))
|
2014-09-18 04:55:46 +08:00
|
|
|
Ret = optimizeUnaryDoubleFP(CI, B, true);
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2019-08-10 01:22:56 +08:00
|
|
|
Type *Ty = CI->getType();
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Op = CI->getArgOperand(0);
|
2019-08-10 01:22:56 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Turn exp2(sitofp(x)) -> ldexp(1.0, sext(x)) if sizeof(x) <= 32
|
|
|
|
// Turn exp2(uitofp(x)) -> ldexp(1.0, zext(x)) if sizeof(x) < 32
|
2019-08-10 01:22:56 +08:00
|
|
|
if ((isa<SIToFPInst>(Op) || isa<UIToFPInst>(Op)) &&
|
|
|
|
hasFloatFn(TLI, Ty, LibFunc_ldexp, LibFunc_ldexpf, LibFunc_ldexpl)) {
|
2019-08-16 23:33:41 +08:00
|
|
|
if (Value *Exp = getIntToFPVal(Op, B))
|
2019-08-10 01:22:56 +08:00
|
|
|
return emitBinaryFloatFnCall(ConstantFP::get(Ty, 1.0), Exp, TLI,
|
|
|
|
LibFunc_ldexp, LibFunc_ldexpf, LibFunc_ldexpl,
|
|
|
|
B, CI->getCalledFunction()->getAttributes());
|
2013-11-03 14:48:38 +08:00
|
|
|
}
|
2019-08-16 23:33:41 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return Ret;
|
|
|
|
}
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2015-08-17 04:18:19 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFMinFMax(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// If we can shrink the call to a float function rather than a double
|
|
|
|
// function, do that first.
|
2019-06-29 22:28:54 +08:00
|
|
|
Function *Callee = CI->getCalledFunction();
|
2015-11-06 03:18:23 +08:00
|
|
|
StringRef Name = Callee->getName();
|
2016-01-06 08:32:15 +08:00
|
|
|
if ((Name == "fmin" || Name == "fmax") && hasFloatVersion(Name))
|
|
|
|
if (Value *Ret = optimizeBinaryDoubleFP(CI, B))
|
2015-08-17 04:18:19 +08:00
|
|
|
return Ret;
|
|
|
|
|
2019-06-29 22:28:54 +08:00
|
|
|
// The LLVM intrinsics minnum/maxnum correspond to fmin/fmax. Canonicalize to
|
|
|
|
// the intrinsics for improved optimization (for example, vectorization).
|
|
|
|
// No-signed-zeros is implied by the definitions of fmax/fmin themselves.
|
|
|
|
// From the C standard draft WG14/N1256:
|
|
|
|
// "Ideally, fmax would be sensitive to the sign of zero, for example
|
|
|
|
// fmax(-0.0, +0.0) would return +0; however, implementation in software
|
|
|
|
// might be impractical."
|
2015-08-17 05:16:37 +08:00
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
2019-06-29 22:28:54 +08:00
|
|
|
FastMathFlags FMF = CI->getFastMathFlags();
|
|
|
|
FMF.setNoSignedZeros();
|
2016-01-13 02:03:37 +08:00
|
|
|
B.setFastMathFlags(FMF);
|
2015-08-17 04:18:19 +08:00
|
|
|
|
2019-06-29 22:28:54 +08:00
|
|
|
Intrinsic::ID IID = Callee->getName().startswith("fmin") ? Intrinsic::minnum
|
|
|
|
: Intrinsic::maxnum;
|
|
|
|
Function *F = Intrinsic::getDeclaration(CI->getModule(), IID, CI->getType());
|
|
|
|
return B.CreateCall(F, { CI->getArgOperand(0), CI->getArgOperand(1) });
|
2015-08-17 04:18:19 +08:00
|
|
|
}
|
|
|
|
|
2019-10-01 04:52:21 +08:00
|
|
|
Value *LibCallSimplifier::optimizeLog(CallInst *Log, IRBuilder<> &B) {
|
|
|
|
Function *LogFn = Log->getCalledFunction();
|
|
|
|
AttributeList Attrs = LogFn->getAttributes();
|
|
|
|
StringRef LogNm = LogFn->getName();
|
|
|
|
Intrinsic::ID LogID = LogFn->getIntrinsicID();
|
|
|
|
Module *Mod = Log->getModule();
|
|
|
|
Type *Ty = Log->getType();
|
2015-11-30 04:58:04 +08:00
|
|
|
Value *Ret = nullptr;
|
|
|
|
|
2019-10-01 04:52:21 +08:00
|
|
|
if (UnsafeFPShrink && hasFloatVersion(LogNm))
|
|
|
|
Ret = optimizeUnaryDoubleFP(Log, B, true);
|
2016-01-12 07:31:48 +08:00
|
|
|
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
// The earlier call must also be 'fast' in order to do these transforms.
|
2019-10-01 04:52:21 +08:00
|
|
|
CallInst *Arg = dyn_cast<CallInst>(Log->getArgOperand(0));
|
|
|
|
if (!Log->isFast() || !Arg || !Arg->isFast() || !Arg->hasOneUse())
|
2015-11-30 04:58:04 +08:00
|
|
|
return Ret;
|
|
|
|
|
2019-10-01 04:52:21 +08:00
|
|
|
LibFunc LogLb, ExpLb, Exp2Lb, Exp10Lb, PowLb;
|
|
|
|
|
|
|
|
// This is only applicable to log(), log2(), log10().
|
|
|
|
if (TLI->getLibFunc(LogNm, LogLb))
|
|
|
|
switch (LogLb) {
|
|
|
|
case LibFunc_logf:
|
|
|
|
LogID = Intrinsic::log;
|
|
|
|
ExpLb = LibFunc_expf;
|
|
|
|
Exp2Lb = LibFunc_exp2f;
|
|
|
|
Exp10Lb = LibFunc_exp10f;
|
|
|
|
PowLb = LibFunc_powf;
|
|
|
|
break;
|
|
|
|
case LibFunc_log:
|
|
|
|
LogID = Intrinsic::log;
|
|
|
|
ExpLb = LibFunc_exp;
|
|
|
|
Exp2Lb = LibFunc_exp2;
|
|
|
|
Exp10Lb = LibFunc_exp10;
|
|
|
|
PowLb = LibFunc_pow;
|
|
|
|
break;
|
|
|
|
case LibFunc_logl:
|
|
|
|
LogID = Intrinsic::log;
|
|
|
|
ExpLb = LibFunc_expl;
|
|
|
|
Exp2Lb = LibFunc_exp2l;
|
|
|
|
Exp10Lb = LibFunc_exp10l;
|
|
|
|
PowLb = LibFunc_powl;
|
|
|
|
break;
|
|
|
|
case LibFunc_log2f:
|
|
|
|
LogID = Intrinsic::log2;
|
|
|
|
ExpLb = LibFunc_expf;
|
|
|
|
Exp2Lb = LibFunc_exp2f;
|
|
|
|
Exp10Lb = LibFunc_exp10f;
|
|
|
|
PowLb = LibFunc_powf;
|
|
|
|
break;
|
|
|
|
case LibFunc_log2:
|
|
|
|
LogID = Intrinsic::log2;
|
|
|
|
ExpLb = LibFunc_exp;
|
|
|
|
Exp2Lb = LibFunc_exp2;
|
|
|
|
Exp10Lb = LibFunc_exp10;
|
|
|
|
PowLb = LibFunc_pow;
|
|
|
|
break;
|
|
|
|
case LibFunc_log2l:
|
|
|
|
LogID = Intrinsic::log2;
|
|
|
|
ExpLb = LibFunc_expl;
|
|
|
|
Exp2Lb = LibFunc_exp2l;
|
|
|
|
Exp10Lb = LibFunc_exp10l;
|
|
|
|
PowLb = LibFunc_powl;
|
|
|
|
break;
|
|
|
|
case LibFunc_log10f:
|
|
|
|
LogID = Intrinsic::log10;
|
|
|
|
ExpLb = LibFunc_expf;
|
|
|
|
Exp2Lb = LibFunc_exp2f;
|
|
|
|
Exp10Lb = LibFunc_exp10f;
|
|
|
|
PowLb = LibFunc_powf;
|
|
|
|
break;
|
|
|
|
case LibFunc_log10:
|
|
|
|
LogID = Intrinsic::log10;
|
|
|
|
ExpLb = LibFunc_exp;
|
|
|
|
Exp2Lb = LibFunc_exp2;
|
|
|
|
Exp10Lb = LibFunc_exp10;
|
|
|
|
PowLb = LibFunc_pow;
|
|
|
|
break;
|
|
|
|
case LibFunc_log10l:
|
|
|
|
LogID = Intrinsic::log10;
|
|
|
|
ExpLb = LibFunc_expl;
|
|
|
|
Exp2Lb = LibFunc_exp2l;
|
|
|
|
Exp10Lb = LibFunc_exp10l;
|
|
|
|
PowLb = LibFunc_powl;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
else if (LogID == Intrinsic::log || LogID == Intrinsic::log2 ||
|
|
|
|
LogID == Intrinsic::log10) {
|
|
|
|
if (Ty->getScalarType()->isFloatTy()) {
|
|
|
|
ExpLb = LibFunc_expf;
|
|
|
|
Exp2Lb = LibFunc_exp2f;
|
|
|
|
Exp10Lb = LibFunc_exp10f;
|
|
|
|
PowLb = LibFunc_powf;
|
|
|
|
} else if (Ty->getScalarType()->isDoubleTy()) {
|
|
|
|
ExpLb = LibFunc_exp;
|
|
|
|
Exp2Lb = LibFunc_exp2;
|
|
|
|
Exp10Lb = LibFunc_exp10;
|
|
|
|
PowLb = LibFunc_pow;
|
|
|
|
} else
|
|
|
|
return Ret;
|
|
|
|
} else
|
2015-11-30 04:58:04 +08:00
|
|
|
return Ret;
|
|
|
|
|
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
2019-10-01 04:52:21 +08:00
|
|
|
B.setFastMathFlags(FastMathFlags::getFast());
|
|
|
|
|
2019-10-11 05:29:10 +08:00
|
|
|
Intrinsic::ID ArgID = Arg->getIntrinsicID();
|
2019-10-01 04:52:21 +08:00
|
|
|
LibFunc ArgLb = NotLibFunc;
|
2019-10-10 06:03:23 +08:00
|
|
|
TLI->getLibFunc(Arg, ArgLb);
|
2019-10-01 04:52:21 +08:00
|
|
|
|
|
|
|
// log(pow(x,y)) -> y*log(x)
|
|
|
|
if (ArgLb == PowLb || ArgID == Intrinsic::pow) {
|
|
|
|
Value *LogX =
|
|
|
|
Log->doesNotAccessMemory()
|
|
|
|
? B.CreateCall(Intrinsic::getDeclaration(Mod, LogID, Ty),
|
|
|
|
Arg->getOperand(0), "log")
|
|
|
|
: emitUnaryFloatFnCall(Arg->getOperand(0), LogNm, B, Attrs);
|
|
|
|
Value *MulY = B.CreateFMul(Arg->getArgOperand(1), LogX, "mul");
|
|
|
|
// Since pow() may have side effects, e.g. errno,
|
|
|
|
// dead code elimination may not be trusted to remove it.
|
|
|
|
substituteInParent(Arg, MulY);
|
|
|
|
return MulY;
|
|
|
|
}
|
2019-10-10 06:03:23 +08:00
|
|
|
|
2019-10-01 04:52:21 +08:00
|
|
|
// log(exp{,2,10}(y)) -> y*log({e,2,10})
|
|
|
|
// TODO: There is no exp10() intrinsic yet.
|
2019-10-10 06:03:23 +08:00
|
|
|
if (ArgLb == ExpLb || ArgLb == Exp2Lb || ArgLb == Exp10Lb ||
|
2019-10-01 04:52:21 +08:00
|
|
|
ArgID == Intrinsic::exp || ArgID == Intrinsic::exp2) {
|
|
|
|
Constant *Eul;
|
|
|
|
if (ArgLb == ExpLb || ArgID == Intrinsic::exp)
|
2019-10-10 03:58:01 +08:00
|
|
|
// FIXME: Add more precise value of e for long double.
|
|
|
|
Eul = ConstantFP::get(Log->getType(), numbers::e);
|
2019-10-01 04:52:21 +08:00
|
|
|
else if (ArgLb == Exp2Lb || ArgID == Intrinsic::exp2)
|
|
|
|
Eul = ConstantFP::get(Log->getType(), 2.0);
|
|
|
|
else
|
|
|
|
Eul = ConstantFP::get(Log->getType(), 10.0);
|
|
|
|
Value *LogE = Log->doesNotAccessMemory()
|
|
|
|
? B.CreateCall(Intrinsic::getDeclaration(Mod, LogID, Ty),
|
|
|
|
Eul, "log")
|
|
|
|
: emitUnaryFloatFnCall(Eul, LogNm, B, Attrs);
|
|
|
|
Value *MulY = B.CreateFMul(Arg->getArgOperand(0), LogE, "mul");
|
|
|
|
// Since exp() may have side effects, e.g. errno,
|
|
|
|
// dead code elimination may not be trusted to remove it.
|
|
|
|
substituteInParent(Arg, MulY);
|
|
|
|
return MulY;
|
|
|
|
}
|
2015-11-30 04:58:04 +08:00
|
|
|
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
2014-10-17 02:48:17 +08:00
|
|
|
Value *LibCallSimplifier::optimizeSqrt(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
Value *Ret = nullptr;
|
[LangRef] Make @llvm.sqrt(x) return undef, rather than have UB, for negative x.
Summary:
Some frontends emit a speculate-and-select idiom for sqrt, wherein they compute
sqrt(x), check if x is negative, and select NaN if it is:
%cmp = fcmp olt double %a, -0.000000e+00
%sqrt = call double @llvm.sqrt.f64(double %a)
%ret = select i1 %cmp, double 0x7FF8000000000000, double %sqrt
This is technically UB as the LangRef is written today if %a is ever less than
-0. But emitting code that's compliant with the current definition of sqrt
would require a branch, which would then prevent us from matching this idiom in
SelectionDAG (which we do today -- ISD::FSQRT has defined behavior on negative
inputs), because SelectionDAG looks at one BB at a time.
Nothing in LLVM takes advantage of this undefined behavior, as far as we can
tell, and the fact that llvm.sqrt has UB dates from its initial addition to the
LangRef.
Reviewers: arsenm, mehdi_amini, hfinkel
Subscribers: wdng, llvm-commits
Differential Revision: https://reviews.llvm.org/D28797
llvm-svn: 293242
2017-01-27 08:58:03 +08:00
|
|
|
// TODO: Once we have a way (other than checking for the existince of the
|
|
|
|
// libcall) to tell whether our target can lower @llvm.sqrt, relax the
|
|
|
|
// condition below.
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (TLI->has(LibFunc_sqrtf) && (Callee->getName() == "sqrt" ||
|
[LangRef] Make @llvm.sqrt(x) return undef, rather than have UB, for negative x.
Summary:
Some frontends emit a speculate-and-select idiom for sqrt, wherein they compute
sqrt(x), check if x is negative, and select NaN if it is:
%cmp = fcmp olt double %a, -0.000000e+00
%sqrt = call double @llvm.sqrt.f64(double %a)
%ret = select i1 %cmp, double 0x7FF8000000000000, double %sqrt
This is technically UB as the LangRef is written today if %a is ever less than
-0. But emitting code that's compliant with the current definition of sqrt
would require a branch, which would then prevent us from matching this idiom in
SelectionDAG (which we do today -- ISD::FSQRT has defined behavior on negative
inputs), because SelectionDAG looks at one BB at a time.
Nothing in LLVM takes advantage of this undefined behavior, as far as we can
tell, and the fact that llvm.sqrt has UB dates from its initial addition to the
LangRef.
Reviewers: arsenm, mehdi_amini, hfinkel
Subscribers: wdng, llvm-commits
Differential Revision: https://reviews.llvm.org/D28797
llvm-svn: 293242
2017-01-27 08:58:03 +08:00
|
|
|
Callee->getIntrinsicID() == Intrinsic::sqrt))
|
2014-10-17 02:48:17 +08:00
|
|
|
Ret = optimizeUnaryDoubleFP(CI, B, true);
|
2016-01-12 06:34:19 +08:00
|
|
|
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
if (!CI->isFast())
|
2015-10-29 10:58:44 +08:00
|
|
|
return Ret;
|
2014-10-17 02:48:17 +08:00
|
|
|
|
2016-01-07 04:52:21 +08:00
|
|
|
Instruction *I = dyn_cast<Instruction>(CI->getArgOperand(0));
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
if (!I || I->getOpcode() != Instruction::FMul || !I->isFast())
|
2016-01-07 04:52:21 +08:00
|
|
|
return Ret;
|
|
|
|
|
|
|
|
// We're looking for a repeated factor in a multiplication tree,
|
|
|
|
// so we can do this fold: sqrt(x * x) -> fabs(x);
|
2016-01-12 06:34:19 +08:00
|
|
|
// or this fold: sqrt((x * x) * y) -> fabs(x) * sqrt(y).
|
2016-01-07 04:52:21 +08:00
|
|
|
Value *Op0 = I->getOperand(0);
|
|
|
|
Value *Op1 = I->getOperand(1);
|
|
|
|
Value *RepeatOp = nullptr;
|
|
|
|
Value *OtherOp = nullptr;
|
|
|
|
if (Op0 == Op1) {
|
|
|
|
// Simple match: the operands of the multiply are identical.
|
|
|
|
RepeatOp = Op0;
|
|
|
|
} else {
|
|
|
|
// Look for a more complicated pattern: one of the operands is itself
|
|
|
|
// a multiply, so search for a common factor in that multiply.
|
|
|
|
// Note: We don't bother looking any deeper than this first level or for
|
|
|
|
// variations of this pattern because instcombine's visitFMUL and/or the
|
|
|
|
// reassociation pass should give us this form.
|
|
|
|
Value *OtherMul0, *OtherMul1;
|
|
|
|
if (match(Op0, m_FMul(m_Value(OtherMul0), m_Value(OtherMul1)))) {
|
|
|
|
// Pattern: sqrt((x * y) * z)
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
if (OtherMul0 == OtherMul1 && cast<Instruction>(Op0)->isFast()) {
|
2016-01-07 04:52:21 +08:00
|
|
|
// Matched: sqrt((x * x) * z)
|
|
|
|
RepeatOp = OtherMul0;
|
|
|
|
OtherOp = Op1;
|
2014-10-17 02:48:17 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-01-07 04:52:21 +08:00
|
|
|
if (!RepeatOp)
|
|
|
|
return Ret;
|
|
|
|
|
|
|
|
// Fast math flags for any created instructions should match the sqrt
|
|
|
|
// and multiply.
|
|
|
|
IRBuilder<>::FastMathFlagGuard Guard(B);
|
2016-01-13 02:03:37 +08:00
|
|
|
B.setFastMathFlags(I->getFastMathFlags());
|
2016-01-12 06:35:39 +08:00
|
|
|
|
2016-01-07 04:52:21 +08:00
|
|
|
// If we found a repeated factor, hoist it out of the square root and
|
|
|
|
// replace it with the fabs of that factor.
|
|
|
|
Module *M = Callee->getParent();
|
|
|
|
Type *ArgType = I->getType();
|
2019-02-02 04:43:25 +08:00
|
|
|
Function *Fabs = Intrinsic::getDeclaration(M, Intrinsic::fabs, ArgType);
|
2016-01-07 04:52:21 +08:00
|
|
|
Value *FabsCall = B.CreateCall(Fabs, RepeatOp, "fabs");
|
|
|
|
if (OtherOp) {
|
|
|
|
// If we found a non-repeated factor, we still need to get its square
|
|
|
|
// root. We then multiply that by the value that was simplified out
|
|
|
|
// of the square root calculation.
|
2019-02-02 04:43:25 +08:00
|
|
|
Function *Sqrt = Intrinsic::getDeclaration(M, Intrinsic::sqrt, ArgType);
|
2016-01-07 04:52:21 +08:00
|
|
|
Value *SqrtCall = B.CreateCall(Sqrt, OtherOp, "sqrt");
|
|
|
|
return B.CreateFMul(FabsCall, SqrtCall);
|
|
|
|
}
|
|
|
|
return FabsCall;
|
2014-10-17 02:48:17 +08:00
|
|
|
}
|
|
|
|
|
2016-01-07 03:23:35 +08:00
|
|
|
// TODO: Generalize to handle any trig function and its inverse.
|
2015-11-05 07:36:56 +08:00
|
|
|
Value *LibCallSimplifier::optimizeTan(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
Value *Ret = nullptr;
|
2015-11-06 03:18:23 +08:00
|
|
|
StringRef Name = Callee->getName();
|
|
|
|
if (UnsafeFPShrink && Name == "tan" && hasFloatVersion(Name))
|
2015-11-05 07:36:56 +08:00
|
|
|
Ret = optimizeUnaryDoubleFP(CI, B, true);
|
|
|
|
|
|
|
|
Value *Op1 = CI->getArgOperand(0);
|
|
|
|
auto *OpC = dyn_cast<CallInst>(Op1);
|
|
|
|
if (!OpC)
|
|
|
|
return Ret;
|
|
|
|
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
// Both calls must be 'fast' in order to remove them.
|
|
|
|
if (!CI->isFast() || !OpC->isFast())
|
2016-01-07 03:23:35 +08:00
|
|
|
return Ret;
|
|
|
|
|
2015-11-05 07:36:56 +08:00
|
|
|
// tan(atan(x)) -> x
|
|
|
|
// tanf(atanf(x)) -> x
|
|
|
|
// tanl(atanl(x)) -> x
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2015-11-05 07:36:56 +08:00
|
|
|
Function *F = OpC->getCalledFunction();
|
2015-11-26 17:51:17 +08:00
|
|
|
if (F && TLI->getLibFunc(F->getName(), Func) && TLI->has(Func) &&
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
((Func == LibFunc_atan && Callee->getName() == "tan") ||
|
|
|
|
(Func == LibFunc_atanf && Callee->getName() == "tanf") ||
|
|
|
|
(Func == LibFunc_atanl && Callee->getName() == "tanl")))
|
2015-11-05 07:36:56 +08:00
|
|
|
Ret = OpC->getArgOperand(0);
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
2016-01-22 07:38:43 +08:00
|
|
|
static bool isTrigLibCall(CallInst *CI) {
|
|
|
|
// We can only hope to do anything useful if we can ignore things like errno
|
|
|
|
// and floating-point exceptions.
|
2016-04-28 03:04:35 +08:00
|
|
|
// We already checked the prototype.
|
|
|
|
return CI->hasFnAttr(Attribute::NoUnwind) &&
|
|
|
|
CI->hasFnAttr(Attribute::ReadNone);
|
2016-01-22 07:38:43 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
static void insertSinCosCall(IRBuilder<> &B, Function *OrigCallee, Value *Arg,
|
|
|
|
bool UseFloat, Value *&Sin, Value *&Cos,
|
2016-01-22 07:38:43 +08:00
|
|
|
Value *&SinCos) {
|
|
|
|
Type *ArgTy = Arg->getType();
|
|
|
|
Type *ResTy;
|
|
|
|
StringRef Name;
|
|
|
|
|
|
|
|
Triple T(OrigCallee->getParent()->getTargetTriple());
|
|
|
|
if (UseFloat) {
|
|
|
|
Name = "__sincospif_stret";
|
|
|
|
|
|
|
|
assert(T.getArch() != Triple::x86 && "x86 messy and unsupported for now");
|
|
|
|
// x86_64 can't use {float, float} since that would be returned in both
|
|
|
|
// xmm0 and xmm1, which isn't what a real struct would do.
|
|
|
|
ResTy = T.getArch() == Triple::x86_64
|
2017-05-10 03:31:13 +08:00
|
|
|
? static_cast<Type *>(VectorType::get(ArgTy, 2))
|
|
|
|
: static_cast<Type *>(StructType::get(ArgTy, ArgTy));
|
2016-01-22 07:38:43 +08:00
|
|
|
} else {
|
|
|
|
Name = "__sincospi_stret";
|
2017-05-10 03:31:13 +08:00
|
|
|
ResTy = StructType::get(ArgTy, ArgTy);
|
2016-01-22 07:38:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
Module *M = OrigCallee->getParent();
|
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Recommit r352791 after tweaking DerivedTypes.h slightly, so that gcc
doesn't choke on it, hopefully.
Original Message:
The FunctionCallee type is effectively a {FunctionType*,Value*} pair,
and is a useful convenience to enable code to continue passing the
result of getOrInsertFunction() through to EmitCall, even once pointer
types lose their pointee-type.
Then:
- update the CallInst/InvokeInst instruction creation functions to
take a Callee,
- modify getOrInsertFunction to return FunctionCallee, and
- update all callers appropriately.
One area of particular note is the change to the sanitizer
code. Previously, they had been casting the result of
`getOrInsertFunction` to a `Function*` via
`checkSanitizerInterfaceFunction`, and storing that. That would report
an error if someone had already inserted a function declaraction with
a mismatching signature.
However, in general, LLVM allows for such mismatches, as
`getOrInsertFunction` will automatically insert a bitcast if
needed. As part of this cleanup, cause the sanitizer code to do the
same. (It will call its functions using the expected signature,
however they may have been declared.)
Finally, in a small number of locations, callers of
`getOrInsertFunction` actually were expecting/requiring that a brand
new function was being created. In such cases, I've switched them to
Function::Create instead.
Differential Revision: https://reviews.llvm.org/D57315
llvm-svn: 352827
2019-02-01 10:28:03 +08:00
|
|
|
FunctionCallee Callee =
|
|
|
|
M->getOrInsertFunction(Name, OrigCallee->getAttributes(), ResTy, ArgTy);
|
2016-01-22 07:38:43 +08:00
|
|
|
|
|
|
|
if (Instruction *ArgInst = dyn_cast<Instruction>(Arg)) {
|
|
|
|
// If the argument is an instruction, it must dominate all uses so put our
|
|
|
|
// sincos call there.
|
|
|
|
B.SetInsertPoint(ArgInst->getParent(), ++ArgInst->getIterator());
|
|
|
|
} else {
|
|
|
|
// Otherwise (e.g. for a constant) the beginning of the function is as
|
|
|
|
// good a place as any.
|
|
|
|
BasicBlock &EntryBB = B.GetInsertBlock()->getParent()->getEntryBlock();
|
|
|
|
B.SetInsertPoint(&EntryBB, EntryBB.begin());
|
|
|
|
}
|
|
|
|
|
|
|
|
SinCos = B.CreateCall(Callee, Arg, "sincospi");
|
|
|
|
|
|
|
|
if (SinCos->getType()->isStructTy()) {
|
|
|
|
Sin = B.CreateExtractValue(SinCos, 0, "sinpi");
|
|
|
|
Cos = B.CreateExtractValue(SinCos, 1, "cospi");
|
|
|
|
} else {
|
|
|
|
Sin = B.CreateExtractElement(SinCos, ConstantInt::get(B.getInt32Ty(), 0),
|
|
|
|
"sinpi");
|
|
|
|
Cos = B.CreateExtractElement(SinCos, ConstantInt::get(B.getInt32Ty(), 1),
|
|
|
|
"cospi");
|
|
|
|
}
|
|
|
|
}
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeSinCosPi(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// Make sure the prototype is as expected, otherwise the rest of the
|
|
|
|
// function is probably invalid and likely to abort.
|
|
|
|
if (!isTrigLibCall(CI))
|
|
|
|
return nullptr;
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Arg = CI->getArgOperand(0);
|
|
|
|
SmallVector<CallInst *, 1> SinCalls;
|
|
|
|
SmallVector<CallInst *, 1> CosCalls;
|
|
|
|
SmallVector<CallInst *, 1> SinCosCalls;
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
bool IsFloat = Arg->getType()->isFloatTy();
|
2013-11-03 14:48:38 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Look for all compatible sinpi, cospi and sincospi calls with the same
|
|
|
|
// argument. If there are enough (in some sense) we can make the
|
|
|
|
// substitution.
|
2016-03-19 12:53:02 +08:00
|
|
|
Function *F = CI->getFunction();
|
2014-09-18 04:55:46 +08:00
|
|
|
for (User *U : Arg->users())
|
2016-03-19 12:53:02 +08:00
|
|
|
classifyArgUse(U, F, IsFloat, SinCalls, CosCalls, SinCosCalls);
|
2012-11-26 04:45:27 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// It's only worthwhile if both sinpi and cospi are actually used.
|
|
|
|
if (SinCosCalls.empty() && (SinCalls.empty() || CosCalls.empty()))
|
|
|
|
return nullptr;
|
2012-11-26 04:45:27 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Sin, *Cos, *SinCos;
|
|
|
|
insertSinCosCall(B, CI->getCalledFunction(), Arg, IsFloat, Sin, Cos, SinCos);
|
2012-11-26 04:45:27 +08:00
|
|
|
|
2016-12-16 10:28:38 +08:00
|
|
|
auto replaceTrigInsts = [this](SmallVectorImpl<CallInst *> &Calls,
|
|
|
|
Value *Res) {
|
|
|
|
for (CallInst *C : Calls)
|
|
|
|
replaceAllUsesWith(C, Res);
|
|
|
|
};
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
replaceTrigInsts(SinCalls, Sin);
|
|
|
|
replaceTrigInsts(CosCalls, Cos);
|
|
|
|
replaceTrigInsts(SinCosCalls, SinCos);
|
2012-11-26 04:45:27 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-26 08:24:07 +08:00
|
|
|
|
2016-03-19 12:53:02 +08:00
|
|
|
void LibCallSimplifier::classifyArgUse(
|
|
|
|
Value *Val, Function *F, bool IsFloat,
|
|
|
|
SmallVectorImpl<CallInst *> &SinCalls,
|
|
|
|
SmallVectorImpl<CallInst *> &CosCalls,
|
|
|
|
SmallVectorImpl<CallInst *> &SinCosCalls) {
|
2014-09-18 04:55:46 +08:00
|
|
|
CallInst *CI = dyn_cast<CallInst>(Val);
|
|
|
|
|
|
|
|
if (!CI)
|
|
|
|
return;
|
2012-11-26 11:10:07 +08:00
|
|
|
|
2016-03-19 12:53:02 +08:00
|
|
|
// Don't consider calls in other functions.
|
|
|
|
if (CI->getFunction() != F)
|
|
|
|
return;
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Function *Callee = CI->getCalledFunction();
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2016-04-28 03:04:35 +08:00
|
|
|
if (!Callee || !TLI->getLibFunc(*Callee, Func) || !TLI->has(Func) ||
|
2015-11-29 05:43:12 +08:00
|
|
|
!isTrigLibCall(CI))
|
2014-09-18 04:55:46 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
if (IsFloat) {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (Func == LibFunc_sinpif)
|
2014-09-18 04:55:46 +08:00
|
|
|
SinCalls.push_back(CI);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
else if (Func == LibFunc_cospif)
|
2014-09-18 04:55:46 +08:00
|
|
|
CosCalls.push_back(CI);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
else if (Func == LibFunc_sincospif_stret)
|
2014-09-18 04:55:46 +08:00
|
|
|
SinCosCalls.push_back(CI);
|
|
|
|
} else {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (Func == LibFunc_sinpi)
|
2014-09-18 04:55:46 +08:00
|
|
|
SinCalls.push_back(CI);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
else if (Func == LibFunc_cospi)
|
2014-09-18 04:55:46 +08:00
|
|
|
CosCalls.push_back(CI);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
else if (Func == LibFunc_sincospi_stret)
|
2014-09-18 04:55:46 +08:00
|
|
|
SinCosCalls.push_back(CI);
|
2012-11-26 11:10:07 +08:00
|
|
|
}
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-11-26 11:10:07 +08:00
|
|
|
|
2012-11-27 04:37:20 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2014-09-18 04:55:46 +08:00
|
|
|
// Integer Library Call Optimizations
|
2012-11-27 04:37:20 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFFS(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// ffs(x) -> x != 0 ? (i32)llvm.cttz(x)+1 : 0
|
2016-12-16 07:11:00 +08:00
|
|
|
Value *Op = CI->getArgOperand(0);
|
2014-09-18 04:55:46 +08:00
|
|
|
Type *ArgType = Op->getType();
|
2019-02-02 04:43:25 +08:00
|
|
|
Function *F = Intrinsic::getDeclaration(CI->getCalledFunction()->getParent(),
|
|
|
|
Intrinsic::cttz, ArgType);
|
[SimplifyLibCalls] Correctly set the is_zero_undef flag for llvm.cttz
If <src> is non-zero we can safely set the flag to true, and this
results in less code generated for, e.g. ffs(x) + 1 on FreeBSD.
Thanks to majnemer for suggesting the fix and reviewing.
Code generated before the patch was applied:
0: 0f bc c7 bsf %edi,%eax
3: b9 20 00 00 00 mov $0x20,%ecx
8: 0f 45 c8 cmovne %eax,%ecx
b: 83 c1 02 add $0x2,%ecx
e: b8 01 00 00 00 mov $0x1,%eax
13: 85 ff test %edi,%edi
15: 0f 45 c1 cmovne %ecx,%eax
18: c3 retq
Code generated after the patch was applied:
0: 0f bc cf bsf %edi,%ecx
3: 83 c1 02 add $0x2,%ecx
6: 85 ff test %edi,%edi
8: b8 01 00 00 00 mov $0x1,%eax
d: 0f 45 c1 cmovne %ecx,%eax
10: c3 retq
It seems we can still use cmove and save another 'test' instruction, but
that can be tackled separately.
Differential Revision: http://reviews.llvm.org/D11989
llvm-svn: 244947
2015-08-14 04:34:26 +08:00
|
|
|
Value *V = B.CreateCall(F, {Op, B.getTrue()}, "cttz");
|
2014-09-18 04:55:46 +08:00
|
|
|
V = B.CreateAdd(V, ConstantInt::get(V->getType(), 1));
|
|
|
|
V = B.CreateIntCast(V, B.getInt32Ty(), false);
|
2013-11-17 10:06:35 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *Cond = B.CreateICmpNE(Op, Constant::getNullValue(ArgType));
|
|
|
|
return B.CreateSelect(Cond, V, B.getInt32(0));
|
|
|
|
}
|
|
|
|
|
2016-12-16 07:45:11 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFls(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// fls(x) -> (i32)(sizeInBits(x) - llvm.ctlz(x, false))
|
|
|
|
Value *Op = CI->getArgOperand(0);
|
|
|
|
Type *ArgType = Op->getType();
|
2019-02-02 04:43:25 +08:00
|
|
|
Function *F = Intrinsic::getDeclaration(CI->getCalledFunction()->getParent(),
|
|
|
|
Intrinsic::ctlz, ArgType);
|
2016-12-16 07:45:11 +08:00
|
|
|
Value *V = B.CreateCall(F, {Op, B.getFalse()}, "ctlz");
|
|
|
|
V = B.CreateSub(ConstantInt::get(V->getType(), ArgType->getIntegerBitWidth()),
|
|
|
|
V);
|
|
|
|
return B.CreateIntCast(V, CI->getType(), false);
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeAbs(CallInst *CI, IRBuilder<> &B) {
|
2018-05-23 07:29:40 +08:00
|
|
|
// abs(x) -> x <s 0 ? -x : x
|
|
|
|
// The negation has 'nsw' because abs of INT_MIN is undefined.
|
|
|
|
Value *X = CI->getArgOperand(0);
|
|
|
|
Value *IsNeg = B.CreateICmpSLT(X, Constant::getNullValue(X->getType()));
|
|
|
|
Value *NegX = B.CreateNSWNeg(X, "neg");
|
|
|
|
return B.CreateSelect(IsNeg, NegX, X);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2013-11-17 10:06:35 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeIsDigit(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// isdigit(c) -> (c-'0') <u 10
|
|
|
|
Value *Op = CI->getArgOperand(0);
|
|
|
|
Op = B.CreateSub(Op, B.getInt32('0'), "isdigittmp");
|
|
|
|
Op = B.CreateICmpULT(Op, B.getInt32(10), "isdigit");
|
|
|
|
return B.CreateZExt(Op, CI->getType());
|
|
|
|
}
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeIsAscii(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// isascii(c) -> c <u 128
|
|
|
|
Value *Op = CI->getArgOperand(0);
|
|
|
|
Op = B.CreateICmpULT(Op, B.getInt32(128), "isascii");
|
|
|
|
return B.CreateZExt(Op, CI->getType());
|
|
|
|
}
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeToAscii(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// toascii(c) -> c & 0x7f
|
|
|
|
return B.CreateAnd(CI->getArgOperand(0),
|
|
|
|
ConstantInt::get(CI->getType(), 0x7F));
|
|
|
|
}
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2018-04-26 02:58:53 +08:00
|
|
|
Value *LibCallSimplifier::optimizeAtoi(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
StringRef Str;
|
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(0), Str))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
return convertStrToNumber(CI, Str, 10);
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeStrtol(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
StringRef Str;
|
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(0), Str))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
if (!isa<ConstantPointerNull>(CI->getArgOperand(1)))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
if (ConstantInt *CInt = dyn_cast<ConstantInt>(CI->getArgOperand(2))) {
|
|
|
|
return convertStrToNumber(CI, Str, CInt->getSExtValue());
|
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Formatting and IO Library Call Optimizations
|
|
|
|
//===----------------------------------------------------------------------===//
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
static bool isReportingError(Function *Callee, CallInst *CI, int StreamArg);
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeErrorReporting(CallInst *CI, IRBuilder<> &B,
|
|
|
|
int StreamArg) {
|
2016-04-28 03:04:35 +08:00
|
|
|
Function *Callee = CI->getCalledFunction();
|
2014-09-18 04:55:46 +08:00
|
|
|
// Error reporting calls should be cold, mark them as such.
|
|
|
|
// This applies even to non-builtin calls: it is only a hint and applies to
|
|
|
|
// functions that the frontend might not understand as builtins.
|
|
|
|
|
|
|
|
// This heuristic was suggested in:
|
|
|
|
// Improving Static Branch Prediction in a Compiler
|
|
|
|
// Brian L. Deitrich, Ben-Chung Cheng, Wen-mei W. Hwu
|
|
|
|
// Proceedings of PACT'98, Oct. 1998, IEEE
|
|
|
|
if (!CI->hasFnAttr(Attribute::Cold) &&
|
|
|
|
isReportingError(Callee, CI, StreamArg)) {
|
Rename AttributeSet to AttributeList
Summary:
This class is a list of AttributeSetNodes corresponding the function
prototype of a call or function declaration. This class used to be
called ParamAttrListPtr, then AttrListPtr, then AttributeSet. It is
typically accessed by parameter and return value index, so
"AttributeList" seems like a more intuitive name.
Rename AttributeSetImpl to AttributeListImpl to follow suit.
It's useful to rename this class so that we can rename AttributeSetNode
to AttributeSet later. AttributeSet is the set of attributes that apply
to a single function, argument, or return value.
Reviewers: sanjoy, javed.absar, chandlerc, pete
Reviewed By: pete
Subscribers: pete, jholewinski, arsenm, dschuff, mehdi_amini, jfb, nhaehnle, sbc100, void, llvm-commits
Differential Revision: https://reviews.llvm.org/D31102
llvm-svn: 298393
2017-03-22 00:57:19 +08:00
|
|
|
CI->addAttribute(AttributeList::FunctionIndex, Attribute::Cold);
|
2012-11-27 04:37:20 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
static bool isReportingError(Function *Callee, CallInst *CI, int StreamArg) {
|
2017-04-25 11:48:47 +08:00
|
|
|
if (!Callee || !Callee->isDeclaration())
|
2014-09-18 04:55:46 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
if (StreamArg < 0)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
// These functions might be considered cold, but only if their stream
|
|
|
|
// argument is stderr.
|
|
|
|
|
|
|
|
if (StreamArg >= (int)CI->getNumArgOperands())
|
|
|
|
return false;
|
|
|
|
LoadInst *LI = dyn_cast<LoadInst>(CI->getArgOperand(StreamArg));
|
|
|
|
if (!LI)
|
|
|
|
return false;
|
|
|
|
GlobalVariable *GV = dyn_cast<GlobalVariable>(LI->getPointerOperand());
|
|
|
|
if (!GV || !GV->isDeclaration())
|
|
|
|
return false;
|
|
|
|
return GV->getName() == "stderr";
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizePrintFString(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// Check for a fixed format string.
|
|
|
|
StringRef FormatStr;
|
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(0), FormatStr))
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2012-11-27 04:37:20 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Empty format string -> noop.
|
|
|
|
if (FormatStr.empty()) // Tolerate printf's declared void.
|
|
|
|
return CI->use_empty() ? (Value *)CI : ConstantInt::get(CI->getType(), 0);
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Do not do any of the following transformations if the printf return value
|
|
|
|
// is used, in general the printf return value is not compatible with either
|
|
|
|
// putchar() or puts().
|
|
|
|
if (!CI->use_empty())
|
|
|
|
return nullptr;
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2016-05-09 22:36:16 +08:00
|
|
|
// printf("x") -> putchar('x'), even for "%" and "%%".
|
|
|
|
if (FormatStr.size() == 1 || FormatStr == "%%")
|
2016-04-03 09:46:52 +08:00
|
|
|
return emitPutChar(B.getInt32(FormatStr[0]), B, TLI);
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2016-03-28 23:54:01 +08:00
|
|
|
// printf("%s", "a") --> putchar('a')
|
|
|
|
if (FormatStr == "%s" && CI->getNumArgOperands() > 1) {
|
|
|
|
StringRef ChrStr;
|
|
|
|
if (!getConstantStringInfo(CI->getOperand(1), ChrStr))
|
|
|
|
return nullptr;
|
|
|
|
if (ChrStr.size() != 1)
|
|
|
|
return nullptr;
|
2016-04-03 09:46:52 +08:00
|
|
|
return emitPutChar(B.getInt32(ChrStr[0]), B, TLI);
|
2016-03-28 23:54:01 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// printf("foo\n") --> puts("foo")
|
|
|
|
if (FormatStr[FormatStr.size() - 1] == '\n' &&
|
|
|
|
FormatStr.find('%') == StringRef::npos) { // No format characters.
|
|
|
|
// Create a string literal with no \n on it. We expect the constant merge
|
|
|
|
// pass to be run after this pass, to merge duplicate strings.
|
|
|
|
FormatStr = FormatStr.drop_back();
|
|
|
|
Value *GV = B.CreateGlobalString(FormatStr, "str");
|
2016-04-03 09:46:52 +08:00
|
|
|
return emitPutS(GV, B, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Optimize specific format strings.
|
|
|
|
// printf("%c", chr) --> putchar(chr)
|
|
|
|
if (FormatStr == "%c" && CI->getNumArgOperands() > 1 &&
|
2016-04-03 09:46:52 +08:00
|
|
|
CI->getArgOperand(1)->getType()->isIntegerTy())
|
|
|
|
return emitPutChar(CI->getArgOperand(1), B, TLI);
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// printf("%s\n", str) --> puts(str)
|
|
|
|
if (FormatStr == "%s\n" && CI->getNumArgOperands() > 1 &&
|
2016-04-03 09:46:52 +08:00
|
|
|
CI->getArgOperand(1)->getType()->isPointerTy())
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitPutS(CI->getArgOperand(1), B, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizePrintF(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
FunctionType *FT = Callee->getFunctionType();
|
|
|
|
if (Value *V = optimizePrintFString(CI, B)) {
|
|
|
|
return V;
|
2012-11-27 13:57:54 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// printf(format, ...) -> iprintf(format, ...) if no floating point
|
|
|
|
// arguments.
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (TLI->has(LibFunc_iprintf) && !callHasFloatingPointArgument(CI)) {
|
2014-09-18 04:55:46 +08:00
|
|
|
Module *M = B.GetInsertBlock()->getParent()->getParent();
|
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Recommit r352791 after tweaking DerivedTypes.h slightly, so that gcc
doesn't choke on it, hopefully.
Original Message:
The FunctionCallee type is effectively a {FunctionType*,Value*} pair,
and is a useful convenience to enable code to continue passing the
result of getOrInsertFunction() through to EmitCall, even once pointer
types lose their pointee-type.
Then:
- update the CallInst/InvokeInst instruction creation functions to
take a Callee,
- modify getOrInsertFunction to return FunctionCallee, and
- update all callers appropriately.
One area of particular note is the change to the sanitizer
code. Previously, they had been casting the result of
`getOrInsertFunction` to a `Function*` via
`checkSanitizerInterfaceFunction`, and storing that. That would report
an error if someone had already inserted a function declaraction with
a mismatching signature.
However, in general, LLVM allows for such mismatches, as
`getOrInsertFunction` will automatically insert a bitcast if
needed. As part of this cleanup, cause the sanitizer code to do the
same. (It will call its functions using the expected signature,
however they may have been declared.)
Finally, in a small number of locations, callers of
`getOrInsertFunction` actually were expecting/requiring that a brand
new function was being created. In such cases, I've switched them to
Function::Create instead.
Differential Revision: https://reviews.llvm.org/D57315
llvm-svn: 352827
2019-02-01 10:28:03 +08:00
|
|
|
FunctionCallee IPrintFFn =
|
2014-09-18 04:55:46 +08:00
|
|
|
M->getOrInsertFunction("iprintf", FT, Callee->getAttributes());
|
|
|
|
CallInst *New = cast<CallInst>(CI->clone());
|
|
|
|
New->setCalledFunction(IPrintFFn);
|
|
|
|
B.Insert(New);
|
|
|
|
return New;
|
|
|
|
}
|
2019-04-03 09:08:35 +08:00
|
|
|
|
|
|
|
// printf(format, ...) -> __small_printf(format, ...) if no 128-bit floating point
|
|
|
|
// arguments.
|
|
|
|
if (TLI->has(LibFunc_small_printf) && !callHasFP128Argument(CI)) {
|
|
|
|
Module *M = B.GetInsertBlock()->getParent()->getParent();
|
|
|
|
auto SmallPrintFFn =
|
|
|
|
M->getOrInsertFunction(TLI->getName(LibFunc_small_printf),
|
|
|
|
FT, Callee->getAttributes());
|
|
|
|
CallInst *New = cast<CallInst>(CI->clone());
|
|
|
|
New->setCalledFunction(SmallPrintFFn);
|
|
|
|
B.Insert(New);
|
|
|
|
return New;
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeSPrintFString(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// Check for a fixed format string.
|
|
|
|
StringRef FormatStr;
|
2019-10-01 21:19:04 +08:00
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(1), FormatStr))
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// If we just have a format string (nothing else crazy) transform it.
|
|
|
|
if (CI->getNumArgOperands() == 2) {
|
|
|
|
// Make sure there's no % in the constant array. We could try to handle
|
|
|
|
// %% -> % in the future if we cared.
|
2018-06-01 00:39:27 +08:00
|
|
|
if (FormatStr.find('%') != StringRef::npos)
|
|
|
|
return nullptr; // we found a format specifier, bail out.
|
2014-09-18 04:55:46 +08:00
|
|
|
|
2018-02-06 05:23:22 +08:00
|
|
|
// sprintf(str, fmt) -> llvm.memcpy(align 1 str, align 1 fmt, strlen(fmt)+1)
|
2019-12-16 22:24:13 +08:00
|
|
|
B.CreateMemCpy(
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CI->getArgOperand(0), Align(1), CI->getArgOperand(1), Align(1),
|
2019-12-16 22:24:13 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()),
|
|
|
|
FormatStr.size() + 1)); // Copy the null byte.
|
2014-09-18 04:55:46 +08:00
|
|
|
return ConstantInt::get(CI->getType(), FormatStr.size());
|
|
|
|
}
|
2012-11-27 13:57:54 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// The remaining optimizations require the format string to be "%s" or "%c"
|
|
|
|
// and have an extra operand.
|
|
|
|
if (FormatStr.size() != 2 || FormatStr[0] != '%' ||
|
|
|
|
CI->getNumArgOperands() < 3)
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2014-09-18 04:55:46 +08:00
|
|
|
|
|
|
|
// Decode the second character of the format string.
|
|
|
|
if (FormatStr[1] == 'c') {
|
|
|
|
// sprintf(dst, "%c", chr) --> *(i8*)dst = chr; *((i8*)dst+1) = 0
|
2019-10-01 21:19:04 +08:00
|
|
|
if (!CI->getArgOperand(2)->getType()->isIntegerTy())
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
2019-10-01 21:19:04 +08:00
|
|
|
Value *V = B.CreateTrunc(CI->getArgOperand(2), B.getInt8Ty(), "char");
|
|
|
|
Value *Ptr = castToCStr(CI->getArgOperand(0), B);
|
2014-09-18 04:55:46 +08:00
|
|
|
B.CreateStore(V, Ptr);
|
2015-03-31 04:42:56 +08:00
|
|
|
Ptr = B.CreateGEP(B.getInt8Ty(), Ptr, B.getInt32(1), "nul");
|
2014-09-18 04:55:46 +08:00
|
|
|
B.CreateStore(B.getInt8(0), Ptr);
|
|
|
|
|
|
|
|
return ConstantInt::get(CI->getType(), 1);
|
2012-11-27 13:57:54 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (FormatStr[1] == 's') {
|
2019-10-01 21:03:10 +08:00
|
|
|
// sprintf(dest, "%s", str) -> llvm.memcpy(align 1 dest, align 1 str,
|
|
|
|
// strlen(str)+1)
|
2019-10-01 21:19:04 +08:00
|
|
|
if (!CI->getArgOperand(2)->getType()->isPointerTy())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
Value *Len = emitStrLen(CI->getArgOperand(2), B, DL, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
if (!Len)
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2016-04-27 05:04:47 +08:00
|
|
|
Value *IncLen =
|
|
|
|
B.CreateAdd(Len, ConstantInt::get(Len->getType(), 1), "leninc");
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
B.CreateMemCpy(CI->getArgOperand(0), Align(1), CI->getArgOperand(2),
|
|
|
|
Align(1), IncLen);
|
2013-04-17 10:01:10 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// The sprintf result is the unincremented number of bytes in the string.
|
|
|
|
return B.CreateIntCast(Len, CI->getType(), false);
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-29 23:45:33 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeSPrintF(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
FunctionType *FT = Callee->getFunctionType();
|
|
|
|
if (Value *V = optimizeSPrintFString(CI, B)) {
|
|
|
|
return V;
|
|
|
|
}
|
2012-11-29 23:45:33 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// sprintf(str, format, ...) -> siprintf(str, format, ...) if no floating
|
|
|
|
// point arguments.
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (TLI->has(LibFunc_siprintf) && !callHasFloatingPointArgument(CI)) {
|
2014-09-18 04:55:46 +08:00
|
|
|
Module *M = B.GetInsertBlock()->getParent()->getParent();
|
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Recommit r352791 after tweaking DerivedTypes.h slightly, so that gcc
doesn't choke on it, hopefully.
Original Message:
The FunctionCallee type is effectively a {FunctionType*,Value*} pair,
and is a useful convenience to enable code to continue passing the
result of getOrInsertFunction() through to EmitCall, even once pointer
types lose their pointee-type.
Then:
- update the CallInst/InvokeInst instruction creation functions to
take a Callee,
- modify getOrInsertFunction to return FunctionCallee, and
- update all callers appropriately.
One area of particular note is the change to the sanitizer
code. Previously, they had been casting the result of
`getOrInsertFunction` to a `Function*` via
`checkSanitizerInterfaceFunction`, and storing that. That would report
an error if someone had already inserted a function declaraction with
a mismatching signature.
However, in general, LLVM allows for such mismatches, as
`getOrInsertFunction` will automatically insert a bitcast if
needed. As part of this cleanup, cause the sanitizer code to do the
same. (It will call its functions using the expected signature,
however they may have been declared.)
Finally, in a small number of locations, callers of
`getOrInsertFunction` actually were expecting/requiring that a brand
new function was being created. In such cases, I've switched them to
Function::Create instead.
Differential Revision: https://reviews.llvm.org/D57315
llvm-svn: 352827
2019-02-01 10:28:03 +08:00
|
|
|
FunctionCallee SIPrintFFn =
|
2014-09-18 04:55:46 +08:00
|
|
|
M->getOrInsertFunction("siprintf", FT, Callee->getAttributes());
|
|
|
|
CallInst *New = cast<CallInst>(CI->clone());
|
|
|
|
New->setCalledFunction(SIPrintFFn);
|
|
|
|
B.Insert(New);
|
|
|
|
return New;
|
|
|
|
}
|
2019-04-03 09:08:35 +08:00
|
|
|
|
|
|
|
// sprintf(str, format, ...) -> __small_sprintf(str, format, ...) if no 128-bit
|
|
|
|
// floating point arguments.
|
|
|
|
if (TLI->has(LibFunc_small_sprintf) && !callHasFP128Argument(CI)) {
|
|
|
|
Module *M = B.GetInsertBlock()->getParent()->getParent();
|
|
|
|
auto SmallSPrintFFn =
|
|
|
|
M->getOrInsertFunction(TLI->getName(LibFunc_small_sprintf),
|
|
|
|
FT, Callee->getAttributes());
|
|
|
|
CallInst *New = cast<CallInst>(CI->clone());
|
|
|
|
New->setCalledFunction(SmallSPrintFFn);
|
|
|
|
B.Insert(New);
|
|
|
|
return New;
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, {0, 1});
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-29 23:45:33 +08:00
|
|
|
|
2018-05-12 01:50:49 +08:00
|
|
|
Value *LibCallSimplifier::optimizeSnPrintFString(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// Check for size
|
|
|
|
ConstantInt *Size = dyn_cast<ConstantInt>(CI->getArgOperand(1));
|
|
|
|
if (!Size)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
uint64_t N = Size->getZExtValue();
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
// Check for a fixed format string.
|
|
|
|
StringRef FormatStr;
|
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(2), FormatStr))
|
|
|
|
return nullptr;
|
2018-05-12 01:50:49 +08:00
|
|
|
|
|
|
|
// If we just have a format string (nothing else crazy) transform it.
|
|
|
|
if (CI->getNumArgOperands() == 3) {
|
|
|
|
// Make sure there's no % in the constant array. We could try to handle
|
|
|
|
// %% -> % in the future if we cared.
|
2018-06-01 00:39:27 +08:00
|
|
|
if (FormatStr.find('%') != StringRef::npos)
|
|
|
|
return nullptr; // we found a format specifier, bail out.
|
2018-05-12 01:50:49 +08:00
|
|
|
|
|
|
|
if (N == 0)
|
|
|
|
return ConstantInt::get(CI->getType(), FormatStr.size());
|
|
|
|
else if (N < FormatStr.size() + 1)
|
|
|
|
return nullptr;
|
|
|
|
|
2019-03-12 18:31:52 +08:00
|
|
|
// snprintf(dst, size, fmt) -> llvm.memcpy(align 1 dst, align 1 fmt,
|
2018-05-12 01:50:49 +08:00
|
|
|
// strlen(fmt)+1)
|
|
|
|
B.CreateMemCpy(
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CI->getArgOperand(0), Align(1), CI->getArgOperand(2), Align(1),
|
2018-05-12 01:50:49 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()),
|
|
|
|
FormatStr.size() + 1)); // Copy the null byte.
|
|
|
|
return ConstantInt::get(CI->getType(), FormatStr.size());
|
|
|
|
}
|
|
|
|
|
|
|
|
// The remaining optimizations require the format string to be "%s" or "%c"
|
|
|
|
// and have an extra operand.
|
|
|
|
if (FormatStr.size() == 2 && FormatStr[0] == '%' &&
|
|
|
|
CI->getNumArgOperands() == 4) {
|
|
|
|
|
|
|
|
// Decode the second character of the format string.
|
|
|
|
if (FormatStr[1] == 'c') {
|
|
|
|
if (N == 0)
|
|
|
|
return ConstantInt::get(CI->getType(), 1);
|
|
|
|
else if (N == 1)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// snprintf(dst, size, "%c", chr) --> *(i8*)dst = chr; *((i8*)dst+1) = 0
|
|
|
|
if (!CI->getArgOperand(3)->getType()->isIntegerTy())
|
|
|
|
return nullptr;
|
|
|
|
Value *V = B.CreateTrunc(CI->getArgOperand(3), B.getInt8Ty(), "char");
|
|
|
|
Value *Ptr = castToCStr(CI->getArgOperand(0), B);
|
|
|
|
B.CreateStore(V, Ptr);
|
|
|
|
Ptr = B.CreateGEP(B.getInt8Ty(), Ptr, B.getInt32(1), "nul");
|
|
|
|
B.CreateStore(B.getInt8(0), Ptr);
|
|
|
|
|
|
|
|
return ConstantInt::get(CI->getType(), 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (FormatStr[1] == 's') {
|
|
|
|
// snprintf(dest, size, "%s", str) to llvm.memcpy(dest, str, len+1, 1)
|
|
|
|
StringRef Str;
|
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(3), Str))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
if (N == 0)
|
|
|
|
return ConstantInt::get(CI->getType(), Str.size());
|
|
|
|
else if (N < Str.size() + 1)
|
|
|
|
return nullptr;
|
|
|
|
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
B.CreateMemCpy(CI->getArgOperand(0), Align(1), CI->getArgOperand(3),
|
|
|
|
Align(1), ConstantInt::get(CI->getType(), Str.size() + 1));
|
2018-05-12 01:50:49 +08:00
|
|
|
|
|
|
|
// The snprintf result is the unincremented number of bytes in the string.
|
|
|
|
return ConstantInt::get(CI->getType(), Str.size());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeSnPrintF(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (Value *V = optimizeSnPrintFString(CI, B)) {
|
|
|
|
return V;
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (isKnownNonZero(CI->getOperand(1), DL))
|
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
2018-05-12 01:50:49 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFPrintFString(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
optimizeErrorReporting(CI, B, 0);
|
2012-11-29 23:45:33 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// All the optimizations depend on the format string.
|
|
|
|
StringRef FormatStr;
|
|
|
|
if (!getConstantStringInfo(CI->getArgOperand(1), FormatStr))
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Do not do any of the following transformations if the fprintf return
|
|
|
|
// value is used, in general the fprintf return value is not compatible
|
|
|
|
// with fwrite(), fputc() or fputs().
|
|
|
|
if (!CI->use_empty())
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2014-09-18 04:55:46 +08:00
|
|
|
|
|
|
|
// fprintf(F, "foo") --> fwrite("foo", 3, 1, F)
|
|
|
|
if (CI->getNumArgOperands() == 2) {
|
2018-06-01 00:39:27 +08:00
|
|
|
// Could handle %% -> % if we cared.
|
|
|
|
if (FormatStr.find('%') != StringRef::npos)
|
|
|
|
return nullptr; // We found a format specifier.
|
2014-09-18 04:55:46 +08:00
|
|
|
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitFWrite(
|
2014-09-18 04:55:46 +08:00
|
|
|
CI->getArgOperand(1),
|
2015-03-10 10:37:25 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), FormatStr.size()),
|
2014-09-18 04:55:46 +08:00
|
|
|
CI->getArgOperand(0), B, DL, TLI);
|
2012-11-29 23:45:33 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// The remaining optimizations require the format string to be "%s" or "%c"
|
|
|
|
// and have an extra operand.
|
|
|
|
if (FormatStr.size() != 2 || FormatStr[0] != '%' ||
|
|
|
|
CI->getNumArgOperands() < 3)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Decode the second character of the format string.
|
|
|
|
if (FormatStr[1] == 'c') {
|
|
|
|
// fprintf(F, "%c", chr) --> fputc(chr, F)
|
|
|
|
if (!CI->getArgOperand(2)->getType()->isIntegerTy())
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitFPutC(CI->getArgOperand(2), CI->getArgOperand(0), B, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
2012-11-29 23:45:33 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
if (FormatStr[1] == 's') {
|
|
|
|
// fprintf(F, "%s", str) --> fputs(str, F)
|
|
|
|
if (!CI->getArgOperand(2)->getType()->isPointerTy())
|
|
|
|
return nullptr;
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitFPutS(CI->getArgOperand(2), CI->getArgOperand(0), B, TLI);
|
2014-09-18 04:55:46 +08:00
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-29 23:45:33 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFPrintF(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
Function *Callee = CI->getCalledFunction();
|
|
|
|
FunctionType *FT = Callee->getFunctionType();
|
|
|
|
if (Value *V = optimizeFPrintFString(CI, B)) {
|
|
|
|
return V;
|
2012-11-29 23:45:33 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// fprintf(stream, format, ...) -> fiprintf(stream, format, ...) if no
|
|
|
|
// floating point arguments.
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (TLI->has(LibFunc_fiprintf) && !callHasFloatingPointArgument(CI)) {
|
2014-09-18 04:55:46 +08:00
|
|
|
Module *M = B.GetInsertBlock()->getParent()->getParent();
|
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Recommit r352791 after tweaking DerivedTypes.h slightly, so that gcc
doesn't choke on it, hopefully.
Original Message:
The FunctionCallee type is effectively a {FunctionType*,Value*} pair,
and is a useful convenience to enable code to continue passing the
result of getOrInsertFunction() through to EmitCall, even once pointer
types lose their pointee-type.
Then:
- update the CallInst/InvokeInst instruction creation functions to
take a Callee,
- modify getOrInsertFunction to return FunctionCallee, and
- update all callers appropriately.
One area of particular note is the change to the sanitizer
code. Previously, they had been casting the result of
`getOrInsertFunction` to a `Function*` via
`checkSanitizerInterfaceFunction`, and storing that. That would report
an error if someone had already inserted a function declaraction with
a mismatching signature.
However, in general, LLVM allows for such mismatches, as
`getOrInsertFunction` will automatically insert a bitcast if
needed. As part of this cleanup, cause the sanitizer code to do the
same. (It will call its functions using the expected signature,
however they may have been declared.)
Finally, in a small number of locations, callers of
`getOrInsertFunction` actually were expecting/requiring that a brand
new function was being created. In such cases, I've switched them to
Function::Create instead.
Differential Revision: https://reviews.llvm.org/D57315
llvm-svn: 352827
2019-02-01 10:28:03 +08:00
|
|
|
FunctionCallee FIPrintFFn =
|
2014-09-18 04:55:46 +08:00
|
|
|
M->getOrInsertFunction("fiprintf", FT, Callee->getAttributes());
|
|
|
|
CallInst *New = cast<CallInst>(CI->clone());
|
|
|
|
New->setCalledFunction(FIPrintFFn);
|
|
|
|
B.Insert(New);
|
|
|
|
return New;
|
|
|
|
}
|
2019-04-03 09:08:35 +08:00
|
|
|
|
|
|
|
// fprintf(stream, format, ...) -> __small_fprintf(stream, format, ...) if no
|
|
|
|
// 128-bit floating point arguments.
|
|
|
|
if (TLI->has(LibFunc_small_fprintf) && !callHasFP128Argument(CI)) {
|
|
|
|
Module *M = B.GetInsertBlock()->getParent()->getParent();
|
|
|
|
auto SmallFPrintFFn =
|
|
|
|
M->getOrInsertFunction(TLI->getName(LibFunc_small_fprintf),
|
|
|
|
FT, Callee->getAttributes());
|
|
|
|
CallInst *New = cast<CallInst>(CI->clone());
|
|
|
|
New->setCalledFunction(SmallFPrintFFn);
|
|
|
|
B.Insert(New);
|
|
|
|
return New;
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2013-11-17 10:06:35 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFWrite(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
optimizeErrorReporting(CI, B, 3);
|
2012-11-29 23:45:39 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Get the element size and count.
|
|
|
|
ConstantInt *SizeC = dyn_cast<ConstantInt>(CI->getArgOperand(1));
|
|
|
|
ConstantInt *CountC = dyn_cast<ConstantInt>(CI->getArgOperand(2));
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
if (SizeC && CountC) {
|
|
|
|
uint64_t Bytes = SizeC->getZExtValue() * CountC->getZExtValue();
|
|
|
|
|
|
|
|
// If this is writing zero records, remove the call (it's a noop).
|
|
|
|
if (Bytes == 0)
|
|
|
|
return ConstantInt::get(CI->getType(), 0);
|
|
|
|
|
|
|
|
// If this is writing one byte, turn it into fputc.
|
|
|
|
// This optimisation is only valid, if the return value is unused.
|
|
|
|
if (Bytes == 1 && CI->use_empty()) { // fwrite(S,1,1,F) -> fputc(S[0],F)
|
2019-02-02 04:44:24 +08:00
|
|
|
Value *Char = B.CreateLoad(B.getInt8Ty(),
|
|
|
|
castToCStr(CI->getArgOperand(0), B), "char");
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
Value *NewCI = emitFPutC(Char, CI->getArgOperand(3), B, TLI);
|
|
|
|
return NewCI ? ConstantInt::get(CI->getType(), 1) : nullptr;
|
|
|
|
}
|
2018-04-27 09:48:09 +08:00
|
|
|
}
|
2018-04-27 06:31:43 +08:00
|
|
|
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
if (isLocallyOpenedFile(CI->getArgOperand(3), CI, B, TLI))
|
|
|
|
return emitFWriteUnlocked(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), CI->getArgOperand(3), B, DL,
|
|
|
|
TLI);
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-29 23:45:43 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFPuts(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
optimizeErrorReporting(CI, B, 1);
|
2012-11-30 03:15:17 +08:00
|
|
|
|
2016-07-07 22:31:19 +08:00
|
|
|
// Don't rewrite fputs to fwrite when optimising for size because fwrite
|
|
|
|
// requires more arguments and thus extra MOVs are required.
|
2019-04-16 00:49:00 +08:00
|
|
|
bool OptForSize = CI->getFunction()->hasOptSize() ||
|
2019-11-21 05:08:07 +08:00
|
|
|
llvm::shouldOptimizeForSize(CI->getParent(), PSI, BFI,
|
|
|
|
PGSOQueryType::IRPass);
|
2019-04-16 00:49:00 +08:00
|
|
|
if (OptForSize)
|
2016-07-07 22:31:19 +08:00
|
|
|
return nullptr;
|
|
|
|
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
// Check if has any use
|
|
|
|
if (!CI->use_empty()) {
|
|
|
|
if (isLocallyOpenedFile(CI->getArgOperand(1), CI, B, TLI))
|
|
|
|
return emitFPutSUnlocked(CI->getArgOperand(0), CI->getArgOperand(1), B,
|
|
|
|
TLI);
|
|
|
|
else
|
|
|
|
// We can't optimize if return value is used.
|
|
|
|
return nullptr;
|
|
|
|
}
|
2012-11-30 03:15:17 +08:00
|
|
|
|
2019-03-12 18:31:52 +08:00
|
|
|
// fputs(s,F) --> fwrite(s,strlen(s),1,F)
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len = GetStringLength(CI->getArgOperand(0));
|
2014-09-18 04:55:46 +08:00
|
|
|
if (!Len)
|
|
|
|
return nullptr;
|
2012-10-14 00:45:24 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
// Known to have no uses (see above).
|
2016-01-20 03:46:10 +08:00
|
|
|
return emitFWrite(
|
2014-09-18 04:55:46 +08:00
|
|
|
CI->getArgOperand(0),
|
2015-03-10 10:37:25 +08:00
|
|
|
ConstantInt::get(DL.getIntPtrType(CI->getContext()), Len - 1),
|
2014-09-18 04:55:46 +08:00
|
|
|
CI->getArgOperand(1), B, DL, TLI);
|
|
|
|
}
|
2012-10-14 00:45:24 +08:00
|
|
|
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFPutc(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
optimizeErrorReporting(CI, B, 1);
|
|
|
|
|
|
|
|
if (isLocallyOpenedFile(CI->getArgOperand(1), CI, B, TLI))
|
|
|
|
return emitFPutCUnlocked(CI->getArgOperand(0), CI->getArgOperand(1), B,
|
|
|
|
TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeFGetc(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (isLocallyOpenedFile(CI->getArgOperand(0), CI, B, TLI))
|
|
|
|
return emitFGetCUnlocked(CI->getArgOperand(0), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeFGets(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (isLocallyOpenedFile(CI->getArgOperand(2), CI, B, TLI))
|
|
|
|
return emitFGetSUnlocked(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *LibCallSimplifier::optimizeFRead(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
if (isLocallyOpenedFile(CI->getArgOperand(3), CI, B, TLI))
|
|
|
|
return emitFReadUnlocked(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), CI->getArgOperand(3), B, DL,
|
|
|
|
TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
Value *LibCallSimplifier::optimizePuts(CallInst *CI, IRBuilder<> &B) {
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
annotateNonNullBasedOnAccess(CI, 0);
|
2019-03-12 22:20:22 +08:00
|
|
|
if (!CI->use_empty())
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2019-03-12 22:20:22 +08:00
|
|
|
// Check for a constant string.
|
|
|
|
// puts("") -> putchar('\n')
|
|
|
|
StringRef Str;
|
|
|
|
if (getConstantStringInfo(CI->getArgOperand(0), Str) && Str.empty())
|
|
|
|
return emitPutChar(B.getInt32('\n'), B, TLI);
|
2012-10-14 00:45:24 +08:00
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
2012-10-14 00:45:24 +08:00
|
|
|
|
2019-10-03 06:49:20 +08:00
|
|
|
Value *LibCallSimplifier::optimizeBCopy(CallInst *CI, IRBuilder<> &B) {
|
|
|
|
// bcopy(src, dst, n) -> llvm.memmove(dst, src, n)
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
return B.CreateMemMove(CI->getArgOperand(1), Align(1), CI->getArgOperand(0),
|
|
|
|
Align(1), CI->getArgOperand(2));
|
2019-10-03 06:49:20 +08:00
|
|
|
}
|
|
|
|
|
2014-09-18 04:55:46 +08:00
|
|
|
bool LibCallSimplifier::hasFloatVersion(StringRef FuncName) {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2013-03-12 08:08:29 +08:00
|
|
|
SmallString<20> FloatFuncName = FuncName;
|
|
|
|
FloatFuncName += 'f';
|
|
|
|
if (TLI->getLibFunc(FloatFuncName, Func))
|
|
|
|
return TLI->has(Func);
|
|
|
|
return false;
|
|
|
|
}
|
2012-11-13 12:16:17 +08:00
|
|
|
|
2015-01-13 01:20:06 +08:00
|
|
|
Value *LibCallSimplifier::optimizeStringMemoryLibCall(CallInst *CI,
|
|
|
|
IRBuilder<> &Builder) {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2013-03-12 08:08:29 +08:00
|
|
|
Function *Callee = CI->getCalledFunction();
|
2015-01-13 01:20:06 +08:00
|
|
|
// Check for string/memory library functions.
|
2016-04-28 03:04:35 +08:00
|
|
|
if (TLI->getLibFunc(*Callee, Func) && TLI->has(Func)) {
|
2015-01-13 01:20:06 +08:00
|
|
|
// Make sure we never change the calling convention.
|
|
|
|
assert((ignoreCallingConv(Func) ||
|
2016-09-13 20:10:14 +08:00
|
|
|
isCallingConvCCompatible(CI)) &&
|
2015-01-13 01:20:06 +08:00
|
|
|
"Optimizing string/memory libcall would change the calling convention");
|
2013-03-12 08:08:29 +08:00
|
|
|
switch (Func) {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strcat:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrCat(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strncat:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrNCat(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strchr:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrChr(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strrchr:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrRChr(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strcmp:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrCmp(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strncmp:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrNCmp(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strcpy:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrCpy(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_stpcpy:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStpCpy(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strncpy:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrNCpy(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strlen:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrLen(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strpbrk:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrPBrk(CI, Builder);
|
2019-09-24 02:20:01 +08:00
|
|
|
case LibFunc_strndup:
|
|
|
|
return optimizeStrNDup(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strtol:
|
|
|
|
case LibFunc_strtod:
|
|
|
|
case LibFunc_strtof:
|
|
|
|
case LibFunc_strtoul:
|
|
|
|
case LibFunc_strtoll:
|
|
|
|
case LibFunc_strtold:
|
|
|
|
case LibFunc_strtoull:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrTo(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strspn:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrSpn(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strcspn:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrCSpn(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_strstr:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeStrStr(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memchr:
|
2015-03-21 23:36:21 +08:00
|
|
|
return optimizeMemChr(CI, Builder);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
case LibFunc_memrchr:
|
|
|
|
return optimizeMemRChr(CI, Builder);
|
2019-05-06 17:15:22 +08:00
|
|
|
case LibFunc_bcmp:
|
|
|
|
return optimizeBCmp(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memcmp:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeMemCmp(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memcpy:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeMemCpy(CI, Builder);
|
2019-11-26 03:15:25 +08:00
|
|
|
case LibFunc_memccpy:
|
|
|
|
return optimizeMemCCpy(CI, Builder);
|
[InstCombine] mempcpy(d,s,n) to memcpy(d,s,n) + n
Summary:
Back-end currently expands mempcpy, but middle-end should work with memcpy instead of mempcpy to enable more memcpy-optimization.
GCC backend emits mempcpy, so LLVM backend could form it too, if we know mempcpy libcall is better than memcpy + n.
https://godbolt.org/z/dOCG96
Reviewers: efriedma, spatel, craig.topper, RKSimon, jdoerfert
Reviewed By: efriedma
Subscribers: hjl.tools, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65737
llvm-svn: 370593
2019-09-01 02:19:05 +08:00
|
|
|
case LibFunc_mempcpy:
|
|
|
|
return optimizeMemPCpy(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memmove:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeMemMove(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memset:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeMemSet(CI, Builder);
|
2018-04-18 22:21:31 +08:00
|
|
|
case LibFunc_realloc:
|
|
|
|
return optimizeRealloc(CI, Builder);
|
2017-05-20 06:37:09 +08:00
|
|
|
case LibFunc_wcslen:
|
|
|
|
return optimizeWcslen(CI, Builder);
|
2019-10-03 06:49:20 +08:00
|
|
|
case LibFunc_bcopy:
|
|
|
|
return optimizeBCopy(CI, Builder);
|
2015-01-13 01:20:06 +08:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2017-08-15 05:15:13 +08:00
|
|
|
Value *LibCallSimplifier::optimizeFloatingPointLibCall(CallInst *CI,
|
|
|
|
LibFunc Func,
|
|
|
|
IRBuilder<> &Builder) {
|
|
|
|
// Don't optimize calls that require strict floating point semantics.
|
|
|
|
if (CI->isStrictFP())
|
|
|
|
return nullptr;
|
|
|
|
|
2018-08-14 03:24:41 +08:00
|
|
|
if (Value *V = optimizeTrigReflections(CI, Func, Builder))
|
|
|
|
return V;
|
|
|
|
|
2017-08-15 05:15:13 +08:00
|
|
|
switch (Func) {
|
|
|
|
case LibFunc_sinpif:
|
|
|
|
case LibFunc_sinpi:
|
|
|
|
case LibFunc_cospif:
|
|
|
|
case LibFunc_cospi:
|
|
|
|
return optimizeSinCosPi(CI, Builder);
|
|
|
|
case LibFunc_powf:
|
|
|
|
case LibFunc_pow:
|
|
|
|
case LibFunc_powl:
|
|
|
|
return optimizePow(CI, Builder);
|
|
|
|
case LibFunc_exp2l:
|
|
|
|
case LibFunc_exp2:
|
|
|
|
case LibFunc_exp2f:
|
|
|
|
return optimizeExp2(CI, Builder);
|
|
|
|
case LibFunc_fabsf:
|
|
|
|
case LibFunc_fabs:
|
|
|
|
case LibFunc_fabsl:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::fabs);
|
|
|
|
case LibFunc_sqrtf:
|
|
|
|
case LibFunc_sqrt:
|
|
|
|
case LibFunc_sqrtl:
|
|
|
|
return optimizeSqrt(CI, Builder);
|
2019-10-01 04:52:21 +08:00
|
|
|
case LibFunc_logf:
|
2017-08-15 05:15:13 +08:00
|
|
|
case LibFunc_log:
|
2019-10-01 04:52:21 +08:00
|
|
|
case LibFunc_logl:
|
|
|
|
case LibFunc_log10f:
|
2017-08-15 05:15:13 +08:00
|
|
|
case LibFunc_log10:
|
2019-10-01 04:52:21 +08:00
|
|
|
case LibFunc_log10l:
|
|
|
|
case LibFunc_log1pf:
|
2017-08-15 05:15:13 +08:00
|
|
|
case LibFunc_log1p:
|
2019-10-01 04:52:21 +08:00
|
|
|
case LibFunc_log1pl:
|
|
|
|
case LibFunc_log2f:
|
2017-08-15 05:15:13 +08:00
|
|
|
case LibFunc_log2:
|
2019-10-01 04:52:21 +08:00
|
|
|
case LibFunc_log2l:
|
|
|
|
case LibFunc_logbf:
|
2017-08-15 05:15:13 +08:00
|
|
|
case LibFunc_logb:
|
2019-10-01 04:52:21 +08:00
|
|
|
case LibFunc_logbl:
|
2017-08-15 05:15:13 +08:00
|
|
|
return optimizeLog(CI, Builder);
|
|
|
|
case LibFunc_tan:
|
|
|
|
case LibFunc_tanf:
|
|
|
|
case LibFunc_tanl:
|
|
|
|
return optimizeTan(CI, Builder);
|
|
|
|
case LibFunc_ceil:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::ceil);
|
|
|
|
case LibFunc_floor:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::floor);
|
|
|
|
case LibFunc_round:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::round);
|
|
|
|
case LibFunc_nearbyint:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::nearbyint);
|
|
|
|
case LibFunc_rint:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::rint);
|
|
|
|
case LibFunc_trunc:
|
|
|
|
return replaceUnaryCall(CI, Builder, Intrinsic::trunc);
|
|
|
|
case LibFunc_acos:
|
|
|
|
case LibFunc_acosh:
|
|
|
|
case LibFunc_asin:
|
|
|
|
case LibFunc_asinh:
|
|
|
|
case LibFunc_atan:
|
|
|
|
case LibFunc_atanh:
|
|
|
|
case LibFunc_cbrt:
|
|
|
|
case LibFunc_cosh:
|
|
|
|
case LibFunc_exp:
|
|
|
|
case LibFunc_exp10:
|
|
|
|
case LibFunc_expm1:
|
2018-08-14 03:24:41 +08:00
|
|
|
case LibFunc_cos:
|
2017-08-15 05:15:13 +08:00
|
|
|
case LibFunc_sin:
|
|
|
|
case LibFunc_sinh:
|
|
|
|
case LibFunc_tanh:
|
|
|
|
if (UnsafeFPShrink && hasFloatVersion(CI->getCalledFunction()->getName()))
|
|
|
|
return optimizeUnaryDoubleFP(CI, Builder, true);
|
|
|
|
return nullptr;
|
|
|
|
case LibFunc_copysign:
|
|
|
|
if (hasFloatVersion(CI->getCalledFunction()->getName()))
|
|
|
|
return optimizeBinaryDoubleFP(CI, Builder);
|
|
|
|
return nullptr;
|
|
|
|
case LibFunc_fminf:
|
|
|
|
case LibFunc_fmin:
|
|
|
|
case LibFunc_fminl:
|
|
|
|
case LibFunc_fmaxf:
|
|
|
|
case LibFunc_fmax:
|
|
|
|
case LibFunc_fmaxl:
|
|
|
|
return optimizeFMinFMax(CI, Builder);
|
2017-12-16 09:26:25 +08:00
|
|
|
case LibFunc_cabs:
|
|
|
|
case LibFunc_cabsf:
|
|
|
|
case LibFunc_cabsl:
|
|
|
|
return optimizeCAbs(CI, Builder);
|
2017-08-15 05:15:13 +08:00
|
|
|
default:
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-01-13 01:20:06 +08:00
|
|
|
Value *LibCallSimplifier::optimizeCall(CallInst *CI) {
|
2017-08-15 05:15:13 +08:00
|
|
|
// TODO: Split out the code below that operates on FP calls so that
|
|
|
|
// we can all non-FP calls with the StrictFP attribute to be
|
|
|
|
// optimized.
|
2015-01-13 01:20:06 +08:00
|
|
|
if (CI->isNoBuiltin())
|
|
|
|
return nullptr;
|
|
|
|
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2015-01-13 01:20:06 +08:00
|
|
|
Function *Callee = CI->getCalledFunction();
|
2016-01-06 13:01:34 +08:00
|
|
|
|
|
|
|
SmallVector<OperandBundleDef, 2> OpBundles;
|
|
|
|
CI->getOperandBundlesAsDefs(OpBundles);
|
|
|
|
IRBuilder<> Builder(CI, /*FPMathTag=*/nullptr, OpBundles);
|
2016-09-13 20:10:14 +08:00
|
|
|
bool isCallingConvC = isCallingConvCCompatible(CI);
|
2015-01-13 01:20:06 +08:00
|
|
|
|
2016-01-20 02:38:52 +08:00
|
|
|
// Command-line parameter overrides instruction attribute.
|
2017-08-15 05:15:13 +08:00
|
|
|
// This can't be moved to optimizeFloatingPointLibCall() because it may be
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
// used by the intrinsic optimizations.
|
2015-01-13 01:20:06 +08:00
|
|
|
if (EnableUnsafeFPShrink.getNumOccurrences() > 0)
|
|
|
|
UnsafeFPShrink = EnableUnsafeFPShrink;
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
else if (isa<FPMathOperator>(CI) && CI->isFast())
|
2015-10-29 10:58:44 +08:00
|
|
|
UnsafeFPShrink = true;
|
2015-01-13 01:20:06 +08:00
|
|
|
|
|
|
|
// First, check for intrinsics.
|
|
|
|
if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(CI)) {
|
|
|
|
if (!isCallingConvC)
|
|
|
|
return nullptr;
|
2017-08-15 05:15:13 +08:00
|
|
|
// The FP intrinsics have corresponding constrained versions so we don't
|
|
|
|
// need to check for the StrictFP attribute here.
|
2015-01-13 01:20:06 +08:00
|
|
|
switch (II->getIntrinsicID()) {
|
|
|
|
case Intrinsic::pow:
|
|
|
|
return optimizePow(CI, Builder);
|
|
|
|
case Intrinsic::exp2:
|
|
|
|
return optimizeExp2(CI, Builder);
|
2015-11-30 04:58:04 +08:00
|
|
|
case Intrinsic::log:
|
2019-10-01 04:52:21 +08:00
|
|
|
case Intrinsic::log2:
|
|
|
|
case Intrinsic::log10:
|
2015-11-30 04:58:04 +08:00
|
|
|
return optimizeLog(CI, Builder);
|
2015-01-13 01:20:06 +08:00
|
|
|
case Intrinsic::sqrt:
|
|
|
|
return optimizeSqrt(CI, Builder);
|
2016-01-27 00:17:24 +08:00
|
|
|
// TODO: Use foldMallocMemset() with memset intrinsic.
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
case Intrinsic::memset:
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
return optimizeMemSet(CI, Builder);
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
case Intrinsic::memcpy:
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
return optimizeMemCpy(CI, Builder);
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
case Intrinsic::memmove:
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
return optimizeMemMove(CI, Builder);
|
2015-01-13 01:20:06 +08:00
|
|
|
default:
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-01-13 01:22:43 +08:00
|
|
|
// Also try to simplify calls to fortified library functions.
|
|
|
|
if (Value *SimplifiedFortifiedCI = FortifiedSimplifier.optimizeCall(CI)) {
|
|
|
|
// Try to further simplify the result.
|
2015-01-14 08:55:05 +08:00
|
|
|
CallInst *SimplifiedCI = dyn_cast<CallInst>(SimplifiedFortifiedCI);
|
2015-10-02 06:43:53 +08:00
|
|
|
if (SimplifiedCI && SimplifiedCI->getCalledFunction()) {
|
|
|
|
// Use an IR Builder from SimplifiedCI if available instead of CI
|
|
|
|
// to guarantee we reach all uses we might replace later on.
|
|
|
|
IRBuilder<> TmpBuilder(SimplifiedCI);
|
|
|
|
if (Value *V = optimizeStringMemoryLibCall(SimplifiedCI, TmpBuilder)) {
|
[SimplifyLibCalls] Don't confuse strcpy_chk for stpcpy_chk.
This was introduced in a faulty refactoring (r225640, mea culpa):
the tests weren't testing the return values, so, for both
__strcpy_chk and __stpcpy_chk, we would return the end of the
buffer (matching stpcpy) instead of the beginning (for strcpy).
The root cause was the prefix "__" being ignored when comparing,
which made us always pick LibFunc::stpcpy_chk.
Pass the LibFunc::Func directly to avoid this kind of error.
Also, make the testcases as explicit as possible to prevent this.
The now-useful testcases expose another, entangled, stpcpy problem,
with the further simplification. This was introduced in a
refactoring (r225640) to match the original behavior.
However, this leads to problems when successive simplifications
generate several similar instructions, none of which are removed
by the custom replaceAllUsesWith.
For instance, InstCombine (the main user) doesn't erase the
instruction in its custom RAUW. When trying to simplify say
__stpcpy_chk:
- first, an stpcpy is created (fortified simplifier),
- second, a memcpy is created (normal simplifier), but the
stpcpy call isn't removed.
- third, InstCombine later revisits the instructions,
and simplifies the first stpcpy to a memcpy. We now have
two memcpys.
llvm-svn: 227250
2015-01-28 05:52:16 +08:00
|
|
|
// If we were able to further simplify, remove the now redundant call.
|
2019-09-07 06:07:11 +08:00
|
|
|
substituteInParent(SimplifiedCI, V);
|
2015-01-13 01:22:43 +08:00
|
|
|
return V;
|
[SimplifyLibCalls] Don't confuse strcpy_chk for stpcpy_chk.
This was introduced in a faulty refactoring (r225640, mea culpa):
the tests weren't testing the return values, so, for both
__strcpy_chk and __stpcpy_chk, we would return the end of the
buffer (matching stpcpy) instead of the beginning (for strcpy).
The root cause was the prefix "__" being ignored when comparing,
which made us always pick LibFunc::stpcpy_chk.
Pass the LibFunc::Func directly to avoid this kind of error.
Also, make the testcases as explicit as possible to prevent this.
The now-useful testcases expose another, entangled, stpcpy problem,
with the further simplification. This was introduced in a
refactoring (r225640) to match the original behavior.
However, this leads to problems when successive simplifications
generate several similar instructions, none of which are removed
by the custom replaceAllUsesWith.
For instance, InstCombine (the main user) doesn't erase the
instruction in its custom RAUW. When trying to simplify say
__stpcpy_chk:
- first, an stpcpy is created (fortified simplifier),
- second, a memcpy is created (normal simplifier), but the
stpcpy call isn't removed.
- third, InstCombine later revisits the instructions,
and simplifies the first stpcpy to a memcpy. We now have
two memcpys.
llvm-svn: 227250
2015-01-28 05:52:16 +08:00
|
|
|
}
|
2015-10-02 06:43:53 +08:00
|
|
|
}
|
2015-01-13 01:22:43 +08:00
|
|
|
return SimplifiedFortifiedCI;
|
|
|
|
}
|
|
|
|
|
2015-01-13 01:20:06 +08:00
|
|
|
// Then check for known library functions.
|
2016-04-28 03:04:35 +08:00
|
|
|
if (TLI->getLibFunc(*Callee, Func) && TLI->has(Func)) {
|
2015-01-13 01:20:06 +08:00
|
|
|
// We never change the calling convention.
|
|
|
|
if (!ignoreCallingConv(Func) && !isCallingConvC)
|
|
|
|
return nullptr;
|
|
|
|
if (Value *V = optimizeStringMemoryLibCall(CI, Builder))
|
|
|
|
return V;
|
2017-08-15 05:15:13 +08:00
|
|
|
if (Value *V = optimizeFloatingPointLibCall(CI, Func, Builder))
|
|
|
|
return V;
|
2015-01-13 01:20:06 +08:00
|
|
|
switch (Func) {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_ffs:
|
|
|
|
case LibFunc_ffsl:
|
|
|
|
case LibFunc_ffsll:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeFFS(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_fls:
|
|
|
|
case LibFunc_flsl:
|
|
|
|
case LibFunc_flsll:
|
2016-12-16 07:45:11 +08:00
|
|
|
return optimizeFls(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_abs:
|
|
|
|
case LibFunc_labs:
|
|
|
|
case LibFunc_llabs:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeAbs(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_isdigit:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeIsDigit(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_isascii:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeIsAscii(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_toascii:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeToAscii(CI, Builder);
|
2018-04-26 02:58:53 +08:00
|
|
|
case LibFunc_atoi:
|
|
|
|
case LibFunc_atol:
|
|
|
|
case LibFunc_atoll:
|
|
|
|
return optimizeAtoi(CI, Builder);
|
|
|
|
case LibFunc_strtol:
|
|
|
|
case LibFunc_strtoll:
|
|
|
|
return optimizeStrtol(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_printf:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizePrintF(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_sprintf:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeSPrintF(CI, Builder);
|
2018-05-12 01:50:49 +08:00
|
|
|
case LibFunc_snprintf:
|
|
|
|
return optimizeSnPrintF(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_fprintf:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeFPrintF(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_fwrite:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeFWrite(CI, Builder);
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
case LibFunc_fread:
|
|
|
|
return optimizeFRead(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_fputs:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeFPuts(CI, Builder);
|
[SimplifyLibcalls] Replace locked IO with unlocked IO
Summary: If file stream arg is not captured and source is fopen, we could replace IO calls by unlocked IO ("_unlocked" function variants) to gain better speed,
Reviewers: efriedma, RKSimon, spatel, sanjoy, hfinkel, majnemer, lebedev.ri, rja
Reviewed By: rja
Subscribers: rja, srhines, efriedma, lebedev.ri, llvm-commits
Differential Revision: https://reviews.llvm.org/D45736
llvm-svn: 332452
2018-05-16 19:39:52 +08:00
|
|
|
case LibFunc_fgets:
|
|
|
|
return optimizeFGets(CI, Builder);
|
|
|
|
case LibFunc_fputc:
|
|
|
|
return optimizeFPutc(CI, Builder);
|
|
|
|
case LibFunc_fgetc:
|
|
|
|
return optimizeFGetc(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_puts:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizePuts(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_perror:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeErrorReporting(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_vfprintf:
|
|
|
|
case LibFunc_fiprintf:
|
2014-09-18 04:55:46 +08:00
|
|
|
return optimizeErrorReporting(CI, Builder, 0);
|
2014-11-13 05:23:34 +08:00
|
|
|
default:
|
|
|
|
return nullptr;
|
|
|
|
}
|
2013-03-12 08:08:29 +08:00
|
|
|
}
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2012-10-14 00:45:24 +08:00
|
|
|
}
|
|
|
|
|
2015-01-21 10:11:59 +08:00
|
|
|
LibCallSimplifier::LibCallSimplifier(
|
2015-03-10 10:37:25 +08:00
|
|
|
const DataLayout &DL, const TargetLibraryInfo *TLI,
|
2017-07-27 03:03:18 +08:00
|
|
|
OptimizationRemarkEmitter &ORE,
|
2019-04-16 00:49:00 +08:00
|
|
|
BlockFrequencyInfo *BFI, ProfileSummaryInfo *PSI,
|
2018-10-11 22:51:11 +08:00
|
|
|
function_ref<void(Instruction *, Value *)> Replacer,
|
|
|
|
function_ref<void(Instruction *)> Eraser)
|
2019-04-16 00:49:00 +08:00
|
|
|
: FortifiedSimplifier(TLI), DL(DL), TLI(TLI), ORE(ORE), BFI(BFI), PSI(PSI),
|
2018-10-11 22:51:11 +08:00
|
|
|
UnsafeFPShrink(false), Replacer(Replacer), Eraser(Eraser) {}
|
2015-01-21 10:11:59 +08:00
|
|
|
|
|
|
|
void LibCallSimplifier::replaceAllUsesWith(Instruction *I, Value *With) {
|
|
|
|
// Indirect through the replacer used in this instance.
|
|
|
|
Replacer(I, With);
|
2012-10-14 00:45:24 +08:00
|
|
|
}
|
|
|
|
|
2018-10-11 22:51:11 +08:00
|
|
|
void LibCallSimplifier::eraseFromParent(Instruction *I) {
|
|
|
|
Eraser(I);
|
|
|
|
}
|
|
|
|
|
2013-06-21 03:48:07 +08:00
|
|
|
// TODO:
|
|
|
|
// Additional cases that we need to add to this file:
|
|
|
|
//
|
|
|
|
// cbrt:
|
|
|
|
// * cbrt(expN(X)) -> expN(x/3)
|
|
|
|
// * cbrt(sqrt(x)) -> pow(x,1/6)
|
2015-08-27 02:30:16 +08:00
|
|
|
// * cbrt(cbrt(x)) -> pow(x,1/9)
|
2013-06-21 03:48:07 +08:00
|
|
|
//
|
|
|
|
// exp, expf, expl:
|
|
|
|
// * exp(log(x)) -> x
|
|
|
|
//
|
|
|
|
// log, logf, logl:
|
|
|
|
// * log(exp(x)) -> x
|
|
|
|
// * log(exp(y)) -> y*log(e)
|
|
|
|
// * log(exp10(y)) -> y*log(10)
|
|
|
|
// * log(sqrt(x)) -> 0.5*log(x)
|
|
|
|
//
|
|
|
|
// pow, powf, powl:
|
|
|
|
// * pow(sqrt(x),y) -> pow(x,y*0.5)
|
|
|
|
// * pow(pow(x,y),z)-> pow(x,y*z)
|
|
|
|
//
|
|
|
|
// signbit:
|
|
|
|
// * signbit(cnst) -> cnst'
|
|
|
|
// * signbit(nncst) -> 0 (if pstv is a non-negative constant)
|
|
|
|
//
|
|
|
|
// sqrt, sqrtf, sqrtl:
|
|
|
|
// * sqrt(expN(x)) -> expN(x*0.5)
|
|
|
|
// * sqrt(Nroot(x)) -> pow(x,1/(2*N))
|
|
|
|
// * sqrt(pow(x,y)) -> pow(|x|,y*0.5)
|
|
|
|
//
|
2015-01-13 01:22:43 +08:00
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Fortified Library Call Optimizations
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2019-06-01 06:41:36 +08:00
|
|
|
bool
|
|
|
|
FortifiedLibCallSimplifier::isFortifiedCallFoldable(CallInst *CI,
|
|
|
|
unsigned ObjSizeOp,
|
|
|
|
Optional<unsigned> SizeOp,
|
|
|
|
Optional<unsigned> StrOp,
|
|
|
|
Optional<unsigned> FlagOp) {
|
|
|
|
// If this function takes a flag argument, the implementation may use it to
|
|
|
|
// perform extra checks. Don't fold into the non-checking variant.
|
|
|
|
if (FlagOp) {
|
|
|
|
ConstantInt *Flag = dyn_cast<ConstantInt>(CI->getArgOperand(*FlagOp));
|
|
|
|
if (!Flag || !Flag->isZero())
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (SizeOp && CI->getArgOperand(ObjSizeOp) == CI->getArgOperand(*SizeOp))
|
2015-01-13 01:22:43 +08:00
|
|
|
return true;
|
2019-06-01 06:41:36 +08:00
|
|
|
|
2015-01-13 01:22:43 +08:00
|
|
|
if (ConstantInt *ObjSizeCI =
|
|
|
|
dyn_cast<ConstantInt>(CI->getArgOperand(ObjSizeOp))) {
|
2017-07-07 02:39:47 +08:00
|
|
|
if (ObjSizeCI->isMinusOne())
|
2015-01-13 01:22:43 +08:00
|
|
|
return true;
|
|
|
|
// If the object size wasn't -1 (unknown), bail out if we were asked to.
|
|
|
|
if (OnlyLowerUnknownSize)
|
|
|
|
return false;
|
2019-06-01 06:41:36 +08:00
|
|
|
if (StrOp) {
|
|
|
|
uint64_t Len = GetStringLength(CI->getArgOperand(*StrOp));
|
2015-01-13 01:22:43 +08:00
|
|
|
// If the length is 0 we don't know how long it is and so we can't
|
|
|
|
// remove the check.
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len)
|
|
|
|
annotateDereferenceableBytes(CI, *StrOp, Len);
|
|
|
|
else
|
2015-01-13 01:22:43 +08:00
|
|
|
return false;
|
|
|
|
return ObjSizeCI->getZExtValue() >= Len;
|
|
|
|
}
|
2019-06-01 06:41:36 +08:00
|
|
|
|
|
|
|
if (SizeOp) {
|
|
|
|
if (ConstantInt *SizeCI =
|
|
|
|
dyn_cast<ConstantInt>(CI->getArgOperand(*SizeOp)))
|
|
|
|
return ObjSizeCI->getZExtValue() >= SizeCI->getZExtValue();
|
|
|
|
}
|
2015-01-13 01:22:43 +08:00
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeMemCpyChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
2019-06-01 06:41:36 +08:00
|
|
|
if (isFortifiedCallFoldable(CI, 3, 2)) {
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI =
|
|
|
|
B.CreateMemCpy(CI->getArgOperand(0), Align(1), CI->getArgOperand(1),
|
|
|
|
Align(1), CI->getArgOperand(2));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2015-01-13 01:22:43 +08:00
|
|
|
return CI->getArgOperand(0);
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeMemMoveChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
2019-06-01 06:41:36 +08:00
|
|
|
if (isFortifiedCallFoldable(CI, 3, 2)) {
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CallInst *NewCI =
|
|
|
|
B.CreateMemMove(CI->getArgOperand(0), Align(1), CI->getArgOperand(1),
|
|
|
|
Align(1), CI->getArgOperand(2));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2015-01-13 01:22:43 +08:00
|
|
|
return CI->getArgOperand(0);
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2016-01-01 00:10:49 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeMemSetChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
2016-01-27 00:17:24 +08:00
|
|
|
// TODO: Try foldMallocMemset() here.
|
|
|
|
|
2019-06-01 06:41:36 +08:00
|
|
|
if (isFortifiedCallFoldable(CI, 3, 2)) {
|
2015-01-13 01:22:43 +08:00
|
|
|
Value *Val = B.CreateIntCast(CI->getArgOperand(1), B.getInt8Ty(), false);
|
2019-12-10 00:36:50 +08:00
|
|
|
CallInst *NewCI = B.CreateMemSet(CI->getArgOperand(0), Val,
|
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
2020-01-21 22:00:04 +08:00
|
|
|
CI->getArgOperand(2), Align(1));
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
NewCI->setAttributes(CI->getAttributes());
|
2015-01-13 01:22:43 +08:00
|
|
|
return CI->getArgOperand(0);
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Don't confuse strcpy_chk for stpcpy_chk.
This was introduced in a faulty refactoring (r225640, mea culpa):
the tests weren't testing the return values, so, for both
__strcpy_chk and __stpcpy_chk, we would return the end of the
buffer (matching stpcpy) instead of the beginning (for strcpy).
The root cause was the prefix "__" being ignored when comparing,
which made us always pick LibFunc::stpcpy_chk.
Pass the LibFunc::Func directly to avoid this kind of error.
Also, make the testcases as explicit as possible to prevent this.
The now-useful testcases expose another, entangled, stpcpy problem,
with the further simplification. This was introduced in a
refactoring (r225640) to match the original behavior.
However, this leads to problems when successive simplifications
generate several similar instructions, none of which are removed
by the custom replaceAllUsesWith.
For instance, InstCombine (the main user) doesn't erase the
instruction in its custom RAUW. When trying to simplify say
__stpcpy_chk:
- first, an stpcpy is created (fortified simplifier),
- second, a memcpy is created (normal simplifier), but the
stpcpy call isn't removed.
- third, InstCombine later revisits the instructions,
and simplifies the first stpcpy to a memcpy. We now have
two memcpys.
llvm-svn: 227250
2015-01-28 05:52:16 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeStrpCpyChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B,
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func) {
|
2015-03-10 10:37:25 +08:00
|
|
|
const DataLayout &DL = CI->getModule()->getDataLayout();
|
2015-01-13 01:22:43 +08:00
|
|
|
Value *Dst = CI->getArgOperand(0), *Src = CI->getArgOperand(1),
|
|
|
|
*ObjSize = CI->getArgOperand(2);
|
|
|
|
|
|
|
|
// __stpcpy_chk(x,x,...) -> x+strlen(x)
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (Func == LibFunc_stpcpy_chk && !OnlyLowerUnknownSize && Dst == Src) {
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *StrLen = emitStrLen(Src, B, DL, TLI);
|
2015-04-04 05:33:42 +08:00
|
|
|
return StrLen ? B.CreateInBoundsGEP(B.getInt8Ty(), Dst, StrLen) : nullptr;
|
2015-01-13 01:22:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// If a) we don't have any length information, or b) we know this will
|
|
|
|
// fit then just lower to a plain st[rp]cpy. Otherwise we'll keep our
|
|
|
|
// st[rp]cpy_chk call which may fail at runtime if the size is too long.
|
|
|
|
// TODO: It might be nice to get a maximum length out of the possible
|
|
|
|
// string lengths for varying.
|
2019-06-01 06:41:36 +08:00
|
|
|
if (isFortifiedCallFoldable(CI, 2, None, 1)) {
|
2019-06-01 06:41:31 +08:00
|
|
|
if (Func == LibFunc_strcpy_chk)
|
|
|
|
return emitStrCpy(Dst, Src, B, TLI);
|
|
|
|
else
|
|
|
|
return emitStpCpy(Dst, Src, B, TLI);
|
|
|
|
}
|
2015-01-13 01:22:43 +08:00
|
|
|
|
2015-04-04 05:32:06 +08:00
|
|
|
if (OnlyLowerUnknownSize)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Maybe we can stil fold __st[rp]cpy_chk to __memcpy_chk.
|
2018-05-23 04:27:36 +08:00
|
|
|
uint64_t Len = GetStringLength(Src);
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
if (Len)
|
|
|
|
annotateDereferenceableBytes(CI, 1, Len);
|
|
|
|
else
|
2015-04-04 05:32:06 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
Type *SizeTTy = DL.getIntPtrType(CI->getContext());
|
|
|
|
Value *LenV = ConstantInt::get(SizeTTy, Len);
|
2016-01-20 03:46:10 +08:00
|
|
|
Value *Ret = emitMemCpyChk(Dst, Src, LenV, ObjSize, B, DL, TLI);
|
2015-04-04 05:32:06 +08:00
|
|
|
// If the function was an __stpcpy_chk, and we were able to fold it into
|
|
|
|
// a __memcpy_chk, we still need to return the correct end pointer.
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
if (Ret && Func == LibFunc_stpcpy_chk)
|
2015-04-04 05:32:06 +08:00
|
|
|
return B.CreateGEP(B.getInt8Ty(), Dst, ConstantInt::get(SizeTTy, Len - 1));
|
|
|
|
return Ret;
|
2015-01-13 01:22:43 +08:00
|
|
|
}
|
|
|
|
|
[SimplifyLibCalls] Don't confuse strcpy_chk for stpcpy_chk.
This was introduced in a faulty refactoring (r225640, mea culpa):
the tests weren't testing the return values, so, for both
__strcpy_chk and __stpcpy_chk, we would return the end of the
buffer (matching stpcpy) instead of the beginning (for strcpy).
The root cause was the prefix "__" being ignored when comparing,
which made us always pick LibFunc::stpcpy_chk.
Pass the LibFunc::Func directly to avoid this kind of error.
Also, make the testcases as explicit as possible to prevent this.
The now-useful testcases expose another, entangled, stpcpy problem,
with the further simplification. This was introduced in a
refactoring (r225640) to match the original behavior.
However, this leads to problems when successive simplifications
generate several similar instructions, none of which are removed
by the custom replaceAllUsesWith.
For instance, InstCombine (the main user) doesn't erase the
instruction in its custom RAUW. When trying to simplify say
__stpcpy_chk:
- first, an stpcpy is created (fortified simplifier),
- second, a memcpy is created (normal simplifier), but the
stpcpy call isn't removed.
- third, InstCombine later revisits the instructions,
and simplifies the first stpcpy to a memcpy. We now have
two memcpys.
llvm-svn: 227250
2015-01-28 05:52:16 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeStrpNCpyChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B,
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func) {
|
2019-06-01 06:41:36 +08:00
|
|
|
if (isFortifiedCallFoldable(CI, 3, 2)) {
|
2019-06-01 06:41:31 +08:00
|
|
|
if (Func == LibFunc_strncpy_chk)
|
|
|
|
return emitStrNCpy(CI->getArgOperand(0), CI->getArgOperand(1),
|
2019-06-01 06:41:36 +08:00
|
|
|
CI->getArgOperand(2), B, TLI);
|
2019-06-01 06:41:31 +08:00
|
|
|
else
|
|
|
|
return emitStpNCpy(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), B, TLI);
|
2015-01-13 01:22:43 +08:00
|
|
|
}
|
2019-06-01 06:41:31 +08:00
|
|
|
|
2015-01-13 01:22:43 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2019-06-01 06:41:36 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeMemCCpyChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 4, 3))
|
|
|
|
return emitMemCCpy(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), CI->getArgOperand(3), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeSNPrintfChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 3, 1, None, 2)) {
|
|
|
|
SmallVector<Value *, 8> VariadicArgs(CI->arg_begin() + 5, CI->arg_end());
|
|
|
|
return emitSNPrintf(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(4), VariadicArgs, B, TLI);
|
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeSPrintfChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 2, None, None, 1)) {
|
|
|
|
SmallVector<Value *, 8> VariadicArgs(CI->arg_begin() + 4, CI->arg_end());
|
|
|
|
return emitSPrintf(CI->getArgOperand(0), CI->getArgOperand(3), VariadicArgs,
|
|
|
|
B, TLI);
|
|
|
|
}
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeStrCatChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 2))
|
|
|
|
return emitStrCat(CI->getArgOperand(0), CI->getArgOperand(1), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeStrLCat(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 3))
|
|
|
|
return emitStrLCat(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeStrNCatChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 3))
|
|
|
|
return emitStrNCat(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeStrLCpyChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 3))
|
|
|
|
return emitStrLCpy(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(2), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeVSNPrintfChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 3, 1, None, 2))
|
|
|
|
return emitVSNPrintf(CI->getArgOperand(0), CI->getArgOperand(1),
|
|
|
|
CI->getArgOperand(4), CI->getArgOperand(5), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
Value *FortifiedLibCallSimplifier::optimizeVSPrintfChk(CallInst *CI,
|
|
|
|
IRBuilder<> &B) {
|
|
|
|
if (isFortifiedCallFoldable(CI, 2, None, None, 1))
|
|
|
|
return emitVSPrintf(CI->getArgOperand(0), CI->getArgOperand(3),
|
|
|
|
CI->getArgOperand(4), B, TLI);
|
|
|
|
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2015-01-13 01:22:43 +08:00
|
|
|
Value *FortifiedLibCallSimplifier::optimizeCall(CallInst *CI) {
|
2015-04-01 08:45:09 +08:00
|
|
|
// FIXME: We shouldn't be changing "nobuiltin" or TLI unavailable calls here.
|
|
|
|
// Some clang users checked for _chk libcall availability using:
|
|
|
|
// __has_builtin(__builtin___memcpy_chk)
|
|
|
|
// When compiling with -fno-builtin, this is always true.
|
|
|
|
// When passing -ffreestanding/-mkernel, which both imply -fno-builtin, we
|
|
|
|
// end up with fortified libcalls, which isn't acceptable in a freestanding
|
|
|
|
// environment which only provides their non-fortified counterparts.
|
|
|
|
//
|
|
|
|
// Until we change clang and/or teach external users to check for availability
|
|
|
|
// differently, disregard the "nobuiltin" attribute and TLI::has.
|
|
|
|
//
|
|
|
|
// PR23093.
|
2015-01-13 01:22:43 +08:00
|
|
|
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
LibFunc Func;
|
2015-01-13 01:22:43 +08:00
|
|
|
Function *Callee = CI->getCalledFunction();
|
2016-01-06 13:01:34 +08:00
|
|
|
|
|
|
|
SmallVector<OperandBundleDef, 2> OpBundles;
|
|
|
|
CI->getOperandBundlesAsDefs(OpBundles);
|
|
|
|
IRBuilder<> Builder(CI, /*FPMathTag=*/nullptr, OpBundles);
|
2016-09-13 20:10:14 +08:00
|
|
|
bool isCallingConvC = isCallingConvCCompatible(CI);
|
2015-01-13 01:22:43 +08:00
|
|
|
|
2016-04-28 03:04:35 +08:00
|
|
|
// First, check that this is a known library functions and that the prototype
|
|
|
|
// is correct.
|
|
|
|
if (!TLI->getLibFunc(*Callee, Func))
|
2015-01-13 01:22:43 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// We never change the calling convention.
|
|
|
|
if (!ignoreCallingConv(Func) && !isCallingConvC)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
switch (Func) {
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memcpy_chk:
|
2015-01-13 01:22:43 +08:00
|
|
|
return optimizeMemCpyChk(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memmove_chk:
|
2015-01-13 01:22:43 +08:00
|
|
|
return optimizeMemMoveChk(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_memset_chk:
|
2015-01-13 01:22:43 +08:00
|
|
|
return optimizeMemSetChk(CI, Builder);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_stpcpy_chk:
|
|
|
|
case LibFunc_strcpy_chk:
|
[SimplifyLibCalls] Don't confuse strcpy_chk for stpcpy_chk.
This was introduced in a faulty refactoring (r225640, mea culpa):
the tests weren't testing the return values, so, for both
__strcpy_chk and __stpcpy_chk, we would return the end of the
buffer (matching stpcpy) instead of the beginning (for strcpy).
The root cause was the prefix "__" being ignored when comparing,
which made us always pick LibFunc::stpcpy_chk.
Pass the LibFunc::Func directly to avoid this kind of error.
Also, make the testcases as explicit as possible to prevent this.
The now-useful testcases expose another, entangled, stpcpy problem,
with the further simplification. This was introduced in a
refactoring (r225640) to match the original behavior.
However, this leads to problems when successive simplifications
generate several similar instructions, none of which are removed
by the custom replaceAllUsesWith.
For instance, InstCombine (the main user) doesn't erase the
instruction in its custom RAUW. When trying to simplify say
__stpcpy_chk:
- first, an stpcpy is created (fortified simplifier),
- second, a memcpy is created (normal simplifier), but the
stpcpy call isn't removed.
- third, InstCombine later revisits the instructions,
and simplifies the first stpcpy to a memcpy. We now have
two memcpys.
llvm-svn: 227250
2015-01-28 05:52:16 +08:00
|
|
|
return optimizeStrpCpyChk(CI, Builder, Func);
|
[Analysis] Add LibFunc_ prefix to enums in TargetLibraryInfo. (NFC)
Summary:
The LibFunc::Func enum holds enumerators named for libc functions.
Unfortunately, there are real situations, including libc implementations, where
function names are actually macros (musl uses "#define fopen64 fopen", for
example; any other transitively visible macro would have similar effects).
Strictly speaking, a conforming C++ Standard Library should provide any such
macros as functions instead (via <cstdio>). However, there are some "library"
functions which are not part of the standard, and thus not subject to this
rule (fopen64, for example). So, in order to be both portable and consistent,
the enum should not use the bare function names.
The old enum naming used a namespace LibFunc and an enum Func, with bare
enumerators. This patch changes LibFunc to be an enum with enumerators prefixed
with "LibFFunc_". (Unfortunately, a scoped enum is not sufficient to override
macros.)
There are additional changes required in clang.
Reviewers: rsmith
Subscribers: mehdi_amini, mzolotukhin, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D28476
llvm-svn: 292848
2017-01-24 07:16:46 +08:00
|
|
|
case LibFunc_stpncpy_chk:
|
|
|
|
case LibFunc_strncpy_chk:
|
[SimplifyLibCalls] Don't confuse strcpy_chk for stpcpy_chk.
This was introduced in a faulty refactoring (r225640, mea culpa):
the tests weren't testing the return values, so, for both
__strcpy_chk and __stpcpy_chk, we would return the end of the
buffer (matching stpcpy) instead of the beginning (for strcpy).
The root cause was the prefix "__" being ignored when comparing,
which made us always pick LibFunc::stpcpy_chk.
Pass the LibFunc::Func directly to avoid this kind of error.
Also, make the testcases as explicit as possible to prevent this.
The now-useful testcases expose another, entangled, stpcpy problem,
with the further simplification. This was introduced in a
refactoring (r225640) to match the original behavior.
However, this leads to problems when successive simplifications
generate several similar instructions, none of which are removed
by the custom replaceAllUsesWith.
For instance, InstCombine (the main user) doesn't erase the
instruction in its custom RAUW. When trying to simplify say
__stpcpy_chk:
- first, an stpcpy is created (fortified simplifier),
- second, a memcpy is created (normal simplifier), but the
stpcpy call isn't removed.
- third, InstCombine later revisits the instructions,
and simplifies the first stpcpy to a memcpy. We now have
two memcpys.
llvm-svn: 227250
2015-01-28 05:52:16 +08:00
|
|
|
return optimizeStrpNCpyChk(CI, Builder, Func);
|
2019-06-01 06:41:36 +08:00
|
|
|
case LibFunc_memccpy_chk:
|
|
|
|
return optimizeMemCCpyChk(CI, Builder);
|
|
|
|
case LibFunc_snprintf_chk:
|
|
|
|
return optimizeSNPrintfChk(CI, Builder);
|
|
|
|
case LibFunc_sprintf_chk:
|
|
|
|
return optimizeSPrintfChk(CI, Builder);
|
|
|
|
case LibFunc_strcat_chk:
|
|
|
|
return optimizeStrCatChk(CI, Builder);
|
|
|
|
case LibFunc_strlcat_chk:
|
|
|
|
return optimizeStrLCat(CI, Builder);
|
|
|
|
case LibFunc_strncat_chk:
|
|
|
|
return optimizeStrNCatChk(CI, Builder);
|
|
|
|
case LibFunc_strlcpy_chk:
|
|
|
|
return optimizeStrLCpyChk(CI, Builder);
|
|
|
|
case LibFunc_vsnprintf_chk:
|
|
|
|
return optimizeVSNPrintfChk(CI, Builder);
|
|
|
|
case LibFunc_vsprintf_chk:
|
|
|
|
return optimizeVSPrintfChk(CI, Builder);
|
2015-01-13 01:22:43 +08:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2015-03-10 10:37:25 +08:00
|
|
|
FortifiedLibCallSimplifier::FortifiedLibCallSimplifier(
|
|
|
|
const TargetLibraryInfo *TLI, bool OnlyLowerUnknownSize)
|
2019-07-12 08:33:49 +08:00
|
|
|
: TLI(TLI), OnlyLowerUnknownSize(OnlyLowerUnknownSize) {}
|