[Clang] Undef attribute for global variables
Summary:
[Clang] Attribute to allow defining undef global variables
Initializing global variables is very cheap on hosted implementations. The
C semantics of zero initializing globals work very well there. It is not
necessarily cheap on freestanding implementations. Where there is no loader
available, code must be emitted near the start point to write the appropriate
values into memory.
At present, external variables can be declared in C++ and definitions provided
in assembly (or IR) to achive this effect. This patch provides an attribute in
order to remove this reason for writing assembly for performance sensitive
freestanding implementations.
A close analogue in tree is LDS memory for amdgcn, where the kernel is
responsible for initializing the memory after it starts executing on the gpu.
Uninitalized variables in LDS are observably cheaper than zero initialized.
Patch is loosely based on the cuda __shared__ and opencl __local variable
implementation which also produces undef global variables.
Reviewers: kcc, rjmccall, rsmith, glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich, jdoerfert, gregrodgers, jfb, aaron.ballman
Reviewed By: rjmccall, aaron.ballman
Subscribers: Anastasia, aaron.ballman, davidb, Quuxplusone, dexonsmith, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74361
2020-03-18 05:22:04 +08:00
|
|
|
// RUN: %clang_cc1 %s -verify -fsyntax-only
|
|
|
|
// See also attr-loader-uninitialized.cpp
|
|
|
|
|
|
|
|
int good __attribute__((loader_uninitialized));
|
|
|
|
static int local_ok __attribute__((loader_uninitialized));
|
|
|
|
int hidden_ok __attribute__((visibility("hidden"))) __attribute__((loader_uninitialized));
|
|
|
|
|
|
|
|
const int can_still_be_const __attribute__((loader_uninitialized));
|
|
|
|
|
|
|
|
extern int external_rejected __attribute__((loader_uninitialized));
|
|
|
|
// expected-error@-1 {{variable 'external_rejected' cannot be declared both 'extern' and with the 'loader_uninitialized' attribute}}
|
|
|
|
|
2020-08-20 01:11:34 +08:00
|
|
|
struct S;
|
|
|
|
extern struct S incomplete_external_rejected __attribute__((loader_uninitialized));
|
|
|
|
// expected-error@-1 {{variable 'incomplete_external_rejected' cannot be declared both 'extern' and with the 'loader_uninitialized' attribute}}
|
|
|
|
|
[Clang] Undef attribute for global variables
Summary:
[Clang] Attribute to allow defining undef global variables
Initializing global variables is very cheap on hosted implementations. The
C semantics of zero initializing globals work very well there. It is not
necessarily cheap on freestanding implementations. Where there is no loader
available, code must be emitted near the start point to write the appropriate
values into memory.
At present, external variables can be declared in C++ and definitions provided
in assembly (or IR) to achive this effect. This patch provides an attribute in
order to remove this reason for writing assembly for performance sensitive
freestanding implementations.
A close analogue in tree is LDS memory for amdgcn, where the kernel is
responsible for initializing the memory after it starts executing on the gpu.
Uninitalized variables in LDS are observably cheaper than zero initialized.
Patch is loosely based on the cuda __shared__ and opencl __local variable
implementation which also produces undef global variables.
Reviewers: kcc, rjmccall, rsmith, glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich, jdoerfert, gregrodgers, jfb, aaron.ballman
Reviewed By: rjmccall, aaron.ballman
Subscribers: Anastasia, aaron.ballman, davidb, Quuxplusone, dexonsmith, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74361
2020-03-18 05:22:04 +08:00
|
|
|
int noargs __attribute__((loader_uninitialized(0)));
|
|
|
|
// expected-error@-1 {{'loader_uninitialized' attribute takes no arguments}}
|
|
|
|
|
|
|
|
int init_rejected __attribute__((loader_uninitialized)) = 42;
|
|
|
|
// expected-error@-1 {{variable with 'loader_uninitialized' attribute cannot have an initializer}}
|
|
|
|
|
|
|
|
int declaration_then_uninit_ok;
|
|
|
|
int declaration_then_uninit_ok __attribute__((loader_uninitialized));
|
|
|
|
|
|
|
|
int definition_then_uninit_rejected = 0;
|
|
|
|
int definition_then_uninit_rejected __attribute__((loader_uninitialized));
|
|
|
|
// expected-error@-1 {{redeclaration cannot add 'loader_uninitialized' attribute}}
|
|
|
|
// expected-note@-3 {{previous definition is here}}
|
|
|
|
|
|
|
|
int tentative_repeated_ok __attribute__((loader_uninitialized));
|
|
|
|
int tentative_repeated_ok __attribute__((loader_uninitialized));
|
|
|
|
|
|
|
|
__private_extern__ int private_extern_can_be_initialised = 10;
|
|
|
|
__private_extern__ int therefore_uninit_private_extern_ok __attribute__((loader_uninitialized));
|
|
|
|
|
|
|
|
__private_extern__ int initialized_private_extern_rejected __attribute__((loader_uninitialized)) = 5;
|
|
|
|
// expected-error@-1 {{variable with 'loader_uninitialized' attribute cannot have an initializer}}
|
|
|
|
|
|
|
|
extern __attribute__((visibility("hidden"))) int extern_hidden __attribute__((loader_uninitialized));
|
|
|
|
// expected-error@-1 {{variable 'extern_hidden' cannot be declared both 'extern' and with the 'loader_uninitialized' attribute}}
|
2020-08-20 01:11:34 +08:00
|
|
|
|
|
|
|
struct Incomplete;
|
|
|
|
struct Incomplete incomplete __attribute__((loader_uninitialized));
|
|
|
|
// expected-error@-1 {{variable has incomplete type 'struct Incomplete'}}
|
|
|
|
// expected-note@-3 {{forward declaration of 'struct Incomplete'}}
|