maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/clang-tools-extra/test/clang-tidy/readability-simplify-bool-e...

96 lines
2.8 KiB
C++
Raw Normal View History

[clang-tidy] Enhance clang-tidy readability-simplify-boolean-expr check... Enhance clang-tidy readability-simplify-boolean-expr check to handle chained conditional assignment and chained conditional return. Based on feedback from applying this tool to the clang/LLVM codebase, this changeset improves the readability-simplify-boolean-expr check so that conditional assignment or return statements at the end of a chain of if/else if statements are left unchanged unless a configuration option is supplied. http://reviews.llvm.org/D8996 Patch by Richard Thomson! llvm-svn: 237541
2015-05-17 20:31:12 +08:00
// RUN: $(dirname %s)/check_clang_tidy.sh %s readability-simplify-boolean-expr %t -config="{CheckOptions: [{key: "readability-simplify-boolean-expr.ChainedConditionalReturn", value: 1}]}" --
// REQUIRES: shell
bool chained_conditional_compound_return(int i) {
if (i < 0) {
return true;
} else if (i < 10) {
return false;
} else if (i > 20) {
return true;
} else {
return false;
}
// CHECK-MESSAGES: :[[@LINE-4]]:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
// CHECK-FIXES: {{^}} } else if (i < 10) {{{$}}
// CHECK-FIXES-NEXT: {{^}} return false;{{$}}
// CHECK-FIXES-NEXT: {{^}} } else return i > 20;{{$}}
}
bool chained_conditional_return(int i) {
if (i < 0)
return true;
else if (i < 10)
return false;
else if (i > 20)
return true;
else
return false;
// CHECK-MESSAGES: :[[@LINE-3]]:12: warning: {{.*}} in conditional return statement
// CHECK-FIXES: {{^}} else if (i < 10)
// CHECK-FIXES-NEXT: {{^}} return false;
// CHECK-FIXES-NEXT: {{^}} else return i > 20;
}
[clang-tidy] Enhance clang-tidy readability-simplify-boolean-expr... Enhance clang-tidy readability-simplify-boolean-expr to handle 'if (e) return true; return false;' and improve replacement expressions. This changeset extends the simplify boolean expression check in clang-tidy to simplify if (e) return true; return false; to return e; (note the lack of an else clause on the if statement.) By default, chained conditional assignment is left unchanged, unless a configuration parameter is set to non-zero to override this behavior. It also improves the handling of replacement expressions to apply static_cast<bool>(expr) when expr is not of type bool. http://reviews.llvm.org/D9810 Patch by Richard Thomson! llvm-svn: 241155
2015-07-01 20:39:40 +08:00
bool chained_simple_if_return(int i) {
if (i < 5)
return true;
if (i > 10)
return true;
return false;
}
// CHECK-MESSAGES: :[[@LINE-3]]:12: warning: {{.*}} in conditional return
// CHECK-FIXES: {{^}}bool chained_simple_if_return(int i) {{{$}}
// CHECK-FIXES: {{^}} if (i < 5){{$}}
// CHECK-FIXES: {{^ return true;$}}
// CHECK-FIXES: {{^ return i > 10;$}}
// CHECK-FIXES: {{^}$}}
bool chained_simple_if_return_negated(int i) {
if (i < 5)
return false;
if (i > 10)
return false;
return true;
}
// CHECK-MESSAGES: :[[@LINE-3]]:12: warning: {{.*}} in conditional return
// CHECK-FIXES: {{^}}bool chained_simple_if_return_negated(int i) {{{$}}
// CHECK-FIXES: {{^}} if (i < 5){{$}}
// CHECK-FIXES: {{^ return false;$}}
// CHECK-FIXES: {{^ return i <= 10;$}}
// CHECK-FIXES: {{^}$}}
bool complex_chained_if_return_return(int i) {
if (i < 5) {
return true;
}
if (i > 10) {
return true;
}
return false;
}
// CHECK-MESSAGES: :[[@LINE-4]]:12: warning: {{.*}} in conditional return
// CHECK-FIXES: {{^}}bool complex_chained_if_return_return(int i) {{{$}}
// CHECK-FIXES: {{^}} if (i < 5) {{{$}}
// CHECK-FIXES: {{^}} return true;{{$}}
// CHECK-FIXES: {{^}} }{{$}}
// CHECK-FIXES: {{^ return i > 10;$}}
// CHECK-FIXES: {{^}$}}
bool complex_chained_if_return_return_negated(int i) {
if (i < 5) {
return false;
}
if (i > 10) {
return false;
}
return true;
}
// CHECK-MESSAGES: :[[@LINE-4]]:12: warning: {{.*}} in conditional return
// CHECK-FIXES: {{^}}bool complex_chained_if_return_return_negated(int i) {{{$}}
// CHECK-FIXES: {{^}} if (i < 5) {{{$}}
// CHECK-FIXES: {{^}} return false;{{$}}
// CHECK-FIXES: {{^}} }{{$}}
// CHECK-FIXES: {{^ return i <= 10;$}}
// CHECK-FIXES: {{^}$}}