2012-11-13 08:08:49 +08:00
|
|
|
//===- Reassociate.cpp - Reassociate binary expressions -------------------===//
|
2005-04-22 07:48:37 +08:00
|
|
|
//
|
2003-10-21 03:43:21 +08:00
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 04:36:04 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2005-04-22 07:48:37 +08:00
|
|
|
//
|
2003-10-21 03:43:21 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2002-05-09 06:19:27 +08:00
|
|
|
//
|
|
|
|
// This pass reassociates commutative expressions in an order that is designed
|
2010-01-01 08:04:26 +08:00
|
|
|
// to promote better constant propagation, GCSE, LICM, PRE, etc.
|
2002-05-09 06:19:27 +08:00
|
|
|
//
|
|
|
|
// For example: 4 + (x + 5) -> x + (4 + 5)
|
|
|
|
//
|
|
|
|
// In the implementation of this algorithm, constants are assigned rank = 0,
|
|
|
|
// function arguments are rank = 1, and other values are assigned ranks
|
|
|
|
// corresponding to the reverse post order traversal of current function
|
|
|
|
// (starting at 2), which effectively gives values in deep loops higher rank
|
|
|
|
// than values not in loops.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
#include "llvm/Transforms/Scalar/Reassociate.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/ADT/APFloat.h"
|
|
|
|
#include "llvm/ADT/APInt.h"
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm/ADT/DenseMap.h"
|
|
|
|
#include "llvm/ADT/PostOrderIterator.h"
|
|
|
|
#include "llvm/ADT/SetVector.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
2017-12-13 03:18:02 +08:00
|
|
|
#include "llvm/ADT/SmallSet.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/ADT/SmallVector.h"
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm/ADT/Statistic.h"
|
2015-09-10 18:22:12 +08:00
|
|
|
#include "llvm/Analysis/GlobalsModRef.h"
|
2018-06-05 05:23:21 +08:00
|
|
|
#include "llvm/Transforms/Utils/Local.h"
|
2015-08-07 02:44:34 +08:00
|
|
|
#include "llvm/Analysis/ValueTracking.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/IR/Argument.h"
|
|
|
|
#include "llvm/IR/BasicBlock.h"
|
2014-03-04 19:45:46 +08:00
|
|
|
#include "llvm/IR/CFG.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/IR/Constant.h"
|
2013-01-02 19:36:10 +08:00
|
|
|
#include "llvm/IR/Constants.h"
|
|
|
|
#include "llvm/IR/Function.h"
|
|
|
|
#include "llvm/IR/IRBuilder.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/IR/InstrTypes.h"
|
|
|
|
#include "llvm/IR/Instruction.h"
|
2013-01-02 19:36:10 +08:00
|
|
|
#include "llvm/IR/Instructions.h"
|
[DebugInfo] Invalidate debug info in ReassociatePass::RewriteExprTree
Summary:
When Reassociate is rewriting an expression tree it may
reuse old binary expression nodes, for new expressions.
Whenever an expression node is reused, but with a non-trivial
change in the result, we need to invalidate any debug info
that is associated with the node.
If for example rewriting
x = mul a, b
y = mul c, x
into
x = mul c, b
y = mul a, x
we still get the same result for 'y', but 'x' is a new expression.
All debug info referring to 'x' must be invalidated (marked as
optimized out) since we no longer calculate the expected value.
As a side-effect this patch avoid (at least some) problems where
reassociate could end up creating IR with debug-use before def.
Earlier the dbg.value nodes where left untouched in the IR, while
the reused binary nodes where sinked to just before the root node
of the rewritten expression tree. See PR27273 for more info about
such problems.
Reviewers: dblaikie, aprantl, dexonsmith
Reviewed By: aprantl
Subscribers: JDevlieghere, llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D45975
llvm-svn: 330804
2018-04-25 17:23:56 +08:00
|
|
|
#include "llvm/IR/IntrinsicInst.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/IR/Operator.h"
|
|
|
|
#include "llvm/IR/PassManager.h"
|
2017-06-22 00:07:09 +08:00
|
|
|
#include "llvm/IR/PatternMatch.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/IR/Type.h"
|
|
|
|
#include "llvm/IR/User.h"
|
|
|
|
#include "llvm/IR/Value.h"
|
2014-03-04 19:17:44 +08:00
|
|
|
#include "llvm/IR/ValueHandle.h"
|
2002-05-09 06:19:27 +08:00
|
|
|
#include "llvm/Pass.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/Support/Casting.h"
|
2004-09-02 06:55:40 +08:00
|
|
|
#include "llvm/Support/Debug.h"
|
2017-10-19 05:46:47 +08:00
|
|
|
#include "llvm/Support/ErrorHandling.h"
|
2009-08-23 12:37:46 +08:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2016-04-27 07:39:29 +08:00
|
|
|
#include "llvm/Transforms/Scalar.h"
|
2005-05-08 05:59:39 +08:00
|
|
|
#include <algorithm>
|
2017-10-19 05:46:47 +08:00
|
|
|
#include <cassert>
|
|
|
|
#include <utility>
|
|
|
|
|
2004-01-09 14:02:20 +08:00
|
|
|
using namespace llvm;
|
2016-04-27 07:39:29 +08:00
|
|
|
using namespace reassociate;
|
2018-10-23 05:37:02 +08:00
|
|
|
using namespace PatternMatch;
|
2003-11-12 06:41:34 +08:00
|
|
|
|
2014-04-22 10:55:47 +08:00
|
|
|
#define DEBUG_TYPE "reassociate"
|
|
|
|
|
2006-12-20 05:40:18 +08:00
|
|
|
STATISTIC(NumChanged, "Number of insts reassociated");
|
|
|
|
STATISTIC(NumAnnihil, "Number of expr tree annihilated");
|
|
|
|
STATISTIC(NumFactor , "Number of multiplies factored");
|
2002-10-02 06:38:41 +08:00
|
|
|
|
2008-11-22 05:00:20 +08:00
|
|
|
#ifndef NDEBUG
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Print out the expression identified in the Ops list.
|
2010-01-01 02:40:32 +08:00
|
|
|
static void PrintOps(Instruction *I, const SmallVectorImpl<ValueEntry> &Ops) {
|
2015-12-15 01:24:23 +08:00
|
|
|
Module *M = I->getModule();
|
2010-01-05 09:27:24 +08:00
|
|
|
dbgs() << Instruction::getOpcodeName(I->getOpcode()) << " "
|
2009-12-31 15:17:37 +08:00
|
|
|
<< *Ops[0].Op->getType() << '\t';
|
2008-08-19 12:45:19 +08:00
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
2010-01-05 09:27:24 +08:00
|
|
|
dbgs() << "[ ";
|
2014-01-09 10:29:41 +08:00
|
|
|
Ops[i].Op->printAsOperand(dbgs(), false, M);
|
2010-01-05 09:27:24 +08:00
|
|
|
dbgs() << ", #" << Ops[i].Rank << "] ";
|
2008-08-19 12:45:19 +08:00
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
2008-11-22 04:00:59 +08:00
|
|
|
#endif
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
/// Utility class representing a non-constant Xor-operand. We classify
|
|
|
|
/// non-constant Xor-Operands into two categories:
|
|
|
|
/// C1) The operand is in the form "X & C", where C is a constant and C != ~0
|
|
|
|
/// C2)
|
|
|
|
/// C2.1) The operand is in the form of "X | C", where C is a non-zero
|
|
|
|
/// constant.
|
|
|
|
/// C2.2) Any operand E which doesn't fall into C1 and C2.1, we view this
|
|
|
|
/// operand as "E | 0"
|
|
|
|
class llvm::reassociate::XorOpnd {
|
|
|
|
public:
|
|
|
|
XorOpnd(Value *V);
|
|
|
|
|
|
|
|
bool isInvalid() const { return SymbolicPart == nullptr; }
|
|
|
|
bool isOrExpr() const { return isOr; }
|
|
|
|
Value *getValue() const { return OrigVal; }
|
|
|
|
Value *getSymbolicPart() const { return SymbolicPart; }
|
|
|
|
unsigned getSymbolicRank() const { return SymbolicRank; }
|
|
|
|
const APInt &getConstPart() const { return ConstPart; }
|
|
|
|
|
|
|
|
void Invalidate() { SymbolicPart = OrigVal = nullptr; }
|
|
|
|
void setSymbolicRank(unsigned R) { SymbolicRank = R; }
|
|
|
|
|
|
|
|
private:
|
|
|
|
Value *OrigVal;
|
|
|
|
Value *SymbolicPart;
|
|
|
|
APInt ConstPart;
|
|
|
|
unsigned SymbolicRank;
|
|
|
|
bool isOr;
|
|
|
|
};
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2013-03-30 10:15:01 +08:00
|
|
|
XorOpnd::XorOpnd(Value *V) {
|
2013-04-02 02:13:05 +08:00
|
|
|
assert(!isa<ConstantInt>(V) && "No ConstantInt");
|
2013-03-30 10:15:01 +08:00
|
|
|
OrigVal = V;
|
|
|
|
Instruction *I = dyn_cast<Instruction>(V);
|
|
|
|
SymbolicRank = 0;
|
|
|
|
|
|
|
|
if (I && (I->getOpcode() == Instruction::Or ||
|
|
|
|
I->getOpcode() == Instruction::And)) {
|
|
|
|
Value *V0 = I->getOperand(0);
|
|
|
|
Value *V1 = I->getOperand(1);
|
2017-06-22 00:07:09 +08:00
|
|
|
const APInt *C;
|
2018-10-23 05:37:02 +08:00
|
|
|
if (match(V0, m_APInt(C)))
|
2013-03-30 10:15:01 +08:00
|
|
|
std::swap(V0, V1);
|
|
|
|
|
2018-10-23 05:37:02 +08:00
|
|
|
if (match(V1, m_APInt(C))) {
|
2017-06-22 00:07:09 +08:00
|
|
|
ConstPart = *C;
|
2013-03-30 10:15:01 +08:00
|
|
|
SymbolicPart = V0;
|
|
|
|
isOr = (I->getOpcode() == Instruction::Or);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// view the operand as "V | 0"
|
|
|
|
SymbolicPart = V;
|
2017-06-22 00:07:09 +08:00
|
|
|
ConstPart = APInt::getNullValue(V->getType()->getScalarSizeInBits());
|
2013-03-30 10:15:01 +08:00
|
|
|
isOr = true;
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Return true if V is an instruction of the specified opcode and if it
|
|
|
|
/// only has one use.
|
2012-05-25 20:03:02 +08:00
|
|
|
static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) {
|
2017-11-15 07:03:56 +08:00
|
|
|
auto *I = dyn_cast<Instruction>(V);
|
|
|
|
if (I && I->hasOneUse() && I->getOpcode() == Opcode)
|
|
|
|
if (!isa<FPMathOperator>(I) || I->isFast())
|
|
|
|
return cast<BinaryOperator>(I);
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2012-05-25 20:03:02 +08:00
|
|
|
}
|
|
|
|
|
2014-08-14 23:23:01 +08:00
|
|
|
static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode1,
|
|
|
|
unsigned Opcode2) {
|
2017-11-15 07:03:56 +08:00
|
|
|
auto *I = dyn_cast<Instruction>(V);
|
|
|
|
if (I && I->hasOneUse() &&
|
|
|
|
(I->getOpcode() == Opcode1 || I->getOpcode() == Opcode2))
|
|
|
|
if (!isa<FPMathOperator>(I) || I->isFast())
|
|
|
|
return cast<BinaryOperator>(I);
|
2014-08-14 23:23:01 +08:00
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
2016-11-02 16:55:19 +08:00
|
|
|
void ReassociatePass::BuildRankMap(Function &F,
|
|
|
|
ReversePostOrderTraversal<Function*> &RPOT) {
|
2017-08-07 09:57:21 +08:00
|
|
|
unsigned Rank = 2;
|
2003-08-14 00:16:26 +08:00
|
|
|
|
2014-11-14 23:01:38 +08:00
|
|
|
// Assign distinct ranks to function arguments.
|
2017-08-07 09:57:21 +08:00
|
|
|
for (auto &Arg : F.args()) {
|
|
|
|
ValueRankMap[&Arg] = ++Rank;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Calculated Rank[" << Arg.getName() << "] = " << Rank
|
|
|
|
<< "\n");
|
2014-11-14 23:01:38 +08:00
|
|
|
}
|
2003-08-14 00:16:26 +08:00
|
|
|
|
2016-11-02 16:55:19 +08:00
|
|
|
// Traverse basic blocks in ReversePostOrder
|
2016-06-26 20:28:59 +08:00
|
|
|
for (BasicBlock *BB : RPOT) {
|
2017-08-07 09:57:21 +08:00
|
|
|
unsigned BBRank = RankMap[BB] = ++Rank << 16;
|
2005-05-09 04:57:04 +08:00
|
|
|
|
|
|
|
// Walk the basic block, adding precomputed ranks for any instructions that
|
|
|
|
// we cannot move. This ensures that the ranks for these instructions are
|
|
|
|
// all different in the block.
|
2016-06-26 20:28:59 +08:00
|
|
|
for (Instruction &I : *BB)
|
|
|
|
if (mayBeMemoryDependent(I))
|
|
|
|
ValueRankMap[&I] = ++BBRank;
|
2005-05-09 04:57:04 +08:00
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
unsigned ReassociatePass::getRank(Value *V) {
|
2005-05-07 12:08:02 +08:00
|
|
|
Instruction *I = dyn_cast<Instruction>(V);
|
2014-04-25 13:29:35 +08:00
|
|
|
if (!I) {
|
2010-01-01 08:01:34 +08:00
|
|
|
if (isa<Argument>(V)) return ValueRankMap[V]; // Function argument.
|
|
|
|
return 0; // Otherwise it's a global or constant, rank 0.
|
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2010-01-01 08:01:34 +08:00
|
|
|
if (unsigned Rank = ValueRankMap[I])
|
|
|
|
return Rank; // Rank already known?
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2005-05-07 12:08:02 +08:00
|
|
|
// If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that
|
|
|
|
// we can reassociate expressions for code motion! Since we do not recurse
|
|
|
|
// for PHI nodes, we cannot have infinite recursion here, because there
|
|
|
|
// cannot be loops in the value graph that do not go through PHI nodes.
|
|
|
|
unsigned Rank = 0, MaxRank = RankMap[I->getParent()];
|
2018-04-20 01:56:36 +08:00
|
|
|
for (unsigned i = 0, e = I->getNumOperands(); i != e && Rank != MaxRank; ++i)
|
2005-05-07 12:08:02 +08:00
|
|
|
Rank = std::max(Rank, getRank(I->getOperand(i)));
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2018-10-23 23:55:06 +08:00
|
|
|
// If this is a 'not' or 'neg' instruction, do not count it for rank. This
|
2005-05-08 08:08:33 +08:00
|
|
|
// assures us that X and ~X will have the same rank.
|
2018-10-23 23:55:06 +08:00
|
|
|
if (!match(I, m_Not(m_Value())) && !match(I, m_Neg(m_Value())) &&
|
2018-10-24 22:45:18 +08:00
|
|
|
!match(I, m_FNeg(m_Value())))
|
2005-05-08 08:08:33 +08:00
|
|
|
++Rank;
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Calculated Rank[" << V->getName() << "] = " << Rank
|
|
|
|
<< "\n");
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2010-01-01 08:01:34 +08:00
|
|
|
return ValueRankMap[I] = Rank;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
2014-11-17 23:52:51 +08:00
|
|
|
// Canonicalize constants to RHS. Otherwise, sort the operands by rank.
|
2016-04-27 07:39:29 +08:00
|
|
|
void ReassociatePass::canonicalizeOperands(Instruction *I) {
|
2014-11-15 01:05:59 +08:00
|
|
|
assert(isa<BinaryOperator>(I) && "Expected binary operator.");
|
|
|
|
assert(I->isCommutative() && "Expected commutative operator.");
|
|
|
|
|
|
|
|
Value *LHS = I->getOperand(0);
|
|
|
|
Value *RHS = I->getOperand(1);
|
2017-08-07 09:49:09 +08:00
|
|
|
if (LHS == RHS || isa<Constant>(RHS))
|
2014-11-17 23:52:51 +08:00
|
|
|
return;
|
2017-08-07 09:49:09 +08:00
|
|
|
if (isa<Constant>(LHS) || getRank(RHS) < getRank(LHS))
|
2014-11-15 01:05:59 +08:00
|
|
|
cast<BinaryOperator>(I)->swapOperands();
|
|
|
|
}
|
|
|
|
|
2014-08-14 23:23:01 +08:00
|
|
|
static BinaryOperator *CreateAdd(Value *S1, Value *S2, const Twine &Name,
|
|
|
|
Instruction *InsertBefore, Value *FlagsOp) {
|
2015-03-14 04:53:01 +08:00
|
|
|
if (S1->getType()->isIntOrIntVectorTy())
|
2014-08-14 23:23:01 +08:00
|
|
|
return BinaryOperator::CreateAdd(S1, S2, Name, InsertBefore);
|
|
|
|
else {
|
|
|
|
BinaryOperator *Res =
|
|
|
|
BinaryOperator::CreateFAdd(S1, S2, Name, InsertBefore);
|
|
|
|
Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
|
|
|
|
return Res;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static BinaryOperator *CreateMul(Value *S1, Value *S2, const Twine &Name,
|
|
|
|
Instruction *InsertBefore, Value *FlagsOp) {
|
2015-03-14 04:53:01 +08:00
|
|
|
if (S1->getType()->isIntOrIntVectorTy())
|
2014-08-14 23:23:01 +08:00
|
|
|
return BinaryOperator::CreateMul(S1, S2, Name, InsertBefore);
|
|
|
|
else {
|
|
|
|
BinaryOperator *Res =
|
|
|
|
BinaryOperator::CreateFMul(S1, S2, Name, InsertBefore);
|
|
|
|
Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
|
|
|
|
return Res;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static BinaryOperator *CreateNeg(Value *S1, const Twine &Name,
|
|
|
|
Instruction *InsertBefore, Value *FlagsOp) {
|
2015-03-14 04:53:01 +08:00
|
|
|
if (S1->getType()->isIntOrIntVectorTy())
|
2014-08-14 23:23:01 +08:00
|
|
|
return BinaryOperator::CreateNeg(S1, Name, InsertBefore);
|
|
|
|
else {
|
|
|
|
BinaryOperator *Res = BinaryOperator::CreateFNeg(S1, Name, InsertBefore);
|
|
|
|
Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
|
|
|
|
return Res;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Replace 0-X with X*-1.
|
2012-06-09 04:15:33 +08:00
|
|
|
static BinaryOperator *LowerNegateToMultiply(Instruction *Neg) {
|
2014-08-14 23:23:01 +08:00
|
|
|
Type *Ty = Neg->getType();
|
2015-03-14 04:53:01 +08:00
|
|
|
Constant *NegOne = Ty->isIntOrIntVectorTy() ?
|
|
|
|
ConstantInt::getAllOnesValue(Ty) : ConstantFP::get(Ty, -1.0);
|
2005-05-09 05:28:52 +08:00
|
|
|
|
2014-08-14 23:23:01 +08:00
|
|
|
BinaryOperator *Res = CreateMul(Neg->getOperand(1), NegOne, "", Neg, Neg);
|
|
|
|
Neg->setOperand(1, Constant::getNullValue(Ty)); // Drop use of op.
|
2007-02-11 09:23:03 +08:00
|
|
|
Res->takeName(Neg);
|
2005-05-09 05:28:52 +08:00
|
|
|
Neg->replaceAllUsesWith(Res);
|
2011-04-29 06:48:14 +08:00
|
|
|
Res->setDebugLoc(Neg->getDebugLoc());
|
2005-05-09 05:28:52 +08:00
|
|
|
return Res;
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Returns k such that lambda(2^Bitwidth) = 2^k, where lambda is the Carmichael
|
|
|
|
/// function. This means that x^(2^k) === 1 mod 2^Bitwidth for
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
/// every odd x, i.e. x^(2^k) = 1 for every odd x in Bitwidth-bit arithmetic.
|
|
|
|
/// Note that 0 <= k < Bitwidth, and if Bitwidth > 3 then x^(2^k) = 0 for every
|
|
|
|
/// even x in Bitwidth-bit arithmetic.
|
|
|
|
static unsigned CarmichaelShift(unsigned Bitwidth) {
|
|
|
|
if (Bitwidth < 3)
|
|
|
|
return Bitwidth - 1;
|
|
|
|
return Bitwidth - 2;
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Add the extra weight 'RHS' to the existing weight 'LHS',
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
/// reducing the combined weight using any special properties of the operation.
|
|
|
|
/// The existing weight LHS represents the computation X op X op ... op X where
|
|
|
|
/// X occurs LHS times. The combined weight represents X op X op ... op X with
|
|
|
|
/// X occurring LHS + RHS times. If op is "Xor" for example then the combined
|
|
|
|
/// operation is equivalent to X if LHS + RHS is odd, or 0 if LHS + RHS is even;
|
|
|
|
/// the routine returns 1 in LHS in the first case, and 0 in LHS in the second.
|
|
|
|
static void IncorporateWeight(APInt &LHS, const APInt &RHS, unsigned Opcode) {
|
|
|
|
// If we were working with infinite precision arithmetic then the combined
|
|
|
|
// weight would be LHS + RHS. But we are using finite precision arithmetic,
|
|
|
|
// and the APInt sum LHS + RHS may not be correct if it wraps (it is correct
|
|
|
|
// for nilpotent operations and addition, but not for idempotent operations
|
|
|
|
// and multiplication), so it is important to correctly reduce the combined
|
|
|
|
// weight back into range if wrapping would be wrong.
|
|
|
|
|
|
|
|
// If RHS is zero then the weight didn't change.
|
|
|
|
if (RHS.isMinValue())
|
|
|
|
return;
|
|
|
|
// If LHS is zero then the combined weight is RHS.
|
|
|
|
if (LHS.isMinValue()) {
|
|
|
|
LHS = RHS;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
// From this point on we know that neither LHS nor RHS is zero.
|
|
|
|
|
|
|
|
if (Instruction::isIdempotent(Opcode)) {
|
|
|
|
// Idempotent means X op X === X, so any non-zero weight is equivalent to a
|
|
|
|
// weight of 1. Keeping weights at zero or one also means that wrapping is
|
|
|
|
// not a problem.
|
|
|
|
assert(LHS == 1 && RHS == 1 && "Weights not reduced!");
|
|
|
|
return; // Return a weight of 1.
|
|
|
|
}
|
|
|
|
if (Instruction::isNilpotent(Opcode)) {
|
|
|
|
// Nilpotent means X op X === 0, so reduce weights modulo 2.
|
|
|
|
assert(LHS == 1 && RHS == 1 && "Weights not reduced!");
|
|
|
|
LHS = 0; // 1 + 1 === 0 modulo 2.
|
|
|
|
return;
|
|
|
|
}
|
2014-08-14 23:23:01 +08:00
|
|
|
if (Opcode == Instruction::Add || Opcode == Instruction::FAdd) {
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
// TODO: Reduce the weight by exploiting nsw/nuw?
|
|
|
|
LHS += RHS;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2014-08-14 23:23:01 +08:00
|
|
|
assert((Opcode == Instruction::Mul || Opcode == Instruction::FMul) &&
|
|
|
|
"Unknown associative operation!");
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
unsigned Bitwidth = LHS.getBitWidth();
|
|
|
|
// If CM is the Carmichael number then a weight W satisfying W >= CM+Bitwidth
|
|
|
|
// can be replaced with W-CM. That's because x^W=x^(W-CM) for every Bitwidth
|
|
|
|
// bit number x, since either x is odd in which case x^CM = 1, or x is even in
|
|
|
|
// which case both x^W and x^(W - CM) are zero. By subtracting off multiples
|
|
|
|
// of CM like this weights can always be reduced to the range [0, CM+Bitwidth)
|
|
|
|
// which by a happy accident means that they can always be represented using
|
|
|
|
// Bitwidth bits.
|
|
|
|
// TODO: Reduce the weight by exploiting nsw/nuw? (Could do much better than
|
|
|
|
// the Carmichael number).
|
|
|
|
if (Bitwidth > 3) {
|
|
|
|
/// CM - The value of Carmichael's lambda function.
|
|
|
|
APInt CM = APInt::getOneBitSet(Bitwidth, CarmichaelShift(Bitwidth));
|
|
|
|
// Any weight W >= Threshold can be replaced with W - CM.
|
|
|
|
APInt Threshold = CM + Bitwidth;
|
|
|
|
assert(LHS.ult(Threshold) && RHS.ult(Threshold) && "Weights not reduced!");
|
|
|
|
// For Bitwidth 4 or more the following sum does not overflow.
|
|
|
|
LHS += RHS;
|
|
|
|
while (LHS.uge(Threshold))
|
|
|
|
LHS -= CM;
|
|
|
|
} else {
|
|
|
|
// To avoid problems with overflow do everything the same as above but using
|
|
|
|
// a larger type.
|
|
|
|
unsigned CM = 1U << CarmichaelShift(Bitwidth);
|
|
|
|
unsigned Threshold = CM + Bitwidth;
|
|
|
|
assert(LHS.getZExtValue() < Threshold && RHS.getZExtValue() < Threshold &&
|
|
|
|
"Weights not reduced!");
|
|
|
|
unsigned Total = LHS.getZExtValue() + RHS.getZExtValue();
|
|
|
|
while (Total >= Threshold)
|
|
|
|
Total -= CM;
|
|
|
|
LHS = Total;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-19 05:46:47 +08:00
|
|
|
using RepeatedValue = std::pair<Value*, APInt>;
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Given an associative binary expression, return the leaf
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
/// nodes in Ops along with their weights (how many times the leaf occurs). The
|
|
|
|
/// original expression is the same as
|
|
|
|
/// (Ops[0].first op Ops[0].first op ... Ops[0].first) <- Ops[0].second times
|
2012-07-24 18:51:42 +08:00
|
|
|
/// op
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
/// (Ops[1].first op Ops[1].first op ... Ops[1].first) <- Ops[1].second times
|
|
|
|
/// op
|
|
|
|
/// ...
|
|
|
|
/// op
|
|
|
|
/// (Ops[N].first op Ops[N].first op ... Ops[N].first) <- Ops[N].second times
|
|
|
|
///
|
2012-11-15 17:58:38 +08:00
|
|
|
/// Note that the values Ops[0].first, ..., Ops[N].first are all distinct.
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
///
|
|
|
|
/// This routine may modify the function, in which case it returns 'true'. The
|
|
|
|
/// changes it makes may well be destructive, changing the value computed by 'I'
|
|
|
|
/// to something completely different. Thus if the routine returns 'true' then
|
|
|
|
/// you MUST either replace I with a new expression computed from the Ops array,
|
|
|
|
/// or use RewriteExprTree to put the values back in.
|
2012-05-25 20:03:02 +08:00
|
|
|
///
|
|
|
|
/// A leaf node is either not a binary operation of the same kind as the root
|
|
|
|
/// node 'I' (i.e. is not a binary operator at all, or is, but with a different
|
|
|
|
/// opcode), or is the same kind of binary operator but has a use which either
|
|
|
|
/// does not belong to the expression, or does belong to the expression but is
|
|
|
|
/// a leaf node. Every leaf node has at least one use that is a non-leaf node
|
|
|
|
/// of the expression, while for non-leaf nodes (except for the root 'I') every
|
|
|
|
/// use is a non-leaf node of the expression.
|
|
|
|
///
|
|
|
|
/// For example:
|
|
|
|
/// expression graph node names
|
|
|
|
///
|
|
|
|
/// + | I
|
|
|
|
/// / \ |
|
|
|
|
/// + + | A, B
|
|
|
|
/// / \ / \ |
|
|
|
|
/// * + * | C, D, E
|
|
|
|
/// / \ / \ / \ |
|
|
|
|
/// + * | F, G
|
|
|
|
///
|
|
|
|
/// The leaf nodes are C, E, F and G. The Ops array will contain (maybe not in
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
/// that order) (C, 1), (E, 1), (F, 2), (G, 2).
|
2012-05-25 20:03:02 +08:00
|
|
|
///
|
|
|
|
/// The expression is maximal: if some instruction is a binary operator of the
|
|
|
|
/// same kind as 'I', and all of its uses are non-leaf nodes of the expression,
|
|
|
|
/// then the instruction also belongs to the expression, is not a leaf node of
|
|
|
|
/// it, and its operands also belong to the expression (but may be leaf nodes).
|
2005-05-08 05:59:39 +08:00
|
|
|
///
|
2012-05-25 20:03:02 +08:00
|
|
|
/// NOTE: This routine will set operands of non-leaf non-root nodes to undef in
|
|
|
|
/// order to ensure that every non-root node in the expression has *exactly one*
|
|
|
|
/// use by a non-leaf node of the expression. This destruction means that the
|
2012-05-27 00:42:52 +08:00
|
|
|
/// caller MUST either replace 'I' with a new expression or use something like
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
/// RewriteExprTree to put the values back in if the routine indicates that it
|
|
|
|
/// made a change by returning 'true'.
|
2006-03-15 00:04:29 +08:00
|
|
|
///
|
2012-05-25 20:03:02 +08:00
|
|
|
/// In the above example either the right operand of A or the left operand of B
|
|
|
|
/// will be replaced by undef. If it is B's operand then this gives:
|
|
|
|
///
|
|
|
|
/// + | I
|
|
|
|
/// / \ |
|
|
|
|
/// + + | A, B - operand of B replaced with undef
|
|
|
|
/// / \ \ |
|
|
|
|
/// * + * | C, D, E
|
|
|
|
/// / \ / \ / \ |
|
|
|
|
/// + * | F, G
|
|
|
|
///
|
2012-05-27 00:42:52 +08:00
|
|
|
/// Note that such undef operands can only be reached by passing through 'I'.
|
|
|
|
/// For example, if you visit operands recursively starting from a leaf node
|
|
|
|
/// then you will never see such an undef operand unless you get back to 'I',
|
2012-05-25 20:03:02 +08:00
|
|
|
/// which requires passing through a phi node.
|
|
|
|
///
|
|
|
|
/// Note that this routine may also mutate binary operators of the wrong type
|
|
|
|
/// that have all uses inside the expression (i.e. only used by non-leaf nodes
|
|
|
|
/// of the expression) if it can turn them into binary operators of the right
|
|
|
|
/// type and thus make the expression bigger.
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
static bool LinearizeExprTree(BinaryOperator *I,
|
|
|
|
SmallVectorImpl<RepeatedValue> &Ops) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "LINEARIZE: " << *I << '\n');
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
unsigned Bitwidth = I->getType()->getScalarType()->getPrimitiveSizeInBits();
|
|
|
|
unsigned Opcode = I->getOpcode();
|
2014-08-14 23:23:01 +08:00
|
|
|
assert(I->isAssociative() && I->isCommutative() &&
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
"Expected an associative and commutative operation!");
|
2012-05-25 20:03:02 +08:00
|
|
|
|
|
|
|
// Visit all operands of the expression, keeping track of their weight (the
|
|
|
|
// number of paths from the expression root to the operand, or if you like
|
|
|
|
// the number of times that operand occurs in the linearized expression).
|
|
|
|
// For example, if I = X + A, where X = A + B, then I, X and B have weight 1
|
|
|
|
// while A has weight two.
|
|
|
|
|
|
|
|
// Worklist of non-leaf nodes (their operands are in the expression too) along
|
|
|
|
// with their weights, representing a certain number of paths to the operator.
|
|
|
|
// If an operator occurs in the worklist multiple times then we found multiple
|
|
|
|
// ways to get to it.
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
SmallVector<std::pair<BinaryOperator*, APInt>, 8> Worklist; // (Op, Weight)
|
|
|
|
Worklist.push_back(std::make_pair(I, APInt(Bitwidth, 1)));
|
2014-11-19 04:21:54 +08:00
|
|
|
bool Changed = false;
|
2005-05-08 05:59:39 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Leaves of the expression are values that either aren't the right kind of
|
|
|
|
// operation (eg: a constant, or a multiply in an add tree), or are, but have
|
|
|
|
// some uses that are not inside the expression. For example, in I = X + X,
|
|
|
|
// X = A + B, the value X has two uses (by I) that are in the expression. If
|
|
|
|
// X has any other uses, for example in a return instruction, then we consider
|
|
|
|
// X to be a leaf, and won't analyze it further. When we first visit a value,
|
|
|
|
// if it has more than one use then at first we conservatively consider it to
|
|
|
|
// be a leaf. Later, as the expression is explored, we may discover some more
|
|
|
|
// uses of the value from inside the expression. If all uses turn out to be
|
|
|
|
// from within the expression (and the value is a binary operator of the right
|
|
|
|
// kind) then the value is no longer considered to be a leaf, and its operands
|
|
|
|
// are explored.
|
|
|
|
|
|
|
|
// Leaves - Keeps track of the set of putative leaves as well as the number of
|
|
|
|
// paths to each leaf seen so far.
|
2017-10-19 05:46:47 +08:00
|
|
|
using LeafMap = DenseMap<Value *, APInt>;
|
2012-05-25 20:03:02 +08:00
|
|
|
LeafMap Leaves; // Leaf -> Total weight so far.
|
2017-10-19 05:46:47 +08:00
|
|
|
SmallVector<Value *, 8> LeafOrder; // Ensure deterministic leaf output order.
|
2005-05-09 05:28:52 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
#ifndef NDEBUG
|
2017-10-19 05:46:47 +08:00
|
|
|
SmallPtrSet<Value *, 8> Visited; // For sanity checking the iteration scheme.
|
2012-05-25 20:03:02 +08:00
|
|
|
#endif
|
|
|
|
while (!Worklist.empty()) {
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
std::pair<BinaryOperator*, APInt> P = Worklist.pop_back_val();
|
2012-05-25 20:03:02 +08:00
|
|
|
I = P.first; // We examine the operands of this binary operator.
|
|
|
|
|
|
|
|
for (unsigned OpIdx = 0; OpIdx < 2; ++OpIdx) { // Visit operands.
|
|
|
|
Value *Op = I->getOperand(OpIdx);
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
APInt Weight = P.second; // Number of paths to this operand.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "OPERAND: " << *Op << " (" << Weight << ")\n");
|
2012-05-25 20:03:02 +08:00
|
|
|
assert(!Op->use_empty() && "No uses, so how did we get to it?!");
|
|
|
|
|
|
|
|
// If this is a binary operation of the right kind with only one use then
|
|
|
|
// add its operands to the expression.
|
|
|
|
if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) {
|
2014-11-19 15:49:26 +08:00
|
|
|
assert(Visited.insert(Op).second && "Not first visit!");
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "DIRECT ADD: " << *Op << " (" << Weight << ")\n");
|
2012-05-25 20:03:02 +08:00
|
|
|
Worklist.push_back(std::make_pair(BO, Weight));
|
|
|
|
continue;
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Appears to be a leaf. Is the operand already in the set of leaves?
|
|
|
|
LeafMap::iterator It = Leaves.find(Op);
|
|
|
|
if (It == Leaves.end()) {
|
|
|
|
// Not in the leaf map. Must be the first time we saw this operand.
|
2014-11-19 15:49:26 +08:00
|
|
|
assert(Visited.insert(Op).second && "Not first visit!");
|
2012-05-25 20:03:02 +08:00
|
|
|
if (!Op->hasOneUse()) {
|
|
|
|
// This value has uses not accounted for by the expression, so it is
|
|
|
|
// not safe to modify. Mark it as being a leaf.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs()
|
|
|
|
<< "ADD USES LEAF: " << *Op << " (" << Weight << ")\n");
|
2012-05-25 20:03:02 +08:00
|
|
|
LeafOrder.push_back(Op);
|
|
|
|
Leaves[Op] = Weight;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
// No uses outside the expression, try morphing it.
|
2016-11-14 20:00:46 +08:00
|
|
|
} else {
|
2012-05-25 20:03:02 +08:00
|
|
|
// Already in the leaf map.
|
2016-11-14 20:00:46 +08:00
|
|
|
assert(It != Leaves.end() && Visited.count(Op) &&
|
|
|
|
"In leaf map but not visited!");
|
2012-05-25 20:03:02 +08:00
|
|
|
|
|
|
|
// Update the number of paths to the leaf.
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
IncorporateWeight(It->second, Weight, Opcode);
|
2012-05-25 20:03:02 +08:00
|
|
|
|
2012-07-26 17:26:40 +08:00
|
|
|
#if 0 // TODO: Re-enable once PR13021 is fixed.
|
2012-05-25 20:03:02 +08:00
|
|
|
// The leaf already has one use from inside the expression. As we want
|
|
|
|
// exactly one such use, drop this new use of the leaf.
|
|
|
|
assert(!Op->hasOneUse() && "Only one use, but we got here twice!");
|
|
|
|
I->setOperand(OpIdx, UndefValue::get(I->getType()));
|
2014-11-19 04:21:54 +08:00
|
|
|
Changed = true;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// If the leaf is a binary operation of the right kind and we now see
|
|
|
|
// that its multiple original uses were in fact all by nodes belonging
|
|
|
|
// to the expression, then no longer consider it to be a leaf and add
|
|
|
|
// its operands to the expression.
|
|
|
|
if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "UNLEAF: " << *Op << " (" << It->second << ")\n");
|
2012-05-25 20:03:02 +08:00
|
|
|
Worklist.push_back(std::make_pair(BO, It->second));
|
|
|
|
Leaves.erase(It);
|
|
|
|
continue;
|
|
|
|
}
|
2012-07-26 17:26:40 +08:00
|
|
|
#endif
|
2005-04-22 07:48:37 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// If we still have uses that are not accounted for by the expression
|
|
|
|
// then it is not safe to modify the value.
|
|
|
|
if (!Op->hasOneUse())
|
|
|
|
continue;
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// No uses outside the expression, try morphing it.
|
|
|
|
Weight = It->second;
|
|
|
|
Leaves.erase(It); // Since the value may be morphed below.
|
|
|
|
}
|
2005-05-08 05:59:39 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// At this point we have a value which, first of all, is not a binary
|
|
|
|
// expression of the right kind, and secondly, is only used inside the
|
|
|
|
// expression. This means that it can safely be modified. See if we
|
|
|
|
// can usefully morph it into an expression of the right kind.
|
|
|
|
assert((!isa<Instruction>(Op) ||
|
2014-11-07 00:46:37 +08:00
|
|
|
cast<Instruction>(Op)->getOpcode() != Opcode
|
|
|
|
|| (isa<FPMathOperator>(Op) &&
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
!cast<Instruction>(Op)->isFast())) &&
|
2012-05-25 20:03:02 +08:00
|
|
|
"Should have been handled above!");
|
|
|
|
assert(Op->hasOneUse() && "Has uses outside the expression tree!");
|
|
|
|
|
|
|
|
// If this is a multiply expression, turn any internal negations into
|
|
|
|
// multiplies by -1 so they can be reassociated.
|
2014-08-14 23:23:01 +08:00
|
|
|
if (BinaryOperator *BO = dyn_cast<BinaryOperator>(Op))
|
2018-10-23 23:55:06 +08:00
|
|
|
if ((Opcode == Instruction::Mul && match(BO, m_Neg(m_Value()))) ||
|
2018-10-24 22:45:18 +08:00
|
|
|
(Opcode == Instruction::FMul && match(BO, m_FNeg(m_Value())))) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs()
|
|
|
|
<< "MORPH LEAF: " << *Op << " (" << Weight << ") TO ");
|
2014-08-14 23:23:01 +08:00
|
|
|
BO = LowerNegateToMultiply(BO);
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << *BO << '\n');
|
2014-08-14 23:23:01 +08:00
|
|
|
Worklist.push_back(std::make_pair(BO, Weight));
|
2014-11-19 04:21:54 +08:00
|
|
|
Changed = true;
|
2014-08-14 23:23:01 +08:00
|
|
|
continue;
|
|
|
|
}
|
2005-05-08 05:59:39 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Failed to morph into an expression of the right type. This really is
|
|
|
|
// a leaf.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "ADD LEAF: " << *Op << " (" << Weight << ")\n");
|
2012-05-25 20:03:02 +08:00
|
|
|
assert(!isReassociableOp(Op, Opcode) && "Value was morphed?");
|
|
|
|
LeafOrder.push_back(Op);
|
|
|
|
Leaves[Op] = Weight;
|
|
|
|
}
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// The leaves, repeated according to their weights, represent the linearized
|
|
|
|
// form of the expression.
|
|
|
|
for (unsigned i = 0, e = LeafOrder.size(); i != e; ++i) {
|
|
|
|
Value *V = LeafOrder[i];
|
|
|
|
LeafMap::iterator It = Leaves.find(V);
|
|
|
|
if (It == Leaves.end())
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
// Node initially thought to be a leaf wasn't.
|
2012-05-25 20:03:02 +08:00
|
|
|
continue;
|
|
|
|
assert(!isReassociableOp(V, Opcode) && "Shouldn't be a leaf!");
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
APInt Weight = It->second;
|
|
|
|
if (Weight.isMinValue())
|
|
|
|
// Leaf already output or weight reduction eliminated it.
|
|
|
|
continue;
|
2012-05-25 20:03:02 +08:00
|
|
|
// Ensure the leaf is only output once.
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
It->second = 0;
|
|
|
|
Ops.push_back(std::make_pair(V, Weight));
|
|
|
|
}
|
|
|
|
|
|
|
|
// For nilpotent operations or addition there may be no operands, for example
|
|
|
|
// because the expression was "X xor X" or consisted of 2^Bitwidth additions:
|
|
|
|
// in both cases the weight reduces to 0 causing the value to be skipped.
|
|
|
|
if (Ops.empty()) {
|
2012-11-15 17:58:38 +08:00
|
|
|
Constant *Identity = ConstantExpr::getBinOpIdentity(Opcode, I->getType());
|
2012-06-13 17:42:13 +08:00
|
|
|
assert(Identity && "Associative operation without identity!");
|
2015-05-30 03:43:39 +08:00
|
|
|
Ops.emplace_back(Identity, APInt(Bitwidth, 1));
|
2012-05-25 20:03:02 +08:00
|
|
|
}
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
|
2014-11-19 04:21:54 +08:00
|
|
|
return Changed;
|
2005-05-08 05:59:39 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Now that the operands for this expression tree are
|
|
|
|
/// linearized and optimized, emit them in-order.
|
2016-04-27 07:39:29 +08:00
|
|
|
void ReassociatePass::RewriteExprTree(BinaryOperator *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2012-05-25 20:03:02 +08:00
|
|
|
assert(Ops.size() > 1 && "Single values should be used directly!");
|
|
|
|
|
2012-11-19 03:27:01 +08:00
|
|
|
// Since our optimizations should never increase the number of operations, the
|
|
|
|
// new expression can usually be written reusing the existing binary operators
|
2012-05-25 20:03:02 +08:00
|
|
|
// from the original expression tree, without creating any new instructions,
|
|
|
|
// though the rewritten expression may have a completely different topology.
|
|
|
|
// We take care to not change anything if the new expression will be the same
|
|
|
|
// as the original. If more than trivial changes (like commuting operands)
|
|
|
|
// were made then we are obliged to clear out any optional subclass data like
|
|
|
|
// nsw flags.
|
|
|
|
|
|
|
|
/// NodesToRewrite - Nodes from the original expression available for writing
|
|
|
|
/// the new expression into.
|
|
|
|
SmallVector<BinaryOperator*, 8> NodesToRewrite;
|
|
|
|
unsigned Opcode = I->getOpcode();
|
2012-06-30 03:03:05 +08:00
|
|
|
BinaryOperator *Op = I;
|
2012-05-25 20:03:02 +08:00
|
|
|
|
2012-11-19 03:27:01 +08:00
|
|
|
/// NotRewritable - The operands being written will be the leaves of the new
|
|
|
|
/// expression and must not be used as inner nodes (via NodesToRewrite) by
|
|
|
|
/// mistake. Inner nodes are always reassociable, and usually leaves are not
|
|
|
|
/// (if they were they would have been incorporated into the expression and so
|
|
|
|
/// would not be leaves), so most of the time there is no danger of this. But
|
|
|
|
/// in rare cases a leaf may become reassociable if an optimization kills uses
|
|
|
|
/// of it, or it may momentarily become reassociable during rewriting (below)
|
|
|
|
/// due it being removed as an operand of one of its uses. Ensure that misuse
|
|
|
|
/// of leaf nodes as inner nodes cannot occur by remembering all of the future
|
|
|
|
/// leaves and refusing to reuse any of them as inner nodes.
|
|
|
|
SmallPtrSet<Value*, 8> NotRewritable;
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i)
|
|
|
|
NotRewritable.insert(Ops[i].Op);
|
|
|
|
|
2012-05-27 00:42:52 +08:00
|
|
|
// ExpressionChanged - Non-null if the rewritten expression differs from the
|
|
|
|
// original in some non-trivial way, requiring the clearing of optional flags.
|
|
|
|
// Flags are cleared from the operator in ExpressionChanged up to I inclusive.
|
2014-04-25 13:29:35 +08:00
|
|
|
BinaryOperator *ExpressionChanged = nullptr;
|
2012-06-27 22:19:00 +08:00
|
|
|
for (unsigned i = 0; ; ++i) {
|
2012-05-25 20:03:02 +08:00
|
|
|
// The last operation (which comes earliest in the IR) is special as both
|
|
|
|
// operands will come from Ops, rather than just one with the other being
|
|
|
|
// a subexpression.
|
|
|
|
if (i+2 == Ops.size()) {
|
|
|
|
Value *NewLHS = Ops[i].Op;
|
|
|
|
Value *NewRHS = Ops[i+1].Op;
|
|
|
|
Value *OldLHS = Op->getOperand(0);
|
|
|
|
Value *OldRHS = Op->getOperand(1);
|
|
|
|
|
2014-11-20 07:21:20 +08:00
|
|
|
if (NewLHS == OldLHS && NewRHS == OldRHS)
|
|
|
|
// Nothing changed, leave it alone.
|
|
|
|
break;
|
|
|
|
|
|
|
|
if (NewLHS == OldRHS && NewRHS == OldLHS) {
|
|
|
|
// The order of the operands was reversed. Swap them.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n');
|
2014-11-20 07:21:20 +08:00
|
|
|
Op->swapOperands();
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n');
|
2012-05-25 20:03:02 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumChanged;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// The new operation differs non-trivially from the original. Overwrite
|
|
|
|
// the old operands with the new ones.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n');
|
2012-05-25 20:03:02 +08:00
|
|
|
if (NewLHS != OldLHS) {
|
2012-11-19 03:27:01 +08:00
|
|
|
BinaryOperator *BO = isReassociableOp(OldLHS, Opcode);
|
|
|
|
if (BO && !NotRewritable.count(BO))
|
2012-05-25 20:03:02 +08:00
|
|
|
NodesToRewrite.push_back(BO);
|
|
|
|
Op->setOperand(0, NewLHS);
|
|
|
|
}
|
|
|
|
if (NewRHS != OldRHS) {
|
2012-11-19 03:27:01 +08:00
|
|
|
BinaryOperator *BO = isReassociableOp(OldRHS, Opcode);
|
|
|
|
if (BO && !NotRewritable.count(BO))
|
2012-05-25 20:03:02 +08:00
|
|
|
NodesToRewrite.push_back(BO);
|
|
|
|
Op->setOperand(1, NewRHS);
|
|
|
|
}
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n');
|
2012-05-25 20:03:02 +08:00
|
|
|
|
2012-05-27 00:42:52 +08:00
|
|
|
ExpressionChanged = Op;
|
2005-05-08 05:59:39 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumChanged;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
break;
|
2005-05-08 05:59:39 +08:00
|
|
|
}
|
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Not the last operation. The left-hand side will be a sub-expression
|
|
|
|
// while the right-hand side will be the current element of Ops.
|
|
|
|
Value *NewRHS = Ops[i].Op;
|
|
|
|
if (NewRHS != Op->getOperand(1)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n');
|
2012-05-25 20:03:02 +08:00
|
|
|
if (NewRHS == Op->getOperand(0)) {
|
|
|
|
// The new right-hand side was already present as the left operand. If
|
|
|
|
// we are lucky then swapping the operands will sort out both of them.
|
|
|
|
Op->swapOperands();
|
|
|
|
} else {
|
|
|
|
// Overwrite with the new right-hand side.
|
2012-11-19 03:27:01 +08:00
|
|
|
BinaryOperator *BO = isReassociableOp(Op->getOperand(1), Opcode);
|
|
|
|
if (BO && !NotRewritable.count(BO))
|
2012-05-25 20:03:02 +08:00
|
|
|
NodesToRewrite.push_back(BO);
|
|
|
|
Op->setOperand(1, NewRHS);
|
2012-05-27 00:42:52 +08:00
|
|
|
ExpressionChanged = Op;
|
2012-05-25 20:03:02 +08:00
|
|
|
}
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n');
|
2012-05-25 20:03:02 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumChanged;
|
|
|
|
}
|
2011-02-02 10:02:34 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Now deal with the left-hand side. If this is already an operation node
|
|
|
|
// from the original expression then just rewrite the rest of the expression
|
|
|
|
// into it.
|
2012-11-19 03:27:01 +08:00
|
|
|
BinaryOperator *BO = isReassociableOp(Op->getOperand(0), Opcode);
|
|
|
|
if (BO && !NotRewritable.count(BO)) {
|
2012-06-30 03:03:05 +08:00
|
|
|
Op = BO;
|
2012-05-25 20:03:02 +08:00
|
|
|
continue;
|
|
|
|
}
|
2011-02-02 10:02:34 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Otherwise, grab a spare node from the original expression and use that as
|
2012-06-29 21:25:06 +08:00
|
|
|
// the left-hand side. If there are no nodes left then the optimizers made
|
|
|
|
// an expression with more nodes than the original! This usually means that
|
|
|
|
// they did something stupid but it might mean that the problem was just too
|
|
|
|
// hard (finding the mimimal number of multiplications needed to realize a
|
|
|
|
// multiplication expression is NP-complete). Whatever the reason, smart or
|
|
|
|
// stupid, create a new node if there are none left.
|
2012-06-30 03:03:05 +08:00
|
|
|
BinaryOperator *NewOp;
|
2012-06-29 21:25:06 +08:00
|
|
|
if (NodesToRewrite.empty()) {
|
|
|
|
Constant *Undef = UndefValue::get(I->getType());
|
2012-06-30 03:03:05 +08:00
|
|
|
NewOp = BinaryOperator::Create(Instruction::BinaryOps(Opcode),
|
|
|
|
Undef, Undef, "", I);
|
2015-03-14 04:53:01 +08:00
|
|
|
if (NewOp->getType()->isFPOrFPVectorTy())
|
2014-08-14 23:23:01 +08:00
|
|
|
NewOp->setFastMathFlags(I->getFastMathFlags());
|
2012-06-30 03:03:05 +08:00
|
|
|
} else {
|
|
|
|
NewOp = NodesToRewrite.pop_back_val();
|
2012-06-29 21:25:06 +08:00
|
|
|
}
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n');
|
2012-06-30 03:03:05 +08:00
|
|
|
Op->setOperand(0, NewOp);
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n');
|
2012-05-27 00:42:52 +08:00
|
|
|
ExpressionChanged = Op;
|
2005-05-08 05:59:39 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumChanged;
|
2012-06-30 03:03:05 +08:00
|
|
|
Op = NewOp;
|
2005-05-08 05:59:39 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2012-05-27 00:42:52 +08:00
|
|
|
// If the expression changed non-trivially then clear out all subclass data
|
2012-06-27 22:19:00 +08:00
|
|
|
// starting from the operator specified in ExpressionChanged, and compactify
|
|
|
|
// the operators to just before the expression root to guarantee that the
|
|
|
|
// expression tree is dominated by all of Ops.
|
|
|
|
if (ExpressionChanged)
|
2012-05-25 20:03:02 +08:00
|
|
|
do {
|
2014-08-14 23:23:01 +08:00
|
|
|
// Preserve FastMathFlags.
|
|
|
|
if (isa<FPMathOperator>(I)) {
|
|
|
|
FastMathFlags Flags = I->getFastMathFlags();
|
|
|
|
ExpressionChanged->clearSubclassOptionalData();
|
|
|
|
ExpressionChanged->setFastMathFlags(Flags);
|
|
|
|
} else
|
|
|
|
ExpressionChanged->clearSubclassOptionalData();
|
|
|
|
|
2012-05-27 00:42:52 +08:00
|
|
|
if (ExpressionChanged == I)
|
2012-05-25 20:03:02 +08:00
|
|
|
break;
|
[DebugInfo] Invalidate debug info in ReassociatePass::RewriteExprTree
Summary:
When Reassociate is rewriting an expression tree it may
reuse old binary expression nodes, for new expressions.
Whenever an expression node is reused, but with a non-trivial
change in the result, we need to invalidate any debug info
that is associated with the node.
If for example rewriting
x = mul a, b
y = mul c, x
into
x = mul c, b
y = mul a, x
we still get the same result for 'y', but 'x' is a new expression.
All debug info referring to 'x' must be invalidated (marked as
optimized out) since we no longer calculate the expected value.
As a side-effect this patch avoid (at least some) problems where
reassociate could end up creating IR with debug-use before def.
Earlier the dbg.value nodes where left untouched in the IR, while
the reused binary nodes where sinked to just before the root node
of the rewritten expression tree. See PR27273 for more info about
such problems.
Reviewers: dblaikie, aprantl, dexonsmith
Reviewed By: aprantl
Subscribers: JDevlieghere, llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D45975
llvm-svn: 330804
2018-04-25 17:23:56 +08:00
|
|
|
|
|
|
|
// Discard any debug info related to the expressions that has changed (we
|
|
|
|
// can leave debug infor related to the root, since the result of the
|
|
|
|
// expression tree should be the same even after reassociation).
|
2018-12-11 06:17:04 +08:00
|
|
|
replaceDbgUsesWithUndef(ExpressionChanged);
|
[DebugInfo] Invalidate debug info in ReassociatePass::RewriteExprTree
Summary:
When Reassociate is rewriting an expression tree it may
reuse old binary expression nodes, for new expressions.
Whenever an expression node is reused, but with a non-trivial
change in the result, we need to invalidate any debug info
that is associated with the node.
If for example rewriting
x = mul a, b
y = mul c, x
into
x = mul c, b
y = mul a, x
we still get the same result for 'y', but 'x' is a new expression.
All debug info referring to 'x' must be invalidated (marked as
optimized out) since we no longer calculate the expected value.
As a side-effect this patch avoid (at least some) problems where
reassociate could end up creating IR with debug-use before def.
Earlier the dbg.value nodes where left untouched in the IR, while
the reused binary nodes where sinked to just before the root node
of the rewritten expression tree. See PR27273 for more info about
such problems.
Reviewers: dblaikie, aprantl, dexonsmith
Reviewed By: aprantl
Subscribers: JDevlieghere, llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D45975
llvm-svn: 330804
2018-04-25 17:23:56 +08:00
|
|
|
|
2012-06-27 22:19:00 +08:00
|
|
|
ExpressionChanged->moveBefore(I);
|
2014-03-09 11:16:01 +08:00
|
|
|
ExpressionChanged = cast<BinaryOperator>(*ExpressionChanged->user_begin());
|
2017-10-19 05:46:47 +08:00
|
|
|
} while (true);
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Throw away any left over nodes from the original expression.
|
|
|
|
for (unsigned i = 0, e = NodesToRewrite.size(); i != e; ++i)
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(NodesToRewrite[i]);
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Insert instructions before the instruction pointed to by BI,
|
2012-05-03 07:43:23 +08:00
|
|
|
/// that computes the negative version of the value specified. The negative
|
|
|
|
/// version of the value is returned, and BI is left pointing at the instruction
|
|
|
|
/// that should be processed next by the reassociation pass.
|
2015-11-17 02:07:30 +08:00
|
|
|
/// Also add intermediate instructions to the redo list that are modified while
|
|
|
|
/// pushing the negates through adds. These will be revisited to see if
|
|
|
|
/// additional opportunities have been exposed.
|
|
|
|
static Value *NegateValue(Value *V, Instruction *BI,
|
2018-05-03 01:59:16 +08:00
|
|
|
ReassociatePass::OrderedSet &ToRedo) {
|
2017-11-16 00:19:17 +08:00
|
|
|
if (auto *C = dyn_cast<Constant>(V))
|
|
|
|
return C->getType()->isFPOrFPVectorTy() ? ConstantExpr::getFNeg(C) :
|
|
|
|
ConstantExpr::getNeg(C);
|
2015-01-16 11:00:58 +08:00
|
|
|
|
2002-05-16 12:37:07 +08:00
|
|
|
// We are trying to expose opportunity for reassociation. One of the things
|
|
|
|
// that we want to do to achieve this is to push a negation as deep into an
|
|
|
|
// expression chain as possible, to expose the add instructions. In practice,
|
|
|
|
// this means that we turn this:
|
|
|
|
// X = -(A+12+C+D) into X = -A + -12 + -C + -D = -12 + -A + -C + -D
|
|
|
|
// so that later, a: Y = 12+X could get reassociated with the -12 to eliminate
|
|
|
|
// the constants. We assume that instcombine will clean up the mess later if
|
2010-01-01 08:04:26 +08:00
|
|
|
// we introduce tons of unnecessary negation instructions.
|
2002-05-16 12:37:07 +08:00
|
|
|
//
|
2014-08-14 23:23:01 +08:00
|
|
|
if (BinaryOperator *I =
|
|
|
|
isReassociableOp(V, Instruction::Add, Instruction::FAdd)) {
|
2012-05-25 20:03:02 +08:00
|
|
|
// Push the negates through the add.
|
2015-11-17 02:07:30 +08:00
|
|
|
I->setOperand(0, NegateValue(I->getOperand(0), BI, ToRedo));
|
|
|
|
I->setOperand(1, NegateValue(I->getOperand(1), BI, ToRedo));
|
2015-06-25 05:27:36 +08:00
|
|
|
if (I->getOpcode() == Instruction::Add) {
|
|
|
|
I->setHasNoUnsignedWrap(false);
|
|
|
|
I->setHasNoSignedWrap(false);
|
|
|
|
}
|
2012-05-25 20:03:02 +08:00
|
|
|
|
|
|
|
// We must move the add instruction here, because the neg instructions do
|
|
|
|
// not dominate the old add instruction in general. By moving it, we are
|
|
|
|
// assured that the neg instructions we just inserted dominate the
|
|
|
|
// instruction we are about to insert after them.
|
|
|
|
//
|
|
|
|
I->moveBefore(BI);
|
|
|
|
I->setName(I->getName()+".neg");
|
2015-11-17 02:07:30 +08:00
|
|
|
|
|
|
|
// Add the intermediate negates to the redo list as processing them later
|
|
|
|
// could expose more reassociating opportunities.
|
|
|
|
ToRedo.insert(I);
|
2012-05-25 20:03:02 +08:00
|
|
|
return I;
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 04:34:32 +08:00
|
|
|
// Okay, we need to materialize a negated version of V with an instruction.
|
|
|
|
// Scan the use lists of V to see if we have one already.
|
2014-03-09 11:16:01 +08:00
|
|
|
for (User *U : V->users()) {
|
2018-10-24 22:45:18 +08:00
|
|
|
if (!match(U, m_Neg(m_Value())) && !match(U, m_FNeg(m_Value())))
|
2014-08-14 23:23:01 +08:00
|
|
|
continue;
|
2010-01-01 04:34:32 +08:00
|
|
|
|
|
|
|
// We found one! Now we have to make sure that the definition dominates
|
|
|
|
// this use. We do this by moving it to the entry block (if it is a
|
|
|
|
// non-instruction value) or right after the definition. These negates will
|
|
|
|
// be zapped by reassociate later, so we don't need much finesse here.
|
2010-07-12 20:03:02 +08:00
|
|
|
BinaryOperator *TheNeg = cast<BinaryOperator>(U);
|
2010-01-03 05:46:33 +08:00
|
|
|
|
|
|
|
// Verify that the negate is in this function, V might be a constant expr.
|
|
|
|
if (TheNeg->getParent()->getParent() != BI->getParent()->getParent())
|
|
|
|
continue;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 04:34:32 +08:00
|
|
|
BasicBlock::iterator InsertPt;
|
|
|
|
if (Instruction *InstInput = dyn_cast<Instruction>(V)) {
|
|
|
|
if (InvokeInst *II = dyn_cast<InvokeInst>(InstInput)) {
|
|
|
|
InsertPt = II->getNormalDest()->begin();
|
|
|
|
} else {
|
2015-10-14 03:26:58 +08:00
|
|
|
InsertPt = ++InstInput->getIterator();
|
2010-01-01 04:34:32 +08:00
|
|
|
}
|
|
|
|
while (isa<PHINode>(InsertPt)) ++InsertPt;
|
|
|
|
} else {
|
|
|
|
InsertPt = TheNeg->getParent()->getParent()->getEntryBlock().begin();
|
|
|
|
}
|
2015-10-14 03:26:58 +08:00
|
|
|
TheNeg->moveBefore(&*InsertPt);
|
2015-06-25 05:27:36 +08:00
|
|
|
if (TheNeg->getOpcode() == Instruction::Sub) {
|
|
|
|
TheNeg->setHasNoUnsignedWrap(false);
|
|
|
|
TheNeg->setHasNoSignedWrap(false);
|
|
|
|
} else {
|
|
|
|
TheNeg->andIRFlags(BI);
|
|
|
|
}
|
2015-11-17 02:07:30 +08:00
|
|
|
ToRedo.insert(TheNeg);
|
2010-01-01 04:34:32 +08:00
|
|
|
return TheNeg;
|
|
|
|
}
|
2002-05-16 12:37:07 +08:00
|
|
|
|
|
|
|
// Insert a 'neg' instruction that subtracts the value from zero to get the
|
|
|
|
// negation.
|
2015-11-17 02:07:30 +08:00
|
|
|
BinaryOperator *NewNeg = CreateNeg(V, V->getName() + ".neg", BI, BI);
|
|
|
|
ToRedo.insert(NewNeg);
|
|
|
|
return NewNeg;
|
2002-05-16 12:37:07 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Return true if we should break up this subtract of X-Y into (X + -Y).
|
2009-11-14 15:25:54 +08:00
|
|
|
static bool ShouldBreakUpSubtract(Instruction *Sub) {
|
2008-02-18 04:44:51 +08:00
|
|
|
// If this is a negation, we can't split it up!
|
2018-10-24 22:45:18 +08:00
|
|
|
if (match(Sub, m_Neg(m_Value())) || match(Sub, m_FNeg(m_Value())))
|
2008-02-18 04:44:51 +08:00
|
|
|
return false;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2014-10-10 04:06:29 +08:00
|
|
|
// Don't breakup X - undef.
|
|
|
|
if (isa<UndefValue>(Sub->getOperand(1)))
|
|
|
|
return false;
|
|
|
|
|
2008-02-18 04:44:51 +08:00
|
|
|
// Don't bother to break this up unless either the LHS is an associable add or
|
2008-02-18 04:51:26 +08:00
|
|
|
// subtract or if this is only used by one.
|
2014-08-14 23:23:01 +08:00
|
|
|
Value *V0 = Sub->getOperand(0);
|
|
|
|
if (isReassociableOp(V0, Instruction::Add, Instruction::FAdd) ||
|
|
|
|
isReassociableOp(V0, Instruction::Sub, Instruction::FSub))
|
2008-02-18 04:44:51 +08:00
|
|
|
return true;
|
2014-08-14 23:23:01 +08:00
|
|
|
Value *V1 = Sub->getOperand(1);
|
|
|
|
if (isReassociableOp(V1, Instruction::Add, Instruction::FAdd) ||
|
|
|
|
isReassociableOp(V1, Instruction::Sub, Instruction::FSub))
|
2008-02-18 04:44:51 +08:00
|
|
|
return true;
|
2014-08-14 23:23:01 +08:00
|
|
|
Value *VB = Sub->user_back();
|
2012-05-03 07:43:23 +08:00
|
|
|
if (Sub->hasOneUse() &&
|
2014-08-14 23:23:01 +08:00
|
|
|
(isReassociableOp(VB, Instruction::Add, Instruction::FAdd) ||
|
|
|
|
isReassociableOp(VB, Instruction::Sub, Instruction::FSub)))
|
2008-02-18 04:44:51 +08:00
|
|
|
return true;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2008-02-18 04:44:51 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// If we have (X-Y), and if either X is an add, or if this is only used by an
|
|
|
|
/// add, transform this into (X+(0-Y)) to promote better reassociation.
|
2018-05-03 01:59:16 +08:00
|
|
|
static BinaryOperator *BreakUpSubtract(Instruction *Sub,
|
|
|
|
ReassociatePass::OrderedSet &ToRedo) {
|
2010-01-01 08:04:26 +08:00
|
|
|
// Convert a subtract into an add and a neg instruction. This allows sub
|
|
|
|
// instructions to be commuted with other add instructions.
|
2005-05-07 12:08:02 +08:00
|
|
|
//
|
2010-01-01 08:04:26 +08:00
|
|
|
// Calculate the negative value of Operand 1 of the sub instruction,
|
|
|
|
// and set it as the RHS of the add instruction we just made.
|
2015-11-17 02:07:30 +08:00
|
|
|
Value *NegVal = NegateValue(Sub->getOperand(1), Sub, ToRedo);
|
2014-08-14 23:23:01 +08:00
|
|
|
BinaryOperator *New = CreateAdd(Sub->getOperand(0), NegVal, "", Sub, Sub);
|
2012-06-09 04:15:33 +08:00
|
|
|
Sub->setOperand(0, Constant::getNullValue(Sub->getType())); // Drop use of op.
|
|
|
|
Sub->setOperand(1, Constant::getNullValue(Sub->getType())); // Drop use of op.
|
2007-02-11 09:23:03 +08:00
|
|
|
New->takeName(Sub);
|
2005-05-07 12:08:02 +08:00
|
|
|
|
|
|
|
// Everyone now refers to the add instruction.
|
|
|
|
Sub->replaceAllUsesWith(New);
|
2011-04-29 06:48:14 +08:00
|
|
|
New->setDebugLoc(Sub->getDebugLoc());
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Negated: " << *New << '\n');
|
2005-05-07 12:08:02 +08:00
|
|
|
return New;
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// If this is a shift of a reassociable multiply or is used by one, change
|
|
|
|
/// this into a multiply by a constant to assist with further reassociation.
|
2012-06-09 04:15:33 +08:00
|
|
|
static BinaryOperator *ConvertShiftToMul(Instruction *Shl) {
|
|
|
|
Constant *MulCst = ConstantInt::get(Shl->getType(), 1);
|
|
|
|
MulCst = ConstantExpr::getShl(MulCst, cast<Constant>(Shl->getOperand(1)));
|
|
|
|
|
|
|
|
BinaryOperator *Mul =
|
|
|
|
BinaryOperator::CreateMul(Shl->getOperand(0), MulCst, "", Shl);
|
|
|
|
Shl->setOperand(0, UndefValue::get(Shl->getType())); // Drop use of op.
|
|
|
|
Mul->takeName(Shl);
|
2014-11-08 06:12:57 +08:00
|
|
|
|
|
|
|
// Everyone now refers to the mul instruction.
|
2012-06-09 04:15:33 +08:00
|
|
|
Shl->replaceAllUsesWith(Mul);
|
|
|
|
Mul->setDebugLoc(Shl->getDebugLoc());
|
2014-11-08 06:12:57 +08:00
|
|
|
|
|
|
|
// We can safely preserve the nuw flag in all cases. It's also safe to turn a
|
|
|
|
// nuw nsw shl into a nuw nsw mul. However, nsw in isolation requires special
|
|
|
|
// handling.
|
|
|
|
bool NSW = cast<BinaryOperator>(Shl)->hasNoSignedWrap();
|
|
|
|
bool NUW = cast<BinaryOperator>(Shl)->hasNoUnsignedWrap();
|
|
|
|
if (NSW && NUW)
|
|
|
|
Mul->setHasNoSignedWrap(true);
|
|
|
|
Mul->setHasNoUnsignedWrap(NUW);
|
2012-06-09 04:15:33 +08:00
|
|
|
return Mul;
|
2005-05-07 12:24:13 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Scan backwards and forwards among values with the same rank as element i
|
|
|
|
/// to see if X exists. If X does not exist, return i. This is useful when
|
|
|
|
/// scanning for 'x' when we see '-x' because they both get the same rank.
|
2017-06-22 03:39:33 +08:00
|
|
|
static unsigned FindInOperandList(const SmallVectorImpl<ValueEntry> &Ops,
|
|
|
|
unsigned i, Value *X) {
|
2005-05-09 02:59:37 +08:00
|
|
|
unsigned XRank = Ops[i].Rank;
|
|
|
|
unsigned e = Ops.size();
|
2014-10-06 07:41:26 +08:00
|
|
|
for (unsigned j = i+1; j != e && Ops[j].Rank == XRank; ++j) {
|
2005-05-09 02:59:37 +08:00
|
|
|
if (Ops[j].Op == X)
|
|
|
|
return j;
|
2014-10-06 07:41:26 +08:00
|
|
|
if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op))
|
|
|
|
if (Instruction *I2 = dyn_cast<Instruction>(X))
|
|
|
|
if (I1->isIdenticalTo(I2))
|
|
|
|
return j;
|
|
|
|
}
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
// Scan backwards.
|
2014-10-06 07:41:26 +08:00
|
|
|
for (unsigned j = i-1; j != ~0U && Ops[j].Rank == XRank; --j) {
|
2005-05-09 02:59:37 +08:00
|
|
|
if (Ops[j].Op == X)
|
|
|
|
return j;
|
2014-10-06 07:41:26 +08:00
|
|
|
if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op))
|
|
|
|
if (Instruction *I2 = dyn_cast<Instruction>(X))
|
|
|
|
if (I1->isIdenticalTo(I2))
|
|
|
|
return j;
|
|
|
|
}
|
2005-05-09 02:59:37 +08:00
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Emit a tree of add instructions, summing Ops together
|
2006-03-04 17:31:13 +08:00
|
|
|
/// and returning the result. Insert the tree before I.
|
2012-05-02 17:59:45 +08:00
|
|
|
static Value *EmitAddTreeOfValues(Instruction *I,
|
2017-05-02 01:07:49 +08:00
|
|
|
SmallVectorImpl<WeakTrackingVH> &Ops) {
|
2006-03-04 17:31:13 +08:00
|
|
|
if (Ops.size() == 1) return Ops.back();
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2006-03-04 17:31:13 +08:00
|
|
|
Value *V1 = Ops.back();
|
|
|
|
Ops.pop_back();
|
|
|
|
Value *V2 = EmitAddTreeOfValues(I, Ops);
|
2017-11-10 02:14:24 +08:00
|
|
|
return CreateAdd(V2, V1, "reass.add", I, I);
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// If V is an expression tree that is a multiplication sequence,
|
|
|
|
/// and if this sequence contains a multiply by Factor,
|
2006-03-04 17:31:13 +08:00
|
|
|
/// remove Factor from the tree and return the new tree.
|
2016-04-27 07:39:29 +08:00
|
|
|
Value *ReassociatePass::RemoveFactorFromExpression(Value *V, Value *Factor) {
|
2014-08-14 23:23:01 +08:00
|
|
|
BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul);
|
|
|
|
if (!BO)
|
|
|
|
return nullptr;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
SmallVector<RepeatedValue, 8> Tree;
|
|
|
|
MadeChange |= LinearizeExprTree(BO, Tree);
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVector<ValueEntry, 8> Factors;
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
Factors.reserve(Tree.size());
|
|
|
|
for (unsigned i = 0, e = Tree.size(); i != e; ++i) {
|
|
|
|
RepeatedValue E = Tree[i];
|
|
|
|
Factors.append(E.second.getZExtValue(),
|
|
|
|
ValueEntry(getRank(E.first), E.first));
|
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
|
|
|
bool FoundFactor = false;
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
bool NeedsNegate = false;
|
|
|
|
for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
|
2006-03-04 17:31:13 +08:00
|
|
|
if (Factors[i].Op == Factor) {
|
|
|
|
FoundFactor = true;
|
|
|
|
Factors.erase(Factors.begin()+i);
|
|
|
|
break;
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
// If this is a negative version of this factor, remove it.
|
2014-08-14 23:23:01 +08:00
|
|
|
if (ConstantInt *FC1 = dyn_cast<ConstantInt>(Factor)) {
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
if (ConstantInt *FC2 = dyn_cast<ConstantInt>(Factors[i].Op))
|
|
|
|
if (FC1->getValue() == -FC2->getValue()) {
|
|
|
|
FoundFactor = NeedsNegate = true;
|
|
|
|
Factors.erase(Factors.begin()+i);
|
|
|
|
break;
|
|
|
|
}
|
2014-08-14 23:23:01 +08:00
|
|
|
} else if (ConstantFP *FC1 = dyn_cast<ConstantFP>(Factor)) {
|
|
|
|
if (ConstantFP *FC2 = dyn_cast<ConstantFP>(Factors[i].Op)) {
|
2016-06-08 18:01:20 +08:00
|
|
|
const APFloat &F1 = FC1->getValueAPF();
|
2014-08-14 23:23:01 +08:00
|
|
|
APFloat F2(FC2->getValueAPF());
|
|
|
|
F2.changeSign();
|
|
|
|
if (F1.compare(F2) == APFloat::cmpEqual) {
|
|
|
|
FoundFactor = NeedsNegate = true;
|
|
|
|
Factors.erase(Factors.begin() + i);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2006-03-15 00:04:29 +08:00
|
|
|
if (!FoundFactor) {
|
|
|
|
// Make sure to restore the operands to the expression tree.
|
|
|
|
RewriteExprTree(BO, Factors);
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2006-03-15 00:04:29 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2015-10-14 03:26:58 +08:00
|
|
|
BasicBlock::iterator InsertPt = ++BO->getIterator();
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:34:45 +08:00
|
|
|
// If this was just a single multiply, remove the multiply and return the only
|
|
|
|
// remaining operand.
|
|
|
|
if (Factors.size() == 1) {
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(BO);
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
V = Factors[0].Op;
|
|
|
|
} else {
|
|
|
|
RewriteExprTree(BO, Factors);
|
|
|
|
V = BO;
|
2010-01-01 03:34:45 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
if (NeedsNegate)
|
2015-10-14 03:26:58 +08:00
|
|
|
V = CreateNeg(V, "neg", &*InsertPt, BO);
|
2012-05-03 07:43:23 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
return V;
|
2006-03-04 17:31:13 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// If V is a single-use multiply, recursively add its operands as factors,
|
|
|
|
/// otherwise add V to the list of factors.
|
2010-03-05 15:18:54 +08:00
|
|
|
///
|
|
|
|
/// Ops is the top-level list of add operands we're trying to factor.
|
2006-03-15 00:04:29 +08:00
|
|
|
static void FindSingleUseMultiplyFactors(Value *V,
|
2017-02-09 01:45:27 +08:00
|
|
|
SmallVectorImpl<Value*> &Factors) {
|
2014-08-14 23:23:01 +08:00
|
|
|
BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul);
|
2012-05-25 20:03:02 +08:00
|
|
|
if (!BO) {
|
2006-03-15 00:04:29 +08:00
|
|
|
Factors.push_back(V);
|
|
|
|
return;
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2006-03-15 00:04:29 +08:00
|
|
|
// Otherwise, add the LHS and RHS to the list of factors.
|
2017-02-09 01:45:27 +08:00
|
|
|
FindSingleUseMultiplyFactors(BO->getOperand(1), Factors);
|
|
|
|
FindSingleUseMultiplyFactors(BO->getOperand(0), Factors);
|
2006-03-15 00:04:29 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Optimize a series of operands to an 'and', 'or', or 'xor' instruction.
|
|
|
|
/// This optimizes based on identities. If it can be reduced to a single Value,
|
|
|
|
/// it is returned, otherwise the Ops list is mutated as necessary.
|
2010-01-01 02:40:32 +08:00
|
|
|
static Value *OptimizeAndOrXor(unsigned Opcode,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2009-12-31 15:59:34 +08:00
|
|
|
// Scan the operand lists looking for X and ~X pairs, along with X,X pairs.
|
|
|
|
// If we find any, we can simplify the expression. X&~X == 0, X|~X == -1.
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
|
|
|
// First, check for X and ~X in the operand list.
|
|
|
|
assert(i < Ops.size());
|
2018-10-23 23:55:06 +08:00
|
|
|
Value *X;
|
|
|
|
if (match(Ops[i].Op, m_Not(m_Value(X)))) { // Cannot occur for ^.
|
2009-12-31 15:59:34 +08:00
|
|
|
unsigned FoundX = FindInOperandList(Ops, i, X);
|
|
|
|
if (FoundX != i) {
|
2010-01-01 01:51:05 +08:00
|
|
|
if (Opcode == Instruction::And) // ...&X&~X = 0
|
2009-12-31 15:59:34 +08:00
|
|
|
return Constant::getNullValue(X->getType());
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 01:51:05 +08:00
|
|
|
if (Opcode == Instruction::Or) // ...|X|~X = -1
|
2009-12-31 15:59:34 +08:00
|
|
|
return Constant::getAllOnesValue(X->getType());
|
|
|
|
}
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
// Next, check for duplicate pairs of values, which we assume are next to
|
|
|
|
// each other, due to our sorting criteria.
|
|
|
|
assert(i < Ops.size());
|
|
|
|
if (i+1 != Ops.size() && Ops[i+1].Op == Ops[i].Op) {
|
|
|
|
if (Opcode == Instruction::And || Opcode == Instruction::Or) {
|
2010-01-01 03:49:01 +08:00
|
|
|
// Drop duplicate values for And and Or.
|
2009-12-31 15:59:34 +08:00
|
|
|
Ops.erase(Ops.begin()+i);
|
|
|
|
--i; --e;
|
|
|
|
++NumAnnihil;
|
2010-01-01 03:49:01 +08:00
|
|
|
continue;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:49:01 +08:00
|
|
|
// Drop pairs of values for Xor.
|
|
|
|
assert(Opcode == Instruction::Xor);
|
|
|
|
if (e == 2)
|
|
|
|
return Constant::getNullValue(Ops[0].Op->getType());
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 08:04:26 +08:00
|
|
|
// Y ^ X^X -> Y
|
2010-01-01 03:49:01 +08:00
|
|
|
Ops.erase(Ops.begin()+i, Ops.begin()+i+2);
|
|
|
|
i -= 1; e -= 2;
|
|
|
|
++NumAnnihil;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
|
|
|
}
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
2006-03-15 00:04:29 +08:00
|
|
|
|
2015-12-17 07:10:53 +08:00
|
|
|
/// Helper function of CombineXorOpnd(). It creates a bitwise-and
|
2013-03-30 10:15:01 +08:00
|
|
|
/// instruction with the given two operands, and return the resulting
|
|
|
|
/// instruction. There are two special cases: 1) if the constant operand is 0,
|
|
|
|
/// it will return NULL. 2) if the constant is ~0, the symbolic operand will
|
|
|
|
/// be returned.
|
2017-06-22 03:39:35 +08:00
|
|
|
static Value *createAndInstr(Instruction *InsertBefore, Value *Opnd,
|
2013-03-30 10:15:01 +08:00
|
|
|
const APInt &ConstOpnd) {
|
2017-06-22 03:39:35 +08:00
|
|
|
if (ConstOpnd.isNullValue())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
if (ConstOpnd.isAllOnesValue())
|
2013-03-30 10:15:01 +08:00
|
|
|
return Opnd;
|
2017-06-22 03:39:35 +08:00
|
|
|
|
|
|
|
Instruction *I = BinaryOperator::CreateAnd(
|
|
|
|
Opnd, ConstantInt::get(Opnd->getType(), ConstOpnd), "and.ra",
|
|
|
|
InsertBefore);
|
|
|
|
I->setDebugLoc(InsertBefore->getDebugLoc());
|
|
|
|
return I;
|
2013-03-30 10:15:01 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Helper function of OptimizeXor(). It tries to simplify "Opnd1 ^ ConstOpnd"
|
|
|
|
// into "R ^ C", where C would be 0, and R is a symbolic value.
|
|
|
|
//
|
|
|
|
// If it was successful, true is returned, and the "R" and "C" is returned
|
|
|
|
// via "Res" and "ConstOpnd", respectively; otherwise, false is returned,
|
|
|
|
// and both "Res" and "ConstOpnd" remain unchanged.
|
2016-04-27 07:39:29 +08:00
|
|
|
bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1,
|
|
|
|
APInt &ConstOpnd, Value *&Res) {
|
2018-07-31 03:41:25 +08:00
|
|
|
// Xor-Rule 1: (x | c1) ^ c2 = (x | c1) ^ (c1 ^ c1) ^ c2
|
2013-03-30 10:15:01 +08:00
|
|
|
// = ((x | c1) ^ c1) ^ (c1 ^ c2)
|
|
|
|
// = (x & ~c1) ^ (c1 ^ c2)
|
|
|
|
// It is useful only when c1 == c2.
|
2017-06-22 03:39:35 +08:00
|
|
|
if (!Opnd1->isOrExpr() || Opnd1->getConstPart().isNullValue())
|
|
|
|
return false;
|
2013-03-30 10:15:01 +08:00
|
|
|
|
2017-06-22 03:39:35 +08:00
|
|
|
if (!Opnd1->getValue()->hasOneUse())
|
|
|
|
return false;
|
2013-03-30 10:15:01 +08:00
|
|
|
|
2017-06-22 03:39:35 +08:00
|
|
|
const APInt &C1 = Opnd1->getConstPart();
|
|
|
|
if (C1 != ConstOpnd)
|
|
|
|
return false;
|
2013-03-30 10:15:01 +08:00
|
|
|
|
2017-06-22 03:39:35 +08:00
|
|
|
Value *X = Opnd1->getSymbolicPart();
|
|
|
|
Res = createAndInstr(I, X, ~C1);
|
|
|
|
// ConstOpnd was C2, now C1 ^ C2.
|
|
|
|
ConstOpnd ^= C1;
|
|
|
|
|
|
|
|
if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue()))
|
|
|
|
RedoInsts.insert(T);
|
|
|
|
return true;
|
2013-03-30 10:15:01 +08:00
|
|
|
}
|
2018-07-31 03:41:25 +08:00
|
|
|
|
2013-03-30 10:15:01 +08:00
|
|
|
// Helper function of OptimizeXor(). It tries to simplify
|
|
|
|
// "Opnd1 ^ Opnd2 ^ ConstOpnd" into "R ^ C", where C would be 0, and R is a
|
2018-07-31 03:41:25 +08:00
|
|
|
// symbolic value.
|
|
|
|
//
|
|
|
|
// If it was successful, true is returned, and the "R" and "C" is returned
|
2013-03-30 10:15:01 +08:00
|
|
|
// via "Res" and "ConstOpnd", respectively (If the entire expression is
|
|
|
|
// evaluated to a constant, the Res is set to NULL); otherwise, false is
|
|
|
|
// returned, and both "Res" and "ConstOpnd" remain unchanged.
|
2016-04-27 07:39:29 +08:00
|
|
|
bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1,
|
|
|
|
XorOpnd *Opnd2, APInt &ConstOpnd,
|
|
|
|
Value *&Res) {
|
2013-03-30 10:15:01 +08:00
|
|
|
Value *X = Opnd1->getSymbolicPart();
|
|
|
|
if (X != Opnd2->getSymbolicPart())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// This many instruction become dead.(At least "Opnd1 ^ Opnd2" will die.)
|
|
|
|
int DeadInstNum = 1;
|
|
|
|
if (Opnd1->getValue()->hasOneUse())
|
|
|
|
DeadInstNum++;
|
|
|
|
if (Opnd2->getValue()->hasOneUse())
|
|
|
|
DeadInstNum++;
|
|
|
|
|
|
|
|
// Xor-Rule 2:
|
|
|
|
// (x | c1) ^ (x & c2)
|
|
|
|
// = (x|c1) ^ (x&c2) ^ (c1 ^ c1) = ((x|c1) ^ c1) ^ (x & c2) ^ c1
|
|
|
|
// = (x & ~c1) ^ (x & c2) ^ c1 // Xor-Rule 1
|
|
|
|
// = (x & c3) ^ c1, where c3 = ~c1 ^ c2 // Xor-rule 3
|
|
|
|
//
|
|
|
|
if (Opnd1->isOrExpr() != Opnd2->isOrExpr()) {
|
|
|
|
if (Opnd2->isOrExpr())
|
|
|
|
std::swap(Opnd1, Opnd2);
|
|
|
|
|
2013-04-28 02:02:12 +08:00
|
|
|
const APInt &C1 = Opnd1->getConstPart();
|
|
|
|
const APInt &C2 = Opnd2->getConstPart();
|
2013-03-30 10:15:01 +08:00
|
|
|
APInt C3((~C1) ^ C2);
|
|
|
|
|
|
|
|
// Do not increase code size!
|
2017-06-19 02:15:38 +08:00
|
|
|
if (!C3.isNullValue() && !C3.isAllOnesValue()) {
|
|
|
|
int NewInstNum = ConstOpnd.getBoolValue() ? 1 : 2;
|
2013-03-30 10:15:01 +08:00
|
|
|
if (NewInstNum > DeadInstNum)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
Res = createAndInstr(I, X, C3);
|
|
|
|
ConstOpnd ^= C1;
|
|
|
|
} else if (Opnd1->isOrExpr()) {
|
|
|
|
// Xor-Rule 3: (x | c1) ^ (x | c2) = (x & c3) ^ c3 where c3 = c1 ^ c2
|
|
|
|
//
|
2013-04-28 02:02:12 +08:00
|
|
|
const APInt &C1 = Opnd1->getConstPart();
|
|
|
|
const APInt &C2 = Opnd2->getConstPart();
|
2013-03-30 10:15:01 +08:00
|
|
|
APInt C3 = C1 ^ C2;
|
2018-07-31 03:41:25 +08:00
|
|
|
|
2013-03-30 10:15:01 +08:00
|
|
|
// Do not increase code size
|
2017-06-19 02:15:38 +08:00
|
|
|
if (!C3.isNullValue() && !C3.isAllOnesValue()) {
|
|
|
|
int NewInstNum = ConstOpnd.getBoolValue() ? 1 : 2;
|
2013-03-30 10:15:01 +08:00
|
|
|
if (NewInstNum > DeadInstNum)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
Res = createAndInstr(I, X, C3);
|
|
|
|
ConstOpnd ^= C3;
|
|
|
|
} else {
|
|
|
|
// Xor-Rule 4: (x & c1) ^ (x & c2) = (x & (c1^c2))
|
|
|
|
//
|
2013-04-28 02:02:12 +08:00
|
|
|
const APInt &C1 = Opnd1->getConstPart();
|
|
|
|
const APInt &C2 = Opnd2->getConstPart();
|
2013-03-30 10:15:01 +08:00
|
|
|
APInt C3 = C1 ^ C2;
|
|
|
|
Res = createAndInstr(I, X, C3);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Put the original operands in the Redo list; hope they will be deleted
|
|
|
|
// as dead code.
|
|
|
|
if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue()))
|
|
|
|
RedoInsts.insert(T);
|
|
|
|
if (Instruction *T = dyn_cast<Instruction>(Opnd2->getValue()))
|
|
|
|
RedoInsts.insert(T);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Optimize a series of operands to an 'xor' instruction. If it can be reduced
|
|
|
|
/// to a single Value, it is returned, otherwise the Ops list is mutated as
|
|
|
|
/// necessary.
|
2016-04-27 07:39:29 +08:00
|
|
|
Value *ReassociatePass::OptimizeXor(Instruction *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2013-03-30 10:15:01 +08:00
|
|
|
if (Value *V = OptimizeAndOrXor(Instruction::Xor, Ops))
|
|
|
|
return V;
|
2018-07-31 03:41:25 +08:00
|
|
|
|
2013-03-30 10:15:01 +08:00
|
|
|
if (Ops.size() == 1)
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2013-03-30 10:15:01 +08:00
|
|
|
|
|
|
|
SmallVector<XorOpnd, 8> Opnds;
|
2013-04-09 06:00:43 +08:00
|
|
|
SmallVector<XorOpnd*, 8> OpndPtrs;
|
2017-06-22 00:07:09 +08:00
|
|
|
Type *Ty = Ops[0].Op->getType();
|
|
|
|
APInt ConstOpnd(Ty->getScalarSizeInBits(), 0);
|
2013-03-30 10:15:01 +08:00
|
|
|
|
|
|
|
// Step 1: Convert ValueEntry to XorOpnd
|
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
|
|
|
Value *V = Ops[i].Op;
|
2017-06-22 00:07:09 +08:00
|
|
|
const APInt *C;
|
|
|
|
// TODO: Support non-splat vectors.
|
2018-10-23 05:37:02 +08:00
|
|
|
if (match(V, m_APInt(C))) {
|
2017-06-22 00:07:09 +08:00
|
|
|
ConstOpnd ^= *C;
|
|
|
|
} else {
|
2013-03-30 10:15:01 +08:00
|
|
|
XorOpnd O(V);
|
|
|
|
O.setSymbolicRank(getRank(O.getSymbolicPart()));
|
|
|
|
Opnds.push_back(O);
|
2017-06-22 00:07:09 +08:00
|
|
|
}
|
2013-03-30 10:15:01 +08:00
|
|
|
}
|
|
|
|
|
2013-04-09 06:00:43 +08:00
|
|
|
// NOTE: From this point on, do *NOT* add/delete element to/from "Opnds".
|
|
|
|
// It would otherwise invalidate the "Opnds"'s iterator, and hence invalidate
|
|
|
|
// the "OpndPtrs" as well. For the similar reason, do not fuse this loop
|
|
|
|
// with the previous loop --- the iterator of the "Opnds" may be invalidated
|
|
|
|
// when new elements are added to the vector.
|
|
|
|
for (unsigned i = 0, e = Opnds.size(); i != e; ++i)
|
|
|
|
OpndPtrs.push_back(&Opnds[i]);
|
|
|
|
|
2013-03-30 10:15:01 +08:00
|
|
|
// Step 2: Sort the Xor-Operands in a way such that the operands containing
|
|
|
|
// the same symbolic value cluster together. For instance, the input operand
|
|
|
|
// sequence ("x | 123", "y & 456", "x & 789") will be sorted into:
|
|
|
|
// ("x | 123", "x & 789", "y & 456").
|
2016-04-27 07:32:00 +08:00
|
|
|
//
|
|
|
|
// The purpose is twofold:
|
|
|
|
// 1) Cluster together the operands sharing the same symbolic-value.
|
|
|
|
// 2) Operand having smaller symbolic-value-rank is permuted earlier, which
|
|
|
|
// could potentially shorten crital path, and expose more loop-invariants.
|
|
|
|
// Note that values' rank are basically defined in RPO order (FIXME).
|
|
|
|
// So, if Rank(X) < Rank(Y) < Rank(Z), it means X is defined earlier
|
|
|
|
// than Y which is defined earlier than Z. Permute "x | 1", "Y & 2",
|
|
|
|
// "z" in the order of X-Y-Z is better than any other orders.
|
|
|
|
std::stable_sort(OpndPtrs.begin(), OpndPtrs.end(),
|
|
|
|
[](XorOpnd *LHS, XorOpnd *RHS) {
|
|
|
|
return LHS->getSymbolicRank() < RHS->getSymbolicRank();
|
|
|
|
});
|
2013-03-30 10:15:01 +08:00
|
|
|
|
|
|
|
// Step 3: Combine adjacent operands
|
2014-04-25 13:29:35 +08:00
|
|
|
XorOpnd *PrevOpnd = nullptr;
|
2013-03-30 10:15:01 +08:00
|
|
|
bool Changed = false;
|
|
|
|
for (unsigned i = 0, e = Opnds.size(); i < e; i++) {
|
2013-04-09 06:00:43 +08:00
|
|
|
XorOpnd *CurrOpnd = OpndPtrs[i];
|
2013-03-30 10:15:01 +08:00
|
|
|
// The combined value
|
|
|
|
Value *CV;
|
|
|
|
|
|
|
|
// Step 3.1: Try simplifying "CurrOpnd ^ ConstOpnd"
|
2017-06-19 02:15:38 +08:00
|
|
|
if (!ConstOpnd.isNullValue() &&
|
|
|
|
CombineXorOpnd(I, CurrOpnd, ConstOpnd, CV)) {
|
2013-03-30 10:15:01 +08:00
|
|
|
Changed = true;
|
|
|
|
if (CV)
|
|
|
|
*CurrOpnd = XorOpnd(CV);
|
|
|
|
else {
|
|
|
|
CurrOpnd->Invalidate();
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!PrevOpnd || CurrOpnd->getSymbolicPart() != PrevOpnd->getSymbolicPart()) {
|
|
|
|
PrevOpnd = CurrOpnd;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// step 3.2: When previous and current operands share the same symbolic
|
2018-07-31 03:41:25 +08:00
|
|
|
// value, try to simplify "PrevOpnd ^ CurrOpnd ^ ConstOpnd"
|
2013-03-30 10:15:01 +08:00
|
|
|
if (CombineXorOpnd(I, CurrOpnd, PrevOpnd, ConstOpnd, CV)) {
|
|
|
|
// Remove previous operand
|
|
|
|
PrevOpnd->Invalidate();
|
|
|
|
if (CV) {
|
|
|
|
*CurrOpnd = XorOpnd(CV);
|
|
|
|
PrevOpnd = CurrOpnd;
|
|
|
|
} else {
|
|
|
|
CurrOpnd->Invalidate();
|
2014-04-25 13:29:35 +08:00
|
|
|
PrevOpnd = nullptr;
|
2013-03-30 10:15:01 +08:00
|
|
|
}
|
|
|
|
Changed = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Step 4: Reassemble the Ops
|
|
|
|
if (Changed) {
|
|
|
|
Ops.clear();
|
|
|
|
for (unsigned int i = 0, e = Opnds.size(); i < e; i++) {
|
|
|
|
XorOpnd &O = Opnds[i];
|
|
|
|
if (O.isInvalid())
|
|
|
|
continue;
|
|
|
|
ValueEntry VE(getRank(O.getValue()), O.getValue());
|
|
|
|
Ops.push_back(VE);
|
|
|
|
}
|
2017-06-19 02:15:38 +08:00
|
|
|
if (!ConstOpnd.isNullValue()) {
|
2017-06-22 00:07:09 +08:00
|
|
|
Value *C = ConstantInt::get(Ty, ConstOpnd);
|
2013-03-30 10:15:01 +08:00
|
|
|
ValueEntry VE(getRank(C), C);
|
|
|
|
Ops.push_back(VE);
|
|
|
|
}
|
2017-06-22 00:07:09 +08:00
|
|
|
unsigned Sz = Ops.size();
|
2013-03-30 10:15:01 +08:00
|
|
|
if (Sz == 1)
|
|
|
|
return Ops.back().Op;
|
2017-06-22 00:07:09 +08:00
|
|
|
if (Sz == 0) {
|
|
|
|
assert(ConstOpnd.isNullValue());
|
|
|
|
return ConstantInt::get(Ty, ConstOpnd);
|
2013-03-30 10:15:01 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2013-03-30 10:15:01 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Optimize a series of operands to an 'add' instruction. This
|
2009-12-31 15:59:34 +08:00
|
|
|
/// optimizes based on identities. If it can be reduced to a single Value, it
|
|
|
|
/// is returned, otherwise the Ops list is mutated as necessary.
|
2016-04-27 07:39:29 +08:00
|
|
|
Value *ReassociatePass::OptimizeAdd(Instruction *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2009-12-31 15:59:34 +08:00
|
|
|
// Scan the operand lists looking for X and -X pairs. If we find any, we
|
2014-05-31 23:01:54 +08:00
|
|
|
// can simplify expressions like X+-X == 0 and X+~X ==-1. While we're at it,
|
|
|
|
// scan for any
|
2010-01-01 03:24:52 +08:00
|
|
|
// duplicates. We want to canonicalize Y+Y+Y+Z -> 3*Y+Z.
|
2014-05-31 23:01:54 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
2010-01-01 03:24:52 +08:00
|
|
|
Value *TheOp = Ops[i].Op;
|
|
|
|
// Check to see if we've seen this operand before. If so, we factor all
|
2010-01-01 03:49:01 +08:00
|
|
|
// instances of the operand together. Due to our sorting criteria, we know
|
|
|
|
// that these need to be next to each other in the vector.
|
|
|
|
if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) {
|
|
|
|
// Rescan the list, remove all instances of this operand from the expr.
|
2010-01-01 03:24:52 +08:00
|
|
|
unsigned NumFound = 0;
|
2010-01-01 03:49:01 +08:00
|
|
|
do {
|
|
|
|
Ops.erase(Ops.begin()+i);
|
2010-01-01 03:24:52 +08:00
|
|
|
++NumFound;
|
2010-01-01 03:49:01 +08:00
|
|
|
} while (i != Ops.size() && Ops[i].Op == TheOp);
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\nFACTORING [" << NumFound << "]: " << *TheOp
|
|
|
|
<< '\n');
|
2010-01-01 03:24:52 +08:00
|
|
|
++NumFactor;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// Insert a new multiply.
|
2014-08-14 23:23:01 +08:00
|
|
|
Type *Ty = TheOp->getType();
|
2015-03-14 04:53:01 +08:00
|
|
|
Constant *C = Ty->isIntOrIntVectorTy() ?
|
|
|
|
ConstantInt::get(Ty, NumFound) : ConstantFP::get(Ty, NumFound);
|
2014-08-14 23:23:01 +08:00
|
|
|
Instruction *Mul = CreateMul(TheOp, C, "factor", I, I);
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// Now that we have inserted a multiply, optimize it. This allows us to
|
|
|
|
// handle cases that require multiple factoring steps, such as this:
|
|
|
|
// (X*2) + (X*2) + (X*2) -> (X*2)*3 -> X*6
|
2014-08-14 23:23:01 +08:00
|
|
|
RedoInsts.insert(Mul);
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// If every add operand was a duplicate, return the multiply.
|
|
|
|
if (Ops.empty())
|
|
|
|
return Mul;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// Otherwise, we had some input that didn't have the dupe, such as
|
|
|
|
// "A + A + B" -> "A*2 + B". Add the new multiply to the list of
|
|
|
|
// things being added by this operation.
|
|
|
|
Ops.insert(Ops.begin(), ValueEntry(getRank(Mul), Mul));
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 03:49:01 +08:00
|
|
|
--i;
|
|
|
|
e = Ops.size();
|
|
|
|
continue;
|
2010-01-01 03:24:52 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2014-05-31 23:01:54 +08:00
|
|
|
// Check for X and -X or X and ~X in the operand list.
|
2018-10-23 23:55:06 +08:00
|
|
|
Value *X;
|
|
|
|
if (!match(TheOp, m_Neg(m_Value(X))) && !match(TheOp, m_Not(m_Value(X))) &&
|
2018-10-24 22:45:18 +08:00
|
|
|
!match(TheOp, m_FNeg(m_Value(X))))
|
2009-12-31 15:59:34 +08:00
|
|
|
continue;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
unsigned FoundX = FindInOperandList(Ops, i, X);
|
|
|
|
if (FoundX == i)
|
|
|
|
continue;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
// Remove X and -X from the operand list.
|
2014-08-14 23:23:01 +08:00
|
|
|
if (Ops.size() == 2 &&
|
2018-10-24 22:45:18 +08:00
|
|
|
(match(TheOp, m_Neg(m_Value())) || match(TheOp, m_FNeg(m_Value()))))
|
2009-12-31 15:59:34 +08:00
|
|
|
return Constant::getNullValue(X->getType());
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2014-05-31 23:01:54 +08:00
|
|
|
// Remove X and ~X from the operand list.
|
2018-10-23 23:55:06 +08:00
|
|
|
if (Ops.size() == 2 && match(TheOp, m_Not(m_Value())))
|
2014-05-31 23:01:54 +08:00
|
|
|
return Constant::getAllOnesValue(X->getType());
|
|
|
|
|
2009-12-31 15:59:34 +08:00
|
|
|
Ops.erase(Ops.begin()+i);
|
|
|
|
if (i < FoundX)
|
|
|
|
--FoundX;
|
|
|
|
else
|
|
|
|
--i; // Need to back up an extra one.
|
|
|
|
Ops.erase(Ops.begin()+FoundX);
|
|
|
|
++NumAnnihil;
|
|
|
|
--i; // Revisit element.
|
|
|
|
e -= 2; // Removed two elements.
|
2014-05-31 23:01:54 +08:00
|
|
|
|
|
|
|
// if X and ~X we append -1 to the operand list.
|
2018-10-23 23:55:06 +08:00
|
|
|
if (match(TheOp, m_Not(m_Value()))) {
|
2014-05-31 23:01:54 +08:00
|
|
|
Value *V = Constant::getAllOnesValue(X->getType());
|
|
|
|
Ops.insert(Ops.end(), ValueEntry(getRank(V), V));
|
|
|
|
e += 1;
|
|
|
|
}
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// Scan the operand list, checking to see if there are any common factors
|
|
|
|
// between operands. Consider something like A*A+A*B*C+D. We would like to
|
|
|
|
// reassociate this to A*(A+B*C)+D, which reduces the number of multiplies.
|
|
|
|
// To efficiently find this, we count the number of times a factor occurs
|
|
|
|
// for any ADD operands that are MULs.
|
|
|
|
DenseMap<Value*, unsigned> FactorOccurrences;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4)
|
|
|
|
// where they are actually the same multiply.
|
|
|
|
unsigned MaxOcc = 0;
|
2014-04-25 13:29:35 +08:00
|
|
|
Value *MaxOccVal = nullptr;
|
2010-01-01 02:17:13 +08:00
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
|
2014-08-14 23:23:01 +08:00
|
|
|
BinaryOperator *BOp =
|
|
|
|
isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul);
|
2012-05-25 20:03:02 +08:00
|
|
|
if (!BOp)
|
2010-01-01 02:17:13 +08:00
|
|
|
continue;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// Compute all of the factors of this added value.
|
|
|
|
SmallVector<Value*, 8> Factors;
|
2017-02-09 01:45:27 +08:00
|
|
|
FindSingleUseMultiplyFactors(BOp, Factors);
|
2010-01-01 02:17:13 +08:00
|
|
|
assert(Factors.size() > 1 && "Bad linearize!");
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// Add one to FactorOccurrences for each unique factor in this op.
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
SmallPtrSet<Value*, 8> Duplicates;
|
|
|
|
for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
|
|
|
|
Value *Factor = Factors[i];
|
2014-11-19 15:49:26 +08:00
|
|
|
if (!Duplicates.insert(Factor).second)
|
2014-08-14 23:23:01 +08:00
|
|
|
continue;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
unsigned Occ = ++FactorOccurrences[Factor];
|
2014-08-14 23:23:01 +08:00
|
|
|
if (Occ > MaxOcc) {
|
|
|
|
MaxOcc = Occ;
|
|
|
|
MaxOccVal = Factor;
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
// If Factor is a negative constant, add the negated value as a factor
|
|
|
|
// because we can percolate the negate out. Watch for minint, which
|
|
|
|
// cannot be positivified.
|
2014-08-14 23:23:01 +08:00
|
|
|
if (ConstantInt *CI = dyn_cast<ConstantInt>(Factor)) {
|
2011-07-15 14:08:15 +08:00
|
|
|
if (CI->isNegative() && !CI->isMinValue(true)) {
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
Factor = ConstantInt::get(CI->getContext(), -CI->getValue());
|
[Reassociate] Add negated value of negative constant to the Duplicates list.
In OptimizeAdd, we scan the operand list to see if there are any common factors
between operands that can be factored out to reduce the number of multiplies
(e.g., 'A*A+A*B*C+D' -> 'A*(A+B*C)+D'). For each operand of the operand list, we
only consider unique factors (which is tracked by the Duplicate set). Now if we
find a factor that is a negative constant, we add the negated value as a factor
as well, because we can percolate the negate out. However, we mistakenly don't
add this negated constant to the Duplicates set.
Consider the expression A*2*-2 + B. Obviously, nothing to factor.
For the added value A*2*-2 we over count 2 as a factor without this change,
which causes the assert reported in PR30256. The problem is that this code is
assuming that all the multiply operands of the add are already reassociated.
This change avoids the issue by making OptimizeAdd tolerate multiplies which
haven't been completely optimized; this sort of works, but we're doing wasted
work: we'll end up revisiting the add later anyway.
Another possible approach would be to enforce RPO iteration order more strongly.
If we have RedoInsts, we process them immediately in RPO order, rather than
waiting until we've finished processing the whole function. Intuitively, it
seems like the natural approach: reassociation works on expression trees, so
the optimization only works in one direction. That said, I'm not sure how
practical that is given the current Reassociate; the "optimal" form for an
expression depends on its use list (see all the uses of "user_back()"), so
Reassociate is really an iterative optimization of sorts, so any changes here
would probably get messy.
PR30256
Differential Revision: https://reviews.llvm.org/D30228
llvm-svn: 296003
2017-02-24 02:49:03 +08:00
|
|
|
if (!Duplicates.insert(Factor).second)
|
|
|
|
continue;
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
unsigned Occ = ++FactorOccurrences[Factor];
|
2014-08-14 23:23:01 +08:00
|
|
|
if (Occ > MaxOcc) {
|
|
|
|
MaxOcc = Occ;
|
|
|
|
MaxOccVal = Factor;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else if (ConstantFP *CF = dyn_cast<ConstantFP>(Factor)) {
|
|
|
|
if (CF->isNegative()) {
|
|
|
|
APFloat F(CF->getValueAPF());
|
|
|
|
F.changeSign();
|
|
|
|
Factor = ConstantFP::get(CF->getContext(), F);
|
[Reassociate] Add negated value of negative constant to the Duplicates list.
In OptimizeAdd, we scan the operand list to see if there are any common factors
between operands that can be factored out to reduce the number of multiplies
(e.g., 'A*A+A*B*C+D' -> 'A*(A+B*C)+D'). For each operand of the operand list, we
only consider unique factors (which is tracked by the Duplicate set). Now if we
find a factor that is a negative constant, we add the negated value as a factor
as well, because we can percolate the negate out. However, we mistakenly don't
add this negated constant to the Duplicates set.
Consider the expression A*2*-2 + B. Obviously, nothing to factor.
For the added value A*2*-2 we over count 2 as a factor without this change,
which causes the assert reported in PR30256. The problem is that this code is
assuming that all the multiply operands of the add are already reassociated.
This change avoids the issue by making OptimizeAdd tolerate multiplies which
haven't been completely optimized; this sort of works, but we're doing wasted
work: we'll end up revisiting the add later anyway.
Another possible approach would be to enforce RPO iteration order more strongly.
If we have RedoInsts, we process them immediately in RPO order, rather than
waiting until we've finished processing the whole function. Intuitively, it
seems like the natural approach: reassociation works on expression trees, so
the optimization only works in one direction. That said, I'm not sure how
practical that is given the current Reassociate; the "optimal" form for an
expression depends on its use list (see all the uses of "user_back()"), so
Reassociate is really an iterative optimization of sorts, so any changes here
would probably get messy.
PR30256
Differential Revision: https://reviews.llvm.org/D30228
llvm-svn: 296003
2017-02-24 02:49:03 +08:00
|
|
|
if (!Duplicates.insert(Factor).second)
|
|
|
|
continue;
|
2014-08-14 23:23:01 +08:00
|
|
|
unsigned Occ = ++FactorOccurrences[Factor];
|
|
|
|
if (Occ > MaxOcc) {
|
|
|
|
MaxOcc = Occ;
|
|
|
|
MaxOccVal = Factor;
|
|
|
|
}
|
When factoring multiply expressions across adds, factor both
positive and negative forms of constants together. This
allows us to compile:
int foo(int x, int y) {
return (x-y) + (x-y) + (x-y);
}
into:
_foo: ## @foo
subl %esi, %edi
leal (%rdi,%rdi,2), %eax
ret
instead of (where the 3 and -3 were not factored):
_foo:
imull $-3, 8(%esp), %ecx
imull $3, 4(%esp), %eax
addl %ecx, %eax
ret
this started out as:
movl 12(%ebp), %ecx
imull $3, 8(%ebp), %eax
subl %ecx, %eax
subl %ecx, %eax
subl %ecx, %eax
ret
This comes from PR5359.
llvm-svn: 92381
2010-01-01 09:13:15 +08:00
|
|
|
}
|
2014-08-14 23:23:01 +08:00
|
|
|
}
|
2010-01-01 02:17:13 +08:00
|
|
|
}
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// If any factor occurred more than one time, we can pull it out.
|
|
|
|
if (MaxOcc > 1) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\nFACTORING [" << MaxOcc << "]: " << *MaxOccVal
|
|
|
|
<< '\n');
|
2010-01-01 02:17:13 +08:00
|
|
|
++NumFactor;
|
|
|
|
|
|
|
|
// Create a new instruction that uses the MaxOccVal twice. If we don't do
|
|
|
|
// this, we could otherwise run into situations where removing a factor
|
2012-05-03 07:43:23 +08:00
|
|
|
// from an expression will drop a use of maxocc, and this can cause
|
2010-01-01 02:17:13 +08:00
|
|
|
// RemoveFactorFromExpression on successive values to behave differently.
|
2014-08-14 23:23:01 +08:00
|
|
|
Instruction *DummyInst =
|
2015-03-14 04:53:01 +08:00
|
|
|
I->getType()->isIntOrIntVectorTy()
|
2014-08-14 23:23:01 +08:00
|
|
|
? BinaryOperator::CreateAdd(MaxOccVal, MaxOccVal)
|
|
|
|
: BinaryOperator::CreateFAdd(MaxOccVal, MaxOccVal);
|
|
|
|
|
2017-05-02 01:07:49 +08:00
|
|
|
SmallVector<WeakTrackingVH, 4> NewMulOps;
|
2011-01-26 18:08:38 +08:00
|
|
|
for (unsigned i = 0; i != Ops.size(); ++i) {
|
2010-01-09 14:01:36 +08:00
|
|
|
// Only try to remove factors from expressions we're allowed to.
|
2014-08-14 23:23:01 +08:00
|
|
|
BinaryOperator *BOp =
|
|
|
|
isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul);
|
2012-05-25 20:03:02 +08:00
|
|
|
if (!BOp)
|
2010-01-09 14:01:36 +08:00
|
|
|
continue;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
if (Value *V = RemoveFactorFromExpression(Ops[i].Op, MaxOccVal)) {
|
2011-01-26 18:08:38 +08:00
|
|
|
// The factorized operand may occur several times. Convert them all in
|
|
|
|
// one fell swoop.
|
|
|
|
for (unsigned j = Ops.size(); j != i;) {
|
|
|
|
--j;
|
|
|
|
if (Ops[j].Op == Ops[i].Op) {
|
|
|
|
NewMulOps.push_back(V);
|
|
|
|
Ops.erase(Ops.begin()+j);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
--i;
|
2010-01-01 02:17:13 +08:00
|
|
|
}
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// No need for extra uses anymore.
|
[IR] De-virtualize ~Value to save a vptr
Summary:
Implements PR889
Removing the virtual table pointer from Value saves 1% of RSS when doing
LTO of llc on Linux. The impact on time was positive, but too noisy to
conclusively say that performance improved. Here is a link to the
spreadsheet with the original data:
https://docs.google.com/spreadsheets/d/1F4FHir0qYnV0MEp2sYYp_BuvnJgWlWPhWOwZ6LbW7W4/edit?usp=sharing
This change makes it invalid to directly delete a Value, User, or
Instruction pointer. Instead, such code can be rewritten to a null check
and a call Value::deleteValue(). Value objects tend to have their
lifetimes managed through iplist, so for the most part, this isn't a big
deal. However, there are some places where LLVM deletes values, and
those places had to be migrated to deleteValue. I have also created
llvm::unique_value, which has a custom deleter, so it can be used in
place of std::unique_ptr<Value>.
I had to add the "DerivedUser" Deleter escape hatch for MemorySSA, which
derives from User outside of lib/IR. Code in IR cannot include MemorySSA
headers or call the MemoryAccess object destructors without introducing
a circular dependency, so we need some level of indirection.
Unfortunately, no class derived from User may have any virtual methods,
because adding a virtual method would break User::getHungOffOperands(),
which assumes that it can find the use list immediately prior to the
User object. I've added a static_assert to the appropriate OperandTraits
templates to help people avoid this trap.
Reviewers: chandlerc, mehdi_amini, pete, dberlin, george.burgess.iv
Reviewed By: chandlerc
Subscribers: krytarowski, eraman, george.burgess.iv, mzolotukhin, Prazek, nlewycky, hans, inglorion, pcc, tejohnson, dberlin, llvm-commits
Differential Revision: https://reviews.llvm.org/D31261
llvm-svn: 303362
2017-05-19 01:24:10 +08:00
|
|
|
DummyInst->deleteValue();
|
2010-01-09 01:51:48 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
unsigned NumAddedValues = NewMulOps.size();
|
|
|
|
Value *V = EmitAddTreeOfValues(I, NewMulOps);
|
2010-01-09 01:51:48 +08:00
|
|
|
|
2010-01-01 03:24:52 +08:00
|
|
|
// Now that we have inserted the add tree, optimize it. This allows us to
|
|
|
|
// handle cases that require multiple factoring steps, such as this:
|
2010-01-01 02:17:13 +08:00
|
|
|
// A*A*B + A*A*C --> A*(A*B+A*C) --> A*(A*(B+C))
|
2010-01-01 02:18:46 +08:00
|
|
|
assert(NumAddedValues > 1 && "Each occurrence should contribute a value");
|
2010-01-09 01:51:48 +08:00
|
|
|
(void)NumAddedValues;
|
2012-06-09 04:15:33 +08:00
|
|
|
if (Instruction *VI = dyn_cast<Instruction>(V))
|
|
|
|
RedoInsts.insert(VI);
|
2010-01-01 03:24:52 +08:00
|
|
|
|
|
|
|
// Create the multiply.
|
2017-11-10 02:14:24 +08:00
|
|
|
Instruction *V2 = CreateMul(V, MaxOccVal, "reass.mul", I, I);
|
2010-01-01 03:24:52 +08:00
|
|
|
|
2010-01-01 03:49:01 +08:00
|
|
|
// Rerun associate on the multiply in case the inner expression turned into
|
|
|
|
// a multiply. We want to make sure that we keep things in canonical form.
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(V2);
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:17:13 +08:00
|
|
|
// If every add operand included the factor (e.g. "A*B + A*C"), then the
|
|
|
|
// entire result expression is just the multiply "A*(B+C)".
|
|
|
|
if (Ops.empty())
|
|
|
|
return V2;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2010-01-01 02:18:46 +08:00
|
|
|
// Otherwise, we had some input that didn't have the factor, such as
|
2010-01-01 02:17:13 +08:00
|
|
|
// "A*B + A*C + D" -> "A*(B+C) + D". Add the new multiply to the list of
|
2010-01-01 02:18:46 +08:00
|
|
|
// things being added by this operation.
|
2010-01-01 02:17:13 +08:00
|
|
|
Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2));
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2009-12-31 15:59:34 +08:00
|
|
|
}
|
2006-03-04 17:31:13 +08:00
|
|
|
|
2018-05-01 23:54:18 +08:00
|
|
|
/// Build up a vector of value/power pairs factoring a product.
|
2012-04-26 13:30:30 +08:00
|
|
|
///
|
|
|
|
/// Given a series of multiplication operands, build a vector of factors and
|
|
|
|
/// the powers each is raised to when forming the final product. Sort them in
|
|
|
|
/// the order of descending power.
|
|
|
|
///
|
|
|
|
/// (x*x) -> [(x, 2)]
|
|
|
|
/// ((x*x)*x) -> [(x, 3)]
|
|
|
|
/// ((((x*y)*x)*y)*x) -> [(x, 3), (y, 2)]
|
|
|
|
///
|
|
|
|
/// \returns Whether any factors have a power greater than one.
|
2017-06-20 00:23:43 +08:00
|
|
|
static bool collectMultiplyFactors(SmallVectorImpl<ValueEntry> &Ops,
|
|
|
|
SmallVectorImpl<Factor> &Factors) {
|
2012-05-25 20:03:02 +08:00
|
|
|
// FIXME: Have Ops be (ValueEntry, Multiplicity) pairs, simplifying this.
|
|
|
|
// Compute the sum of powers of simplifiable factors.
|
2012-04-26 13:30:30 +08:00
|
|
|
unsigned FactorPowerSum = 0;
|
2012-05-25 20:03:02 +08:00
|
|
|
for (unsigned Idx = 1, Size = Ops.size(); Idx < Size; ++Idx) {
|
|
|
|
Value *Op = Ops[Idx-1].Op;
|
|
|
|
|
|
|
|
// Count the number of occurrences of this value.
|
|
|
|
unsigned Count = 1;
|
|
|
|
for (; Idx < Size && Ops[Idx].Op == Op; ++Idx)
|
|
|
|
++Count;
|
2012-04-26 13:30:30 +08:00
|
|
|
// Track for simplification all factors which occur 2 or more times.
|
2012-05-25 20:03:02 +08:00
|
|
|
if (Count > 1)
|
|
|
|
FactorPowerSum += Count;
|
2012-04-26 13:30:30 +08:00
|
|
|
}
|
2012-05-25 20:03:02 +08:00
|
|
|
|
2012-04-26 13:30:30 +08:00
|
|
|
// We can only simplify factors if the sum of the powers of our simplifiable
|
|
|
|
// factors is 4 or higher. When that is the case, we will *always* have
|
|
|
|
// a simplification. This is an important invariant to prevent cyclicly
|
|
|
|
// trying to simplify already minimal formations.
|
|
|
|
if (FactorPowerSum < 4)
|
|
|
|
return false;
|
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Now gather the simplifiable factors, removing them from Ops.
|
|
|
|
FactorPowerSum = 0;
|
|
|
|
for (unsigned Idx = 1; Idx < Ops.size(); ++Idx) {
|
|
|
|
Value *Op = Ops[Idx-1].Op;
|
2012-04-26 13:30:30 +08:00
|
|
|
|
2012-05-25 20:03:02 +08:00
|
|
|
// Count the number of occurrences of this value.
|
|
|
|
unsigned Count = 1;
|
|
|
|
for (; Idx < Ops.size() && Ops[Idx].Op == Op; ++Idx)
|
|
|
|
++Count;
|
|
|
|
if (Count == 1)
|
|
|
|
continue;
|
2012-06-02 18:20:22 +08:00
|
|
|
// Move an even number of occurrences to Factors.
|
2012-05-25 20:03:02 +08:00
|
|
|
Count &= ~1U;
|
|
|
|
Idx -= Count;
|
|
|
|
FactorPowerSum += Count;
|
|
|
|
Factors.push_back(Factor(Op, Count));
|
|
|
|
Ops.erase(Ops.begin()+Idx, Ops.begin()+Idx+Count);
|
2012-04-26 13:30:30 +08:00
|
|
|
}
|
2012-05-25 20:03:02 +08:00
|
|
|
|
2012-04-26 13:30:30 +08:00
|
|
|
// None of the adjustments above should have reduced the sum of factor powers
|
|
|
|
// below our mininum of '4'.
|
|
|
|
assert(FactorPowerSum >= 4);
|
|
|
|
|
2016-04-27 06:22:18 +08:00
|
|
|
std::stable_sort(Factors.begin(), Factors.end(),
|
|
|
|
[](const Factor &LHS, const Factor &RHS) {
|
|
|
|
return LHS.Power > RHS.Power;
|
|
|
|
});
|
2012-04-26 13:30:30 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-05-01 23:54:18 +08:00
|
|
|
/// Build a tree of multiplies, computing the product of Ops.
|
2012-04-26 13:30:30 +08:00
|
|
|
static Value *buildMultiplyTree(IRBuilder<> &Builder,
|
|
|
|
SmallVectorImpl<Value*> &Ops) {
|
|
|
|
if (Ops.size() == 1)
|
|
|
|
return Ops.back();
|
|
|
|
|
|
|
|
Value *LHS = Ops.pop_back_val();
|
|
|
|
do {
|
2015-03-14 04:53:01 +08:00
|
|
|
if (LHS->getType()->isIntOrIntVectorTy())
|
2014-08-14 23:23:01 +08:00
|
|
|
LHS = Builder.CreateMul(LHS, Ops.pop_back_val());
|
|
|
|
else
|
|
|
|
LHS = Builder.CreateFMul(LHS, Ops.pop_back_val());
|
2012-04-26 13:30:30 +08:00
|
|
|
} while (!Ops.empty());
|
|
|
|
|
|
|
|
return LHS;
|
|
|
|
}
|
|
|
|
|
2018-05-01 23:54:18 +08:00
|
|
|
/// Build a minimal multiplication DAG for (a^x)*(b^y)*(c^z)*...
|
2012-04-26 13:30:30 +08:00
|
|
|
///
|
|
|
|
/// Given a vector of values raised to various powers, where no two values are
|
|
|
|
/// equal and the powers are sorted in decreasing order, compute the minimal
|
|
|
|
/// DAG of multiplies to compute the final product, and return that product
|
|
|
|
/// value.
|
2016-04-27 07:39:29 +08:00
|
|
|
Value *
|
|
|
|
ReassociatePass::buildMinimalMultiplyDAG(IRBuilder<> &Builder,
|
|
|
|
SmallVectorImpl<Factor> &Factors) {
|
2012-04-26 13:30:30 +08:00
|
|
|
assert(Factors[0].Power);
|
|
|
|
SmallVector<Value *, 4> OuterProduct;
|
|
|
|
for (unsigned LastIdx = 0, Idx = 1, Size = Factors.size();
|
|
|
|
Idx < Size && Factors[Idx].Power > 0; ++Idx) {
|
|
|
|
if (Factors[Idx].Power != Factors[LastIdx].Power) {
|
|
|
|
LastIdx = Idx;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// We want to multiply across all the factors with the same power so that
|
|
|
|
// we can raise them to that power as a single entity. Build a mini tree
|
|
|
|
// for that.
|
|
|
|
SmallVector<Value *, 4> InnerProduct;
|
|
|
|
InnerProduct.push_back(Factors[LastIdx].Base);
|
|
|
|
do {
|
|
|
|
InnerProduct.push_back(Factors[Idx].Base);
|
|
|
|
++Idx;
|
|
|
|
} while (Idx < Size && Factors[Idx].Power == Factors[LastIdx].Power);
|
|
|
|
|
|
|
|
// Reset the base value of the first factor to the new expression tree.
|
|
|
|
// We'll remove all the factors with the same power in a second pass.
|
2012-06-09 04:15:33 +08:00
|
|
|
Value *M = Factors[LastIdx].Base = buildMultiplyTree(Builder, InnerProduct);
|
|
|
|
if (Instruction *MI = dyn_cast<Instruction>(M))
|
|
|
|
RedoInsts.insert(MI);
|
2012-04-26 13:30:30 +08:00
|
|
|
|
|
|
|
LastIdx = Idx;
|
|
|
|
}
|
|
|
|
// Unique factors with equal powers -- we've folded them into the first one's
|
|
|
|
// base.
|
|
|
|
Factors.erase(std::unique(Factors.begin(), Factors.end(),
|
2016-04-27 06:22:18 +08:00
|
|
|
[](const Factor &LHS, const Factor &RHS) {
|
|
|
|
return LHS.Power == RHS.Power;
|
|
|
|
}),
|
2012-04-26 13:30:30 +08:00
|
|
|
Factors.end());
|
|
|
|
|
|
|
|
// Iteratively collect the base of each factor with an add power into the
|
|
|
|
// outer product, and halve each power in preparation for squaring the
|
|
|
|
// expression.
|
|
|
|
for (unsigned Idx = 0, Size = Factors.size(); Idx != Size; ++Idx) {
|
|
|
|
if (Factors[Idx].Power & 1)
|
|
|
|
OuterProduct.push_back(Factors[Idx].Base);
|
|
|
|
Factors[Idx].Power >>= 1;
|
|
|
|
}
|
|
|
|
if (Factors[0].Power) {
|
|
|
|
Value *SquareRoot = buildMinimalMultiplyDAG(Builder, Factors);
|
|
|
|
OuterProduct.push_back(SquareRoot);
|
|
|
|
OuterProduct.push_back(SquareRoot);
|
|
|
|
}
|
|
|
|
if (OuterProduct.size() == 1)
|
|
|
|
return OuterProduct.front();
|
|
|
|
|
2012-05-08 20:16:05 +08:00
|
|
|
Value *V = buildMultiplyTree(Builder, OuterProduct);
|
|
|
|
return V;
|
2012-04-26 13:30:30 +08:00
|
|
|
}
|
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
Value *ReassociatePass::OptimizeMul(BinaryOperator *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2012-04-26 13:30:30 +08:00
|
|
|
// We can only optimize the multiplies when there is a chain of more than
|
|
|
|
// three, such that a balanced tree might require fewer total multiplies.
|
|
|
|
if (Ops.size() < 4)
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2012-04-26 13:30:30 +08:00
|
|
|
|
|
|
|
// Try to turn linear trees of multiplies without other uses of the
|
|
|
|
// intermediate stages into minimal multiply DAGs with perfect sub-expression
|
|
|
|
// re-use.
|
|
|
|
SmallVector<Factor, 4> Factors;
|
|
|
|
if (!collectMultiplyFactors(Ops, Factors))
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr; // All distinct factors, so nothing left for us to do.
|
2012-04-26 13:30:30 +08:00
|
|
|
|
|
|
|
IRBuilder<> Builder(I);
|
2016-11-23 04:23:04 +08:00
|
|
|
// The reassociate transformation for FP operations is performed only
|
|
|
|
// if unsafe algebra is permitted by FastMathFlags. Propagate those flags
|
|
|
|
// to the newly generated operations.
|
|
|
|
if (auto FPI = dyn_cast<FPMathOperator>(I))
|
|
|
|
Builder.setFastMathFlags(FPI->getFastMathFlags());
|
|
|
|
|
2012-04-26 13:30:30 +08:00
|
|
|
Value *V = buildMinimalMultiplyDAG(Builder, Factors);
|
|
|
|
if (Ops.empty())
|
|
|
|
return V;
|
|
|
|
|
|
|
|
ValueEntry NewEntry = ValueEntry(getRank(V), V);
|
|
|
|
Ops.insert(std::lower_bound(Ops.begin(), Ops.end(), NewEntry), NewEntry);
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2012-04-26 13:30:30 +08:00
|
|
|
}
|
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
Value *ReassociatePass::OptimizeExpression(BinaryOperator *I,
|
|
|
|
SmallVectorImpl<ValueEntry> &Ops) {
|
2005-05-08 08:19:31 +08:00
|
|
|
// Now that we have the linearized expression tree, try to optimize it.
|
|
|
|
// Start by folding any constants that we found.
|
2014-04-25 13:29:35 +08:00
|
|
|
Constant *Cst = nullptr;
|
2006-03-04 17:31:13 +08:00
|
|
|
unsigned Opcode = I->getOpcode();
|
2012-11-15 17:58:38 +08:00
|
|
|
while (!Ops.empty() && isa<Constant>(Ops.back().Op)) {
|
|
|
|
Constant *C = cast<Constant>(Ops.pop_back_val().Op);
|
|
|
|
Cst = Cst ? ConstantExpr::get(Opcode, C, Cst) : C;
|
|
|
|
}
|
|
|
|
// If there was nothing but constants then we are done.
|
|
|
|
if (Ops.empty())
|
|
|
|
return Cst;
|
|
|
|
|
|
|
|
// Put the combined constant back at the end of the operand list, except if
|
|
|
|
// there is no point. For example, an add of 0 gets dropped here, while a
|
|
|
|
// multiplication by zero turns the whole expression into zero.
|
|
|
|
if (Cst && Cst != ConstantExpr::getBinOpIdentity(Opcode, I->getType())) {
|
|
|
|
if (Cst == ConstantExpr::getBinOpAbsorber(Opcode, I->getType()))
|
|
|
|
return Cst;
|
|
|
|
Ops.push_back(ValueEntry(0, Cst));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (Ops.size() == 1) return Ops[0].Op;
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2009-12-31 15:33:14 +08:00
|
|
|
// Handle destructive annihilation due to identities between elements in the
|
2005-05-08 08:19:31 +08:00
|
|
|
// argument list here.
|
2012-04-26 13:30:30 +08:00
|
|
|
unsigned NumOps = Ops.size();
|
2005-05-09 02:59:37 +08:00
|
|
|
switch (Opcode) {
|
|
|
|
default: break;
|
|
|
|
case Instruction::And:
|
|
|
|
case Instruction::Or:
|
2009-12-31 15:59:34 +08:00
|
|
|
if (Value *Result = OptimizeAndOrXor(Opcode, Ops))
|
|
|
|
return Result;
|
2005-05-09 02:59:37 +08:00
|
|
|
break;
|
|
|
|
|
2013-03-30 10:15:01 +08:00
|
|
|
case Instruction::Xor:
|
|
|
|
if (Value *Result = OptimizeXor(I, Ops))
|
|
|
|
return Result;
|
|
|
|
break;
|
|
|
|
|
2012-04-26 13:30:30 +08:00
|
|
|
case Instruction::Add:
|
2014-08-14 23:23:01 +08:00
|
|
|
case Instruction::FAdd:
|
2010-01-01 02:17:13 +08:00
|
|
|
if (Value *Result = OptimizeAdd(I, Ops))
|
2009-12-31 15:59:34 +08:00
|
|
|
return Result;
|
2012-04-26 13:30:30 +08:00
|
|
|
break;
|
2006-03-04 17:31:13 +08:00
|
|
|
|
2012-04-26 13:30:30 +08:00
|
|
|
case Instruction::Mul:
|
2014-08-14 23:23:01 +08:00
|
|
|
case Instruction::FMul:
|
2012-04-26 13:30:30 +08:00
|
|
|
if (Value *Result = OptimizeMul(I, Ops))
|
|
|
|
return Result;
|
2005-05-09 02:59:37 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2012-06-09 04:15:33 +08:00
|
|
|
if (Ops.size() != NumOps)
|
2006-03-04 17:31:13 +08:00
|
|
|
return OptimizeExpression(I, Ops);
|
2014-04-25 13:29:35 +08:00
|
|
|
return nullptr;
|
2005-05-08 08:19:31 +08:00
|
|
|
}
|
|
|
|
|
2016-01-05 03:48:14 +08:00
|
|
|
// Remove dead instructions and if any operands are trivially dead add them to
|
|
|
|
// Insts so they will be removed as well.
|
2018-05-03 01:59:16 +08:00
|
|
|
void ReassociatePass::RecursivelyEraseDeadInsts(Instruction *I,
|
|
|
|
OrderedSet &Insts) {
|
2016-01-05 03:48:14 +08:00
|
|
|
assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!");
|
|
|
|
SmallVector<Value *, 4> Ops(I->op_begin(), I->op_end());
|
|
|
|
ValueRankMap.erase(I);
|
|
|
|
Insts.remove(I);
|
|
|
|
RedoInsts.remove(I);
|
|
|
|
I->eraseFromParent();
|
|
|
|
for (auto Op : Ops)
|
|
|
|
if (Instruction *OpInst = dyn_cast<Instruction>(Op))
|
|
|
|
if (OpInst->use_empty())
|
|
|
|
Insts.insert(OpInst);
|
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Zap the given instruction, adding interesting operands to the work list.
|
2016-04-27 07:39:29 +08:00
|
|
|
void ReassociatePass::EraseInst(Instruction *I) {
|
2012-06-09 04:15:33 +08:00
|
|
|
assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!");
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Erasing dead inst: "; I->dump());
|
2016-08-30 21:58:35 +08:00
|
|
|
|
2012-06-09 04:15:33 +08:00
|
|
|
SmallVector<Value*, 8> Ops(I->op_begin(), I->op_end());
|
|
|
|
// Erase the dead instruction.
|
|
|
|
ValueRankMap.erase(I);
|
2012-11-13 08:08:49 +08:00
|
|
|
RedoInsts.remove(I);
|
2012-06-09 04:15:33 +08:00
|
|
|
I->eraseFromParent();
|
|
|
|
// Optimize its operands.
|
2012-06-15 16:37:50 +08:00
|
|
|
SmallPtrSet<Instruction *, 8> Visited; // Detect self-referential nodes.
|
2012-06-09 04:15:33 +08:00
|
|
|
for (unsigned i = 0, e = Ops.size(); i != e; ++i)
|
|
|
|
if (Instruction *Op = dyn_cast<Instruction>(Ops[i])) {
|
|
|
|
// If this is a node in an expression tree, climb to the expression root
|
|
|
|
// and add that since that's where optimization actually happens.
|
|
|
|
unsigned Opcode = Op->getOpcode();
|
2014-03-09 11:16:01 +08:00
|
|
|
while (Op->hasOneUse() && Op->user_back()->getOpcode() == Opcode &&
|
2014-11-19 15:49:26 +08:00
|
|
|
Visited.insert(Op).second)
|
2014-03-09 11:16:01 +08:00
|
|
|
Op = Op->user_back();
|
2018-05-11 23:45:36 +08:00
|
|
|
|
|
|
|
// The instruction we're going to push may be coming from a
|
|
|
|
// dead block, and Reassociate skips the processing of unreachable
|
|
|
|
// blocks because it's a waste of time and also because it can
|
|
|
|
// lead to infinite loop due to LLVM's non-standard definition
|
|
|
|
// of dominance.
|
|
|
|
if (ValueRankMap.find(Op) != ValueRankMap.end())
|
|
|
|
RedoInsts.insert(Op);
|
2012-06-09 04:15:33 +08:00
|
|
|
}
|
2017-06-27 13:32:13 +08:00
|
|
|
|
|
|
|
MadeChange = true;
|
2012-06-09 04:15:33 +08:00
|
|
|
}
|
|
|
|
|
2014-11-12 06:58:35 +08:00
|
|
|
// Canonicalize expressions of the following form:
|
|
|
|
// x + (-Constant * y) -> x - (Constant * y)
|
|
|
|
// x - (-Constant * y) -> x + (Constant * y)
|
2016-04-27 07:39:29 +08:00
|
|
|
Instruction *ReassociatePass::canonicalizeNegConstExpr(Instruction *I) {
|
2014-11-12 06:58:35 +08:00
|
|
|
if (!I->hasOneUse() || I->getType()->isVectorTy())
|
|
|
|
return nullptr;
|
|
|
|
|
2015-05-28 14:16:39 +08:00
|
|
|
// Must be a fmul or fdiv instruction.
|
2014-11-12 06:58:35 +08:00
|
|
|
unsigned Opcode = I->getOpcode();
|
2015-05-28 14:16:39 +08:00
|
|
|
if (Opcode != Instruction::FMul && Opcode != Instruction::FDiv)
|
2014-11-12 06:58:35 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2015-05-28 14:16:39 +08:00
|
|
|
auto *C0 = dyn_cast<ConstantFP>(I->getOperand(0));
|
|
|
|
auto *C1 = dyn_cast<ConstantFP>(I->getOperand(1));
|
|
|
|
|
|
|
|
// Both operands are constant, let it get constant folded away.
|
|
|
|
if (C0 && C1)
|
2014-11-12 06:58:35 +08:00
|
|
|
return nullptr;
|
|
|
|
|
2015-05-28 14:16:39 +08:00
|
|
|
ConstantFP *CF = C0 ? C0 : C1;
|
|
|
|
|
|
|
|
// Must have one constant operand.
|
|
|
|
if (!CF)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Must be a negative ConstantFP.
|
|
|
|
if (!CF->isNegative())
|
2014-11-12 06:58:35 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// User must be a binary operator with one or more uses.
|
|
|
|
Instruction *User = I->user_back();
|
2017-05-17 06:38:40 +08:00
|
|
|
if (!isa<BinaryOperator>(User) || User->use_empty())
|
2014-11-12 06:58:35 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
unsigned UserOpcode = User->getOpcode();
|
2015-05-28 14:16:39 +08:00
|
|
|
if (UserOpcode != Instruction::FAdd && UserOpcode != Instruction::FSub)
|
2014-11-12 06:58:35 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Subtraction is not commutative. Explicitly, the following transform is
|
|
|
|
// not valid: (-Constant * y) - x -> x + (Constant * y)
|
|
|
|
if (!User->isCommutative() && User->getOperand(1) != I)
|
|
|
|
return nullptr;
|
|
|
|
|
2017-08-23 22:10:06 +08:00
|
|
|
// Don't canonicalize x + (-Constant * y) -> x - (Constant * y), if the
|
|
|
|
// resulting subtract will be broken up later. This can get us into an
|
|
|
|
// infinite loop during reassociation.
|
|
|
|
if (UserOpcode == Instruction::FAdd && ShouldBreakUpSubtract(User))
|
|
|
|
return nullptr;
|
|
|
|
|
2014-08-21 18:45:30 +08:00
|
|
|
// Change the sign of the constant.
|
2015-05-28 14:16:39 +08:00
|
|
|
APFloat Val = CF->getValueAPF();
|
|
|
|
Val.changeSign();
|
|
|
|
I->setOperand(C0 ? 0 : 1, ConstantFP::get(CF->getContext(), Val));
|
2014-11-12 06:58:35 +08:00
|
|
|
|
|
|
|
// Canonicalize I to RHS to simplify the next bit of logic. E.g.,
|
|
|
|
// ((-Const*y) + x) -> (x + (-Const*y)).
|
|
|
|
if (User->getOperand(0) == I && User->isCommutative())
|
|
|
|
cast<BinaryOperator>(User)->swapOperands();
|
|
|
|
|
|
|
|
Value *Op0 = User->getOperand(0);
|
|
|
|
Value *Op1 = User->getOperand(1);
|
|
|
|
BinaryOperator *NI;
|
2015-05-28 14:16:39 +08:00
|
|
|
switch (UserOpcode) {
|
2014-11-12 06:58:35 +08:00
|
|
|
default:
|
|
|
|
llvm_unreachable("Unexpected Opcode!");
|
|
|
|
case Instruction::FAdd:
|
|
|
|
NI = BinaryOperator::CreateFSub(Op0, Op1);
|
|
|
|
NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags());
|
|
|
|
break;
|
|
|
|
case Instruction::FSub:
|
|
|
|
NI = BinaryOperator::CreateFAdd(Op0, Op1);
|
|
|
|
NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags());
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
NI->insertBefore(User);
|
|
|
|
NI->setName(User->getName());
|
|
|
|
User->replaceAllUsesWith(NI);
|
2014-08-21 18:45:30 +08:00
|
|
|
NI->setDebugLoc(I->getDebugLoc());
|
2014-11-12 06:58:35 +08:00
|
|
|
RedoInsts.insert(I);
|
2014-08-21 18:45:30 +08:00
|
|
|
MadeChange = true;
|
2014-11-12 06:58:35 +08:00
|
|
|
return NI;
|
2014-08-21 18:45:30 +08:00
|
|
|
}
|
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
/// Inspect and optimize the given instruction. Note that erasing
|
2012-06-09 04:15:33 +08:00
|
|
|
/// instructions is not allowed.
|
2016-04-27 07:39:29 +08:00
|
|
|
void ReassociatePass::OptimizeInst(Instruction *I) {
|
2012-06-09 04:15:33 +08:00
|
|
|
// Only consider operations that we understand.
|
|
|
|
if (!isa<BinaryOperator>(I))
|
|
|
|
return;
|
|
|
|
|
2014-08-14 23:23:01 +08:00
|
|
|
if (I->getOpcode() == Instruction::Shl && isa<ConstantInt>(I->getOperand(1)))
|
2012-06-09 04:15:33 +08:00
|
|
|
// If an operand of this shift is a reassociable multiply, or if the shift
|
|
|
|
// is used by a reassociable multiply or add, turn into a multiply.
|
|
|
|
if (isReassociableOp(I->getOperand(0), Instruction::Mul) ||
|
|
|
|
(I->hasOneUse() &&
|
2014-03-09 11:16:01 +08:00
|
|
|
(isReassociableOp(I->user_back(), Instruction::Mul) ||
|
|
|
|
isReassociableOp(I->user_back(), Instruction::Add)))) {
|
2012-06-09 04:15:33 +08:00
|
|
|
Instruction *NI = ConvertShiftToMul(I);
|
|
|
|
RedoInsts.insert(I);
|
2011-04-12 08:11:56 +08:00
|
|
|
MadeChange = true;
|
2012-06-09 04:15:33 +08:00
|
|
|
I = NI;
|
2011-04-12 08:11:56 +08:00
|
|
|
}
|
2005-05-10 11:39:25 +08:00
|
|
|
|
2014-11-12 06:58:35 +08:00
|
|
|
// Canonicalize negative constants out of expressions.
|
|
|
|
if (Instruction *Res = canonicalizeNegConstExpr(I))
|
|
|
|
I = Res;
|
|
|
|
|
2014-11-15 01:09:19 +08:00
|
|
|
// Commute binary operators, to canonicalize the order of their operands.
|
|
|
|
// This can potentially expose more CSE opportunities, and makes writing other
|
|
|
|
// transformations simpler.
|
|
|
|
if (I->isCommutative())
|
|
|
|
canonicalizeOperands(I);
|
|
|
|
|
[IR] redefine 'UnsafeAlgebra' / 'reassoc' fast-math-flags and add 'trans' fast-math-flag
As discussed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/107104.html
and again more recently:
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118118.html
...this is a step in cleaning up our fast-math-flags implementation in IR to better match
the capabilities of both clang's user-visible flags and the backend's flags for SDNode.
As proposed in the above threads, we're replacing the 'UnsafeAlgebra' bit (which had the
'umbrella' meaning that all flags are set) with a new bit that only applies to algebraic
reassociation - 'AllowReassoc'.
We're also adding a bit to allow approximations for library functions called 'ApproxFunc'
(this was initially proposed as 'libm' or similar).
...and we're out of bits. 7 bits ought to be enough for anyone, right? :) FWIW, I did
look at getting this out of SubclassOptionalData via SubclassData (spacious 16-bits),
but that's apparently already used for other purposes. Also, I don't think we can just
add a field to FPMathOperator because Operator is not intended to be instantiated.
We'll defer movement of FMF to another day.
We keep the 'fast' keyword. I thought about removing that, but seeing IR like this:
%f.fast = fadd reassoc nnan ninf nsz arcp contract afn float %op1, %op2
...made me think we want to keep the shortcut synonym.
Finally, this change is binary incompatible with existing IR as seen in the
compatibility tests. This statement:
"Newer releases can ignore features from older releases, but they cannot miscompile
them. For example, if nsw is ever replaced with something else, dropping it would be
a valid way to upgrade the IR."
( http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility )
...provides the flexibility we want to make this change without requiring a new IR
version. Ie, we're not loosening the FP strictness of existing IR. At worst, we will
fail to optimize some previously 'fast' code because it's no longer recognized as
'fast'. This should get fixed as we audit/squash all of the uses of 'isFast()'.
Note: an inter-dependent clang commit to use the new API name should closely follow
commit.
Differential Revision: https://reviews.llvm.org/D39304
llvm-svn: 317488
2017-11-07 00:27:15 +08:00
|
|
|
// Don't optimize floating-point instructions unless they are 'fast'.
|
|
|
|
if (I->getType()->isFPOrFPVectorTy() && !I->isFast())
|
2014-11-15 01:09:19 +08:00
|
|
|
return;
|
2012-05-08 04:47:23 +08:00
|
|
|
|
2011-04-12 08:11:56 +08:00
|
|
|
// Do not reassociate boolean (i1) expressions. We want to preserve the
|
|
|
|
// original order of evaluation for short-circuited comparisons that
|
|
|
|
// SimplifyCFG has folded to AND/OR expressions. If the expression
|
|
|
|
// is not further optimized, it is likely to be transformed back to a
|
|
|
|
// short-circuited form for code gen, and the source order may have been
|
|
|
|
// optimized for the most likely conditions.
|
2012-06-09 04:15:33 +08:00
|
|
|
if (I->getType()->isIntegerTy(1))
|
2011-04-12 08:11:56 +08:00
|
|
|
return;
|
2010-02-05 07:32:37 +08:00
|
|
|
|
2011-04-12 08:11:56 +08:00
|
|
|
// If this is a subtract instruction which is not already in negate form,
|
|
|
|
// see if we can convert it to X+-Y.
|
2012-06-09 04:15:33 +08:00
|
|
|
if (I->getOpcode() == Instruction::Sub) {
|
|
|
|
if (ShouldBreakUpSubtract(I)) {
|
2015-11-17 02:07:30 +08:00
|
|
|
Instruction *NI = BreakUpSubtract(I, RedoInsts);
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(I);
|
2011-04-12 08:11:56 +08:00
|
|
|
MadeChange = true;
|
2012-06-09 04:15:33 +08:00
|
|
|
I = NI;
|
2018-10-23 23:55:06 +08:00
|
|
|
} else if (match(I, m_Neg(m_Value()))) {
|
2011-04-12 08:11:56 +08:00
|
|
|
// Otherwise, this is a negation. See if the operand is a multiply tree
|
|
|
|
// and if this is not an inner node of a multiply tree.
|
2012-06-09 04:15:33 +08:00
|
|
|
if (isReassociableOp(I->getOperand(1), Instruction::Mul) &&
|
|
|
|
(!I->hasOneUse() ||
|
2014-03-09 11:16:01 +08:00
|
|
|
!isReassociableOp(I->user_back(), Instruction::Mul))) {
|
2012-06-09 04:15:33 +08:00
|
|
|
Instruction *NI = LowerNegateToMultiply(I);
|
2015-11-17 02:07:30 +08:00
|
|
|
// If the negate was simplified, revisit the users to see if we can
|
|
|
|
// reassociate further.
|
|
|
|
for (User *U : NI->users()) {
|
|
|
|
if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U))
|
|
|
|
RedoInsts.insert(Tmp);
|
|
|
|
}
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(I);
|
2008-02-18 10:18:25 +08:00
|
|
|
MadeChange = true;
|
2012-06-09 04:15:33 +08:00
|
|
|
I = NI;
|
2005-05-07 12:08:02 +08:00
|
|
|
}
|
2005-05-09 05:28:52 +08:00
|
|
|
}
|
2014-08-14 23:23:01 +08:00
|
|
|
} else if (I->getOpcode() == Instruction::FSub) {
|
|
|
|
if (ShouldBreakUpSubtract(I)) {
|
2015-11-17 02:07:30 +08:00
|
|
|
Instruction *NI = BreakUpSubtract(I, RedoInsts);
|
2014-08-14 23:23:01 +08:00
|
|
|
RedoInsts.insert(I);
|
|
|
|
MadeChange = true;
|
|
|
|
I = NI;
|
2018-10-24 22:45:18 +08:00
|
|
|
} else if (match(I, m_FNeg(m_Value()))) {
|
2014-08-14 23:23:01 +08:00
|
|
|
// Otherwise, this is a negation. See if the operand is a multiply tree
|
|
|
|
// and if this is not an inner node of a multiply tree.
|
|
|
|
if (isReassociableOp(I->getOperand(1), Instruction::FMul) &&
|
|
|
|
(!I->hasOneUse() ||
|
|
|
|
!isReassociableOp(I->user_back(), Instruction::FMul))) {
|
2015-11-17 02:07:30 +08:00
|
|
|
// If the negate was simplified, revisit the users to see if we can
|
|
|
|
// reassociate further.
|
2014-08-14 23:23:01 +08:00
|
|
|
Instruction *NI = LowerNegateToMultiply(I);
|
2015-11-17 02:07:30 +08:00
|
|
|
for (User *U : NI->users()) {
|
|
|
|
if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U))
|
|
|
|
RedoInsts.insert(Tmp);
|
|
|
|
}
|
2014-08-14 23:23:01 +08:00
|
|
|
RedoInsts.insert(I);
|
|
|
|
MadeChange = true;
|
|
|
|
I = NI;
|
|
|
|
}
|
|
|
|
}
|
2011-04-12 08:11:56 +08:00
|
|
|
}
|
2002-11-01 01:12:59 +08:00
|
|
|
|
2012-06-09 04:15:33 +08:00
|
|
|
// If this instruction is an associative binary operator, process it.
|
|
|
|
if (!I->isAssociative()) return;
|
|
|
|
BinaryOperator *BO = cast<BinaryOperator>(I);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2011-04-12 08:11:56 +08:00
|
|
|
// If this is an interior node of a reassociable tree, ignore it until we
|
|
|
|
// get to the root of the tree, to avoid N^2 analysis.
|
2012-07-23 21:44:15 +08:00
|
|
|
unsigned Opcode = BO->getOpcode();
|
2015-11-17 02:07:30 +08:00
|
|
|
if (BO->hasOneUse() && BO->user_back()->getOpcode() == Opcode) {
|
|
|
|
// During the initial run we will get to the root of the tree.
|
|
|
|
// But if we get here while we are redoing instructions, there is no
|
|
|
|
// guarantee that the root will be visited. So Redo later
|
2016-01-08 07:22:55 +08:00
|
|
|
if (BO->user_back() != BO &&
|
|
|
|
BO->getParent() == BO->user_back()->getParent())
|
2015-11-17 02:07:30 +08:00
|
|
|
RedoInsts.insert(BO->user_back());
|
2011-04-12 08:11:56 +08:00
|
|
|
return;
|
2015-11-17 02:07:30 +08:00
|
|
|
}
|
2005-05-08 05:59:39 +08:00
|
|
|
|
2012-05-03 07:43:23 +08:00
|
|
|
// If this is an add tree that is used by a sub instruction, ignore it
|
2011-04-12 08:11:56 +08:00
|
|
|
// until we process the subtract.
|
2012-06-09 04:15:33 +08:00
|
|
|
if (BO->hasOneUse() && BO->getOpcode() == Instruction::Add &&
|
2014-03-09 11:16:01 +08:00
|
|
|
cast<Instruction>(BO->user_back())->getOpcode() == Instruction::Sub)
|
2011-04-12 08:11:56 +08:00
|
|
|
return;
|
2014-08-14 23:23:01 +08:00
|
|
|
if (BO->hasOneUse() && BO->getOpcode() == Instruction::FAdd &&
|
|
|
|
cast<Instruction>(BO->user_back())->getOpcode() == Instruction::FSub)
|
|
|
|
return;
|
2005-09-02 15:07:58 +08:00
|
|
|
|
2012-06-09 04:15:33 +08:00
|
|
|
ReassociateExpression(BO);
|
2006-03-14 15:11:11 +08:00
|
|
|
}
|
2005-05-09 04:09:57 +08:00
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
void ReassociatePass::ReassociateExpression(BinaryOperator *I) {
|
2010-01-01 03:24:52 +08:00
|
|
|
// First, walk the expression tree, linearizing the tree, collecting the
|
|
|
|
// operand information.
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
SmallVector<RepeatedValue, 8> Tree;
|
|
|
|
MadeChange |= LinearizeExprTree(I, Tree);
|
2010-01-01 02:40:32 +08:00
|
|
|
SmallVector<ValueEntry, 8> Ops;
|
Now that Reassociate's LinearizeExprTree can look through arbitrary expression
topologies, it is quite possible for a leaf node to have huge multiplicity, for
example: x0 = x*x, x1 = x0*x0, x2 = x1*x1, ... rapidly gives a value which is x
raised to a vast power (the multiplicity, or weight, of x). This patch fixes
the computation of weights by correctly computing them no matter how big they
are, rather than just overflowing and getting a wrong value. It turns out that
the weight for a value never needs more bits to represent than the value itself,
so it is enough to represent weights as APInts of the same bitwidth and do the
right overflow-avoiding dance steps when computing weights. As a side-effect it
reduces the number of multiplies needed in some cases of large powers. While
there, in view of external uses (eg by the vectorizer) I made LinearizeExprTree
static, pushing the rank computation out into users. This is progress towards
fixing PR13021.
llvm-svn: 158358
2012-06-12 22:33:56 +08:00
|
|
|
Ops.reserve(Tree.size());
|
|
|
|
for (unsigned i = 0, e = Tree.size(); i != e; ++i) {
|
|
|
|
RepeatedValue E = Tree[i];
|
|
|
|
Ops.append(E.second.getZExtValue(),
|
|
|
|
ValueEntry(getRank(E.first), E.first));
|
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "RAIn:\t"; PrintOps(I, Ops); dbgs() << '\n');
|
2012-05-26 15:47:48 +08:00
|
|
|
|
2006-03-14 15:11:11 +08:00
|
|
|
// Now that we have linearized the tree to a list and have gathered all of
|
|
|
|
// the operands and their ranks, sort the operands by their rank. Use a
|
|
|
|
// stable_sort so that values with equal ranks will have their relative
|
|
|
|
// positions maintained (and so the compiler is deterministic). Note that
|
|
|
|
// this sorts so that the highest ranking values end up at the beginning of
|
|
|
|
// the vector.
|
|
|
|
std::stable_sort(Ops.begin(), Ops.end());
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2015-04-23 02:04:46 +08:00
|
|
|
// Now that we have the expression tree in a convenient
|
2006-03-14 15:11:11 +08:00
|
|
|
// sorted form, optimize it globally if possible.
|
|
|
|
if (Value *V = OptimizeExpression(I, Ops)) {
|
2012-06-15 16:37:50 +08:00
|
|
|
if (V == I)
|
|
|
|
// Self-referential expression in unreachable code.
|
|
|
|
return;
|
2006-03-14 15:11:11 +08:00
|
|
|
// This expression tree simplified to something that isn't a tree,
|
|
|
|
// eliminate it.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Reassoc to scalar: " << *V << '\n');
|
2006-03-14 15:11:11 +08:00
|
|
|
I->replaceAllUsesWith(V);
|
2011-04-29 06:48:14 +08:00
|
|
|
if (Instruction *VI = dyn_cast<Instruction>(V))
|
2017-08-24 17:05:00 +08:00
|
|
|
if (I->getDebugLoc())
|
|
|
|
VI->setDebugLoc(I->getDebugLoc());
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(I);
|
2010-01-01 01:51:05 +08:00
|
|
|
++NumAnnihil;
|
2012-06-15 16:37:50 +08:00
|
|
|
return;
|
2006-03-14 15:11:11 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2006-03-14 15:11:11 +08:00
|
|
|
// We want to sink immediates as deeply as possible except in the case where
|
|
|
|
// this is a multiply tree used only by an add, and the immediate is a -1.
|
|
|
|
// In this case we reassociate to put the negation on the outside so that we
|
|
|
|
// can fold the negation into the add: (-X)*Y + Z -> Z-X*Y
|
2014-08-14 23:23:01 +08:00
|
|
|
if (I->hasOneUse()) {
|
|
|
|
if (I->getOpcode() == Instruction::Mul &&
|
|
|
|
cast<Instruction>(I->user_back())->getOpcode() == Instruction::Add &&
|
|
|
|
isa<ConstantInt>(Ops.back().Op) &&
|
2017-07-07 02:39:47 +08:00
|
|
|
cast<ConstantInt>(Ops.back().Op)->isMinusOne()) {
|
2014-08-14 23:23:01 +08:00
|
|
|
ValueEntry Tmp = Ops.pop_back_val();
|
|
|
|
Ops.insert(Ops.begin(), Tmp);
|
|
|
|
} else if (I->getOpcode() == Instruction::FMul &&
|
|
|
|
cast<Instruction>(I->user_back())->getOpcode() ==
|
|
|
|
Instruction::FAdd &&
|
|
|
|
isa<ConstantFP>(Ops.back().Op) &&
|
|
|
|
cast<ConstantFP>(Ops.back().Op)->isExactlyValue(-1.0)) {
|
|
|
|
ValueEntry Tmp = Ops.pop_back_val();
|
|
|
|
Ops.insert(Ops.begin(), Tmp);
|
|
|
|
}
|
2006-03-14 15:11:11 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "RAOut:\t"; PrintOps(I, Ops); dbgs() << '\n');
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2006-03-14 15:11:11 +08:00
|
|
|
if (Ops.size() == 1) {
|
2012-06-15 16:37:50 +08:00
|
|
|
if (Ops[0].Op == I)
|
|
|
|
// Self-referential expression in unreachable code.
|
|
|
|
return;
|
|
|
|
|
2006-03-14 15:11:11 +08:00
|
|
|
// This expression tree simplified to something that isn't a tree,
|
|
|
|
// eliminate it.
|
|
|
|
I->replaceAllUsesWith(Ops[0].Op);
|
2011-04-29 06:48:14 +08:00
|
|
|
if (Instruction *OI = dyn_cast<Instruction>(Ops[0].Op))
|
|
|
|
OI->setDebugLoc(I->getDebugLoc());
|
2012-06-09 04:15:33 +08:00
|
|
|
RedoInsts.insert(I);
|
2012-06-15 16:37:50 +08:00
|
|
|
return;
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
2012-05-03 07:43:23 +08:00
|
|
|
|
2017-12-13 03:18:02 +08:00
|
|
|
if (Ops.size() > 2 && Ops.size() <= GlobalReassociateLimit) {
|
|
|
|
// Find the pair with the highest count in the pairmap and move it to the
|
|
|
|
// back of the list so that it can later be CSE'd.
|
|
|
|
// example:
|
|
|
|
// a*b*c*d*e
|
|
|
|
// if c*e is the most "popular" pair, we can express this as
|
|
|
|
// (((c*e)*d)*b)*a
|
|
|
|
unsigned Max = 1;
|
|
|
|
unsigned BestRank = 0;
|
|
|
|
std::pair<unsigned, unsigned> BestPair;
|
|
|
|
unsigned Idx = I->getOpcode() - Instruction::BinaryOpsBegin;
|
|
|
|
for (unsigned i = 0; i < Ops.size() - 1; ++i)
|
|
|
|
for (unsigned j = i + 1; j < Ops.size(); ++j) {
|
|
|
|
unsigned Score = 0;
|
|
|
|
Value *Op0 = Ops[i].Op;
|
|
|
|
Value *Op1 = Ops[j].Op;
|
|
|
|
if (std::less<Value *>()(Op1, Op0))
|
|
|
|
std::swap(Op0, Op1);
|
|
|
|
auto it = PairMap[Idx].find({Op0, Op1});
|
|
|
|
if (it != PairMap[Idx].end())
|
|
|
|
Score += it->second;
|
|
|
|
|
|
|
|
unsigned MaxRank = std::max(Ops[i].Rank, Ops[j].Rank);
|
|
|
|
if (Score > Max || (Score == Max && MaxRank < BestRank)) {
|
|
|
|
BestPair = {i, j};
|
|
|
|
Max = Score;
|
|
|
|
BestRank = MaxRank;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (Max > 1) {
|
|
|
|
auto Op0 = Ops[BestPair.first];
|
|
|
|
auto Op1 = Ops[BestPair.second];
|
|
|
|
Ops.erase(&Ops[BestPair.second]);
|
|
|
|
Ops.erase(&Ops[BestPair.first]);
|
|
|
|
Ops.push_back(Op0);
|
|
|
|
Ops.push_back(Op1);
|
|
|
|
}
|
|
|
|
}
|
2010-01-01 03:24:52 +08:00
|
|
|
// Now that we ordered and optimized the expressions, splat them back into
|
|
|
|
// the expression tree, removing any unneeded nodes.
|
|
|
|
RewriteExprTree(I, Ops);
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|
|
|
|
|
2017-12-13 03:18:02 +08:00
|
|
|
void
|
|
|
|
ReassociatePass::BuildPairMap(ReversePostOrderTraversal<Function *> &RPOT) {
|
|
|
|
// Make a "pairmap" of how often each operand pair occurs.
|
|
|
|
for (BasicBlock *BI : RPOT) {
|
|
|
|
for (Instruction &I : *BI) {
|
|
|
|
if (!I.isAssociative())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Ignore nodes that aren't at the root of trees.
|
|
|
|
if (I.hasOneUse() && I.user_back()->getOpcode() == I.getOpcode())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Collect all operands in a single reassociable expression.
|
|
|
|
// Since Reassociate has already been run once, we can assume things
|
|
|
|
// are already canonical according to Reassociation's regime.
|
|
|
|
SmallVector<Value *, 8> Worklist = { I.getOperand(0), I.getOperand(1) };
|
|
|
|
SmallVector<Value *, 8> Ops;
|
|
|
|
while (!Worklist.empty() && Ops.size() <= GlobalReassociateLimit) {
|
|
|
|
Value *Op = Worklist.pop_back_val();
|
|
|
|
Instruction *OpI = dyn_cast<Instruction>(Op);
|
|
|
|
if (!OpI || OpI->getOpcode() != I.getOpcode() || !OpI->hasOneUse()) {
|
|
|
|
Ops.push_back(Op);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
// Be paranoid about self-referencing expressions in unreachable code.
|
|
|
|
if (OpI->getOperand(0) != OpI)
|
|
|
|
Worklist.push_back(OpI->getOperand(0));
|
|
|
|
if (OpI->getOperand(1) != OpI)
|
|
|
|
Worklist.push_back(OpI->getOperand(1));
|
|
|
|
}
|
|
|
|
// Skip extremely long expressions.
|
|
|
|
if (Ops.size() > GlobalReassociateLimit)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Add all pairwise combinations of operands to the pair map.
|
|
|
|
unsigned BinaryIdx = I.getOpcode() - Instruction::BinaryOpsBegin;
|
|
|
|
SmallSet<std::pair<Value *, Value*>, 32> Visited;
|
|
|
|
for (unsigned i = 0; i < Ops.size() - 1; ++i) {
|
|
|
|
for (unsigned j = i + 1; j < Ops.size(); ++j) {
|
|
|
|
// Canonicalize operand orderings.
|
|
|
|
Value *Op0 = Ops[i];
|
|
|
|
Value *Op1 = Ops[j];
|
|
|
|
if (std::less<Value *>()(Op1, Op0))
|
|
|
|
std::swap(Op0, Op1);
|
|
|
|
if (!Visited.insert({Op0, Op1}).second)
|
|
|
|
continue;
|
|
|
|
auto res = PairMap[BinaryIdx].insert({{Op0, Op1}, 1});
|
|
|
|
if (!res.second)
|
|
|
|
++res.first->second;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-17 08:11:01 +08:00
|
|
|
PreservedAnalyses ReassociatePass::run(Function &F, FunctionAnalysisManager &) {
|
2016-11-02 16:55:19 +08:00
|
|
|
// Get the functions basic blocks in Reverse Post Order. This order is used by
|
|
|
|
// BuildRankMap to pre calculate ranks correctly. It also excludes dead basic
|
|
|
|
// blocks (it has been seen that the analysis in this pass could hang when
|
|
|
|
// analysing dead basic blocks).
|
|
|
|
ReversePostOrderTraversal<Function *> RPOT(&F);
|
|
|
|
|
2016-08-17 23:54:39 +08:00
|
|
|
// Calculate the rank map for F.
|
2016-11-02 16:55:19 +08:00
|
|
|
BuildRankMap(F, RPOT);
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2017-12-13 03:18:02 +08:00
|
|
|
// Build the pair map before running reassociate.
|
|
|
|
// Technically this would be more accurate if we did it after one round
|
|
|
|
// of reassociation, but in practice it doesn't seem to help much on
|
|
|
|
// real-world code, so don't waste the compile time running reassociate
|
|
|
|
// twice.
|
|
|
|
// If a user wants, they could expicitly run reassociate twice in their
|
|
|
|
// pass pipeline for further potential gains.
|
|
|
|
// It might also be possible to update the pair map during runtime, but the
|
|
|
|
// overhead of that may be large if there's many reassociable chains.
|
|
|
|
BuildPairMap(RPOT);
|
|
|
|
|
2005-05-08 05:59:39 +08:00
|
|
|
MadeChange = false;
|
2017-12-13 03:18:02 +08:00
|
|
|
|
|
|
|
// Traverse the same blocks that were analysed by BuildRankMap.
|
2016-11-02 16:55:19 +08:00
|
|
|
for (BasicBlock *BI : RPOT) {
|
|
|
|
assert(RankMap.count(&*BI) && "BB should be ranked.");
|
2012-06-09 04:15:33 +08:00
|
|
|
// Optimize every instruction in the basic block.
|
2016-08-17 23:54:39 +08:00
|
|
|
for (BasicBlock::iterator II = BI->begin(), IE = BI->end(); II != IE;)
|
2015-10-14 03:26:58 +08:00
|
|
|
if (isInstructionTriviallyDead(&*II)) {
|
|
|
|
EraseInst(&*II++);
|
2012-06-09 04:15:33 +08:00
|
|
|
} else {
|
2015-10-14 03:26:58 +08:00
|
|
|
OptimizeInst(&*II);
|
2016-02-22 04:39:50 +08:00
|
|
|
assert(II->getParent() == &*BI && "Moved to a different block!");
|
2012-06-09 04:15:33 +08:00
|
|
|
++II;
|
|
|
|
}
|
|
|
|
|
2016-08-17 23:54:39 +08:00
|
|
|
// Make a copy of all the instructions to be redone so we can remove dead
|
|
|
|
// instructions.
|
2018-05-03 01:59:16 +08:00
|
|
|
OrderedSet ToRedo(RedoInsts);
|
2016-08-17 23:54:39 +08:00
|
|
|
// Iterate over all instructions to be reevaluated and remove trivially dead
|
|
|
|
// instructions. If any operand of the trivially dead instruction becomes
|
|
|
|
// dead mark it for deletion as well. Continue this process until all
|
|
|
|
// trivially dead instructions have been removed.
|
|
|
|
while (!ToRedo.empty()) {
|
|
|
|
Instruction *I = ToRedo.pop_back_val();
|
2016-10-28 10:47:09 +08:00
|
|
|
if (isInstructionTriviallyDead(I)) {
|
2016-08-17 23:54:39 +08:00
|
|
|
RecursivelyEraseDeadInsts(I, ToRedo);
|
2016-10-28 10:47:09 +08:00
|
|
|
MadeChange = true;
|
|
|
|
}
|
2016-08-17 23:54:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Now that we have removed dead instructions, we can reoptimize the
|
|
|
|
// remaining instructions.
|
|
|
|
while (!RedoInsts.empty()) {
|
2018-05-03 01:59:16 +08:00
|
|
|
Instruction *I = RedoInsts.front();
|
|
|
|
RedoInsts.erase(RedoInsts.begin());
|
2016-08-17 23:54:39 +08:00
|
|
|
if (isInstructionTriviallyDead(I))
|
|
|
|
EraseInst(I);
|
|
|
|
else
|
|
|
|
OptimizeInst(I);
|
2011-04-12 08:11:56 +08:00
|
|
|
}
|
2012-06-09 04:15:33 +08:00
|
|
|
}
|
2002-05-09 06:19:27 +08:00
|
|
|
|
2017-12-13 03:18:02 +08:00
|
|
|
// We are done with the rank map and pair map.
|
2012-05-25 20:03:02 +08:00
|
|
|
RankMap.clear();
|
|
|
|
ValueRankMap.clear();
|
2017-12-13 03:18:02 +08:00
|
|
|
for (auto &Entry : PairMap)
|
|
|
|
Entry.clear();
|
2012-05-25 20:03:02 +08:00
|
|
|
|
2016-05-29 08:41:17 +08:00
|
|
|
if (MadeChange) {
|
2017-01-15 14:32:49 +08:00
|
|
|
PreservedAnalyses PA;
|
|
|
|
PA.preserveSet<CFGAnalyses>();
|
2016-05-29 08:41:17 +08:00
|
|
|
PA.preserve<GlobalsAA>();
|
|
|
|
return PA;
|
|
|
|
}
|
2016-04-27 07:39:29 +08:00
|
|
|
|
|
|
|
return PreservedAnalyses::all();
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
2017-10-19 05:46:47 +08:00
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
class ReassociateLegacyPass : public FunctionPass {
|
|
|
|
ReassociatePass Impl;
|
2017-10-19 05:46:47 +08:00
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
public:
|
|
|
|
static char ID; // Pass identification, replacement for typeid
|
2017-10-19 05:46:47 +08:00
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
ReassociateLegacyPass() : FunctionPass(ID) {
|
|
|
|
initializeReassociateLegacyPassPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
|
|
|
|
|
|
|
bool runOnFunction(Function &F) override {
|
|
|
|
if (skipFunction(F))
|
|
|
|
return false;
|
|
|
|
|
2016-06-17 08:11:01 +08:00
|
|
|
FunctionAnalysisManager DummyFAM;
|
|
|
|
auto PA = Impl.run(F, DummyFAM);
|
2016-04-27 07:39:29 +08:00
|
|
|
return !PA.areAllPreserved();
|
|
|
|
}
|
|
|
|
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
|
|
AU.setPreservesCFG();
|
|
|
|
AU.addPreserved<GlobalsAAWrapperPass>();
|
|
|
|
}
|
|
|
|
};
|
2017-10-19 05:46:47 +08:00
|
|
|
|
|
|
|
} // end anonymous namespace
|
2016-04-27 07:39:29 +08:00
|
|
|
|
|
|
|
char ReassociateLegacyPass::ID = 0;
|
2017-10-19 05:46:47 +08:00
|
|
|
|
2016-04-27 07:39:29 +08:00
|
|
|
INITIALIZE_PASS(ReassociateLegacyPass, "reassociate",
|
|
|
|
"Reassociate expressions", false, false)
|
|
|
|
|
|
|
|
// Public interface to the Reassociate pass
|
|
|
|
FunctionPass *llvm::createReassociatePass() {
|
|
|
|
return new ReassociateLegacyPass();
|
2002-05-09 06:19:27 +08:00
|
|
|
}
|