[Support] make report_fatal_error `abort` instead of `exit`
Summary:
This patch could be treated as a rebase of D33960. It also fixes PR35547.
A fix for `llvm/test/Other/close-stderr.ll` is proposed in D68164. Seems
the consensus is that the test is passing by chance and I'm not
sure how important it is for us. So it is removed like in D33960 for now.
The rest of the test fixes are just adding `--crash` flag to `not` tool.
** The reason it fixes PR35547 is
`exit` does cleanup including calling class destructor whereas `abort`
does not do any cleanup. In multithreading environment such as ThinLTO or JIT,
threads may share states which mostly are ManagedStatic<>. If faulting thread
tearing down a class when another thread is using it, there are chances of
memory corruption. This is bad 1. It will stop error reporting like pretty
stack printer; 2. The memory corruption is distracting and nondeterministic in
terms of error message, and corruption type (depending one the timing, it
could be double free, heap free after use, etc.).
Reviewers: rnk, chandlerc, zturner, sepavloff, MaskRay, espindola
Reviewed By: rnk, MaskRay
Subscribers: wuzish, jholewinski, qcolombet, dschuff, jyknight, emaste, sdardis, nemanjai, jvesely, nhaehnle, sbc100, arichardson, jgravelle-google, aheejin, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, jsji, lenary, s.egerton, pzheng, cfe-commits, MaskRay, filcab, davide, MatzeB, mehdi_amini, hiraditya, steven_wu, dexonsmith, rupprecht, seiya, llvm-commits
Tags: #llvm, #clang
Differential Revision: https://reviews.llvm.org/D67847
2020-01-15 14:43:51 +08:00
|
|
|
; RUN: not --crash llc -mtriple=amdgcn-mesa-mesa3d -mcpu=tahiti -o - < %s 2>&1 | FileCheck -enable-var-scope -check-prefix=GFX6ERR %s
|
2019-06-21 05:11:42 +08:00
|
|
|
; RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=hawaii -o - -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,LOOP %s
|
|
|
|
|
; RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=fiji -o - -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,LOOP,GFX8 %s
|
|
|
|
|
; RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx900 -o - -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,NOLOOP %s
|
|
|
|
|
; RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1010 -o - -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,NOLOOP,GFX10 %s
|
|
|
|
|
|
|
|
|
|
; GFX6ERR: LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.ds.gws.sema.release.all
|
|
|
|
|
|
|
|
|
|
; GCN-LABEL: {{^}}gws_sema_release_all_offset0:
|
2019-07-20 04:01:24 +08:00
|
|
|
; NOLOOP-DAG: s_mov_b32 m0, 0{{$}}
|
|
|
|
|
; NOLOOP: ds_gws_sema_release_all gds{{$}}
|
2019-06-21 05:11:42 +08:00
|
|
|
|
2019-07-20 04:01:24 +08:00
|
|
|
; LOOP: s_mov_b32 m0, 0{{$}}
|
2019-06-21 05:11:42 +08:00
|
|
|
; LOOP: [[LOOP:BB[0-9]+_[0-9]+]]:
|
|
|
|
|
; LOOP-NEXT: s_setreg_imm32_b32 hwreg(HW_REG_TRAPSTS, 8, 1), 0
|
|
|
|
|
; GFX8-NEXT: s_nop 0
|
2019-07-20 04:01:24 +08:00
|
|
|
; LOOP-NEXT: ds_gws_sema_release_all gds
|
2019-06-21 05:11:42 +08:00
|
|
|
; LOOP-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
|
; LOOP-NEXT: s_getreg_b32 [[GETREG:s[0-9]+]], hwreg(HW_REG_TRAPSTS, 8, 1)
|
|
|
|
|
; LOOP-NEXT: s_cmp_lg_u32 [[GETREG]], 0
|
|
|
|
|
; LOOP-NEXT: s_cbranch_scc1 [[LOOP]]
|
|
|
|
|
define amdgpu_kernel void @gws_sema_release_all_offset0(i32 %val) #0 {
|
|
|
|
|
call void @llvm.amdgcn.ds.gws.sema.release.all(i32 0)
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
declare void @llvm.amdgcn.ds.gws.sema.release.all(i32) #0
|
|
|
|
|
|
|
|
|
|
attributes #0 = { convergent inaccessiblememonly nounwind }
|