2019-03-25 20:36:30 +08:00
|
|
|
//===--- ClangTidyCheck.h - clang-tidy --------------------------*- C++ -*-===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDYCHECK_H
|
|
|
|
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDYCHECK_H
|
|
|
|
|
|
|
|
#include "ClangTidyDiagnosticConsumer.h"
|
|
|
|
#include "ClangTidyOptions.h"
|
|
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
#include "clang/Basic/Diagnostic.h"
|
|
|
|
#include "clang/Basic/SourceManager.h"
|
2020-04-08 02:53:52 +08:00
|
|
|
#include "llvm/ADT/Optional.h"
|
2019-03-25 20:36:30 +08:00
|
|
|
#include "llvm/ADT/StringExtras.h"
|
2020-04-08 02:53:52 +08:00
|
|
|
#include "llvm/Support/Error.h"
|
2019-03-25 20:36:30 +08:00
|
|
|
#include <memory>
|
|
|
|
#include <type_traits>
|
|
|
|
#include <vector>
|
|
|
|
|
|
|
|
namespace clang {
|
|
|
|
|
|
|
|
class CompilerInstance;
|
|
|
|
|
|
|
|
namespace tidy {
|
|
|
|
|
2020-04-08 02:53:52 +08:00
|
|
|
template <typename T> class OptionError : public llvm::ErrorInfo<T> {
|
|
|
|
std::error_code convertToErrorCode() const override {
|
|
|
|
return llvm::inconvertibleErrorCode();
|
|
|
|
}
|
|
|
|
|
|
|
|
public:
|
|
|
|
void log(raw_ostream &OS) const override { OS << this->message(); }
|
|
|
|
};
|
|
|
|
|
|
|
|
class MissingOptionError : public OptionError<MissingOptionError> {
|
|
|
|
public:
|
|
|
|
explicit MissingOptionError(std::string OptionName)
|
|
|
|
: OptionName(OptionName) {}
|
|
|
|
|
|
|
|
std::string message() const override;
|
|
|
|
static char ID;
|
|
|
|
private:
|
|
|
|
const std::string OptionName;
|
|
|
|
};
|
|
|
|
|
|
|
|
class UnparseableEnumOptionError
|
|
|
|
: public OptionError<UnparseableEnumOptionError> {
|
|
|
|
public:
|
|
|
|
explicit UnparseableEnumOptionError(std::string LookupName,
|
|
|
|
std::string LookupValue)
|
|
|
|
: LookupName(LookupName), LookupValue(LookupValue) {}
|
|
|
|
explicit UnparseableEnumOptionError(std::string LookupName,
|
|
|
|
std::string LookupValue,
|
|
|
|
std::string SuggestedValue)
|
|
|
|
: LookupName(LookupName), LookupValue(LookupValue),
|
|
|
|
SuggestedValue(SuggestedValue) {}
|
|
|
|
|
|
|
|
std::string message() const override;
|
|
|
|
static char ID;
|
|
|
|
|
|
|
|
private:
|
|
|
|
const std::string LookupName;
|
|
|
|
const std::string LookupValue;
|
|
|
|
const llvm::Optional<std::string> SuggestedValue;
|
|
|
|
};
|
|
|
|
|
|
|
|
class UnparseableIntegerOptionError
|
|
|
|
: public OptionError<UnparseableIntegerOptionError> {
|
|
|
|
public:
|
|
|
|
explicit UnparseableIntegerOptionError(std::string LookupName,
|
|
|
|
std::string LookupValue,
|
|
|
|
bool IsBoolean = false)
|
|
|
|
: LookupName(LookupName), LookupValue(LookupValue), IsBoolean(IsBoolean) {
|
|
|
|
}
|
|
|
|
|
|
|
|
std::string message() const override;
|
|
|
|
static char ID;
|
|
|
|
|
|
|
|
private:
|
|
|
|
const std::string LookupName;
|
|
|
|
const std::string LookupValue;
|
|
|
|
const bool IsBoolean;
|
|
|
|
};
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Base class for all clang-tidy checks.
|
2019-03-25 20:36:30 +08:00
|
|
|
///
|
|
|
|
/// To implement a ``ClangTidyCheck``, write a subclass and override some of the
|
|
|
|
/// base class's methods. E.g. to implement a check that validates namespace
|
|
|
|
/// declarations, override ``registerMatchers``:
|
|
|
|
///
|
|
|
|
/// ~~~{.cpp}
|
|
|
|
/// void registerMatchers(ast_matchers::MatchFinder *Finder) override {
|
|
|
|
/// Finder->addMatcher(namespaceDecl().bind("namespace"), this);
|
|
|
|
/// }
|
|
|
|
/// ~~~
|
|
|
|
///
|
|
|
|
/// and then override ``check(const MatchResult &Result)`` to do the actual
|
|
|
|
/// check for each match.
|
|
|
|
///
|
|
|
|
/// A new ``ClangTidyCheck`` instance is created per translation unit.
|
|
|
|
///
|
|
|
|
/// FIXME: Figure out whether carrying information from one TU to another is
|
|
|
|
/// useful/necessary.
|
|
|
|
class ClangTidyCheck : public ast_matchers::MatchFinder::MatchCallback {
|
|
|
|
public:
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Initializes the check with \p CheckName and \p Context.
|
2019-03-25 20:36:30 +08:00
|
|
|
///
|
|
|
|
/// Derived classes must implement the constructor with this signature or
|
|
|
|
/// delegate it. If a check needs to read options, it can do this in the
|
|
|
|
/// constructor using the Options.get() methods below.
|
|
|
|
ClangTidyCheck(StringRef CheckName, ClangTidyContext *Context);
|
|
|
|
|
[clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck
Summary:
Motivated by [[ https://bugs.llvm.org/show_bug.cgi?id=45045 | Tune inspections to a specific C++ standard. ]]
Moves the isLanguageVersionSupported virtual function from `MakeSmartPtrCheck` to the base `ClangTidyCheck` class.
This will disable registering matchers or pp callbacks on unsupported language versions for a check.
Having it as a standalone function is cleaner than manually disabling the check in the register function and should hopefully
encourage check developers to actually restrict the check based on language version.
As an added bonus this could enable automatic detection of what language version a check runs on for the purpose of documentation generation
Reviewers: aaron.ballman, gribozavr2, Eugene.Zelenko, JonasToth, alexfh, hokein
Reviewed By: gribozavr2
Subscribers: xazax.hun, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75289
2020-02-28 21:03:30 +08:00
|
|
|
/// Override this to disable registering matchers and PP callbacks if an
|
|
|
|
/// invalid language version is being used.
|
|
|
|
///
|
|
|
|
/// For example if a check is examining overloaded functions then this should
|
|
|
|
/// be overridden to return false when the CPlusPlus flag is not set in
|
|
|
|
/// \p LangOpts.
|
|
|
|
virtual bool isLanguageVersionSupported(const LangOptions &LangOpts) const {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Override this to register ``PPCallbacks`` in the preprocessor.
|
2019-03-25 20:36:30 +08:00
|
|
|
///
|
|
|
|
/// This should be used for clang-tidy checks that analyze preprocessor-
|
|
|
|
/// dependent properties, e.g. include directives and macro definitions.
|
|
|
|
///
|
[clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck
Summary:
Motivated by [[ https://bugs.llvm.org/show_bug.cgi?id=45045 | Tune inspections to a specific C++ standard. ]]
Moves the isLanguageVersionSupported virtual function from `MakeSmartPtrCheck` to the base `ClangTidyCheck` class.
This will disable registering matchers or pp callbacks on unsupported language versions for a check.
Having it as a standalone function is cleaner than manually disabling the check in the register function and should hopefully
encourage check developers to actually restrict the check based on language version.
As an added bonus this could enable automatic detection of what language version a check runs on for the purpose of documentation generation
Reviewers: aaron.ballman, gribozavr2, Eugene.Zelenko, JonasToth, alexfh, hokein
Reviewed By: gribozavr2
Subscribers: xazax.hun, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75289
2020-02-28 21:03:30 +08:00
|
|
|
/// This will only be executed if the function isLanguageVersionSupported
|
|
|
|
/// returns true.
|
|
|
|
///
|
2019-03-25 20:36:30 +08:00
|
|
|
/// There are two Preprocessors to choose from that differ in how they handle
|
|
|
|
/// modular #includes:
|
|
|
|
/// - PP is the real Preprocessor. It doesn't walk into modular #includes and
|
|
|
|
/// thus doesn't generate PPCallbacks for their contents.
|
|
|
|
/// - ModuleExpanderPP preprocesses the whole translation unit in the
|
|
|
|
/// non-modular mode, which allows it to generate PPCallbacks not only for
|
|
|
|
/// the main file and textual headers, but also for all transitively
|
|
|
|
/// included modular headers when the analysis runs with modules enabled.
|
|
|
|
/// When modules are not enabled ModuleExpanderPP just points to the real
|
|
|
|
/// preprocessor.
|
|
|
|
virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
|
|
|
|
Preprocessor *ModuleExpanderPP) {}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Override this to register AST matchers with \p Finder.
|
2019-03-25 20:36:30 +08:00
|
|
|
///
|
|
|
|
/// This should be used by clang-tidy checks that analyze code properties that
|
|
|
|
/// dependent on AST knowledge.
|
|
|
|
///
|
|
|
|
/// You can register as many matchers as necessary with \p Finder. Usually,
|
|
|
|
/// "this" will be used as callback, but you can also specify other callback
|
|
|
|
/// classes. Thereby, different matchers can trigger different callbacks.
|
|
|
|
///
|
[clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck
Summary:
Motivated by [[ https://bugs.llvm.org/show_bug.cgi?id=45045 | Tune inspections to a specific C++ standard. ]]
Moves the isLanguageVersionSupported virtual function from `MakeSmartPtrCheck` to the base `ClangTidyCheck` class.
This will disable registering matchers or pp callbacks on unsupported language versions for a check.
Having it as a standalone function is cleaner than manually disabling the check in the register function and should hopefully
encourage check developers to actually restrict the check based on language version.
As an added bonus this could enable automatic detection of what language version a check runs on for the purpose of documentation generation
Reviewers: aaron.ballman, gribozavr2, Eugene.Zelenko, JonasToth, alexfh, hokein
Reviewed By: gribozavr2
Subscribers: xazax.hun, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75289
2020-02-28 21:03:30 +08:00
|
|
|
/// This will only be executed if the function isLanguageVersionSupported
|
|
|
|
/// returns true.
|
|
|
|
///
|
2019-03-25 20:36:30 +08:00
|
|
|
/// If you need to merge information between the different matchers, you can
|
|
|
|
/// store these as members of the derived class. However, note that all
|
|
|
|
/// matches occur in the order of the AST traversal.
|
|
|
|
virtual void registerMatchers(ast_matchers::MatchFinder *Finder) {}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// ``ClangTidyChecks`` that register ASTMatchers should do the actual
|
2019-03-25 20:36:30 +08:00
|
|
|
/// work in here.
|
|
|
|
virtual void check(const ast_matchers::MatchFinder::MatchResult &Result) {}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Add a diagnostic with the check's name.
|
2019-03-25 20:36:30 +08:00
|
|
|
DiagnosticBuilder diag(SourceLocation Loc, StringRef Description,
|
|
|
|
DiagnosticIDs::Level Level = DiagnosticIDs::Warning);
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Should store all options supported by this check with their
|
2019-03-25 20:36:30 +08:00
|
|
|
/// current values or default values for options that haven't been overridden.
|
|
|
|
///
|
|
|
|
/// The check should use ``Options.store()`` to store each option it supports
|
|
|
|
/// whether it has the default value or it has been overridden.
|
|
|
|
virtual void storeOptions(ClangTidyOptions::OptionMap &Options) {}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Provides access to the ``ClangTidyCheck`` options via check-local
|
2019-03-25 20:36:30 +08:00
|
|
|
/// names.
|
|
|
|
///
|
|
|
|
/// Methods of this class prepend ``CheckName + "."`` to translate check-local
|
|
|
|
/// option names to global option names.
|
|
|
|
class OptionsView {
|
|
|
|
public:
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Initializes the instance using \p CheckName + "." as a prefix.
|
2019-03-25 20:36:30 +08:00
|
|
|
OptionsView(StringRef CheckName,
|
|
|
|
const ClangTidyOptions::OptionMap &CheckOptions);
|
|
|
|
|
2020-04-08 02:53:52 +08:00
|
|
|
/// Read a named option from the ``Context``.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present, returns
|
|
|
|
/// a ``MissingOptionError``.
|
|
|
|
llvm::Expected<std::string> get(StringRef LocalName) const;
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Read a named option from the ``Context``.
|
2019-03-25 20:36:30 +08:00
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present, returns
|
|
|
|
/// \p Default.
|
2020-04-08 02:53:52 +08:00
|
|
|
std::string get(StringRef LocalName, StringRef Default) const {
|
|
|
|
if (llvm::Expected<std::string> Val = get(LocalName))
|
|
|
|
return *Val;
|
|
|
|
else
|
|
|
|
llvm::consumeError(Val.takeError());
|
|
|
|
return Default.str();
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context``.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
|
|
|
/// present either, returns a ``MissingOptionError``.
|
|
|
|
llvm::Expected<std::string> getLocalOrGlobal(StringRef LocalName) const;
|
2019-03-25 20:36:30 +08:00
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Read a named option from the ``Context``.
|
2019-03-25 20:36:30 +08:00
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
2020-04-08 02:53:52 +08:00
|
|
|
/// present either, returns \p Default.
|
|
|
|
std::string getLocalOrGlobal(StringRef LocalName, StringRef Default) const {
|
|
|
|
if (llvm::Expected<std::string> Val = getLocalOrGlobal(LocalName))
|
|
|
|
return *Val;
|
|
|
|
else
|
|
|
|
llvm::consumeError(Val.takeError());
|
|
|
|
return Default.str();
|
|
|
|
}
|
2019-03-25 20:36:30 +08:00
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
2019-03-25 20:36:30 +08:00
|
|
|
/// integral type ``T``.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present, returns
|
2020-04-08 02:53:52 +08:00
|
|
|
/// a ``MissingOptionError``. If the corresponding key can't be parsed as
|
|
|
|
/// a ``T``, return an ``UnparseableIntegerOptionError``.
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_integral<T>::value, llvm::Expected<T>>
|
|
|
|
get(StringRef LocalName) const {
|
|
|
|
if (llvm::Expected<std::string> Value = get(LocalName)) {
|
|
|
|
T Result{};
|
|
|
|
if (!StringRef(*Value).getAsInteger(10, Result))
|
|
|
|
return Result;
|
|
|
|
return llvm::make_error<UnparseableIntegerOptionError>(
|
|
|
|
(NamePrefix + LocalName).str(), *Value);
|
|
|
|
} else
|
|
|
|
return std::move(Value.takeError());
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
|
|
|
/// integral type ``T``.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present or it can't be
|
|
|
|
/// parsed as a ``T``, returns \p Default.
|
2019-03-25 20:36:30 +08:00
|
|
|
template <typename T>
|
Use std::foo_t rather than std::foo in LLVM.
Summary: C++14 migration. No functional change.
Reviewers: bkramer, JDevlieghere, lebedev.ri
Subscribers: MatzeB, hiraditya, jkorous, dexonsmith, arphaman, kadircet, lebedev.ri, usaxena95, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D74384
2020-02-11 12:33:08 +08:00
|
|
|
std::enable_if_t<std::is_integral<T>::value, T> get(StringRef LocalName,
|
|
|
|
T Default) const {
|
2020-04-08 02:53:52 +08:00
|
|
|
if (llvm::Expected<T> ValueOr = get<T>(LocalName))
|
|
|
|
return *ValueOr;
|
|
|
|
else
|
|
|
|
logErrToStdErr(ValueOr.takeError());
|
|
|
|
return Default;
|
2019-03-25 20:36:30 +08:00
|
|
|
}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
2019-03-25 20:36:30 +08:00
|
|
|
/// integral type ``T``.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
2020-04-08 02:53:52 +08:00
|
|
|
/// present either, returns a ``MissingOptionError``. If the corresponding
|
|
|
|
/// key can't be parsed as a ``T``, return an
|
|
|
|
/// ``UnparseableIntegerOptionError``.
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_integral<T>::value, llvm::Expected<T>>
|
|
|
|
getLocalOrGlobal(StringRef LocalName) const {
|
|
|
|
llvm::Expected<std::string> ValueOr = get(LocalName);
|
|
|
|
bool IsGlobal = false;
|
|
|
|
if (!ValueOr) {
|
|
|
|
IsGlobal = true;
|
|
|
|
llvm::consumeError(ValueOr.takeError());
|
|
|
|
ValueOr = getLocalOrGlobal(LocalName);
|
|
|
|
if (!ValueOr)
|
|
|
|
return std::move(ValueOr.takeError());
|
|
|
|
}
|
|
|
|
T Result{};
|
|
|
|
if (!StringRef(*ValueOr).getAsInteger(10, Result))
|
|
|
|
return Result;
|
|
|
|
return llvm::make_error<UnparseableIntegerOptionError>(
|
|
|
|
(IsGlobal ? LocalName.str() : (NamePrefix + LocalName).str()),
|
|
|
|
*ValueOr);
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
|
|
|
/// integral type ``T``.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
|
|
|
/// present either or it can't be parsed as a ``T``, returns \p Default.
|
2019-03-25 20:36:30 +08:00
|
|
|
template <typename T>
|
Use std::foo_t rather than std::foo in LLVM.
Summary: C++14 migration. No functional change.
Reviewers: bkramer, JDevlieghere, lebedev.ri
Subscribers: MatzeB, hiraditya, jkorous, dexonsmith, arphaman, kadircet, lebedev.ri, usaxena95, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D74384
2020-02-11 12:33:08 +08:00
|
|
|
std::enable_if_t<std::is_integral<T>::value, T>
|
2019-03-25 20:36:30 +08:00
|
|
|
getLocalOrGlobal(StringRef LocalName, T Default) const {
|
2020-04-08 02:53:52 +08:00
|
|
|
if (llvm::Expected<T> ValueOr = getLocalOrGlobal<T>(LocalName))
|
|
|
|
return *ValueOr;
|
|
|
|
else
|
|
|
|
logErrToStdErr(ValueOr.takeError());
|
|
|
|
return Default;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
2020-06-29 16:44:11 +08:00
|
|
|
/// enum type ``T`` using the \p Mapping provided. If \p IgnoreCase is set,
|
|
|
|
/// it will search the mapping ignoring the case.
|
2020-04-08 02:53:52 +08:00
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present, returns a
|
|
|
|
/// ``MissingOptionError``. If the key can't be parsed as a ``T`` returns a
|
|
|
|
/// ``UnparseableEnumOptionError``.
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_enum<T>::value, llvm::Expected<T>>
|
2020-06-29 16:44:11 +08:00
|
|
|
get(StringRef LocalName, ArrayRef<std::pair<StringRef, T>> Mapping,
|
|
|
|
bool IgnoreCase = false) {
|
|
|
|
if (llvm::Expected<int64_t> ValueOr = getEnumInt(
|
|
|
|
LocalName, typeEraseMapping(Mapping), false, IgnoreCase))
|
2020-04-08 02:53:52 +08:00
|
|
|
return static_cast<T>(*ValueOr);
|
|
|
|
else
|
|
|
|
return std::move(ValueOr.takeError());
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
2020-06-29 16:44:11 +08:00
|
|
|
/// enum type ``T`` using the \p Mapping provided. If \p IgnoreCase is set,
|
|
|
|
/// it will search the mapping ignoring the case.
|
2020-04-08 02:53:52 +08:00
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present or it can't be
|
|
|
|
/// parsed as a ``T``, returns \p Default.
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_enum<T>::value, T>
|
2020-06-29 16:44:11 +08:00
|
|
|
get(StringRef LocalName, ArrayRef<std::pair<StringRef, T>> Mapping,
|
|
|
|
T Default, bool IgnoreCase = false) {
|
|
|
|
if (auto ValueOr = get(LocalName, Mapping, IgnoreCase))
|
2020-04-08 02:53:52 +08:00
|
|
|
return *ValueOr;
|
|
|
|
else
|
|
|
|
logErrToStdErr(ValueOr.takeError());
|
|
|
|
return Default;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
2020-06-29 16:44:11 +08:00
|
|
|
/// enum type ``T`` using the \p Mapping provided. If \p IgnoreCase is set,
|
|
|
|
/// it will search the mapping ignoring the case.
|
2020-04-08 02:53:52 +08:00
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
|
|
|
/// present either, returns a ``MissingOptionError``. If the key can't be
|
|
|
|
/// parsed as a ``T`` returns a ``UnparseableEnumOptionError``.
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_enum<T>::value, llvm::Expected<T>>
|
|
|
|
getLocalOrGlobal(StringRef LocalName,
|
2020-06-29 16:44:11 +08:00
|
|
|
ArrayRef<std::pair<StringRef, T>> Mapping,
|
2020-04-08 02:53:52 +08:00
|
|
|
bool IgnoreCase = false) {
|
2020-06-29 16:44:11 +08:00
|
|
|
if (llvm::Expected<int64_t> ValueOr = getEnumInt(
|
|
|
|
LocalName, typeEraseMapping(Mapping), true, IgnoreCase))
|
2020-04-08 02:53:52 +08:00
|
|
|
return static_cast<T>(*ValueOr);
|
|
|
|
else
|
|
|
|
return std::move(ValueOr.takeError());
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as an
|
2020-06-29 16:44:11 +08:00
|
|
|
/// enum type ``T`` using the \p Mapping provided. If \p IgnoreCase is set,
|
|
|
|
/// it will search the mapping ignoring the case.
|
2020-04-08 02:53:52 +08:00
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
|
|
|
/// present either or it can't be parsed as a ``T``, returns \p Default.
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_enum<T>::value, T>
|
2020-06-29 16:44:11 +08:00
|
|
|
getLocalOrGlobal(StringRef LocalName,
|
|
|
|
ArrayRef<std::pair<StringRef, T>> Mapping, T Default,
|
|
|
|
bool IgnoreCase = false) {
|
|
|
|
if (auto ValueOr = getLocalOrGlobal(LocalName, Mapping, IgnoreCase))
|
2020-04-08 02:53:52 +08:00
|
|
|
return *ValueOr;
|
|
|
|
else
|
|
|
|
logErrToStdErr(ValueOr.takeError());
|
|
|
|
return Default;
|
2019-03-25 20:36:30 +08:00
|
|
|
}
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Stores an option with the check-local name \p LocalName with
|
2019-03-25 20:36:30 +08:00
|
|
|
/// string value \p Value to \p Options.
|
|
|
|
void store(ClangTidyOptions::OptionMap &Options, StringRef LocalName,
|
|
|
|
StringRef Value) const;
|
|
|
|
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Stores an option with the check-local name \p LocalName with
|
2019-03-25 20:36:30 +08:00
|
|
|
/// ``int64_t`` value \p Value to \p Options.
|
|
|
|
void store(ClangTidyOptions::OptionMap &Options, StringRef LocalName,
|
|
|
|
int64_t Value) const;
|
|
|
|
|
2020-04-08 02:53:52 +08:00
|
|
|
/// Stores an option with the check-local name \p LocalName as the string
|
2020-06-29 16:44:11 +08:00
|
|
|
/// representation of the Enum \p Value using the \p Mapping to \p Options.
|
2020-04-08 02:53:52 +08:00
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_enum<T>::value>
|
2020-06-29 16:44:11 +08:00
|
|
|
store(ClangTidyOptions::OptionMap &Options, StringRef LocalName, T Value,
|
|
|
|
ArrayRef<std::pair<StringRef, T>> Mapping) {
|
2020-04-08 02:53:52 +08:00
|
|
|
auto Iter = llvm::find_if(
|
2020-06-29 16:44:11 +08:00
|
|
|
Mapping, [&](const std::pair<StringRef, T> &NameAndEnum) {
|
|
|
|
return NameAndEnum.second == Value;
|
2020-04-08 02:53:52 +08:00
|
|
|
});
|
|
|
|
assert(Iter != Mapping.end() && "Unknown Case Value");
|
2020-06-29 16:44:11 +08:00
|
|
|
store(Options, LocalName, Iter->first);
|
2020-04-08 02:53:52 +08:00
|
|
|
}
|
|
|
|
|
2019-03-25 20:36:30 +08:00
|
|
|
private:
|
2020-06-29 16:44:11 +08:00
|
|
|
using NameAndValue = std::pair<StringRef, int64_t>;
|
2020-04-08 02:53:52 +08:00
|
|
|
|
|
|
|
llvm::Expected<int64_t> getEnumInt(StringRef LocalName,
|
|
|
|
ArrayRef<NameAndValue> Mapping,
|
|
|
|
bool CheckGlobal, bool IgnoreCase);
|
|
|
|
|
|
|
|
template <typename T>
|
|
|
|
std::enable_if_t<std::is_enum<T>::value, std::vector<NameAndValue>>
|
2020-06-29 16:44:11 +08:00
|
|
|
typeEraseMapping(ArrayRef<std::pair<StringRef, T>> Mapping) {
|
2020-04-08 02:53:52 +08:00
|
|
|
std::vector<NameAndValue> Result;
|
|
|
|
Result.reserve(Mapping.size());
|
|
|
|
for (auto &MappedItem : Mapping) {
|
2020-06-29 16:44:11 +08:00
|
|
|
Result.emplace_back(MappedItem.first,
|
|
|
|
static_cast<int64_t>(MappedItem.second));
|
2020-04-08 02:53:52 +08:00
|
|
|
}
|
|
|
|
return Result;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void logErrToStdErr(llvm::Error &&Err);
|
|
|
|
|
2019-03-25 20:36:30 +08:00
|
|
|
std::string NamePrefix;
|
|
|
|
const ClangTidyOptions::OptionMap &CheckOptions;
|
|
|
|
};
|
|
|
|
|
2019-06-14 03:05:02 +08:00
|
|
|
private:
|
|
|
|
void run(const ast_matchers::MatchFinder::MatchResult &Result) override;
|
|
|
|
StringRef getID() const override { return CheckName; }
|
|
|
|
std::string CheckName;
|
|
|
|
ClangTidyContext *Context;
|
|
|
|
|
|
|
|
protected:
|
2019-03-25 20:36:30 +08:00
|
|
|
OptionsView Options;
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Returns the main file name of the current translation unit.
|
2019-03-25 20:36:30 +08:00
|
|
|
StringRef getCurrentMainFile() const { return Context->getCurrentFile(); }
|
Remove \brief commands from doxygen comments.
Summary:
We've been running doxygen with the autobrief option for a couple of
years now. This makes the \brief markers into our comments
redundant. Since they are a visual distraction and we don't want to
encourage more \brief markers in new code either, this patch removes
them all.
Patch produced by
for i in $(git grep -l '\\brief'); do perl -pi -e 's/\\brief //g' $i & done
[This is analogous to LLVM r331272 and CFE r331834]
Subscribers: srhines, nemanjai, javed.absar, kbarton, MaskRay, jkorous, arphaman, jfb, kadircet, jsji, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66578
llvm-svn: 369643
2019-08-22 19:32:57 +08:00
|
|
|
/// Returns the language options from the context.
|
2019-04-02 19:31:56 +08:00
|
|
|
const LangOptions &getLangOpts() const { return Context->getLangOpts(); }
|
2019-03-25 20:36:30 +08:00
|
|
|
};
|
|
|
|
|
2020-04-08 04:30:29 +08:00
|
|
|
/// Read a named option from the ``Context`` and parse it as a bool.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present, returns
|
|
|
|
/// a ``MissingOptionError``. If the corresponding key can't be parsed as
|
|
|
|
/// a bool, return an ``UnparseableIntegerOptionError``.
|
|
|
|
template <>
|
|
|
|
llvm::Expected<bool>
|
|
|
|
ClangTidyCheck::OptionsView::get<bool>(StringRef LocalName) const;
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as a bool.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from the
|
|
|
|
/// ``CheckOptions``. If the corresponding key is not present or it can't be
|
|
|
|
/// parsed as a bool, returns \p Default.
|
|
|
|
template <>
|
|
|
|
bool ClangTidyCheck::OptionsView::get<bool>(StringRef LocalName,
|
|
|
|
bool Default) const;
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as a bool.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
|
|
|
/// present either, returns a ``MissingOptionError``. If the corresponding
|
|
|
|
/// key can't be parsed as a bool, return an
|
|
|
|
/// ``UnparseableIntegerOptionError``.
|
|
|
|
template <>
|
|
|
|
llvm::Expected<bool>
|
|
|
|
ClangTidyCheck::OptionsView::getLocalOrGlobal<bool>(StringRef LocalName) const;
|
|
|
|
|
|
|
|
/// Read a named option from the ``Context`` and parse it as a bool.
|
|
|
|
///
|
|
|
|
/// Reads the option with the check-local name \p LocalName from local or
|
|
|
|
/// global ``CheckOptions``. Gets local option first. If local is not
|
|
|
|
/// present, falls back to get global option. If global option is not
|
|
|
|
/// present either or it can't be parsed as a bool, returns \p Default.
|
|
|
|
template <>
|
|
|
|
bool ClangTidyCheck::OptionsView::getLocalOrGlobal<bool>(StringRef LocalName,
|
|
|
|
bool Default) const;
|
|
|
|
|
2019-03-25 20:36:30 +08:00
|
|
|
} // namespace tidy
|
|
|
|
} // namespace clang
|
|
|
|
|
|
|
|
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDYCHECK_H
|