2012-12-26 08:13:29 +08:00
|
|
|
// RUN: %clang_cc1 -fsyntax-only -verify -Wall %s
|
|
|
|
|
|
|
|
namespace test1 {
|
2020-07-27 00:20:56 +08:00
|
|
|
static void f() {} // expected-warning {{function 'f' is not needed and will not be emitted}}
|
|
|
|
static void f();
|
|
|
|
template <typename T>
|
|
|
|
void foo() {
|
|
|
|
f();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace test1_template {
|
|
|
|
template <typename T> static void f() {}
|
[clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.
Background:
-----------
There are two related argument types which can be sent into a diagnostic to
display the name of an entity: DeclarationName (ak_declarationname) or
NamedDecl* (ak_nameddecl) (there is also ak_identifierinfo for
IdentifierInfo*, but we are not concerned with it here).
A DeclarationName in a diagnostic will just be streamed to the output,
which will directly result in a call to DeclarationName::print.
A NamedDecl* in a diagnostic will also ultimately result in a call to
DeclarationName::print, but with two customisation points along the way:
The first customisation point is NamedDecl::getNameForDiagnostic which is
overloaded by FunctionDecl, ClassTemplateSpecializationDecl and
VarTemplateSpecializationDecl to print the template arguments, if any.
The second customisation point is NamedDecl::printName. By default it just
streams the stored DeclarationName into the output but it can be customised
to provide a user-friendly name for an entity. It is currently overloaded by
DecompositionDecl and MSGuidDecl.
What this patch does:
---------------------
For many diagnostics a DeclarationName is used instead of the NamedDecl*.
This bypasses the two customisation points mentioned above. This patches fix
this for diagnostics in Sema.cpp, SemaCast.cpp, SemaChecking.cpp, SemaDecl.cpp,
SemaDeclAttr.cpp, SemaDecl.cpp, SemaOverload.cpp and SemaStmt.cpp.
I have only modified diagnostics where I could construct a test-case which
demonstrates that the change is appropriate (either with this patch or the next
one).
Reviewed By: erichkeane, aaron.ballman
Differential Revision: https://reviews.llvm.org/D84656
2020-07-28 06:22:21 +08:00
|
|
|
template <> void f<int>() {} // expected-warning {{function 'f<int>' is not needed and will not be emitted}}
|
2020-07-27 00:20:56 +08:00
|
|
|
template <typename T>
|
|
|
|
void foo() {
|
|
|
|
f<int>();
|
|
|
|
f<long>();
|
2012-12-26 08:13:29 +08:00
|
|
|
}
|
2020-07-27 00:20:56 +08:00
|
|
|
} // namespace test1_template
|
2012-12-26 08:13:29 +08:00
|
|
|
|
|
|
|
namespace test2 {
|
|
|
|
static void f() {}
|
|
|
|
static void f();
|
|
|
|
static void g() { f(); }
|
|
|
|
void h() { g(); }
|
|
|
|
}
|
2012-12-26 12:38:44 +08:00
|
|
|
|
|
|
|
namespace test3 {
|
|
|
|
static void f();
|
|
|
|
template<typename T>
|
|
|
|
static void g() {
|
|
|
|
f();
|
|
|
|
}
|
|
|
|
static void f() {
|
|
|
|
}
|
|
|
|
void h() {
|
|
|
|
g<int>();
|
|
|
|
}
|
|
|
|
}
|
2013-01-09 03:43:34 +08:00
|
|
|
|
|
|
|
namespace test4 {
|
|
|
|
static void f();
|
|
|
|
static void f();
|
|
|
|
template<typename T>
|
|
|
|
static void g() {
|
|
|
|
f();
|
|
|
|
}
|
|
|
|
static void f() {
|
|
|
|
}
|
|
|
|
void h() {
|
|
|
|
g<int>();
|
|
|
|
}
|
|
|
|
}
|
2013-10-23 05:56:29 +08:00
|
|
|
|
|
|
|
namespace test4 {
|
|
|
|
static void func();
|
|
|
|
void bar() {
|
|
|
|
void func();
|
|
|
|
func();
|
|
|
|
}
|
|
|
|
static void func() {}
|
|
|
|
}
|