maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/ELF/wrap-shlib-undefined.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

82 lines
3.0 KiB
ArmAsm
Raw Normal View History

[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition This is a regression after D51283. Also, export `foo` if `__real_foo` is referenced by a shared object.
2020-06-02 13:57:43 +08:00
# REQUIRES: x86
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# RUN: rm -rf %t && split-file %s %t
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/main.s -o %t/main.o
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/call-foo.s -o %t/call-foo.o
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/bar.s -o %t/bar.o
# RUN: ld.lld -shared -soname=t.so %t/bar.o -o %t/bar.so
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/wrap.s -o %t/wrap.o
# RUN: ld.lld -shared --soname=fixed %t/wrap.o -o %t/wrap.so
[ELF] --wrap: Produce a dynamic symbol for undefined __wrap_ ``` // a.s jmp fcntl // b.s .globl fcntl fcntl: ret ``` `ld.lld -shared --wrap=fcntl a.o b.o` has an `R_X86_64_JUMP_SLOT` referencing the index 0 undefined symbol, which will cause a glibc `symbol lookup error` at runtime. This is because `__wrap_fcntl` is not in .dynsym We use an approximation `!wrap->isUndefined()`, which doesn't set `isUsedInRegularObj` of `__wrap_fcntl` when `fcntl` is referenced and `__wrap_fcntl` is undefined. Fix this by using `sym->referenced`.
2021-01-20 13:23:57 +08:00
## foo is defined, then referenced in another object file.
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# RUN: ld.lld -shared %t/main.o %t/call-foo.o --wrap foo -o %t1.so
# RUN: llvm-readelf -r %t1.so | FileCheck %s --check-prefix=CHECK1
# CHECK1: R_X86_64_JUMP_SLOT 0000000000000000 bar + 0
[ELF] --wrap: Produce a dynamic symbol for undefined __wrap_ ``` // a.s jmp fcntl // b.s .globl fcntl fcntl: ret ``` `ld.lld -shared --wrap=fcntl a.o b.o` has an `R_X86_64_JUMP_SLOT` referencing the index 0 undefined symbol, which will cause a glibc `symbol lookup error` at runtime. This is because `__wrap_fcntl` is not in .dynsym We use an approximation `!wrap->isUndefined()`, which doesn't set `isUsedInRegularObj` of `__wrap_fcntl` when `fcntl` is referenced and `__wrap_fcntl` is undefined. Fix this by using `sym->referenced`.
2021-01-20 13:23:57 +08:00
# CHECK1-NEXT: R_X86_64_JUMP_SLOT 0000000000000000 __wrap_foo + 0
[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition This is a regression after D51283. Also, export `foo` if `__real_foo` is referenced by a shared object.
2020-06-02 13:57:43 +08:00
## --no-allow-shlib-undefined errors because __real_foo is not defined.
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# RUN: not ld.lld %t/main.o %t/bar.so -o /dev/null 2>&1 | FileCheck --check-prefix=ERR %s
[ELF] Append " [--no-allow-shlib-undefined]" to the corresponding diagnostics --no-allow-shlib-undefined (enabled by default when linking an executable) rejects unresolved references in shared objects. Users may be confused by the common diagnostics of unresolved symbols in object files (LLD: "undefined symbol: foo"; GNU ld/gold: "undefined reference to") Learn from GCC/clang " [-Wfoo]": append the option name to the diagnostics. Users can find relevant information by searching "--no-allow-shlib-undefined". It should also be obvious to them that the positive form --allow-shlib-undefined can suppress the error. Also downgrade the error to a warning if --noinhibit-exec is used (compatible with GNU ld and gold). Reviewed By: grimar, psmith Differential Revision: https://reviews.llvm.org/D81028
2020-06-03 22:59:28 +08:00
# ERR: {{.*}}.so: undefined reference to __real_foo [--no-allow-shlib-undefined]
[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition This is a regression after D51283. Also, export `foo` if `__real_foo` is referenced by a shared object.
2020-06-02 13:57:43 +08:00
## --wrap=foo defines __real_foo.
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# RUN: ld.lld %t/main.o %t/bar.so --wrap=foo -o %t2
# RUN: llvm-readelf --dyn-syms %t2 | FileCheck %s --check-prefix=CHECK2
[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition This is a regression after D51283. Also, export `foo` if `__real_foo` is referenced by a shared object.
2020-06-02 13:57:43 +08:00
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
## The reference __real_foo from %t/bar.so causes foo to be exported.
[ELF] --wrap: set isUsedInRegularObj of __wrap_ only if it is defined Fixes PR46169
2020-08-02 09:19:14 +08:00
## __wrap_foo is not used, thus not exported.
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# CHECK2: Symbol table '.dynsym' contains 3 entries:
# CHECK2: NOTYPE LOCAL DEFAULT UND
# CHECK2-NEXT: NOTYPE GLOBAL DEFAULT UND bar
# CHECK2-NEXT: NOTYPE GLOBAL DEFAULT 6 foo
## __wrap_bar is undefined.
[LLD][ELF] Correct test temporary file paths In 8031785f4a7ebd the temporary object being built was moved to %t/main.o, but not all run lines were updated to reflect this. Observe the failure on this buildbot: http://lab.llvm.org:8011/#/builders/5/builds/3646/steps/9/logs/stdio It might pass locally for some people due to a stale %t.o hanging around the build directory.
2021-01-20 19:43:27 +08:00
# RUN: ld.lld -shared %t/main.o --wrap=bar -o %t3.so
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# RUN: llvm-readelf -r --dyn-syms %t3.so | FileCheck %s --check-prefix=CHECK3
[ELF] --wrap: Produce a dynamic symbol for undefined __wrap_ ``` // a.s jmp fcntl // b.s .globl fcntl fcntl: ret ``` `ld.lld -shared --wrap=fcntl a.o b.o` has an `R_X86_64_JUMP_SLOT` referencing the index 0 undefined symbol, which will cause a glibc `symbol lookup error` at runtime. This is because `__wrap_fcntl` is not in .dynsym We use an approximation `!wrap->isUndefined()`, which doesn't set `isUsedInRegularObj` of `__wrap_fcntl` when `fcntl` is referenced and `__wrap_fcntl` is undefined. Fix this by using `sym->referenced`.
2021-01-20 13:23:57 +08:00
# CHECK3: R_X86_64_JUMP_SLOT 0000000000000000 __wrap_bar + 0
# CHECK3: Symbol table '.dynsym' contains 4 entries:
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# CHECK3: NOTYPE LOCAL DEFAULT UND
[ELF] --wrap: Produce a dynamic symbol for undefined __wrap_ ``` // a.s jmp fcntl // b.s .globl fcntl fcntl: ret ``` `ld.lld -shared --wrap=fcntl a.o b.o` has an `R_X86_64_JUMP_SLOT` referencing the index 0 undefined symbol, which will cause a glibc `symbol lookup error` at runtime. This is because `__wrap_fcntl` is not in .dynsym We use an approximation `!wrap->isUndefined()`, which doesn't set `isUsedInRegularObj` of `__wrap_fcntl` when `fcntl` is referenced and `__wrap_fcntl` is undefined. Fix this by using `sym->referenced`.
2021-01-20 13:23:57 +08:00
# CHECK3-NEXT: NOTYPE GLOBAL DEFAULT UND __wrap_bar
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# CHECK3-NEXT: NOTYPE GLOBAL DEFAULT 6 _start
# CHECK3-NEXT: NOTYPE GLOBAL DEFAULT 6 foo
## __wrap_bar is defined in %t/wrap.so.
[LLD][ELF] Correct test temporary file paths In 8031785f4a7ebd the temporary object being built was moved to %t/main.o, but not all run lines were updated to reflect this. Observe the failure on this buildbot: http://lab.llvm.org:8011/#/builders/5/builds/3646/steps/9/logs/stdio It might pass locally for some people due to a stale %t.o hanging around the build directory.
2021-01-20 19:43:27 +08:00
# RUN: ld.lld -shared %t/main.o %t/wrap.so --wrap=bar -o %t4.so
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
# RUN: llvm-readelf -r --dyn-syms %t4.so | FileCheck %s --check-prefix=CHECK4
# CHECK4: R_X86_64_JUMP_SLOT {{.*}} __wrap_bar + 0
# CHECK4: Symbol table '.dynsym' contains 4 entries:
# CHECK4: NOTYPE LOCAL DEFAULT UND
# CHECK4-NEXT: NOTYPE GLOBAL DEFAULT UND __wrap_bar
# CHECK4-NEXT: NOTYPE GLOBAL DEFAULT 6 _start
# CHECK4-NEXT: NOTYPE GLOBAL DEFAULT 6 foo
[LLD][ELF] Correct test temporary file paths In 8031785f4a7ebd the temporary object being built was moved to %t/main.o, but not all run lines were updated to reflect this. Observe the failure on this buildbot: http://lab.llvm.org:8011/#/builders/5/builds/3646/steps/9/logs/stdio It might pass locally for some people due to a stale %t.o hanging around the build directory.
2021-01-20 19:43:27 +08:00
# RUN: ld.lld %t/main.o %t/wrap.so --wrap bar -o %t1
[ELF] --wrap: set isUsedInRegularObj of __wrap_ if it is defined or shared Fixes PR47017 (a regression when fixing PR46169): if __wrap_ is shared, it is not exported.
2020-08-09 00:24:08 +08:00
# RUN: llvm-readelf --dyn-syms %t1 | FileCheck %s --check-prefix=DYNSYM
# RUN: llvm-objdump -d %t1 | FileCheck %s --check-prefix=ASM
[ELF] --wrap: don't leave the original symbol as SHN_UNDEF in .symtab or .dynsym
2020-08-09 09:17:38 +08:00
# DYNSYM: Symbol table '.dynsym' contains 2 entries:
[ELF] --wrap: set isUsedInRegularObj of __wrap_ if it is defined or shared Fixes PR47017 (a regression when fixing PR46169): if __wrap_ is shared, it is not exported.
2020-08-09 00:24:08 +08:00
# DYNSYM: NOTYPE LOCAL DEFAULT UND
# DYNSYM-NEXT: NOTYPE GLOBAL DEFAULT UND __wrap_bar
# ASM: <_start>:
# ASM-NEXT: callq {{.*}} <__wrap_bar@plt>
#--- main.s
[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition This is a regression after D51283. Also, export `foo` if `__real_foo` is referenced by a shared object.
2020-06-02 13:57:43 +08:00
.globl _start, foo
_start:
call bar
foo:
[ELF] --wrap: set isUsedInRegularObj of __wrap_ if it is defined or shared Fixes PR47017 (a regression when fixing PR46169): if __wrap_ is shared, it is not exported.
2020-08-09 00:24:08 +08:00
[ELF][test] Improve --wrap tests
2021-01-20 13:05:16 +08:00
#--- call-foo.s
call foo
#--- bar.s
.globl bar
bar:
call __real_foo
[ELF] --wrap: set isUsedInRegularObj of __wrap_ if it is defined or shared Fixes PR47017 (a regression when fixing PR46169): if __wrap_ is shared, it is not exported.
2020-08-09 00:24:08 +08:00
#--- wrap.s
.globl __wrap_bar
__wrap_bar:
retq