2013-07-30 02:12:58 +08:00
; RUN: opt -objc-arc -S < %s | FileCheck %s
2013-01-17 05:07:18 +08:00
; rdar://11744105
; bugzilla://14584
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
target triple = "x86_64-apple-macosx10.9.0"
%0 = type opaque
%struct._class_t = type { %struct._class_t * , %struct._class_t * , %struct._objc_cache * , i8 * ( i8 * , i8 * ) * * , %struct._class_ro_t * }
%struct._objc_cache = type opaque
%struct._class_ro_t = type { i32 , i32 , i32 , i8 * , i8 * , %struct.__method_list_t * , %struct._objc_protocol_list * , %struct._ivar_list_t * , i8 * , %struct._prop_list_t * }
%struct.__method_list_t = type { i32 , i32 , [ 0 x %struct._objc_method ] }
%struct._objc_method = type { i8 * , i8 * , i8 * }
%struct._objc_protocol_list = type { i64 , [ 0 x %struct._protocol_t * ] }
%struct._protocol_t = type { i8 * , i8 * , %struct._objc_protocol_list * , %struct.__method_list_t * , %struct.__method_list_t * , %struct.__method_list_t * , %struct.__method_list_t * , %struct._prop_list_t * , i32 , i32 , i8 * * }
%struct._prop_list_t = type { i32 , i32 , [ 0 x %struct._prop_t ] }
%struct._prop_t = type { i8 * , i8 * }
%struct._ivar_list_t = type { i32 , i32 , [ 0 x %struct._ivar_t ] }
%struct._ivar_t = type { i64 * , i8 * , i8 * , i32 , i32 }
%struct.NSConstantString = type { i32 * , i32 , i8 * , i64 }
@"OBJC_CLASS_$_NSObject" = external global %struct._class_t
@"\01L_OBJC_CLASSLIST_REFERENCES_$_" = internal global %struct._class_t * @"OBJC_CLASS_$_NSObject" , section "__DATA, __objc_classrefs, regular, no_dead_strip" , align 8
@"\01L_OBJC_METH_VAR_NAME_" = internal global [ 4 x i8 ] c "new\00" , section "__TEXT,__objc_methname,cstring_literals" , align 1
2015-03-14 02:20:45 +08:00
@"\01L_OBJC_SELECTOR_REFERENCES_" = internal global i8 * getelementptr inbounds ( [ 4 x i8 ] , [ 4 x i8 ] * @"\01L_OBJC_METH_VAR_NAME_" , i64 0 , i64 0 ) , section "__DATA, __objc_selrefs, literal_pointers, no_dead_strip"
2013-01-17 05:07:18 +08:00
@__CFConstantStringClassReference = external global [ 0 x i32 ]
Remove the linker_private and linker_private_weak linkages.
These linkages were introduced some time ago, but it was never very
clear what exactly their semantics were or what they should be used
for. Some investigation found these uses:
* utf-16 strings in clang.
* non-unnamed_addr strings produced by the sanitizers.
It turns out they were just working around a more fundamental problem.
For some sections a MachO linker needs a symbol in order to split the
section into atoms, and llvm had no idea that was the case. I fixed
that in r201700 and it is now safe to use the private linkage. When
the object ends up in a section that requires symbols, llvm will use a
'l' prefix instead of a 'L' prefix and things just work.
With that, these linkages were already dead, but there was a potential
future user in the objc metadata information. I am still looking at
CGObjcMac.cpp, but at this point I am convinced that linker_private
and linker_private_weak are not what they need.
The objc uses are currently split in
* Regular symbols (no '\01' prefix). LLVM already directly provides
whatever semantics they need.
* Uses of a private name (start with "\01L" or "\01l") and private
linkage. We can drop the "\01L" and "\01l" prefixes as soon as llvm
agrees with clang on L being ok or not for a given section. I have two
patches in code review for this.
* Uses of private name and weak linkage.
The last case is the one that one could think would fit one of these
linkages. That is not the case. The semantics are
* the linker will merge these symbol by *name*.
* the linker will hide them in the final DSO.
Given that the merging is done by name, any of the private (or
internal) linkages would be a bad match. They allow llvm to rename the
symbols, and that is really not what we want. From the llvm point of
view, these objects should really be (linkonce|weak)(_odr)?.
For now, just keeping the "\01l" prefix is probably the best for these
symbols. If we one day want to have a more direct support in llvm,
IMHO what we should add is not a linkage, it is just a hidden_symbol
attribute. It would be applicable to multiple linkages. For example,
on weak it would produce the current behavior we have for objc
metadata. On internal, it would be equivalent to private (and we
should then remove private).
llvm-svn: 203866
2014-03-14 07:18:37 +08:00
@.str = private unnamed_addr constant [ 11 x i8 ] c "Failed: %@\00" , align 1
2015-03-14 02:20:45 +08:00
@_unnamed_cfstring_ = private constant %struct.NSConstantString { i32 * getelementptr inbounds ( [ 0 x i32 ] , [ 0 x i32 ] * @__CFConstantStringClassReference , i32 0 , i32 0 ) , i32 1992 , i8 * getelementptr inbounds ( [ 11 x i8 ] , [ 11 x i8 ] * @.str , i32 0 , i32 0 ) , i64 10 } , section "__DATA,__cfstring"
2013-01-17 05:07:18 +08:00
@"OBJC_CLASS_$_NSException" = external global %struct._class_t
@"\01L_OBJC_CLASSLIST_REFERENCES_$_1" = internal global %struct._class_t * @"OBJC_CLASS_$_NSException" , section "__DATA, __objc_classrefs, regular, no_dead_strip" , align 8
Remove the linker_private and linker_private_weak linkages.
These linkages were introduced some time ago, but it was never very
clear what exactly their semantics were or what they should be used
for. Some investigation found these uses:
* utf-16 strings in clang.
* non-unnamed_addr strings produced by the sanitizers.
It turns out they were just working around a more fundamental problem.
For some sections a MachO linker needs a symbol in order to split the
section into atoms, and llvm had no idea that was the case. I fixed
that in r201700 and it is now safe to use the private linkage. When
the object ends up in a section that requires symbols, llvm will use a
'l' prefix instead of a 'L' prefix and things just work.
With that, these linkages were already dead, but there was a potential
future user in the objc metadata information. I am still looking at
CGObjcMac.cpp, but at this point I am convinced that linker_private
and linker_private_weak are not what they need.
The objc uses are currently split in
* Regular symbols (no '\01' prefix). LLVM already directly provides
whatever semantics they need.
* Uses of a private name (start with "\01L" or "\01l") and private
linkage. We can drop the "\01L" and "\01l" prefixes as soon as llvm
agrees with clang on L being ok or not for a given section. I have two
patches in code review for this.
* Uses of private name and weak linkage.
The last case is the one that one could think would fit one of these
linkages. That is not the case. The semantics are
* the linker will merge these symbol by *name*.
* the linker will hide them in the final DSO.
Given that the merging is done by name, any of the private (or
internal) linkages would be a bad match. They allow llvm to rename the
symbols, and that is really not what we want. From the llvm point of
view, these objects should really be (linkonce|weak)(_odr)?.
For now, just keeping the "\01l" prefix is probably the best for these
symbols. If we one day want to have a more direct support in llvm,
IMHO what we should add is not a linkage, it is just a hidden_symbol
attribute. It would be applicable to multiple linkages. For example,
on weak it would produce the current behavior we have for objc
metadata. On internal, it would be equivalent to private (and we
should then remove private).
llvm-svn: 203866
2014-03-14 07:18:37 +08:00
@.str2 = private unnamed_addr constant [ 4 x i8 ] c "Foo\00" , align 1
2015-03-14 02:20:45 +08:00
@_unnamed_cfstring_3 = private constant %struct.NSConstantString { i32 * getelementptr inbounds ( [ 0 x i32 ] , [ 0 x i32 ] * @__CFConstantStringClassReference , i32 0 , i32 0 ) , i32 1992 , i8 * getelementptr inbounds ( [ 4 x i8 ] , [ 4 x i8 ] * @.str2 , i32 0 , i32 0 ) , i64 3 } , section "__DATA,__cfstring"
2013-01-17 05:07:18 +08:00
@"\01L_OBJC_METH_VAR_NAME_4" = internal global [ 14 x i8 ] c "raise:format:\00" , section "__TEXT,__objc_methname,cstring_literals" , align 1
2015-03-14 02:20:45 +08:00
@"\01L_OBJC_SELECTOR_REFERENCES_5" = internal global i8 * getelementptr inbounds ( [ 14 x i8 ] , [ 14 x i8 ] * @"\01L_OBJC_METH_VAR_NAME_4" , i64 0 , i64 0 ) , section "__DATA, __objc_selrefs, literal_pointers, no_dead_strip"
@llvm.used = appending global [ 6 x i8 * ] [ i8 * bitcast ( %struct._class_t * * @"\01L_OBJC_CLASSLIST_REFERENCES_$_" to i8 * ) , i8 * getelementptr inbounds ( [ 4 x i8 ] , [ 4 x i8 ] * @"\01L_OBJC_METH_VAR_NAME_" , i32 0 , i32 0 ) , i8 * bitcast ( i8 * * @"\01L_OBJC_SELECTOR_REFERENCES_" to i8 * ) , i8 * bitcast ( %struct._class_t * * @"\01L_OBJC_CLASSLIST_REFERENCES_$_1" to i8 * ) , i8 * getelementptr inbounds ( [ 14 x i8 ] , [ 14 x i8 ] * @"\01L_OBJC_METH_VAR_NAME_4" , i32 0 , i32 0 ) , i8 * bitcast ( i8 * * @"\01L_OBJC_SELECTOR_REFERENCES_5" to i8 * ) ] , section "llvm.metadata"
2013-01-17 05:07:18 +08:00
2015-06-18 04:52:32 +08:00
define i32 @main ( ) uwtable ssp personality i8 * bitcast ( i32 ( . . . ) * @__objc_personality_v0 to i8 * ) {
2013-01-17 05:07:18 +08:00
entry:
2015-02-28 05:17:42 +08:00
%tmp = load %struct._class_t * , %struct._class_t * * @"\01L_OBJC_CLASSLIST_REFERENCES_$_" , align 8 , !dbg !37
%tmp1 = load i8 * , i8 * * @"\01L_OBJC_SELECTOR_REFERENCES_" , align 8 , !dbg !37 , !invariant.load !38
2013-01-17 05:07:18 +08:00
%tmp2 = bitcast %struct._class_t * %tmp to i8 * , !dbg !37
; CHECK: call i8* bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to i8* (i8*, i8*)*)(i8* %tmp2, i8* %tmp1)
%call = call i8 * bitcast ( i8 * ( i8 * , i8 * , . . . ) * @objc_msgSend to i8 * ( i8 * , i8 * ) * ) ( i8 * %tmp2 , i8 * %tmp1 ) , !dbg !37 , !clang.arc.no_objc_arc_exceptions !38
2015-04-30 00:38:44 +08:00
call void @llvm.dbg.value ( metadata i8 * %call , i64 0 , metadata !25 , metadata !DIExpression ( ) ) , !dbg !37
2013-02-22 17:09:42 +08:00
; CHECK: call i8* @objc_retain(i8* %call) [[NUW:#[0-9]+]]
2013-01-17 05:07:18 +08:00
%tmp3 = call i8 * @objc_retain ( i8 * %call ) nounwind , !dbg !39
2015-04-30 00:38:44 +08:00
call void @llvm.dbg.value ( metadata i8 * %call , i64 0 , metadata !25 , metadata !DIExpression ( ) ) , !dbg !39
2013-01-17 05:07:18 +08:00
invoke fastcc void @ThrowFunc ( i8 * %call )
to label %eh.cont unwind label %lpad , !dbg !40 , !clang.arc.no_objc_arc_exceptions !38
eh.cont: ; preds = %entry
; CHECK: call void @objc_release(i8* %call)
call void @objc_release ( i8 * %call ) nounwind , !dbg !42 , !clang.imprecise_release !38
br label %if.end , !dbg !43
lpad: ; preds = %entry
2015-06-18 04:52:32 +08:00
%tmp4 = landingpad { i8 * , i32 }
2013-01-17 05:07:18 +08:00
catch i8 * null , !dbg !40
%tmp5 = extractvalue { i8 * , i32 } %tmp4 , 0 , !dbg !40
%exn.adjusted = call i8 * @objc_begin_catch ( i8 * %tmp5 ) nounwind , !dbg !44
2015-04-30 00:38:44 +08:00
call void @llvm.dbg.value ( metadata i8 0 , i64 0 , metadata !21 , metadata !DIExpression ( ) ) , !dbg !46
2013-01-17 05:07:18 +08:00
call void @objc_end_catch ( ) , !dbg !49 , !clang.arc.no_objc_arc_exceptions !38
; CHECK: call void @objc_release(i8* %call)
call void @objc_release ( i8 * %call ) nounwind , !dbg !42 , !clang.imprecise_release !38
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 07:24:18 +08:00
call void ( i8 * , . . . ) @NSLog ( i8 * bitcast ( %struct.NSConstantString * @_unnamed_cfstring_ to i8 * ) , i8 * %call ) , !dbg !50 , !clang.arc.no_objc_arc_exceptions !38
2013-01-17 05:07:18 +08:00
br label %if.end , !dbg !52
if.end: ; preds = %lpad, %eh.cont
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 07:24:18 +08:00
call void ( i8 * , . . . ) @NSLog ( i8 * bitcast ( %struct.NSConstantString * @_unnamed_cfstring_ to i8 * ) , i8 * %call ) , !dbg !53 , !clang.arc.no_objc_arc_exceptions !38
2013-01-17 05:07:18 +08:00
; CHECK: call void @objc_release(i8* %call)
call void @objc_release ( i8 * %call ) nounwind , !dbg !54 , !clang.imprecise_release !38
ret i32 0 , !dbg !54
}
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
llvm-svn: 218787
2014-10-02 02:55:02 +08:00
declare void @llvm.dbg.declare ( metadata , metadata , metadata ) nounwind readnone
2013-01-17 05:07:18 +08:00
declare i8 * @objc_msgSend ( i8 * , i8 * , . . . ) nonlazybind
declare i8 * @objc_retain ( i8 * ) nonlazybind
declare i8 * @objc_begin_catch ( i8 * )
declare void @objc_end_catch ( )
declare void @objc_exception_rethrow ( )
define internal fastcc void @ThrowFunc ( i8 * %obj ) uwtable noinline ssp {
entry:
%tmp = call i8 * @objc_retain ( i8 * %obj ) nounwind
2015-04-30 00:38:44 +08:00
call void @llvm.dbg.value ( metadata i8 * %obj , i64 0 , metadata !32 , metadata !DIExpression ( ) ) , !dbg !55
2015-02-28 05:17:42 +08:00
%tmp1 = load %struct._class_t * , %struct._class_t * * @"\01L_OBJC_CLASSLIST_REFERENCES_$_1" , align 8 , !dbg !56
%tmp2 = load i8 * , i8 * * @"\01L_OBJC_SELECTOR_REFERENCES_5" , align 8 , !dbg !56 , !invariant.load !38
2013-01-17 05:07:18 +08:00
%tmp3 = bitcast %struct._class_t * %tmp1 to i8 * , !dbg !56
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 07:24:18 +08:00
call void ( i8 * , i8 * , %0 * , %0 * , . . . ) bitcast ( i8 * ( i8 * , i8 * , . . . ) * @objc_msgSend to void ( i8 * , i8 * , %0 * , %0 * , . . . ) * ) ( i8 * %tmp3 , i8 * %tmp2 , %0 * bitcast ( %struct.NSConstantString * @_unnamed_cfstring_3 to %0 * ) , %0 * bitcast ( %struct.NSConstantString * @_unnamed_cfstring_3 to %0 * ) ) , !dbg !56 , !clang.arc.no_objc_arc_exceptions !38
2013-01-17 05:07:18 +08:00
call void @objc_release ( i8 * %obj ) nounwind , !dbg !58 , !clang.imprecise_release !38
ret void , !dbg !58
}
declare i32 @__objc_personality_v0 ( . . . )
declare void @objc_release ( i8 * ) nonlazybind
declare void @NSLog ( i8 * , . . . )
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
llvm-svn: 218787
2014-10-02 02:55:02 +08:00
declare void @llvm.dbg.value ( metadata , i64 , metadata , metadata ) nounwind readnone
2013-01-17 05:07:18 +08:00
2013-02-22 17:09:42 +08:00
; CHECK: attributes #0 = { ssp uwtable }
; CHECK: attributes #1 = { nounwind readnone }
; CHECK: attributes #2 = { nonlazybind }
; CHECK: attributes #3 = { noinline ssp uwtable }
; CHECK: attributes [[NUW]] = { nounwind }
2013-01-17 05:07:18 +08:00
!llvm.dbg.cu = ! { !0 }
2013-11-23 05:49:45 +08:00
!llvm.module.flags = ! { !33 , !34 , !35 , !36 , !61 }
2013-01-17 05:07:18 +08:00
2015-08-04 01:26:41 +08:00
!0 = distinct !DICompileUnit ( language: D W _ L A N G _ O b j C , producer: "clang version 3.3 " , isOptimized: true , runtimeVersion: 2 , emissionKind: 0 , file: !60 , enums: !1 , retainedTypes: !1 , subprograms: !3 , globals: !1 )
2015-03-28 04:46:33 +08:00
!1 = ! { }
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!3 = ! { !5 , !27 }
2015-08-29 04:26:49 +08:00
!5 = distinct !DISubprogram ( name: "main" , line: 9 , isLocal: false , isDefinition: true , virtualIndex: 6 , isOptimized: true , scopeLine: 10 , file: !60 , scope: !6 , type: !7 , function: i32 ( ) * @main , variables: !11 )
2015-04-30 00:38:44 +08:00
!6 = !DIFile ( filename: "test.m" , directory: "/Volumes/Files/gottesmmcab/Radar/12906997" )
!7 = !DISubroutineType ( types: !8 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!8 = ! { !9 }
2015-04-30 00:38:44 +08:00
!9 = !DIBasicType ( tag: D W _ T A G _ b a s e _ type , name: "int" , size: 32 , align: 32 , encoding: D W _ A T E _ s i g n e d )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!11 = ! { !12 , !21 , !25 }
2015-08-01 02:58:39 +08:00
!12 = !DILocalVariable ( name: "obj" , line: 11 , scope: !13 , file: !6 , type: !14 )
2015-04-30 00:38:44 +08:00
!13 = distinct !DILexicalBlock ( line: 10 , column: 0 , file: !60 , scope: !5 )
!14 = !DIDerivedType ( tag: D W _ T A G _ t y p e d e f , name: "id" , line: 11 , file: !60 , baseType: !15 )
!15 = !DIDerivedType ( tag: D W _ T A G _ p o i n t e r _ type , size: 64 , align: 64 , file: !60 , baseType: !16 )
!16 = !DICompositeType ( tag: D W _ T A G _ s t r u c t u r e _ type , name: "objc_object" , file: !60 , elements: !17 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!17 = ! { !18 }
2015-04-30 00:38:44 +08:00
!18 = !DIDerivedType ( tag: D W _ T A G _ m e m b e r , name: "isa" , size: 64 , file: !60 , scope: !16 , baseType: !19 )
!19 = !DIDerivedType ( tag: D W _ T A G _ p o i n t e r _ type , size: 64 , baseType: !20 )
!20 = !DICompositeType ( tag: D W _ T A G _ s t r u c t u r e _ type , name: "objc_class" , flags: D I F l a g F w d D e c l , file: !60 )
2015-08-01 02:58:39 +08:00
!21 = !DILocalVariable ( name: "ok" , line: 13 , scope: !22 , file: !6 , type: !23 )
2015-04-30 00:38:44 +08:00
!22 = distinct !DILexicalBlock ( line: 12 , column: 0 , file: !60 , scope: !13 )
!23 = !DIDerivedType ( tag: D W _ T A G _ t y p e d e f , name: "BOOL" , line: 62 , file: !60 , baseType: !24 )
!24 = !DIBasicType ( tag: D W _ T A G _ b a s e _ type , name: "signed char" , size: 8 , align: 8 , encoding: D W _ A T E _ s i g n e d _ c h a r )
2015-08-01 02:58:39 +08:00
!25 = !DILocalVariable ( name: "obj2" , line: 15 , scope: !26 , file: !6 , type: !14 )
2015-04-30 00:38:44 +08:00
!26 = distinct !DILexicalBlock ( line: 14 , column: 0 , file: !60 , scope: !22 )
2015-08-29 04:26:49 +08:00
!27 = distinct !DISubprogram ( name: "ThrowFunc" , line: 4 , isLocal: true , isDefinition: true , virtualIndex: 6 , flags: D I F l a g P r o t o t y p e d , isOptimized: true , scopeLine: 5 , file: !60 , scope: !6 , type: !28 , function: void ( i8 * ) * @ThrowFunc , variables: !31 )
2015-04-30 00:38:44 +08:00
!28 = !DISubroutineType ( types: !29 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!29 = ! { null , !14 }
!31 = ! { !32 }
2015-08-01 02:58:39 +08:00
!32 = !DILocalVariable ( name: "obj" , line: 4 , arg: 1 , scope: !27 , file: !6 , type: !14 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!33 = ! { i32 1 , !"Objective-C Version" , i32 2 }
!34 = ! { i32 1 , !"Objective-C Image Info Version" , i32 0 }
!35 = ! { i32 1 , !"Objective-C Image Info Section" , !"__DATA, __objc_imageinfo, regular, no_dead_strip" }
!36 = ! { i32 4 , !"Objective-C Garbage Collection" , i32 0 }
2015-04-30 00:38:44 +08:00
!37 = !DILocation ( line: 11 , scope: !13 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!38 = ! { }
2015-04-30 00:38:44 +08:00
!39 = !DILocation ( line: 15 , scope: !26 )
!40 = !DILocation ( line: 17 , scope: !41 )
!41 = distinct !DILexicalBlock ( line: 16 , column: 0 , file: !60 , scope: !26 )
!42 = !DILocation ( line: 22 , scope: !26 )
!43 = !DILocation ( line: 23 , scope: !22 )
!44 = !DILocation ( line: 19 , scope: !41 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!45 = ! { i8 0 }
2015-04-30 00:38:44 +08:00
!46 = !DILocation ( line: 20 , scope: !47 )
!47 = distinct !DILexicalBlock ( line: 19 , column: 0 , file: !60 , scope: !48 )
!48 = distinct !DILexicalBlock ( line: 19 , column: 0 , file: !60 , scope: !26 )
!49 = !DILocation ( line: 21 , scope: !47 )
!50 = !DILocation ( line: 24 , scope: !51 )
!51 = distinct !DILexicalBlock ( line: 23 , column: 0 , file: !60 , scope: !22 )
!52 = !DILocation ( line: 25 , scope: !51 )
!53 = !DILocation ( line: 27 , scope: !13 )
!54 = !DILocation ( line: 28 , scope: !13 )
!55 = !DILocation ( line: 4 , scope: !27 )
!56 = !DILocation ( line: 6 , scope: !57 )
!57 = distinct !DILexicalBlock ( line: 5 , column: 0 , file: !60 , scope: !27 )
!58 = !DILocation ( line: 7 , scope: !57 )
!60 = !DIFile ( filename: "test.m" , directory: "/Volumes/Files/gottesmmcab/Radar/12906997" )
2015-03-04 01:24:31 +08:00
!61 = ! { i32 1 , !"Debug Info Version" , i32 3 }