[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"
Summary:
Most libraries are defined in the lib/ directory but there are also a
few libraries defined in tools/ e.g. libLLVM, libLTO. I'm defining
"Component Libraries" as libraries defined in lib/ that may be included in
libLLVM.so. Explicitly marking the libraries in lib/ as component
libraries allows us to remove some fragile checks that attempt to
differentiate between lib/ libraries and tools/ libraires:
1. In tools/llvm-shlib, because
llvm_map_components_to_libnames(LIB_NAMES "all") returned a list of
all libraries defined in the whole project, there was custom code
needed to filter out libraries defined in tools/, none of which should
be included in libLLVM.so. This code assumed that any library
defined as static was from lib/ and everything else should be
excluded.
With this change, llvm_map_components_to_libnames(LIB_NAMES, "all")
only returns libraries that have been added to the LLVM_COMPONENT_LIBS
global cmake property, so this custom filtering logic can be removed.
Doing this also fixes the build with BUILD_SHARED_LIBS=ON
and LLVM_BUILD_LLVM_DYLIB=ON.
2. There was some code in llvm_add_library that assumed that
libraries defined in lib/ would not have LLVM_LINK_COMPONENTS or
ARG_LINK_COMPONENTS set. This is only true because libraries
defined lib lib/ use LLVMBuild.txt and don't set these values.
This code has been fixed now to check if the library has been
explicitly marked as a component library, which should now make it
easier to remove LLVMBuild at some point in the future.
I have tested this patch on Windows, MacOS and Linux with release builds
and the following combinations of CMake options:
- "" (No options)
- -DLLVM_BUILD_LLVM_DYLIB=ON
- -DLLVM_LINK_LLVM_DYLIB=ON
- -DBUILD_SHARED_LIBS=ON
- -DBUILD_SHARED_LIBS=ON -DLLVM_BUILD_LLVM_DYLIB=ON
- -DBUILD_SHARED_LIBS=ON -DLLVM_LINK_LLVM_DYLIB=ON
Reviewers: beanz, smeenai, compnerd, phosek
Reviewed By: beanz
Subscribers: wuzish, jholewinski, arsenm, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, mgorny, mehdi_amini, sbc100, jgravelle-google, hiraditya, aheejin, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, steven_wu, rogfer01, MartinMosbeck, brucehoult, the_o, dexonsmith, PkmX, jocewei, jsji, dang, Jim, lenary, s.egerton, pzheng, sameer.abuasal, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70179
2019-11-14 13:39:58 +08:00
|
|
|
add_llvm_component_library(LLVMAsmPrinter
|
2018-01-29 22:52:41 +08:00
|
|
|
AccelTable.cpp
|
2014-04-24 05:04:59 +08:00
|
|
|
AddressPool.cpp
|
2011-03-06 08:13:15 +08:00
|
|
|
ARMException.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
AsmPrinter.cpp
|
2010-04-05 03:09:29 +08:00
|
|
|
AsmPrinterDwarf.cpp
|
2010-04-05 02:34:07 +08:00
|
|
|
AsmPrinterInlineAsm.cpp
|
2018-08-17 23:22:04 +08:00
|
|
|
DbgEntityHistoryCalculator.cpp
|
2016-02-11 04:55:49 +08:00
|
|
|
DebugHandlerBase.cpp
|
2015-06-22 00:54:56 +08:00
|
|
|
DebugLocStream.cpp
|
2009-05-19 08:18:14 +08:00
|
|
|
DIE.cpp
|
2013-08-09 07:51:31 +08:00
|
|
|
DIEHash.cpp
|
2011-01-15 06:58:11 +08:00
|
|
|
DwarfCFIException.cpp
|
2014-10-04 23:49:50 +08:00
|
|
|
DwarfCompileUnit.cpp
|
2009-05-19 08:18:14 +08:00
|
|
|
DwarfDebug.cpp
|
2015-01-13 06:19:22 +08:00
|
|
|
DwarfExpression.cpp
|
2014-04-24 02:54:00 +08:00
|
|
|
DwarfFile.cpp
|
2014-04-26 05:34:35 +08:00
|
|
|
DwarfStringPool.cpp
|
2013-12-03 03:33:15 +08:00
|
|
|
DwarfUnit.cpp
|
2014-06-11 09:19:03 +08:00
|
|
|
EHStreamer.cpp
|
2013-03-25 22:12:21 +08:00
|
|
|
ErlangGCPrinter.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
OcamlGCPrinter.cpp
|
2018-01-10 07:49:30 +08:00
|
|
|
WinCFGuard.cpp
|
2015-05-29 06:47:01 +08:00
|
|
|
WinException.cpp
|
2016-01-15 03:25:04 +08:00
|
|
|
CodeViewDebug.cpp
|
Reland "[WebAssembly] LSDA info generation"
Summary:
This adds support for LSDA (exception table) generation for wasm EH.
Wasm EH mostly follows the structure of Itanium-style exception tables,
with one exception: a call site table entry in wasm EH corresponds to
not a call site but a landing pad.
In wasm EH, the VM is responsible for stack unwinding. After an
exception occurs and the stack is unwound, the control flow is
transferred to wasm 'catch' instruction by the VM, after which the
personality function is called from the compiler-generated code. (Refer
to WasmEHPrepare pass for more information on this part.)
This patch:
- Changes wasm.landingpad.index intrinsic to take a token argument, to
make this 1:1 match with a catchpad instruction
- Stores landingpad index info and catch type info MachineFunction in
before instruction selection
- Lowers wasm.lsda intrinsic to an MCSymbol pointing to the start of an
exception table
- Adds WasmException class with overridden methods for table generation
- Adds support for LSDA section in Wasm object writer
Reviewers: dschuff, sbc100, rnk
Subscribers: mgorny, jgravelle-google, sunfish, llvm-commits
Differential Revision: https://reviews.llvm.org/D52748
llvm-svn: 345345
2018-10-26 07:55:10 +08:00
|
|
|
WasmException.cpp
|
2013-08-06 13:56:39 +08:00
|
|
|
|
2016-11-17 12:36:50 +08:00
|
|
|
DEPENDS
|
|
|
|
intrinsics_gen
|
|
|
|
)
|