2017-02-18 03:36:19 +08:00
|
|
|
// RUN: %clang_cc1 %s -triple=x86_64-pc-linuxs -emit-llvm -std=c++98 -o - | FileCheck -check-prefix=CHECK -check-prefix=CHECK98 %s
|
|
|
|
|
// RUN: %clang_cc1 %s -triple=x86_64-pc-linuxs -emit-llvm -std=c++11 -o - | FileCheck -check-prefix=CHECK -check-prefix=CHECK11 %s
|
2010-01-26 12:02:23 +08:00
|
|
|
|
|
|
|
|
// CHECK: @_ZZ1hvE1i = internal global i32 0, align 4
|
2012-03-09 11:06:56 +08:00
|
|
|
// CHECK: @base_req = global [4 x i8] c"foo\00", align 1
|
2012-04-15 10:50:59 +08:00
|
|
|
// CHECK: @base_req_uchar = global [4 x i8] c"bar\00", align 1
|
2010-02-07 10:03:08 +08:00
|
|
|
|
2012-03-31 05:00:39 +08:00
|
|
|
// CHECK: @_ZZN5test31BC1EvE1u = internal global { i8, [3 x i8] } { i8 97, [3 x i8] undef }, align 4
|
2014-09-20 03:43:18 +08:00
|
|
|
|
Compute and preserve alignment more faithfully in IR-generation.
Introduce an Address type to bundle a pointer value with an
alignment. Introduce APIs on CGBuilderTy to work with Address
values. Change core APIs on CGF/CGM to traffic in Address where
appropriate. Require alignments to be non-zero. Update a ton
of code to compute and propagate alignment information.
As part of this, I've promoted CGBuiltin's EmitPointerWithAlignment
helper function to CGF and made use of it in a number of places in
the expression emitter.
The end result is that we should now be significantly more correct
when performing operations on objects that are locally known to
be under-aligned. Since alignment is not reliably tracked in the
type system, there are inherent limits to this, but at least we
are no longer confused by standard operations like derived-to-base
conversions and array-to-pointer decay. I've also fixed a large
number of bugs where we were applying the complete-object alignment
to a pointer instead of the non-virtual alignment, although most of
these were hidden by the very conservative approach we took with
member alignment.
Also, because IRGen now reliably asserts on zero alignments, we
should no longer be subject to an absurd but frustrating recurring
bug where an incomplete type would report a zero alignment and then
we'd naively do a alignmentAtOffset on it and emit code using an
alignment equal to the largest power-of-two factor of the offset.
We should also now be emitting much more aggressive alignment
attributes in the presence of over-alignment. In particular,
field access now uses alignmentAtOffset instead of min.
Several times in this patch, I had to change the existing
code-generation pattern in order to more effectively use
the Address APIs. For the most part, this seems to be a strict
improvement, like doing pointer arithmetic with GEPs instead of
ptrtoint. That said, I've tried very hard to not change semantics,
but it is likely that I've failed in a few places, for which I
apologize.
ABIArgInfo now always carries the assumed alignment of indirect and
indirect byval arguments. In order to cut down on what was already
a dauntingly large patch, I changed the code to never set align
attributes in the IR on non-byval indirect arguments. That is,
we still generate code which assumes that indirect arguments have
the given alignment, but we don't express this information to the
backend except where it's semantically required (i.e. on byvals).
This is likely a minor regression for those targets that did provide
this information, but it'll be trivial to add it back in a later
patch.
I partially punted on applying this work to CGBuiltin. Please
do not add more uses of the CreateDefaultAligned{Load,Store}
APIs; they will be going away eventually.
llvm-svn: 246985
2015-09-08 16:05:57 +08:00
|
|
|
// CHECK: @_ZZ2h2vE1i = linkonce_odr global i32 0, comdat, align 4
|
|
|
|
|
// CHECK: @_ZGVZ2h2vE1i = linkonce_odr global i64 0, comdat, align 8{{$}}
|
2015-01-22 08:24:57 +08:00
|
|
|
// CHECK: @_ZZN5test1L6getvarEiE3var = internal constant [4 x i32] [i32 1, i32 0, i32 2, i32 4], align 16
|
2017-02-18 03:36:19 +08:00
|
|
|
// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8
|
|
|
|
|
// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN5test49HasVTableE, i32 0, inrange i32 0, i32 2) }, comdat, align 8
|
2010-02-07 10:03:08 +08:00
|
|
|
|
2009-08-09 05:45:14 +08:00
|
|
|
struct A {
|
|
|
|
|
A();
|
|
|
|
|
~A();
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
void f() {
|
Compute and preserve alignment more faithfully in IR-generation.
Introduce an Address type to bundle a pointer value with an
alignment. Introduce APIs on CGBuilderTy to work with Address
values. Change core APIs on CGF/CGM to traffic in Address where
appropriate. Require alignments to be non-zero. Update a ton
of code to compute and propagate alignment information.
As part of this, I've promoted CGBuiltin's EmitPointerWithAlignment
helper function to CGF and made use of it in a number of places in
the expression emitter.
The end result is that we should now be significantly more correct
when performing operations on objects that are locally known to
be under-aligned. Since alignment is not reliably tracked in the
type system, there are inherent limits to this, but at least we
are no longer confused by standard operations like derived-to-base
conversions and array-to-pointer decay. I've also fixed a large
number of bugs where we were applying the complete-object alignment
to a pointer instead of the non-virtual alignment, although most of
these were hidden by the very conservative approach we took with
member alignment.
Also, because IRGen now reliably asserts on zero alignments, we
should no longer be subject to an absurd but frustrating recurring
bug where an incomplete type would report a zero alignment and then
we'd naively do a alignmentAtOffset on it and emit code using an
alignment equal to the largest power-of-two factor of the offset.
We should also now be emitting much more aggressive alignment
attributes in the presence of over-alignment. In particular,
field access now uses alignmentAtOffset instead of min.
Several times in this patch, I had to change the existing
code-generation pattern in order to more effectively use
the Address APIs. For the most part, this seems to be a strict
improvement, like doing pointer arithmetic with GEPs instead of
ptrtoint. That said, I've tried very hard to not change semantics,
but it is likely that I've failed in a few places, for which I
apologize.
ABIArgInfo now always carries the assumed alignment of indirect and
indirect byval arguments. In order to cut down on what was already
a dauntingly large patch, I changed the code to never set align
attributes in the IR on non-byval indirect arguments. That is,
we still generate code which assumes that indirect arguments have
the given alignment, but we don't express this information to the
backend except where it's semantically required (i.e. on byvals).
This is likely a minor regression for those targets that did provide
this information, but it'll be trivial to add it back in a later
patch.
I partially punted on applying this work to CGBuiltin. Please
do not add more uses of the CreateDefaultAligned{Load,Store}
APIs; they will be going away eventually.
llvm-svn: 246985
2015-09-08 16:05:57 +08:00
|
|
|
// CHECK: load atomic i8, i8* bitcast (i64* @_ZGVZ1fvE1a to i8*) acquire, align 8
|
2010-05-05 23:38:32 +08:00
|
|
|
// CHECK: call i32 @__cxa_guard_acquire
|
|
|
|
|
// CHECK: call void @_ZN1AC1Ev
|
2015-03-14 02:21:46 +08:00
|
|
|
// CHECK: call i32 @__cxa_atexit(void (i8*)* bitcast (void (%struct.A*)* @_ZN1AD1Ev to void (i8*)*), i8* getelementptr inbounds (%struct.A, %struct.A* @_ZZ1fvE1a, i32 0, i32 0), i8* @__dso_handle)
|
2010-09-08 09:44:27 +08:00
|
|
|
// CHECK: call void @__cxa_guard_release
|
2009-08-09 05:45:14 +08:00
|
|
|
static A a;
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-10 09:05:11 +08:00
|
|
|
void g() {
|
2016-04-08 05:46:12 +08:00
|
|
|
// CHECK: call i8* @_Znwm(i64 1)
|
2009-12-10 09:05:11 +08:00
|
|
|
// CHECK: call void @_ZN1AC1Ev(
|
|
|
|
|
static A& a = *new A;
|
|
|
|
|
}
|
2010-01-26 12:02:23 +08:00
|
|
|
|
|
|
|
|
int a();
|
|
|
|
|
void h() {
|
|
|
|
|
static const int i = a();
|
|
|
|
|
}
|
2010-02-07 10:03:08 +08:00
|
|
|
|
2015-01-13 06:13:53 +08:00
|
|
|
// CHECK: define linkonce_odr void @_Z2h2v() {{.*}} comdat {
|
2010-02-07 10:03:08 +08:00
|
|
|
inline void h2() {
|
|
|
|
|
static int i = a();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void h3() {
|
|
|
|
|
h2();
|
|
|
|
|
}
|
2010-05-04 05:39:56 +08:00
|
|
|
|
|
|
|
|
// PR6980: this shouldn't crash
|
|
|
|
|
namespace test0 {
|
|
|
|
|
struct A { A(); };
|
|
|
|
|
__attribute__((noreturn)) int throw_exception();
|
|
|
|
|
|
|
|
|
|
void test() {
|
|
|
|
|
throw_exception();
|
|
|
|
|
static A r;
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-05-25 12:30:21 +08:00
|
|
|
|
|
|
|
|
namespace test1 {
|
2013-08-15 14:47:53 +08:00
|
|
|
// CHECK-LABEL: define internal i32 @_ZN5test1L6getvarEi(
|
2010-05-25 12:30:21 +08:00
|
|
|
static inline int getvar(int index) {
|
|
|
|
|
static const int var[] = { 1, 0, 2, 4 };
|
|
|
|
|
return var[index];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void test() { (void) getvar(2); }
|
|
|
|
|
}
|
2012-03-09 11:06:56 +08:00
|
|
|
|
|
|
|
|
// Make sure we emit the initializer correctly for the following:
|
|
|
|
|
char base_req[] = { "foo" };
|
2012-04-15 10:50:59 +08:00
|
|
|
unsigned char base_req_uchar[] = { "bar" };
|
2012-03-09 11:27:46 +08:00
|
|
|
|
|
|
|
|
namespace union_static_local {
|
2013-08-15 14:47:53 +08:00
|
|
|
// CHECK-LABEL: define internal void @_ZZN18union_static_local4testEvEN1c4mainEv
|
2012-03-09 11:27:46 +08:00
|
|
|
// CHECK: call void @_ZN18union_static_local1fEPNS_1xE(%"union.union_static_local::x"* bitcast ({ [2 x i8*] }* @_ZZN18union_static_local4testEvE3foo to %"union.union_static_local::x"*))
|
|
|
|
|
union x { long double y; const char *x[2]; };
|
|
|
|
|
void f(union x*);
|
|
|
|
|
void test() {
|
|
|
|
|
static union x foo = { .x = { "a", "b" } };
|
|
|
|
|
struct c {
|
|
|
|
|
static void main() {
|
|
|
|
|
f(&foo);
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
c::main();
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-03-31 05:00:39 +08:00
|
|
|
|
|
|
|
|
// rdar://problem/11091093
|
|
|
|
|
// Static variables should be consistent across constructor
|
|
|
|
|
// or destructor variants.
|
|
|
|
|
namespace test2 {
|
|
|
|
|
struct A {
|
|
|
|
|
A();
|
|
|
|
|
~A();
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct B : virtual A {
|
|
|
|
|
B();
|
|
|
|
|
~B();
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// If we ever implement this as a delegate ctor call, just change
|
|
|
|
|
// this to take variadic arguments or something.
|
|
|
|
|
extern int foo();
|
|
|
|
|
B::B() {
|
|
|
|
|
static int x = foo();
|
|
|
|
|
}
|
2013-12-09 22:51:17 +08:00
|
|
|
// CHECK-LABEL: define void @_ZN5test21BC2Ev
|
2015-02-28 05:19:58 +08:00
|
|
|
// CHECK: load atomic i8, i8* bitcast (i64* @_ZGVZN5test21BC1EvE1x to i8*) acquire,
|
2012-03-31 05:00:39 +08:00
|
|
|
// CHECK: call i32 @__cxa_guard_acquire(i64* @_ZGVZN5test21BC1EvE1x)
|
|
|
|
|
// CHECK: [[T0:%.*]] = call i32 @_ZN5test23fooEv()
|
|
|
|
|
// CHECK: store i32 [[T0]], i32* @_ZZN5test21BC1EvE1x,
|
|
|
|
|
// CHECK: call void @__cxa_guard_release(i64* @_ZGVZN5test21BC1EvE1x)
|
|
|
|
|
|
2013-12-09 22:51:17 +08:00
|
|
|
// CHECK-LABEL: define void @_ZN5test21BC1Ev
|
2015-02-28 05:19:58 +08:00
|
|
|
// CHECK: load atomic i8, i8* bitcast (i64* @_ZGVZN5test21BC1EvE1x to i8*) acquire,
|
2012-03-31 05:00:39 +08:00
|
|
|
// CHECK: call i32 @__cxa_guard_acquire(i64* @_ZGVZN5test21BC1EvE1x)
|
|
|
|
|
// CHECK: [[T0:%.*]] = call i32 @_ZN5test23fooEv()
|
|
|
|
|
// CHECK: store i32 [[T0]], i32* @_ZZN5test21BC1EvE1x,
|
|
|
|
|
// CHECK: call void @__cxa_guard_release(i64* @_ZGVZN5test21BC1EvE1x)
|
|
|
|
|
|
|
|
|
|
// This is just for completeness, because we actually emit this
|
|
|
|
|
// using a delegate dtor call.
|
|
|
|
|
B::~B() {
|
|
|
|
|
static int y = foo();
|
|
|
|
|
}
|
2013-08-15 14:47:53 +08:00
|
|
|
// CHECK-LABEL: define void @_ZN5test21BD2Ev(
|
2015-02-28 05:19:58 +08:00
|
|
|
// CHECK: load atomic i8, i8* bitcast (i64* @_ZGVZN5test21BD1EvE1y to i8*) acquire,
|
2012-03-31 05:00:39 +08:00
|
|
|
// CHECK: call i32 @__cxa_guard_acquire(i64* @_ZGVZN5test21BD1EvE1y)
|
|
|
|
|
// CHECK: [[T0:%.*]] = call i32 @_ZN5test23fooEv()
|
|
|
|
|
// CHECK: store i32 [[T0]], i32* @_ZZN5test21BD1EvE1y,
|
|
|
|
|
// CHECK: call void @__cxa_guard_release(i64* @_ZGVZN5test21BD1EvE1y)
|
2013-12-09 22:51:17 +08:00
|
|
|
|
|
|
|
|
// CHECK-LABEL: define void @_ZN5test21BD1Ev(
|
|
|
|
|
// CHECK: call void @_ZN5test21BD2Ev(
|
2012-03-31 05:00:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// This shouldn't error out.
|
|
|
|
|
namespace test3 {
|
|
|
|
|
struct A {
|
|
|
|
|
A();
|
|
|
|
|
~A();
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct B : virtual A {
|
|
|
|
|
B();
|
|
|
|
|
~B();
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
B::B() {
|
|
|
|
|
union U { char x; int i; };
|
|
|
|
|
static U u = { 'a' };
|
|
|
|
|
}
|
2013-08-15 14:47:53 +08:00
|
|
|
// CHECK-LABEL: define void @_ZN5test31BC2Ev(
|
2013-12-09 22:51:17 +08:00
|
|
|
// CHECK-LABEL: define void @_ZN5test31BC1Ev(
|
2012-03-31 05:00:39 +08:00
|
|
|
}
|
2015-07-21 04:35:30 +08:00
|
|
|
|
|
|
|
|
// We forgot to set the comdat when replacing the global with a different type.
|
|
|
|
|
namespace test4 {
|
|
|
|
|
struct HasVTable {
|
|
|
|
|
virtual void f();
|
|
|
|
|
};
|
|
|
|
|
inline HasVTable &useStaticLocal() {
|
|
|
|
|
static HasVTable obj;
|
|
|
|
|
return obj;
|
|
|
|
|
}
|
|
|
|
|
void useit() {
|
|
|
|
|
useStaticLocal();
|
|
|
|
|
}
|
|
|
|
|
// CHECK: define linkonce_odr dereferenceable(8) %"struct.test4::HasVTable"* @_ZN5test414useStaticLocalEv()
|
2017-02-18 03:36:19 +08:00
|
|
|
// CHECK: ret %"struct.test4::HasVTable"*{{.*}} @_ZZN5test414useStaticLocalEvE3obj
|
2015-07-21 04:35:30 +08:00
|
|
|
}
|