maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lldb/unittests/Platform/PlatformDarwinTest.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

135 lines
5.4 KiB
C++
Raw Normal View History

[lldb][NFC] Fix all formatting errors in .cpp file headers Summary: A *.cpp file header in LLDB (and in LLDB) should like this: ``` //===-- TestUtilities.cpp -------------------------------------------------===// ``` However in LLDB most of our source files have arbitrary changes to this format and these changes are spreading through LLDB as folks usually just use the existing source files as templates for their new files (most notably the unnecessary editor language indicator `-*- C++ -*-` is spreading and in every review someone is pointing out that this is wrong, resulting in people pointing out that this is done in the same way in other files). This patch removes most of these inconsistencies including the editor language indicators, all the different missing/additional '-' characters, files that center the file name, missing trailing `===//` (mostly caused by clang-format breaking the line). Reviewers: aprantl, espindola, jfb, shafik, JDevlieghere Reviewed By: JDevlieghere Subscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D73258
2020-01-24 15:23:27 +08:00
//===-- PlatformDarwinTest.cpp --------------------------------------------===//
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
//
Update the file headers across all of the LLVM projects in the monorepo to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
2019-01-19 16:50:56 +08:00
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
//
//===----------------------------------------------------------------------===//
#include "gtest/gtest.h"
#include "Plugins/Platform/MacOSX/PlatformDarwin.h"
#include "llvm/ADT/StringRef.h"
#include <tuple>
using namespace lldb;
using namespace lldb_private;
Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (e.g.: trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" fails after that patch). Fixed here by stripping the ".sdk" suffix first. (Part of) rdar://problem/45041492 Differential Revision https://reviews.llvm.org/D53677 llvm-svn: 345274
2018-10-25 23:30:43 +08:00
struct PlatformDarwinTester : public PlatformDarwin {
[lldb/PlatformDarwin] Be more robust in computing the SDK path with xcrun The current implementation isn't very resilient when it comes to the output of xcrun. Currently it cannot deal with: - Trailing newlines. - Leading newlines and errors/warnings before the Xcode path. - Xcode not being named Xcode.app. This extract the logic into a helper in PlatformDarwin and fixes those issues. It's also the first step towards removing code duplication between the different platforms and downstream Swift. Differential revision: https://reviews.llvm.org/D76261
2020-03-18 05:28:34 +08:00
public:
using PlatformDarwin::FindXcodeContentsDirectoryInPath;
Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (e.g.: trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" fails after that patch). Fixed here by stripping the ".sdk" suffix first. (Part of) rdar://problem/45041492 Differential Revision https://reviews.llvm.org/D53677 llvm-svn: 345274
2018-10-25 23:30:43 +08:00
static bool SDKSupportsModules(SDKType desired_type,
const lldb_private::FileSpec &sdk_path) {
return PlatformDarwin::SDKSupportsModules(desired_type, sdk_path);
}
};
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
TEST(PlatformDarwinTest, TestParseVersionBuildDir) {
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
llvm::VersionTuple V;
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
llvm::StringRef D;
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
std::tie(V, D) = PlatformDarwin::ParseVersionBuildDir("1.2.3 (test1)");
EXPECT_EQ(llvm::VersionTuple(1, 2, 3), V);
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
EXPECT_EQ("test1", D);
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
std::tie(V, D) = PlatformDarwin::ParseVersionBuildDir("2.3 (test2)");
EXPECT_EQ(llvm::VersionTuple(2, 3), V);
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
EXPECT_EQ("test2", D);
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
std::tie(V, D) = PlatformDarwin::ParseVersionBuildDir("3 (test3)");
EXPECT_EQ(llvm::VersionTuple(3), V);
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
EXPECT_EQ("test3", D);
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
std::tie(V, D) = PlatformDarwin::ParseVersionBuildDir("1.2.3 (test");
EXPECT_EQ(llvm::VersionTuple(1, 2, 3), V);
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
EXPECT_EQ("test", D);
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
std::tie(V, D) = PlatformDarwin::ParseVersionBuildDir("2.3.4 test");
EXPECT_EQ(llvm::VersionTuple(2, 3, 4), V);
Convert many functions to use StringRefs. Where possible, remove the const char* version. To keep the risk and impact here minimal, I've only done the simplest functions. In the process, I found a few opportunities for adding some unit tests, so I added those as well. Tested on Windows, Linux, and OSX. llvm-svn: 281799
2016-09-17 10:00:02 +08:00
EXPECT_EQ("", D);
Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead of three - no need to default initialize variables - no custom parsing code - VersionTuple has comparison operators, which makes version comparisons much simpler Reviewers: zturner, friss, clayborg, jingham Subscribers: emaste, lldb-commits Differential Revision: https://reviews.llvm.org/D47889 llvm-svn: 334950
2018-06-18 23:02:23 +08:00
std::tie(V, D) = PlatformDarwin::ParseVersionBuildDir("3.4.5");
EXPECT_EQ(llvm::VersionTuple(3, 4, 5), V);
Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (e.g.: trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" fails after that patch). Fixed here by stripping the ".sdk" suffix first. (Part of) rdar://problem/45041492 Differential Revision https://reviews.llvm.org/D53677 llvm-svn: 345274
2018-10-25 23:30:43 +08:00
std::string base = "/Applications/Xcode.app/Contents/Developer/Platforms/";
EXPECT_TRUE(PlatformDarwinTester::SDKSupportsModules(
PlatformDarwin::SDKType::iPhoneSimulator,
[FileSystem] Move path resolution logic out of FileSpec This patch removes the logic for resolving paths out of FileSpec and updates call sites to rely on the FileSystem class instead. Differential revision: https://reviews.llvm.org/D53915 llvm-svn: 345890
2018-11-02 05:05:36 +08:00
FileSpec(
base +
"iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.0.sdk")));
Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (e.g.: trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" fails after that patch). Fixed here by stripping the ".sdk" suffix first. (Part of) rdar://problem/45041492 Differential Revision https://reviews.llvm.org/D53677 llvm-svn: 345274
2018-10-25 23:30:43 +08:00
EXPECT_FALSE(PlatformDarwinTester::SDKSupportsModules(
PlatformDarwin::SDKType::iPhoneSimulator,
[FileSystem] Move path resolution logic out of FileSpec This patch removes the logic for resolving paths out of FileSpec and updates call sites to rely on the FileSystem class instead. Differential revision: https://reviews.llvm.org/D53915 llvm-svn: 345890
2018-11-02 05:05:36 +08:00
FileSpec(
base +
"iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator7.2.sdk")));
Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (e.g.: trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" fails after that patch). Fixed here by stripping the ".sdk" suffix first. (Part of) rdar://problem/45041492 Differential Revision https://reviews.llvm.org/D53677 llvm-svn: 345274
2018-10-25 23:30:43 +08:00
EXPECT_TRUE(PlatformDarwinTester::SDKSupportsModules(
PlatformDarwin::SDKType::MacOSX,
[FileSystem] Move path resolution logic out of FileSpec This patch removes the logic for resolving paths out of FileSpec and updates call sites to rely on the FileSystem class instead. Differential revision: https://reviews.llvm.org/D53915 llvm-svn: 345890
2018-11-02 05:05:36 +08:00
FileSpec(base + "MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk")));
Fix a bug PlatformDarwin::SDKSupportsModule. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (e.g.: trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" fails after that patch). Fixed here by stripping the ".sdk" suffix first. (Part of) rdar://problem/45041492 Differential Revision https://reviews.llvm.org/D53677 llvm-svn: 345274
2018-10-25 23:30:43 +08:00
EXPECT_FALSE(PlatformDarwinTester::SDKSupportsModules(
PlatformDarwin::SDKType::MacOSX,
[FileSystem] Move path resolution logic out of FileSpec This patch removes the logic for resolving paths out of FileSpec and updates call sites to rely on the FileSystem class instead. Differential revision: https://reviews.llvm.org/D53915 llvm-svn: 345890
2018-11-02 05:05:36 +08:00
FileSpec(base + "MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk")));
Fix compiler warnings in PlatformDarwinTest.cpp llvm-svn: 283651
2016-10-08 12:03:15 +08:00
}
[lldb/PlatformDarwin] Be more robust in computing the SDK path with xcrun The current implementation isn't very resilient when it comes to the output of xcrun. Currently it cannot deal with: - Trailing newlines. - Leading newlines and errors/warnings before the Xcode path. - Xcode not being named Xcode.app. This extract the logic into a helper in PlatformDarwin and fixes those issues. It's also the first step towards removing code duplication between the different platforms and downstream Swift. Differential revision: https://reviews.llvm.org/D76261
2020-03-18 05:28:34 +08:00
TEST(PlatformDarwinTest, FindXcodeContentsDirectoryInPath) {
std::string standard =
"/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/"
"Developer/SDKs/MacOSX.sdk";
EXPECT_EQ("/Applications/Xcode.app/Contents",
PlatformDarwinTester::FindXcodeContentsDirectoryInPath(standard));
std::string standard_version =
"/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/"
"Developer/SDKs/MacOSX10.15.sdk";
EXPECT_EQ(
"/Applications/Xcode.app/Contents",
PlatformDarwinTester::FindXcodeContentsDirectoryInPath(standard_version));
std::string beta = "/Applications/Xcode-beta.app/Contents/Developer/"
"Platforms/MacOSX.platform/"
"Developer/SDKs/MacOSX10.15.sdk";
EXPECT_EQ("/Applications/Xcode-beta.app/Contents",
PlatformDarwinTester::FindXcodeContentsDirectoryInPath(beta));
std::string no_app =
"/Applications/Xcode/Contents/Developer/Platforms/MacOSX.platform/"
"Developer/SDKs/MacOSX10.15.sdk";
EXPECT_EQ("", PlatformDarwinTester::FindXcodeContentsDirectoryInPath(no_app));
std::string no_contents =
"/Applications/Xcode.app/Developer/Platforms/MacOSX.platform/"
"Developer/SDKs/MacOSX10.15.sdk";
EXPECT_EQ(
"", PlatformDarwinTester::FindXcodeContentsDirectoryInPath(no_contents));
std::string no_capitalization =
"/Applications/Xcode.app/contents/Developer/Platforms/MacOSX.platform/"
"Developer/SDKs/MacOSX10.15.sdk";
EXPECT_EQ("", PlatformDarwinTester::FindXcodeContentsDirectoryInPath(
no_capitalization));
}
TEST(PlatformDarwinTest, GetSDKNameForType) {
EXPECT_EQ("macosx",
PlatformDarwin::GetSDKNameForType(PlatformDarwin::SDKType::MacOSX));
EXPECT_EQ("iphonesimulator", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::iPhoneSimulator));
EXPECT_EQ("iphoneos", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::iPhoneOS));
EXPECT_EQ("appletvsimulator", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::AppleTVSimulator));
EXPECT_EQ("appletvos", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::AppleTVOS));
EXPECT_EQ("watchsimulator", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::WatchSimulator));
EXPECT_EQ("watchos", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::watchOS));
EXPECT_EQ("linux",
PlatformDarwin::GetSDKNameForType(PlatformDarwin::SDKType::Linux));
EXPECT_EQ("", PlatformDarwin::GetSDKNameForType(
PlatformDarwin::SDKType::numSDKTypes));
EXPECT_EQ(
"", PlatformDarwin::GetSDKNameForType(PlatformDarwin::SDKType::unknown));
}