Move Host/Symbols.cpp to Symbols/LocateSymbolFile.cpp
Given that we have a target named Symbols, one wonders why a
file named Symbols.cpp is not in this target. To be clear,
the functions exposed from this file are really focused on
*locating* a symbol file on a given host, which is where the
ambiguity comes in. However, it makes more sense conceptually
to be in the Symbols target. While some of the specific places
to search for symbol files might change depending on the Host,
this is not inherently true in the same way that, for example,
"accessing the file system" or "starting threads" is
fundamentally dependent on the Host.
PDBs, for example, recently became a reality on non-Windows platforms,
and it's theoretically possible that DSYMs could become a thing on non
MacOSX platforms (maybe in a remote debugging scenario). Other types of
symbol files, such as DWO, DWP, etc have never been tied to any Host
platform anyway.
After this patch, there is only one remaining dependency from
Host to Target.
Differential Revision: https://reviews.llvm.org/D58730
llvm-svn: 355032
2019-02-28 05:42:10 +08:00
|
|
|
set(LLVM_OPTIONAL_SOURCES LocateSymbolFileMacOSX.cpp)
|
|
|
|
|
|
|
|
if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
|
|
|
|
set(PLATFORM_SOURCES LocateSymbolFileMacOSX.cpp)
|
|
|
|
endif()
|
|
|
|
|
2013-09-25 18:37:32 +08:00
|
|
|
add_lldb_library(lldbSymbol
|
2015-09-30 21:50:14 +08:00
|
|
|
ArmUnwindInfo.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
Block.cpp
|
2019-05-01 01:22:29 +08:00
|
|
|
CompactUnwindInfo.cpp
|
|
|
|
CompileUnit.cpp
|
2015-09-16 07:44:17 +08:00
|
|
|
CompilerDecl.cpp
|
2015-08-25 07:46:31 +08:00
|
|
|
CompilerDeclContext.cpp
|
2015-08-12 06:53:00 +08:00
|
|
|
CompilerType.cpp
|
2019-05-01 01:22:29 +08:00
|
|
|
DWARFCallFrameInfo.cpp
|
2015-12-16 08:22:08 +08:00
|
|
|
DebugMacros.cpp
|
2019-07-03 03:53:07 +08:00
|
|
|
DeclVendor.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
FuncUnwinders.cpp
|
2019-05-01 01:22:29 +08:00
|
|
|
Function.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
LineEntry.cpp
|
|
|
|
LineTable.cpp
|
Move Host/Symbols.cpp to Symbols/LocateSymbolFile.cpp
Given that we have a target named Symbols, one wonders why a
file named Symbols.cpp is not in this target. To be clear,
the functions exposed from this file are really focused on
*locating* a symbol file on a given host, which is where the
ambiguity comes in. However, it makes more sense conceptually
to be in the Symbols target. While some of the specific places
to search for symbol files might change depending on the Host,
this is not inherently true in the same way that, for example,
"accessing the file system" or "starting threads" is
fundamentally dependent on the Host.
PDBs, for example, recently became a reality on non-Windows platforms,
and it's theoretically possible that DSYMs could become a thing on non
MacOSX platforms (maybe in a remote debugging scenario). Other types of
symbol files, such as DWO, DWP, etc have never been tied to any Host
platform anyway.
After this patch, there is only one remaining dependency from
Host to Target.
Differential Revision: https://reviews.llvm.org/D58730
llvm-svn: 355032
2019-02-28 05:42:10 +08:00
|
|
|
LocateSymbolFile.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
ObjectFile.cpp
|
2019-04-24 15:27:05 +08:00
|
|
|
PostfixExpression.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
Symbol.cpp
|
|
|
|
SymbolContext.cpp
|
|
|
|
SymbolFile.cpp
|
|
|
|
SymbolVendor.cpp
|
|
|
|
Symtab.cpp
|
|
|
|
Type.cpp
|
|
|
|
TypeList.cpp
|
2018-11-06 03:33:59 +08:00
|
|
|
TypeMap.cpp
|
2015-08-12 05:38:15 +08:00
|
|
|
TypeSystem.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
UnwindPlan.cpp
|
|
|
|
UnwindTable.cpp
|
|
|
|
Variable.cpp
|
|
|
|
VariableList.cpp
|
2017-02-01 04:43:05 +08:00
|
|
|
|
Move Host/Symbols.cpp to Symbols/LocateSymbolFile.cpp
Given that we have a target named Symbols, one wonders why a
file named Symbols.cpp is not in this target. To be clear,
the functions exposed from this file are really focused on
*locating* a symbol file on a given host, which is where the
ambiguity comes in. However, it makes more sense conceptually
to be in the Symbols target. While some of the specific places
to search for symbol files might change depending on the Host,
this is not inherently true in the same way that, for example,
"accessing the file system" or "starting threads" is
fundamentally dependent on the Host.
PDBs, for example, recently became a reality on non-Windows platforms,
and it's theoretically possible that DSYMs could become a thing on non
MacOSX platforms (maybe in a remote debugging scenario). Other types of
symbol files, such as DWO, DWP, etc have never been tied to any Host
platform anyway.
After this patch, there is only one remaining dependency from
Host to Target.
Differential Revision: https://reviews.llvm.org/D58730
llvm-svn: 355032
2019-02-28 05:42:10 +08:00
|
|
|
${PLATFORM_SOURCES}
|
|
|
|
|
2017-02-01 04:43:05 +08:00
|
|
|
LINK_LIBS
|
|
|
|
lldbCore
|
|
|
|
lldbExpression
|
|
|
|
lldbHost
|
|
|
|
lldbTarget
|
|
|
|
lldbUtility
|
|
|
|
lldbPluginObjCLanguage
|
2019-10-04 20:03:03 +08:00
|
|
|
|
2017-02-01 04:43:05 +08:00
|
|
|
LINK_COMPONENTS
|
|
|
|
Support
|
2013-09-25 18:37:32 +08:00
|
|
|
)
|