2017-10-20 05:37:38 +08:00
|
|
|
//===-- RISCVInstrInfo.h - RISCV Instruction Information --------*- C++ -*-===//
|
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2017-10-20 05:37:38 +08:00
|
|
|
//
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
//
|
|
|
|
|
// This file contains the RISCV implementation of the TargetInstrInfo class.
|
|
|
|
|
//
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
|
|
#ifndef LLVM_LIB_TARGET_RISCV_RISCVINSTRINFO_H
|
|
|
|
|
#define LLVM_LIB_TARGET_RISCV_RISCVINSTRINFO_H
|
|
|
|
|
|
|
|
|
|
#include "RISCVRegisterInfo.h"
|
2017-11-08 09:01:31 +08:00
|
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
2017-10-20 05:37:38 +08:00
|
|
|
|
|
|
|
|
#define GET_INSTRINFO_HEADER
|
|
|
|
|
#include "RISCVGenInstrInfo.inc"
|
|
|
|
|
|
|
|
|
|
namespace llvm {
|
|
|
|
|
|
[RISCV] Add MachineInstr immediate verification
Summary:
This patch implements the `TargetInstrInfo::verifyInstruction` hook for RISC-V. Currently the hook verifies the machine instruction's immediate operands, to check if the immediates are within the expected bounds. Without the hook invalid immediates are not detected except when doing assembly parsing, so they are silently emitted (including being truncated when emitting object code).
The bounds information is specified in tablegen by using the `OperandType` definition, which sets the `MCOperandInfo`'s `OperandType` field. Several RISC-V-specific immediate operand types were created, which extend the `MCInstrDesc`'s `OperandType` `enum`.
To have the hook called with `llc` pass it the `-verify-machineinstrs` option. For Clang add the cmake build config `-DLLVM_ENABLE_EXPENSIVE_CHECKS=True`, or temporarily patch `TargetPassConfig::addVerifyPass`.
Review concerns:
- The patch adds immediate operand type checks that cover at least the base ISA. There are several other operand types for the C extension and one type for the F/D extensions that were left out of this initial patch because they introduced further design concerns that I felt were best evaluated separately.
- Invalid register classes (e.g. passing a GPR register where a GPRC is expected) are already caught, so were not included.
- This design makes the more abstract `MachineInstr` verification depend on MC layer definitions, which arguably is not the cleanest design, but is in line with how things are done in other parts of the target and LLVM in general.
- There is some duplication of logic already present in the `MCOperandPredicate`s. Since the `MachineInstr` and `MCInstr` notions of immediates are fundamentally different, this is currently necessary.
Reviewers: asb, lenary
Reviewed By: lenary
Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67397
llvm-svn: 375006
2019-10-16 23:06:02 +08:00
|
|
|
class RISCVSubtarget;
|
|
|
|
|
|
2017-10-20 05:37:38 +08:00
|
|
|
class RISCVInstrInfo : public RISCVGenInstrInfo {
|
|
|
|
|
|
|
|
|
|
public:
|
[RISCV] Add MachineInstr immediate verification
Summary:
This patch implements the `TargetInstrInfo::verifyInstruction` hook for RISC-V. Currently the hook verifies the machine instruction's immediate operands, to check if the immediates are within the expected bounds. Without the hook invalid immediates are not detected except when doing assembly parsing, so they are silently emitted (including being truncated when emitting object code).
The bounds information is specified in tablegen by using the `OperandType` definition, which sets the `MCOperandInfo`'s `OperandType` field. Several RISC-V-specific immediate operand types were created, which extend the `MCInstrDesc`'s `OperandType` `enum`.
To have the hook called with `llc` pass it the `-verify-machineinstrs` option. For Clang add the cmake build config `-DLLVM_ENABLE_EXPENSIVE_CHECKS=True`, or temporarily patch `TargetPassConfig::addVerifyPass`.
Review concerns:
- The patch adds immediate operand type checks that cover at least the base ISA. There are several other operand types for the C extension and one type for the F/D extensions that were left out of this initial patch because they introduced further design concerns that I felt were best evaluated separately.
- Invalid register classes (e.g. passing a GPR register where a GPRC is expected) are already caught, so were not included.
- This design makes the more abstract `MachineInstr` verification depend on MC layer definitions, which arguably is not the cleanest design, but is in line with how things are done in other parts of the target and LLVM in general.
- There is some duplication of logic already present in the `MCOperandPredicate`s. Since the `MachineInstr` and `MCInstr` notions of immediates are fundamentally different, this is currently necessary.
Reviewers: asb, lenary
Reviewed By: lenary
Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67397
llvm-svn: 375006
2019-10-16 23:06:02 +08:00
|
|
|
explicit RISCVInstrInfo(RISCVSubtarget &STI);
|
2017-11-08 20:20:01 +08:00
|
|
|
|
2018-04-26 23:34:27 +08:00
|
|
|
unsigned isLoadFromStackSlot(const MachineInstr &MI,
|
|
|
|
|
int &FrameIndex) const override;
|
|
|
|
|
unsigned isStoreToStackSlot(const MachineInstr &MI,
|
|
|
|
|
int &FrameIndex) const override;
|
|
|
|
|
|
2017-11-08 20:20:01 +08:00
|
|
|
void copyPhysReg(MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI,
|
2019-11-11 16:24:21 +08:00
|
|
|
const DebugLoc &DL, MCRegister DstReg, MCRegister SrcReg,
|
2017-11-08 20:20:01 +08:00
|
|
|
bool KillSrc) const override;
|
2017-11-08 21:31:40 +08:00
|
|
|
|
|
|
|
|
void storeRegToStackSlot(MachineBasicBlock &MBB,
|
[NFC] unsigned->Register in storeRegTo/loadRegFromStack
Summary:
This patch makes progress on the 'unsigned -> Register' rewrite for
`TargetInstrInfo::loadRegFromStack` and `TII::storeRegToStack`.
Reviewers: arsenm, craig.topper, uweigand, jpienaar, atanasyan, venkatra, robertlytton, dylanmckay, t.p.northover, kparzysz, tstellar, k-ishizaka
Reviewed By: arsenm
Subscribers: wuzish, merge_guards_bot, jyknight, sdardis, nemanjai, jvesely, wdng, nhaehnle, hiraditya, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, jsji, Jim, lenary, s.egerton, pzheng, sameer.abuasal, apazos, luismarques, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73870
2020-02-03 21:22:06 +08:00
|
|
|
MachineBasicBlock::iterator MBBI, Register SrcReg,
|
2017-11-08 21:31:40 +08:00
|
|
|
bool IsKill, int FrameIndex,
|
|
|
|
|
const TargetRegisterClass *RC,
|
|
|
|
|
const TargetRegisterInfo *TRI) const override;
|
|
|
|
|
|
|
|
|
|
void loadRegFromStackSlot(MachineBasicBlock &MBB,
|
[NFC] unsigned->Register in storeRegTo/loadRegFromStack
Summary:
This patch makes progress on the 'unsigned -> Register' rewrite for
`TargetInstrInfo::loadRegFromStack` and `TII::storeRegToStack`.
Reviewers: arsenm, craig.topper, uweigand, jpienaar, atanasyan, venkatra, robertlytton, dylanmckay, t.p.northover, kparzysz, tstellar, k-ishizaka
Reviewed By: arsenm
Subscribers: wuzish, merge_guards_bot, jyknight, sdardis, nemanjai, jvesely, wdng, nhaehnle, hiraditya, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, jsji, Jim, lenary, s.egerton, pzheng, sameer.abuasal, apazos, luismarques, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73870
2020-02-03 21:22:06 +08:00
|
|
|
MachineBasicBlock::iterator MBBI, Register DstReg,
|
2017-11-08 21:31:40 +08:00
|
|
|
int FrameIndex, const TargetRegisterClass *RC,
|
|
|
|
|
const TargetRegisterInfo *TRI) const override;
|
2018-01-11 03:53:46 +08:00
|
|
|
|
2019-09-13 12:03:32 +08:00
|
|
|
// Materializes the given integer Val into DstReg.
|
|
|
|
|
void movImm(MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI,
|
|
|
|
|
const DebugLoc &DL, Register DstReg, uint64_t Val,
|
|
|
|
|
MachineInstr::MIFlag Flag = MachineInstr::NoFlags) const;
|
2018-01-11 04:47:00 +08:00
|
|
|
|
2018-01-11 05:05:07 +08:00
|
|
|
unsigned getInstSizeInBytes(const MachineInstr &MI) const override;
|
|
|
|
|
|
2018-01-11 04:47:00 +08:00
|
|
|
bool analyzeBranch(MachineBasicBlock &MBB, MachineBasicBlock *&TBB,
|
|
|
|
|
MachineBasicBlock *&FBB,
|
|
|
|
|
SmallVectorImpl<MachineOperand> &Cond,
|
|
|
|
|
bool AllowModify) const override;
|
|
|
|
|
|
|
|
|
|
unsigned insertBranch(MachineBasicBlock &MBB, MachineBasicBlock *TBB,
|
|
|
|
|
MachineBasicBlock *FBB, ArrayRef<MachineOperand> Cond,
|
|
|
|
|
const DebugLoc &dl,
|
|
|
|
|
int *BytesAdded = nullptr) const override;
|
|
|
|
|
|
2018-01-11 05:05:07 +08:00
|
|
|
unsigned insertIndirectBranch(MachineBasicBlock &MBB,
|
|
|
|
|
MachineBasicBlock &NewDestBB,
|
|
|
|
|
const DebugLoc &DL, int64_t BrOffset,
|
|
|
|
|
RegScavenger *RS = nullptr) const override;
|
|
|
|
|
|
2018-01-11 04:47:00 +08:00
|
|
|
unsigned removeBranch(MachineBasicBlock &MBB,
|
|
|
|
|
int *BytesRemoved = nullptr) const override;
|
|
|
|
|
|
|
|
|
|
bool
|
|
|
|
|
reverseBranchCondition(SmallVectorImpl<MachineOperand> &Cond) const override;
|
2018-01-11 05:05:07 +08:00
|
|
|
|
|
|
|
|
MachineBasicBlock *getBranchDestBlock(const MachineInstr &MI) const override;
|
|
|
|
|
|
|
|
|
|
bool isBranchOffsetInRange(unsigned BranchOpc,
|
|
|
|
|
int64_t BrOffset) const override;
|
2019-01-26 04:22:49 +08:00
|
|
|
|
|
|
|
|
bool isAsCheapAsAMove(const MachineInstr &MI) const override;
|
[RISCV] Add MachineInstr immediate verification
Summary:
This patch implements the `TargetInstrInfo::verifyInstruction` hook for RISC-V. Currently the hook verifies the machine instruction's immediate operands, to check if the immediates are within the expected bounds. Without the hook invalid immediates are not detected except when doing assembly parsing, so they are silently emitted (including being truncated when emitting object code).
The bounds information is specified in tablegen by using the `OperandType` definition, which sets the `MCOperandInfo`'s `OperandType` field. Several RISC-V-specific immediate operand types were created, which extend the `MCInstrDesc`'s `OperandType` `enum`.
To have the hook called with `llc` pass it the `-verify-machineinstrs` option. For Clang add the cmake build config `-DLLVM_ENABLE_EXPENSIVE_CHECKS=True`, or temporarily patch `TargetPassConfig::addVerifyPass`.
Review concerns:
- The patch adds immediate operand type checks that cover at least the base ISA. There are several other operand types for the C extension and one type for the F/D extensions that were left out of this initial patch because they introduced further design concerns that I felt were best evaluated separately.
- Invalid register classes (e.g. passing a GPR register where a GPRC is expected) are already caught, so were not included.
- This design makes the more abstract `MachineInstr` verification depend on MC layer definitions, which arguably is not the cleanest design, but is in line with how things are done in other parts of the target and LLVM in general.
- There is some duplication of logic already present in the `MCOperandPredicate`s. Since the `MachineInstr` and `MCInstr` notions of immediates are fundamentally different, this is currently necessary.
Reviewers: asb, lenary
Reviewed By: lenary
Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67397
llvm-svn: 375006
2019-10-16 23:06:02 +08:00
|
|
|
|
2020-09-21 15:59:22 +08:00
|
|
|
Optional<DestSourcePair>
|
|
|
|
|
isCopyInstrImpl(const MachineInstr &MI) const override;
|
|
|
|
|
|
[RISCV] Add MachineInstr immediate verification
Summary:
This patch implements the `TargetInstrInfo::verifyInstruction` hook for RISC-V. Currently the hook verifies the machine instruction's immediate operands, to check if the immediates are within the expected bounds. Without the hook invalid immediates are not detected except when doing assembly parsing, so they are silently emitted (including being truncated when emitting object code).
The bounds information is specified in tablegen by using the `OperandType` definition, which sets the `MCOperandInfo`'s `OperandType` field. Several RISC-V-specific immediate operand types were created, which extend the `MCInstrDesc`'s `OperandType` `enum`.
To have the hook called with `llc` pass it the `-verify-machineinstrs` option. For Clang add the cmake build config `-DLLVM_ENABLE_EXPENSIVE_CHECKS=True`, or temporarily patch `TargetPassConfig::addVerifyPass`.
Review concerns:
- The patch adds immediate operand type checks that cover at least the base ISA. There are several other operand types for the C extension and one type for the F/D extensions that were left out of this initial patch because they introduced further design concerns that I felt were best evaluated separately.
- Invalid register classes (e.g. passing a GPR register where a GPRC is expected) are already caught, so were not included.
- This design makes the more abstract `MachineInstr` verification depend on MC layer definitions, which arguably is not the cleanest design, but is in line with how things are done in other parts of the target and LLVM in general.
- There is some duplication of logic already present in the `MCOperandPredicate`s. Since the `MachineInstr` and `MCInstr` notions of immediates are fundamentally different, this is currently necessary.
Reviewers: asb, lenary
Reviewed By: lenary
Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67397
llvm-svn: 375006
2019-10-16 23:06:02 +08:00
|
|
|
bool verifyInstruction(const MachineInstr &MI,
|
|
|
|
|
StringRef &ErrInfo) const override;
|
|
|
|
|
|
2019-11-05 17:36:08 +08:00
|
|
|
bool getMemOperandWithOffsetWidth(const MachineInstr &LdSt,
|
|
|
|
|
const MachineOperand *&BaseOp,
|
|
|
|
|
int64_t &Offset, unsigned &Width,
|
|
|
|
|
const TargetRegisterInfo *TRI) const;
|
|
|
|
|
|
|
|
|
|
bool areMemAccessesTriviallyDisjoint(const MachineInstr &MIa,
|
|
|
|
|
const MachineInstr &MIb) const override;
|
|
|
|
|
|
[RISCV] Machine Operand Flag Serialization
Summary:
These hooks ensure that the RISC-V backend can serialize and parse MIR
correctly.
Reviewers: jrtc27, luismarques
Reviewed By: luismarques
Subscribers: hiraditya, asb, rbar, johnrusso, simoncook, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, sameer.abuasal, apazos, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70666
2019-12-09 21:16:28 +08:00
|
|
|
|
|
|
|
|
std::pair<unsigned, unsigned>
|
|
|
|
|
decomposeMachineOperandsTargetFlags(unsigned TF) const override;
|
|
|
|
|
|
|
|
|
|
ArrayRef<std::pair<unsigned, const char *>>
|
|
|
|
|
getSerializableDirectMachineOperandTargetFlags() const override;
|
|
|
|
|
|
2019-12-20 00:41:53 +08:00
|
|
|
// Return true if the function can safely be outlined from.
|
|
|
|
|
virtual bool
|
|
|
|
|
isFunctionSafeToOutlineFrom(MachineFunction &MF,
|
|
|
|
|
bool OutlineFromLinkOnceODRs) const override;
|
|
|
|
|
|
|
|
|
|
// Return true if MBB is safe to outline from, and return any target-specific
|
|
|
|
|
// information in Flags.
|
|
|
|
|
virtual bool isMBBSafeToOutlineFrom(MachineBasicBlock &MBB,
|
|
|
|
|
unsigned &Flags) const override;
|
|
|
|
|
|
|
|
|
|
// Calculate target-specific information for a set of outlining candidates.
|
|
|
|
|
outliner::OutlinedFunction getOutliningCandidateInfo(
|
|
|
|
|
std::vector<outliner::Candidate> &RepeatedSequenceLocs) const override;
|
|
|
|
|
|
|
|
|
|
// Return if/how a given MachineInstr should be outlined.
|
|
|
|
|
virtual outliner::InstrType
|
|
|
|
|
getOutliningType(MachineBasicBlock::iterator &MBBI,
|
|
|
|
|
unsigned Flags) const override;
|
|
|
|
|
|
|
|
|
|
// Insert a custom frame for outlined functions.
|
|
|
|
|
virtual void
|
|
|
|
|
buildOutlinedFrame(MachineBasicBlock &MBB, MachineFunction &MF,
|
|
|
|
|
const outliner::OutlinedFunction &OF) const override;
|
|
|
|
|
|
|
|
|
|
// Insert a call to an outlined function into a given basic block.
|
|
|
|
|
virtual MachineBasicBlock::iterator
|
|
|
|
|
insertOutlinedCall(Module &M, MachineBasicBlock &MBB,
|
|
|
|
|
MachineBasicBlock::iterator &It, MachineFunction &MF,
|
|
|
|
|
const outliner::Candidate &C) const override;
|
2021-02-09 01:56:47 +08:00
|
|
|
|
|
|
|
|
bool findCommutedOpIndices(const MachineInstr &MI, unsigned &SrcOpIdx1,
|
|
|
|
|
unsigned &SrcOpIdx2) const override;
|
|
|
|
|
MachineInstr *commuteInstructionImpl(MachineInstr &MI, bool NewMI,
|
|
|
|
|
unsigned OpIdx1,
|
|
|
|
|
unsigned OpIdx2) const override;
|
|
|
|
|
|
[RISCV] Add MachineInstr immediate verification
Summary:
This patch implements the `TargetInstrInfo::verifyInstruction` hook for RISC-V. Currently the hook verifies the machine instruction's immediate operands, to check if the immediates are within the expected bounds. Without the hook invalid immediates are not detected except when doing assembly parsing, so they are silently emitted (including being truncated when emitting object code).
The bounds information is specified in tablegen by using the `OperandType` definition, which sets the `MCOperandInfo`'s `OperandType` field. Several RISC-V-specific immediate operand types were created, which extend the `MCInstrDesc`'s `OperandType` `enum`.
To have the hook called with `llc` pass it the `-verify-machineinstrs` option. For Clang add the cmake build config `-DLLVM_ENABLE_EXPENSIVE_CHECKS=True`, or temporarily patch `TargetPassConfig::addVerifyPass`.
Review concerns:
- The patch adds immediate operand type checks that cover at least the base ISA. There are several other operand types for the C extension and one type for the F/D extensions that were left out of this initial patch because they introduced further design concerns that I felt were best evaluated separately.
- Invalid register classes (e.g. passing a GPR register where a GPRC is expected) are already caught, so were not included.
- This design makes the more abstract `MachineInstr` verification depend on MC layer definitions, which arguably is not the cleanest design, but is in line with how things are done in other parts of the target and LLVM in general.
- There is some duplication of logic already present in the `MCOperandPredicate`s. Since the `MachineInstr` and `MCInstr` notions of immediates are fundamentally different, this is currently necessary.
Reviewers: asb, lenary
Reviewed By: lenary
Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67397
llvm-svn: 375006
2019-10-16 23:06:02 +08:00
|
|
|
protected:
|
|
|
|
|
const RISCVSubtarget &STI;
|
2017-10-20 05:37:38 +08:00
|
|
|
};
|
2019-10-24 12:29:28 +08:00
|
|
|
|
2021-01-28 05:14:43 +08:00
|
|
|
namespace RISCVVPseudosTable {
|
|
|
|
|
|
|
|
|
|
struct PseudoInfo {
|
|
|
|
|
uint16_t Pseudo;
|
|
|
|
|
uint16_t BaseInstr;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
#define GET_RISCVVPseudosTable_DECL
|
|
|
|
|
#include "RISCVGenSearchableTables.inc"
|
|
|
|
|
|
|
|
|
|
} // end namespace RISCVVPseudosTable
|
|
|
|
|
|
2019-10-24 12:29:28 +08:00
|
|
|
} // end namespace llvm
|
2017-10-20 05:37:38 +08:00
|
|
|
#endif
|