2017-08-18 05:26:39 +08:00
|
|
|
//===- llvm/CodeGen/DwarfCompileUnit.cpp - Dwarf Compile Units ------------===//
|
2017-03-01 08:14:42 +08:00
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file contains support for constructing a dwarf compile unit.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-10-04 23:49:50 +08:00
|
|
|
#include "DwarfCompileUnit.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "AddressPool.h"
|
|
|
|
#include "DwarfDebug.h"
|
2015-01-14 09:01:30 +08:00
|
|
|
#include "DwarfExpression.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "DwarfUnit.h"
|
|
|
|
#include "llvm/ADT/None.h"
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
|
|
|
#include "llvm/ADT/SmallVector.h"
|
|
|
|
#include "llvm/ADT/StringRef.h"
|
|
|
|
#include "llvm/BinaryFormat/Dwarf.h"
|
|
|
|
#include "llvm/CodeGen/AsmPrinter.h"
|
|
|
|
#include "llvm/CodeGen/DIE.h"
|
|
|
|
#include "llvm/CodeGen/LexicalScopes.h"
|
2014-10-05 00:24:00 +08:00
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
|
|
#include "llvm/CodeGen/MachineOperand.h"
|
2017-11-17 09:07:10 +08:00
|
|
|
#include "llvm/CodeGen/TargetFrameLowering.h"
|
|
|
|
#include "llvm/CodeGen/TargetLoweringObjectFile.h"
|
|
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
2014-10-04 23:49:50 +08:00
|
|
|
#include "llvm/IR/DataLayout.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "llvm/IR/DebugInfo.h"
|
|
|
|
#include "llvm/IR/DebugInfoMetadata.h"
|
2014-10-04 23:49:50 +08:00
|
|
|
#include "llvm/IR/GlobalVariable.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "llvm/MC/MCSection.h"
|
2014-10-04 23:49:50 +08:00
|
|
|
#include "llvm/MC/MCStreamer.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "llvm/MC/MCSymbol.h"
|
2017-11-17 09:07:10 +08:00
|
|
|
#include "llvm/MC/MachineLocation.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "llvm/Support/Casting.h"
|
2014-10-05 00:24:00 +08:00
|
|
|
#include "llvm/Target/TargetMachine.h"
|
2017-08-18 05:26:39 +08:00
|
|
|
#include "llvm/Target/TargetOptions.h"
|
|
|
|
#include <algorithm>
|
|
|
|
#include <cassert>
|
|
|
|
#include <cstdint>
|
|
|
|
#include <iterator>
|
|
|
|
#include <memory>
|
|
|
|
#include <string>
|
|
|
|
#include <utility>
|
2014-10-04 23:49:50 +08:00
|
|
|
|
2017-08-18 05:26:39 +08:00
|
|
|
using namespace llvm;
|
2014-10-04 23:49:50 +08:00
|
|
|
|
2015-04-30 00:38:44 +08:00
|
|
|
DwarfCompileUnit::DwarfCompileUnit(unsigned UID, const DICompileUnit *Node,
|
2014-10-04 23:49:50 +08:00
|
|
|
AsmPrinter *A, DwarfDebug *DW,
|
|
|
|
DwarfFile *DWU)
|
2017-08-18 05:26:39 +08:00
|
|
|
: DwarfUnit(dwarf::DW_TAG_compile_unit, Node, A, DW, DWU), UniqueID(UID) {
|
2014-10-04 23:49:50 +08:00
|
|
|
insertDIE(Node, &getUnitDie());
|
2016-02-01 22:09:41 +08:00
|
|
|
MacroLabelBegin = Asm->createTempSymbol("cu_macro_begin");
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// addLabelAddress - Add a dwarf label attribute data and value using
|
|
|
|
/// DW_FORM_addr or DW_FORM_GNU_addr_index.
|
|
|
|
void DwarfCompileUnit::addLabelAddress(DIE &Die, dwarf::Attribute Attribute,
|
|
|
|
const MCSymbol *Label) {
|
|
|
|
// Don't use the address pool in non-fission or in the skeleton unit itself.
|
|
|
|
// FIXME: Once GDB supports this, it's probably worthwhile using the address
|
|
|
|
// pool from the skeleton - maybe even in non-fission (possibly fewer
|
|
|
|
// relocations by sharing them in the pool, but we have other ideas about how
|
|
|
|
// to reduce the number of relocations as well/instead).
|
|
|
|
if (!DD->useSplitDwarf() || !Skeleton)
|
|
|
|
return addLocalLabelAddress(Die, Attribute, Label);
|
|
|
|
|
|
|
|
if (Label)
|
|
|
|
DD->addArangeLabel(SymbolCU(this, Label));
|
|
|
|
|
|
|
|
unsigned idx = DD->getAddressPool().getIndex(Label);
|
2015-06-26 07:46:41 +08:00
|
|
|
Die.addValue(DIEValueAllocator, Attribute, dwarf::DW_FORM_GNU_addr_index,
|
|
|
|
DIEInteger(idx));
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void DwarfCompileUnit::addLocalLabelAddress(DIE &Die,
|
|
|
|
dwarf::Attribute Attribute,
|
|
|
|
const MCSymbol *Label) {
|
|
|
|
if (Label)
|
|
|
|
DD->addArangeLabel(SymbolCU(this, Label));
|
|
|
|
|
2015-05-28 06:31:41 +08:00
|
|
|
if (Label)
|
2015-06-26 07:46:41 +08:00
|
|
|
Die.addValue(DIEValueAllocator, Attribute, dwarf::DW_FORM_addr,
|
|
|
|
DIELabel(Label));
|
2015-05-28 06:31:41 +08:00
|
|
|
else
|
2015-06-26 07:46:41 +08:00
|
|
|
Die.addValue(DIEValueAllocator, Attribute, dwarf::DW_FORM_addr,
|
|
|
|
DIEInteger(0));
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
2018-01-13 03:17:50 +08:00
|
|
|
unsigned DwarfCompileUnit::getOrCreateSourceID(const DIFile *File) {
|
2014-10-04 23:49:50 +08:00
|
|
|
// If we print assembly, we can't separate .file entries according to
|
|
|
|
// compile units. Thus all files will belong to the default compile unit.
|
|
|
|
|
|
|
|
// FIXME: add a better feature test than hasRawTextSupport. Even better,
|
|
|
|
// extend .file to support this.
|
2018-01-13 03:17:50 +08:00
|
|
|
unsigned CUID = Asm->OutStreamer->hasRawTextSupport() ? 0 : getUniqueID();
|
|
|
|
if (!File)
|
|
|
|
return Asm->OutStreamer->EmitDwarfFileDirective(0, "", "", nullptr, CUID);
|
2015-04-25 03:11:51 +08:00
|
|
|
return Asm->OutStreamer->EmitDwarfFileDirective(
|
2018-01-13 03:17:50 +08:00
|
|
|
0, File->getDirectory(), File->getFilename(), getMD5AsBytes(File), CUID);
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
2015-04-22 02:44:06 +08:00
|
|
|
DIE *DwarfCompileUnit::getOrCreateGlobalVariableDIE(
|
2016-12-20 10:09:43 +08:00
|
|
|
const DIGlobalVariable *GV, ArrayRef<GlobalExpr> GlobalExprs) {
|
2014-10-04 23:49:50 +08:00
|
|
|
// Check for pre-existence.
|
|
|
|
if (DIE *Die = getDIE(GV))
|
|
|
|
return Die;
|
|
|
|
|
2015-04-07 07:27:40 +08:00
|
|
|
assert(GV);
|
2014-10-04 23:49:50 +08:00
|
|
|
|
2015-04-21 02:32:29 +08:00
|
|
|
auto *GVContext = GV->getScope();
|
|
|
|
auto *GTy = DD->resolve(GV->getType());
|
2014-10-04 23:49:50 +08:00
|
|
|
|
2014-10-24 03:12:43 +08:00
|
|
|
// Construct the context before querying for the existence of the DIE in
|
|
|
|
// case such construction creates the DIE.
|
2016-04-30 09:44:07 +08:00
|
|
|
DIE *ContextDIE = getOrCreateContextDIE(GVContext);
|
2014-10-04 23:49:50 +08:00
|
|
|
|
2016-04-30 09:44:07 +08:00
|
|
|
// Add to map.
|
|
|
|
DIE *VariableDIE = &createAndAddDIE(GV->getTag(), *ContextDIE, GV);
|
2015-04-30 00:38:44 +08:00
|
|
|
DIScope *DeclContext;
|
2015-04-16 09:01:28 +08:00
|
|
|
if (auto *SDMDecl = GV->getStaticDataMemberDeclaration()) {
|
|
|
|
DeclContext = resolve(SDMDecl->getScope());
|
|
|
|
assert(SDMDecl->isStaticMember() && "Expected static member decl");
|
2015-04-14 10:22:36 +08:00
|
|
|
assert(GV->isDefinition());
|
2014-10-24 03:12:43 +08:00
|
|
|
// We need the declaration DIE that is in the static member's class.
|
|
|
|
DIE *VariableSpecDIE = getOrCreateStaticMemberDIE(SDMDecl);
|
|
|
|
addDIEEntry(*VariableDIE, dwarf::DW_AT_specification, *VariableSpecDIE);
|
2016-11-09 06:11:38 +08:00
|
|
|
// If the global variable's type is different from the one in the class
|
|
|
|
// member type, assume that it's more specific and also emit it.
|
|
|
|
if (GTy != DD->resolve(SDMDecl->getBaseType()))
|
|
|
|
addType(*VariableDIE, GTy);
|
2014-10-24 03:12:43 +08:00
|
|
|
} else {
|
2015-04-14 10:22:36 +08:00
|
|
|
DeclContext = GV->getScope();
|
2014-10-04 23:49:50 +08:00
|
|
|
// Add name and type.
|
2015-04-14 10:22:36 +08:00
|
|
|
addString(*VariableDIE, dwarf::DW_AT_name, GV->getDisplayName());
|
2014-10-04 23:49:50 +08:00
|
|
|
addType(*VariableDIE, GTy);
|
|
|
|
|
|
|
|
// Add scoping info.
|
2015-04-14 10:22:36 +08:00
|
|
|
if (!GV->isLocalToUnit())
|
2014-10-04 23:49:50 +08:00
|
|
|
addFlag(*VariableDIE, dwarf::DW_AT_external);
|
|
|
|
|
|
|
|
// Add line number info.
|
|
|
|
addSourceLine(*VariableDIE, GV);
|
|
|
|
}
|
|
|
|
|
2015-04-14 10:22:36 +08:00
|
|
|
if (!GV->isDefinition())
|
2014-10-24 03:12:43 +08:00
|
|
|
addFlag(*VariableDIE, dwarf::DW_AT_declaration);
|
2015-04-15 02:08:25 +08:00
|
|
|
else
|
|
|
|
addGlobalName(GV->getName(), *VariableDIE, DeclContext);
|
2014-10-24 03:12:43 +08:00
|
|
|
|
2016-10-26 19:59:03 +08:00
|
|
|
if (uint32_t AlignInBytes = GV->getAlignInBytes())
|
|
|
|
addUInt(*VariableDIE, dwarf::DW_AT_alignment, dwarf::DW_FORM_udata,
|
|
|
|
AlignInBytes);
|
|
|
|
|
2014-10-04 23:49:50 +08:00
|
|
|
// Add location.
|
|
|
|
bool addToAccelTable = false;
|
2016-12-20 10:09:43 +08:00
|
|
|
DIELoc *Loc = nullptr;
|
|
|
|
std::unique_ptr<DIEDwarfExpression> DwarfExpr;
|
|
|
|
for (const auto &GE : GlobalExprs) {
|
|
|
|
const GlobalVariable *Global = GE.Var;
|
|
|
|
const DIExpression *Expr = GE.Expr;
|
2017-03-24 07:35:09 +08:00
|
|
|
|
2016-12-20 10:09:43 +08:00
|
|
|
// For compatibility with DWARF 3 and earlier,
|
|
|
|
// DW_AT_location(DW_OP_constu, X, DW_OP_stack_value) becomes
|
|
|
|
// DW_AT_const_value(X).
|
|
|
|
if (GlobalExprs.size() == 1 && Expr && Expr->isConstant()) {
|
2017-03-24 07:35:09 +08:00
|
|
|
addToAccelTable = true;
|
2016-12-20 10:09:43 +08:00
|
|
|
addConstantValue(*VariableDIE, /*Unsigned=*/true, Expr->getElement(1));
|
2017-03-24 07:35:09 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// We cannot describe the location of dllimport'd variables: the
|
|
|
|
// computation of their address requires loads from the IAT.
|
|
|
|
if (Global && Global->hasDLLImportStorageClass())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Nothing to describe without address or constant.
|
|
|
|
if (!Global && (!Expr || !Expr->isConstant()))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!Loc) {
|
2016-07-10 04:47:48 +08:00
|
|
|
addToAccelTable = true;
|
2017-03-24 07:35:09 +08:00
|
|
|
Loc = new (DIEValueAllocator) DIELoc;
|
|
|
|
DwarfExpr = llvm::make_unique<DIEDwarfExpression>(*Asm, *this, *Loc);
|
|
|
|
}
|
|
|
|
|
[DebugInfo] Fix fragment offset emission order for symbol locations
Summary:
When emitting the location for a global variable with fragmented debug
expressions, make sure that the offset pieces, which represent
optimized-out parts of the variable, are emitted before their succeeding
fragments' expressions. Previously, if the succeeding fragment's
location was a symbol, the offset piece was emitted after, rather than
before, that symbol's expression. This effectively meant that the symbols
were associated with the wrong parts of the variable.
This fixes PR36085.
Patch by: David Stenberg
Reviewers: aprantl, probinson, dblaikie
Reviewed By: aprantl
Subscribers: JDevlieghere, llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D42527
llvm-svn: 323644
2018-01-29 20:37:30 +08:00
|
|
|
if (Expr)
|
|
|
|
DwarfExpr->addFragmentOffset(Expr);
|
|
|
|
|
2017-03-24 07:35:09 +08:00
|
|
|
if (Global) {
|
|
|
|
const MCSymbol *Sym = Asm->getSymbol(Global);
|
|
|
|
if (Global->isThreadLocal()) {
|
|
|
|
if (Asm->TM.Options.EmulatedTLS) {
|
|
|
|
// TODO: add debug info for emulated thread local mode.
|
|
|
|
} else {
|
|
|
|
// FIXME: Make this work with -gsplit-dwarf.
|
|
|
|
unsigned PointerSize = Asm->getDataLayout().getPointerSize();
|
|
|
|
assert((PointerSize == 4 || PointerSize == 8) &&
|
|
|
|
"Add support for other sizes if necessary");
|
|
|
|
// Based on GCC's support for TLS:
|
|
|
|
if (!DD->useSplitDwarf()) {
|
|
|
|
// 1) Start with a constNu of the appropriate pointer size
|
2016-12-20 10:09:43 +08:00
|
|
|
addUInt(*Loc, dwarf::DW_FORM_data1,
|
2017-03-24 07:35:09 +08:00
|
|
|
PointerSize == 4 ? dwarf::DW_OP_const4u
|
|
|
|
: dwarf::DW_OP_const8u);
|
|
|
|
// 2) containing the (relocated) offset of the TLS variable
|
|
|
|
// within the module's TLS block.
|
|
|
|
addExpr(*Loc, dwarf::DW_FORM_udata,
|
|
|
|
Asm->getObjFileLowering().getDebugThreadLocalSymbol(Sym));
|
|
|
|
} else {
|
|
|
|
addUInt(*Loc, dwarf::DW_FORM_data1, dwarf::DW_OP_GNU_const_index);
|
|
|
|
addUInt(*Loc, dwarf::DW_FORM_udata,
|
|
|
|
DD->getAddressPool().getIndex(Sym, /* TLS */ true));
|
2016-07-10 04:47:48 +08:00
|
|
|
}
|
2017-03-24 07:35:09 +08:00
|
|
|
// 3) followed by an OP to make the debugger do a TLS lookup.
|
|
|
|
addUInt(*Loc, dwarf::DW_FORM_data1,
|
|
|
|
DD->useGNUTLSOpcode() ? dwarf::DW_OP_GNU_push_tls_address
|
|
|
|
: dwarf::DW_OP_form_tls_address);
|
2015-07-29 00:24:05 +08:00
|
|
|
}
|
2017-03-24 07:35:09 +08:00
|
|
|
} else {
|
|
|
|
DD->addArangeLabel(SymbolCU(this, Sym));
|
|
|
|
addOpAddress(*Loc, Sym);
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
2017-03-24 07:35:09 +08:00
|
|
|
}
|
[DebugInfo] Fix fragment offset emission order for symbol locations
Summary:
When emitting the location for a global variable with fragmented debug
expressions, make sure that the offset pieces, which represent
optimized-out parts of the variable, are emitted before their succeeding
fragments' expressions. Previously, if the succeeding fragment's
location was a symbol, the offset piece was emitted after, rather than
before, that symbol's expression. This effectively meant that the symbols
were associated with the wrong parts of the variable.
This fixes PR36085.
Patch by: David Stenberg
Reviewers: aprantl, probinson, dblaikie
Reviewed By: aprantl
Subscribers: JDevlieghere, llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D42527
llvm-svn: 323644
2018-01-29 20:37:30 +08:00
|
|
|
if (Expr)
|
2017-03-24 07:35:09 +08:00
|
|
|
DwarfExpr->addExpression(Expr);
|
2016-12-17 03:39:01 +08:00
|
|
|
}
|
2016-12-20 10:09:43 +08:00
|
|
|
if (Loc)
|
|
|
|
addBlock(*VariableDIE, dwarf::DW_AT_location, DwarfExpr->finalize());
|
|
|
|
|
|
|
|
if (DD->useAllLinkageNames())
|
|
|
|
addLinkageName(*VariableDIE, GV->getLinkageName());
|
2014-10-04 23:49:50 +08:00
|
|
|
|
|
|
|
if (addToAccelTable) {
|
2015-04-14 10:22:36 +08:00
|
|
|
DD->addAccelName(GV->getName(), *VariableDIE);
|
2014-10-04 23:49:50 +08:00
|
|
|
|
|
|
|
// If the linkage name is different than the name, go ahead and output
|
|
|
|
// that as well into the name table.
|
2015-04-14 10:22:36 +08:00
|
|
|
if (GV->getLinkageName() != "" && GV->getName() != GV->getLinkageName())
|
|
|
|
DD->addAccelName(GV->getLinkageName(), *VariableDIE);
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
2014-10-24 03:12:43 +08:00
|
|
|
return VariableDIE;
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void DwarfCompileUnit::addRange(RangeSpan Range) {
|
|
|
|
bool SameAsPrevCU = this == DD->getPrevCU();
|
|
|
|
DD->setPrevCU(this);
|
|
|
|
// If we have no current ranges just add the range and return, otherwise,
|
|
|
|
// check the current section and CU against the previous section and CU we
|
|
|
|
// emitted into and the subprogram was contained within. If these are the
|
|
|
|
// same then extend our current range, otherwise add this as a new range.
|
|
|
|
if (CURanges.empty() || !SameAsPrevCU ||
|
|
|
|
(&CURanges.back().getEnd()->getSection() !=
|
|
|
|
&Range.getEnd()->getSection())) {
|
|
|
|
CURanges.push_back(Range);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
CURanges.back().setEnd(Range.getEnd());
|
|
|
|
}
|
|
|
|
|
2015-03-11 00:58:10 +08:00
|
|
|
void DwarfCompileUnit::initStmtList() {
|
2014-10-04 23:49:50 +08:00
|
|
|
// Define start line table label for each Compile Unit.
|
|
|
|
MCSymbol *LineTableStartSym =
|
2015-04-25 03:11:51 +08:00
|
|
|
Asm->OutStreamer->getDwarfLineTableSymbol(getUniqueID());
|
2014-10-04 23:49:50 +08:00
|
|
|
|
|
|
|
// DW_AT_stmt_list is a offset of line number information for this
|
|
|
|
// compile unit in debug_line section. For split dwarf this is
|
|
|
|
// left in the skeleton CU and so not included.
|
|
|
|
// The line table entries are not always emitted in assembly, so it
|
|
|
|
// is not okay to use line_table_start here.
|
2015-03-11 00:58:10 +08:00
|
|
|
const TargetLoweringObjectFile &TLOF = Asm->getObjFileLowering();
|
2015-06-26 07:46:41 +08:00
|
|
|
StmtListValue =
|
2016-12-02 02:56:29 +08:00
|
|
|
addSectionLabel(getUnitDie(), dwarf::DW_AT_stmt_list, LineTableStartSym,
|
2015-06-26 07:46:41 +08:00
|
|
|
TLOF.getDwarfLineSection()->getBeginSymbol());
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void DwarfCompileUnit::applyStmtList(DIE &D) {
|
2015-06-26 07:46:41 +08:00
|
|
|
D.addValue(DIEValueAllocator, *StmtListValue);
|
2014-10-04 23:49:50 +08:00
|
|
|
}
|
|
|
|
|
2014-10-04 23:58:47 +08:00
|
|
|
void DwarfCompileUnit::attachLowHighPC(DIE &D, const MCSymbol *Begin,
|
|
|
|
const MCSymbol *End) {
|
|
|
|
assert(Begin && "Begin label should not be null!");
|
|
|
|
assert(End && "End label should not be null!");
|
|
|
|
assert(Begin->isDefined() && "Invalid starting label");
|
|
|
|
assert(End->isDefined() && "Invalid end label");
|
|
|
|
|
|
|
|
addLabelAddress(D, dwarf::DW_AT_low_pc, Begin);
|
|
|
|
if (DD->getDwarfVersion() < 4)
|
|
|
|
addLabelAddress(D, dwarf::DW_AT_high_pc, End);
|
|
|
|
else
|
|
|
|
addLabelDelta(D, dwarf::DW_AT_high_pc, End, Begin);
|
|
|
|
}
|
|
|
|
|
2014-10-05 00:24:00 +08:00
|
|
|
// Find DIE for the given subprogram and attach appropriate DW_AT_low_pc
|
|
|
|
// and DW_AT_high_pc attributes. If there are global variables in this
|
|
|
|
// scope then create and insert DIEs for these variables.
|
2015-04-30 00:38:44 +08:00
|
|
|
DIE &DwarfCompileUnit::updateSubprogramScopeDIE(const DISubprogram *SP) {
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
DIE *SPDie = getOrCreateSubprogramDIE(SP, includeMinimalInlineScopes());
|
2014-10-05 00:24:00 +08:00
|
|
|
|
2015-03-05 10:05:42 +08:00
|
|
|
attachLowHighPC(*SPDie, Asm->getFunctionBegin(), Asm->getFunctionEnd());
|
2016-05-25 05:19:28 +08:00
|
|
|
if (DD->useAppleExtensionAttributes() &&
|
|
|
|
!DD->getCurrentFunction()->getTarget().Options.DisableFramePointerElim(
|
2014-10-05 00:24:00 +08:00
|
|
|
*DD->getCurrentFunction()))
|
|
|
|
addFlag(*SPDie, dwarf::DW_AT_APPLE_omit_frame_ptr);
|
|
|
|
|
|
|
|
// Only include DW_AT_frame_base in full debug info
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
if (!includeMinimalInlineScopes()) {
|
2015-02-21 06:36:11 +08:00
|
|
|
const TargetRegisterInfo *RI = Asm->MF->getSubtarget().getRegisterInfo();
|
2014-10-05 00:24:00 +08:00
|
|
|
MachineLocation Location(RI->getFrameRegister(*Asm->MF));
|
2015-01-14 08:15:16 +08:00
|
|
|
if (RI->isPhysicalRegister(Location.getReg()))
|
|
|
|
addAddress(*SPDie, dwarf::DW_AT_frame_base, Location);
|
2014-10-05 00:24:00 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Add name to the name table, we do this here because we're guaranteed
|
|
|
|
// to have concrete versions of our DW_TAG_subprogram nodes.
|
|
|
|
DD->addSubprogramNames(SP, *SPDie);
|
|
|
|
|
|
|
|
return *SPDie;
|
|
|
|
}
|
|
|
|
|
2014-10-09 06:20:02 +08:00
|
|
|
// Construct a DIE for this scope.
|
|
|
|
void DwarfCompileUnit::constructScopeDIE(
|
2015-06-26 07:52:10 +08:00
|
|
|
LexicalScope *Scope, SmallVectorImpl<DIE *> &FinalChildren) {
|
2014-10-09 06:20:02 +08:00
|
|
|
if (!Scope || !Scope->getScopeNode())
|
|
|
|
return;
|
|
|
|
|
2015-04-21 02:32:29 +08:00
|
|
|
auto *DS = Scope->getScopeNode();
|
2014-10-09 06:20:02 +08:00
|
|
|
|
2015-04-30 00:38:44 +08:00
|
|
|
assert((Scope->getInlinedAt() || !isa<DISubprogram>(DS)) &&
|
2014-10-09 06:20:02 +08:00
|
|
|
"Only handle inlined subprograms here, use "
|
|
|
|
"constructSubprogramScopeDIE for non-inlined "
|
|
|
|
"subprograms");
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
SmallVector<DIE *, 8> Children;
|
2014-10-09 06:20:02 +08:00
|
|
|
|
|
|
|
// We try to create the scope DIE first, then the children DIEs. This will
|
|
|
|
// avoid creating un-used children then removing them later when we find out
|
|
|
|
// the scope DIE is null.
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *ScopeDIE;
|
2015-04-30 00:38:44 +08:00
|
|
|
if (Scope->getParent() && isa<DISubprogram>(DS)) {
|
2014-10-10 00:50:53 +08:00
|
|
|
ScopeDIE = constructInlinedScopeDIE(Scope);
|
2014-10-09 06:20:02 +08:00
|
|
|
if (!ScopeDIE)
|
|
|
|
return;
|
|
|
|
// We create children when the scope DIE is not null.
|
2014-10-10 02:24:28 +08:00
|
|
|
createScopeChildrenDIE(Scope, Children);
|
2014-10-09 06:20:02 +08:00
|
|
|
} else {
|
|
|
|
// Early exit when we know the scope DIE is going to be null.
|
|
|
|
if (DD->isLexicalScopeDIENull(Scope))
|
|
|
|
return;
|
|
|
|
|
2017-07-27 08:06:53 +08:00
|
|
|
bool HasNonScopeChildren = false;
|
2014-10-09 06:20:02 +08:00
|
|
|
|
|
|
|
// We create children here when we know the scope DIE is not going to be
|
|
|
|
// null and the children will be added to the scope DIE.
|
2017-07-27 08:06:53 +08:00
|
|
|
createScopeChildrenDIE(Scope, Children, &HasNonScopeChildren);
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
|
2014-10-09 06:20:02 +08:00
|
|
|
// If there are only other scopes as children, put them directly in the
|
|
|
|
// parent instead, as this scope would serve no purpose.
|
2017-07-27 08:06:53 +08:00
|
|
|
if (!HasNonScopeChildren) {
|
2014-10-09 06:20:02 +08:00
|
|
|
FinalChildren.insert(FinalChildren.end(),
|
|
|
|
std::make_move_iterator(Children.begin()),
|
|
|
|
std::make_move_iterator(Children.end()));
|
|
|
|
return;
|
|
|
|
}
|
2014-10-10 01:08:42 +08:00
|
|
|
ScopeDIE = constructLexicalScopeDIE(Scope);
|
2014-10-09 06:20:02 +08:00
|
|
|
assert(ScopeDIE && "Scope DIE should not be null.");
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add children
|
|
|
|
for (auto &I : Children)
|
|
|
|
ScopeDIE->addChild(std::move(I));
|
|
|
|
|
|
|
|
FinalChildren.push_back(std::move(ScopeDIE));
|
|
|
|
}
|
|
|
|
|
2014-11-04 07:10:59 +08:00
|
|
|
void DwarfCompileUnit::addScopeRangeList(DIE &ScopeDIE,
|
|
|
|
SmallVector<RangeSpan, 2> Range) {
|
2015-03-11 00:58:10 +08:00
|
|
|
const TargetLoweringObjectFile &TLOF = Asm->getObjFileLowering();
|
|
|
|
|
2014-10-09 08:11:39 +08:00
|
|
|
// Emit offset in .debug_range as a relocatable label. emitDIE will handle
|
|
|
|
// emitting it appropriately.
|
2015-03-11 00:58:10 +08:00
|
|
|
const MCSymbol *RangeSectionSym =
|
|
|
|
TLOF.getDwarfRangesSection()->getBeginSymbol();
|
2014-10-09 08:11:39 +08:00
|
|
|
|
2015-03-18 04:07:06 +08:00
|
|
|
RangeSpanList List(Asm->createTempSymbol("debug_ranges"), std::move(Range));
|
2014-11-04 07:10:59 +08:00
|
|
|
|
2014-10-09 08:11:39 +08:00
|
|
|
// Under fission, ranges are specified by constant offsets relative to the
|
|
|
|
// CU's DW_AT_GNU_ranges_base.
|
2014-11-04 07:10:59 +08:00
|
|
|
if (isDwoUnit())
|
|
|
|
addSectionDelta(ScopeDIE, dwarf::DW_AT_ranges, List.getSym(),
|
|
|
|
RangeSectionSym);
|
2014-10-09 08:11:39 +08:00
|
|
|
else
|
2014-11-04 07:10:59 +08:00
|
|
|
addSectionLabel(ScopeDIE, dwarf::DW_AT_ranges, List.getSym(),
|
|
|
|
RangeSectionSym);
|
2014-10-09 08:11:39 +08:00
|
|
|
|
|
|
|
// Add the range list to the set of ranges to be emitted.
|
2014-11-04 05:52:56 +08:00
|
|
|
(Skeleton ? Skeleton : this)->CURangeLists.push_back(std::move(List));
|
2014-10-09 08:11:39 +08:00
|
|
|
}
|
|
|
|
|
2014-11-04 07:10:59 +08:00
|
|
|
void DwarfCompileUnit::attachRangesOrLowHighPC(
|
|
|
|
DIE &Die, SmallVector<RangeSpan, 2> Ranges) {
|
|
|
|
if (Ranges.size() == 1) {
|
|
|
|
const auto &single = Ranges.front();
|
|
|
|
attachLowHighPC(Die, single.getStart(), single.getEnd());
|
|
|
|
} else
|
|
|
|
addScopeRangeList(Die, std::move(Ranges));
|
|
|
|
}
|
|
|
|
|
2014-10-09 08:21:42 +08:00
|
|
|
void DwarfCompileUnit::attachRangesOrLowHighPC(
|
|
|
|
DIE &Die, const SmallVectorImpl<InsnRange> &Ranges) {
|
2014-11-04 07:10:59 +08:00
|
|
|
SmallVector<RangeSpan, 2> List;
|
|
|
|
List.reserve(Ranges.size());
|
|
|
|
for (const InsnRange &R : Ranges)
|
|
|
|
List.push_back(RangeSpan(DD->getLabelBeforeInsn(R.first),
|
|
|
|
DD->getLabelAfterInsn(R.second)));
|
|
|
|
attachRangesOrLowHighPC(Die, std::move(List));
|
2014-10-09 08:21:42 +08:00
|
|
|
}
|
|
|
|
|
2014-10-10 00:50:53 +08:00
|
|
|
// This scope represents inlined body of a function. Construct DIE to
|
|
|
|
// represent this concrete inlined copy of the function.
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::constructInlinedScopeDIE(LexicalScope *Scope) {
|
2014-10-10 00:50:53 +08:00
|
|
|
assert(Scope->getScopeNode());
|
2015-04-21 02:32:29 +08:00
|
|
|
auto *DS = Scope->getScopeNode();
|
|
|
|
auto *InlinedSP = getDISubprogram(DS);
|
2014-10-10 00:50:53 +08:00
|
|
|
// Find the subprogram's DwarfCompileUnit in the SPMap in case the subprogram
|
|
|
|
// was inlined from another compile unit.
|
2017-05-12 09:13:45 +08:00
|
|
|
DIE *OriginDIE = getAbstractSPDies()[InlinedSP];
|
2014-10-10 00:50:53 +08:00
|
|
|
assert(OriginDIE && "Unable to find original DIE for an inlined subprogram.");
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
auto ScopeDIE = DIE::get(DIEValueAllocator, dwarf::DW_TAG_inlined_subroutine);
|
2014-10-10 00:50:53 +08:00
|
|
|
addDIEEntry(*ScopeDIE, dwarf::DW_AT_abstract_origin, *OriginDIE);
|
|
|
|
|
|
|
|
attachRangesOrLowHighPC(*ScopeDIE, Scope->getRanges());
|
|
|
|
|
|
|
|
// Add the call site information to the DIE.
|
2015-04-30 00:38:44 +08:00
|
|
|
const DILocation *IA = Scope->getInlinedAt();
|
2014-10-10 00:50:53 +08:00
|
|
|
addUInt(*ScopeDIE, dwarf::DW_AT_call_file, None,
|
2018-01-13 03:17:50 +08:00
|
|
|
getOrCreateSourceID(IA->getFile()));
|
2015-04-14 09:35:55 +08:00
|
|
|
addUInt(*ScopeDIE, dwarf::DW_AT_call_line, None, IA->getLine());
|
2016-10-07 23:21:31 +08:00
|
|
|
if (IA->getDiscriminator() && DD->getDwarfVersion() >= 4)
|
2015-11-12 02:09:47 +08:00
|
|
|
addUInt(*ScopeDIE, dwarf::DW_AT_GNU_discriminator, None,
|
|
|
|
IA->getDiscriminator());
|
2014-10-10 00:50:53 +08:00
|
|
|
|
|
|
|
// Add name to the name table, we do this here because we're guaranteed
|
|
|
|
// to have concrete versions of our DW_TAG_inlined_subprogram nodes.
|
|
|
|
DD->addSubprogramNames(InlinedSP, *ScopeDIE);
|
|
|
|
|
|
|
|
return ScopeDIE;
|
|
|
|
}
|
|
|
|
|
2014-10-10 01:08:42 +08:00
|
|
|
// Construct new DW_TAG_lexical_block for this scope and attach
|
|
|
|
// DW_AT_low_pc/DW_AT_high_pc labels.
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::constructLexicalScopeDIE(LexicalScope *Scope) {
|
2014-10-10 01:08:42 +08:00
|
|
|
if (DD->isLexicalScopeDIENull(Scope))
|
|
|
|
return nullptr;
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
auto ScopeDIE = DIE::get(DIEValueAllocator, dwarf::DW_TAG_lexical_block);
|
2014-10-10 01:08:42 +08:00
|
|
|
if (Scope->isAbstractScope())
|
|
|
|
return ScopeDIE;
|
|
|
|
|
|
|
|
attachRangesOrLowHighPC(*ScopeDIE, Scope->getRanges());
|
|
|
|
|
|
|
|
return ScopeDIE;
|
|
|
|
}
|
|
|
|
|
2014-10-10 01:56:36 +08:00
|
|
|
/// constructVariableDIE - Construct a DIE for the given DbgVariable.
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::constructVariableDIE(DbgVariable &DV, bool Abstract) {
|
2014-10-10 01:56:36 +08:00
|
|
|
auto D = constructVariableDIEImpl(DV, Abstract);
|
|
|
|
DV.setDIE(*D);
|
|
|
|
return D;
|
|
|
|
}
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::constructVariableDIEImpl(const DbgVariable &DV,
|
|
|
|
bool Abstract) {
|
2014-10-10 01:56:36 +08:00
|
|
|
// Define variable debug information entry.
|
2015-06-26 07:52:10 +08:00
|
|
|
auto VariableDie = DIE::get(DIEValueAllocator, DV.getTag());
|
[DebugInfo] Emit DWARF reference for DIVariable 'count' in DISubrange
Summary:
This patch implements the codegen of DWARF debug info for non-constant
'count' fields for DISubrange.
This is patch [2/3] in a series to extend LLVM's DISubrange Metadata
node to support debugging of C99 variable length arrays and vectors with
runtime length like the Scalable Vector Extension for AArch64. It is
also a first step towards representing more complex cases like arrays
in Fortran.
Reviewers: echristo, pcc, aprantl, dexonsmith, clayborg, kristof.beyls, dblaikie
Reviewed By: aprantl
Subscribers: fhahn, aemerson, rengolin, JDevlieghere, llvm-commits
Differential Revision: https://reviews.llvm.org/D41696
llvm-svn: 323323
2018-01-24 21:35:54 +08:00
|
|
|
insertDIE(DV.getVariable(), VariableDie);
|
2014-10-10 01:56:36 +08:00
|
|
|
|
|
|
|
if (Abstract) {
|
|
|
|
applyVariableAttributes(DV, *VariableDie);
|
|
|
|
return VariableDie;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add variable address.
|
|
|
|
|
AsmPrinter: Create a unified .debug_loc stream
This commit removes `DebugLocList` and replaces it with
`DebugLocStream`.
- `DebugLocEntry` no longer contains its byte/comment streams.
- The `DebugLocEntry` list for a variable/inlined-at pair is allocated
on the stack, and released right after `DebugLocEntry::finalize()`
(possible because of the refactoring in r231023). Now, only one
list is in memory at a time now.
- There's a single unified stream for the `.debug_loc` section that
persists, stored in the new `DebugLocStream` data structure.
The last point is important: this collapses the nested `SmallVector<>`s
from `DebugLocList` into unified streams. We previously had something
like the following:
vec<tuple<Label, CU,
vec<tuple<BeginSym, EndSym,
vec<Value>,
vec<char>,
vec<string>>>>>
A `SmallVector` can avoid allocations, but is statically fairly large
for a vector: three pointers plus the size of the small storage, which
is the number of elements in small mode times the element size).
Nesting these is expensive, since an inner vector's size contributes to
the element size of an outer one. (Nesting any vector is expensive...)
In the old data structure, the outer vector's *element* size was 632B,
excluding allocation costs for when the middle and inner vectors
exceeded their small sizes. 312B of this was for the "three" pointers
in the vector-tree beneath it. If you assume 1M functions with an
average of 10 variable/inlined-at pairs each (in an LTO scenario),
that's almost 6GB (besides inner allocations), with almost 3GB for the
"three" pointers.
This came up in a heap profile a little while ago of a `clang -flto -g`
bootstrap, with `DwarfDebug::collectVariableInfo()` using something like
10-15% of the total memory.
With this commit, we have:
tuple<vec<tuple<Label, CU, Offset>>,
vec<tuple<BeginSym, EndSym, Offset, Offset>>,
vec<char>,
vec<string>>
The offsets are used to create `ArrayRef` slices of adjacent
`SmallVector`s. This reduces the number of vectors to four (unrelated
to the number of variable/inlined-at pairs), and caps the number of
allocations at the same number.
Besides saving memory and limiting allocations, this is NFC.
I don't know my way around this code very well yet, but I wonder if we
could go further: why stream to a side-table, instead of directly to the
output stream?
llvm-svn: 235229
2015-04-18 05:34:47 +08:00
|
|
|
unsigned Offset = DV.getDebugLocListIndex();
|
2014-10-10 01:56:36 +08:00
|
|
|
if (Offset != ~0U) {
|
|
|
|
addLocationList(*VariableDie, dwarf::DW_AT_location, Offset);
|
|
|
|
return VariableDie;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check if variable is described by a DBG_VALUE instruction.
|
|
|
|
if (const MachineInstr *DVInsn = DV.getMInsn()) {
|
|
|
|
assert(DVInsn->getNumOperands() == 4);
|
|
|
|
if (DVInsn->getOperand(0).isReg()) {
|
2017-08-03 01:19:13 +08:00
|
|
|
auto RegOp = DVInsn->getOperand(0);
|
|
|
|
auto Op1 = DVInsn->getOperand(1);
|
2014-10-10 01:56:36 +08:00
|
|
|
// If the second operand is an immediate, this is an indirect value.
|
2017-08-03 01:19:13 +08:00
|
|
|
assert((!Op1.isImm() || (Op1.getImm() == 0)) && "unexpected offset");
|
|
|
|
MachineLocation Location(RegOp.getReg(), Op1.isImm());
|
2017-08-03 01:07:38 +08:00
|
|
|
addVariableAddress(DV, *VariableDie, Location);
|
2016-02-18 06:20:08 +08:00
|
|
|
} else if (DVInsn->getOperand(0).isImm()) {
|
|
|
|
// This variable is described by a single constant.
|
|
|
|
// Check whether it has a DIExpression.
|
|
|
|
auto *Expr = DV.getSingleExpression();
|
|
|
|
if (Expr && Expr->getNumElements()) {
|
|
|
|
DIELoc *Loc = new (DIEValueAllocator) DIELoc;
|
|
|
|
DIEDwarfExpression DwarfExpr(*Asm, *this, *Loc);
|
|
|
|
// If there is an expression, emit raw unsigned bytes.
|
2016-12-10 04:43:40 +08:00
|
|
|
DwarfExpr.addFragmentOffset(Expr);
|
2017-03-17 01:42:45 +08:00
|
|
|
DwarfExpr.addUnsignedConstant(DVInsn->getOperand(0).getImm());
|
|
|
|
DwarfExpr.addExpression(Expr);
|
2016-12-20 10:09:43 +08:00
|
|
|
addBlock(*VariableDie, dwarf::DW_AT_location, DwarfExpr.finalize());
|
2016-02-18 06:20:08 +08:00
|
|
|
} else
|
|
|
|
addConstantValue(*VariableDie, DVInsn->getOperand(0), DV.getType());
|
|
|
|
} else if (DVInsn->getOperand(0).isFPImm())
|
2014-10-10 01:56:36 +08:00
|
|
|
addConstantFPValue(*VariableDie, DVInsn->getOperand(0));
|
|
|
|
else if (DVInsn->getOperand(0).isCImm())
|
|
|
|
addConstantValue(*VariableDie, DVInsn->getOperand(0).getCImm(),
|
|
|
|
DV.getType());
|
|
|
|
|
|
|
|
return VariableDie;
|
|
|
|
}
|
|
|
|
|
|
|
|
// .. else use frame index.
|
2017-02-18 03:42:32 +08:00
|
|
|
if (!DV.hasFrameIndexExprs())
|
2015-02-11 07:18:28 +08:00
|
|
|
return VariableDie;
|
|
|
|
|
Reapply "AsmPrinter: Change DIEValue to be stored by value"
This reverts commit r238350, effectively reapplying r238349 after fixing
(all?) the problems, all somehow related to how I was using
`AlignedArrayCharUnion<>` inside `DIEValue`:
- MSVC can only handle `sizeof()` on types, not values. Change the
assert.
- GCC doesn't know the `is_trivially_copyable` type trait. Instead of
asserting it, add destructors.
- Call placement new even when constructing POD (i.e., the pointers).
- Instead of copying the char buffer, copy the casted classes.
I've left in a couple of `static_assert`s that I think both MSVC and GCC
know how to handle. If the bots disagree with me, I'll remove them.
- Check that the constructed type is either standard layout or a
pointer. This protects against a programming error: we really want
the "small" `DIEValue`s to be small and simple, so don't
accidentally change them not to be.
- Similarly, check that the size of the buffer is no bigger than a
`uint64_t` or a pointer. (I thought checking against
`sizeof(uint64_t)` would be good enough, but Chandler suggested that
pointers might sometimes be bigger than that in the context of
sanitizers.)
I've also committed r238359 in the meantime, which introduces a
DIEValue.def to simplify dispatching between the various types (thanks
to a review comment by David Blaikie). Without that, this commit would
be almost unintelligible.
Here's the original commit message:
--
Change `DIEValue` to be stored/passed/etc. by value, instead of
reference. It's now a discriminated union, with a `Val` field storing
the actual type. The classes that used to inherit from `DIEValue` no
longer do. There are two categories of these:
- Small values fit in a single pointer and are stored by value.
- Large values require auxiliary storage, and are stored by reference.
The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp. It
was relying on `DIEInteger`s being passed around by reference, so I
replaced that assumption with a `PatchLocation` type that stores a safe
reference to where the `DIEInteger` lives instead.
This commit causes a temporary regression in memory usage, since I've
left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit. I
measured an increase from 845 MB to 879 MB, around 3.9%. The follow-up
drops it lower than the starting point, and I've only recently brought
the memory this low anyway, so I'm committing these changes separately
to keep them incremental. (I also considered swapping the commits, but
the other one first would cause a lot more code churn.)
(I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`;
see r236629 for details.)
--
llvm-svn: 238362
2015-05-28 06:14:58 +08:00
|
|
|
DIELoc *Loc = new (DIEValueAllocator) DIELoc;
|
2015-02-11 07:18:28 +08:00
|
|
|
DIEDwarfExpression DwarfExpr(*Asm, *this, *Loc);
|
2017-02-18 03:42:32 +08:00
|
|
|
for (auto &Fragment : DV.getFrameIndexExprs()) {
|
2014-10-10 01:56:36 +08:00
|
|
|
unsigned FrameReg = 0;
|
2017-04-18 09:21:53 +08:00
|
|
|
const DIExpression *Expr = Fragment.Expr;
|
2015-02-21 06:36:11 +08:00
|
|
|
const TargetFrameLowering *TFI = Asm->MF->getSubtarget().getFrameLowering();
|
2017-02-18 03:42:32 +08:00
|
|
|
int Offset = TFI->getFrameIndexReference(*Asm->MF, Fragment.FI, FrameReg);
|
2017-04-18 09:21:53 +08:00
|
|
|
DwarfExpr.addFragmentOffset(Expr);
|
2017-03-21 05:35:09 +08:00
|
|
|
SmallVector<uint64_t, 8> Ops;
|
2017-06-14 21:14:38 +08:00
|
|
|
Ops.push_back(dwarf::DW_OP_plus_uconst);
|
2017-03-21 05:35:09 +08:00
|
|
|
Ops.push_back(Offset);
|
2017-04-18 09:21:53 +08:00
|
|
|
Ops.append(Expr->elements_begin(), Expr->elements_end());
|
|
|
|
DIExpressionCursor Cursor(Ops);
|
2017-04-20 07:42:25 +08:00
|
|
|
DwarfExpr.setMemoryLocationKind();
|
|
|
|
DwarfExpr.addMachineRegExpression(
|
|
|
|
*Asm->MF->getSubtarget().getRegisterInfo(), Cursor, FrameReg);
|
2017-04-18 09:21:53 +08:00
|
|
|
DwarfExpr.addExpression(std::move(Cursor));
|
2014-10-10 01:56:36 +08:00
|
|
|
}
|
2016-12-20 10:09:43 +08:00
|
|
|
addBlock(*VariableDie, dwarf::DW_AT_location, DwarfExpr.finalize());
|
2014-10-10 01:56:36 +08:00
|
|
|
|
|
|
|
return VariableDie;
|
|
|
|
}
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::constructVariableDIE(DbgVariable &DV,
|
|
|
|
const LexicalScope &Scope,
|
|
|
|
DIE *&ObjectPointer) {
|
2014-10-10 01:56:39 +08:00
|
|
|
auto Var = constructVariableDIE(DV, Scope.isAbstractScope());
|
|
|
|
if (DV.isObjectPointer())
|
2015-06-26 07:52:10 +08:00
|
|
|
ObjectPointer = Var;
|
2014-10-10 01:56:39 +08:00
|
|
|
return Var;
|
|
|
|
}
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::createScopeChildrenDIE(LexicalScope *Scope,
|
|
|
|
SmallVectorImpl<DIE *> &Children,
|
2017-07-27 08:06:53 +08:00
|
|
|
bool *HasNonScopeChildren) {
|
|
|
|
assert(Children.empty());
|
2014-10-10 02:24:28 +08:00
|
|
|
DIE *ObjectPointer = nullptr;
|
|
|
|
|
2014-10-25 01:57:34 +08:00
|
|
|
for (DbgVariable *DV : DU->getScopeVariables().lookup(Scope))
|
2014-10-10 02:24:28 +08:00
|
|
|
Children.push_back(constructVariableDIE(*DV, *Scope, ObjectPointer));
|
|
|
|
|
2017-07-27 08:06:53 +08:00
|
|
|
// Skip imported directives in gmlt-like data.
|
|
|
|
if (!includeMinimalInlineScopes()) {
|
|
|
|
// There is no need to emit empty lexical block DIE.
|
|
|
|
for (const auto *IE : ImportedEntities[Scope->getScopeNode()])
|
|
|
|
Children.push_back(
|
|
|
|
constructImportedEntityDIE(cast<DIImportedEntity>(IE)));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (HasNonScopeChildren)
|
|
|
|
*HasNonScopeChildren = !Children.empty();
|
2014-10-10 02:24:28 +08:00
|
|
|
|
|
|
|
for (LexicalScope *LS : Scope->getChildren())
|
|
|
|
constructScopeDIE(LS, Children);
|
|
|
|
|
|
|
|
return ObjectPointer;
|
|
|
|
}
|
|
|
|
|
2016-12-16 07:17:52 +08:00
|
|
|
void DwarfCompileUnit::constructSubprogramScopeDIE(const DISubprogram *Sub, LexicalScope *Scope) {
|
2014-10-10 04:21:36 +08:00
|
|
|
DIE &ScopeDIE = updateSubprogramScopeDIE(Sub);
|
|
|
|
|
2016-12-16 07:17:52 +08:00
|
|
|
if (Scope) {
|
|
|
|
assert(!Scope->getInlinedAt());
|
|
|
|
assert(!Scope->isAbstractScope());
|
|
|
|
// Collect lexical scope children first.
|
|
|
|
// ObjectPointer might be a local (non-argument) local variable if it's a
|
|
|
|
// block's synthetic this pointer.
|
|
|
|
if (DIE *ObjectPointer = createAndAddScopeChildren(Scope, ScopeDIE))
|
|
|
|
addDIEEntry(ScopeDIE, dwarf::DW_AT_object_pointer, *ObjectPointer);
|
|
|
|
}
|
|
|
|
|
2014-10-10 04:21:36 +08:00
|
|
|
// If this is a variadic function, add an unspecified parameter.
|
2015-04-30 00:38:44 +08:00
|
|
|
DITypeRefArray FnArgs = Sub->getType()->getTypeArray();
|
2014-10-24 06:27:50 +08:00
|
|
|
|
2014-10-10 04:21:36 +08:00
|
|
|
// If we have a single element of null, it is a function that returns void.
|
|
|
|
// If we have more than one elements and the last one is null, it is a
|
|
|
|
// variadic function.
|
2015-04-07 12:14:33 +08:00
|
|
|
if (FnArgs.size() > 1 && !FnArgs[FnArgs.size() - 1] &&
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
!includeMinimalInlineScopes())
|
2015-06-26 07:52:10 +08:00
|
|
|
ScopeDIE.addChild(
|
|
|
|
DIE::get(DIEValueAllocator, dwarf::DW_TAG_unspecified_parameters));
|
2014-10-10 04:21:36 +08:00
|
|
|
}
|
|
|
|
|
2014-10-10 04:26:15 +08:00
|
|
|
DIE *DwarfCompileUnit::createAndAddScopeChildren(LexicalScope *Scope,
|
|
|
|
DIE &ScopeDIE) {
|
|
|
|
// We create children when the scope DIE is not null.
|
2015-06-26 07:52:10 +08:00
|
|
|
SmallVector<DIE *, 8> Children;
|
2014-10-10 04:26:15 +08:00
|
|
|
DIE *ObjectPointer = createScopeChildrenDIE(Scope, Children);
|
|
|
|
|
|
|
|
// Add children
|
|
|
|
for (auto &I : Children)
|
|
|
|
ScopeDIE.addChild(std::move(I));
|
|
|
|
|
|
|
|
return ObjectPointer;
|
|
|
|
}
|
|
|
|
|
2015-11-12 02:09:47 +08:00
|
|
|
void DwarfCompileUnit::constructAbstractSubprogramScopeDIE(
|
|
|
|
LexicalScope *Scope) {
|
2017-05-12 09:13:45 +08:00
|
|
|
DIE *&AbsDef = getAbstractSPDies()[Scope->getScopeNode()];
|
2014-11-01 05:57:02 +08:00
|
|
|
if (AbsDef)
|
|
|
|
return;
|
|
|
|
|
2015-04-30 00:38:44 +08:00
|
|
|
auto *SP = cast<DISubprogram>(Scope->getScopeNode());
|
2014-10-10 14:39:26 +08:00
|
|
|
|
|
|
|
DIE *ContextDIE;
|
2017-11-15 18:57:05 +08:00
|
|
|
DwarfCompileUnit *ContextCU = this;
|
2014-10-10 14:39:26 +08:00
|
|
|
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
if (includeMinimalInlineScopes())
|
|
|
|
ContextDIE = &getUnitDie();
|
2014-10-10 14:39:26 +08:00
|
|
|
// Some of this is duplicated from DwarfUnit::getOrCreateSubprogramDIE, with
|
2015-04-18 08:35:36 +08:00
|
|
|
// the important distinction that the debug node is not associated with the
|
|
|
|
// DIE (since the debug node will be associated with the concrete DIE, if
|
2014-10-10 14:39:26 +08:00
|
|
|
// any). It could be refactored to some common utility function.
|
2015-04-14 11:40:37 +08:00
|
|
|
else if (auto *SPDecl = SP->getDeclaration()) {
|
2014-10-10 14:39:26 +08:00
|
|
|
ContextDIE = &getUnitDie();
|
|
|
|
getOrCreateSubprogramDIE(SPDecl);
|
2017-11-15 18:57:05 +08:00
|
|
|
} else {
|
2015-04-14 11:40:37 +08:00
|
|
|
ContextDIE = getOrCreateContextDIE(resolve(SP->getScope()));
|
2017-11-15 18:57:05 +08:00
|
|
|
// The scope may be shared with a subprogram that has already been
|
|
|
|
// constructed in another CU, in which case we need to construct this
|
|
|
|
// subprogram in the same CU.
|
|
|
|
ContextCU = DD->lookupCU(ContextDIE->getUnitDie());
|
|
|
|
}
|
2014-10-10 14:39:26 +08:00
|
|
|
|
2015-04-18 08:35:36 +08:00
|
|
|
// Passing null as the associated node because the abstract definition
|
2014-10-10 14:39:26 +08:00
|
|
|
// shouldn't be found by lookup.
|
2017-11-15 18:57:05 +08:00
|
|
|
AbsDef = &ContextCU->createAndAddDIE(dwarf::DW_TAG_subprogram, *ContextDIE, nullptr);
|
|
|
|
ContextCU->applySubprogramAttributesToDefinition(SP, *AbsDef);
|
2014-10-10 14:39:26 +08:00
|
|
|
|
2017-11-15 18:57:05 +08:00
|
|
|
if (!ContextCU->includeMinimalInlineScopes())
|
|
|
|
ContextCU->addUInt(*AbsDef, dwarf::DW_AT_inline, None, dwarf::DW_INL_inlined);
|
|
|
|
if (DIE *ObjectPointer = ContextCU->createAndAddScopeChildren(Scope, *AbsDef))
|
|
|
|
ContextCU->addDIEEntry(*AbsDef, dwarf::DW_AT_object_pointer, *ObjectPointer);
|
2014-10-10 14:39:26 +08:00
|
|
|
}
|
|
|
|
|
2015-06-26 07:52:10 +08:00
|
|
|
DIE *DwarfCompileUnit::constructImportedEntityDIE(
|
|
|
|
const DIImportedEntity *Module) {
|
2016-04-30 09:44:07 +08:00
|
|
|
DIE *IMDie = DIE::get(DIEValueAllocator, (dwarf::Tag)Module->getTag());
|
|
|
|
insertDIE(Module, IMDie);
|
2014-10-25 05:31:09 +08:00
|
|
|
DIE *EntityDie;
|
2015-04-14 09:46:44 +08:00
|
|
|
auto *Entity = resolve(Module->getEntity());
|
2015-04-30 00:38:44 +08:00
|
|
|
if (auto *NS = dyn_cast<DINamespace>(Entity))
|
2015-04-07 07:27:40 +08:00
|
|
|
EntityDie = getOrCreateNameSpace(NS);
|
2015-06-30 10:13:04 +08:00
|
|
|
else if (auto *M = dyn_cast<DIModule>(Entity))
|
|
|
|
EntityDie = getOrCreateModule(M);
|
2015-04-30 00:38:44 +08:00
|
|
|
else if (auto *SP = dyn_cast<DISubprogram>(Entity))
|
2015-04-07 07:27:40 +08:00
|
|
|
EntityDie = getOrCreateSubprogramDIE(SP);
|
2015-04-30 00:38:44 +08:00
|
|
|
else if (auto *T = dyn_cast<DIType>(Entity))
|
2015-04-07 07:27:40 +08:00
|
|
|
EntityDie = getOrCreateTypeDIE(T);
|
2015-04-30 00:38:44 +08:00
|
|
|
else if (auto *GV = dyn_cast<DIGlobalVariable>(Entity))
|
2016-12-20 10:09:43 +08:00
|
|
|
EntityDie = getOrCreateGlobalVariableDIE(GV, {});
|
2014-10-25 05:31:09 +08:00
|
|
|
else
|
|
|
|
EntityDie = getDIE(Entity);
|
|
|
|
assert(EntityDie);
|
2018-01-13 03:17:50 +08:00
|
|
|
addSourceLine(*IMDie, Module->getLine(), Module->getFile());
|
2014-10-25 05:31:09 +08:00
|
|
|
addDIEEntry(*IMDie, dwarf::DW_AT_import, *EntityDie);
|
2015-04-14 09:46:44 +08:00
|
|
|
StringRef Name = Module->getName();
|
2014-10-25 05:31:09 +08:00
|
|
|
if (!Name.empty())
|
|
|
|
addString(*IMDie, dwarf::DW_AT_name, Name);
|
|
|
|
|
|
|
|
return IMDie;
|
|
|
|
}
|
|
|
|
|
2015-04-30 00:38:44 +08:00
|
|
|
void DwarfCompileUnit::finishSubprogramDefinition(const DISubprogram *SP) {
|
2016-04-30 09:44:07 +08:00
|
|
|
DIE *D = getDIE(SP);
|
2017-05-12 09:13:45 +08:00
|
|
|
if (DIE *AbsSPDIE = getAbstractSPDies().lookup(SP)) {
|
2016-04-30 09:44:07 +08:00
|
|
|
if (D)
|
2014-10-10 14:39:29 +08:00
|
|
|
// If this subprogram has an abstract definition, reference that
|
|
|
|
addDIEEntry(*D, dwarf::DW_AT_abstract_origin, *AbsSPDIE);
|
2016-04-30 09:44:07 +08:00
|
|
|
} else {
|
2016-12-16 07:17:52 +08:00
|
|
|
assert(D || includeMinimalInlineScopes());
|
2016-04-30 09:44:07 +08:00
|
|
|
if (D)
|
2014-10-10 14:39:29 +08:00
|
|
|
// And attach the attributes
|
|
|
|
applySubprogramAttributesToDefinition(SP, *D);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-12 09:13:45 +08:00
|
|
|
void DwarfCompileUnit::finishVariableDefinition(const DbgVariable &Var) {
|
|
|
|
DbgVariable *AbsVar = getExistingAbstractVariable(
|
|
|
|
InlinedVariable(Var.getVariable(), Var.getInlinedAt()));
|
|
|
|
auto *VariableDie = Var.getDIE();
|
|
|
|
if (AbsVar && AbsVar->getDIE()) {
|
|
|
|
addDIEEntry(*VariableDie, dwarf::DW_AT_abstract_origin,
|
|
|
|
*AbsVar->getDIE());
|
|
|
|
} else
|
|
|
|
applyVariableAttributes(Var, *VariableDie);
|
|
|
|
}
|
|
|
|
|
|
|
|
DbgVariable *DwarfCompileUnit::getExistingAbstractVariable(InlinedVariable IV) {
|
|
|
|
const DILocalVariable *Cleansed;
|
|
|
|
return getExistingAbstractVariable(IV, Cleansed);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Find abstract variable, if any, associated with Var.
|
|
|
|
DbgVariable *DwarfCompileUnit::getExistingAbstractVariable(
|
|
|
|
InlinedVariable IV, const DILocalVariable *&Cleansed) {
|
|
|
|
// More then one inlined variable corresponds to one abstract variable.
|
|
|
|
Cleansed = IV.first;
|
|
|
|
auto &AbstractVariables = getAbstractVariables();
|
|
|
|
auto I = AbstractVariables.find(Cleansed);
|
|
|
|
if (I != AbstractVariables.end())
|
|
|
|
return I->second.get();
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
void DwarfCompileUnit::createAbstractVariable(const DILocalVariable *Var,
|
|
|
|
LexicalScope *Scope) {
|
|
|
|
assert(Scope && Scope->isAbstractScope());
|
2017-08-18 05:26:39 +08:00
|
|
|
auto AbsDbgVariable = llvm::make_unique<DbgVariable>(Var, /* IA */ nullptr);
|
2017-05-12 09:13:45 +08:00
|
|
|
DU->addScopeVariable(Scope, AbsDbgVariable.get());
|
|
|
|
getAbstractVariables()[Var] = std::move(AbsDbgVariable);
|
|
|
|
}
|
|
|
|
|
2015-03-11 00:58:10 +08:00
|
|
|
void DwarfCompileUnit::emitHeader(bool UseOffsets) {
|
2014-11-02 10:26:24 +08:00
|
|
|
// Don't bother labeling the .dwo unit, as its offset isn't used.
|
2015-03-10 11:11:11 +08:00
|
|
|
if (!Skeleton) {
|
2015-03-18 04:07:06 +08:00
|
|
|
LabelBegin = Asm->createTempSymbol("cu_begin");
|
2015-04-25 03:11:51 +08:00
|
|
|
Asm->OutStreamer->EmitLabel(LabelBegin);
|
2015-03-10 11:11:11 +08:00
|
|
|
}
|
2014-11-02 07:59:23 +08:00
|
|
|
|
2017-03-01 04:24:55 +08:00
|
|
|
dwarf::UnitType UT = Skeleton ? dwarf::DW_UT_split_compile
|
|
|
|
: DD->useSplitDwarf() ? dwarf::DW_UT_skeleton
|
|
|
|
: dwarf::DW_UT_compile;
|
|
|
|
DwarfUnit::emitCommonHeader(UseOffsets, UT);
|
2014-11-02 07:59:23 +08:00
|
|
|
}
|
|
|
|
|
2017-09-13 05:50:41 +08:00
|
|
|
bool DwarfCompileUnit::hasDwarfPubSections() const {
|
|
|
|
// Opting in to GNU Pubnames/types overrides the default to ensure these are
|
|
|
|
// generated for things like Gold's gdb_index generation.
|
|
|
|
if (CUNode->getGnuPubnames())
|
|
|
|
return true;
|
|
|
|
|
2017-09-13 05:50:55 +08:00
|
|
|
return DD->tuneForGDB() && !includeMinimalInlineScopes();
|
2017-09-13 05:50:41 +08:00
|
|
|
}
|
|
|
|
|
2014-11-02 14:16:39 +08:00
|
|
|
/// addGlobalName - Add a new global name to the compile unit.
|
2017-02-03 08:44:18 +08:00
|
|
|
void DwarfCompileUnit::addGlobalName(StringRef Name, const DIE &Die,
|
2015-04-30 00:38:44 +08:00
|
|
|
const DIScope *Context) {
|
2017-09-13 05:50:41 +08:00
|
|
|
if (!hasDwarfPubSections())
|
2014-11-02 14:16:39 +08:00
|
|
|
return;
|
|
|
|
std::string FullName = getParentContextString(Context) + Name.str();
|
|
|
|
GlobalNames[FullName] = &Die;
|
|
|
|
}
|
|
|
|
|
2017-02-03 08:44:18 +08:00
|
|
|
void DwarfCompileUnit::addGlobalNameForTypeUnit(StringRef Name,
|
|
|
|
const DIScope *Context) {
|
2017-09-13 05:50:41 +08:00
|
|
|
if (!hasDwarfPubSections())
|
2017-02-03 08:44:18 +08:00
|
|
|
return;
|
|
|
|
std::string FullName = getParentContextString(Context) + Name.str();
|
|
|
|
// Insert, allowing the entry to remain as-is if it's already present
|
|
|
|
// This way the CU-level type DIE is preferred over the "can't describe this
|
|
|
|
// type as a unit offset because it's not really in the CU at all, it's only
|
|
|
|
// in a type unit"
|
|
|
|
GlobalNames.insert(std::make_pair(std::move(FullName), &getUnitDie()));
|
|
|
|
}
|
|
|
|
|
2014-11-02 14:16:39 +08:00
|
|
|
/// Add a new global type to the unit.
|
2015-04-30 00:38:44 +08:00
|
|
|
void DwarfCompileUnit::addGlobalType(const DIType *Ty, const DIE &Die,
|
|
|
|
const DIScope *Context) {
|
2017-09-13 05:50:41 +08:00
|
|
|
if (!hasDwarfPubSections())
|
2014-11-02 14:16:39 +08:00
|
|
|
return;
|
2015-04-16 09:01:28 +08:00
|
|
|
std::string FullName = getParentContextString(Context) + Ty->getName().str();
|
2014-11-02 14:16:39 +08:00
|
|
|
GlobalTypes[FullName] = &Die;
|
|
|
|
}
|
2014-11-02 07:59:23 +08:00
|
|
|
|
2017-02-03 08:44:18 +08:00
|
|
|
void DwarfCompileUnit::addGlobalTypeUnitType(const DIType *Ty,
|
|
|
|
const DIScope *Context) {
|
2017-09-13 05:50:41 +08:00
|
|
|
if (!hasDwarfPubSections())
|
2017-02-03 08:44:18 +08:00
|
|
|
return;
|
|
|
|
std::string FullName = getParentContextString(Context) + Ty->getName().str();
|
|
|
|
// Insert, allowing the entry to remain as-is if it's already present
|
|
|
|
// This way the CU-level type DIE is preferred over the "can't describe this
|
|
|
|
// type as a unit offset because it's not really in the CU at all, it's only
|
|
|
|
// in a type unit"
|
|
|
|
GlobalTypes.insert(std::make_pair(std::move(FullName), &getUnitDie()));
|
|
|
|
}
|
|
|
|
|
2014-11-02 14:37:23 +08:00
|
|
|
/// addVariableAddress - Add DW_AT_location attribute for a
|
|
|
|
/// DbgVariable based on provided MachineLocation.
|
|
|
|
void DwarfCompileUnit::addVariableAddress(const DbgVariable &DV, DIE &Die,
|
|
|
|
MachineLocation Location) {
|
2017-10-13 06:54:36 +08:00
|
|
|
// addBlockByrefAddress is obsolete and will be removed soon.
|
|
|
|
// The clang frontend always generates block byref variables with a
|
|
|
|
// complex expression that encodes exactly what addBlockByrefAddress
|
|
|
|
// would do.
|
|
|
|
assert((!DV.isBlockByrefVariable() || DV.hasComplexAddress()) &&
|
|
|
|
"block byref variable without a complex expression");
|
AsmPrinter: Rewrite initialization of DbgVariable, NFC
There are three types of `DbgVariable`:
- alloca variables, created based on the MMI table,
- register variables, created based on DBG_VALUE instructions, and
- optimized-out variables.
This commit reconfigures `DbgVariable` to make it easier to tell which
kind we have, and make initialization a little clearer.
For MMI/alloca variables, `FrameIndex.size()` must always equal
`Expr.size()`, and there shouldn't be an `MInsn`. For register
variables (with a `MInsn`), `FrameIndex` must be empty, and `Expr`
should have 0 or 1 element depending on whether it has a complex
expression (registers with multiple locations use `DebugLocListIndex`).
Optimized-out variables shouldn't have any of these fields.
Moreover, this separates DBG_VALUE initialization until after the
variable is created, simplifying logic in a future commit that changes
`collectVariableInfo()` to stop creating empty .debug_loc entries/lists.
llvm-svn: 240243
2015-06-22 00:50:43 +08:00
|
|
|
if (DV.hasComplexAddress())
|
2014-11-02 14:37:23 +08:00
|
|
|
addComplexAddress(DV, Die, dwarf::DW_AT_location, Location);
|
|
|
|
else if (DV.isBlockByrefVariable())
|
|
|
|
addBlockByrefAddress(DV, Die, dwarf::DW_AT_location, Location);
|
|
|
|
else
|
2015-01-20 01:57:29 +08:00
|
|
|
addAddress(Die, dwarf::DW_AT_location, Location);
|
2014-11-02 14:37:23 +08:00
|
|
|
}
|
2014-11-02 14:46:40 +08:00
|
|
|
|
|
|
|
/// Add an address attribute to a die based on the location provided.
|
|
|
|
void DwarfCompileUnit::addAddress(DIE &Die, dwarf::Attribute Attribute,
|
2015-01-20 01:57:29 +08:00
|
|
|
const MachineLocation &Location) {
|
Reapply "AsmPrinter: Change DIEValue to be stored by value"
This reverts commit r238350, effectively reapplying r238349 after fixing
(all?) the problems, all somehow related to how I was using
`AlignedArrayCharUnion<>` inside `DIEValue`:
- MSVC can only handle `sizeof()` on types, not values. Change the
assert.
- GCC doesn't know the `is_trivially_copyable` type trait. Instead of
asserting it, add destructors.
- Call placement new even when constructing POD (i.e., the pointers).
- Instead of copying the char buffer, copy the casted classes.
I've left in a couple of `static_assert`s that I think both MSVC and GCC
know how to handle. If the bots disagree with me, I'll remove them.
- Check that the constructed type is either standard layout or a
pointer. This protects against a programming error: we really want
the "small" `DIEValue`s to be small and simple, so don't
accidentally change them not to be.
- Similarly, check that the size of the buffer is no bigger than a
`uint64_t` or a pointer. (I thought checking against
`sizeof(uint64_t)` would be good enough, but Chandler suggested that
pointers might sometimes be bigger than that in the context of
sanitizers.)
I've also committed r238359 in the meantime, which introduces a
DIEValue.def to simplify dispatching between the various types (thanks
to a review comment by David Blaikie). Without that, this commit would
be almost unintelligible.
Here's the original commit message:
--
Change `DIEValue` to be stored/passed/etc. by value, instead of
reference. It's now a discriminated union, with a `Val` field storing
the actual type. The classes that used to inherit from `DIEValue` no
longer do. There are two categories of these:
- Small values fit in a single pointer and are stored by value.
- Large values require auxiliary storage, and are stored by reference.
The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp. It
was relying on `DIEInteger`s being passed around by reference, so I
replaced that assumption with a `PatchLocation` type that stores a safe
reference to where the `DIEInteger` lives instead.
This commit causes a temporary regression in memory usage, since I've
left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit. I
measured an increase from 845 MB to 879 MB, around 3.9%. The follow-up
drops it lower than the starting point, and I've only recently brought
the memory this low anyway, so I'm committing these changes separately
to keep them incremental. (I also considered swapping the commits, but
the other one first would cause a lot more code churn.)
(I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`;
see r236629 for details.)
--
llvm-svn: 238362
2015-05-28 06:14:58 +08:00
|
|
|
DIELoc *Loc = new (DIEValueAllocator) DIELoc;
|
2017-03-21 05:35:09 +08:00
|
|
|
DIEDwarfExpression DwarfExpr(*Asm, *this, *Loc);
|
2017-04-20 07:42:25 +08:00
|
|
|
if (Location.isIndirect())
|
|
|
|
DwarfExpr.setMemoryLocationKind();
|
2014-12-05 09:02:46 +08:00
|
|
|
|
2017-08-02 23:22:17 +08:00
|
|
|
DIExpressionCursor Cursor({});
|
2017-03-21 05:35:09 +08:00
|
|
|
const TargetRegisterInfo &TRI = *Asm->MF->getSubtarget().getRegisterInfo();
|
2017-04-20 07:42:25 +08:00
|
|
|
if (!DwarfExpr.addMachineRegExpression(TRI, Cursor, Location.getReg()))
|
2014-12-05 09:02:46 +08:00
|
|
|
return;
|
2017-03-21 05:35:09 +08:00
|
|
|
DwarfExpr.addExpression(std::move(Cursor));
|
2014-12-05 09:02:46 +08:00
|
|
|
|
2014-11-02 14:46:40 +08:00
|
|
|
// Now attach the location information to the DIE.
|
2017-03-21 05:35:09 +08:00
|
|
|
addBlock(Die, Attribute, DwarfExpr.finalize());
|
2014-11-02 14:46:40 +08:00
|
|
|
}
|
2014-11-02 14:58:44 +08:00
|
|
|
|
|
|
|
/// Start with the address based on the location provided, and generate the
|
|
|
|
/// DWARF information necessary to find the actual variable given the extra
|
|
|
|
/// address information encoded in the DbgVariable, starting from the starting
|
|
|
|
/// location. Add the DWARF information to the die.
|
|
|
|
void DwarfCompileUnit::addComplexAddress(const DbgVariable &DV, DIE &Die,
|
|
|
|
dwarf::Attribute Attribute,
|
|
|
|
const MachineLocation &Location) {
|
Reapply "AsmPrinter: Change DIEValue to be stored by value"
This reverts commit r238350, effectively reapplying r238349 after fixing
(all?) the problems, all somehow related to how I was using
`AlignedArrayCharUnion<>` inside `DIEValue`:
- MSVC can only handle `sizeof()` on types, not values. Change the
assert.
- GCC doesn't know the `is_trivially_copyable` type trait. Instead of
asserting it, add destructors.
- Call placement new even when constructing POD (i.e., the pointers).
- Instead of copying the char buffer, copy the casted classes.
I've left in a couple of `static_assert`s that I think both MSVC and GCC
know how to handle. If the bots disagree with me, I'll remove them.
- Check that the constructed type is either standard layout or a
pointer. This protects against a programming error: we really want
the "small" `DIEValue`s to be small and simple, so don't
accidentally change them not to be.
- Similarly, check that the size of the buffer is no bigger than a
`uint64_t` or a pointer. (I thought checking against
`sizeof(uint64_t)` would be good enough, but Chandler suggested that
pointers might sometimes be bigger than that in the context of
sanitizers.)
I've also committed r238359 in the meantime, which introduces a
DIEValue.def to simplify dispatching between the various types (thanks
to a review comment by David Blaikie). Without that, this commit would
be almost unintelligible.
Here's the original commit message:
--
Change `DIEValue` to be stored/passed/etc. by value, instead of
reference. It's now a discriminated union, with a `Val` field storing
the actual type. The classes that used to inherit from `DIEValue` no
longer do. There are two categories of these:
- Small values fit in a single pointer and are stored by value.
- Large values require auxiliary storage, and are stored by reference.
The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp. It
was relying on `DIEInteger`s being passed around by reference, so I
replaced that assumption with a `PatchLocation` type that stores a safe
reference to where the `DIEInteger` lives instead.
This commit causes a temporary regression in memory usage, since I've
left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit. I
measured an increase from 845 MB to 879 MB, around 3.9%. The follow-up
drops it lower than the starting point, and I've only recently brought
the memory this low anyway, so I'm committing these changes separately
to keep them incremental. (I also considered swapping the commits, but
the other one first would cause a lot more code churn.)
(I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`;
see r236629 for details.)
--
llvm-svn: 238362
2015-05-28 06:14:58 +08:00
|
|
|
DIELoc *Loc = new (DIEValueAllocator) DIELoc;
|
2015-01-14 09:01:30 +08:00
|
|
|
DIEDwarfExpression DwarfExpr(*Asm, *this, *Loc);
|
2017-03-21 05:35:09 +08:00
|
|
|
const DIExpression *DIExpr = DV.getSingleExpression();
|
|
|
|
DwarfExpr.addFragmentOffset(DIExpr);
|
2017-04-20 07:42:25 +08:00
|
|
|
if (Location.isIndirect())
|
|
|
|
DwarfExpr.setMemoryLocationKind();
|
2017-03-21 05:35:09 +08:00
|
|
|
|
2017-08-02 23:22:17 +08:00
|
|
|
DIExpressionCursor Cursor(DIExpr);
|
2016-05-21 03:35:17 +08:00
|
|
|
const TargetRegisterInfo &TRI = *Asm->MF->getSubtarget().getRegisterInfo();
|
2017-04-20 07:42:25 +08:00
|
|
|
if (!DwarfExpr.addMachineRegExpression(TRI, Cursor, Location.getReg()))
|
2016-11-03 00:12:20 +08:00
|
|
|
return;
|
2017-03-21 05:35:09 +08:00
|
|
|
DwarfExpr.addExpression(std::move(Cursor));
|
2014-11-02 14:58:44 +08:00
|
|
|
|
|
|
|
// Now attach the location information to the DIE.
|
2017-03-21 05:35:09 +08:00
|
|
|
addBlock(Die, Attribute, DwarfExpr.finalize());
|
2014-11-02 14:58:44 +08:00
|
|
|
}
|
2014-11-02 15:03:19 +08:00
|
|
|
|
|
|
|
/// Add a Dwarf loclistptr attribute data and value.
|
|
|
|
void DwarfCompileUnit::addLocationList(DIE &Die, dwarf::Attribute Attribute,
|
|
|
|
unsigned Index) {
|
|
|
|
dwarf::Form Form = DD->getDwarfVersion() >= 4 ? dwarf::DW_FORM_sec_offset
|
|
|
|
: dwarf::DW_FORM_data4;
|
2015-06-26 07:46:41 +08:00
|
|
|
Die.addValue(DIEValueAllocator, Attribute, Form, DIELocList(Index));
|
2014-11-02 15:03:19 +08:00
|
|
|
}
|
2014-11-02 15:06:51 +08:00
|
|
|
|
2014-11-02 15:08:12 +08:00
|
|
|
void DwarfCompileUnit::applyVariableAttributes(const DbgVariable &Var,
|
|
|
|
DIE &VariableDie) {
|
2014-11-02 15:06:51 +08:00
|
|
|
StringRef Name = Var.getName();
|
|
|
|
if (!Name.empty())
|
|
|
|
addString(VariableDie, dwarf::DW_AT_name, Name);
|
2016-10-26 19:59:03 +08:00
|
|
|
const auto *DIVar = Var.getVariable();
|
|
|
|
if (DIVar)
|
|
|
|
if (uint32_t AlignInBytes = DIVar->getAlignInBytes())
|
|
|
|
addUInt(VariableDie, dwarf::DW_AT_alignment, dwarf::DW_FORM_udata,
|
|
|
|
AlignInBytes);
|
|
|
|
|
|
|
|
addSourceLine(VariableDie, DIVar);
|
2014-11-02 15:06:51 +08:00
|
|
|
addType(VariableDie, Var.getType());
|
|
|
|
if (Var.isArtificial())
|
|
|
|
addFlag(VariableDie, dwarf::DW_AT_artificial);
|
|
|
|
}
|
2014-11-02 15:11:55 +08:00
|
|
|
|
|
|
|
/// Add a Dwarf expression attribute data and value.
|
|
|
|
void DwarfCompileUnit::addExpr(DIELoc &Die, dwarf::Form Form,
|
|
|
|
const MCExpr *Expr) {
|
2015-06-26 07:46:41 +08:00
|
|
|
Die.addValue(DIEValueAllocator, (dwarf::Attribute)0, Form, DIEExpr(Expr));
|
2014-11-02 15:11:55 +08:00
|
|
|
}
|
2014-11-02 16:09:09 +08:00
|
|
|
|
2015-04-21 06:10:08 +08:00
|
|
|
void DwarfCompileUnit::applySubprogramAttributesToDefinition(
|
2015-04-30 00:38:44 +08:00
|
|
|
const DISubprogram *SP, DIE &SPDie) {
|
2015-04-14 11:40:37 +08:00
|
|
|
auto *SPDecl = SP->getDeclaration();
|
2015-04-21 02:32:29 +08:00
|
|
|
auto *Context = resolve(SPDecl ? SPDecl->getScope() : SP->getScope());
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
applySubprogramAttributes(SP, SPDie, includeMinimalInlineScopes());
|
2015-04-14 11:40:37 +08:00
|
|
|
addGlobalName(SP->getName(), SPDie, Context);
|
2014-11-02 16:09:09 +08:00
|
|
|
}
|
2014-11-02 16:51:37 +08:00
|
|
|
|
|
|
|
bool DwarfCompileUnit::isDwoUnit() const {
|
|
|
|
return DD->useSplitDwarf() && Skeleton;
|
|
|
|
}
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
|
|
|
|
bool DwarfCompileUnit::includeMinimalInlineScopes() const {
|
2016-04-01 07:56:58 +08:00
|
|
|
return getCUNode()->getEmissionKind() == DICompileUnit::LineTablesOnly ||
|
Provide gmlt-like inline scope information in the skeleton CU to facilitate symbolication without needing the .dwo files
Clang -gsplit-dwarf self-host -O0, binary increases by 0.0005%, -O2,
binary increases by 25%.
A large binary inside Google, split-dwarf, -O0, and other internal flags
(GDB index, etc) increases by 1.8%, optimized build is 35%.
The size impact may be somewhat greater in .o files (I haven't measured
that much - since the linked executable -O0 numbers seemed low enough)
due to relocations. These relocations could be removed if we taught the
llvm-symbolizer to handle indexed addressing in the .o file (GDB can't
cope with this just yet, but GDB won't be reading this info anyway).
Also debug_ranges could be shared between .o and .dwo, though ideally
debug_ranges would get a schema that could used index(+offset)
addressing, and move to the .dwo file, then we'd be back to sharing
addresses in the address pool again.
But for now, these sizes seem small enough to go ahead with this.
Verified that no other DW_TAGs are produced into the .o file other than
subprograms and inlined_subroutines.
llvm-svn: 221306
2014-11-05 06:12:25 +08:00
|
|
|
(DD->useSplitDwarf() && !Skeleton);
|
|
|
|
}
|