DA: remove uses of GEP, only ask SCEV
It's been quite some time the Dependence Analysis (DA) is broken,
as it uses the GEP representation to "identify" multi-dimensional arrays.
It even wrongly detects multi-dimensional arrays in single nested loops:
from test/Analysis/DependenceAnalysis/Coupled.ll, example @couple6
;; for (long int i = 0; i < 50; i++) {
;; A[i][3*i - 6] = i;
;; *B++ = A[i][i];
DA used to detect two subscripts, which makes no sense in the LLVM IR
or in C/C++ semantics, as there are no guarantees as in Fortran of
subscripts not overlapping into a next array dimension:
maximum nesting levels = 1
SrcPtrSCEV = %A
DstPtrSCEV = %A
using GEPs
subscript 0
src = {0,+,1}<nuw><nsw><%for.body>
dst = {0,+,1}<nuw><nsw><%for.body>
class = 1
loops = {1}
subscript 1
src = {-6,+,3}<nsw><%for.body>
dst = {0,+,1}<nuw><nsw><%for.body>
class = 1
loops = {1}
Separable = {}
Coupled = {1}
With the current patch, DA will correctly work on only one dimension:
maximum nesting levels = 1
SrcSCEV = {(-2424 + %A)<nsw>,+,1212}<%for.body>
DstSCEV = {%A,+,404}<%for.body>
subscript 0
src = {(-2424 + %A)<nsw>,+,1212}<%for.body>
dst = {%A,+,404}<%for.body>
class = 1
loops = {1}
Separable = {0}
Coupled = {}
This change removes all uses of GEP from DA, and we now only rely
on the SCEV representation.
The patch does not turn on -da-delinearize by default, and so the DA analysis
will be more conservative in the case of multi-dimensional memory accesses in
nested loops.
I disabled some interchange tests, as the DA is not able to disambiguate
the dependence anymore. To make DA stronger, we may need to
compute a bound on the number of iterations based on the access functions
and array dimensions.
The patch cleans up all the CHECKs in test/Transforms/LoopInterchange/*.ll to
avoid checking for snippets of LLVM IR: this form of checking is very hard to
maintain. Instead, we now check for output of the pass that are more meaningful
than dozens of lines of LLVM IR. Some tests now require -debug messages and thus
only enabled with asserts.
Patch written by Sebastian Pop and Aditya Kumar.
Differential Revision: https://reviews.llvm.org/D35430
llvm-svn: 326837
2018-03-07 05:55:59 +08:00
|
|
|
; REQUIRES: asserts
|
2018-04-05 17:48:45 +08:00
|
|
|
; RUN: opt < %s -basicaa -loop-interchange -verify-dom-info -verify-loop-info \
|
|
|
|
|
; RUN: -S -debug 2>&1 | FileCheck %s
|
2017-07-18 17:47:06 +08:00
|
|
|
|
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
|
target triple = "x86_64-unknown-linux-gnu"
|
|
|
|
|
|
|
|
|
|
@D = common global [100 x [100 x [100 x i32]]] zeroinitializer
|
|
|
|
|
|
|
|
|
|
;; Test for interchange in loop nest greater than 2.
|
|
|
|
|
;; for(int i=0;i<100;i++)
|
|
|
|
|
;; for(int j=0;j<100;j++)
|
|
|
|
|
;; for(int k=0;k<100;k++)
|
|
|
|
|
;; D[i][k][j] = D[i][k][j]+t;
|
|
|
|
|
|
DA: remove uses of GEP, only ask SCEV
It's been quite some time the Dependence Analysis (DA) is broken,
as it uses the GEP representation to "identify" multi-dimensional arrays.
It even wrongly detects multi-dimensional arrays in single nested loops:
from test/Analysis/DependenceAnalysis/Coupled.ll, example @couple6
;; for (long int i = 0; i < 50; i++) {
;; A[i][3*i - 6] = i;
;; *B++ = A[i][i];
DA used to detect two subscripts, which makes no sense in the LLVM IR
or in C/C++ semantics, as there are no guarantees as in Fortran of
subscripts not overlapping into a next array dimension:
maximum nesting levels = 1
SrcPtrSCEV = %A
DstPtrSCEV = %A
using GEPs
subscript 0
src = {0,+,1}<nuw><nsw><%for.body>
dst = {0,+,1}<nuw><nsw><%for.body>
class = 1
loops = {1}
subscript 1
src = {-6,+,3}<nsw><%for.body>
dst = {0,+,1}<nuw><nsw><%for.body>
class = 1
loops = {1}
Separable = {}
Coupled = {1}
With the current patch, DA will correctly work on only one dimension:
maximum nesting levels = 1
SrcSCEV = {(-2424 + %A)<nsw>,+,1212}<%for.body>
DstSCEV = {%A,+,404}<%for.body>
subscript 0
src = {(-2424 + %A)<nsw>,+,1212}<%for.body>
dst = {%A,+,404}<%for.body>
class = 1
loops = {1}
Separable = {0}
Coupled = {}
This change removes all uses of GEP from DA, and we now only rely
on the SCEV representation.
The patch does not turn on -da-delinearize by default, and so the DA analysis
will be more conservative in the case of multi-dimensional memory accesses in
nested loops.
I disabled some interchange tests, as the DA is not able to disambiguate
the dependence anymore. To make DA stronger, we may need to
compute a bound on the number of iterations based on the access functions
and array dimensions.
The patch cleans up all the CHECKs in test/Transforms/LoopInterchange/*.ll to
avoid checking for snippets of LLVM IR: this form of checking is very hard to
maintain. Instead, we now check for output of the pass that are more meaningful
than dozens of lines of LLVM IR. Some tests now require -debug messages and thus
only enabled with asserts.
Patch written by Sebastian Pop and Aditya Kumar.
Differential Revision: https://reviews.llvm.org/D35430
llvm-svn: 326837
2018-03-07 05:55:59 +08:00
|
|
|
; CHECK: Processing Inner Loop Id = 2 and OuterLoopId = 1
|
|
|
|
|
; CHECK: Loops interchanged.
|
|
|
|
|
|
|
|
|
|
; CHECK: Processing Inner Loop Id = 1 and OuterLoopId = 0
|
|
|
|
|
; CHECK: Interchanging loops not profitable.
|
|
|
|
|
|
2017-07-18 17:47:06 +08:00
|
|
|
define void @interchange_08(i32 %t){
|
|
|
|
|
entry:
|
|
|
|
|
br label %for.cond1.preheader
|
|
|
|
|
|
|
|
|
|
for.cond1.preheader: ; preds = %for.inc15, %entry
|
|
|
|
|
%i.028 = phi i32 [ 0, %entry ], [ %inc16, %for.inc15 ]
|
|
|
|
|
br label %for.cond4.preheader
|
|
|
|
|
|
|
|
|
|
for.cond4.preheader: ; preds = %for.inc12, %for.cond1.preheader
|
|
|
|
|
%j.027 = phi i32 [ 0, %for.cond1.preheader ], [ %inc13, %for.inc12 ]
|
|
|
|
|
br label %for.body6
|
|
|
|
|
|
|
|
|
|
for.body6: ; preds = %for.body6, %for.cond4.preheader
|
|
|
|
|
%k.026 = phi i32 [ 0, %for.cond4.preheader ], [ %inc, %for.body6 ]
|
|
|
|
|
%arrayidx8 = getelementptr inbounds [100 x [100 x [100 x i32]]], [100 x [100 x [100 x i32]]]* @D, i32 0, i32 %i.028, i32 %k.026, i32 %j.027
|
|
|
|
|
%0 = load i32, i32* %arrayidx8
|
|
|
|
|
%add = add nsw i32 %0, %t
|
|
|
|
|
store i32 %add, i32* %arrayidx8
|
|
|
|
|
%inc = add nuw nsw i32 %k.026, 1
|
|
|
|
|
%exitcond = icmp eq i32 %inc, 100
|
|
|
|
|
br i1 %exitcond, label %for.inc12, label %for.body6
|
|
|
|
|
|
|
|
|
|
for.inc12: ; preds = %for.body6
|
|
|
|
|
%inc13 = add nuw nsw i32 %j.027, 1
|
|
|
|
|
%exitcond29 = icmp eq i32 %inc13, 100
|
|
|
|
|
br i1 %exitcond29, label %for.inc15, label %for.cond4.preheader
|
|
|
|
|
|
|
|
|
|
for.inc15: ; preds = %for.inc12
|
|
|
|
|
%inc16 = add nuw nsw i32 %i.028, 1
|
|
|
|
|
%exitcond30 = icmp eq i32 %inc16, 100
|
|
|
|
|
br i1 %exitcond30, label %for.end17, label %for.cond1.preheader
|
|
|
|
|
|
|
|
|
|
for.end17: ; preds = %for.inc15
|
|
|
|
|
ret void
|
|
|
|
|
}
|