llvm-project/lldb/unittests/Utility/SubsystemRAIITest.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

100 lines
3.0 KiB
C++
Raw Normal View History

//===-- SubsystemRAIITest.cpp ---------------------------------------------===//
[lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests Summary: Many of our tests need to initialize certain subsystems/plugins of LLDB such as `FileSystem` or `HostInfo` by calling their static `Initialize` functions before the test starts and then calling `::Terminate` after the test is done (in reverse order). This adds a lot of error-prone boilerplate code to our testing code. This patch adds a RAII called SubsystemRAII that ensures that we always call ::Initialize and then call ::Terminate after the test is done (and that the Terminate calls are always in the reverse order of the ::Initialize calls). It also gets rid of all of the boilerplate that we had for these calls. Per-fixture initialization is still not very nice with this approach as it would require some kind of static unique_ptr that gets manually assigned/reseted from the gtest SetUpTestCase/TearDownTestCase functions. Because of that I changed all per-fixture setup to now do per-test setup which can be done by just having the SubsystemRAII as a member of the test fixture. This change doesn't influence our normal test runtime as LIT anyway runs each test case separately (and the Initialize/Terminate calls are anyway not very expensive). It will however make running all tests in a single executable slightly slower. Reviewers: labath, JDevlieghere, martong, espindola, shafik Reviewed By: labath Subscribers: mgorny, rnkovacs, emaste, MaskRay, abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D71630
2019-12-23 17:38:12 +08:00
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "gtest/gtest-spi.h"
#include "gtest/gtest.h"
#include "TestingSupport/SubsystemRAII.h"
using namespace lldb_private;
namespace {
enum class SystemState {
/// Start state of the subsystem.
Start,
/// Initialize has been called but Terminate hasn't been called yet.
Initialized,
/// Terminate has been called.
Terminated
};
struct TestSubsystem {
static SystemState state;
static void Initialize() {
assert(state == SystemState::Start);
state = SystemState::Initialized;
}
static void Terminate() {
assert(state == SystemState::Initialized);
state = SystemState::Terminated;
}
};
} // namespace
SystemState TestSubsystem::state = SystemState::Start;
TEST(SubsystemRAIITest, NormalSubsystem) {
// Tests that SubsystemRAII handles Initialize functions that return void.
EXPECT_EQ(SystemState::Start, TestSubsystem::state);
{
SubsystemRAII<TestSubsystem> subsystem;
EXPECT_EQ(SystemState::Initialized, TestSubsystem::state);
}
EXPECT_EQ(SystemState::Terminated, TestSubsystem::state);
}
static const char *SubsystemErrorString = "Initialize failed";
namespace {
struct TestSubsystemWithError {
static SystemState state;
static bool will_fail;
static llvm::Error Initialize() {
assert(state == SystemState::Start);
state = SystemState::Initialized;
if (will_fail)
return llvm::make_error<llvm::StringError>(
SubsystemErrorString, llvm::inconvertibleErrorCode());
return llvm::Error::success();
}
static void Terminate() {
assert(state == SystemState::Initialized);
state = SystemState::Terminated;
}
/// Reset the subsystem to the default state for testing.
static void Reset() { state = SystemState::Start; }
};
} // namespace
SystemState TestSubsystemWithError::state = SystemState::Start;
bool TestSubsystemWithError::will_fail = false;
TEST(SubsystemRAIITest, SubsystemWithErrorSuccess) {
// Tests that SubsystemRAII handles llvm::success() returned from
// Initialize.
TestSubsystemWithError::Reset();
EXPECT_EQ(SystemState::Start, TestSubsystemWithError::state);
{
TestSubsystemWithError::will_fail = false;
SubsystemRAII<TestSubsystemWithError> subsystem;
EXPECT_EQ(SystemState::Initialized, TestSubsystemWithError::state);
}
EXPECT_EQ(SystemState::Terminated, TestSubsystemWithError::state);
}
TEST(SubsystemRAIITest, SubsystemWithErrorFailure) {
// Tests that SubsystemRAII handles any errors returned from
// Initialize.
TestSubsystemWithError::Reset();
EXPECT_EQ(SystemState::Start, TestSubsystemWithError::state);
TestSubsystemWithError::will_fail = true;
EXPECT_FATAL_FAILURE(SubsystemRAII<TestSubsystemWithError> subsystem,
SubsystemErrorString);
}