[analyzer][NFC] Reimplement checker options
TL;DR:
* Add checker and package options to the TableGen files
* Added a new class called CmdLineOption, and both Package and Checker recieved
a list<CmdLineOption> field.
* Added every existing checker and package option to Checkers.td.
* The CheckerRegistry class
* Received some comments to most of it's inline classes
* Received the CmdLineOption and PackageInfo inline classes, a list of
CmdLineOption was added to CheckerInfo and PackageInfo
* Added addCheckerOption and addPackageOption
* Added a new field called Packages, used in addPackageOptions, filled up in
addPackage
Detailed description:
In the last couple months, a lot of effort was put into tightening the
analyzer's command line interface. The main issue is that it's spectacularly
easy to mess up a lenghty enough invocation of the analyzer, and the user was
given no warnings or errors at all in that case.
We can divide the effort of resolving this into several chapters:
* Non-checker analyzer configurations:
Gather every analyzer configuration into a dedicated file. Emit errors for
non-existent configurations or incorrect values. Be able to list these
configurations. Tighten AnalyzerOptions interface to disallow making such
a mistake in the future.
* Fix the "Checker Naming Bug" by reimplementing checker dependencies:
When cplusplus.InnerPointer was enabled, it implicitly registered
unix.Malloc, which implicitly registered some sort of a modeling checker
from the CStringChecker family. This resulted in all of these checker
objects recieving the name "cplusplus.InnerPointer", making AnalyzerOptions
asking for the wrong checker options from the command line:
cplusplus.InnerPointer:Optimisic
istead of
unix.Malloc:Optimistic.
This was resolved by making CheckerRegistry responsible for checker
dependency handling, instead of checkers themselves.
* Checker options: (this patch included!)
Same as the first item, but for checkers.
(+ minor fixes here and there, and everything else that is yet to come)
There were several issues regarding checker options, that non-checker
configurations didn't suffer from: checker plugins are loaded runtime, and they
could add new checkers and new options, meaning that unlike for non-checker
configurations, we can't collect every checker option purely by generating code.
Also, as seen from the "Checker Naming Bug" issue raised above, they are very
rarely used in practice, and all sorts of skeletons fell out of the closet while
working on this project.
They were extremely problematic for users as well, purely because of how long
they were. Consider the following monster of a checker option:
alpha.cplusplus.UninitializedObject:CheckPointeeInitialization=false
While we were able to verify whether the checker itself (the part before the
colon) existed, any errors past that point were unreported, easily resulting
in 7+ hours of analyses going to waste.
This patch, similarly to how dependencies were reimplemented, uses TableGen to
register checker options into Checkers.td, so that Checkers.inc now contains
entries for both checker and package options. Using the preprocessor,
Checkers.inc is converted into code in CheckerRegistry, adding every builtin
(checkers and packages that have an entry in the Checkers.td file) checker and
package option to the registry. The new addPackageOption and addCheckerOption
functions expose the same functionality to statically-linked non-builtin and
plugin checkers and packages as well.
Emitting errors for incorrect user input, being able to list these options, and
some other functionalies will land in later patches.
Differential Revision: https://reviews.llvm.org/D57855
llvm-svn: 358752
2019-04-19 20:32:10 +08:00
|
|
|
// RUN: not %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config RetainOneTwoThree:CheckOSObject=false \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-NON-EXISTENT-CHECKER
|
|
|
|
|
|
|
|
|
|
// Note that non-existent packages and checkers were always reported.
|
|
|
|
|
|
|
|
|
|
// RUN: not %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config-compatibility-mode=true \
|
|
|
|
|
// RUN: -analyzer-config RetainOneTwoThree:CheckOSObject=false \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-NON-EXISTENT-CHECKER
|
|
|
|
|
|
|
|
|
|
// CHECK-NON-EXISTENT-CHECKER: (frontend): no analyzer checkers or packages
|
|
|
|
|
// CHECK-NON-EXISTENT-CHECKER-SAME: are associated with 'RetainOneTwoThree'
|
|
|
|
|
|
2019-05-17 17:51:59 +08:00
|
|
|
|
[analyzer] Remove the default value arg from getChecker*Option
Since D57922, the config table contains every checker option, and it's default
value, so having it as an argument for getChecker*Option is redundant.
By the time any of the getChecker*Option function is called, we verified the
value in CheckerRegistry (after D57860), so we can confidently assert here, as
any irregularities detected at this point must be a programmer error. However,
in compatibility mode, verification won't happen, so the default value must be
restored.
This implies something else, other than adding removing one more potential point
of failure -- debug.ConfigDumper will always contain valid values for
checker/package options!
Differential Revision: https://reviews.llvm.org/D59195
llvm-svn: 361042
2019-05-17 23:52:13 +08:00
|
|
|
// RUN: %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-checker=debug.ConfigDumper \
|
|
|
|
|
// RUN: -analyzer-checker=debug.AnalysisOrder \
|
|
|
|
|
// RUN: -analyzer-config-compatibility-mode=true \
|
|
|
|
|
// RUN: -analyzer-config debug.AnalysisOrder:*=yesplease \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-CORRECTED-BOOL-VALUE
|
|
|
|
|
|
|
|
|
|
// CHECK-CORRECTED-BOOL-VALUE: debug.AnalysisOrder:* = false
|
|
|
|
|
//
|
|
|
|
|
// RUN: %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-checker=debug.ConfigDumper \
|
|
|
|
|
// RUN: -analyzer-checker=optin.performance.Padding \
|
|
|
|
|
// RUN: -analyzer-config-compatibility-mode=true \
|
|
|
|
|
// RUN: -analyzer-config optin.performance.Padding:AllowedPad=surpriseme \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-CORRECTED-INT-VALUE
|
|
|
|
|
|
|
|
|
|
// CHECK-CORRECTED-INT-VALUE: optin.performance.Padding:AllowedPad = 24
|
|
|
|
|
|
|
|
|
|
|
2019-05-17 17:51:59 +08:00
|
|
|
// Every other error should be avoidable in compatiblity mode.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// RUN: not %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config debug.AnalysisOrder:Everything=false \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-NON-EXISTENT-CHECKER-OPTION
|
|
|
|
|
|
|
|
|
|
// CHECK-NON-EXISTENT-CHECKER-OPTION: (frontend): checker 'debug.AnalysisOrder'
|
|
|
|
|
// CHECK-NON-EXISTENT-CHECKER-OPTION-SAME: has no option called 'Everything'
|
|
|
|
|
|
|
|
|
|
// RUN: %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config-compatibility-mode=true \
|
|
|
|
|
// RUN: -analyzer-config debug.AnalysisOrder:Everything=false
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// RUN: not %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config debug.AnalysisOrder:*=nothankyou \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID-BOOL-VALUE
|
|
|
|
|
|
|
|
|
|
// CHECK-INVALID-BOOL-VALUE: (frontend): invalid input for checker option
|
|
|
|
|
// CHECK-INVALID-BOOL-VALUE-SAME: 'debug.AnalysisOrder:*', that expects a
|
|
|
|
|
// CHECK-INVALID-BOOL-VALUE-SAME: boolean value
|
|
|
|
|
|
|
|
|
|
// RUN: %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config-compatibility-mode=true \
|
|
|
|
|
// RUN: -analyzer-config debug.AnalysisOrder:*=nothankyou
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// RUN: not %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config optin.performance.Padding:AllowedPad=surpriseme \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID-INT-VALUE
|
|
|
|
|
|
|
|
|
|
// CHECK-INVALID-INT-VALUE: (frontend): invalid input for checker option
|
|
|
|
|
// CHECK-INVALID-INT-VALUE-SAME: 'optin.performance.Padding:AllowedPad', that
|
|
|
|
|
// CHECK-INVALID-INT-VALUE-SAME: expects an integer value
|
|
|
|
|
|
|
|
|
|
// RUN: %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config-compatibility-mode=true \
|
|
|
|
|
// RUN: -analyzer-config optin.performance.Padding:AllowedPad=surpriseme
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// RUN: not %clang_analyze_cc1 -verify %s \
|
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
|
// RUN: -analyzer-config nullability:NoDiagnoseCallsToSystemHeaders=sure \
|
|
|
|
|
// RUN: 2>&1 | FileCheck %s -check-prefix=CHECK-PACKAGE-VALUE
|
|
|
|
|
|
|
|
|
|
// CHECK-PACKAGE-VALUE: (frontend): invalid input for checker option
|
|
|
|
|
// CHECK-PACKAGE-VALUE-SAME: 'nullability:NoDiagnoseCallsToSystemHeaders', that
|
|
|
|
|
// CHECK-PACKAGE-VALUE-SAME: expects a boolean value
|
|
|
|
|
|
[analyzer][NFC] Reimplement checker options
TL;DR:
* Add checker and package options to the TableGen files
* Added a new class called CmdLineOption, and both Package and Checker recieved
a list<CmdLineOption> field.
* Added every existing checker and package option to Checkers.td.
* The CheckerRegistry class
* Received some comments to most of it's inline classes
* Received the CmdLineOption and PackageInfo inline classes, a list of
CmdLineOption was added to CheckerInfo and PackageInfo
* Added addCheckerOption and addPackageOption
* Added a new field called Packages, used in addPackageOptions, filled up in
addPackage
Detailed description:
In the last couple months, a lot of effort was put into tightening the
analyzer's command line interface. The main issue is that it's spectacularly
easy to mess up a lenghty enough invocation of the analyzer, and the user was
given no warnings or errors at all in that case.
We can divide the effort of resolving this into several chapters:
* Non-checker analyzer configurations:
Gather every analyzer configuration into a dedicated file. Emit errors for
non-existent configurations or incorrect values. Be able to list these
configurations. Tighten AnalyzerOptions interface to disallow making such
a mistake in the future.
* Fix the "Checker Naming Bug" by reimplementing checker dependencies:
When cplusplus.InnerPointer was enabled, it implicitly registered
unix.Malloc, which implicitly registered some sort of a modeling checker
from the CStringChecker family. This resulted in all of these checker
objects recieving the name "cplusplus.InnerPointer", making AnalyzerOptions
asking for the wrong checker options from the command line:
cplusplus.InnerPointer:Optimisic
istead of
unix.Malloc:Optimistic.
This was resolved by making CheckerRegistry responsible for checker
dependency handling, instead of checkers themselves.
* Checker options: (this patch included!)
Same as the first item, but for checkers.
(+ minor fixes here and there, and everything else that is yet to come)
There were several issues regarding checker options, that non-checker
configurations didn't suffer from: checker plugins are loaded runtime, and they
could add new checkers and new options, meaning that unlike for non-checker
configurations, we can't collect every checker option purely by generating code.
Also, as seen from the "Checker Naming Bug" issue raised above, they are very
rarely used in practice, and all sorts of skeletons fell out of the closet while
working on this project.
They were extremely problematic for users as well, purely because of how long
they were. Consider the following monster of a checker option:
alpha.cplusplus.UninitializedObject:CheckPointeeInitialization=false
While we were able to verify whether the checker itself (the part before the
colon) existed, any errors past that point were unreported, easily resulting
in 7+ hours of analyses going to waste.
This patch, similarly to how dependencies were reimplemented, uses TableGen to
register checker options into Checkers.td, so that Checkers.inc now contains
entries for both checker and package options. Using the preprocessor,
Checkers.inc is converted into code in CheckerRegistry, adding every builtin
(checkers and packages that have an entry in the Checkers.td file) checker and
package option to the registry. The new addPackageOption and addCheckerOption
functions expose the same functionality to statically-linked non-builtin and
plugin checkers and packages as well.
Emitting errors for incorrect user input, being able to list these options, and
some other functionalies will land in later patches.
Differential Revision: https://reviews.llvm.org/D57855
llvm-svn: 358752
2019-04-19 20:32:10 +08:00
|
|
|
// expected-no-diagnostics
|
|
|
|
|
|
|
|
|
|
int main() {}
|