2007-08-11 04:18:51 +08:00
|
|
|
//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 03:59:25 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2007-08-11 04:18:51 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements extra semantic analysis beyond what is enforced
|
|
|
|
// by the C type system.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "Sema.h"
|
|
|
|
#include "clang/AST/ASTContext.h"
|
2008-08-11 13:35:13 +08:00
|
|
|
#include "clang/AST/DeclObjC.h"
|
2007-08-21 00:18:38 +08:00
|
|
|
#include "clang/AST/ExprCXX.h"
|
2008-06-17 02:00:42 +08:00
|
|
|
#include "clang/AST/ExprObjC.h"
|
2009-02-19 03:21:10 +08:00
|
|
|
#include "clang/Lex/LiteralSupport.h"
|
2007-08-11 04:18:51 +08:00
|
|
|
#include "clang/Lex/Preprocessor.h"
|
|
|
|
using namespace clang;
|
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
/// getLocationOfStringLiteralByte - Return a source location that points to the
|
|
|
|
/// specified byte of the specified string literal.
|
|
|
|
///
|
|
|
|
/// Strings are amazingly complex. They can be formed from multiple tokens and
|
|
|
|
/// can have escape sequences in them in addition to the usual trigraph and
|
|
|
|
/// escaped newline business. This routine handles this complexity.
|
|
|
|
///
|
|
|
|
SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
|
|
|
|
unsigned ByteNo) const {
|
|
|
|
assert(!SL->isWide() && "This doesn't work for wide strings yet");
|
|
|
|
|
|
|
|
// Loop over all of the tokens in this string until we find the one that
|
|
|
|
// contains the byte we're looking for.
|
|
|
|
unsigned TokNo = 0;
|
|
|
|
while (1) {
|
|
|
|
assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
|
|
|
|
SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
|
|
|
|
|
|
|
|
// Get the spelling of the string so that we can get the data that makes up
|
|
|
|
// the string literal, not the identifier for the macro it is potentially
|
|
|
|
// expanded through.
|
|
|
|
SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
|
|
|
|
|
|
|
|
// Re-lex the token to get its length and original spelling.
|
|
|
|
std::pair<FileID, unsigned> LocInfo =
|
|
|
|
SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
|
|
|
|
std::pair<const char *,const char *> Buffer =
|
|
|
|
SourceMgr.getBufferData(LocInfo.first);
|
|
|
|
const char *StrData = Buffer.first+LocInfo.second;
|
|
|
|
|
|
|
|
// Create a langops struct and enable trigraphs. This is sufficient for
|
|
|
|
// relexing tokens.
|
|
|
|
LangOptions LangOpts;
|
|
|
|
LangOpts.Trigraphs = true;
|
|
|
|
|
|
|
|
// Create a lexer starting at the beginning of this token.
|
|
|
|
Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.first, StrData,
|
|
|
|
Buffer.second);
|
|
|
|
Token TheTok;
|
|
|
|
TheLexer.LexFromRawLexer(TheTok);
|
|
|
|
|
2009-02-19 03:26:42 +08:00
|
|
|
// Use the StringLiteralParser to compute the length of the string in bytes.
|
|
|
|
StringLiteralParser SLP(&TheTok, 1, PP);
|
|
|
|
unsigned TokNumBytes = SLP.GetStringLength();
|
2009-02-19 02:34:12 +08:00
|
|
|
|
2009-02-19 02:52:52 +08:00
|
|
|
// If the byte is in this token, return the location of the byte.
|
2009-02-19 01:49:48 +08:00
|
|
|
if (ByteNo < TokNumBytes ||
|
|
|
|
(ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
|
2009-02-19 03:21:10 +08:00
|
|
|
unsigned Offset =
|
|
|
|
StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP);
|
|
|
|
|
|
|
|
// Now that we know the offset of the token in the spelling, use the
|
|
|
|
// preprocessor to get the offset in the original source.
|
|
|
|
return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
|
2009-02-19 01:49:48 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Move to the next string token.
|
|
|
|
++TokNo;
|
|
|
|
ByteNo -= TokNumBytes;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2007-08-11 04:18:51 +08:00
|
|
|
/// CheckFunctionCall - Check a direct function call for various correctness
|
|
|
|
/// and safety properties not strictly enforced by the C type system.
|
2009-01-19 08:08:26 +08:00
|
|
|
Action::OwningExprResult
|
|
|
|
Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
|
|
|
|
OwningExprResult TheCallResult(Owned(TheCall));
|
2007-08-11 04:18:51 +08:00
|
|
|
// Get the IdentifierInfo* for the called function.
|
|
|
|
IdentifierInfo *FnInfo = FDecl->getIdentifier();
|
2008-11-18 04:34:05 +08:00
|
|
|
|
|
|
|
// None of the checks below are needed for functions that don't have
|
|
|
|
// simple names (e.g., C++ conversion functions).
|
|
|
|
if (!FnInfo)
|
2009-01-19 08:08:26 +08:00
|
|
|
return move(TheCallResult);
|
2008-11-18 04:34:05 +08:00
|
|
|
|
2009-02-15 02:57:46 +08:00
|
|
|
switch (FDecl->getBuiltinID(Context)) {
|
2007-12-20 07:59:04 +08:00
|
|
|
case Builtin::BI__builtin___CFStringMakeConstantString:
|
2007-12-28 13:29:59 +08:00
|
|
|
assert(TheCall->getNumArgs() == 1 &&
|
2007-12-20 08:26:33 +08:00
|
|
|
"Wrong # arguments to builtin CFStringMakeConstantString");
|
2009-02-18 14:01:06 +08:00
|
|
|
if (CheckObjCString(TheCall->getArg(0)))
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError();
|
|
|
|
return move(TheCallResult);
|
2008-07-10 01:58:53 +08:00
|
|
|
case Builtin::BI__builtin_stdarg_start:
|
2007-12-20 07:59:04 +08:00
|
|
|
case Builtin::BI__builtin_va_start:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinVAStart(TheCall))
|
|
|
|
return ExprError();
|
|
|
|
return move(TheCallResult);
|
2007-12-20 08:26:33 +08:00
|
|
|
case Builtin::BI__builtin_isgreater:
|
|
|
|
case Builtin::BI__builtin_isgreaterequal:
|
|
|
|
case Builtin::BI__builtin_isless:
|
|
|
|
case Builtin::BI__builtin_islessequal:
|
|
|
|
case Builtin::BI__builtin_islessgreater:
|
|
|
|
case Builtin::BI__builtin_isunordered:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinUnorderedCompare(TheCall))
|
|
|
|
return ExprError();
|
|
|
|
return move(TheCallResult);
|
2008-05-20 16:23:37 +08:00
|
|
|
case Builtin::BI__builtin_return_address:
|
|
|
|
case Builtin::BI__builtin_frame_address:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinStackAddress(TheCall))
|
|
|
|
return ExprError();
|
|
|
|
return move(TheCallResult);
|
2008-05-15 03:38:39 +08:00
|
|
|
case Builtin::BI__builtin_shufflevector:
|
2009-01-19 08:08:26 +08:00
|
|
|
return SemaBuiltinShuffleVector(TheCall);
|
|
|
|
// TheCall will be freed by the smart pointer here, but that's fine, since
|
|
|
|
// SemaBuiltinShuffleVector guts it, but then doesn't release it.
|
2008-07-22 06:59:13 +08:00
|
|
|
case Builtin::BI__builtin_prefetch:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinPrefetch(TheCall))
|
|
|
|
return ExprError();
|
|
|
|
return move(TheCallResult);
|
2008-09-04 05:13:56 +08:00
|
|
|
case Builtin::BI__builtin_object_size:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinObjectSize(TheCall))
|
|
|
|
return ExprError();
|
2009-05-03 14:04:26 +08:00
|
|
|
return move(TheCallResult);
|
2009-05-03 12:46:36 +08:00
|
|
|
case Builtin::BI__builtin_longjmp:
|
|
|
|
if (SemaBuiltinLongjmp(TheCall))
|
|
|
|
return ExprError();
|
2009-05-03 14:04:26 +08:00
|
|
|
return move(TheCallResult);
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_fetch_and_add:
|
|
|
|
case Builtin::BI__sync_fetch_and_sub:
|
|
|
|
case Builtin::BI__sync_fetch_and_or:
|
|
|
|
case Builtin::BI__sync_fetch_and_and:
|
|
|
|
case Builtin::BI__sync_fetch_and_xor:
|
2009-05-13 12:37:52 +08:00
|
|
|
case Builtin::BI__sync_fetch_and_nand:
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_add_and_fetch:
|
|
|
|
case Builtin::BI__sync_sub_and_fetch:
|
|
|
|
case Builtin::BI__sync_and_and_fetch:
|
|
|
|
case Builtin::BI__sync_or_and_fetch:
|
|
|
|
case Builtin::BI__sync_xor_and_fetch:
|
2009-05-13 12:37:52 +08:00
|
|
|
case Builtin::BI__sync_nand_and_fetch:
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_val_compare_and_swap:
|
|
|
|
case Builtin::BI__sync_bool_compare_and_swap:
|
|
|
|
case Builtin::BI__sync_lock_test_and_set:
|
|
|
|
case Builtin::BI__sync_lock_release:
|
|
|
|
if (SemaBuiltinAtomicOverloaded(TheCall))
|
|
|
|
return ExprError();
|
|
|
|
return move(TheCallResult);
|
2007-08-17 13:31:46 +08:00
|
|
|
}
|
2008-10-03 02:44:07 +08:00
|
|
|
|
|
|
|
// FIXME: This mechanism should be abstracted to be less fragile and
|
|
|
|
// more efficient. For example, just map function ids to custom
|
|
|
|
// handlers.
|
|
|
|
|
2007-08-11 04:18:51 +08:00
|
|
|
// Printf checking.
|
2009-02-15 02:57:46 +08:00
|
|
|
if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
|
|
|
|
if (Format->getType() == "printf") {
|
2009-02-28 01:58:43 +08:00
|
|
|
bool HasVAListArg = Format->getFirstArg() == 0;
|
|
|
|
if (!HasVAListArg) {
|
|
|
|
if (const FunctionProtoType *Proto
|
|
|
|
= FDecl->getType()->getAsFunctionProtoType())
|
2009-02-15 02:57:46 +08:00
|
|
|
HasVAListArg = !Proto->isVariadic();
|
2009-02-28 01:58:43 +08:00
|
|
|
}
|
2009-02-15 02:57:46 +08:00
|
|
|
CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
|
2009-02-28 01:58:43 +08:00
|
|
|
HasVAListArg ? 0 : Format->getFirstArg() - 1);
|
2009-02-15 02:57:46 +08:00
|
|
|
}
|
2007-08-11 04:18:51 +08:00
|
|
|
}
|
2009-01-19 08:08:26 +08:00
|
|
|
|
|
|
|
return move(TheCallResult);
|
2007-08-17 13:31:46 +08:00
|
|
|
}
|
|
|
|
|
2009-05-19 05:05:18 +08:00
|
|
|
Action::OwningExprResult
|
|
|
|
Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
|
|
|
|
|
|
|
|
OwningExprResult TheCallResult(Owned(TheCall));
|
|
|
|
// Printf checking.
|
|
|
|
const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
|
|
|
|
if (!Format)
|
|
|
|
return move(TheCallResult);
|
|
|
|
const VarDecl *V = dyn_cast<VarDecl>(NDecl);
|
|
|
|
if (!V)
|
|
|
|
return move(TheCallResult);
|
|
|
|
QualType Ty = V->getType();
|
|
|
|
if (!Ty->isBlockPointerType())
|
|
|
|
return move(TheCallResult);
|
|
|
|
if (Format->getType() == "printf") {
|
|
|
|
bool HasVAListArg = Format->getFirstArg() == 0;
|
|
|
|
if (!HasVAListArg) {
|
|
|
|
const FunctionType *FT =
|
|
|
|
Ty->getAsBlockPointerType()->getPointeeType()->getAsFunctionType();
|
|
|
|
if (const FunctionProtoType *Proto = dyn_cast<FunctionProtoType>(FT))
|
|
|
|
HasVAListArg = !Proto->isVariadic();
|
|
|
|
}
|
|
|
|
CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
|
|
|
|
HasVAListArg ? 0 : Format->getFirstArg() - 1);
|
|
|
|
}
|
|
|
|
return move(TheCallResult);
|
|
|
|
}
|
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
/// SemaBuiltinAtomicOverloaded - We have a call to a function like
|
|
|
|
/// __sync_fetch_and_add, which is an overloaded function based on the pointer
|
|
|
|
/// type of its first argument. The main ActOnCallExpr routines have already
|
|
|
|
/// promoted the types of arguments because all of these calls are prototyped as
|
|
|
|
/// void(...).
|
|
|
|
///
|
|
|
|
/// This function goes through and does final semantic checking for these
|
|
|
|
/// builtins,
|
|
|
|
bool Sema::SemaBuiltinAtomicOverloaded(CallExpr *TheCall) {
|
|
|
|
DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
|
|
|
|
FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
|
|
|
|
|
|
|
|
// Ensure that we have at least one argument to do type inference from.
|
|
|
|
if (TheCall->getNumArgs() < 1)
|
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
|
|
|
|
<< 0 << TheCall->getCallee()->getSourceRange();
|
|
|
|
|
|
|
|
// Inspect the first argument of the atomic builtin. This should always be
|
|
|
|
// a pointer type, whose element is an integral scalar or pointer type.
|
|
|
|
// Because it is a pointer type, we don't have to worry about any implicit
|
|
|
|
// casts here.
|
|
|
|
Expr *FirstArg = TheCall->getArg(0);
|
|
|
|
if (!FirstArg->getType()->isPointerType())
|
|
|
|
return Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
|
|
|
|
<< FirstArg->getType() << FirstArg->getSourceRange();
|
|
|
|
|
|
|
|
QualType ValType = FirstArg->getType()->getAsPointerType()->getPointeeType();
|
|
|
|
if (!ValType->isIntegerType() && !ValType->isPointerType() &&
|
|
|
|
!ValType->isBlockPointerType())
|
|
|
|
return Diag(DRE->getLocStart(),
|
|
|
|
diag::err_atomic_builtin_must_be_pointer_intptr)
|
|
|
|
<< FirstArg->getType() << FirstArg->getSourceRange();
|
|
|
|
|
|
|
|
// We need to figure out which concrete builtin this maps onto. For example,
|
|
|
|
// __sync_fetch_and_add with a 2 byte object turns into
|
|
|
|
// __sync_fetch_and_add_2.
|
|
|
|
#define BUILTIN_ROW(x) \
|
|
|
|
{ Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
|
|
|
|
Builtin::BI##x##_8, Builtin::BI##x##_16 }
|
|
|
|
|
|
|
|
static const unsigned BuiltinIndices[][5] = {
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_add),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_sub),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_or),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_and),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_xor),
|
2009-05-13 12:37:52 +08:00
|
|
|
BUILTIN_ROW(__sync_fetch_and_nand),
|
2009-05-08 14:58:22 +08:00
|
|
|
|
|
|
|
BUILTIN_ROW(__sync_add_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_sub_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_and_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_or_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_xor_and_fetch),
|
2009-05-13 12:37:52 +08:00
|
|
|
BUILTIN_ROW(__sync_nand_and_fetch),
|
2009-05-08 14:58:22 +08:00
|
|
|
|
|
|
|
BUILTIN_ROW(__sync_val_compare_and_swap),
|
|
|
|
BUILTIN_ROW(__sync_bool_compare_and_swap),
|
|
|
|
BUILTIN_ROW(__sync_lock_test_and_set),
|
|
|
|
BUILTIN_ROW(__sync_lock_release)
|
|
|
|
};
|
|
|
|
#undef BUILTIN_ROW
|
|
|
|
|
|
|
|
// Determine the index of the size.
|
|
|
|
unsigned SizeIndex;
|
|
|
|
switch (Context.getTypeSize(ValType)/8) {
|
|
|
|
case 1: SizeIndex = 0; break;
|
|
|
|
case 2: SizeIndex = 1; break;
|
|
|
|
case 4: SizeIndex = 2; break;
|
|
|
|
case 8: SizeIndex = 3; break;
|
|
|
|
case 16: SizeIndex = 4; break;
|
|
|
|
default:
|
|
|
|
return Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
|
|
|
|
<< FirstArg->getType() << FirstArg->getSourceRange();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Each of these builtins has one pointer argument, followed by some number of
|
|
|
|
// values (0, 1 or 2) followed by a potentially empty varags list of stuff
|
|
|
|
// that we ignore. Find out which row of BuiltinIndices to read from as well
|
|
|
|
// as the number of fixed args.
|
|
|
|
unsigned BuiltinID = FDecl->getBuiltinID(Context);
|
|
|
|
unsigned BuiltinIndex, NumFixed = 1;
|
|
|
|
switch (BuiltinID) {
|
|
|
|
default: assert(0 && "Unknown overloaded atomic builtin!");
|
|
|
|
case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
|
2009-05-13 12:37:52 +08:00
|
|
|
case Builtin::BI__sync_fetch_and_nand:BuiltinIndex = 5; break;
|
2009-05-08 14:58:22 +08:00
|
|
|
|
2009-05-13 12:37:52 +08:00
|
|
|
case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 6; break;
|
|
|
|
case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 7; break;
|
|
|
|
case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 8; break;
|
|
|
|
case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 9; break;
|
|
|
|
case Builtin::BI__sync_xor_and_fetch: BuiltinIndex =10; break;
|
|
|
|
case Builtin::BI__sync_nand_and_fetch:BuiltinIndex =11; break;
|
2009-05-08 14:58:22 +08:00
|
|
|
|
|
|
|
case Builtin::BI__sync_val_compare_and_swap:
|
2009-05-13 12:37:52 +08:00
|
|
|
BuiltinIndex = 12;
|
2009-05-08 14:58:22 +08:00
|
|
|
NumFixed = 2;
|
|
|
|
break;
|
|
|
|
case Builtin::BI__sync_bool_compare_and_swap:
|
2009-05-13 12:37:52 +08:00
|
|
|
BuiltinIndex = 13;
|
2009-05-08 14:58:22 +08:00
|
|
|
NumFixed = 2;
|
|
|
|
break;
|
2009-05-13 12:37:52 +08:00
|
|
|
case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 14; break;
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_lock_release:
|
2009-05-13 12:37:52 +08:00
|
|
|
BuiltinIndex = 15;
|
2009-05-08 14:58:22 +08:00
|
|
|
NumFixed = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now that we know how many fixed arguments we expect, first check that we
|
|
|
|
// have at least that many.
|
|
|
|
if (TheCall->getNumArgs() < 1+NumFixed)
|
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
|
|
|
|
<< 0 << TheCall->getCallee()->getSourceRange();
|
|
|
|
|
2009-05-08 23:36:58 +08:00
|
|
|
|
|
|
|
// Get the decl for the concrete builtin from this, we can tell what the
|
|
|
|
// concrete integer type we should convert to is.
|
|
|
|
unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
|
|
|
|
const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
|
|
|
|
IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
|
|
|
|
FunctionDecl *NewBuiltinDecl =
|
|
|
|
cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
|
|
|
|
TUScope, false, DRE->getLocStart()));
|
|
|
|
const FunctionProtoType *BuiltinFT =
|
|
|
|
NewBuiltinDecl->getType()->getAsFunctionProtoType();
|
|
|
|
ValType = BuiltinFT->getArgType(0)->getAsPointerType()->getPointeeType();
|
|
|
|
|
|
|
|
// If the first type needs to be converted (e.g. void** -> int*), do it now.
|
|
|
|
if (BuiltinFT->getArgType(0) != FirstArg->getType()) {
|
|
|
|
ImpCastExprToType(FirstArg, BuiltinFT->getArgType(0), false);
|
|
|
|
TheCall->setArg(0, FirstArg);
|
|
|
|
}
|
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Next, walk the valid ones promoting to the right type.
|
|
|
|
for (unsigned i = 0; i != NumFixed; ++i) {
|
|
|
|
Expr *Arg = TheCall->getArg(i+1);
|
|
|
|
|
|
|
|
// If the argument is an implicit cast, then there was a promotion due to
|
|
|
|
// "...", just remove it now.
|
|
|
|
if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
|
|
|
|
Arg = ICE->getSubExpr();
|
|
|
|
ICE->setSubExpr(0);
|
|
|
|
ICE->Destroy(Context);
|
|
|
|
TheCall->setArg(i+1, Arg);
|
|
|
|
}
|
|
|
|
|
|
|
|
// GCC does an implicit conversion to the pointer or integer ValType. This
|
|
|
|
// can fail in some cases (1i -> int**), check for this error case now.
|
|
|
|
if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
// Okay, we have something that *can* be converted to the right type. Check
|
|
|
|
// to see if there is a potentially weird extension going on here. This can
|
|
|
|
// happen when you do an atomic operation on something like an char* and
|
|
|
|
// pass in 42. The 42 gets converted to char. This is even more strange
|
|
|
|
// for things like 45.123 -> char, etc.
|
|
|
|
// FIXME: Do this check.
|
|
|
|
ImpCastExprToType(Arg, ValType, false);
|
|
|
|
TheCall->setArg(i+1, Arg);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Switch the DeclRefExpr to refer to the new decl.
|
|
|
|
DRE->setDecl(NewBuiltinDecl);
|
|
|
|
DRE->setType(NewBuiltinDecl->getType());
|
|
|
|
|
|
|
|
// Set the callee in the CallExpr.
|
|
|
|
// FIXME: This leaks the original parens and implicit casts.
|
|
|
|
Expr *PromotedCall = DRE;
|
|
|
|
UsualUnaryConversions(PromotedCall);
|
|
|
|
TheCall->setCallee(PromotedCall);
|
|
|
|
|
|
|
|
|
|
|
|
// Change the result type of the call to match the result type of the decl.
|
|
|
|
TheCall->setType(NewBuiltinDecl->getResultType());
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-02-18 14:01:06 +08:00
|
|
|
/// CheckObjCString - Checks that the argument to the builtin
|
2007-08-17 13:31:46 +08:00
|
|
|
/// CFString constructor is correct
|
2009-04-14 04:26:29 +08:00
|
|
|
/// FIXME: GCC currently emits the following warning:
|
|
|
|
/// "warning: input conversion stopped due to an input byte that does not
|
|
|
|
/// belong to the input codeset UTF-8"
|
|
|
|
/// Note: It might also make sense to do the UTF-16 conversion here (would
|
|
|
|
/// simplify the backend).
|
2009-02-18 14:01:06 +08:00
|
|
|
bool Sema::CheckObjCString(Expr *Arg) {
|
2008-02-13 09:02:39 +08:00
|
|
|
Arg = Arg->IgnoreParenCasts();
|
2007-08-17 13:31:46 +08:00
|
|
|
StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
|
|
|
|
|
|
|
|
if (!Literal || Literal->isWide()) {
|
2008-11-19 13:08:23 +08:00
|
|
|
Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
|
|
|
|
<< Arg->getSourceRange();
|
2007-08-17 23:44:17 +08:00
|
|
|
return true;
|
2007-08-17 13:31:46 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
const char *Data = Literal->getStrData();
|
|
|
|
unsigned Length = Literal->getByteLength();
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < Length; ++i) {
|
|
|
|
if (!Data[i]) {
|
2009-02-19 01:49:48 +08:00
|
|
|
Diag(getLocationOfStringLiteralByte(Literal, i),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::warn_cfstring_literal_contains_nul_character)
|
|
|
|
<< Arg->getSourceRange();
|
2007-08-17 13:31:46 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-08-17 23:44:17 +08:00
|
|
|
return false;
|
2007-08-11 04:18:51 +08:00
|
|
|
}
|
|
|
|
|
2007-12-20 08:05:45 +08:00
|
|
|
/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
|
|
|
|
/// Emit an error and return true on failure, return false on success.
|
2007-12-28 13:29:59 +08:00
|
|
|
bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
|
|
|
|
Expr *Fn = TheCall->getCallee();
|
|
|
|
if (TheCall->getNumArgs() > 2) {
|
2008-11-22 02:44:24 +08:00
|
|
|
Diag(TheCall->getArg(2)->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_typecheck_call_too_many_args)
|
2008-11-22 02:44:24 +08:00
|
|
|
<< 0 /*function call*/ << Fn->getSourceRange()
|
2008-11-19 13:08:23 +08:00
|
|
|
<< SourceRange(TheCall->getArg(2)->getLocStart(),
|
|
|
|
(*(TheCall->arg_end()-1))->getLocEnd());
|
2007-12-20 07:59:04 +08:00
|
|
|
return true;
|
|
|
|
}
|
2008-12-16 06:05:35 +08:00
|
|
|
|
|
|
|
if (TheCall->getNumArgs() < 2) {
|
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
|
|
|
|
<< 0 /*function call*/;
|
|
|
|
}
|
|
|
|
|
2007-12-20 08:05:45 +08:00
|
|
|
// Determine whether the current function is variadic or not.
|
|
|
|
bool isVariadic;
|
2009-04-16 03:33:47 +08:00
|
|
|
if (CurBlock)
|
|
|
|
isVariadic = CurBlock->isVariadic;
|
|
|
|
else if (getCurFunctionDecl()) {
|
2009-02-27 07:50:07 +08:00
|
|
|
if (FunctionProtoType* FTP =
|
|
|
|
dyn_cast<FunctionProtoType>(getCurFunctionDecl()->getType()))
|
2008-12-16 06:05:35 +08:00
|
|
|
isVariadic = FTP->isVariadic();
|
|
|
|
else
|
|
|
|
isVariadic = false;
|
|
|
|
} else {
|
2008-06-28 14:07:14 +08:00
|
|
|
isVariadic = getCurMethodDecl()->isVariadic();
|
2008-12-16 06:05:35 +08:00
|
|
|
}
|
2007-12-20 07:59:04 +08:00
|
|
|
|
2007-12-20 08:05:45 +08:00
|
|
|
if (!isVariadic) {
|
2007-12-20 07:59:04 +08:00
|
|
|
Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that the second argument to the builtin is the last argument of the
|
|
|
|
// current function or method.
|
|
|
|
bool SecondArgIsLastNamedArgument = false;
|
2008-02-13 09:22:59 +08:00
|
|
|
const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
|
2008-02-11 12:20:54 +08:00
|
|
|
|
|
|
|
if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
|
|
|
|
if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
|
2007-12-20 07:59:04 +08:00
|
|
|
// FIXME: This isn't correct for methods (results in bogus warning).
|
|
|
|
// Get the last formal in the current function.
|
2008-02-11 12:20:54 +08:00
|
|
|
const ParmVarDecl *LastArg;
|
2009-04-16 03:33:47 +08:00
|
|
|
if (CurBlock)
|
|
|
|
LastArg = *(CurBlock->TheDecl->param_end()-1);
|
|
|
|
else if (FunctionDecl *FD = getCurFunctionDecl())
|
2008-12-05 07:50:19 +08:00
|
|
|
LastArg = *(FD->param_end()-1);
|
2007-12-20 07:59:04 +08:00
|
|
|
else
|
2008-06-28 14:07:14 +08:00
|
|
|
LastArg = *(getCurMethodDecl()->param_end()-1);
|
2007-12-20 07:59:04 +08:00
|
|
|
SecondArgIsLastNamedArgument = PV == LastArg;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!SecondArgIsLastNamedArgument)
|
2007-12-28 13:29:59 +08:00
|
|
|
Diag(TheCall->getArg(1)->getLocStart(),
|
2007-12-20 07:59:04 +08:00
|
|
|
diag::warn_second_parameter_of_va_start_not_last_named_argument);
|
|
|
|
return false;
|
2008-05-20 16:23:37 +08:00
|
|
|
}
|
2007-12-20 07:59:04 +08:00
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
|
|
|
|
/// friends. This is declared to take (...), so we have to check everything.
|
2007-12-28 13:29:59 +08:00
|
|
|
bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
|
|
|
|
if (TheCall->getNumArgs() < 2)
|
2008-11-22 02:44:24 +08:00
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
|
|
|
|
<< 0 /*function call*/;
|
2007-12-28 13:29:59 +08:00
|
|
|
if (TheCall->getNumArgs() > 2)
|
|
|
|
return Diag(TheCall->getArg(2)->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_typecheck_call_too_many_args)
|
2008-11-22 02:44:24 +08:00
|
|
|
<< 0 /*function call*/
|
2008-11-19 13:08:23 +08:00
|
|
|
<< SourceRange(TheCall->getArg(2)->getLocStart(),
|
|
|
|
(*(TheCall->arg_end()-1))->getLocEnd());
|
2007-12-20 08:26:33 +08:00
|
|
|
|
2007-12-28 13:29:59 +08:00
|
|
|
Expr *OrigArg0 = TheCall->getArg(0);
|
|
|
|
Expr *OrigArg1 = TheCall->getArg(1);
|
2009-05-20 06:10:17 +08:00
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
// Do standard promotions between the two arguments, returning their common
|
|
|
|
// type.
|
2007-12-28 13:29:59 +08:00
|
|
|
QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
|
2009-02-20 03:28:43 +08:00
|
|
|
|
|
|
|
// Make sure any conversions are pushed back into the call; this is
|
|
|
|
// type safe since unordered compare builtins are declared as "_Bool
|
|
|
|
// foo(...)".
|
|
|
|
TheCall->setArg(0, OrigArg0);
|
|
|
|
TheCall->setArg(1, OrigArg1);
|
2007-12-20 08:26:33 +08:00
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
|
|
|
|
return false;
|
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
// If the common type isn't a real floating type, then the arguments were
|
|
|
|
// invalid for this operation.
|
|
|
|
if (!Res->isRealFloatingType())
|
2007-12-28 13:29:59 +08:00
|
|
|
return Diag(OrigArg0->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_typecheck_call_invalid_ordered_compare)
|
2008-11-24 14:25:27 +08:00
|
|
|
<< OrigArg0->getType() << OrigArg1->getType()
|
2008-11-19 13:08:23 +08:00
|
|
|
<< SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
|
2007-12-20 08:26:33 +08:00
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-05-20 16:23:37 +08:00
|
|
|
bool Sema::SemaBuiltinStackAddress(CallExpr *TheCall) {
|
|
|
|
// The signature for these builtins is exact; the only thing we need
|
|
|
|
// to check is that the argument is a constant.
|
|
|
|
SourceLocation Loc;
|
2009-05-20 06:10:17 +08:00
|
|
|
if (!TheCall->getArg(0)->isTypeDependent() &&
|
|
|
|
!TheCall->getArg(0)->isValueDependent() &&
|
|
|
|
!TheCall->getArg(0)->isIntegerConstantExpr(Context, &Loc))
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(Loc, diag::err_stack_const_level) << TheCall->getSourceRange();
|
2008-08-10 10:05:13 +08:00
|
|
|
|
2008-05-20 16:23:37 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-05-15 03:38:39 +08:00
|
|
|
/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
|
|
|
|
// This is declared to take (...), so we have to check everything.
|
2009-01-19 08:08:26 +08:00
|
|
|
Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
|
2008-05-15 03:38:39 +08:00
|
|
|
if (TheCall->getNumArgs() < 3)
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError(Diag(TheCall->getLocEnd(),
|
|
|
|
diag::err_typecheck_call_too_few_args)
|
|
|
|
<< 0 /*function call*/ << TheCall->getSourceRange());
|
2008-05-15 03:38:39 +08:00
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
unsigned numElements = std::numeric_limits<unsigned>::max();
|
|
|
|
if (!TheCall->getArg(0)->isTypeDependent() &&
|
|
|
|
!TheCall->getArg(1)->isTypeDependent()) {
|
|
|
|
QualType FAType = TheCall->getArg(0)->getType();
|
|
|
|
QualType SAType = TheCall->getArg(1)->getType();
|
|
|
|
|
|
|
|
if (!FAType->isVectorType() || !SAType->isVectorType()) {
|
|
|
|
Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
|
|
|
|
<< SourceRange(TheCall->getArg(0)->getLocStart(),
|
|
|
|
TheCall->getArg(1)->getLocEnd());
|
|
|
|
return ExprError();
|
|
|
|
}
|
|
|
|
|
|
|
|
if (Context.getCanonicalType(FAType).getUnqualifiedType() !=
|
|
|
|
Context.getCanonicalType(SAType).getUnqualifiedType()) {
|
|
|
|
Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
|
|
|
|
<< SourceRange(TheCall->getArg(0)->getLocStart(),
|
|
|
|
TheCall->getArg(1)->getLocEnd());
|
|
|
|
return ExprError();
|
|
|
|
}
|
2008-05-15 03:38:39 +08:00
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
numElements = FAType->getAsVectorType()->getNumElements();
|
|
|
|
if (TheCall->getNumArgs() != numElements+2) {
|
|
|
|
if (TheCall->getNumArgs() < numElements+2)
|
|
|
|
return ExprError(Diag(TheCall->getLocEnd(),
|
|
|
|
diag::err_typecheck_call_too_few_args)
|
|
|
|
<< 0 /*function call*/ << TheCall->getSourceRange());
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError(Diag(TheCall->getLocEnd(),
|
2009-05-20 06:10:17 +08:00
|
|
|
diag::err_typecheck_call_too_many_args)
|
|
|
|
<< 0 /*function call*/ << TheCall->getSourceRange());
|
|
|
|
}
|
2008-05-15 03:38:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
|
2009-05-20 06:10:17 +08:00
|
|
|
if (TheCall->getArg(i)->isTypeDependent() ||
|
|
|
|
TheCall->getArg(i)->isValueDependent())
|
|
|
|
continue;
|
|
|
|
|
2008-05-15 03:38:39 +08:00
|
|
|
llvm::APSInt Result(32);
|
2008-08-10 10:05:13 +08:00
|
|
|
if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError(Diag(TheCall->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_shufflevector_nonconstant_argument)
|
2009-01-19 08:08:26 +08:00
|
|
|
<< TheCall->getArg(i)->getSourceRange());
|
|
|
|
|
2008-08-10 10:05:13 +08:00
|
|
|
if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError(Diag(TheCall->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_shufflevector_argument_too_large)
|
2009-01-19 08:08:26 +08:00
|
|
|
<< TheCall->getArg(i)->getSourceRange());
|
2008-05-15 03:38:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
llvm::SmallVector<Expr*, 32> exprs;
|
|
|
|
|
2008-08-10 10:05:13 +08:00
|
|
|
for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
|
2008-05-15 03:38:39 +08:00
|
|
|
exprs.push_back(TheCall->getArg(i));
|
|
|
|
TheCall->setArg(i, 0);
|
|
|
|
}
|
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
return Owned(new (Context) ShuffleVectorExpr(exprs.begin(), exprs.size(),
|
|
|
|
exprs[0]->getType(),
|
2009-02-07 09:47:29 +08:00
|
|
|
TheCall->getCallee()->getLocStart(),
|
|
|
|
TheCall->getRParenLoc()));
|
2008-05-15 03:38:39 +08:00
|
|
|
}
|
2007-12-20 07:59:04 +08:00
|
|
|
|
2008-07-22 06:59:13 +08:00
|
|
|
/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
|
|
|
|
// This is declared to take (const void*, ...) and can take two
|
|
|
|
// optional constant int args.
|
|
|
|
bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
|
2008-11-19 13:08:23 +08:00
|
|
|
unsigned NumArgs = TheCall->getNumArgs();
|
2008-07-22 06:59:13 +08:00
|
|
|
|
2008-11-19 13:08:23 +08:00
|
|
|
if (NumArgs > 3)
|
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_many_args)
|
2008-11-22 02:44:24 +08:00
|
|
|
<< 0 /*function call*/ << TheCall->getSourceRange();
|
2008-07-22 06:59:13 +08:00
|
|
|
|
|
|
|
// Argument 0 is checked for us and the remaining arguments must be
|
|
|
|
// constant integers.
|
2008-11-19 13:08:23 +08:00
|
|
|
for (unsigned i = 1; i != NumArgs; ++i) {
|
2008-07-22 06:59:13 +08:00
|
|
|
Expr *Arg = TheCall->getArg(i);
|
2009-05-20 06:10:17 +08:00
|
|
|
if (Arg->isTypeDependent())
|
|
|
|
continue;
|
|
|
|
|
2008-07-22 06:59:13 +08:00
|
|
|
QualType RWType = Arg->getType();
|
|
|
|
|
|
|
|
const BuiltinType *BT = RWType->getAsBuiltinType();
|
2008-09-04 05:13:56 +08:00
|
|
|
llvm::APSInt Result;
|
2009-05-20 06:10:17 +08:00
|
|
|
if (!BT || BT->getKind() != BuiltinType::Int)
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_prefetch_invalid_argument)
|
|
|
|
<< SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2009-05-20 06:10:17 +08:00
|
|
|
|
|
|
|
if (Arg->isValueDependent())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!Arg->isIntegerConstantExpr(Result, Context))
|
|
|
|
return Diag(TheCall->getLocStart(), diag::err_prefetch_invalid_argument)
|
|
|
|
<< SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2008-07-22 06:59:13 +08:00
|
|
|
|
|
|
|
// FIXME: gcc issues a warning and rewrites these to 0. These
|
|
|
|
// seems especially odd for the third argument since the default
|
|
|
|
// is 3.
|
2008-11-19 13:08:23 +08:00
|
|
|
if (i == 1) {
|
2008-07-22 06:59:13 +08:00
|
|
|
if (Result.getSExtValue() < 0 || Result.getSExtValue() > 1)
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
|
|
|
<< "0" << "1" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2008-07-22 06:59:13 +08:00
|
|
|
} else {
|
|
|
|
if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3)
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
|
|
|
<< "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2008-07-22 06:59:13 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-11-19 13:08:23 +08:00
|
|
|
return false;
|
2008-07-22 06:59:13 +08:00
|
|
|
}
|
|
|
|
|
2008-09-04 05:13:56 +08:00
|
|
|
/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
|
|
|
|
/// int type). This simply type checks that type is one of the defined
|
|
|
|
/// constants (0-3).
|
|
|
|
bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
|
|
|
|
Expr *Arg = TheCall->getArg(1);
|
2009-05-20 06:10:17 +08:00
|
|
|
if (Arg->isTypeDependent())
|
|
|
|
return false;
|
|
|
|
|
2008-09-04 05:13:56 +08:00
|
|
|
QualType ArgType = Arg->getType();
|
|
|
|
const BuiltinType *BT = ArgType->getAsBuiltinType();
|
|
|
|
llvm::APSInt Result(32);
|
2009-05-20 06:10:17 +08:00
|
|
|
if (!BT || BT->getKind() != BuiltinType::Int)
|
|
|
|
return Diag(TheCall->getLocStart(), diag::err_object_size_invalid_argument)
|
|
|
|
<< SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
|
|
|
|
|
|
|
if (Arg->isValueDependent())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (!Arg->isIntegerConstantExpr(Result, Context)) {
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_object_size_invalid_argument)
|
|
|
|
<< SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2008-09-04 05:13:56 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
|
|
|
<< "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2008-09-04 05:13:56 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2009-05-03 14:04:26 +08:00
|
|
|
/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
|
2009-05-03 12:46:36 +08:00
|
|
|
/// This checks that val is a constant 1.
|
|
|
|
bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
|
|
|
|
Expr *Arg = TheCall->getArg(1);
|
2009-05-20 06:10:17 +08:00
|
|
|
if (Arg->isTypeDependent() || Arg->isValueDependent())
|
|
|
|
return false;
|
|
|
|
|
2009-05-03 12:46:36 +08:00
|
|
|
llvm::APSInt Result(32);
|
|
|
|
if (!Arg->isIntegerConstantExpr(Result, Context) || Result != 1)
|
|
|
|
return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
|
|
|
|
<< SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2009-01-13 07:09:09 +08:00
|
|
|
// Handle i > 1 ? "x" : "y", recursivelly
|
2009-03-21 05:35:28 +08:00
|
|
|
bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
|
|
|
|
bool HasVAListArg,
|
2009-02-15 02:57:46 +08:00
|
|
|
unsigned format_idx, unsigned firstDataArg) {
|
2009-05-20 06:10:17 +08:00
|
|
|
if (E->isTypeDependent() || E->isValueDependent())
|
|
|
|
return false;
|
2009-01-13 07:09:09 +08:00
|
|
|
|
|
|
|
switch (E->getStmtClass()) {
|
|
|
|
case Stmt::ConditionalOperatorClass: {
|
2009-03-21 05:35:28 +08:00
|
|
|
const ConditionalOperator *C = cast<ConditionalOperator>(E);
|
2009-01-13 07:09:09 +08:00
|
|
|
return SemaCheckStringLiteral(C->getLHS(), TheCall,
|
2009-02-15 02:57:46 +08:00
|
|
|
HasVAListArg, format_idx, firstDataArg)
|
2009-01-13 07:09:09 +08:00
|
|
|
&& SemaCheckStringLiteral(C->getRHS(), TheCall,
|
2009-02-15 02:57:46 +08:00
|
|
|
HasVAListArg, format_idx, firstDataArg);
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ImplicitCastExprClass: {
|
2009-03-21 05:35:28 +08:00
|
|
|
const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
|
2009-01-13 07:09:09 +08:00
|
|
|
return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
|
2009-02-15 02:57:46 +08:00
|
|
|
format_idx, firstDataArg);
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ParenExprClass: {
|
2009-03-21 05:35:28 +08:00
|
|
|
const ParenExpr *Expr = cast<ParenExpr>(E);
|
2009-01-13 07:09:09 +08:00
|
|
|
return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
|
2009-02-15 02:57:46 +08:00
|
|
|
format_idx, firstDataArg);
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
2009-03-21 05:35:28 +08:00
|
|
|
|
|
|
|
case Stmt::DeclRefExprClass: {
|
|
|
|
const DeclRefExpr *DR = cast<DeclRefExpr>(E);
|
|
|
|
|
|
|
|
// As an exception, do not flag errors for variables binding to
|
|
|
|
// const string literals.
|
|
|
|
if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
|
|
|
|
bool isConstant = false;
|
|
|
|
QualType T = DR->getType();
|
|
|
|
|
|
|
|
if (const ArrayType *AT = Context.getAsArrayType(T)) {
|
|
|
|
isConstant = AT->getElementType().isConstant(Context);
|
|
|
|
}
|
|
|
|
else if (const PointerType *PT = T->getAsPointerType()) {
|
|
|
|
isConstant = T.isConstant(Context) &&
|
|
|
|
PT->getPointeeType().isConstant(Context);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (isConstant) {
|
|
|
|
const VarDecl *Def = 0;
|
|
|
|
if (const Expr *Init = VD->getDefinition(Def))
|
|
|
|
return SemaCheckStringLiteral(Init, TheCall,
|
|
|
|
HasVAListArg, format_idx, firstDataArg);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
2009-01-13 07:09:09 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
case Stmt::ObjCStringLiteralClass:
|
|
|
|
case Stmt::StringLiteralClass: {
|
|
|
|
const StringLiteral *StrE = NULL;
|
|
|
|
|
|
|
|
if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
|
2009-01-13 07:09:09 +08:00
|
|
|
StrE = ObjCFExpr->getString();
|
|
|
|
else
|
2009-03-21 05:35:28 +08:00
|
|
|
StrE = cast<StringLiteral>(E);
|
|
|
|
|
2009-01-13 07:09:09 +08:00
|
|
|
if (StrE) {
|
2009-02-15 02:57:46 +08:00
|
|
|
CheckPrintfString(StrE, E, TheCall, HasVAListArg, format_idx,
|
|
|
|
firstDataArg);
|
2009-01-13 07:09:09 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
2009-03-21 05:35:28 +08:00
|
|
|
|
|
|
|
default:
|
|
|
|
return false;
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2007-08-11 04:18:51 +08:00
|
|
|
/// CheckPrintfArguments - Check calls to printf (and similar functions) for
|
2007-08-15 01:39:48 +08:00
|
|
|
/// correct use of format strings.
|
|
|
|
///
|
|
|
|
/// HasVAListArg - A predicate indicating whether the printf-like
|
|
|
|
/// function is passed an explicit va_arg argument (e.g., vprintf)
|
|
|
|
///
|
|
|
|
/// format_idx - The index into Args for the format string.
|
|
|
|
///
|
|
|
|
/// Improper format strings to functions in the printf family can be
|
|
|
|
/// the source of bizarre bugs and very serious security holes. A
|
|
|
|
/// good source of information is available in the following paper
|
|
|
|
/// (which includes additional references):
|
2007-08-11 04:18:51 +08:00
|
|
|
///
|
|
|
|
/// FormatGuard: Automatic Protection From printf Format String
|
|
|
|
/// Vulnerabilities, Proceedings of the 10th USENIX Security Symposium, 2001.
|
2007-08-15 01:39:48 +08:00
|
|
|
///
|
|
|
|
/// Functionality implemented:
|
|
|
|
///
|
|
|
|
/// We can statically check the following properties for string
|
|
|
|
/// literal format strings for non v.*printf functions (where the
|
|
|
|
/// arguments are passed directly):
|
|
|
|
//
|
|
|
|
/// (1) Are the number of format conversions equal to the number of
|
|
|
|
/// data arguments?
|
|
|
|
///
|
|
|
|
/// (2) Does each format conversion correctly match the type of the
|
|
|
|
/// corresponding data argument? (TODO)
|
|
|
|
///
|
|
|
|
/// Moreover, for all printf functions we can:
|
|
|
|
///
|
|
|
|
/// (3) Check for a missing format string (when not caught by type checking).
|
|
|
|
///
|
|
|
|
/// (4) Check for no-operation flags; e.g. using "#" with format
|
|
|
|
/// conversion 'c' (TODO)
|
|
|
|
///
|
|
|
|
/// (5) Check the use of '%n', a major source of security holes.
|
|
|
|
///
|
|
|
|
/// (6) Check for malformed format conversions that don't specify anything.
|
|
|
|
///
|
|
|
|
/// (7) Check for empty format strings. e.g: printf("");
|
|
|
|
///
|
|
|
|
/// (8) Check that the format string is a wide literal.
|
|
|
|
///
|
2008-03-04 00:50:00 +08:00
|
|
|
/// (9) Also check the arguments of functions with the __format__ attribute.
|
|
|
|
/// (TODO).
|
|
|
|
///
|
2007-08-15 01:39:48 +08:00
|
|
|
/// All of these checks can be done by parsing the format string.
|
|
|
|
///
|
|
|
|
/// For now, we ONLY do (1), (3), (5), (6), (7), and (8).
|
2007-08-11 04:18:51 +08:00
|
|
|
void
|
2009-03-21 05:35:28 +08:00
|
|
|
Sema::CheckPrintfArguments(const CallExpr *TheCall, bool HasVAListArg,
|
2009-02-15 02:57:46 +08:00
|
|
|
unsigned format_idx, unsigned firstDataArg) {
|
2009-03-21 05:35:28 +08:00
|
|
|
const Expr *Fn = TheCall->getCallee();
|
2007-12-28 13:29:59 +08:00
|
|
|
|
2007-08-15 01:39:48 +08:00
|
|
|
// CHECK: printf-like function is called with no format string.
|
2007-12-28 13:29:59 +08:00
|
|
|
if (format_idx >= TheCall->getNumArgs()) {
|
2008-11-19 13:27:50 +08:00
|
|
|
Diag(TheCall->getRParenLoc(), diag::warn_printf_missing_format_string)
|
|
|
|
<< Fn->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
|
2007-08-25 13:36:18 +08:00
|
|
|
|
2007-08-11 04:18:51 +08:00
|
|
|
// CHECK: format string is not a string literal.
|
|
|
|
//
|
2007-08-15 01:39:48 +08:00
|
|
|
// Dynamically generated format strings are difficult to
|
|
|
|
// automatically vet at compile time. Requiring that format strings
|
|
|
|
// are string literals: (1) permits the checking of format strings by
|
|
|
|
// the compiler and thereby (2) can practically remove the source of
|
|
|
|
// many format string exploits.
|
2008-06-17 02:00:42 +08:00
|
|
|
|
|
|
|
// Format string can be either ObjC string (e.g. @"%d") or
|
|
|
|
// C string (e.g. "%d")
|
|
|
|
// ObjC string uses the same format specifiers as C string, so we can use
|
|
|
|
// the same format string checking logic for both ObjC and C strings.
|
2009-04-29 12:49:34 +08:00
|
|
|
if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
|
|
|
|
firstDataArg))
|
|
|
|
return; // Literal format string found, check done!
|
|
|
|
|
|
|
|
// For vprintf* functions (i.e., HasVAListArg==true), we add a
|
|
|
|
// special check to see if the format string is a function parameter
|
|
|
|
// of the function calling the printf function. If the function
|
|
|
|
// has an attribute indicating it is a printf-like function, then we
|
|
|
|
// should suppress warnings concerning non-literals being used in a call
|
|
|
|
// to a vprintf function. For example:
|
|
|
|
//
|
|
|
|
// void
|
|
|
|
// logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...) {
|
|
|
|
// va_list ap;
|
|
|
|
// va_start(ap, fmt);
|
|
|
|
// vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
|
|
|
|
// ...
|
|
|
|
//
|
|
|
|
//
|
|
|
|
// FIXME: We don't have full attribute support yet, so just check to see
|
|
|
|
// if the argument is a DeclRefExpr that references a parameter. We'll
|
|
|
|
// add proper support for checking the attribute later.
|
|
|
|
if (HasVAListArg)
|
|
|
|
if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(OrigFormatExpr))
|
|
|
|
if (isa<ParmVarDecl>(DR->getDecl()))
|
|
|
|
return;
|
|
|
|
|
2009-04-29 12:59:47 +08:00
|
|
|
// If there are no arguments specified, warn with -Wformat-security, otherwise
|
|
|
|
// warn only with -Wformat-nonliteral.
|
|
|
|
if (TheCall->getNumArgs() == format_idx+1)
|
|
|
|
Diag(TheCall->getArg(format_idx)->getLocStart(),
|
|
|
|
diag::warn_printf_nonliteral_noargs)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
|
|
|
else
|
|
|
|
Diag(TheCall->getArg(format_idx)->getLocStart(),
|
|
|
|
diag::warn_printf_nonliteral)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
void Sema::CheckPrintfString(const StringLiteral *FExpr,
|
|
|
|
const Expr *OrigFormatExpr,
|
|
|
|
const CallExpr *TheCall, bool HasVAListArg,
|
|
|
|
unsigned format_idx, unsigned firstDataArg) {
|
|
|
|
|
|
|
|
const ObjCStringLiteral *ObjCFExpr =
|
|
|
|
dyn_cast<ObjCStringLiteral>(OrigFormatExpr);
|
2007-08-15 01:39:48 +08:00
|
|
|
|
|
|
|
// CHECK: is the format string a wide literal?
|
|
|
|
if (FExpr->isWide()) {
|
2007-12-28 13:29:59 +08:00
|
|
|
Diag(FExpr->getLocStart(),
|
2008-11-19 13:27:50 +08:00
|
|
|
diag::warn_printf_format_string_is_wide_literal)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Str - The format string. NOTE: this is NOT null-terminated!
|
2009-04-29 12:12:34 +08:00
|
|
|
const char *Str = FExpr->getStrData();
|
2007-08-15 01:39:48 +08:00
|
|
|
|
|
|
|
// CHECK: empty format string?
|
2009-04-29 12:12:34 +08:00
|
|
|
unsigned StrLen = FExpr->getByteLength();
|
2007-08-15 01:39:48 +08:00
|
|
|
|
|
|
|
if (StrLen == 0) {
|
2008-11-19 13:27:50 +08:00
|
|
|
Diag(FExpr->getLocStart(), diag::warn_printf_empty_format_string)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// We process the format string using a binary state machine. The
|
|
|
|
// current state is stored in CurrentState.
|
|
|
|
enum {
|
|
|
|
state_OrdChr,
|
|
|
|
state_Conversion
|
|
|
|
} CurrentState = state_OrdChr;
|
|
|
|
|
|
|
|
// numConversions - The number of conversions seen so far. This is
|
|
|
|
// incremented as we traverse the format string.
|
|
|
|
unsigned numConversions = 0;
|
|
|
|
|
|
|
|
// numDataArgs - The number of data arguments after the format
|
|
|
|
// string. This can only be determined for non vprintf-like
|
|
|
|
// functions. For those functions, this value is 1 (the sole
|
|
|
|
// va_arg argument).
|
2009-02-15 02:57:46 +08:00
|
|
|
unsigned numDataArgs = TheCall->getNumArgs()-firstDataArg;
|
2007-08-15 01:39:48 +08:00
|
|
|
|
|
|
|
// Inspect the format string.
|
|
|
|
unsigned StrIdx = 0;
|
|
|
|
|
|
|
|
// LastConversionIdx - Index within the format string where we last saw
|
|
|
|
// a '%' character that starts a new format conversion.
|
|
|
|
unsigned LastConversionIdx = 0;
|
|
|
|
|
2007-12-28 13:29:59 +08:00
|
|
|
for (; StrIdx < StrLen; ++StrIdx) {
|
2007-12-28 13:38:24 +08:00
|
|
|
|
2007-08-15 01:39:48 +08:00
|
|
|
// Is the number of detected conversion conversions greater than
|
|
|
|
// the number of matching data arguments? If so, stop.
|
|
|
|
if (!HasVAListArg && numConversions > numDataArgs) break;
|
|
|
|
|
|
|
|
// Handle "\0"
|
2007-12-28 13:29:59 +08:00
|
|
|
if (Str[StrIdx] == '\0') {
|
2007-08-15 01:39:48 +08:00
|
|
|
// The string returned by getStrData() is not null-terminated,
|
|
|
|
// so the presence of a null character is likely an error.
|
2009-02-19 01:49:48 +08:00
|
|
|
Diag(getLocationOfStringLiteralByte(FExpr, StrIdx),
|
2008-11-19 13:27:50 +08:00
|
|
|
diag::warn_printf_format_string_contains_null_char)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ordinary characters (not processing a format conversion).
|
|
|
|
if (CurrentState == state_OrdChr) {
|
|
|
|
if (Str[StrIdx] == '%') {
|
|
|
|
CurrentState = state_Conversion;
|
|
|
|
LastConversionIdx = StrIdx;
|
|
|
|
}
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Seen '%'. Now processing a format conversion.
|
|
|
|
switch (Str[StrIdx]) {
|
2007-12-28 13:31:15 +08:00
|
|
|
// Handle dynamic precision or width specifier.
|
|
|
|
case '*': {
|
|
|
|
++numConversions;
|
|
|
|
|
2009-05-14 00:06:05 +08:00
|
|
|
if (!HasVAListArg) {
|
|
|
|
if (numConversions > numDataArgs) {
|
|
|
|
SourceLocation Loc = getLocationOfStringLiteralByte(FExpr, StrIdx);
|
|
|
|
|
|
|
|
if (Str[StrIdx-1] == '.')
|
|
|
|
Diag(Loc, diag::warn_printf_asterisk_precision_missing_arg)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
|
|
|
else
|
|
|
|
Diag(Loc, diag::warn_printf_asterisk_width_missing_arg)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
|
|
|
|
|
|
|
// Don't do any more checking. We'll just emit spurious errors.
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Perform type checking on width/precision specifier.
|
|
|
|
const Expr *E = TheCall->getArg(format_idx+numConversions);
|
|
|
|
if (const BuiltinType *BT = E->getType()->getAsBuiltinType())
|
|
|
|
if (BT->getKind() == BuiltinType::Int)
|
|
|
|
break;
|
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
SourceLocation Loc = getLocationOfStringLiteralByte(FExpr, StrIdx);
|
2009-05-14 00:06:05 +08:00
|
|
|
|
2007-10-13 04:51:52 +08:00
|
|
|
if (Str[StrIdx-1] == '.')
|
2009-05-14 00:06:05 +08:00
|
|
|
Diag(Loc, diag::warn_printf_asterisk_precision_wrong_type)
|
|
|
|
<< E->getType() << E->getSourceRange();
|
2007-10-13 04:51:52 +08:00
|
|
|
else
|
2009-05-14 00:06:05 +08:00
|
|
|
Diag(Loc, diag::warn_printf_asterisk_width_wrong_type)
|
|
|
|
<< E->getType() << E->getSourceRange();
|
2007-10-13 04:51:52 +08:00
|
|
|
|
2009-05-14 00:06:05 +08:00
|
|
|
break;
|
2007-10-13 04:51:52 +08:00
|
|
|
}
|
2007-12-28 13:31:15 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Characters which can terminate a format conversion
|
|
|
|
// (e.g. "%d"). Characters that specify length modifiers or
|
|
|
|
// other flags are handled by the default case below.
|
|
|
|
//
|
|
|
|
// FIXME: additional checks will go into the following cases.
|
|
|
|
case 'i':
|
|
|
|
case 'd':
|
|
|
|
case 'o':
|
|
|
|
case 'u':
|
|
|
|
case 'x':
|
|
|
|
case 'X':
|
|
|
|
case 'D':
|
|
|
|
case 'O':
|
|
|
|
case 'U':
|
|
|
|
case 'e':
|
|
|
|
case 'E':
|
|
|
|
case 'f':
|
|
|
|
case 'F':
|
|
|
|
case 'g':
|
|
|
|
case 'G':
|
|
|
|
case 'a':
|
|
|
|
case 'A':
|
|
|
|
case 'c':
|
|
|
|
case 'C':
|
|
|
|
case 'S':
|
|
|
|
case 's':
|
|
|
|
case 'p':
|
|
|
|
++numConversions;
|
|
|
|
CurrentState = state_OrdChr;
|
|
|
|
break;
|
2007-08-15 01:39:48 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// CHECK: Are we using "%n"? Issue a warning.
|
|
|
|
case 'n': {
|
|
|
|
++numConversions;
|
|
|
|
CurrentState = state_OrdChr;
|
2009-02-19 01:49:48 +08:00
|
|
|
SourceLocation Loc = getLocationOfStringLiteralByte(FExpr,
|
|
|
|
LastConversionIdx);
|
2007-12-28 13:31:15 +08:00
|
|
|
|
2008-11-19 13:27:50 +08:00
|
|
|
Diag(Loc, diag::warn_printf_write_back)<<OrigFormatExpr->getSourceRange();
|
2007-12-28 13:31:15 +08:00
|
|
|
break;
|
|
|
|
}
|
2008-06-17 02:00:42 +08:00
|
|
|
|
|
|
|
// Handle "%@"
|
|
|
|
case '@':
|
|
|
|
// %@ is allowed in ObjC format strings only.
|
|
|
|
if(ObjCFExpr != NULL)
|
|
|
|
CurrentState = state_OrdChr;
|
|
|
|
else {
|
|
|
|
// Issue a warning: invalid format conversion.
|
2009-02-19 01:49:48 +08:00
|
|
|
SourceLocation Loc =
|
|
|
|
getLocationOfStringLiteralByte(FExpr, LastConversionIdx);
|
2008-06-17 02:00:42 +08:00
|
|
|
|
2008-11-20 14:06:08 +08:00
|
|
|
Diag(Loc, diag::warn_printf_invalid_conversion)
|
|
|
|
<< std::string(Str+LastConversionIdx,
|
|
|
|
Str+std::min(LastConversionIdx+2, StrLen))
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2008-06-17 02:00:42 +08:00
|
|
|
}
|
|
|
|
++numConversions;
|
|
|
|
break;
|
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// Handle "%%"
|
|
|
|
case '%':
|
|
|
|
// Sanity check: Was the first "%" character the previous one?
|
|
|
|
// If not, we will assume that we have a malformed format
|
|
|
|
// conversion, and that the current "%" character is the start
|
|
|
|
// of a new conversion.
|
|
|
|
if (StrIdx - LastConversionIdx == 1)
|
|
|
|
CurrentState = state_OrdChr;
|
|
|
|
else {
|
|
|
|
// Issue a warning: invalid format conversion.
|
2009-02-19 01:49:48 +08:00
|
|
|
SourceLocation Loc =
|
|
|
|
getLocationOfStringLiteralByte(FExpr, LastConversionIdx);
|
2007-12-28 13:31:15 +08:00
|
|
|
|
2008-11-20 14:06:08 +08:00
|
|
|
Diag(Loc, diag::warn_printf_invalid_conversion)
|
|
|
|
<< std::string(Str+LastConversionIdx, Str+StrIdx)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-12-28 13:31:15 +08:00
|
|
|
|
|
|
|
// This conversion is broken. Advance to the next format
|
|
|
|
// conversion.
|
|
|
|
LastConversionIdx = StrIdx;
|
|
|
|
++numConversions;
|
2007-08-15 01:39:48 +08:00
|
|
|
}
|
2007-12-28 13:31:15 +08:00
|
|
|
break;
|
2007-08-15 01:39:48 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
default:
|
|
|
|
// This case catches all other characters: flags, widths, etc.
|
|
|
|
// We should eventually process those as well.
|
|
|
|
break;
|
2007-08-15 01:39:48 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (CurrentState == state_Conversion) {
|
|
|
|
// Issue a warning: invalid format conversion.
|
2009-02-19 01:49:48 +08:00
|
|
|
SourceLocation Loc =
|
|
|
|
getLocationOfStringLiteralByte(FExpr, LastConversionIdx);
|
2007-08-15 01:39:48 +08:00
|
|
|
|
2008-11-20 14:06:08 +08:00
|
|
|
Diag(Loc, diag::warn_printf_invalid_conversion)
|
|
|
|
<< std::string(Str+LastConversionIdx,
|
|
|
|
Str+std::min(LastConversionIdx+2, StrLen))
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!HasVAListArg) {
|
|
|
|
// CHECK: Does the number of format conversions exceed the number
|
|
|
|
// of data arguments?
|
|
|
|
if (numConversions > numDataArgs) {
|
2009-02-19 01:49:48 +08:00
|
|
|
SourceLocation Loc =
|
|
|
|
getLocationOfStringLiteralByte(FExpr, LastConversionIdx);
|
2007-08-15 01:39:48 +08:00
|
|
|
|
2008-11-19 13:27:50 +08:00
|
|
|
Diag(Loc, diag::warn_printf_insufficient_data_args)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
}
|
|
|
|
// CHECK: Does the number of data arguments exceed the number of
|
|
|
|
// format conversions in the format string?
|
|
|
|
else if (numConversions < numDataArgs)
|
2007-12-28 13:29:59 +08:00
|
|
|
Diag(TheCall->getArg(format_idx+numConversions+1)->getLocStart(),
|
2008-11-19 13:27:50 +08:00
|
|
|
diag::warn_printf_too_many_data_args)
|
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
}
|
|
|
|
}
|
2007-08-18 00:46:58 +08:00
|
|
|
|
|
|
|
//===--- CHECK: Return Address of Stack Variable --------------------------===//
|
|
|
|
|
|
|
|
static DeclRefExpr* EvalVal(Expr *E);
|
|
|
|
static DeclRefExpr* EvalAddr(Expr* E);
|
|
|
|
|
|
|
|
/// CheckReturnStackAddr - Check if a return statement returns the address
|
|
|
|
/// of a stack variable.
|
|
|
|
void
|
|
|
|
Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
|
|
|
|
SourceLocation ReturnLoc) {
|
2008-02-13 09:02:39 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Perform checking for returned stack addresses.
|
2008-09-06 06:11:13 +08:00
|
|
|
if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
|
2007-08-18 00:46:58 +08:00
|
|
|
if (DeclRefExpr *DR = EvalAddr(RetValExp))
|
2008-11-19 16:23:25 +08:00
|
|
|
Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
|
2008-11-24 05:45:46 +08:00
|
|
|
<< DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
|
2008-09-17 06:25:10 +08:00
|
|
|
|
|
|
|
// Skip over implicit cast expressions when checking for block expressions.
|
|
|
|
if (ImplicitCastExpr *IcExpr =
|
|
|
|
dyn_cast_or_null<ImplicitCastExpr>(RetValExp))
|
|
|
|
RetValExp = IcExpr->getSubExpr();
|
|
|
|
|
2008-09-11 03:17:48 +08:00
|
|
|
if (BlockExpr *C = dyn_cast_or_null<BlockExpr>(RetValExp))
|
2009-04-17 08:09:41 +08:00
|
|
|
if (C->hasBlockDeclRefExprs())
|
|
|
|
Diag(C->getLocStart(), diag::err_ret_local_block)
|
|
|
|
<< C->getSourceRange();
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
// Perform checking for stack values returned by reference.
|
|
|
|
else if (lhsType->isReferenceType()) {
|
2008-10-28 03:41:14 +08:00
|
|
|
// Check for a reference to the stack
|
|
|
|
if (DeclRefExpr *DR = EvalVal(RetValExp))
|
2008-11-19 13:27:50 +08:00
|
|
|
Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
|
2008-11-24 05:45:46 +08:00
|
|
|
<< DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
|
|
|
|
/// check if the expression in a return statement evaluates to an address
|
|
|
|
/// to a location on the stack. The recursion is used to traverse the
|
|
|
|
/// AST of the return expression, with recursion backtracking when we
|
|
|
|
/// encounter a subexpression that (1) clearly does not lead to the address
|
|
|
|
/// of a stack variable or (2) is something we cannot determine leads to
|
|
|
|
/// the address of a stack variable based on such local checking.
|
|
|
|
///
|
2007-08-29 01:02:55 +08:00
|
|
|
/// EvalAddr processes expressions that are pointers that are used as
|
|
|
|
/// references (and not L-values). EvalVal handles all other values.
|
2007-08-18 00:46:58 +08:00
|
|
|
/// At the base case of the recursion is a check for a DeclRefExpr* in
|
|
|
|
/// the refers to a stack variable.
|
|
|
|
///
|
|
|
|
/// This implementation handles:
|
|
|
|
///
|
|
|
|
/// * pointer-to-pointer casts
|
|
|
|
/// * implicit conversions from array references to pointers
|
|
|
|
/// * taking the address of fields
|
|
|
|
/// * arbitrary interplay between "&" and "*" operators
|
|
|
|
/// * pointer arithmetic from an address of a stack variable
|
|
|
|
/// * taking the address of an array element where the array is on the stack
|
|
|
|
static DeclRefExpr* EvalAddr(Expr *E) {
|
|
|
|
// We should only be called for evaluating pointer expressions.
|
2008-09-06 06:11:13 +08:00
|
|
|
assert((E->getType()->isPointerType() ||
|
|
|
|
E->getType()->isBlockPointerType() ||
|
2008-01-08 03:49:32 +08:00
|
|
|
E->getType()->isObjCQualifiedIdType()) &&
|
2007-12-28 13:31:15 +08:00
|
|
|
"EvalAddr only works on pointers");
|
2007-08-18 00:46:58 +08:00
|
|
|
|
|
|
|
// Our "symbolic interpreter" is just a dispatch off the currently
|
|
|
|
// viewed AST node. We then recursively traverse the AST by calling
|
|
|
|
// EvalAddr and EvalVal appropriately.
|
|
|
|
switch (E->getStmtClass()) {
|
2007-12-28 13:31:15 +08:00
|
|
|
case Stmt::ParenExprClass:
|
|
|
|
// Ignore parentheses.
|
|
|
|
return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
case Stmt::UnaryOperatorClass: {
|
|
|
|
// The only unary operator that make sense to handle here
|
|
|
|
// is AddrOf. All others don't make sense as pointers.
|
|
|
|
UnaryOperator *U = cast<UnaryOperator>(E);
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
if (U->getOpcode() == UnaryOperator::AddrOf)
|
|
|
|
return EvalVal(U->getSubExpr());
|
|
|
|
else
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::BinaryOperatorClass: {
|
|
|
|
// Handle pointer arithmetic. All other binary operators are not valid
|
|
|
|
// in this context.
|
|
|
|
BinaryOperator *B = cast<BinaryOperator>(E);
|
|
|
|
BinaryOperator::Opcode op = B->getOpcode();
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
|
|
|
|
return NULL;
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
Expr *Base = B->getLHS();
|
2007-12-01 03:04:31 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// Determine which argument is the real pointer base. It could be
|
|
|
|
// the RHS argument instead of the LHS.
|
|
|
|
if (!Base->getType()->isPointerType()) Base = B->getRHS();
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
assert (Base->getType()->isPointerType());
|
|
|
|
return EvalAddr(Base);
|
|
|
|
}
|
2008-09-11 03:17:48 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// For conditional operators we need to see if either the LHS or RHS are
|
|
|
|
// valid DeclRefExpr*s. If one of them is valid, we return it.
|
|
|
|
case Stmt::ConditionalOperatorClass: {
|
|
|
|
ConditionalOperator *C = cast<ConditionalOperator>(E);
|
|
|
|
|
|
|
|
// Handle the GNU extension for missing LHS.
|
|
|
|
if (Expr *lhsExpr = C->getLHS())
|
|
|
|
if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
|
|
|
|
return LHS;
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
return EvalAddr(C->getRHS());
|
|
|
|
}
|
|
|
|
|
2008-08-07 08:49:01 +08:00
|
|
|
// For casts, we need to handle conversions from arrays to
|
|
|
|
// pointer values, and pointer-to-pointer conversions.
|
2008-10-28 03:41:14 +08:00
|
|
|
case Stmt::ImplicitCastExprClass:
|
2008-10-28 23:36:24 +08:00
|
|
|
case Stmt::CStyleCastExprClass:
|
2008-10-28 03:41:14 +08:00
|
|
|
case Stmt::CXXFunctionalCastExprClass: {
|
2008-08-19 07:01:59 +08:00
|
|
|
Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
|
2008-08-07 08:49:01 +08:00
|
|
|
QualType T = SubExpr->getType();
|
2007-12-28 13:31:15 +08:00
|
|
|
|
2008-09-06 06:11:13 +08:00
|
|
|
if (SubExpr->getType()->isPointerType() ||
|
|
|
|
SubExpr->getType()->isBlockPointerType() ||
|
|
|
|
SubExpr->getType()->isObjCQualifiedIdType())
|
2007-12-28 13:31:15 +08:00
|
|
|
return EvalAddr(SubExpr);
|
2008-08-07 08:49:01 +08:00
|
|
|
else if (T->isArrayType())
|
|
|
|
return EvalVal(SubExpr);
|
2007-12-28 13:31:15 +08:00
|
|
|
else
|
2008-08-07 08:49:01 +08:00
|
|
|
return 0;
|
2007-12-28 13:31:15 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// C++ casts. For dynamic casts, static casts, and const casts, we
|
|
|
|
// are always converting from a pointer-to-pointer, so we just blow
|
2008-10-28 03:41:14 +08:00
|
|
|
// through the cast. In the case the dynamic cast doesn't fail (and
|
|
|
|
// return NULL), we take the conservative route and report cases
|
2007-12-28 13:31:15 +08:00
|
|
|
// where we return the address of a stack variable. For Reinterpre
|
2008-10-28 03:41:14 +08:00
|
|
|
// FIXME: The comment about is wrong; we're not always converting
|
|
|
|
// from pointer to pointer. I'm guessing that this code should also
|
|
|
|
// handle references to objects.
|
|
|
|
case Stmt::CXXStaticCastExprClass:
|
|
|
|
case Stmt::CXXDynamicCastExprClass:
|
|
|
|
case Stmt::CXXConstCastExprClass:
|
|
|
|
case Stmt::CXXReinterpretCastExprClass: {
|
|
|
|
Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
|
2008-09-06 06:11:13 +08:00
|
|
|
if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
|
2007-12-28 13:31:15 +08:00
|
|
|
return EvalAddr(S);
|
2007-08-18 00:46:58 +08:00
|
|
|
else
|
|
|
|
return NULL;
|
2007-12-28 13:31:15 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Everything else: we simply don't reason about them.
|
|
|
|
default:
|
|
|
|
return NULL;
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/// EvalVal - This function is complements EvalAddr in the mutual recursion.
|
|
|
|
/// See the comments for EvalAddr for more details.
|
|
|
|
static DeclRefExpr* EvalVal(Expr *E) {
|
|
|
|
|
2007-08-29 01:02:55 +08:00
|
|
|
// We should only be called for evaluating non-pointer expressions, or
|
|
|
|
// expressions with a pointer type that are not used as references but instead
|
|
|
|
// are l-values (e.g., DeclRefExpr with a pointer type).
|
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Our "symbolic interpreter" is just a dispatch off the currently
|
|
|
|
// viewed AST node. We then recursively traverse the AST by calling
|
|
|
|
// EvalAddr and EvalVal appropriately.
|
|
|
|
switch (E->getStmtClass()) {
|
2009-01-06 13:10:23 +08:00
|
|
|
case Stmt::DeclRefExprClass:
|
|
|
|
case Stmt::QualifiedDeclRefExprClass: {
|
2007-08-18 00:46:58 +08:00
|
|
|
// DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
|
|
|
|
// at code that refers to a variable's name. We check if it has local
|
|
|
|
// storage within the function, and if so, return the expression.
|
|
|
|
DeclRefExpr *DR = cast<DeclRefExpr>(E);
|
|
|
|
|
|
|
|
if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
|
2008-10-29 08:13:59 +08:00
|
|
|
if(V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
|
2007-08-18 00:46:58 +08:00
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ParenExprClass:
|
|
|
|
// Ignore parentheses.
|
|
|
|
return EvalVal(cast<ParenExpr>(E)->getSubExpr());
|
|
|
|
|
|
|
|
case Stmt::UnaryOperatorClass: {
|
|
|
|
// The only unary operator that make sense to handle here
|
|
|
|
// is Deref. All others don't resolve to a "name." This includes
|
|
|
|
// handling all sorts of rvalues passed to a unary operator.
|
|
|
|
UnaryOperator *U = cast<UnaryOperator>(E);
|
|
|
|
|
|
|
|
if (U->getOpcode() == UnaryOperator::Deref)
|
|
|
|
return EvalAddr(U->getSubExpr());
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ArraySubscriptExprClass: {
|
|
|
|
// Array subscripts are potential references to data on the stack. We
|
|
|
|
// retrieve the DeclRefExpr* for the array variable if it indeed
|
|
|
|
// has local storage.
|
2007-08-21 00:18:38 +08:00
|
|
|
return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ConditionalOperatorClass: {
|
|
|
|
// For conditional operators we need to see if either the LHS or RHS are
|
|
|
|
// non-NULL DeclRefExpr's. If one is non-NULL, we return it.
|
|
|
|
ConditionalOperator *C = cast<ConditionalOperator>(E);
|
|
|
|
|
2007-12-01 03:04:31 +08:00
|
|
|
// Handle the GNU extension for missing LHS.
|
|
|
|
if (Expr *lhsExpr = C->getLHS())
|
|
|
|
if (DeclRefExpr *LHS = EvalVal(lhsExpr))
|
|
|
|
return LHS;
|
|
|
|
|
|
|
|
return EvalVal(C->getRHS());
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Accesses to members are potential references to data on the stack.
|
|
|
|
case Stmt::MemberExprClass: {
|
|
|
|
MemberExpr *M = cast<MemberExpr>(E);
|
|
|
|
|
|
|
|
// Check for indirect access. We only want direct field accesses.
|
|
|
|
if (!M->isArrow())
|
|
|
|
return EvalVal(M->getBase());
|
|
|
|
else
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Everything else: we simply don't reason about them.
|
|
|
|
default:
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
}
|
2007-11-25 08:58:00 +08:00
|
|
|
|
|
|
|
//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
|
|
|
|
|
|
|
|
/// Check for comparisons of floating point operands using != and ==.
|
|
|
|
/// Issue a warning if these are no self-comparisons, as they are not likely
|
|
|
|
/// to do what the programmer intended.
|
|
|
|
void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
|
|
|
|
bool EmitWarning = true;
|
|
|
|
|
2008-01-18 00:57:34 +08:00
|
|
|
Expr* LeftExprSansParen = lex->IgnoreParens();
|
2008-01-18 01:55:13 +08:00
|
|
|
Expr* RightExprSansParen = rex->IgnoreParens();
|
2007-11-25 08:58:00 +08:00
|
|
|
|
|
|
|
// Special case: check for x == x (which is OK).
|
|
|
|
// Do not emit warnings for such cases.
|
|
|
|
if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
|
|
|
|
if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
|
|
|
|
if (DRL->getDecl() == DRR->getDecl())
|
|
|
|
EmitWarning = false;
|
|
|
|
|
2007-11-29 08:59:04 +08:00
|
|
|
|
|
|
|
// Special case: check for comparisons against literals that can be exactly
|
|
|
|
// represented by APFloat. In such cases, do not emit a warning. This
|
|
|
|
// is a heuristic: often comparison against such literals are used to
|
|
|
|
// detect if a value in a variable has not changed. This clearly can
|
|
|
|
// lead to false negatives.
|
|
|
|
if (EmitWarning) {
|
|
|
|
if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
|
|
|
|
if (FLL->isExact())
|
|
|
|
EmitWarning = false;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
|
|
|
|
if (FLR->isExact())
|
|
|
|
EmitWarning = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-11-25 08:58:00 +08:00
|
|
|
// Check for comparisons with builtin types.
|
2009-01-19 08:08:26 +08:00
|
|
|
if (EmitWarning)
|
2007-11-25 08:58:00 +08:00
|
|
|
if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
|
2009-02-15 02:57:46 +08:00
|
|
|
if (CL->isBuiltinCall(Context))
|
2007-11-25 08:58:00 +08:00
|
|
|
EmitWarning = false;
|
|
|
|
|
2009-01-19 08:08:26 +08:00
|
|
|
if (EmitWarning)
|
2007-11-25 08:58:00 +08:00
|
|
|
if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
|
2009-02-15 02:57:46 +08:00
|
|
|
if (CR->isBuiltinCall(Context))
|
2007-11-25 08:58:00 +08:00
|
|
|
EmitWarning = false;
|
|
|
|
|
|
|
|
// Emit the diagnostic.
|
|
|
|
if (EmitWarning)
|
2008-11-19 13:08:23 +08:00
|
|
|
Diag(loc, diag::warn_floatingpoint_eq)
|
|
|
|
<< lex->getSourceRange() << rex->getSourceRange();
|
2007-11-25 08:58:00 +08:00
|
|
|
}
|