maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/ELF/wrap-no-real.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

35 lines
1.4 KiB
ArmAsm
Raw Normal View History

Refine our --wrap implementation. Before this patch we would copy foo into real_foo and wrap_foo into foo. The net result is that __wrap_foo shows up twice in the symbol table. With this patch we: * save a copy of __real_foo before copying foo. * drop one of the __wrap_foo from the symbol table. * if __real_foo was not undefined, add a *new* symbol with that content to the symbol table. The net result is that Anything using foo now uses __wrap_foo Anything using __real_foo now uses foo. Anything using __wrap_foo still does. And the symbol table has foo, __wrap_foo and __real_foo (if defined). Which I think is the desired behavior. llvm-svn: 315097
2017-10-07 04:09:34 +08:00
// REQUIRES: x86
// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t1.o
// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/wrap-no-real.s -o %t2.o
Correctly handle shared and lazy symbols. I will try to make this API a bit less error prone, but for now just get another test passing. llvm-svn: 315645
2017-10-13 08:06:38 +08:00
// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/wrap-no-real2.s -o %t3.o
[ELF][test] Fix wrap-no-real.s after D51283 Give %t3.so a DT_SONAME so that the DT_NEEDED entry in a dependent executable has a fixed length.
2020-05-28 08:42:35 +08:00
// RUN: ld.lld -o %t3.so -shared --soname=t3 %t3.o
Refine our --wrap implementation. Before this patch we would copy foo into real_foo and wrap_foo into foo. The net result is that __wrap_foo shows up twice in the symbol table. With this patch we: * save a copy of __real_foo before copying foo. * drop one of the __wrap_foo from the symbol table. * if __real_foo was not undefined, add a *new* symbol with that content to the symbol table. The net result is that Anything using foo now uses __wrap_foo Anything using __real_foo now uses foo. Anything using __wrap_foo still does. And the symbol table has foo, __wrap_foo and __real_foo (if defined). Which I think is the desired behavior. llvm-svn: 315097
2017-10-07 04:09:34 +08:00
// RUN: ld.lld -o %t %t1.o %t2.o -wrap foo
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
// RUN: llvm-objdump -d %t | FileCheck %s
// RUN: llvm-readelf -s -x .got %t | FileCheck --check-prefix=READELF --implicit-check-not=__real_ %s
Correctly handle shared and lazy symbols. I will try to make this API a bit less error prone, but for now just get another test passing. llvm-svn: 315645
2017-10-13 08:06:38 +08:00
[llvm-objdump] -d: print `00000000 <foo>:` instead of `00000000 foo:` The new behavior matches GNU objdump. A pair of angle brackets makes tests slightly easier. `.foo:` is not unique and thus cannot be used in a `CHECK-LABEL:` directive. Without `-LABEL`, the CHECK line can match the `Disassembly of section` line and causes the next `CHECK-NEXT:` to fail. ``` Disassembly of section .foo: 0000000000001634 .foo: ``` Bdragon: <> has metalinguistic connotation. it just "feels right" Reviewed By: rupprecht Differential Revision: https://reviews.llvm.org/D75713
2020-03-06 06:18:38 +08:00
// CHECK: <_start>:
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
// CHECK-NEXT: movq {{.*}}(%rip), %rax # 2021a8
// CHECK-NEXT: movq {{.*}}(%rip), %rbx # 2021a8
// CHECK-NEXT: movq {{.*}}(%rip), %rcx # 2021b0
Refine our --wrap implementation. Before this patch we would copy foo into real_foo and wrap_foo into foo. The net result is that __wrap_foo shows up twice in the symbol table. With this patch we: * save a copy of __real_foo before copying foo. * drop one of the __wrap_foo from the symbol table. * if __real_foo was not undefined, add a *new* symbol with that content to the symbol table. The net result is that Anything using foo now uses __wrap_foo Anything using __real_foo now uses foo. Anything using __wrap_foo still does. And the symbol table has foo, __wrap_foo and __real_foo (if defined). Which I think is the desired behavior. llvm-svn: 315097
2017-10-07 04:09:34 +08:00
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
// READELF: 0000000000011000 0 NOTYPE GLOBAL DEFAULT ABS foo
ELFObjectWriter: Don't sort non-local symbols As we don't sort local symbols, don't sort non-local symbols. This makes non-local symbols appear in their register order, which matches GNU as. The register order is nice in that you can write tests with interleaved CHECK prefixes, e.g. ``` // CHECK: something about foo .globl foo foo: // CHECK: something about bar .globl bar bar: ``` With the lexicographical order, the user needs to place lexicographical smallest symbol first or keep CHECK prefixes in one place.
2021-02-14 02:32:27 +08:00
// READELF: 0000000000011010 0 NOTYPE GLOBAL DEFAULT ABS __wrap_foo
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
// READELF: Hex dump of section '.got':
// READELF-NEXT: 0x[[#%x,ADDR:]] 10100100 00000000 00100100 00000000
Don't produce a duplicated __wrap_foo if there is no __real_foo. This fixes a regression from r317426. llvm-svn: 317956
2017-11-11 08:53:52 +08:00
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
// RUN: ld.lld -o %t2 %t1.o %t2.o %t3.so --wrap foo
// RUN: llvm-objdump -d %t2 | FileCheck --check-prefix=CHECK2 %s
// RUN: llvm-readelf -s -x .got %t2 | FileCheck --check-prefix=READELF --implicit-check-not=__real_ %s
Don't produce a duplicated __wrap_foo if there is no __real_foo. This fixes a regression from r317426. llvm-svn: 317956
2017-11-11 08:53:52 +08:00
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
// CHECK2: <_start>:
[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition This is a regression after D51283. Also, export `foo` if `__real_foo` is referenced by a shared object.
2020-06-02 13:57:43 +08:00
// CHECK2-NEXT: movq {{.*}}(%rip), %rax # 2022e0
// CHECK2-NEXT: movq {{.*}}(%rip), %rbx # 2022e0
// CHECK2-NEXT: movq {{.*}}(%rip), %rcx # 2022e8
Refine our --wrap implementation. Before this patch we would copy foo into real_foo and wrap_foo into foo. The net result is that __wrap_foo shows up twice in the symbol table. With this patch we: * save a copy of __real_foo before copying foo. * drop one of the __wrap_foo from the symbol table. * if __real_foo was not undefined, add a *new* symbol with that content to the symbol table. The net result is that Anything using foo now uses __wrap_foo Anything using __real_foo now uses foo. Anything using __wrap_foo still does. And the symbol table has foo, __wrap_foo and __real_foo (if defined). Which I think is the desired behavior. llvm-svn: 315097
2017-10-07 04:09:34 +08:00
.global _start
_start:
[ELF] --wrap: Drop __real_ symbol from the symbol table In D34993, we discussed and concluded that we should drop `__real_ symbol from the symbol table, but I did the opposite in D50569. This patch is to drop `__real_` symbol. MaskRay's note: omitting `__real_` is important if it is undefined: otherwise a subsequent link may error due to the undefined `__real_` in .dynsym Differential Revision: https://reviews.llvm.org/D51283
2020-05-28 07:18:55 +08:00
mov foo@gotpcrel(%rip), %rax
mov __wrap_foo@gotpcrel(%rip), %rbx
mov __real_foo@gotpcrel(%rip), %rcx