catch up on refactoring default destructors that were missed previously

lib/poems/fixedpoint.cpp

@@ -22,11 +22,6 @@
 
 using namespace std;
 
-FixedPoint::FixedPoint(){
-}
-FixedPoint::~FixedPoint(){
-}
-
 FixedPoint::FixedPoint(double x, double y, double z){
   position(1) = x;
   position(2) = y;

lib/poems/fixedpoint.h

@@ -24,8 +24,8 @@
 
 class FixedPoint : public Point  {
 public:
-  FixedPoint();
+  FixedPoint() = default;
-  ~FixedPoint();
+  ~FixedPoint() = default;
   FixedPoint(double x, double y, double z);
   FixedPoint(Vect3& v);
   PointType GetType();

lib/poems/mat3x3.cpp

@@ -24,8 +24,6 @@ using namespace std;
 Mat3x3::Mat3x3(){
   numrows = numcols = 3;
 }
-Mat3x3::~Mat3x3(){
-}
 
 Mat3x3::Mat3x3(const Mat3x3& A){
   numrows = numcols = 3;

lib/poems/mat3x3.h

@@ -30,7 +30,7 @@ class Mat3x3 : public VirtualMatrix  {
   double elements[3][3];
 public:
   Mat3x3();
-  ~Mat3x3();
+  ~Mat3x3() = default;
   Mat3x3(const Mat3x3& A);  // copy constructor
   Mat3x3(const VirtualMatrix& A);  // copy constructor
 

lib/poems/mat4x4.cpp

@@ -23,8 +23,6 @@ using namespace std;
 Mat4x4::Mat4x4(){
   numrows = numcols = 4;
 }
-Mat4x4::~Mat4x4(){
-}
 
 Mat4x4::Mat4x4(const Mat4x4& A){
   numrows = numcols = 4;

lib/poems/mat4x4.h

@@ -28,7 +28,7 @@ class Mat4x4 : public VirtualMatrix  {
   double elements[4][4];
 public:
   Mat4x4();
-  ~Mat4x4();
+  ~Mat4x4() = default;
   Mat4x4(const Mat4x4& A);  // copy constructor
   Mat4x4(const VirtualMatrix& A);  // copy constructor
 

lib/poems/mat6x6.cpp

@@ -23,8 +23,6 @@ using namespace std;
 Mat6x6::Mat6x6(){
   numrows = numcols = 6;
 }
-Mat6x6::~Mat6x6(){
-}
 
 Mat6x6::Mat6x6(const Mat6x6& A){
   numrows = numcols = 6;

lib/poems/mat6x6.h

@@ -29,7 +29,7 @@ class Mat6x6 : public VirtualMatrix  {
   double elements[6][6];
 public:
   Mat6x6();
-  ~Mat6x6();
+  ~Mat6x6() = default;
   Mat6x6(const Mat6x6& A);  // copy constructor
   Mat6x6(const VirtualMatrix& A);  // copy constructor
 

lib/poems/vect3.cpp

@@ -23,8 +23,6 @@ using namespace std;
 Vect3::Vect3(){
   numrows = 3; numcols = 1;
 }
-Vect3::~Vect3(){
-}
 
 Vect3::Vect3(const Vect3& A){  // copy constructor
   numrows = 3; numcols = 1;

lib/poems/vect3.h

@@ -30,7 +30,7 @@ class Vect3 : public VirtualColMatrix  {
   double elements[3];
 public:
   Vect3();
-  ~Vect3();
+  ~Vect3() = default;
   Vect3(const Vect3& A);  // copy constructor
   Vect3(const VirtualMatrix& A);  // copy constructor
 

lib/poems/vect4.cpp

@@ -23,8 +23,6 @@ using namespace std;
 Vect4::Vect4(){
   numrows = 4; numcols = 1;
 }
-Vect4::~Vect4(){
-}
 
 Vect4::Vect4(const Vect4& A){  // copy constructor
   numrows = 4; numcols = 1;

lib/poems/vect4.h

@@ -28,7 +28,7 @@ class Vect4 : public VirtualColMatrix  {
   double elements[4];
 public:
   Vect4();
-  ~Vect4();
+  ~Vect4() = default;
   Vect4(const Vect4& A);  // copy constructor
   Vect4(const VirtualMatrix& A);  // copy constructor
 

lib/poems/vect6.cpp

@@ -23,8 +23,6 @@ using namespace std;
 Vect6::Vect6(){
   numrows = 6; numcols = 1;
 }
-Vect6::~Vect6(){
-}
 
 Vect6::Vect6(const Vect6& A){  // copy constructor
   numrows = 6; numcols = 1;

lib/poems/vect6.h

@@ -29,7 +29,7 @@ class Vect6 : public VirtualColMatrix  {
   double elements[6];
 public:
   Vect6();
-  ~Vect6();
+  ~Vect6() = default;
   Vect6(const Vect6& A);  // copy constructor
   Vect6(const VirtualMatrix& A);  // copy constructor
 

lib/poems/virtualcolmatrix.cpp

@@ -25,9 +25,6 @@ VirtualColMatrix::VirtualColMatrix(){
   numcols = 1;
 }
 
-VirtualColMatrix::~VirtualColMatrix(){
-}
-
 double& VirtualColMatrix::operator_2int(int i, int j){
   if(j!=1){
     cerr << "matrix index invalid in operator ()" << endl;

lib/poems/virtualcolmatrix.h

@@ -25,7 +25,7 @@
 class VirtualColMatrix : public VirtualMatrix  {
 public:
         VirtualColMatrix();
-        ~VirtualColMatrix();
+        ~VirtualColMatrix() = default;
         double& operator_2int (int i, int j); // array access
         double Get_2int (int i, int j) const;
         void Set_2int (int i, int j, double value);

lib/poems/virtualmatrix.cpp

@@ -26,8 +26,7 @@ VirtualMatrix::VirtualMatrix(){
   numrows = numcols = 0;
 }
 
-VirtualMatrix::~VirtualMatrix(){
+VirtualMatrix::~VirtualMatrix()= default;
-}
 
 int VirtualMatrix::GetNumRows() const {
   return numrows;

lib/poems/virtualrowmatrix.cpp

@@ -26,9 +26,6 @@ VirtualRowMatrix::VirtualRowMatrix(){
   numrows = 1;
 }
 
-VirtualRowMatrix::~VirtualRowMatrix(){
-}
-
 double& VirtualRowMatrix::operator_2int (int i, int j){
   if(i!=1){
     cerr << "matrix index invalid in operator ()" << endl;

lib/poems/virtualrowmatrix.h

@@ -24,7 +24,7 @@
 class VirtualRowMatrix : public VirtualMatrix  {
 public:
   VirtualRowMatrix();
-  ~VirtualRowMatrix();
+  ~VirtualRowMatrix() = default;
   double& operator_2int (int i, int j); // array access
   double Get_2int(int i, int j) const;
   void Set_2int(int i, int j, double value);

src/MACHDYN/fix_smd_move_triangulated_surface.cpp

@@ -215,15 +215,6 @@ FixSMDMoveTriSurf::FixSMDMoveTriSurf(LAMMPS *lmp, int narg, char **arg) :
 
 /* ---------------------------------------------------------------------- */
 
-FixSMDMoveTriSurf::~FixSMDMoveTriSurf()
-{
-  // unregister callbacks to this fix from Atom class
-  //atom->delete_callback(id,Atom::GROW);
-  //atom->delete_callback(id,Atom::RESTART);
-}
-
-/* ---------------------------------------------------------------------- */
-
 int FixSMDMoveTriSurf::setmask() {
         int mask = 0;
         mask |= INITIAL_INTEGRATE;

src/MACHDYN/fix_smd_move_triangulated_surface.h

@@ -39,7 +39,7 @@ namespace LAMMPS_NS {
 class FixSMDMoveTriSurf : public Fix {
  public:
   FixSMDMoveTriSurf(class LAMMPS *, int, char **);
-  ~FixSMDMoveTriSurf();
+  ~FixSMDMoveTriSurf() = default;
   int setmask();
   virtual void init();
   virtual void initial_integrate(int);

src/OPENMP/thr_omp.cpp

@@ -53,13 +53,6 @@ ThrOMP::ThrOMP(LAMMPS *ptr, int style)
   fix = static_cast<FixOMP *>(lmp->modify->fix[ifix]);
 }
 
-/* ---------------------------------------------------------------------- */
-
-ThrOMP::~ThrOMP()
-{
-  // nothing to do?
-}
-
 /* ----------------------------------------------------------------------
    Hook up per thread per atom arrays into the tally infrastructure
    ---------------------------------------------------------------------- */

src/OPENMP/thr_omp.h

@@ -46,7 +46,7 @@ class ThrOMP {
 
  public:
   ThrOMP(LAMMPS *, int);
-  virtual ~ThrOMP();
+  virtual ~ThrOMP() = default;
 
   double memory_usage_thr();
 

unittest/fortran/wrap_commands.cpp

@@ -21,8 +21,8 @@ double f_lammps_get_natoms();
 class LAMMPS_commands : public ::testing::Test {
 protected:
     LAMMPS_NS::LAMMPS *lmp;
-    LAMMPS_commands(){};
+    LAMMPS_commands()           = default;
-    ~LAMMPS_commands() override{};
+    ~LAMMPS_commands() override = default;
 
     void SetUp() override
     {