jasder
/
moby
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
24,918 Commits 10 Branches 339 Tags 274 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Antonio Murdaca 7d22887b2c pkg: chrootarchive: chroot_linux: fix mount leak 
When pivot_root fails we need to unmount the bind mounted path we
previously mounted in preparation for pivot_root.

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
 2016-06-11 00:07:41 +02:00
Antonio Murdaca 5248f5c3d1 pkg: chrootarchive: chroot_linux: fix docker build 
The path we're trying to remove doesn't exist after a successful
chroot+chdir because a / is only appended after pivot_root is
successful and so we can't cleanup anymore with the old path.
Also fix leaking .pivot_root dirs under /var/lib/docker/tmp/docker-builder*
on error.

Fix https://github.com/docker/docker/issues/22587
Introduced by https://github.com/docker/docker/pull/22506

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
 2016-05-10 00:42:49 +02:00
Brian Goff 85988b33d2 Use pivot_root instead of chroot for chrootarchive 
This fixes one issue with Docker running under a grsec kernel, which
denies chmod and mknod under chroot.

Note, if pivot_root fails it will still fallback to chroot.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
 2016-05-04 19:55:34 -04:00