linux-sg2042/net/atm
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
Kconfig [ATM]: atm is no longer experimental 2008-01-28 15:00:11 -08:00
Makefile [ATM]: Kill ipcommon.[ch] 2006-12-02 21:32:08 -08:00
addr.c atm: use const where reasonable 2008-06-17 16:20:06 -07:00
addr.h atm: use const where reasonable 2008-06-17 16:20:06 -07:00
atm_misc.c [ATM]: atm_pcr_goal() doesn't modify its argument's contents -- mark it as const 2005-11-29 16:13:55 -08:00
atm_sysfs.c net: struct device - replace bus_id with dev_name(), dev_set_name() 2008-11-10 13:55:14 -08:00
br2684.c br2684: convert to net_device_ops 2009-01-21 14:01:59 -08:00
clip.c atm: convert clip driver to net_device_ops 2009-03-21 19:19:12 -07:00
common.c atm: use const where reasonable 2008-06-17 16:20:06 -07:00
common.h atm: 32-bit ioctl compatibility 2008-12-03 22:12:38 -08:00
ioctl.c atm: 32-bit ioctl compatibility 2008-12-03 22:12:38 -08:00
lec.c atm: lec use dev_change_mtu 2009-03-21 13:37:28 -07:00
lec.h lec: convert to internal network_device_stats 2009-01-21 14:02:00 -08:00
lec_arpc.h [ATM]: [lec] add reference counting to lec_arp entries 2006-09-29 17:16:48 -07:00
mpc.c atm: convert mpc device to using netdev_ops 2009-03-21 19:19:12 -07:00
mpc.h atm: convert mpc device to using netdev_ops 2009-03-21 19:19:12 -07:00
mpoa_caches.c net: replace NIPQUAD() in net/*/ 2008-10-31 00:54:56 -07:00
mpoa_caches.h [NET] ATM: Fix whitespace errors. 2007-02-10 23:19:16 -08:00
mpoa_proc.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
pppoatm.c [ATM]: Replace DPRINTK() with pr_debug(). 2007-10-10 16:48:27 -07:00
proc.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
protocols.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pvc.c atm: 32-bit ioctl compatibility 2008-12-03 22:12:38 -08:00
raw.c [ATM]: Replace DPRINTK() with pr_debug(). 2007-10-10 16:48:27 -07:00
resources.c atm: 32-bit ioctl compatibility 2008-12-03 22:12:38 -08:00
resources.h atm: 32-bit ioctl compatibility 2008-12-03 22:12:38 -08:00
signaling.c [NET]: sparse warning fixes 2007-10-10 16:54:48 -07:00
signaling.h [NET] ATM: Fix whitespace errors. 2007-02-10 23:19:16 -08:00
svc.c Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2008-12-05 22:54:40 -08:00