linux-sg2042/drivers/net/bonding
Andy Gospodarek ce39a800ea bonding: fix panic when taking bond interface down before removing module
A panic was discovered with bonding when using mode 5 or 6 and trying to
remove the slaves from the bond after the interface was taken down.
When calling 'ifconfig bond0 down' the following happens:

    bond_close()
        bond_alb_deinitialize()
            tlb_deinitialize()
		kfree(bond_info->tx_hashtbl)
                bond_info->tx_hashtbl = NULL

Unfortunately if there are still slaves in the bond, when removing the
module the following happens:

    bonding_exit()
        bond_free_all()
            bond_release_all()
                bond_alb_deinit_slave()
                    tlb_clear_slave()
                        tx_hash_table = BOND_ALB_INFO(bond).tx_hashtbl
			u32 next_index = tx_hash_table[index].next

As you might guess we panic when trying to access a few entries into the
table that no longer exists.

I experimented with several options (like moving the calls to
tlb_deinitialize somewhere else), but it really makes the most sense to
be part of the bond_close routine.  It also didn't seem logical move
tlb_clear_slave around too much, so the simplest option seems to add a
check in tlb_clear_slave to make sure we haven't already wiped the
tx_hashtbl away before searching for all the non-existent hash-table
entries that used to point to the slave as the output interface.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
2008-10-31 00:46:12 -04:00
..
Makefile [PATCH] bonding: add sysfs functionality to bonding (large) 2005-11-13 14:48:21 -05:00
bond_3ad.c bonding: refactor mii monitor 2008-08-07 03:59:53 -04:00
bond_3ad.h Convert bonding timers to workqueues 2007-10-23 20:32:00 -04:00
bond_alb.c bonding: fix panic when taking bond interface down before removing module 2008-10-31 00:46:12 -04:00
bond_alb.h Convert bonding timers to workqueues 2007-10-23 20:32:00 -04:00
bond_main.c bonding: Clean up resource leaks 2008-10-31 00:46:04 -04:00
bond_sysfs.c bonding: Don't destroy bonding master when removing slave via sysfs 2008-08-07 03:59:56 -04:00
bonding.h drivers/net/bonding: sparse fixes for exported tables 2008-09-24 22:12:57 -04:00