hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
linux-sg2042/drivers/bcma
History
Paul Gortmaker 58f743ee06 bcma: fix build error on MIPS; implicit pcibios_enable_device 
The following is seen during allmodconfig builds for MIPS:

drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1

Most likey introduced by commit 49dc957715

    "bcma: add PCIe host controller"

Add the header instead of implicitly assuming it will be present.
Sounds like a good idea, but that alone doesn't fix anything.

The real problem is that the Kconfig has settings related to whether
PCI is possible, i.e.

  config BCMA_HOST_PCI_POSSIBLE
        bool
        depends on BCMA && PCI = y
        default y

  config BCMA_HOST_PCI
        bool "Support for BCMA on PCI-host bus"
        depends on BCMA_HOST_PCI_POSSIBLE

...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
have any dependencies on the above.  Add one.

CC: Hauke Mehrtens <hauke@hauke-m.de>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
 		2012-04-10 14:13:30 -04:00
..
Kconfig bcma: fix build error on MIPS; implicit pcibios_enable_device 2012-04-10 14:13:30 -04:00
Makefile bcma: add mips driver 2011-08-08 14:29:26 -04:00
README bcma: add Broadcom specific AMBA bus driver 2011-05-10 15:54:54 -04:00
TODO bcma: add Broadcom specific AMBA bus driver 2011-05-10 15:54:54 -04:00
bcma_private.h bcma: add PCIe host controller 2012-02-06 14:53:04 -05:00
core.c bcma: fix implicit use of export.h contents 2011-10-31 19:32:02 -04:00
driver_chipcommon.c bcma: fix implicit use of export.h contents 2011-10-31 19:32:02 -04:00
driver_chipcommon_pmu.c bcma: silence PMU warning for BCM4331 2012-03-07 13:56:37 -05:00
driver_mips.c bcma: get CPU clock 2011-08-08 14:29:29 -04:00
driver_pci.c bcma: add PCIe host controller 2012-02-06 14:53:04 -05:00
driver_pci_host.c bcma: fix build error on MIPS; implicit pcibios_enable_device 2012-04-10 14:13:30 -04:00
host_pci.c bcma: make some functions __devinit 2012-02-06 14:53:03 -05:00
host_soc.c bcma: add SOC bus 2011-08-08 14:29:25 -04:00
main.c bcma: export bcma_find_core 2012-03-05 15:20:50 -05:00
scan.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2012-02-15 16:24:37 -05:00
scan.h bcma: add Broadcom specific AMBA bus driver 2011-05-10 15:54:54 -04:00
sprom.c bcma: add support for on-chip OTP memory used for SPROM storage 2012-03-06 15:16:18 -05:00

README 

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.