4fb44dd2c1
In snd_sb_qsound_build, snd_ctl_add(..,p->qsound_switch...) and snd_ctl_add(..,p->qsound_space..) are called. But the second arguments of snd_ctl_add() could be freed via snd_ctl_add_replace() ->snd_ctl_free_one(). After the error code is returned, snd_sb_qsound_destroy(p) is called in __error branch. But in snd_sb_qsound_destroy(), the freed p->qsound_switch and p->qsound_space are still used by snd_ctl_remove(). My patch set p->qsound_switch and p->qsound_space to NULL if snd_ctl_add() failed to avoid the uaf bugs. But these codes need to further be improved with the code style. Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210426145541.8070-1-lyl2019@mail.ustc.edu.cn Signed-off-by: Takashi Iwai <tiwai@suse.de> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| emu8000.c | ||
| emu8000_callback.c | ||
| emu8000_local.h | ||
| emu8000_patch.c | ||
| emu8000_pcm.c | ||
| emu8000_synth.c | ||
| jazz16.c | ||
| sb8.c | ||
| sb8_main.c | ||
| sb8_midi.c | ||
| sb16.c | ||
| sb16_csp.c | ||
| sb16_main.c | ||
| sb_common.c | ||
| sb_mixer.c | ||
| sbawe.c | ||