linux-sg2042/fs/partitions
Nikanth Karthikesan 316d315bff block: Seperate read and write statistics of in_flight requests v2
Commit a9327cac44 added seperate read
and write statistics of in_flight requests. And exported the number
of read and write requests in progress seperately through sysfs.

But  Corrado Zoccolo <czoccolo@gmail.com> reported getting strange
output from "iostat -kx 2". Global values for service time and
utilization were garbage. For interval values, utilization was always
100%, and service time is higher than normal.

So this was reverted by commit 0f78ab9899

The problem was in part_round_stats_single(), I missed the following:
        if (now == part->stamp)
                return;

-       if (part->in_flight) {
+       if (part_in_flight(part)) {
                __part_stat_add(cpu, part, time_in_queue,
                                part_in_flight(part) * (now - part->stamp));
                __part_stat_add(cpu, part, io_ticks, (now - part->stamp));

With this chunk included, the reported regression gets fixed.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>

--
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
2009-10-06 20:16:55 +02:00
..
Kconfig partition: use DEFAULT_SGI_PARTITION for SGI_PARTION default 2008-02-06 10:41:08 -08:00
Makefile partition: add support for sysv68 partitions 2007-05-08 11:15:09 -07:00
acorn.c fs/partitions/acorn.c: remove dead code 2008-10-16 11:21:47 -07:00
acorn.h
amiga.c [PATCH] Fix check_partition routines 2006-12-07 08:39:30 -08:00
amiga.h
atari.c [PATCH] Fix check_partition routines 2006-12-07 08:39:30 -08:00
atari.h
check.c block: Seperate read and write statistics of in_flight requests v2 2009-10-06 20:16:55 +02:00
check.h block: replace @ext_minors with GENHD_FL_EXT_DEVT 2008-10-09 08:56:08 +02:00
efi.c fs/partitions/efi: convert to pr_debug 2008-07-25 10:53:44 -07:00
efi.h Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ibm.c block: Do away with the notion of hardsect_size 2009-05-22 23:22:54 +02:00
ibm.h
karma.c [PATCH] partitions: Read Rio Karma partition table 2006-01-16 23:15:29 -08:00
karma.h [PATCH] partitions: Read Rio Karma partition table 2006-01-16 23:15:29 -08:00
ldm.c fs: ldm.[ch] use get_unaligned_* helpers 2008-07-25 10:53:26 -07:00
ldm.h fs: ldm.[ch] use get_unaligned_* helpers 2008-07-25 10:53:26 -07:00
mac.c [PATCH] Enable RAID autorun on Mac partition tables. 2006-12-04 08:36:37 -08:00
mac.h
msdos.c block: Do away with the notion of hardsect_size 2009-05-22 23:22:54 +02:00
msdos.h
osf.c
osf.h
sgi.c [PARTITION]: Add whole_disk attribute. 2007-02-10 23:50:00 -08:00
sgi.h
sun.c fs/partitions/sun.c endianness annotations 2007-10-14 12:41:51 -07:00
sun.h [PARTITION]: Sun/Solaris VTOC table corrections 2007-07-30 00:27:31 -07:00
sysv68.c partition: add support for sysv68 partitions 2007-05-08 11:15:09 -07:00
sysv68.h partition: add support for sysv68 partitions 2007-05-08 11:15:09 -07:00
ultrix.c fs/partitions/ultrix.c should #include "ultrix.h" 2005-11-08 16:49:14 +01:00
ultrix.h