linux-sg2042/drivers/isdn
Matthias Goebl 7fde4d779b [ISDN]: i4l: Fix DLE handling for i4l-audio
The DLE handling in i4l-audio seems to be broken.

It produces spurious DLEs so asterisk 1.2.24 with chan_modem_i4l
gets irritated, the error message is:
"chan_modem_i4l.c:450 i4l_read: Value of escape is ^ (17)".
-> There shouldn't be a DLE-^.
If a spurious DLE-ETX occurs, the audio connection even dies.
I use a "AVM Fritz!PCI" isdn card.

I found two issues that only appear if ISDN_AUDIO_SKB_DLECOUNT(skb) > 0:
- The loop in isdn_tty.c:isdn_tty_try_read() doesn't escape a DLE if it's
  the last character.

- The loop in isdn_common.c:isdn_readbchan_tty() doesn't copy its characters,
  it only remembers the last one ("last = *p;").

  Compare it with the loop in isdn_common.c:isdn_readbchan(), that *does*
  copy them ("*cp++ = *p;") correctly.
  The special handling of the "last" character made it more difficult.
  I compared it to linux-2.4.19: There was no "last"-handling and both loops
  did escape and copy all characters correctly.

Signed-off-by: Matthias Goebl <matthias.goebl@goebl.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-01-04 03:55:44 -08:00
..
act2000 isdn/act2000: fix major bug. clean irq handler. 2007-10-23 19:53:16 -04:00
capi [ISDN] capidrv: address two longstanding warnings 2007-10-29 04:45:06 -04:00
divert [NET]: Make /proc/net per network namespace 2007-10-10 16:49:06 -07:00
gigaset Add missing newlines to some uses of dev_<level> messages 2007-10-18 14:37:28 -07:00
hardware Spelling fix: explicitly 2007-10-19 23:22:55 +02:00
hisax isdn: bootup crash fix 2007-11-29 09:24:53 -08:00
hysdn [ISDN] hysdn: convert to PCI hotplug API 2007-10-12 09:14:49 -04:00
i4l [ISDN]: i4l: Fix DLE handling for i4l-audio 2008-01-04 03:55:44 -08:00
icn Use menuconfig objects - CONFIG_ISDN_I4L 2007-07-21 17:49:17 -07:00
isdnloop ISDN: Spinlock initializer cleanup 2007-05-08 11:15:17 -07:00
pcbit Convert files to UTF-8 and some cleanups 2007-10-19 23:21:04 +02:00
sc [ISDN] sc: Really, really fix warning 2007-11-14 15:59:43 -08:00
Kconfig Use menuconfig objects: ISDN 2007-07-21 17:49:17 -07:00
Makefile [PATCH] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles 2006-03-26 08:57:05 -08:00