Javier Martinez Canillas 2f632369ab modpost: don't add a trailing wildcard for OF module aliases ... Commit ac55182899 ("modpost: i2c aliases need no trailing wildcard") removed the wildcard at the end of the I2C module aliases because I2C devices have no IDs so the aliases are just arbitrary device names. This is also true for OF modaliases since a compatible string is used to define a specific IP hardware block. So the modalias should match a specific compatible string and not attempt to match a compatible string whose name matches the beginning of another one. For example, the following driver module: $ modinfo cros_ec_keyb | grep alias alias: platform:cros-ec-keyb alias: of:N*T*Cgoogle,cros-ec-keyb* will be tried to be loaded for an alias of:N*T*Cgoogle,cros-ec-keyb-v2 but there could be a different driver that supports the device for that compatible string so it's better to remove the trailing wildcard for OF. Also, remove the word "always" from the add_wildcard() function comment since that was carried from the time where a wildcard was always added at the end of the module alias for all the devices. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Suggested-by: Brian Norris <computersforpeace@gmail.com> Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2016-01-14 16:00:49 -08:00
..
.gitignore	kbuild: trivial - remove trailing empty lines	2014-06-10 00:04:06 +02:00
Makefile	improve modalias building	2013-06-28 00:48:16 +02:00
devicetable-offsets.c	sound updates for 4.4-rc1	2015-11-06 11:04:07 -08:00
empty.c	Linux-2.6.12-rc2	2005-04-16 15:20:36 -07:00
file2alias.c	modpost: don't add a trailing wildcard for OF module aliases	2016-01-14 16:00:49 -08:00
mk_elfconfig.c	kbuild: trivial - remove trailing empty lines	2014-06-10 00:04:06 +02:00
modpost.c	scripts: [modpost] add new sections to white list	2015-10-26 20:38:43 +10:30
modpost.h	Avoid conflict with host definitions when cross-compiling	2015-08-20 14:55:54 +02:00
sumversion.c	kbuild: trivial - use tabs for code indent where possible	2014-06-10 14:00:53 +02:00